@nomac/cli 0.9.0 → 0.9.1

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nomac/cli",
-  "version": "0.9.0",
+  "version": "0.9.1",
   "description": "Cloud Mac sessions over SSH and HTTPS, plus iOS builds and publishing — built for agents.",
   "license": "UNLICENSED",
   "type": "module",

package/src/human-steps.mjs

@@ -0,0 +1,13 @@
+/** Steps only a person can take, from an answer's needs_human, as numbered lines with the link last. */
+export function humanSteps(details) {
+  const human = details?.needs_human;
+  if (!human) return [];
+  return [...(human.steps ?? []).map((step, index) => `  ${index + 1}. ${step}`), ...(human.url ? [`  ${human.url}`] : [])];
+}
+
+/** An API error that needs a person: its message followed by the steps. */
+export function withHumanSteps(error) {
+  const steps = humanSteps(error?.details);
+  if (steps.length) error.friendly = [error.friendly, ...steps].join("\n");
+  return error;
+}

package/src/sign.mjs

@@ -1,5 +1,6 @@
 import { parseArgs } from "node:util";
 import { api as defaultApi, CliError } from "./api.mjs";
+import { withHumanSteps } from "./human-steps.mjs";
 
 export const SIGN_HELP = `Usage: nomac sign [path] [--scheme NAME] [--container PATH] [--team ISSUER_ID] [--session ses_…] [--json]
 Set up App Store signing for the project on this folder's Mac (path: the project folder
@@ -17,7 +18,9 @@ export async function signCommand(args, { api = defaultApi, print = console.log,
   const session = values.session ?? store?.load()?.id;
   if (!session || !/^ses_[A-Za-z0-9_-]{1,80}$/.test(session)) throw new CliError("no Mac", "No Mac for this folder. Start one with nomac start and sync the project (nomac sync .), or pass --session ses_….");
   const body = { ...(positionals[0] ? { path: positionals[0] } : {}), ...(values.scheme ? { scheme: values.scheme } : {}), ...(values.container ? { container: values.container } : {}), ...(values.team ? { issuer_id: values.team } : {}) };
-  const result = await api("POST", `/api/v1/mac/sessions/${encodeURIComponent(session)}/signing`, { body });
+  let result;
+  try { result = await api("POST", `/api/v1/mac/sessions/${encodeURIComponent(session)}/signing`, { body }); }
+  catch (error) { throw values.json ? error : withHumanSteps(error); }
   if (values.json) { print(JSON.stringify(result, null, 2)); return result; }
   print([
     `Signing set up for ${result.project.scheme} (${result.project.container}), Apple team ${result.team_id}, with ${result.identity.name}.`,

package/src/testflight.mjs

@@ -1,6 +1,7 @@
 import { randomUUID } from "node:crypto";
 import { parseArgs } from "node:util";
 import { api as defaultApi, CliError } from "./api.mjs";
+import { humanSteps, withHumanSteps } from "./human-steps.mjs";
 
 export const TESTFLIGHT_HELP = `Usage: nomac testflight <ipa> [--notes TEXT] [--encryption no|yes] [--team ISSUER_ID] [--session ses_…] [--no-wait] [--json]
        nomac testflight --id tfu_…
@@ -15,12 +16,6 @@ needed, and NoMac puts it on TestFlight for your internal testers.
 
 const DONE = new Set(["on_testflight", "failed"]);
 
-/** Steps a person must take, from an error's needs_human. */
-function humanSteps(details) {
-  const human = details?.needs_human;
-  if (!human) return [];
-  return [...(human.steps ?? []).map((step, index) => `  ${index + 1}. ${step}`), ...(human.url ? [`  ${human.url}`] : [])];
-}
 
 function describe(view) {
   const app = `${view.app.bundle_id} ${view.app.version} (${view.app.build_number})`;
@@ -29,7 +24,8 @@ function describe(view) {
     case "processing": return `Apple has ${app} and is processing it (usually 5 to 15 minutes; no Mac needed).${view.waiting_for ? `\n  Waiting for: ${view.waiting_for}` : ""}\n  Stopping this wait does not stop it: follow it later with nomac testflight --id ${view.id}`;
     case "on_testflight": return `On TestFlight: ${app}. Internal testers can install it from the TestFlight app.\n  ${view.url}\n  ${view.app.platform === "IOS"
       ? `To submit it for App Review: nomac publish --project ${view.project_id} --build ${view.build_id}` : "Submit it for App Review in App Store Connect."}`;
-    case "failed": return [`Not sent: ${view.error?.message ?? "the send failed."}`, ...humanSteps(view.error)].join("\n");
+    // With a build_id, Apple had the file and refused it while processing; without one, it never reached Apple.
+    case "failed": return [`${view.build_id ? "Apple did not accept the build" : "Not sent"}: ${view.error?.message ?? "the send failed."}`, ...humanSteps(view.error)].join("\n");
     default: return `${app}: ${view.state}`;
   }
 }
@@ -61,7 +57,7 @@ export async function testflightCommand(args, { api = defaultApi, print = consol
       if (error.code === "encryption_answer_required") {
         error.friendly = `${error.details.question}\nAsk the person who owns the app, then run this again with --encryption no or --encryption yes. NoMac remembers the answer for this app. Most apps answer no.`;
       } else if (error.code === "needs_human") {
-        error.friendly = [error.friendly, ...humanSteps(error.details)].join("\n");
+        withHumanSteps(error);
       }
       throw error;
     }