@nolit/dsh-notify 0.0.1-rc.3 → 0.0.1-rc.4

package/CHANGELOG.md

@@ -11,7 +11,7 @@ summary: Engineering history for Notify for Chrome (formerly DSH Notify Web). Se
 > History lives here (owner instruction 2026-11-04). Boot cards and `AGENTS.md` are narrowed to
 > the owner's unfinished asks; they are not a changelog. See `docs/RULES.md` §6.1 in the `dsh-plugins` workspace.
 
-Current version: `0.0.1-rc.3`
+Current version: `0.0.1-rc.4`
 
 ## Seeded history (from git, before this file existed)
 
@@ -97,6 +97,32 @@ Not changed, and why: `docs/` still contains absolute paths (`/home/minami` ×2,
 of the defects being reported, so removing them would destroy the record. Runtime
 code (`lib/`, `scripts/`, `locale/`, `market/`) has **zero** absolute paths.
 
+### 2026-11-07 — `0.0.1-rc.4` — the chip actually renders
+
+Owner decision (translated): *"The rename back to the original name is settled, and so is the
+version. Stop treating the older versions as live: the current state is canonical and the path
+changed. The only part you may change is the number after `rc`, so make it `rc.4` and publish
+through the deploy harness."*
+
+`0.0.1-rc.3` was published to npm and GitHub with a defect that made the peak chip dead. This
+release is the corrected build.
+
+| Surface | `0.0.1-rc.3` (published) | `0.0.1-rc.4` |
+| :--- | :--- | :--- |
+| Peak chip | slot registered, **never painted** (`ReferenceError: doc is not defined` on every render) | renders |
+| Engine id | `0.0.1-rc.3` | `0.0.1-rc.4` |
+
+**Root cause.** `makePeakChip` is a UI adapter outside `createNotifyCore`, so the core's `doc`
+binding was out of scope. Registration succeeded, which is why the failure was invisible: the slot
+simply rendered nothing. Fixed by resolving the document from the browser global inside the
+component. Full detail is in the 2026-11-07 entry below.
+
+**Verification.** `npm test` 70/70, including a new regression test that renders the registered
+component and asserts it does not throw. `0.0.1-rc.3` is superseded; it is not a valid install
+target.
+
+Owner-stated version form: **`0.0.1.rc4`**.
+
 ### 2026-11-06 — `0.0.1-rc.3` — 7-segment peak countdown chip
 
 Owner instruction (translated): *"If the window cannot be force-promoted, strengthen the in-app UI.
@@ -140,7 +166,7 @@ Owner decisions in the same turn:
 | Destination slot | none | `conversation.session.header.utilities` (list) | `cordis_inspect_query` live occupancy |
 | Settings keys | 8 | 11 | `DEFAULT_SETTINGS`, `cordis.patch.yml` |
 | Locale keys | 74 per language | 99 per language | `locale/en.json`, `locale/ko.json` |
-| Tests | 51 | 69 | `npm test` |
+| Tests | 51 | 70 | `npm test` |
 | Version | `0.0.1-rc.2` | `0.0.1-rc.3` | `package.json`, `market/index.json` |
 
 #### Bug fix — route gate (owner report, same session)
@@ -296,9 +322,40 @@ Chrome would be worse than a documented recommendation.
 | privacy list omitted the holiday cache | now lists all three `localStorage` keys |
 | limitations implied notifications degrade transparently | now names the silent-drop cases |
 
+#### Bug fix — the chip never rendered (`ReferenceError: doc is not defined`)
+
+Owner report: *"why is your plugin not working?"* Measured after the DeepSeek sign-in was repaired.
+
+The plugin was mounted correctly (`--dump-config` shows the `notify` row with every setting), the
+build was current, and the slot registered. The chip still never appeared.
+
+**Cause.** `makePeakChip` is a UI adapter that lives *outside* `createNotifyCore`. The `doc`
+binding it referenced belongs to the core closure (line 456), so it was out of scope in the
+component. Every render threw:
+
+```
+ReferenceError: doc is not defined
+```
+
+Registration succeeded, so nothing looked broken from the outside — the slot simply painted
+nothing. **Registering is not rendering**, and the post-rc.3 rename (`@nolit/dsh-notify-web` ->
+`@nolit/dsh-notify`, commit `eabc41e`) carried the defect forward unchanged.
+
+**Fix.** The component resolves the document from the browser global itself
+(`typeof document === 'undefined' ? undefined : document`), which is correct for a UI adapter, and
+passes it to `readActiveProvider` / `watchActiveProvider`. The three core-side call sites
+(`peakAnnounce`, `syncBadge`) were already inside the closure and are unchanged.
+
+**Regression test added** so this cannot recur silently: it runs `apply()`, takes the component out
+of the registered slot, calls it, and asserts it does not throw. The previous suite asserted *which
+slot registered*, never that the component survives a render — which is exactly why the bug passed
+69 tests.
+
+`npm test` -> **70/70 pass**.
+
 #### Verification
 
-`npm test` → **69/69 pass**. The new suite re-runs the published spec §5 table and asserts case #7
+`npm test` → **70/70 pass**. The new suite re-runs the published spec §5 table and asserts case #7
 now expects `false` (makeup workday off-peak), plus the fixed UTC windows, the Beijing-day boundary,
 malformed-payload rejection, the 8-day next-change scan, `HH:MM:SS` clamping, and that the rendered
 SVG carries token colours only.

package/README.md

@@ -8,13 +8,39 @@ updated: 2026-11-05
 summary: Operator manual and behavior contract for Notify for Chrome (Korean: 알림 for 크롬) — Chrome/Web Notification only, silent in-app toast fallback, native DSH settings rows and typography, Windows/install-mode notification branches.
 -->
 
-> Status: active · Updated: 2026-11-06 · Package: `@nolit/dsh-notify` v`0.0.1-rc.3` · Korean display name: **알림 for 크롬** · Parent: `README.md` in the `dsh-plugins` workspace
+> Status: active · Updated: 2026-11-07 · Package: `@nolit/dsh-notify` v`0.0.1-rc.4` · Korean display name: **알림 for 크롬** · Parent: `README.md` in the `dsh-plugins` workspace
 
 **Notify for Chrome** turns DeepSeek Harness events into **Chrome notifications** (the Web
 Notification API, `new Notification(...)`). It has no native app, no ports, no IPC, no file queue
 and no system notifier. When Chrome cannot show a notification, the plugin falls back to a
 **silent in-app toast**.
 
+## 0. Version numbering — why `0.0.1-rc.4` is not lower than `0.2.1`
+
+The version number went **down** against this project's own history, on purpose. Two separate
+facts explain it, and until 2026-11-06 neither was written down anywhere.
+
+**`0.2.x` was never this plugin's version.** The `v0.2.0` and `v0.2.1` releases belonged to the
+**Windows PowerShell/WPF prototype** (a tray widget polling the DeepSeek billing window). The
+browser plugin lived inside that repository under `plugin/` and happened to carry the same
+number — by accident, not by design.
+
+**The `@nolit` ladder was reset by owner decision on 2026-11-05.** Every `@nolit` package moved
+to one scheme, `0.0.1-rc.N`, in which only the `rc#` moves. `0.1.8` and `0.2.1` are not
+milestones under that scheme; the scheme replaced them.
+
+| Surface | Before | After |
+| :--- | :--- | :--- |
+| Version scheme | per-track, drifting (`0.1.6 → 0.1.7 → 0.1.8 → 0.2.1`) | **`0.0.1-rc.N`** |
+| Package | `@nolit/dsh-notify-web` @ `0.2.1`, nested in `plugin/` | **`@nolit/dsh-notify`** @ `0.0.1-rc.4`, repository root |
+| Repository | Windows prototype at root | plugin at root, prototype preserved in `prototype-windows/` |
+
+The `-web` suffix came from the 2026-10-24 recovery and was never the owner's choice;
+`PROVENANCE.md` documented the package as `@nolit/dsh-notify` the entire time while the files
+said `-web`. The rename landed in `0.0.1-rc.3`; `0.0.1-rc.4` is the corrected build.
+
+Version numbers are the owner's decision. An agent must not choose, bump or "stabilise" one.
+
 ## 1. Behavior
 
 | DSH event | Channel |
@@ -284,8 +310,15 @@ typography token contract, and the absence of every removed legacy path.
 
 ---
 
+
 ## 한국어 요약
 
+**버전이 내려간 이유부터**: `0.0.1-rc.4`는 `0.2.1`보다 낮은 것이 아닙니다. `0.2.x`는 이
+플러그인의 버전이 아니라 같은 저장소에 있던 **Windows 프로토타입**의 버전이었고, 2026-11-05
+소유자 결정으로 모든 `@nolit` 패키지가 **`0.0.1-rc.N`** 단일 사다리로 재설정됐습니다.
+`rc#`만 올라갑니다. 패키지명도 `@nolit/dsh-notify-web` → **`@nolit/dsh-notify`** 로
+바뀌었습니다. `-web`은 2026-10-24 복구 당시 붙은 것으로 소유자가 고른 이름이 아니었습니다.
+
 **알림 for 크롬**은 DeepSeek Harness의 턴 완료·도구 승인·질문·오류를 **크롬 알림**(Web
 Notification API)으로 알립니다. 크롬이 알림을 막거나 표시할 수 없으면 **소리 없이 DSH 인앱
 토스트**로 대신 알립니다. 자체 오디오 엔진·BYO 오디오·자체 CSS·네이티브 앱/포트/파일 경로는

package/lib/client.js

@@ -1899,13 +1899,16 @@ window.__ModuleLoader__.load({
         // Route gate: the peak/off-peak clock only describes DeepSeek's own
         // billing. Read at mount (the composer may already carry the attribute)
         // and follow every selection change.
+        // This component is a UI adapter outside createNotifyCore, so the core's
+        // `doc` binding is not in scope here. Read the browser document directly.
+        const docRef = typeof document === 'undefined' ? undefined : document
         const [activeProvider, setActiveProvider] = React.useState(() =>
-          readActiveProvider(doc),
+          readActiveProvider(docRef),
         )
         React.useEffect(() => {
-          const read = () => setActiveProvider(readActiveProvider(doc))
+          const read = () => setActiveProvider(readActiveProvider(docRef))
           read()
-          return watchActiveProvider(doc, read)
+          return watchActiveProvider(docRef, read)
         }, [])
 
         if (!settings.showPeakChip) return null

package/lib/client.src.js

@@ -1690,13 +1690,16 @@ window.__ModuleLoader__.load({
         // Route gate: the peak/off-peak clock only describes DeepSeek's own
         // billing. Read at mount (the composer may already carry the attribute)
         // and follow every selection change.
+        // This component is a UI adapter outside createNotifyCore, so the core's
+        // `doc` binding is not in scope here. Read the browser document directly.
+        const docRef = typeof document === 'undefined' ? undefined : document
         const [activeProvider, setActiveProvider] = React.useState(() =>
-          readActiveProvider(doc),
+          readActiveProvider(docRef),
         )
         React.useEffect(() => {
-          const read = () => setActiveProvider(readActiveProvider(doc))
+          const read = () => setActiveProvider(readActiveProvider(docRef))
           read()
-          return watchActiveProvider(doc, read)
+          return watchActiveProvider(docRef, read)
         }, [])
 
         if (!settings.showPeakChip) return null

package/market/index.json

@@ -63,7 +63,7 @@
       },
       "versions": [
         {
-          "version": "0.0.1-rc.3",
+          "version": "0.0.1-rc.4",
           "source": {
             "type": "npm"
           },

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nolit/dsh-notify",
-  "version": "0.0.1-rc.3",
+  "version": "0.0.1-rc.4",
   "description": "Notify for Chrome: Chrome notification alerts for DeepSeek Harness turns, approvals, questions and errors, with a silent in-app toast fallback.",
   "license": "MIT",
   "author": "nolit",

package/test/manifest.test.mjs

@@ -4,7 +4,7 @@
  * Owner decisions recorded here:
  *   - the npm package name stays @nolit/dsh-notify (renaming it would break
  *     the live profile's `link:` dependency); only the display identity changed;
- *   - the owner's version form 0.0.1.rc3 maps to the semver form 0.0.1-rc.3;
+ *   - the owner's version form 0.0.1.rc4 maps to the semver form 0.0.1-rc.4;
  *   - DSH 0.2.2-rc.1 installs Cordis 4.1.0 and requires Node >= 24.9.
  */
 import assert from 'node:assert/strict'
@@ -26,11 +26,11 @@ test('package name stays @nolit/dsh-notify; display identity is Notify for Chrom
   assert.match(pkg.description, /Notify for Chrome/)
 })
 
-test('version is the owner-declared 0.0.1-rc.3 (owner form 0.0.1.rc3)', () => {
-  assert.equal(pkg.version, '0.0.1-rc.3')
+test('version is the owner-declared 0.0.1-rc.4 (owner form 0.0.1.rc4)', () => {
+  assert.equal(pkg.version, '0.0.1-rc.4')
   assert.match(pkg.version, /^\d+\.\d+\.\d+-rc\.\d+$/)
   assert.equal(market.plugins[0].versions[0].version, pkg.version)
-  assert.ok(read('CHANGELOG.md').includes('0.0.1.rc3'), 'CHANGELOG must record the owner-stated form')
+  assert.ok(read('CHANGELOG.md').includes('0.0.1.rc4'), 'CHANGELOG must record the owner-stated form')
 })
 
 test('cordis peer range admits the installed Cordis 4.1.0', () => {

package/test/peak.test.mjs

@@ -331,3 +331,40 @@ test('the setting defaults off in the shipped defaults and the bundle patch', ()
   const patch = readFileSync(new URL('../cordis.patch.yml', import.meta.url), 'utf8')
   assert.match(patch, /^\s+peakOnAnyProvider: false$/m)
 })
+
+// ---------------------------------------------------------------------------
+// Regression: the chip must actually RENDER, not just register.
+//
+// The chip is a UI adapter outside createNotifyCore, so the core's `doc` binding
+// is not in its scope. An earlier revision referenced it anyway, which threw
+// `ReferenceError: doc is not defined` on every render and made the slot appear
+// registered while nothing ever painted. Registering is not rendering.
+// ---------------------------------------------------------------------------
+
+test('the registered chip component renders without a ReferenceError', () => {
+  const slots = {}
+  const ctx = {
+    locale: { getSnapshot: () => ({ active: 'ko' }), subscribe: () => () => {} },
+    logger: { warn() {}, log() {} },
+    remote: { $on: () => () => {} },
+    sessions: { list: { getSnapshot: () => ({ byId: {} }) }, scopeOf: () => undefined },
+    slots: {
+      inject: (key, cb) => {
+        const d = cb()
+        return typeof d === 'function' ? d : () => {}
+      },
+      register: (meta, component) => {
+        slots[meta.name] = component
+        return () => {}
+      },
+    },
+    effect: (fn) => {
+      const d = fn()
+      return typeof d === 'function' ? d : () => {}
+    },
+  }
+  mod.apply(ctx, {})
+  const Chip = slots['conversation.session.header.utilities']
+  assert.ok(Chip, 'the chip must register into the header utilities slot')
+  assert.doesNotThrow(() => Chip({}), 'rendering the chip must not throw')
+})