@nodii/dev 0.6.5 → 0.6.7

package/README.md

@@ -144,8 +144,21 @@ nodii-dev figma submit CHANGE_SET --file SUBMISSION.json
 nodii-dev figma apply CHANGE_SET --figma-version VERSION
 nodii-dev figma published CHANGE_SET --figma-version VERSION
 nodii-dev figma abandon CHANGE_SET
+nodii-dev figma withdraw CHANGE_SET    # take back a submit before anything is decided
 nodii-dev figma release FILE_KEY
 
+```
+
+`figma withdraw` moves a change set you hold from `in_review` back to
+`editing`, as long as no item has been decided (Dev's
+`withdrawDesignChangeSet`). Dev refuses when the change set doesn't exist
+(`CHANGE_SET_NOT_FOUND`), isn't in review (`CHANGE_SET_NOT_IN_REVIEW`), you
+aren't its holder or an operator (`WITHDRAW_NOT_ALLOWED`), or an item is
+already decided (`CHANGE_SET_HAS_DECISIONS`: ask the reviewer to request
+changes instead). The CLI prints each refusal in plain words and keeps the
+code.
+
+```bash
 nodii-dev hook claude-figma-pre       # reads Claude Code hook JSON on stdin
 nodii-dev hook claude-figma-post      # reads Claude Code hook JSON on stdin
 nodii-dev hook print-settings         # prints managed-settings JSON; writes nothing
@@ -164,6 +177,8 @@ nodii-dev lane list [--kind KIND] [--status STATUS] [--machine UUID]
 nodii-dev lane show KEY
 nodii-dev lane prioritize|deprioritize KEY --reason TEXT
 nodii-dev lane stop KEY --reason TEXT
+nodii-dev lane non-issue KEY --reason TEXT --evidence TEXT --reroute KEY[,KEY]|none
+                         --branch carried:ISSUE|dropped[:REASON] [--commits SHA[,SHA]]
 nodii-dev next KEY
 
 nodii-dev built list [--cursor CURSOR] [--include-acknowledged true]
@@ -343,6 +358,38 @@ checks. Setup also checks the OAuth login (a token refresh, then the registered
 agent) and prints `nodii-dev login` guidance without exposing credential
 details.
 
+`lane non-issue` ends a lane at its second terminal status, `non_issue`, when
+its investigation proves the issue is not a defect in its repository (DEC-0011,
+MW1-28.1). The lane's own agent or the machine's coordinator runs it; no staff
+person is needed. It needs:
+
+- `--reason`: why this is not a defect here;
+- `--evidence`: what was checked, with `file:line` or data;
+- `--reroute`: the issue keys the real cause was re-routed to, comma-separated,
+  or `none` only when the evidence shows no defect anywhere;
+- `--branch`: what happens to the lane's branch work. `carried:ISSUE` carries it
+  into that open follow-up issue with its commits; `dropped:REASON` drops it
+  with a reason. A bare `dropped` is accepted only when the branch has no
+  commits beyond `origin/main`, and records that as the reason. Dev records the
+  outcome with the lane's branch.
+- `--commits`: the commits (at most 200). Carried work needs at least one.
+  Without the flag the CLI reads the lane's branch commits that are not on
+  `origin/main` (as last fetched) from the lane's recorded worktree; it refuses
+  with `GIT_REQUIRED` when it cannot read them, and with `USAGE` when carried
+  work has none (drop it instead).
+
+The CLI refuses with `USAGE` (exit 2) before sending anything when one of these
+is missing. Dev then makes the lane `non_issue`, which frees its slot like
+`on_dev`, and moves each linked open issue to `wont_do` with the reason. An
+issue that another active lane still works on stays open. Dev refuses a lane
+that is already terminal (409 `LANE_TERMINAL`), a caller that is neither the
+lane's agent nor its coordinator (403 `LANE_ACTOR_REQUIRED`), a live lease held
+by someone else (409 `CLAIM_HELD_BY_OTHER`), and a re-route or carried key that
+names no issue, the lane's own issue, or (for carried) a closed one (422).
+The command reaches Dev through the edge, so it needs the edge's route for
+`/devops/api/v1/lanes/:id/non-issue`; until that is on an environment, the
+command gets the edge's 404 there.
+
 Heartbeat notes are optional and limited by Dev to 500 characters.
 Prioritize and deprioritize require a 1–500 character reason, which the CLI
 sends to Dev. `lane review` records the review gate.

package/dist/cli.js

@@ -68,6 +68,7 @@ Usage: nodii-dev <command> [options] [--json]
   design guideline propose ENTRY --file FILE.md [--summary TEXT] [--dry-run]
   design changeset list [--entry KEY] [--state STATE] | show ID
   figma lock|check|log-write|submit|apply|published|abandon|release
+  figma withdraw CHANGE_SET             # holder takes back a submit: in_review -> editing
   hook claude-figma-pre|claude-figma-post|print-settings
   setup [--yes|--check]                 # dry-run by default
   harness install|update [--include-drafts[=false]] [--adopt PATH,...] [--dry-run]
@@ -84,6 +85,9 @@ Usage: nodii-dev <command> [options] [--json]
   lane step <key> --side SIDE --start|--done|--block <step>
   lane evidence <key> --pr|--commit|--figma|--deploy|--dev-check REF
   lane heartbeat|review|land|verify|prioritize|deprioritize|stop <key>
+  lane non-issue <key> --reason TEXT --evidence TEXT --reroute KEY[,KEY]|none
+                 --branch carried:KEY|dropped[:REASON] [--commits SHA[,SHA]]
+                                        # DEC-0011: terminal non_issue; issue -> wont_do; slot frees
   lane list [--kind KIND] [--status STATUS] [--mine] [--cursor CURSOR]
   lane show <key> | next <key>
   built list | built ack <key...>
@@ -265,6 +269,25 @@ export function transitionBody(f) {
   return { to, ...(note ? { note } : {}) };
 }
 
+// Dev's refusals of withdrawDesignChangeSet, said in terms of what to do next.
+const WITHDRAW_REFUSALS = {
+  CHANGE_SET_NOT_FOUND: (id) => `No change set ${id} in Dev.`,
+  CHANGE_SET_NOT_IN_REVIEW: (id) => `${id} is not in review; only a submitted (in_review) change set can be withdrawn.`,
+  WITHDRAW_NOT_ALLOWED: (id) => `You don't hold ${id}; only its holder (or an operator) can withdraw it.`,
+  CHANGE_SET_HAS_DECISIONS: (id) => `${id} already has a decided item, so it can't be withdrawn; ask the reviewer to request changes instead.`,
+};
+
+export async function figmaWithdraw(id, { request = devRequest } = {}) {
+  if (!id) throw new CliError("USAGE", "figma withdraw CHANGE_SET", 2);
+  try {
+    return await request("POST", `/api/v1/design/change-sets/${encode(id)}/withdraw`, {});
+  } catch (error) {
+    const say = WITHDRAW_REFUSALS[error?.code];
+    if (!say) throw error;
+    throw new CliError(error.code, say(id), error.exitCode ?? 1, error.details);
+  }
+}
+
 export async function main(argv = process.argv.slice(2)) {
   if (argv.length === 1 && ["--version", "-v"].includes(argv[0]))
     return console.log(VERSION);
@@ -571,6 +594,8 @@ export async function main(argv = process.argv.slice(2)) {
         json,
       );
     }
+    if (action === "withdraw")
+      return emit(await figmaWithdraw(rest[0]), json, `Withdrew ${rest[0]}; it is back in editing.`);
     if (action === "release")
       return emit(
         await devRequest(

package/dist/core.js

@@ -4,7 +4,7 @@ import { chmod, mkdir, readFile, rm, writeFile } from "node:fs/promises";
 import { homedir, platform } from "node:os";
 import { dirname, join } from "node:path";
 
-export const VERSION = "0.6.5";
+export const VERSION = "0.6.7";
 export const configPath = () =>
   process.env.NODII_DEV_CONFIG_PATH ??
   join(homedir(), ".config/nodii-dev/config.json");