@nodii/dev 0.6.41 → 0.6.43

package/README.md

@@ -357,6 +357,9 @@ nodii-dev lane step KEY --side backend|frontend --start|--done|--block STEP [--r
                     # --reason is kept as a lane note; on a step already blocked,
                     # --block --reason records the new reason (Dev issue 125 moves it onto the step)
 nodii-dev lane evidence KEY --pr|--commit|--figma|--deploy|--dev-check REF
+nodii-dev lane done-check KEY --evidence TEXT|URL
+                    # the lane's done check is met (NODII-DEV-CLI-4); a launched
+                    # run that exits after it ends finished, not orphaned
 nodii-dev lane subagent-quota KEY N
 nodii-dev lane heartbeat KEY [--note TEXT]
 nodii-dev lane resume KEY
@@ -922,8 +925,9 @@ Dev identity.
 A launched or resumed runtime runs under a detached lane supervisor (an
 internal `nodii-dev __lane-supervisor` process), which sees its exit code and
 reports it to Dev as the lane's identity (NODII-DEV-CLI-1). It first reads the
-lane's status. A lane whose done check is recorded (its `dev_check` step done,
-or the lane `on_dev`, `non_issue` or `stopped`) has finished. On it, exit 0 with a clean worktree ends the run
+lane's status. A lane whose done check is recorded (`nodii-dev lane done-check
+KEY --evidence TEXT|URL`, its `dev_check` step done, or the lane `on_dev`,
+`non_issue` or `stopped`) has finished. On it, exit 0 with a clean worktree ends the run
 `done`, exit 0 with uncommitted or untracked files ends it `handed_off` and names
 them, and any other exit ends it `failed`. None of these counts as a death. A
 process that stops before the done check is recorded is unfinished, whatever

package/dist/cli.js

@@ -219,6 +219,7 @@ Usage: nodii-dev <command> [options] [--json]
   lane step <key> --side SIDE --not-applicable gather --reason-code pre_harness_lane [--note TEXT]
                                         # coordinator only: Gather never applied (pre-Gather lane); never "done"
   lane evidence <key> --pr|--commit|--figma|--deploy|--dev-check REF
+  lane done-check <key> --evidence TEXT|URL   # the done check is met; a launched run that exits after it ends finished
   lane subagent-quota <key> <n>          # coordinator assigns 0-100 subagent slots
   lane heartbeat|resume|land|verify|prioritize|deprioritize|stop <key>
   lane review <key> --file REVIEW.json  # base/head, outcome and clause-cited findings

package/dist/core.js

@@ -4,7 +4,7 @@ import { chmod, mkdir, readFile, rm, writeFile } from "node:fs/promises";
 import { homedir, platform } from "node:os";
 import { dirname, join } from "node:path";
 
-export const VERSION = "0.6.41";
+export const VERSION = "0.6.43";
 export const configPath = () =>
   process.env.NODII_DEV_CONFIG_PATH ??
   join(homedir(), ".config/nodii-dev/config.json");

package/dist/lane-supervisor.js

@@ -10,8 +10,8 @@ import { saveWatchedRun, watchdogRunDir } from "./watchdog.js";
  * NODII-DEV-CLI-1: a launched or resumed lane's runtime is the child of this
  * supervisor, so its exit code is known. The supervisor reports it to Dev
  * with the worktree's clean/dirty state and the lane's status. A lane whose
- * done check is recorded (its dev_check step done, or the lane on_dev,
- * non_issue or stopped) has finished: its run
+ * done check is recorded (`lane done-check`, NODII-DEV-CLI-4; its dev_check
+ * step done; or the lane on_dev, non_issue or stopped) has finished: its run
  * ends, never as a death. A process that stops before that is unfinished,
  * whatever its exit code: it is reported as a process exit, which Dev orphans
  * so `lane resume` relaunches it (hub-58 scope add). Before this, the
@@ -76,14 +76,15 @@ async function send(request, path, body, attempts = 3) {
 }
 
 /**
- * The lane's Dev status and whether its done check is recorded: a dev_check
- * step done, or a terminal lane. Unreadable reads as unfinished.
+ * The lane's Dev status and whether its done check is recorded: a recorded
+ * done check, a dev_check step done, or a terminal lane. Unreadable reads as
+ * unfinished.
  */
 async function laneProgress(request, laneKey) {
   try {
     const lane = (await request("GET", `/api/v1/lanes/${encode(laneKey)}`)).data;
     const devChecked = (lane?.steps ?? []).some((step) => step.stepKey === "dev_check" && step.state === "done");
-    return { status: lane?.status ?? null, finished: devChecked || FINISHED_LANE.has(lane?.status) };
+    return { status: lane?.status ?? null, finished: Boolean(lane?.doneCheckRecorded) || devChecked || FINISHED_LANE.has(lane?.status) };
   } catch {
     return { status: null, finished: false };
   }

package/dist/lanes.js

@@ -113,14 +113,17 @@ async function laneContract(id, request, options) {
   try {
     return (await request("GET", `/api/v1/lanes/${encode(id)}/contract`, undefined, options)).data?.text ?? null;
   } catch (error) {
-    // A Dev from before the Lane contract route: say so, never hide it.
-    if (error?.code === "HTTP_404" || error?.code === "NOT_FOUND") return "(this Dev does not serve the Lane contract yet; read the lane with `nodii-dev lane show`)";
+    // A Dev or edge without the Lane contract route (the edge answers an
+    // unknown route `unroutable`): say so, never fail the Gather on it.
+    if (["unroutable", "HTTP_404", "NOT_FOUND", "ROUTE_NOT_FOUND"].includes(error?.code)) return "(Dev does not serve the Lane contract here yet. Record your pick: the recorded Gather prints the full contract. Until then, `nodii-dev lane show` and `nodii-dev issues show <issue>` hold it.)";
     throw error;
   }
 }
 // Gather never ends on a bare "finished" (hub-58): the next step is the task.
+// Dev has moved the lane past gather by now (NODII-DEV-CLI-3); recording the
+// done check is what lets a launched run end finished (NODII-DEV-CLI-4).
 const nextStepText = (ref, doneCheck) =>
-  `Gather is finished. Next: Task. Work the objective until ${doneCheck} is met, then run \`nodii-dev lane land ${ref}\` (or the lane's finish command). Don't stop before that.`;
+  `Gather is finished. Next: Task. Work the objective until ${doneCheck} is met, record it with \`nodii-dev lane done-check ${ref} --evidence TEXT|URL\`, then run \`nodii-dev lane land ${ref}\` (or the lane's finish command). Don't stop before that.`;
 const agentShortlistText = (ref, data, flags) => [
   ...contractLines(data),
   `Trigger shortlist ${data.shortlistId} · ${JSON.stringify(data.objective)}`,
@@ -515,6 +518,11 @@ export async function laneCommand(action, args, flags, { request = devRequest, c
     const lane = (await request("GET", `/api/v1/lanes/${encode(id)}`)).data;
     const step = lane.steps.find((x) => x.side === side && (x.id === stepRef || x.stepKey === stepRef));
     if (!step) throw new CliError("STEP_NOT_FOUND", `No ${side} step ${stepRef} on ${ref}.`, 1);
+    // Dev finishes gather and starts the next step itself when Gather's Freeze
+    // is written (NODII-DEV-CLI-3), so asking for that again is already true.
+    const already = { done: "done", start: "current" }[selected[0]];
+    if (already && step.state === already)
+      return { payload: { data: step }, human: `${ref}: ${side}/${step.stepKey} is already ${already}.` };
     // hub-58: Gather is the only step a coordinator may rule not applicable.
     if (ruling && step.stepKey !== "gather") throw new CliError("USAGE", "--not-applicable covers only the gather step.", 2);
     // GATHER-NA: coordinator only; Dev refuses a lane identity (COORDINATOR_REQUIRED).
@@ -548,6 +556,17 @@ export async function laneCommand(action, args, flags, { request = devRequest, c
     const payload = await request("POST", `/api/v1/lanes/${encode(id)}/evidence`, body);
     return { payload, human: `${ref}: recorded ${body.kind} evidence.` };
   }
+  if (action === "done-check") {
+    // NODII-DEV-CLI-4: the agent met the lane's done check. A launched run that
+    // exits after this ends finished instead of orphaned (lane-supervisor.js).
+    const value = typeof flags.evidence === "string" ? flags.evidence.trim() : "";
+    if (!value) throw new CliError("USAGE", "lane done-check needs --evidence TEXT|URL: what shows the lane's done check is met.", 2);
+    const body = { kind: "done_check", ...(/^https?:\/\//i.test(value) && URL.canParse(value) ? { url: value } : { ref: value }), ...via };
+    const payload = await request("POST", `/api/v1/lanes/${encode(id)}/evidence`, body);
+    if (!payload?.data?.doneCheckRecorded)
+      throw new CliError("DONE_CHECK_NOT_RECORDED", `Dev took the evidence but does not show ${ref}'s done check as recorded; it predates NODII-DEV-CLI-4. The run would still end orphaned.`, 1);
+    return { payload, human: `${ref}: done check recorded. The lane's run ends finished when its process exits.` };
+  }
   if (action === "heartbeat") {
     return { payload: await request("POST", `/api/v1/lanes/${encode(id)}/heartbeat`, { ...(flags.note !== undefined ? { note: flags.note } : {}), ...via }), human: `${ref}: heartbeat recorded.` };
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nodii/dev",
-  "version": "0.6.41",
+  "version": "0.6.43",
   "description": "Agent CLI for Nodii Dev, reached through the platform edge",
   "type": "module",
   "bin": {