@nodii/dev 0.6.24 → 0.6.25

package/dist/lanes.js

@@ -1,7 +1,8 @@
 import { execFile } from "node:child_process";
+import { readFile } from "node:fs/promises";
 import { promisify } from "node:util";
 import { CliError, encode, devRequest, query, readConfig, requireFlag } from "./core.js";
-import { recordReviewReceipt } from "./safety.js";
+import { recordReviewReceipt, reviewCommitContext } from "./safety.js";
 
 const execFileAsync = promisify(execFile);
 const via = { via: "nodii-dev" };
@@ -53,6 +54,19 @@ function evidence(flags) {
 
 const list = (value) => String(value).split(",").map((x) => x.trim()).filter(Boolean);
 
+export async function reviewBody(flags, read = (path) => readFile(path, "utf8")) {
+  const file = requireFlag(flags, "file");
+  let body;
+  try {
+    body = JSON.parse(await read(file));
+  } catch (error) {
+    throw new CliError("REVIEW_FILE_INVALID", `Cannot read review JSON from ${file}: ${error.message}`, 2);
+  }
+  if (!body || typeof body !== "object" || Array.isArray(body))
+    throw new CliError("REVIEW_FILE_INVALID", "The review file must contain one JSON object.", 2);
+  return { ...body, ...via };
+}
+
 /**
  * DEC-0011 (MW1-28.1): the body for `lane non-issue`. A re-route needs at
  * least one issue key or an explicit `none`, and the branch work is either
@@ -99,7 +113,7 @@ export async function branchCommits(lane) {
   }
 }
 
-export async function laneCommand(action, args, flags, { request = devRequest, config = readConfig, gitContext = inferGitContext, commitsOf = branchCommits, reviewReceipt = recordReviewReceipt } = {}) {
+export async function laneCommand(action, args, flags, { request = devRequest, config = readConfig, gitContext = inferGitContext, commitsOf = branchCommits, read = (path) => readFile(path, "utf8"), reviewContext = reviewCommitContext, reviewReceipt = recordReviewReceipt } = {}) {
   if (action === "list") {
     const c = flags.mine ? await config() : null;
     const payload = await request("GET", `/api/v1/lanes${query({ kind: flags.kind, status: flags.status, machine: flags.machine, agent: flags.mine ? c.agentId : flags.agent, "waiting-on": flags["waiting-on"], stuck: flags.stuck, cursor: flags.cursor, limit: flags.limit })}`);
@@ -170,12 +184,50 @@ export async function laneCommand(action, args, flags, { request = devRequest, c
   }
   if (action === "land") return { payload: await request("POST", `/api/v1/lanes/${encode(id)}/land`, via), human: `${ref}: recorded on main.` };
   if (action === "review") {
-    const payload = await request("POST", `/api/v1/lanes/${encode(id)}/review`, via);
+    const body = await reviewBody(flags, read);
+    const current = await reviewContext();
+    if (body.head !== current.commit || body.base !== current.base)
+      throw new CliError(
+        "REVIEW_FILE_STALE",
+        `The review file covers base ${body.base ?? "(missing)"} and head ${body.head ?? "(missing)"}, but this worktree is base ${current.base} and head ${current.commit}. Review the current diff and write a new receipt.`,
+        2,
+      );
+    const payload = await request("POST", `/api/v1/lanes/${encode(id)}/review`, body);
     try { await reviewReceipt(); }
     catch (error) {
-      throw new CliError("REVIEW_RECEIPT_FAILED", `${ref}: Dev recorded the review, but the local push receipt could not be written (${error?.message ?? error}). Re-run nodii-dev lane review ${ref} from its worktree.`, 1);
+      throw new CliError("REVIEW_RECEIPT_FAILED", `${ref}: Dev recorded the review, but the local push receipt could not be written (${error?.message ?? error}). Re-run nodii-dev lane review ${ref} --file REVIEW.json from its worktree.`, 1);
     }
-    return { payload, human: `${ref}: review recorded for the current commit and origin/main.` };
+    return {
+      payload,
+      human: (p) => {
+        const findings = p.data.findings ?? [];
+        const missed = findings.filter((finding) => finding.missedTrigger === true).length;
+        return `${ref}: review recorded for the current commit and origin/main (${p.data.exitReason}; ${findings.length} finding(s), ${missed} missed trigger(s)).`;
+      },
+    };
+  }
+  if (action === "reviews") {
+    const payload = await request("GET", `/api/v1/lanes/${encode(id)}`);
+    return {
+      payload,
+      human: (p) => {
+        const reviews = p.data.reviews ?? [];
+        return reviews.length
+          ? reviews
+              .map((run) => {
+                const missed = run.findings.filter((finding) => finding.missedTrigger === true).length;
+                return [
+                  `${run.createdAt}\t${run.head}\t${run.exitReason}\t${run.findings.length} finding(s)\t${missed} missed trigger(s)`,
+                  ...run.findings.map(
+                    (finding) =>
+                      `  ${finding.severity}\t${finding.perspective}\t${finding.clauseId ?? "-"}\t${finding.summary}${finding.missedTrigger ? "\tMISSED_TRIGGER" : ""}`,
+                  ),
+                ].join("\n");
+              })
+              .join("\n")
+          : `No reviews recorded for ${ref}.`;
+      },
+    };
   }
   if (action === "verify") {
     const value = requireFlag(flags, "dev-check");

package/dist/safety.js

@@ -370,12 +370,19 @@ export async function safetyPostHook(payload) {
   return { recorded: false };
 }
 
-/** Pin the exact commit and origin/main base Dev's review transition covers. */
+/** The exact commit and origin/main base a review and its local receipt cover. */
+export async function reviewCommitContext(cwd = process.cwd()) {
+  return {
+    commit: await git(cwd, "rev-parse", "HEAD"),
+    base: await git(cwd, "rev-parse", "origin/main"),
+  };
+}
+
+/** Pin the exact commit and origin/main base Dev accepted for review. */
 export async function recordReviewReceipt(cwd = process.cwd()) {
   const path = await gitPrivatePath(cwd, REVIEW_RECEIPT);
   const receipt = {
-    commit: await git(cwd, "rev-parse", "HEAD"),
-    base: await git(cwd, "rev-parse", "origin/main"),
+    ...(await reviewCommitContext(cwd)),
     recordedAt: new Date().toISOString(),
   };
   await mkdir(dirname(path), { recursive: true });

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nodii/dev",
-  "version": "0.6.24",
+  "version": "0.6.25",
   "description": "Agent CLI for Nodii Dev, reached through the platform edge",
   "type": "module",
   "bin": {