@nodii/dev 0.6.21 → 0.6.23

package/dist/core.js

@@ -4,7 +4,7 @@ import { chmod, mkdir, readFile, rm, writeFile } from "node:fs/promises";
 import { homedir, platform } from "node:os";
 import { dirname, join } from "node:path";
 
-export const VERSION = "0.6.21";
+export const VERSION = "0.6.23";
 export const configPath = () =>
   process.env.NODII_DEV_CONFIG_PATH ??
   join(homedir(), ".config/nodii-dev/config.json");

package/dist/vendor/ds-conformance.mjs

@@ -30,7 +30,7 @@
 //     it until it returns [] (each round can reveal instances inside slot
 //     content).
 
-export const VERSION = "1.0.4";
+export const VERSION = "1.0.10";
 
 /** @typedef {{ nodeId: string, check: string, detail: string }} Finding */
 /**
@@ -135,22 +135,18 @@ const NOT_A_TABLE = /\blist page\b/i;
 const CUSTOMER_HEADER =
   /^(customer|client|contact|lead|applicant|candidate)s?( name)?$/i;
 const EXTERNAL_PLANE = /customer portal|partner room|external/i;
-// The viewer's own record (R5): the App Frame sidebar footer, the user menu
-// and the profile. Not any footer: a dialog or table footer can list others.
-const SELF_CONTAINER =
-  /sidebar ?footer|user button|user menu|account menu|profile|\b(my|own) (account|tokens?|security|sessions?|settings|notification settings|records?)\b/i;
-// A frame the screen marks as the viewer's own: "[self]", "(self)", a
-// trailing "· self", or "(you)".
-const SELF_MARK = /\[self\]|\(self\)|·\s*self\s*$|\(you\)/i;
-// Where the screens show who the viewer is: the App Frame footer, the user
-// and account menus, and frames marked self or named my/own.
-const VIEWER_PLACE =
-  /sidebar ?footer|user button|user menu|account menu|\b(my|own) (profile|account|tokens?|security|sessions?|settings)\b/i;
-const SELF_TEXT = /\(you\)|^you$/i;
-const SIGNED_IN = /^(signed in( as\b.*)?|not you\?.*)$/i;
-// The signed-in account card (Account Context, kind=Account) shows the
-// viewer's own email.
-const SELF_COMPONENT = /^account context$/i;
+const APP_FRAME_COMPONENT_SET_KEY = "e725461fd9786a3f1527ddee0ee764e9dcead46b";
+const PERSON_NAME_COMPONENT_SET_KEY =
+  "08370f38bcbbcf88eaf3a6923dc91b5de5f38ea0";
+const TABLE_COMPONENT_SET_KEY = "7ccc1dbb6ebd149fb9aaf42b9c638f5ce7169638";
+const TABLE_CELL_COMPONENT_SET_KEY = "528898c19702ed4b169d023de30380e05169dfa5";
+const ITEM_COMPONENT_SET_KEY = "46abc8cb0d57c22a365da94a03cfd72a0b089b87";
+const SELF_COMPONENT_SET_KEYS = new Set([
+  "af8df2e85ba4d53b26b28ffa69f264758a50fe66", // Account Context
+  "470b2b5fd91dcae681d3d38c0297c71df3bb998f", // Account Menu
+  "8499452873bccfe5d2f29b5322fc1ca18cb103cc", // Profile Name Card
+  "6c1e074dcf69aee388e0300584da09735e314cc3", // Delete Account Card
+]);
 const NOT_A_PERSON = /^(you|the team)$/i;
 const MASKED = /[*•●]/;
 const EMAIL = /[A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+\.[A-Za-z]{2,}/g;
@@ -164,6 +160,9 @@ const PHONE = /(?<![\w.+\-/])\+?\(?\d[\d ().-]{7,}\d(?![\w\-/])/g;
 const LOCAL_PHONE = /^(\(\d{3,5}\)[ .-]?|\d{3,5}[ .-])\d{3,5}([ .-]\d{2,5})?$/;
 const DATE = /^(\d{4}-\d{2}-\d{2}|\d{1,2}[-/.]\d{1,2}[-/.]\d{2,4})/;
 const ROLE_ANNOTATION = /\[role:([a-z0-9._-]+)\]/gi;
+// Published Dialog component-set key. A node id would break when the set is
+// moved; the key is the stable reference shared across library consumers.
+const DIALOG_COMPONENT_SET_KEY = "55d4155c4bce0136e9a3740ecc7174f9bd01727c";
 // otherPersonRevealed is about people (Dev issue 116): a value is judged
 // by the field it fills. A tenant's business contact (support phone or
 // email, caller or sender id, business address) is not personal.
@@ -242,6 +241,13 @@ const styleKeys = (node, styles) => {
 function fieldValue(node, field, styles) {
   if (STYLE_FIELD.test(field) || field === "styles")
     return styleKeys(node, styles);
+  // Figma names the override `fontName`; REST exposes its two values in the
+  // text node's TypeStyle rather than as a direct FontName property.
+  if (field === "fontName")
+    return {
+      family: node?.style?.fontFamily,
+      style: node?.style?.fontStyle,
+    };
   if (TEXT_STYLE_FIELDS.has(field) || field.startsWith("lineHeight"))
     return node?.style?.[field];
   // An image fill's picture is content (DEC-0048): only its scale mode,
@@ -419,8 +425,15 @@ function outOfScopeRoot(n, parent, componentLabel, memo) {
     const hit = memo.get(x.id);
     if (hit) return hit;
     let kind = /** @type {"kit" | "other" | "none"} */ ("none");
-    if (emailKitPart(x, parent, componentLabel)) kind = "kit";
-    else if (x.type === "INSTANCE") kind = "other";
+    if (!visibleNode(x)) kind = "none";
+    else if (emailKitPart(x, parent, componentLabel)) kind = "kit";
+    else if (
+      x.type === "INSTANCE" ||
+      x.type === "TEXT" ||
+      visiblePaints(x.fills) ||
+      visiblePaints(x.strokes)
+    )
+      kind = "other";
     else
       for (const c of x.children ?? []) {
         const k = placed(c);
@@ -435,7 +448,16 @@ function outOfScopeRoot(n, parent, componentLabel, memo) {
   };
   // An email is named so; an editor's workspace around it, or an app screen
   // holding a kit part, stays in scope.
-  return EMAIL_FRAME.test(n.name ?? "") && placed(n) === "kit"
+  let content = /** @type {"kit" | "other" | "none"} */ ("none");
+  for (const child of n.children ?? []) {
+    const kind = placed(child);
+    if (kind === "other") {
+      content = "other";
+      break;
+    }
+    if (kind === "kit") content = "kit";
+  }
+  return EMAIL_FRAME.test(n.name ?? "") && content === "kit"
     ? `email ${n.name}`
     : null;
 }
@@ -506,6 +528,59 @@ function matchesRole(a, inst, role, library) {
   });
 }
 
+/** The Dialog instance's Body slot, matched by its stable property name. */
+function dialogBody(a, inst) {
+  if (a.setOf(inst)?.key !== DIALOG_COMPONENT_SET_KEY) return null;
+  return (
+    (inst.children ?? []).find((child) => {
+      if (child.type !== "SLOT") return false;
+      const property = child.componentPropertyReferences?.slotContentId;
+      return /^body(?:#|$)/i.test(property ?? "") || /^body$/i.test(child.name);
+    }) ?? null
+  );
+}
+
+/** A text sublayer whose characters this instance changes through a TEXT prop. */
+function textPropertyOverrideTarget(a, from, node) {
+  if (node.type !== "TEXT") return false;
+  const property = node.componentPropertyReferences?.characters;
+  if (typeof property !== "string") return false;
+  for (const ancestor of a.ancestors(node)) {
+    if (
+      ancestor.type === "INSTANCE" &&
+      ancestor.componentProperties?.[property]?.type === "TEXT"
+    )
+      return true;
+    if (ancestor === from) break;
+  }
+  return false;
+}
+
+/**
+ * A look field Figma auto-writes when a TEXT component property is set: the
+ * typography fields and the text's variable bindings (typography and its fill
+ * colour). Only skipped when equal to the main (checked by the caller).
+ */
+function autoTextPropertyField(node, field) {
+  if (
+    field === "fontSize" ||
+    field === "fontName" ||
+    field === "letterSpacing" ||
+    field.startsWith("lineHeight")
+  )
+    return true;
+  if (field !== "boundVariables") return false;
+  const keys = Object.keys(node.boundVariables ?? {});
+  return (
+    keys.length > 0 &&
+    keys.every((key) =>
+      /^(font(Family|Size|Style|Weight)|letterSpacing|lineHeight|fills)$/.test(
+        key,
+      ),
+    )
+  );
+}
+
 /** Characters the screen chose: its own text, or an overridden label. */
 function screenText(a, n, overridden) {
   return !a.composed(n) || overridden.has(n.id);
@@ -558,24 +633,15 @@ export function checkConformance({
   const analyses = Object.values(nodes ?? {})
     .filter((entry) => entry?.document)
     .map((entry) => analyse(entry, mains, library));
-  // The viewer (R5): the email and phone the screens show in the viewer's
-  // own places (the App Frame footer, a frame marked self). The same value
-  // anywhere else is still the viewer's own.
+  // The viewer (R5): identifiers inside the structural self set. The same
+  // value anywhere else is still the viewer's own.
   const viewer = new Set();
   for (const a of analyses)
     for (const n of a.byId.values()) {
-      if (n.type !== "TEXT" || a.out.has(n.id)) continue;
+      if (n.type !== "TEXT" || a.out.has(n.id) || !a.shown(n)) continue;
       const ids = identifiers(textOf(n));
       if (ids.length === 0) continue;
-      if (
-        a
-          .ancestors(n)
-          .some(
-            (x) =>
-              VIEWER_PLACE.test(x.name ?? "") || SELF_MARK.test(x.name ?? ""),
-          )
-      )
-        for (const id of ids) viewer.add(id);
+      if (isSelf(a, n)) for (const id of ids) viewer.add(id);
     }
 
   for (const a of analyses) {
@@ -628,12 +694,15 @@ export function checkConformance({
       let slotDefault;
       const differ = [];
       const equal = [];
+      const textPropertyTarget = textPropertyOverrideTarget(a, from, node);
       for (const field of [...fields].sort()) {
         if (ALLOWED_FIELDS.has(field)) continue;
         if (exemptPaint(a, from, node, field)) continue;
         const mine = fieldValue(node, field, a.styles);
         const theirs = fieldValue(mainNode, field, mainStyles);
         if (sameValue(mine, theirs)) {
+          if (textPropertyTarget && autoTextPropertyField(node, field))
+            continue;
           equal.push(field);
           continue;
         }
@@ -677,6 +746,25 @@ export function checkConformance({
         for (const r of roles)
           if (matchesRole(a, n, r, library)) usedRoles.add(r.role);
 
+      // roleMismatch (operator ruling, 30 Oct): a Dialog is for a form,
+      // list or other body content. A title, description and actions alone
+      // ask a question, which is the Alert Dialog role.
+      if (n.type === "INSTANCE") {
+        const body = dialogBody(a, n);
+        if (
+          a.setOf(n)?.key === DIALOG_COMPONENT_SET_KEY &&
+          (!body ||
+            !a.shown(body) ||
+            !(body.children ?? []).some((child) => a.shown(child)))
+        )
+          push(
+            findings,
+            n.id,
+            "roleMismatch",
+            "Dialog Body is empty or hidden; use Alert Dialog",
+          );
+      }
+
       // tableHeaderFill (DEC-0036): every header cell keeps the library fill.
       if (n.type === "INSTANCE" && headerCell(a, n)) {
         const main = mains[n.componentId]?.document;
@@ -1096,42 +1184,94 @@ function handDrawnButton(n) {
   const words = buttonText(n).split(/\s+/).filter(Boolean);
   return words.length > 0 && words.length <= 3;
 }
+function variantValue(n, property) {
+  for (const [name, value] of Object.entries(n.componentProperties ?? {}))
+    if (
+      name.split("#", 1)[0] === property &&
+      value?.type === "VARIANT" &&
+      typeof value.value === "string"
+    )
+      return value.value;
+  const value = n.variantProperties?.[property];
+  return typeof value === "string" ? value : null;
+}
+function selfPersonName(a, n) {
+  return (
+    n.type === "INSTANCE" &&
+    a.setOf(n)?.key === PERSON_NAME_COMPONENT_SET_KEY &&
+    variantValue(n, "state") === "self"
+  );
+}
+function selfRow(a, n) {
+  const up = a.ancestors(n);
+  const tableAt = up.findIndex(
+    (x) => x.type === "INSTANCE" && a.setOf(x)?.key === TABLE_COMPONENT_SET_KEY,
+  );
+  if (tableAt !== -1) {
+    if (tableAt < 2) return null;
+    const body = up[tableAt - 1];
+    const row = up[tableAt - 2];
+    const cells = row.children ?? [];
+    if (
+      a.parent.get(row.id)?.id !== body.id ||
+      a.parent.get(body.id)?.id !== up[tableAt].id ||
+      cells.length === 0 ||
+      !cells.every(
+        (cell) =>
+          cell.type === "INSTANCE" &&
+          a.setOf(cell)?.key === TABLE_CELL_COMPONENT_SET_KEY,
+      )
+    )
+      return null;
+    return row;
+  }
+
+  return (
+    up.find(
+      (x) =>
+        x.type === "INSTANCE" && a.setOf(x)?.key === ITEM_COMPONENT_SET_KEY,
+    ) ?? null
+  );
+}
 function isSelf(a, n) {
   const up = a.ancestors(n);
+  if (up.some((x) => selfPersonName(a, x))) return true;
   if (
     up.some(
-      (x) => SELF_CONTAINER.test(x.name ?? "") || SELF_MARK.test(x.name ?? ""),
+      (x) =>
+        x.type === "INSTANCE" && SELF_COMPONENT_SET_KEYS.has(a.setOf(x)?.key),
     )
   )
     return true;
-  const accountCard = (x) => {
-    const set =
-      x.type === "INSTANCE"
-        ? a.componentLabel(x)
-        : x.type === "COMPONENT"
-          ? a.parent.get(x.id)?.name
-          : null;
-    if (!SELF_COMPONENT.test(set ?? "")) return false;
-    const name = x.type === "INSTANCE" ? a.componentOf(x)?.name : x.name;
-    const kind = x.componentProperties?.kind?.value;
-    return (
-      kind === "Account" || /(^|,\s*)kind=account(\s*,|$)/i.test(name ?? "")
-    );
-  };
-  if (up.some(accountCard)) return true;
-  const siblings = a.parent.get(n.id)?.children ?? [];
+
+  // INTERIM: identify a Table row from its direct Table-cell children, or a
+  // list row from its Item instance. Switch to the published Table Row key
+  // when DESIGN-SYSTEM-160 ships.
+  const row = selfRow(a, n);
   if (
-    [n, ...siblings].some((x) => x.type === "TEXT" && SELF_TEXT.test(textOf(x)))
+    row &&
+    [...indexTree(row).byId.values()].some((x) => selfPersonName(a, x))
   )
     return true;
-  // "Signed in" or "Not you?" in the same card: the nearest instance or
-  // component holding it, never a whole row or screen.
-  const card = up.find((x) => x.type === "INSTANCE" || x.type === "COMPONENT");
-  return card
-    ? [...indexTree(card).byId.values()].some(
-        (x) => x.type === "TEXT" && SIGNED_IN.test(textOf(x)),
-      )
-    : false;
+
+  // INTERIM: switch this slot rule to the footer-user component key when
+  // DESIGN-SYSTEM-159 ships.
+  const slotAt = up.findIndex((x) => {
+    if (x.type !== "SLOT") return false;
+    // Figma formerly exposed the slot reference as mainComponent; current
+    // REST responses use slotContentId. Accept both so a library republish
+    // cannot turn the viewer's own identifiers into another-person findings.
+    const property =
+      x.componentPropertyReferences?.slotContentId ??
+      x.componentPropertyReferences?.mainComponent;
+    return (
+      typeof property === "string" &&
+      property.split("#", 1)[0] === "sidebarFooter"
+    );
+  });
+  if (slotAt === -1) return false;
+  const owner = up.slice(slotAt + 1).find((x) => x.type === "INSTANCE");
+  return owner ? a.setOf(owner)?.key === APP_FRAME_COMPONENT_SET_KEY : false;
 }
 function revealedByPermission(a, n) {
   return [n, ...a.ancestors(n)].some((x) => {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nodii/dev",
-  "version": "0.6.21",
+  "version": "0.6.23",
   "description": "Agent CLI for Nodii Dev, reached through the platform edge",
   "type": "module",
   "bin": {