@nodenv/node-build 5.2.0 → 5.3.0

package/README.md

@@ -13,11 +13,9 @@ https://github.com/nodenv/node-build/releases/latest)
 https://img.shields.io/npm/v/@nodenv/node-build?logo=npm&logoColor=white)](
 https://www.npmjs.com/package/@nodenv/node-build/v/latest)
 
-node-build is a command-line utility that makes it easy to install virtually any
-version of Node, from source or precompiled binary.
+node-build is a command-line tool that simplifies installation of any Node version from source or precompiled binary on Unix-like systems.
 
-It is available as a plugin for [nodenv][] that
-provides the `nodenv install` command, or as a standalone program.
+It is available as a plugin for [nodenv][] as the `nodenv install` command, or as a standalone program as the `node-build` command.
 
 <!-- toc -->
 
@@ -42,41 +40,34 @@ provides the `nodenv install` command, or as a standalone program.
 
 ## Installation
 
+### Homebrew package manager
 ```sh
-# Using Homebrew on macOS
-$ brew install node-build
-
-# As a nodenv plugin
-$ mkdir -p "$(nodenv root)"/plugins
-$ git clone https://github.com/nodenv/node-build.git "$(nodenv root)"/plugins/node-build
-
-# As a standalone program
-$ git clone https://github.com/nodenv/node-build.git
-$ PREFIX=/usr/local ./node-build/install.sh
+brew install node-build
 ```
 
-### Upgrading
-
+Upgrade with:
 ```sh
-# Via Homebrew
-$ brew update && brew upgrade node-build
+brew upgrade node-build
+```
 
-# As a nodenv plugin
-$ git -C "$(nodenv root)"/plugins/node-build pull
+### Clone as nodenv plugin using git
+```sh
+git clone https://github.com/nodenv/node-build.git "$(nodenv root)"/plugins/node-build
 ```
 
-#### Updating available build versions
+Upgrade with:
+```sh
+git -C "$(nodenv root)"/plugins/node-build pull
+```
 
-To grab the latest versions from nodejs.org and generate definition files for
-node-build to use, check out the [node-build-update-defs][] plugin.
-Once installed:
+### Install manually as a standalone program
 
-``` shell
-nodenv update-version-defs
+First, download a tarball from https://github.com/nodenv/node-build/releases/latest. Then:
+```sh
+tar -xzf node-build-*.tar.gz
+PREFIX=/usr/local ./node-build-*/install.sh
 ```
 
-No need to wait for node-build to provide the latest definitions!
-
 ## Usage
 
 ### Basic Usage
@@ -91,9 +82,17 @@ $ node-build --definitions                 # lists all available versions of Nod
 $ node-build 10.13.0 ~/local/node-10.13.0  # installs Node 10.13.0 to ~/local/node-10.13.0
 ```
 
-node-build does not check for system dependencies before downloading and
-attempting to compile the Node source. Please ensure that [all requisite
-libraries][build-env] are available on your system.
+> **Warning**
+> node-build mostly does not verify that system dependencies are present before downloading and attempting to compile Node from source. Please ensure that [all requisite libraries][build-env] such as build tools and development headers are already present on your system.
+
+Firstly, if a precompiled binary exists for your platform, node-build downloads and installs it.
+Otherwise it will build node from source.
+Basically, what node-build does when installing a Node version is this:
+- Downloads an official tarball of Node source code;
+- Extracts the archive into a temporary directory on your system;
+- Executes `./configure --prefix=/path/to/destination` in the source code;
+- Runs `make install` to compile Node;
+- Verifies that the installed Node is functional.
 
 ### Advanced Usage
 
@@ -106,12 +105,20 @@ instead of compiling from source. To force compilation, pass the `-c` or
 
 #### Custom Build Definitions
 
-If you wish to develop and install a version of Node that is not yet supported
-by node-build, you may specify the path to a custom “build definition file” in
-place of a Node version number.
+To install a version of Node that is not recognized by node-build, you can specify the path to a custom build definition file in place of a Node version number.
+
+Check out [default build definitions][definitions] as examples on how to write definition files.
 
-Use the [default build definitions][definitions] as a template for your custom
-definitions.
+##### Generating Latest-Release Build Definitions
+
+Additionally, check out the [node-build-update-defs][] plugin.
+It generates the standard build definitions for releases available from nodejs.org.
+This allows you to install node versions as soon as they are available from nodejs.org,
+without waiting for node-build itself to provide them. Once installed:
+
+``` shell
+nodenv update-version-defs
+```
 
 #### Custom Build Configuration
 
@@ -144,9 +151,7 @@ The build process may be configured through the following environment variables:
 
 #### Applying Patches
 
-Both `nodenv install` and `node-build` support the `--patch` (`-p`) flag to apply
-a patch to the Node (/iojs/chakracore) source code before building.
-Patches are read from `STDIN`:
+Both `nodenv install` and `node-build` commands support the `-p/--patch` flag to apply a patch to the Node source code before building. Patches are read from standard input:
 
 ```sh
 # applying a single patch
@@ -161,12 +166,9 @@ $ cat fix1.patch fix2.patch | nodenv install --patch 11.1.0
 
 #### Checksum Verification
 
-If you have the `shasum`, `openssl`, or `sha256sum` tool installed, node-build will
-automatically verify the SHA2 checksum of each downloaded package before
-installing it.
+All Node definition files bundled with node-build include checksums for packages, meaning that all externally downloaded packages are automatically checked for integrity after fetching.
 
-Checksums are optional and specified as anchors on the package URL in each
-definition. All definitions bundled with node-build include checksums.
+See the next section for more information on how to author checksums.
 
 #### Package Mirrors
 
@@ -232,13 +234,13 @@ Be sure to include the full build log for build failures.
 Forked from [Sam Stephenson][]'s [ruby-build][] by [Will McKenzie][]
 and modified for node.
 
-[nodenv]: https://github.com/nodenv/nodenv
-[ruby-build]: https://github.com/rbenv/ruby-build
-[definitions]: https://github.com/nodenv/node-build/tree/main/share/node-build
-[wiki]: https://github.com/nodenv/node-build/wiki
-[ruby-build wiki]: https://github.com/rbenv/ruby-build/wiki
-[build-env]: https://github.com/nodenv/node-build/wiki#suggested-build-environment
-[issue tracker]: https://github.com/nodenv/node-build/issues
-[node-build-update-defs]: https://github.com/nodenv/node-build-update-defs
-[Sam Stephenson]: https://github.com/sstephenson
-[Will McKenzie]: https://github.com/oinutter
+  [nodenv]: https://github.com/nodenv/nodenv#readme
+  [definitions]: https://github.com/nodenv/node-build/tree/main/share/node-build
+  [wiki]: https://github.com/nodenv/node-build/wiki
+  [build-env]: https://github.com/nodenv/node-build/wiki#suggested-build-environment
+  [issue tracker]: https://github.com/nodenv/node-build/issues
+  [node-build-update-defs]: https://github.com/nodenv/node-build-update-defs
+  [Sam Stephenson]: https://github.com/sstephenson
+  [Will McKenzie]: https://github.com/oinutter
+  [ruby-build]: https://github.com/rbenv/ruby-build
+  [ruby-build wiki]: https://github.com/rbenv/ruby-build/wiki

package/bin/node-build

@@ -15,7 +15,7 @@
 #   --version        Show version of node-build
 #
 
-NODE_BUILD_VERSION=5.2.0
+NODE_BUILD_VERSION=5.3.0
 
 OLDIFS="$IFS"
 
@@ -27,10 +27,15 @@ lib() {
   parse_options() {
     OPTIONS=()
     ARGUMENTS=()
+    EXTRA_ARGUMENTS=()
     local arg option index
 
-    for arg in "$@"; do
-      if [ "${arg:0:1}" = "-" ]; then
+    while [ $# -gt 0 ]; do
+      arg="$1"
+      if [ "$arg" == "--" ]; then
+        shift 1
+        break
+      elif [ "${arg:0:1}" = "-" ]; then
         if [ "${arg:1:1}" = "-" ]; then
           OPTIONS[${#OPTIONS[*]}]="${arg:2}"
         else
@@ -41,15 +46,19 @@ lib() {
             index=$((index+1))
           done
         fi
+        shift 1
       else
         ARGUMENTS[${#ARGUMENTS[*]}]="$arg"
+        shift 1
       fi
     done
+
+    EXTRA_ARGUMENTS=("$@")
   }
 
-  if [ "$1" == "--$FUNCNAME" ]; then
-    declare -f "$FUNCNAME"
-    echo "$FUNCNAME \"\$1\";"
+  if [ "$1" == "--${FUNCNAME[0]}" ]; then
+    declare -f "${FUNCNAME[0]}"
+    echo "${FUNCNAME[0]} \"\$1\";"
     exit
   fi
 }
@@ -63,20 +72,21 @@ resolve_link() {
 abs_dirname() {
   local path="$1"
   local cwd
-  cwd="$(pwd)"
+  cwd="$(pwd || true)"
 
   while [ -n "$path" ]; do
-    cd "${path%/*}"
+    cd "${path%/*}" || return 1
     local name="${path##*/}"
     path="$(resolve_link "$name" || true)"
   done
 
   pwd
-  cd "$cwd"
+  cd "$cwd" || return 1
 }
 
 capitalize() {
-  printf "%s" "$1" | tr '[:lower:]' '[:upper:]'
+  # shellcheck disable=SC2018,SC2019
+  printf "%s" "$1" | tr 'a-z' 'A-Z'
 }
 
 sanitize() {
@@ -84,7 +94,7 @@ sanitize() {
 }
 
 colorize() {
-  if [ -t 1 ]; then printf "\\e[%sm%s\\e[m" "$1" "$2"
+  if [ -t 1 ]; then printf "\e[%sm%s\e[m" "$1" "$2"
   else echo -n "$2"
   fi
 }
@@ -95,7 +105,9 @@ os_information() {
   elif type -p sw_vers >/dev/null; then
     echo "$(sw_vers -productName) $(sw_vers -productVersion)"
   elif [ -r /etc/os-release ]; then
+    # shellcheck disable=SC1091
     source /etc/os-release
+    # shellcheck disable=SC2153
     echo "$NAME $VERSION_ID"
   else
     local os
@@ -106,17 +118,26 @@ os_information() {
 
 is_mac() {
   [ "$(uname -s)" = "Darwin" ] || return 1
-  [ $# -eq 0 ] || test "$(osx_version)" "$@"
+  [ $# -eq 0 ] || [ "$(osx_version)" -ge "$1" ]
+}
+
+is_freebsd() {
+  [ "$(uname -s)" = "FreeBSD" ]
+}
+
+freebsd_package_prefix() {
+  local package="$1"
+  pkg info --prefix "$package" 2>/dev/null | cut -wf2
 }
 
 #  9.1  -> 901
 # 10.9  -> 1009
 # 10.10 -> 1010
 osx_version() {
-  local -a ver
-  IFS=. ver=( $(sw_vers -productVersion) )
+  local ver
+  IFS=. read -d "" -r -a ver <<<"$(sw_vers -productVersion)" || true
   IFS="$OLDIFS"
-  echo $(( ${ver[0]}*100 + ${ver[1]} ))
+  echo $(( ver[0]*100 + ver[1] ))
 }
 
 build_failed() {
@@ -132,9 +153,9 @@ build_failed() {
     if ! rmdir "${BUILD_PATH}" 2>/dev/null; then
       echo "Inspect or clean up the working tree at ${BUILD_PATH}"
 
-      if file_is_not_empty "$LOG_PATH"; then
+      if [ -n "$(head -1 "$LOG_PATH" 2>/dev/null)" ]; then
         colorize 33 "Results logged to ${LOG_PATH}"
-        printf "\\n\\n"
+        printf "\n\n"
         echo "Last 10 log lines:"
         tail -n 10 "$LOG_PATH"
       fi
@@ -143,18 +164,6 @@ build_failed() {
   exit 1
 }
 
-file_is_not_empty() {
-  local filename="$1"
-  local line_count="$(wc -l "$filename" 2>/dev/null || true)"
-
-  if [ -n "$line_count" ]; then
-    words=( $line_count )
-    [ "${words[0]}" -gt 0 ]
-  else
-    return 1
-  fi
-}
-
 num_cpu_cores() {
   local num
   case "$(uname -s)" in
@@ -237,18 +246,6 @@ binary() {
   fi
 }
 
-install_package() {
-  install_package_using "tarball" 1 "$@"
-}
-
-install_git() {
-  install_package_using "git" 2 "$@"
-}
-
-install_svn() {
-  install_package_using "svn" 2 "$@"
-}
-
 install_binary() {
   local url name
 
@@ -260,6 +257,14 @@ install_binary() {
   install_package "$name" "$url" copy "${@:2}"
 }
 
+install_package() {
+  install_package_using "tarball" 1 "$@"
+}
+
+install_git() {
+  install_package_using "git" 2 "$@"
+}
+
 install_package_using() {
   local package_type="$1"
   local package_type_nargs="$2"
@@ -270,7 +275,7 @@ install_package_using() {
   local make_args=( "$package_name" )
   local arg last_arg
 
-  for arg in "${@:$(( $package_type_nargs + 1 ))}"; do
+  for arg in "${@:$(( package_type_nargs + 1 ))}"; do
     if [ "$last_arg" = "--if" ]; then
       "$arg" || return 0
     elif [ "$arg" != "--if" ]; then
@@ -287,9 +292,11 @@ install_package_using() {
     return 0
   fi
 
+  # shellcheck disable=SC2164
   pushd "$BUILD_PATH" >&4
   "fetch_${package_type}" "${fetch_args[@]}"
   make_package "${make_args[@]}"
+  # shellcheck disable=SC2164
   popd >&4
 
   { echo "Installed ${package_name} to ${PREFIX_PATH}"
@@ -301,10 +308,12 @@ make_package() {
   local package_name="$1"
   shift
 
+# shellcheck disable=SC2164
   pushd "$package_name" >&4
   before_install_package "$package_name"
   build_package "$package_name" "$@"
   after_install_package "$package_name"
+  # shellcheck disable=SC2164
   popd >&4
 }
 
@@ -361,7 +370,11 @@ has_checksum_support() {
   local has_checksum_var="HAS_CHECKSUM_SUPPORT_${checksum_command}"
 
   if [ -z "${!has_checksum_var+defined}" ]; then
-    printf -v "$has_checksum_var" "$(echo test | "$checksum_command" >/dev/null; echo $?)"
+    if "$checksum_command" <<<"test" >/dev/null; then
+      printf -v "$has_checksum_var" 0 # success
+    else
+      printf -v "$has_checksum_var" 1 # error
+    fi
   fi
   return "${!has_checksum_var}"
 }
@@ -370,7 +383,7 @@ verify_checksum() {
   local checksum_command
   local filename="$1"
   local expected_checksum
-  expected_checksum="$(echo "$2" | tr '[:upper:]' '[:lower:]')"
+  expected_checksum="$(tr 'A-F' 'a-f' <<<"$2")"
 
   # If the specified filename doesn't exist, return success
   [ -e "$filename" ] || return 0
@@ -394,7 +407,7 @@ verify_checksum() {
 
   # If the computed checksum is empty, return failure
   local computed_checksum
-  computed_checksum=$($checksum_command < "$filename" | tr '[:upper:]' '[:lower:]')
+  computed_checksum="$("$checksum_command" < "$filename" | tr 'A-F' 'a-f')"
   [ -n "$computed_checksum" ] || return 1
 
   if [ "$expected_checksum" != "$computed_checksum" ]; then
@@ -431,11 +444,13 @@ detect_http_client() {
 }
 
 http_head_aria2c() {
+  # shellcheck disable=SC2086
   aria2c --dry-run --no-conf=true ${ARIA2_OPTS} "$1" >&4 2>&1
 }
 
 http_get_aria2c() {
   local out="${2:-$(mktemp "out.XXXXXX")}"
+  # shellcheck disable=SC2086
   if aria2c --allow-overwrite=true --no-conf=true -o "${out}" ${ARIA2_OPTS} "$1" >&4; then
     [ -n "$2" ] || cat "${out}"
   else
@@ -444,18 +459,22 @@ http_get_aria2c() {
 }
 
 http_head_curl() {
+  # shellcheck disable=SC2086
   curl -qsILf ${CURL_OPTS} "$1" >&4 2>&1
 }
 
 http_get_curl() {
+  # shellcheck disable=SC2086
   curl -q -o "${2:--}" -sSLf ${CURL_OPTS} "$1"
 }
 
 http_head_wget() {
+  # shellcheck disable=SC2086
   wget -q --spider ${WGET_OPTS} "$1" >&4 2>&1
 }
 
 http_get_wget() {
+  # shellcheck disable=SC2086
   wget -nv ${WGET_OPTS} -O "${2:--}" "$1"
 }
 
@@ -476,7 +495,7 @@ fetch_tarball() {
     package_url="${package_url%%#*}"
 
     if [ -z "$NODE_BUILD_SKIP_MIRROR" ]; then
-      mirror_url="$("${NODE_BUILD_MIRROR_CMD:=mirror}" $package_url $checksum 2>&4)" || unset mirror_url
+      mirror_url="$("${NODE_BUILD_MIRROR_CMD:-mirror}" $package_url $checksum 2>&4)" || unset mirror_url
     fi
   fi
 
@@ -501,11 +520,13 @@ fetch_tarball() {
     local tarball_filename
     tarball_filename="$(basename "$package_url")"
     echo "Downloading ${tarball_filename}..." >&2
+    # shellcheck disable=SC2015
+    http head "$mirror_url" &&
     download_tarball "$mirror_url" "$package_filename" "$checksum" ||
     download_tarball "$package_url" "$package_filename" "$checksum"
   fi
 
-  { if $tar $tar_args "$package_filename"; then
+  { if $tar "$tar_args" "$package_filename"; then
       if [ ! -d "$package_name" ]; then
         extracted_dir="$(find_extracted_directory)"
         mv "$extracted_dir" "$package_name"
@@ -582,22 +603,26 @@ fetch_git() {
 
   if type git &>/dev/null; then
     if [ -n "$NODE_BUILD_CACHE_PATH" ]; then
+      # shellcheck disable=SC2164
       pushd "$NODE_BUILD_CACHE_PATH" >&4
       local clone_name
       clone_name="$(sanitize "$git_url")"
-      if [ -e "${clone_name}" ]; then
-        { cd "${clone_name}"
+      if [ -e "$clone_name" ]; then
+        { # shellcheck disable=SC2164
+          cd "$clone_name"
           git fetch --force "$git_url" "+${git_ref}:${git_ref}"
         } >&4 2>&1
       else
         git clone --bare --branch "$git_ref" "$git_url" "${clone_name}" >&4 2>&1
       fi
       git_url="$NODE_BUILD_CACHE_PATH/${clone_name}"
+      # shellcheck disable=SC2164
       popd >&4
     fi
 
     if [ -e "${package_name}" ]; then
-      ( cd "${package_name}"
+      ( # shellcheck disable=SC2164
+        cd "${package_name}"
         git fetch --depth 1 origin "+${git_ref}"
         git checkout -q -B "$git_ref" "origin/${git_ref}"
       ) >&4 2>&1
@@ -610,23 +635,6 @@ fetch_git() {
   fi
 }
 
-fetch_svn() {
-  local package_name="$1"
-  local svn_url="$2"
-  local svn_rev="$3"
-
-  echo "Checking out ${svn_url}..." >&2
-
-  if type svn &>/dev/null; then
-    svn co -r "$svn_rev" "$svn_url" "${package_name}" >&4 2>&1
-  elif type svnlite &>/dev/null; then
-    svnlite co -r "$svn_rev" "$svn_url" "${package_name}" >&4 2>&1
-  else
-    echo "error: please install Subversion and try again" >&2
-    exit 1
-  fi
-}
-
 build_package() {
   local package_name="$1"
   shift
@@ -649,9 +657,12 @@ build_package() {
 package_option() {
   local package_name="$1"
   local command_name="$2"
-  local variable="$(capitalize "${package_name}_${command_name}")_OPTS_ARRAY"
-  local array="${variable[@]}"
+  local variable
+  # e.g. NODE_CONFIGURE_OPTS_ARRAY, OPENSSL_MAKE_OPTS_ARRAY
+  variable="$(capitalize "${package_name}_${command_name}")_OPTS_ARRAY"
+  local array="${variable}[@]"
   shift 2
+  # shellcheck disable=SC2034
   local value=( "${!array}" "$@" )
   eval "$variable=( \"\${value[@]}\" )"
 }
@@ -699,13 +710,15 @@ build_package_standard_build() {
   ( if [ "${CFLAGS+defined}" ] || [ "${!PACKAGE_CFLAGS+defined}" ]; then
       export CFLAGS="$CFLAGS ${!PACKAGE_CFLAGS}"
     fi
-    if [ -z "$CC" ] && is_mac -ge 1010; then
+    if [ -z "$CC" ] && is_mac 1010; then
       export CC=clang
     fi
+    # shellcheck disable=SC2086,SC2153
     ${!PACKAGE_CONFIGURE:-./configure} --prefix="${!PACKAGE_PREFIX_PATH:-$PREFIX_PATH}" \
       "${!PACKAGE_CONFIGURE_OPTS_ARRAY}" $CONFIGURE_OPTS ${!PACKAGE_CONFIGURE_OPTS} || return 1
   ) >&4 2>&1
 
+  # shellcheck disable=SC2086
   { "$MAKE" "${!PACKAGE_MAKE_OPTS_ARRAY}" $MAKE_OPTS ${!PACKAGE_MAKE_OPTS}
   } >&4 2>&1
 }
@@ -718,6 +731,7 @@ build_package_standard_install() {
   local PACKAGE_MAKE_INSTALL_OPTS="${package_var_name}_MAKE_INSTALL_OPTS"
   local PACKAGE_MAKE_INSTALL_OPTS_ARRAY="${package_var_name}_MAKE_INSTALL_OPTS_ARRAY[@]"
 
+  # shellcheck disable=SC2086
   { "$MAKE" ${MAKE_INSTALL_TARGET:-install} "${!PACKAGE_MAKE_INSTALL_OPTS_ARRAY}" $MAKE_INSTALL_OPTS ${!PACKAGE_MAKE_INSTALL_OPTS}
   } >&4 2>&1
 }
@@ -799,18 +813,35 @@ fix_jxcore_directory_structure() {
   } >&4
 }
 
+# Kept for backward compatibility
+require_java7() {
+  require_java 7
+}
+
+# Kept for backward compatibility
+require_gcc() {
+  :
+}
+
+# Kept for backward compatibility
+require_llvm() {
+  :
+}
+
 # Ensure that directories listed in LDFLAGS exist
 build_package_ldflags_dirs() {
-  local arg dir
-  set - $LDFLAGS
-  while [ $# -gt 0 ]; do
+  local ldflags
+  read -d '' -r -a ldflags <<<"$LDFLAGS" || true
+  local index=0
+  local dir
+  while [ "$index" -lt "${#ldflags[@]}" ]; do
     dir=""
-    case "$1" in
-    -L  ) dir="$2" ;;
-    -L* ) dir="${1#-L}" ;;
+    case "${ldflags[index]}" in
+    -L  ) dir="${ldflags[index+1]}" ;;
+    -L* ) dir="${ldflags[index]#-L}" ;;
     esac
     [ -z "$dir" ] || mkdir -p "$dir"
-    shift 1
+    index=$((index+1))
   done
 }
 
@@ -892,9 +923,11 @@ unset KEEP_BUILD_PATH
 unset HAS_PATCH
 unset IPV4
 unset IPV6
+unset EARLY_EXIT
 
 NODE_BUILD_INSTALL_PREFIX="$(abs_dirname "$0")/.."
 
+# shellcheck disable=SC2206
 IFS=: NODE_BUILD_DEFINITIONS=($NODE_BUILD_DEFINITIONS ${NODE_BUILD_ROOT:-$NODE_BUILD_INSTALL_PREFIX}/share/node-build)
 IFS="$OLDIFS"
 
@@ -903,20 +936,16 @@ parse_options "$@"
 for option in "${OPTIONS[@]}"; do
   case "$option" in
   "h" | "help" )
-    version
-    echo
-    usage 0
+    EARLY_EXIT=help
     ;;
   "definitions" )
-    list_definitions
-    exit 0
+    EARLY_EXIT=list_definitions
     ;;
   "c" | "compile" )
     SKIP_BINARY=true
     ;;
   "l" | "list")
-    list_maintained_versions
-    exit 0
+    EARLY_EXIT=list_maintained_versions
     ;;
   "k" | "keep" )
     KEEP_BUILD_PATH=true
@@ -934,18 +963,61 @@ for option in "${OPTIONS[@]}"; do
     IPV6=true
     ;;
   "version" )
-    version
-    exit 0
+    EARLY_EXIT=version
+    ;;
+  * )
+    printf "node-build: invalid flag '%s'\n" "$option" >&2
+    EARLY_EXIT=usage_error
     ;;
   esac
 done
 
-[ "${#ARGUMENTS[@]}" -eq 2 ] || usage 1 >&2
-
 DEFINITION_PATH="${ARGUMENTS[0]}"
-if [ -z "$DEFINITION_PATH" ]; then
+PREFIX_PATH="${ARGUMENTS[1]}"
+
+if [ -z "$EARLY_EXIT" ] && [ -z "$DEFINITION_PATH" ]; then
+  echo "node-build: missing definition argument" >&2
+  EARLY_EXIT=usage_error
+fi
+
+if [ -z "$EARLY_EXIT" ] && [ -z "$PREFIX_PATH" ]; then
+  echo "node-build: missing prefix argument" >&2
+  EARLY_EXIT=usage_error
+fi
+
+if [ "${#ARGUMENTS[@]}" -gt 2 ]; then
+  echo "node-build: expected at most 2 arguments, got [${ARGUMENTS[*]}]" >&2
+  EARLY_EXIT=usage_error
+fi
+
+if [ "${#EXTRA_ARGUMENTS[@]}" -gt 0 ]; then
+  NODE_CONFIGURE_OPTS_ARRAY=("${EXTRA_ARGUMENTS[@]}")
+fi
+
+case "$EARLY_EXIT" in
+help )
+  version
+  echo
+  usage 0
+  ;;
+version | list_definitions | list_maintained_versions )
+  "$EARLY_EXIT"
+  exit 0
+  ;;
+usage_error )
+  echo >&2
   usage 1 >&2
-elif [ ! -f "$DEFINITION_PATH" ]; then
+  ;;
+'' )
+  ;;
+* )
+  echo "unimplemented EARLY_EXIT: $EARLY_EXIT" >&2
+  exit 1
+  ;;
+esac
+
+# expand the <definition> argument to full path of the definition file
+if [ ! -f "$DEFINITION_PATH" ]; then
   for DEFINITION_DIR in "${NODE_BUILD_DEFINITIONS[@]}"; do
     if [ -f "${DEFINITION_DIR}/${DEFINITION_PATH}" ]; then
       DEFINITION_PATH="${DEFINITION_DIR}/${DEFINITION_PATH}"
@@ -959,10 +1031,8 @@ elif [ ! -f "$DEFINITION_PATH" ]; then
   fi
 fi
 
-PREFIX_PATH="${ARGUMENTS[1]}"
-if [ -z "$PREFIX_PATH" ]; then
-  usage 1 >&2
-elif [ "${PREFIX_PATH#/}" = "$PREFIX_PATH" ]; then
+# normalize the <prefix> argument
+if [ "${PREFIX_PATH#/}" = "$PREFIX_PATH" ]; then
   PREFIX_PATH="${PWD}/${PREFIX_PATH}"
 fi
 
@@ -993,7 +1063,7 @@ if [ -n "$noexec" ]; then
 fi
 
 if [ -z "$MAKE" ]; then
-  if [ "FreeBSD" = "$(uname -s)" ]; then
+  if is_freebsd; then
     # node needs gmake on FreeBSD : https://github.com/nodejs/node/blob/0229e378e80948428cf7baa7b176939e879497cc/BSDmakefile#L7
     export MAKE="gmake"
   else
@@ -1007,21 +1077,20 @@ else
   unset NODE_BUILD_CACHE_PATH
 fi
 
-ARIA2_OPTS="${NODE_BUILD_ARIA2_OPTS} ${IPV4+--disable-ipv6=true} ${IPV6+--disable-ipv6=false}"
-CURL_OPTS="${NODE_BUILD_CURL_OPTS} ${IPV4+--ipv4} ${IPV6+--ipv6}"
-WGET_OPTS="${NODE_BUILD_WGET_OPTS} ${IPV4+--inet4-only} ${IPV6+--inet6-only}"
-
 NODE_BUILD_MIRROR_URL="${NODE_BUILD_MIRROR_URL%/}"
 
 if ! has_checksum_support compute_sha2 ||
-  [ -z "$NODE_BUILD_MIRROR_URL" -a -z "$NODE_BUILD_MIRROR_CMD" -a -z "$NODE_BUILD_MIRROR_PACKAGE_URL" ]; then
+  [ -z "${NODE_BUILD_MIRROR_URL}${NODE_BUILD_MIRROR_CMD}${NODE_BUILD_MIRROR_PACKAGE_URL}" ]; then
   NODE_BUILD_SKIP_MIRROR=true
 fi
 
+ARIA2_OPTS="${NODE_BUILD_ARIA2_OPTS} ${IPV4+--disable-ipv6=true} ${IPV6+--disable-ipv6=false}"
+CURL_OPTS="${NODE_BUILD_CURL_OPTS} ${IPV4+--ipv4} ${IPV6+--ipv6}"
+WGET_OPTS="${NODE_BUILD_WGET_OPTS} ${IPV4+--inet4-only} ${IPV6+--inet6-only}"
+
 SEED="$(date "+%Y%m%d%H%M%S").$$"
 LOG_PATH="${TMP}/node-build.${SEED}.log"
 NODE_BIN="${PREFIX_PATH}/bin/node"
-CWD="$(pwd)"
 
 if [ -z "$NODE_BUILD_BUILD_PATH" ]; then
   BUILD_PATH="$(mktemp -d "${LOG_PATH%.log}.XXXXXX")"
@@ -1033,7 +1102,7 @@ exec 4<> "$LOG_PATH" # open the log file at fd 4
 if [ -n "$VERBOSE" ]; then
   tail -f "$LOG_PATH" &
   TAIL_PID=$!
-  trap "kill $TAIL_PID" SIGINT SIGTERM EXIT
+  trap 'kill $TAIL_PID' SIGINT SIGTERM EXIT
 else
   if [ -z "$NODE_BUILD_TESTING" ]; then
     echo "To follow progress, use 'tail -f $LOG_PATH' or pass --verbose" >&2
@@ -1048,6 +1117,7 @@ unset NODELIB
 
 trap build_failed ERR
 mkdir -p "$BUILD_PATH"
+# shellcheck disable=SC1090
 source "$DEFINITION_PATH"
 [ -z "${KEEP_BUILD_PATH}" ] && rm -fr "$BUILD_PATH"
 trap - ERR

package/bin/nodenv-install

@@ -64,6 +64,23 @@ definitions() {
   node-build --definitions | $(type -p ggrep grep | head -1) -F "$query" || true
 }
 
+suggest_selecting_global() {
+  local version_file
+  version_file="$(nodenv-version-file)"
+  [[ "$version_file" != "$NODENV_ROOT"/version || -e "$version_file" ]] && return 0
+  echo
+  colorize 1 "NOTE:"
+  echo -n " to activate this Node version as the new default, run: "
+  colorize 33 "nodenv global $VERSION_NAME"
+  echo
+}
+
+colorize() {
+  if [ -t 1 ]; then printf "\e[%sm%s\e[m" "$1" "$2"
+  else printf "%s" "$2"
+  fi
+}
+
 indent() {
   sed 's/^/  /'
 }
@@ -86,7 +103,7 @@ for option in "${OPTIONS[@]}"; do
     ;;
   "l" | "list" )
     node-build --list
-    {
+    [ ! -t 1 ] || {
       echo
       echo "Only latest stable releases for each Node implementation are shown."
       echo "Use 'nodenv install --list-all / -L' to show all local versions."
@@ -138,20 +155,19 @@ DEFINITION="${ARGUMENTS[0]}"
 # after the installation process.
 declare -a before_hooks after_hooks
 
+# shellcheck disable=SC2317
 before_install() {
   local hook="$1"
   before_hooks["${#before_hooks[@]}"]="$hook"
 }
 
+# shellcheck disable=SC2317
 after_install() {
   local hook="$1"
   after_hooks["${#after_hooks[@]}"]="$hook"
 }
 
-while IFS=$'\n' read -r script; do
-  scripts+=("$script")
-done < <(nodenv-hooks install)
-
+IFS=$'\n' read -d '' -r -a scripts <<<"$(nodenv-hooks install)" || true
 # shellcheck disable=SC1090
 for script in "${scripts[@]}"; do source "$script"; done
 
@@ -208,9 +224,12 @@ cleanup() {
 
 trap cleanup SIGINT
 
+build_args=(${KEEP:+--keep} ${VERBOSE:+--verbose} ${HAS_PATCH:+--patch} ${SKIP_BINARY:+--compile} "$DEFINITION" "$PREFIX")
+[ ${#EXTRA_ARGUMENTS[@]} -eq 0 ] || build_args+=(-- "${EXTRA_ARGUMENTS[@]}")
+
 # Invoke `node-build` and record the exit status in $STATUS.
 STATUS=0
-node-build $KEEP $VERBOSE $HAS_PATCH $SKIP_BINARY "$DEFINITION" "$PREFIX" || STATUS="$?"
+node-build "${build_args[@]}" || STATUS="$?"
 
 # Display a more helpful message if the definition wasn't found.
 if [ "$STATUS" == "2" ]; then
@@ -225,14 +244,14 @@ if [ "$STATUS" == "2" ]; then
     echo "See all available versions with \`nodenv install --list'."
     echo
     echo -n "If the version you need is missing, try upgrading node-build"
-    if [ "$here" != "${here#$(brew --prefix 2>/dev/null)}" ]; then
-      printf ":\\n\\n"
-      echo "  brew update && brew upgrade node-build"
+    if [ "$here" != "${here#"$(brew --prefix 2>/dev/null)"}" ]; then
+      printf ":\n\n"
+      echo "  brew upgrade node-build"
     elif [ -d "${here}/.git" ]; then
-      printf ":\\n\\n"
+      printf ":\n\n"
       echo "  git -C ${here} pull"
     else
-      printf ".\\n"
+      printf ".\n"
     fi
   } >&2
 fi
@@ -243,6 +262,7 @@ for hook in "${after_hooks[@]}"; do eval "$hook"; done
 # Run `nodenv-rehash` after a successful installation.
 if [ "$STATUS" == "0" ]; then
   nodenv-rehash
+  suggest_selecting_global
 else
   cleanup
 fi

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nodenv/node-build",
-  "version": "5.2.0",
+  "version": "5.3.0",
   "description": "Install NodeJS versions",
   "homepage": "https://github.com/nodenv/node-build#readme",
   "license": "MIT",