@node-red/nodes 2.1.2 → 2.1.6

package/core/common/20-inject.html

@@ -234,7 +234,7 @@
                             }
                         } else if (v[i].vt === "jsonata") {
                             try{jsonata(v[i].v);}catch(e){return false;}
-                        } else if ([i].vt === "json") {
+                        } else if (v[i].vt === "json") {
                             try{JSON.parse(v[i].v);}catch(e){return false;}
                         }
                     }
@@ -353,14 +353,16 @@
         },
         oneditprepare: function() {
             var node = this;
+            var payloadType = node.payloadType;
+
             if (node.payloadType == null) {
                 if (node.payload == "") {
-                    node.payloadType = "date";
+                    payloadType = "date";
                 } else {
-                    node.payloadType = "str";
+                    payloadType = "str";
                 }
             } else if (node.payloadType === 'string' || node.payloadType === 'none') {
-                node.payloadType = "str";
+                payloadType = "str";
             }
 
             $("#inject-time-type-select").on("change", function() {
@@ -557,7 +559,7 @@
                 var payload = {
                     p:'payload',
                     v: node.payload ? node.payload : '',
-                    vt:node.payloadType ? node.payloadType : 'date'
+                    vt:payloadType ? payloadType : 'date'
                 };
                 var topic = {
                     p:'topic',
@@ -573,7 +575,7 @@
                 if (newProp.v === undefined) {
                     if (prop.p === 'payload') {
                         newProp.v = node.payload ? node.payload : '';
-                        newProp.vt = node.payloadType ? node.payloadType : 'date';
+                        newProp.vt = payloadType ? payloadType : 'date';
                     } else if (prop.p === 'topic' && prop.vt === "str") {
                         newProp.v =  node.topic ? node.topic : '';
                     }
@@ -688,9 +690,9 @@
             this.topic = "";
             var result = getProps(items, true);
             this.props = result.props;
-            if(result.payloadType) { this.payloadType = result.payloadType; };
-            if(result.payload) { this.payload = result.payload; };
-            if(result.topic) { this.topic = result.topic; };
+            if(result.hasOwnProperty('payloadType')) { this.payloadType = result.payloadType; };
+            if(result.hasOwnProperty('payload')) { this.payload = result.payload; };
+            if(result.hasOwnProperty('topic')) { this.topic = result.topic; };
         },
         button: {
             enabled: function() {

package/core/common/21-debug.js

@@ -280,6 +280,18 @@ module.exports = function(RED) {
             root: path.join(__dirname,"lib","debug"),
             dotfiles: 'deny'
         };
-        res.sendFile(req.params[0], options);
+        try {
+            res.sendFile(
+                req.params[0],
+                options,
+                 err => {
+                    if (err) {
+                        res.sendStatus(404);
+                    }
+                }
+            )
+        } catch(err) {
+            res.sendStatus(404);
+        }
     });
 };

package/core/function/10-function.html

@@ -91,21 +91,21 @@
         <div id="func-tab-init" style="display:none">
             <div class="form-row node-text-editor-row" style="position:relative">
                 <div style="height: 250px; min-height:150px;" class="node-text-editor" id="node-input-init-editor" ></div>
-                <div style="position: absolute; right:0; bottom: calc(100% - 20px); z-Index: 5;"><button id="node-init-expand-js" class="red-ui-button red-ui-button-small"><i class="fa fa-expand"></i></button></div>
+                <div style="position: absolute; right:0; bottom: calc(100% - 20px); z-Index: 10;"><button id="node-init-expand-js" class="red-ui-button red-ui-button-small"><i class="fa fa-expand"></i></button></div>
             </div>
         </div>
 
         <div id="func-tab-body" style="display:none">
             <div class="form-row node-text-editor-row" style="position:relative">
                 <div style="height: 220px; min-height:150px;" class="node-text-editor" id="node-input-func-editor" ></div>
-                <div style="position: absolute; right:0; bottom: calc(100% - 20px); z-Index: 5;"><button id="node-function-expand-js" class="red-ui-button red-ui-button-small"><i class="fa fa-expand"></i></button></div>
+                <div style="position: absolute; right:0; bottom: calc(100% - 20px); z-Index: 10;"><button id="node-function-expand-js" class="red-ui-button red-ui-button-small"><i class="fa fa-expand"></i></button></div>
             </div>
         </div>
 
         <div id="func-tab-finalize" style="display:none">
             <div class="form-row node-text-editor-row" style="position:relative">
                 <div style="height: 250px; min-height:150px;" class="node-text-editor" id="node-input-finalize-editor" ></div>
-                <div style="position: absolute; right:0; bottom: calc(100% - 20px); z-Index: 5;"><button id="node-finalize-expand-js" class="red-ui-button red-ui-button-small"><i class="fa fa-expand"></i></button></div>
+                <div style="position: absolute; right:0; bottom: calc(100% - 20px); z-Index: 10;"><button id="node-finalize-expand-js" class="red-ui-button red-ui-button-small"><i class="fa fa-expand"></i></button></div>
             </div>
         </div>
 
@@ -512,6 +512,7 @@
                 return function(e) {
                     e.preventDefault();
                     var value = editor.getValue();
+                    var extraLibs = that.libs || [];
                     RED.editor.editJavaScript({
                         value: value,
                         width: "Infinity",
@@ -523,7 +524,8 @@
                             setTimeout(function() {
                                 editor.focus();
                             },300);
-                        }
+                        },
+                        extraLibs: extraLibs
                     })
                 }
             }

package/core/function/10-function.js

@@ -234,8 +234,7 @@ module.exports = function(RED) {
             },
             env: {
                 get: function(envVar) {
-                    var flow = node._flow;
-                    return flow.getSetting(envVar);
+                    return RED.util.getSetting(node, envVar);
                 }
             },
             setTimeout: function () {

package/core/function/89-delay.html

@@ -114,7 +114,8 @@
             timeout: {value:"5", required:true, validate:function(v) { return RED.validators.number(v) && (v >= 0); }},
             timeoutUnits: {value:"seconds"},
             rate: {value:"1", required:true, validate:function(v) { return RED.validators.number(v) && (v >= 0); }},
-            nbRateUnits: {value:"1", required:false, validate:RED.validators.regex(/\d+|/)},
+            nbRateUnits: {value:"1", required:false,
+                          validate:function(v) { return RED.validators.number(v) && (v >= 0); }},
             rateUnits: {value: "second"},
             randomFirst: {value:"1", required:true, validate:function(v) { return RED.validators.number(v) && (v >= 0); }},
             randomLast: {value:"5", required:true, validate:function(v) { return RED.validators.number(v) && (v >= 0); }},

package/core/function/89-delay.js

@@ -372,6 +372,7 @@ module.exports = function(RED) {
                 hit = false;
                 for (var b in node.buffer) { // check if already in queue
                     if (msg.topic === node.buffer[b].msg.topic) {
+                        if (node.outputs === 2) { send([null,node.buffer[b].msg]) }
                         node.buffer[b].done();
                         node.buffer[b] = {msg, send, done}; // if so - replace existing entry
                         hit = true;

package/core/function/rbe.js

@@ -58,7 +58,7 @@ module.exports = function(RED) {
                 else {
                     var n = parseFloat(value);
                     if (!isNaN(n)) {
-                        if ((typeof node.previous[t] === 'undefined') && (this.func === "narrowband")) {
+                        if ((typeof node.previous[t] === 'undefined') && (this.func === "narrowband" || this.func === "narrowbandEq")) {
                             if (node.start === '') { node.previous[t] = n; }
                             else { node.previous[t] = node.start; }
                         }

package/core/network/21-httprequest.js

@@ -298,18 +298,16 @@ in your Node-RED user directory (${RED.settings.userDir}).
             }
             if (Object.keys(this.credentials).length != 0) {
                 if (this.authType === "basic") {
-                    // Workaround for https://github.com/sindresorhus/got/issues/1169
-                    var cred = ""
-                    if (this.credentials.user) {
-                        // opts.username = this.credentials.user;
-                        cred = this.credentials.user
-                    }
-                    if (this.credentials.password) {
-                        // opts.password = this.credentials.password;
-                        cred += ":" + this.credentials.password
+                    // Workaround for https://github.com/sindresorhus/got/issues/1169 (fixed in got v12)
+                    // var cred = ""
+                    if (this.credentials.user || this.credentials.password) {
+                        // cred = `${this.credentials.user}:${this.credentials.password}`;
+                        if (this.credentials.user === undefined) { this.credentials.user = ""}
+                        if (this.credentials.password === undefined) { this.credentials.password = ""}
+                        opts.headers.Authorization = "Basic " + Buffer.from(`${this.credentials.user}:${this.credentials.password}`).toString("base64");
                     }
                     // build own basic auth header
-                    opts.headers.Authorization = "Basic " + Buffer.from(cred).toString("base64");
+                    // opts.headers.Authorization = "Basic " + Buffer.from(cred).toString("base64");
                 } else if (this.authType === "digest") {
                     let digestCreds = this.credentials;
                     let sentCreds = false;

package/core/network/22-websocket.js

@@ -105,22 +105,24 @@ module.exports = function(RED) {
             if (node.isServer) {
                 node._clients[id] = socket;
                 node.emit('opened',{count:Object.keys(node._clients).length,id:id});
-            } else {
-                if (node.heartbeat) {
-                    node.heartbeatInterval = setInterval(function() {
-                        if (socket.nrPendingHeartbeat) {
-                            // No pong received
-                            socket.terminate();
-                            socket.nrErrorHandler(new Error("timeout"));
-                            return;
-                        }
-                        socket.nrPendingHeartbeat = true;
-                        socket.ping();
-                    },node.heartbeat);
-                }
             }
             socket.on('open',function() {
                 if (!node.isServer) {
+                    if (node.heartbeat) {
+                        clearInterval(node.heartbeatInterval);
+                        node.heartbeatInterval = setInterval(function() {
+                            if (socket.nrPendingHeartbeat) {
+                                // No pong received
+                                socket.terminate();
+                                socket.nrErrorHandler(new Error("timeout"));
+                                return;
+                            }
+                            socket.nrPendingHeartbeat = true;
+                            try {
+                                socket.ping();
+                            } catch(err) {}
+                        },node.heartbeat);
+                    }
                     node.emit('opened',{count:'',id:id});
                 }
             });

package/examples/common/link/03 - Link call.json

@@ -0,0 +1,156 @@
+[
+    {
+        "id": "62ea32aa.d73aac",
+        "type": "comment",
+        "z": "6312c0588348b2d4",
+        "name": "Example: Link Call Node",
+        "info": "Link call node can call link in node then get result from link out node.",
+        "x": 230,
+        "y": 180,
+        "wires": []
+    },
+    {
+        "id": "c588bc36.87fec",
+        "type": "comment",
+        "z": "6312c0588348b2d4",
+        "name": "↓ call link in node",
+        "info": "",
+        "x": 440,
+        "y": 220,
+        "wires": []
+    },
+    {
+        "id": "cd31efb4d2c6967e",
+        "type": "link call",
+        "z": "6312c0588348b2d4",
+        "name": "",
+        "links": [
+            "dbc46892c8d14c37"
+        ],
+        "timeout": "30",
+        "x": 420,
+        "y": 260,
+        "wires": [
+            [
+                "c3db64d1d2260340"
+            ]
+        ]
+    },
+    {
+        "id": "dbc46892c8d14c37",
+        "type": "link in",
+        "z": "6312c0588348b2d4",
+        "name": "",
+        "links": [],
+        "x": 315,
+        "y": 340,
+        "wires": [
+            [
+                "e10575d73f2e5352"
+            ]
+        ]
+    },
+    {
+        "id": "6b61792143b3b0a3",
+        "type": "inject",
+        "z": "6312c0588348b2d4",
+        "name": "",
+        "props": [
+            {
+                "p": "payload"
+            },
+            {
+                "p": "topic",
+                "vt": "str"
+            }
+        ],
+        "repeat": "",
+        "crontab": "",
+        "once": false,
+        "onceDelay": 0.1,
+        "topic": "",
+        "payload": "",
+        "payloadType": "date",
+        "x": 240,
+        "y": 260,
+        "wires": [
+            [
+                "cd31efb4d2c6967e"
+            ]
+        ]
+    },
+    {
+        "id": "e10575d73f2e5352",
+        "type": "change",
+        "z": "6312c0588348b2d4",
+        "name": "",
+        "rules": [
+            {
+                "t": "set",
+                "p": "payload",
+                "pt": "msg",
+                "to": "Hello, World!",
+                "tot": "str"
+            }
+        ],
+        "action": "",
+        "property": "",
+        "from": "",
+        "to": "",
+        "reg": false,
+        "x": 450,
+        "y": 340,
+        "wires": [
+            [
+                "cf8438e7137bc0f0"
+            ]
+        ]
+    },
+    {
+        "id": "cf8438e7137bc0f0",
+        "type": "link out",
+        "z": "6312c0588348b2d4",
+        "name": "",
+        "mode": "return",
+        "links": [],
+        "x": 595,
+        "y": 340,
+        "wires": []
+    },
+    {
+        "id": "c3db64d1d2260340",
+        "type": "debug",
+        "z": "6312c0588348b2d4",
+        "name": "",
+        "active": true,
+        "tosidebar": true,
+        "console": false,
+        "tostatus": false,
+        "complete": "false",
+        "statusVal": "",
+        "statusType": "auto",
+        "x": 600,
+        "y": 260,
+        "wires": []
+    },
+    {
+        "id": "6d077dfa0987febb",
+        "type": "comment",
+        "z": "6312c0588348b2d4",
+        "name": "↑called from link call node",
+        "info": "",
+        "x": 410,
+        "y": 380,
+        "wires": []
+    },
+    {
+        "id": "53b9a0adfd8c4217",
+        "type": "comment",
+        "z": "6312c0588348b2d4",
+        "name": "↑return to link call node",
+        "info": "",
+        "x": 680,
+        "y": 380,
+        "wires": []
+    }
+]

package/examples/storage/{file/01 - Write string to a file.json → read file/01 - Read string from a file.json }

@@ -2,7 +2,7 @@
     {
         "id": "84222b92.d65d18",
         "type": "inject",
-        "z": "4b63452d.672afc",
+        "z": "6312c0588348b2d4",
         "name": "",
         "props": [
             {
@@ -20,8 +20,8 @@
         "topic": "",
         "payload": "Hello, World!",
         "payloadType": "str",
-        "x": 230,
-        "y": 200,
+        "x": 190,
+        "y": 180,
         "wires": [
             [
                 "b4b9f603.739598"
@@ -31,25 +31,25 @@
     {
         "id": "7b014430.dfd94c",
         "type": "comment",
-        "z": "4b63452d.672afc",
+        "z": "6312c0588348b2d4",
         "name": "Write string to a file, then read from the file",
-        "info": "File node can write string to a file.",
-        "x": 260,
-        "y": 120,
+        "info": "Read file node can read string from a file.",
+        "x": 220,
+        "y": 100,
         "wires": []
     },
     {
         "id": "b4b9f603.739598",
         "type": "file",
-        "z": "4b63452d.672afc",
+        "z": "6312c0588348b2d4",
         "name": "",
         "filename": "/tmp/hello.txt",
         "appendNewline": true,
         "createDir": false,
         "overwriteFile": "true",
         "encoding": "none",
-        "x": 420,
-        "y": 200,
+        "x": 380,
+        "y": 180,
         "wires": [
             [
                 "6dc01cac.5c4bf4"
@@ -59,7 +59,7 @@
     {
         "id": "2587adb9.7e60f2",
         "type": "debug",
-        "z": "4b63452d.672afc",
+        "z": "6312c0588348b2d4",
         "name": "",
         "active": true,
         "tosidebar": true,
@@ -68,22 +68,22 @@
         "complete": "false",
         "statusVal": "",
         "statusType": "auto",
-        "x": 810,
-        "y": 200,
+        "x": 770,
+        "y": 180,
         "wires": []
     },
     {
         "id": "6dc01cac.5c4bf4",
         "type": "file in",
-        "z": "4b63452d.672afc",
+        "z": "6312c0588348b2d4",
         "name": "",
         "filename": "/tmp/hello.txt",
         "format": "utf8",
         "chunk": false,
         "sendError": false,
         "encoding": "none",
-        "x": 620,
-        "y": 200,
+        "x": 580,
+        "y": 180,
         "wires": [
             [
                 "2587adb9.7e60f2"
@@ -93,21 +93,21 @@
     {
         "id": "f4b4309a.3b78a",
         "type": "comment",
-        "z": "4b63452d.672afc",
+        "z": "6312c0588348b2d4",
         "name": "↑read result from file",
         "info": "",
-        "x": 630,
-        "y": 240,
+        "x": 590,
+        "y": 220,
         "wires": []
     },
     {
         "id": "672d3693.3cabd8",
         "type": "comment",
-        "z": "4b63452d.672afc",
+        "z": "6312c0588348b2d4",
         "name": "↓write to /tmp/hello.txt",
         "info": "",
-        "x": 440,
-        "y": 160,
+        "x": 400,
+        "y": 140,
         "wires": []
     }
 ]

package/examples/storage/{file-in → read file}/02 - Read data in specified encoding.json

@@ -2,7 +2,7 @@
     {
         "id": "8997398f.c5d628",
         "type": "inject",
-        "z": "194a3e4f.a92772",
+        "z": "6312c0588348b2d4",
         "name": "",
         "props": [
             {
@@ -20,8 +20,8 @@
         "topic": "",
         "payload": "😀",
         "payloadType": "str",
-        "x": 210,
-        "y": 480,
+        "x": 170,
+        "y": 260,
         "wires": [
             [
                 "56e32d23.050f44"
@@ -31,25 +31,25 @@
     {
         "id": "4e598e65.1799d",
         "type": "comment",
-        "z": "194a3e4f.a92772",
+        "z": "6312c0588348b2d4",
         "name": "Read data in specified encoding",
-        "info": "File-in node can specify encoding of data read from a file.",
-        "x": 230,
-        "y": 400,
+        "info": "Read file node can specify encoding of data read from a file.",
+        "x": 190,
+        "y": 180,
         "wires": []
     },
     {
         "id": "56e32d23.050f44",
         "type": "file",
-        "z": "194a3e4f.a92772",
+        "z": "6312c0588348b2d4",
         "name": "",
         "filename": "/tmp/hello.txt",
         "appendNewline": true,
         "createDir": false,
         "overwriteFile": "true",
         "encoding": "none",
-        "x": 380,
-        "y": 480,
+        "x": 340,
+        "y": 260,
         "wires": [
             [
                 "38fa0579.f2cd8a"
@@ -59,7 +59,7 @@
     {
         "id": "d28c8994.99c0a8",
         "type": "debug",
-        "z": "194a3e4f.a92772",
+        "z": "6312c0588348b2d4",
         "name": "",
         "active": true,
         "tosidebar": true,
@@ -68,22 +68,23 @@
         "complete": "false",
         "statusVal": "",
         "statusType": "auto",
-        "x": 770,
-        "y": 480,
+        "x": 730,
+        "y": 260,
         "wires": []
     },
     {
         "id": "38fa0579.f2cd8a",
         "type": "file in",
-        "z": "194a3e4f.a92772",
+        "z": "6312c0588348b2d4",
         "name": "",
         "filename": "/tmp/hello.txt",
         "format": "utf8",
         "chunk": false,
         "sendError": false,
         "encoding": "base64",
-        "x": 580,
-        "y": 480,
+        "allProps": false,
+        "x": 540,
+        "y": 260,
         "wires": [
             [
                 "d28c8994.99c0a8"
@@ -93,21 +94,21 @@
     {
         "id": "fa22ca20.ae4528",
         "type": "comment",
-        "z": "194a3e4f.a92772",
+        "z": "6312c0588348b2d4",
         "name": "↑read data from file as base64 string",
         "info": "",
-        "x": 640,
-        "y": 520,
+        "x": 600,
+        "y": 300,
         "wires": []
     },
     {
         "id": "148e25ad.98891a",
         "type": "comment",
-        "z": "194a3e4f.a92772",
+        "z": "6312c0588348b2d4",
         "name": "↓write to /tmp/hello.txt",
         "info": "",
-        "x": 400,
-        "y": 440,
+        "x": 360,
+        "y": 220,
         "wires": []
     }
 ]