@node-core/utils 5.10.0 → 5.12.0

package/bin/git-node.js

@@ -27,4 +27,6 @@ Promise.all(commandFiles.map(importCommand)).then((commands) => {
     .epilogue(epilogue)
     .help('help')
     .parse();
+}).catch((err) => {
+  throw err;
 });

package/bin/ncu-ci.js

@@ -115,9 +115,9 @@ const args = yargs(hideBin(process.argv))
           type: 'number'
         })
         .positional('certify-safe', {
-          describe: 'If not provided, the command will reject PRs that have ' +
-                    'been pushed since the last review',
-          type: 'boolean'
+          describe: 'SHA of the commit that is expected to be at the tip of the PR head. ' +
+                    'If not provided, the command will use the SHA of the last approved commit.',
+          type: 'string'
         })
         .option('owner', {
           default: '',

package/components/git/metadata.js

@@ -90,5 +90,6 @@ export function handler(argv) {
       if (status === false) {
         throw new Error(IGNORE);
       }
+      return undefined;
     }));
 }

package/components/git/release.js

@@ -112,9 +112,10 @@ function release(state, argv) {
 }
 
 async function main(state, argv, cli, dir) {
-  const prID = /^(?:https:\/\/github\.com\/nodejs\/node\/pull\/)?(\d+)$/.exec(argv.prid);
+  const prID = /^(?:https:\/\/github\.com\/nodejs(-private)?\/node\1\/pull\/)?(\d+)$/.exec(argv.prid);
   if (prID) {
-    argv.prid = Number(prID[1]);
+    if (prID[1]) argv.security = true;
+    argv.prid = Number(prID[2]);
   }
   if (state === PREPARE) {
     const release = new ReleasePreparation(argv, cli, dir);

package/lib/ci/build-types/health_build.js

@@ -20,10 +20,10 @@ class Health {
   formatAsMarkdown() {
     const { success, pending, aborted, failed, unstable, count } = this;
     const rate = `${(success / (count - pending - aborted) * 100).toFixed(2)}%`;
-    // eslint-disable-next-line max-len
-    let result = '| UTC Time         | RUNNING | SUCCESS | UNSTABLE | ABORTED | FAILURE | Green Rate |\n';
-    // eslint-disable-next-line max-len
-    result += '| ---------------- | ------- | ------- | -------- | ------- | ------- | ---------- |\n';
+    let result =
+      '| UTC Time         | RUNNING | SUCCESS | UNSTABLE | ABORTED | FAILURE | Green Rate |\n';
+    result +=
+      '| ---------------- | ------- | ------- | -------- | ------- | ------- | ---------- |\n';
     const time = new Date().toISOString().slice(0, 16).replace('T', ' ');
     result += `| ${time} | ${pad(pending, 7)} | ${pad(success, 8)}|`;
     result += ` ${pad(unstable, 8)} | ${pad(aborted, 7)} | ${pad(failed, 7)} |`;

package/lib/ci/build-types/test_build.js

@@ -76,6 +76,8 @@ export class TestBuild extends Job {
         return result;
       }
     }
+
+    return undefined;
   }
 
   get commit() {

package/lib/ci/ci_failure_parser.js

@@ -204,7 +204,6 @@ const FAILURE_FILTERS = [{
       context: { index: 0, contextBefore: 0, contextAfter: 0 }
     }, {
       pattern:
-        // eslint-disable-next-line max-len
         /error: Your local changes to the following files[\s\S]+Failed to merge in the changes./g,
       context: { index: 0, contextBefore: 0, contextAfter: 0 }
     }, {

package/lib/ci/run_ci.js

@@ -27,7 +27,7 @@ export class RunPRJob {
     this.certifySafe =
       certifySafe ||
       Promise.all([this.prData.getReviews(), this.prData.getPR()]).then(() =>
-        new PRChecker(cli, this.prData, request, {}).checkCommitsAfterReviewOrLabel()
+        (this.certifySafe = new PRChecker(cli, this.prData, request, {}).getApprovedTipOfHead())
       );
   }
 
@@ -45,6 +45,7 @@ export class RunPRJob {
     payload.append('json', JSON.stringify({
       parameter: [
         { name: 'CERTIFY_SAFE', value: 'on' },
+        { name: 'COMMIT_SHA_CHECK', value: this.certifySafe },
         { name: 'TARGET_GITHUB_ORG', value: this.owner },
         { name: 'TARGET_REPO_NAME', value: this.repo },
         { name: 'PR_ID', value: this.prid },

package/lib/cli.js

@@ -81,6 +81,7 @@ export default class CLI {
       return defaultAnswer;
     }
 
+    // eslint-disable-next-line import/namespace -- Plugin can't validate computed reference here
     const answer = await inquirer[questionType]({
       message: question,
       default: defaultAnswer

package/lib/collaborators.js

@@ -105,7 +105,6 @@ function parseCollaborators(readme, cli) {
 
   // We also assume that TSC & TSC Emeriti are also listed as collaborators
   CONTACT_RE.lastIndex = tscIndex;
-  // eslint-disable-next-line no-cond-assign
   while ((m = CONTACT_RE.exec(readme)) && CONTACT_RE.lastIndex < tscrIndex) {
     const login = m[1].toLowerCase();
     const user = new Collaborator(m[1], m[2], m[3], TSC);
@@ -113,7 +112,6 @@ function parseCollaborators(readme, cli) {
   }
 
   CONTACT_RE.lastIndex = clIndex;
-  // eslint-disable-next-line no-cond-assign
   while ((m = CONTACT_RE.exec(readme)) &&
     CONTACT_RE.lastIndex < cleIndex) {
     const login = m[1].toLowerCase();

package/lib/pr_checker.js

@@ -524,38 +524,17 @@ export default class PRChecker {
     return true;
   }
 
-  async checkCommitsAfterReviewOrLabel() {
-    if (this.checkCommitsAfterReview()) return true;
-
-    await Promise.all([this.data.getLabeledEvents(), this.data.getCollaborators()]);
-
-    const {
-      cli, data, pr
-    } = this;
-
-    const { updatedAt } = pr.timelineItems;
-    const requestCiLabels = data.labeledEvents.findLast(
-      ({ createdAt, label: { name } }) => name === 'request-ci' && createdAt > updatedAt
-    );
-    if (requestCiLabels == null) return false;
-
-    const { actor: { login } } = requestCiLabels;
-    const collaborators = Array.from(data.collaborators.values(),
-      (c) => c.login.toLowerCase());
-    if (collaborators.includes(login.toLowerCase())) {
-      cli.info('request-ci label was added by a Collaborator after the last push event.');
-      return true;
-    }
-
-    return false;
-  }
-
-  checkCommitsAfterReview() {
+  getApprovedTipOfHead() {
     const {
       commits, reviews, cli, argv
     } = this;
     const { maxCommits } = argv;
 
+    if (commits.length === 0) {
+      cli.warn('No commits found');
+      return false;
+    }
+
     const reviewIndex = reviews.findLastIndex(
       review => review.authorCanPushToRepository && review.state === 'APPROVED'
     );
@@ -565,45 +544,32 @@ export default class PRChecker {
       return false;
     }
 
-    const reviewDate = reviews[reviewIndex].publishedAt;
-
-    const afterCommits = [];
-    commits.forEach((commit) => {
-      commit = commit.commit;
-      if (commit.committedDate > reviewDate) {
-        afterCommits.push(commit);
-      }
-    });
-
-    const totalCommits = afterCommits.length;
-    if (totalCommits === 0 && this.pr.timelineItems.updatedAt > reviewDate) {
-      // Some commits were pushed, but all the commits have a commit date prior
-      // to the last review. It means that either that a long time elapsed
-      // between the commit and the push, or that the clock on the dev machine
-      // is wrong, or the commit date was forged.
-      cli.warn('Something was pushed to the Pull Request branch since the last approving review.');
-      return false;
-    }
+    const reviewedCommitIndex = commits
+      .findLastIndex(({ commit }) => commit.oid === reviews[reviewIndex].commit.oid);
 
-    if (totalCommits > 0) {
+    if (reviewedCommitIndex !== commits.length - 1) {
       cli.warn('Commits were pushed since the last approving review:');
-      const sliceLength = maxCommits === 0 ? totalCommits : -maxCommits;
-      afterCommits.slice(sliceLength)
-        .forEach(commit => {
+      commits.slice(Math.max(reviewedCommitIndex + 1, commits.length - maxCommits))
+        .forEach(({ commit }) => {
           cli.warn(`- ${commit.messageHeadline}`);
         });
 
+      const totalCommits = commits.length - reviewedCommitIndex - 1;
       if (totalCommits > maxCommits) {
         const infoMsg = '...(use `' +
-          `--max-commits ${totalCommits}` +
-          '` to see the full list of commits)';
+        `--max-commits ${totalCommits}` +
+        '` to see the full list of commits)';
         cli.warn(infoMsg);
       }
 
       return false;
     }
 
-    return true;
+    return reviews[reviewIndex].commit.oid;
+  }
+
+  checkCommitsAfterReview() {
+    return !!this.getApprovedTipOfHead();
   }
 
   checkMergeableState() {

package/lib/pr_data.js

@@ -5,7 +5,6 @@ import {
 } from './user_status.js';
 
 // lib/queries/*.gql file names
-const LABELED_EVENTS_QUERY = 'PRLabeledEvents';
 const PR_QUERY = 'PR';
 const REVIEWS_QUERY = 'Reviews';
 const COMMENTS_QUERY = 'PRComments';
@@ -34,7 +33,6 @@ export default class PRData {
     this.comments = [];
     this.commits = [];
     this.reviewers = [];
-    this.labeledEvents = [];
   }
 
   getThread() {
@@ -92,14 +90,6 @@ export default class PRData {
     ]);
   }
 
-  async getLabeledEvents() {
-    const { prid, owner, repo, cli, request, prStr } = this;
-    const vars = { prid, owner, repo };
-    cli.updateSpinner(`Getting labels from ${prStr}`);
-    this.labeledEvents = (await request.gql(LABELED_EVENTS_QUERY, vars))
-      .repository.pullRequest.timelineItems.nodes;
-  }
-
   async getComments() {
     const { prid, owner, repo, cli, request, prStr } = this;
     const vars = { prid, owner, repo };

package/lib/prepare_release.js

@@ -40,7 +40,7 @@ export default class ReleasePreparation extends Session {
     const { cli } = this;
 
     cli.warn(`PR#${pr.number} - ${pr.title} is not 'MERGEABLE'.
-      So, it will be skipped. Status: ${pr.mergeable}`);
+      Status: ${pr.mergeable}`);
   }
 
   async getOpenPRs(filterLabels) {
@@ -66,7 +66,6 @@ export default class ReleasePreparation extends Session {
     for (const pr of prs) {
       if (pr.mergeable !== 'MERGEABLE') {
         this.warnForNonMergeablePR(pr);
-        continue;
       }
       const cp = new CherryPick(pr.number, this.dir, cli, {
         owner: this.owner,
@@ -93,9 +92,9 @@ export default class ReleasePreparation extends Session {
     } = this;
 
     // Create new proposal branch.
-    cli.startSpinner(`Creating new proposal branch for ${newVersion}`);
+    cli.startSpinner(`Switching to proposal branch for ${newVersion}`);
     const proposalBranch = await this.createProposalBranch(releaseBranch);
-    cli.stopSpinner(`Created new proposal branch for ${newVersion}`);
+    cli.stopSpinner(`Switched to proposal branch for ${newVersion}`);
 
     const success = await this.cherryPickSecurityPRs(filterLabels);
     if (!success) {
@@ -201,9 +200,9 @@ export default class ReleasePreparation extends Session {
     }
 
     // Create new proposal branch.
-    cli.startSpinner(`Creating new proposal branch for ${newVersion}`);
+    cli.startSpinner(`Switching to proposal branch for ${newVersion}`);
     await this.createProposalBranch();
-    cli.stopSpinner(`Created new proposal branch for ${newVersion}`);
+    cli.stopSpinner(`Switched to proposal branch for ${newVersion}`);
 
     if (this.isLTSTransition) {
       // For releases transitioning into LTS, fetch the new code name.
@@ -482,11 +481,14 @@ export default class ReleasePreparation extends Session {
     const data = await fs.readFile(majorChangelogPath, 'utf8');
     const arr = data.split('\n');
     const allCommits = this.getChangelog();
-    const notableChanges = await this.getBranchDiff({ onlyNotableChanges: true });
+    const notableChanges = await this.getBranchDiff({
+      onlyNotableChanges: true,
+      format: isSecurityRelease ? 'messageonly' : 'markdown',
+    });
     let releaseHeader = `## ${date}, Version ${newVersion}` +
                           ` ${releaseInfo}, @${username}\n`;
     if (isSecurityRelease) {
-      releaseHeader += '\nThis is a security release.';
+      releaseHeader += '\nThis is a security release.\n';
     }
 
     const topHeader =
@@ -541,7 +543,7 @@ export default class ReleasePreparation extends Session {
 
     await runAsync('git', [
       'checkout',
-      '-b',
+      '-B',
       proposalBranch,
       base
     ]);
@@ -620,7 +622,7 @@ export default class ReleasePreparation extends Session {
 
     const notableChanges = await this.getBranchDiff({
       onlyNotableChanges: true,
-      format: 'plaintext'
+      format: isSecurityRelease ? 'messageonly' : 'plaintext'
     });
     messageBody.push('Notable changes:\n\n');
     if (isLTSTransition) {

package/lib/prepare_security.js

@@ -52,24 +52,27 @@ export default class PrepareSecurityRelease extends SecurityRelease {
     await this.closeAndRequestDisclosure(vulnerabilityJSON.reports);
 
     this.cli.info('Closing pull requests');
-    // For now, close the ones with vN.x label
-    await this.closePRWithLabel(this.getAffectedVersions(vulnerabilityJSON));
+    // For now, close the ones with Security Release label
+    await this.closePRWithLabel('Security Release');
 
-    const updateFolder = this.cli.prompt(
-      // eslint-disable-next-line max-len
-      `Would you like to update the next-security-release folder to ${vulnerabilityJSON.releaseDate}?`,
+    const updateFolder = await this.cli.prompt(
+      `Would you like to update the next-security-release folder to ${
+        vulnerabilityJSON.releaseDate}?`,
       { defaultAnswer: true });
     if (updateFolder) {
-      const newFolder = this.updateReleaseFolder(vulnerabilityJSON.releaseDate);
+      this.updateReleaseFolder(
+        vulnerabilityJSON.releaseDate.replaceAll('/', '-')
+      );
+      const securityReleaseFolder = path.join(process.cwd(), 'security-release');
       commitAndPushVulnerabilitiesJSON(
-        newFolder,
+        securityReleaseFolder,
         'chore: change next-security-release folder',
         { cli: this.cli, repository: this.repository }
       );
     }
     this.cli.info(`Merge pull request with:
         - git checkout main
-        - git merge --squash ${NEXT_SECURITY_RELEASE_BRANCH}
+        - git merge ${NEXT_SECURITY_RELEASE_BRANCH} --no-ff -m "chore: add latest security release"
         - git push origin main`);
     this.cli.ok('Done!');
   }
@@ -306,16 +309,17 @@ export default class PrepareSecurityRelease extends SecurityRelease {
       labels = [labels];
     }
 
-    const url = 'https://github.com/nodejs-private/node-private/pulls';
+    const url = 'https://github.com/nodejs-private/node-private/pull';
     this.cli.startSpinner('Closing GitHub Pull Requests...');
     // At this point, GitHub does not provide filters through their REST API
-    const prs = this.req.getPullRequest(url);
+    const prs = await this.req.getPullRequest(url);
     for (const pr of prs) {
-      if (pr.labels.some((l) => labels.includes(l))) {
-        this.cli.updateSpinner(`Closing Pull Request: ${pr.id}`);
-        await this.req.closePullRequest(pr.id);
+      if (pr.labels.some((l) => labels.includes(l.name))) {
+        this.cli.updateSpinner(`Closing Pull Request: ${pr.number}`);
+        await this.req.closePullRequest(pr.number,
+          { owner: 'nodejs-private', repo: 'node-private' });
       }
     }
-    this.cli.startSpinner('Closed GitHub Pull Requests.');
+    this.cli.stopSpinner('Closed GitHub Pull Requests.');
   }
 }

package/lib/promote_release.js

@@ -19,6 +19,10 @@ export default class ReleasePromotion extends Session {
   constructor(argv, req, cli, dir) {
     super(cli, dir, argv.prid);
     this.req = req;
+    if (argv.security) {
+      this.config.owner = 'nodejs-private';
+      this.config.repo = 'node-private';
+    }
     this.dryRun = !argv.run;
     this.isLTS = false;
     this.ltsCodename = '';
@@ -226,20 +230,28 @@ export default class ReleasePromotion extends Session {
 
   async verifyTagSignature() {
     const { cli, version } = this;
-    const [needle, haystack] = await Promise.all([forceRunAsync(
+    const verifyTagPattern = /gpg:[^\n]+\ngpg:\s+using RSA key ([^\n]+)\ngpg:\s+issuer "([^"]+)"\ngpg:\s+Good signature from "([^<]+) <\2>"/;
+    const [verifyTagOutput, haystack] = await Promise.all([forceRunAsync(
       'git', ['--no-pager',
-        'log', '-1',
-        `refs/tags/v${version}`,
-        '--format=* **%an** <<%ae>>\n  `%GF`'
-      ], { captureStdout: true }), fs.readFile('README.md')]);
-    if (haystack.includes(needle)) {
-      return;
+        'verify-tag',
+        `v${version}`
+      ], { ignoreFailure: false, captureStderr: true }), fs.readFile('README.md')]);
+    const match = verifyTagPattern.exec(verifyTagOutput);
+    if (match == null) {
+      cli.warn('git was not able to verify the tag:');
+      cli.info(verifyTagOutput);
+    } else {
+      const [, keyID, email, name] = match;
+      const needle = `* **${name}** <<${email}>>\n  ${'`'}${keyID}${'`'}`;
+      if (haystack.includes(needle)) {
+        return;
+      }
+      cli.warn('Tag was signed with an undocumented identity/key pair!');
+      cli.info('Expected to find the following entry in the README:');
+      cli.info(needle);
+      cli.info('If you are using a subkey, it might be OK.');
     }
-    cli.warn('Tag was signed with an undocumented identity/key pair!');
-    cli.info('Expected to find the following entry in the README:');
-    cli.info(needle);
-    cli.info('If you are using a subkey, it might be OK.');
-    cli.info(`Otherwise consider removing the tag (git tag -d v${version
+    cli.info(`If that doesn't sound right, consider removing the tag (git tag -d v${version
              }), check your local config, and start the process over.`);
     if (!await cli.prompt('Do you want to proceed anyway?', { defaultAnswer: false })) {
       throw new Error('Aborted');
@@ -383,7 +395,6 @@ export default class ReleasePromotion extends Session {
           { cause: err }
         );
       }
-      await forceRunAsync('git', ['tag', '--verify', `v${version}`], { ignoreFailure: false });
       this.cli.info('Using the existing tag');
     }
   }
@@ -391,7 +402,7 @@ export default class ReleasePromotion extends Session {
   // Set up the branch so that nightly builds are produced with the next
   // version number and a pre-release tag.
   async setupForNextRelease() {
-    const { versionComponents, prid } = this;
+    const { versionComponents, prid, owner, repo } = this;
 
     // Update node_version.h for next patch release.
     const filePath = path.resolve('src', 'node_version.h');
@@ -422,7 +433,7 @@ export default class ReleasePromotion extends Session {
       '-m',
       `Working on ${workingOnVersion}`,
       '-m',
-      `PR-URL: https://github.com/nodejs/node/pull/${prid}`
+      `PR-URL: https://github.com/${owner}/${repo}/pull/${prid}`
     ], { ignoreFailure: false });
     const workingOnNewReleaseCommit = await forceRunAsync('git', ['rev-parse', 'HEAD'],
       { ignoreFailure: false, captureStdout: true });

package/lib/queries/PR.gql

@@ -23,9 +23,6 @@ query PR($prid: Int!, $owner: String!, $repo: String!) {
           path
         }
       },
-      timelineItems(itemTypes: [HEAD_REF_FORCE_PUSHED_EVENT, PULL_REQUEST_COMMIT]) {
-        updatedAt
-      },
       title,
       baseRefName,
       headRefName,

package/lib/release/utils.js

@@ -21,12 +21,10 @@ export function getStartLTSBlurb({ date, ltsCodename, versionComponents }) {
   const eol = eolDate.toLocaleString('en-US', dateFormat);
   const { major } = versionComponents;
   return [
-    /* eslint-disable max-len */
     `This release marks the transition of Node.js ${major}.x into Long Term Support (LTS)`,
     `with the codename '${ltsCodename}'. The ${major}.x release line now moves into "Active LTS"`,
     `and will remain so until ${mainStart}. After that time, it will move into`,
     `"Maintenance" until end of life in ${eol}.`
-    /* eslint-enable */
   ].join('\n');
 }
 

package/lib/request.js

@@ -109,14 +109,15 @@ export default class Request {
     return this.json(url, options);
   }
 
-  async closePullRequest({ owner, repo }) {
-    const url = `https://api.github.com/repos/${owner}/${repo}/pulls`;
+  async closePullRequest(id, { owner, repo }) {
+    const url = `https://api.github.com/repos/${owner}/${repo}/pulls/${id}`;
     const options = {
       method: 'POST',
       headers: {
         Authorization: `Basic ${this.credentials.github}`,
         'User-Agent': 'node-core-utils',
-        Accept: 'application/vnd.github+json'
+        Accept: 'application/vnd.github+json',
+        'Content-Type': 'application/json'
       },
       body: JSON.stringify({
         state: 'closed'
@@ -230,7 +231,8 @@ export default class Request {
       headers: {
         Authorization: `Basic ${this.credentials.h1}`,
         'User-Agent': 'node-core-utils',
-        Accept: 'application/json'
+        Accept: 'application/json',
+        'Content-Type': 'application/json'
       },
       body: JSON.stringify({
         data: {
@@ -252,11 +254,13 @@ export default class Request {
       headers: {
         Authorization: `Basic ${this.credentials.h1}`,
         'User-Agent': 'node-core-utils',
-        Accept: 'application/json'
+        Accept: 'application/json',
+        'Content-Type': 'application/json'
       },
       body: JSON.stringify({
         data: {
           attributes: {
+            message: 'Requesting disclosure',
             // default to limited version
             substate: 'no-content'
           }

package/lib/run.js

@@ -12,14 +12,19 @@ function runAsyncBase(cmd, args, {
   ignoreFailure = true,
   spawnArgs,
   input,
+  captureStderr = false,
   captureStdout = false
 } = {}) {
   if (cmd instanceof URL) {
     cmd = fileURLToPath(cmd);
   }
   let stdio = 'inherit';
-  if (captureStdout || input != null) {
-    stdio = [input == null ? 'inherit' : 'pipe', captureStdout ? 'pipe' : 'inherit', 'inherit'];
+  if (captureStderr || captureStdout || input != null) {
+    stdio = [
+      input == null ? 'inherit' : 'pipe',
+      captureStdout ? 'pipe' : 'inherit',
+      captureStderr ? 'pipe' : 'inherit'
+    ];
   }
   return new Promise((resolve, reject) => {
     const opt = Object.assign({
@@ -30,6 +35,12 @@ function runAsyncBase(cmd, args, {
       debuglog('[Spawn]', `${cmd} ${(args || []).join(' ')}`, opt);
     }
     const child = spawn(cmd, args, opt);
+    let stderr;
+    if (!captureStdout && captureStderr) {
+      stderr = '';
+      child.stderr.setEncoding('utf8');
+      child.stderr.on('data', (chunk) => { stderr += chunk; });
+    }
     let stdout;
     if (captureStdout) {
       stdout = '';
@@ -51,7 +62,7 @@ function runAsyncBase(cmd, args, {
         stdout = stdout.split(/\r?\n/g);
         if (stdout[stdout.length - 1] === '') stdout.pop();
       }
-      return resolve(stdout);
+      return resolve(stdout ?? stderr);
     });
     if (input != null) child.stdin.end(input);
   });

package/lib/security-release/security-release.js

@@ -236,7 +236,7 @@ export class SecurityRelease {
   updateReleaseFolder(releaseDate) {
     const folder = path.join(process.cwd(),
       NEXT_SECURITY_RELEASE_FOLDER);
-    const newFolder = path.join(process.cwd(), releaseDate);
+    const newFolder = path.join(process.cwd(), 'security-release', releaseDate);
     fs.renameSync(folder, newFolder);
     return newFolder;
   }

package/lib/team_info.js

@@ -67,7 +67,6 @@ TeamInfo.update = async function(cli, request, content) {
 
   const blocks = new Map();
   let m;
-  // eslint-disable-next-line no-cond-assign
   while ((m = RE.exec(content))) {
     const [, org, team] = m;
     const mapKey = key(org, team);

package/lib/update-v8/constants.js

@@ -127,5 +127,11 @@ export const v8Deps = [
       replace: highwayIgnore
     },
     since: 134
+  },
+  {
+    name: 'simdutf',
+    repo: 'third_party/simdutf',
+    gitignore: '!/third_party/simdutf',
+    since: 134
   }
 ];

package/lib/update-v8/majorUpdate.js

@@ -119,7 +119,6 @@ function updateV8Deps() {
         path: v8Dep.repo
       })), newV8Version);
       if (deps.length === 0) return;
-      /* eslint-disable no-await-in-loop */
       for (const dep of deps) {
         if (dep.gitignore) {
           if (typeof dep.gitignore === 'string') {
@@ -132,7 +131,6 @@ function updateV8Deps() {
         const thePath = path.join(ctx.nodeDir, 'deps/v8', dep.path);
         await fetchFromGit(thePath, repo, commit);
       }
-      /* eslint-enable */
     }
   };
 }

package/lib/voting_session.js

@@ -10,6 +10,7 @@ import {
   getEditor, isGhAvailable
 } from './utils.js';
 
+// eslint-disable-next-line import/no-unresolved
 import voteUsingGit from '@node-core/caritat/voteUsingGit';
 import * as yaml from 'js-yaml';
 
@@ -97,7 +98,7 @@ export default class VotingSession extends Session {
         cp.stdin.end(share);
         const [code] = await Promise.race([
           once(cp, 'exit'),
-          once(cp, 'error').then((er) => Promise.reject(er))
+          once(cp, 'error').then((er) => { throw er; })
         ]);
         if (code !== 0) throw new Error('failed', { cause: code });
         return Buffer.concat(await stdout);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@node-core/utils",
-  "version": "5.10.0",
+  "version": "5.12.0",
   "description": "Utilities for Node.js core collaborators",
   "type": "module",
   "engines": {
@@ -40,7 +40,7 @@
     "@pkgjs/nv": "^0.2.2",
     "branch-diff": "^3.1.1",
     "chalk": "^5.4.1",
-    "changelog-maker": "^4.3.1",
+    "changelog-maker": "^4.3.2",
     "cheerio": "^1.0.0",
     "clipboardy": "^4.0.0",
     "core-validate-commit": "^4.1.0",
@@ -53,18 +53,21 @@
     "log-symbols": "^7.0.0",
     "ora": "^8.1.1",
     "replace-in-file": "^8.3.0",
-    "undici": "^7.2.2",
+    "semver": "^7.6.3",
+    "undici": "^7.3.0",
     "which": "^5.0.0",
     "yargs": "^17.7.2"
   },
   "devDependencies": {
+    "@eslint/js": "^9.19.0",
     "@reporters/github": "^1.7.2",
     "c8": "^10.1.3",
-    "eslint": "^8.57.1",
-    "eslint-config-standard": "^17.1.0",
+    "eslint": "^9.19.0",
     "eslint-plugin-import": "^2.31.0",
-    "eslint-plugin-n": "^16.6.2",
-    "eslint-plugin-promise": "^6.6.0",
+    "eslint-plugin-n": "^17.15.1",
+    "eslint-plugin-promise": "^7.2.1",
+    "globals": "^15.14.0",
+    "neostandard": "^0.12.0",
     "sinon": "^19.0.2"
   }
 }

package/lib/queries/PRLabeledEvents.gql

@@ -1,19 +0,0 @@
-query PRLabeledEvents($prid: Int!, $owner: String!, $repo: String!, $after: String) {
-  repository(owner: $owner, name: $repo) {
-    pullRequest(number: $prid) {
-      timelineItems(itemTypes: LABELED_EVENT, after: $after, last: 100) {
-        nodes { 
-          ... on LabeledEvent {
-            actor {
-              login
-            }
-            label {
-              name
-            }
-            createdAt
-          }
-        }
-      }
-    }
-  }
-}