@node-core/utils 5.0.0 → 5.0.2

package/lib/ci/run_ci.js

@@ -26,7 +26,9 @@ export class RunPRJob {
     this.prData = new PRData({ prid, owner, repo }, cli, request);
     this.certifySafe =
       certifySafe ||
-      new PRChecker(cli, this.prData, request, {}).checkCommitsAfterReview();
+      Promise.all([this.prData.getReviews(), this.prData.getPR()]).then(() =>
+        new PRChecker(cli, this.prData, request, {}).checkCommitsAfterReview()
+      );
   }
 
   async getCrumb() {
@@ -68,7 +70,7 @@ export class RunPRJob {
   async start() {
     const { cli, certifySafe } = this;
 
-    if (!certifySafe) {
+    if (!(await certifySafe)) {
       cli.error('Refusing to run CI on potentially unsafe PR');
       return false;
     }

package/lib/update-v8/constants.js

@@ -46,7 +46,8 @@ export const v8Deps = [
       match: '/base\n',
       replace: ''
     },
-    since: 55
+    since: 55,
+    until: 125
   },
   {
     name: 'gtest',

package/lib/update-v8/majorUpdate.js

@@ -146,6 +146,9 @@ async function readDeps(nodeDir, depName) {
   let deps;
   eval(depsDeclaration); // eslint-disable-line no-eval
   const dep = deps[depName];
+  if (!dep) {
+    throw new Error(`V8 dep "${depName}" not found in DEPS file`);
+  }
   if (typeof dep === 'object') {
     return dep.url.split('@');
   }

package/lib/utils.js

@@ -1,3 +1,4 @@
+import { platform } from 'node:os';
 import which from 'which';
 
 import { forceRunAsync } from './run.js';
@@ -62,5 +63,6 @@ export async function getEditor(options = {}) {
     }
   }
 
-  return process.env.VISUAL || process.env.EDITOR || null;
+  return process.env.VISUAL || process.env.EDITOR ||
+          (platform() === 'win32' ? 'notepad.exe' : 'vi');
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@node-core/utils",
-  "version": "5.0.0",
+  "version": "5.0.2",
   "description": "Utilities for Node.js core collaborators",
   "type": "module",
   "engines": {