@node-core/utils 4.2.1 → 4.2.3

package/lib/pr_checker.js

@@ -548,6 +548,15 @@ export default class PRChecker {
     });
 
     const totalCommits = afterCommits.length;
+    if (totalCommits === 0 && this.pr.timelineItems.updatedAt > reviewDate) {
+      // Some commits were pushed, but all the commits have a commit date prior
+      // to the last review. It means that either that a long time elapsed
+      // between the commit and the push, or that the clock on the dev machine
+      // is wrong, or the commit date was forged.
+      cli.warn('Something was pushed to the Pull Request branch since the last approving review.');
+      return false;
+    }
+
     if (totalCommits > 0) {
       cli.warn('Commits were pushed since the last approving review:');
       const sliceLength = maxCommits === 0 ? totalCommits : -maxCommits;

package/lib/prepare_security.js

@@ -78,7 +78,7 @@ class SecurityReleaseIssue {
     let reportsContent = '';
     for (const report of reports.data) {
       const { id, attributes: { title }, relationships: { severity } } = report;
-      const reportLevel = severity.data.attributes.rating;
+      const reportLevel = severity ? severity.data.attributes.rating : 'TBD';
       cli.separator();
       cli.info(`Report: ${id} - ${title} (${reportLevel})`);
       const include = await cli.prompt(

package/lib/queries/PR.gql

@@ -23,6 +23,9 @@ query PR($prid: Int!, $owner: String!, $repo: String!) {
           path
         }
       },
+      timelineItems(itemTypes: [HEAD_REF_FORCE_PUSHED_EVENT, PULL_REQUEST_COMMIT]) {
+        updatedAt
+      },
       title,
       baseRefName,
       headRefName,

package/lib/update-v8/index.js

@@ -5,18 +5,11 @@ import updateVersionNumbers from './updateVersionNumbers.js';
 import commitUpdate from './commitUpdate.js';
 import majorUpdate from './majorUpdate.js';
 import minorUpdate from './minorUpdate.js';
-import updateMaintainingDependencies from './updateMaintainingDependencies.js';
 import updateV8Clone from './updateV8Clone.js';
 
 export function major(options) {
   const tasks = new Listr(
-    [
-      updateV8Clone(),
-      majorUpdate(),
-      updateMaintainingDependencies(),
-      commitUpdate(),
-      updateVersionNumbers()
-    ],
+    [updateV8Clone(), majorUpdate(), commitUpdate(), updateVersionNumbers()],
     getOptions(options)
   );
   return tasks.run(options);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@node-core/utils",
-  "version": "4.2.1",
+  "version": "4.2.3",
   "description": "Utilities for Node.js core collaborators",
   "type": "module",
   "engines": {
@@ -15,8 +15,8 @@
   },
   "scripts": {
     "test": "npm run test-unit && npm run lint",
-    "test-unit": "node --test test/unit",
-    "test:reporters": "node --test --test-reporter=spec --test-reporter-destination=stdout --test-reporter=@reporters/github --test-reporter-destination=stdout test/unit",
+    "test-unit": "node --test test/unit/**",
+    "test:reporters": "node --test --test-reporter=spec --test-reporter-destination=stdout --test-reporter=@reporters/github --test-reporter-destination=stdout test/unit/**",
     "coverage": "c8 --reporter=html --reporter=text --reporter=text-summary npm test",
     "coverage:ci": "c8 --reporter=lcov --reporter=text --reporter=text-summary npm run test:reporters",
     "lint": "eslint . --cache",
@@ -44,7 +44,7 @@
     "clipboardy": "^4.0.0",
     "core-validate-commit": "^4.0.0",
     "figures": "^6.0.1",
-    "ghauth": "^5.0.1",
+    "ghauth": "^6.0.0",
     "inquirer": "^9.2.11",
     "js-yaml": "^4.1.0",
     "listr2": "^7.0.2",

package/lib/update-v8/updateMaintainingDependencies.js

@@ -1,34 +0,0 @@
-import { promises as fs } from 'node:fs';
-import { getNodeV8Version } from './util.js';
-
-export default function updateMaintainingDependencies() {
-  return {
-    title: 'Update V8 version in maintaining-dependencies.md',
-    task: async(ctx) => {
-      const path = `${ctx.nodeDir}/doc/contributing/maintaining/maintaining-dependencies.md`;
-      let maintainingDependenciesMd = await fs.readFile(path, 'utf8');
-      const v8Version = (await getNodeV8Version(ctx.nodeDir)).toString();
-      const v8VersionNoDots = v8Version.replaceAll('.', '');
-      // V8 itemlist link
-      maintainingDependenciesMd = maintainingDependenciesMd.replace(
-        /\* \[V8.*/,
-        `* [V8 ${v8Version}][]`
-      );
-      // V8 link to section
-      maintainingDependenciesMd = maintainingDependenciesMd.replace(
-        /\[v8.*\]: #v8.*/,
-        `[v8 ${v8Version}]: #v8-${v8VersionNoDots}`
-      );
-      // V8 section title
-      maintainingDependenciesMd = maintainingDependenciesMd.replace(
-        /### V8.*/,
-        `### V8 ${v8Version}`
-      );
-      await fs.writeFile(path, maintainingDependenciesMd);
-      await ctx.execGitNode(
-        'add',
-        ['doc/contributing/maintaining/maintaining-dependencies.md']
-      );
-    }
-  };
-};