@nodaro/shared 2.16.0 → 2.18.0

package/src/model-constants.ts

@@ -295,6 +295,35 @@ export const NATIVE_NEGATIVE_VIDEO_PROVIDERS = new Set<string>([
   "wan-s2v",
 ])
 
+/**
+ * The `[style]` section header, verbatim. A composed prompt that ends with that
+ * section has NO terminator (`@nodaro/prompts`' `prompt-style-section.ts` owns
+ * the shape and the reasoning), so a `"\n"`-joined `Avoid:` would read as one
+ * more look clause under its header. Duplicated rather than imported because
+ * `@nodaro/prompts` depends on THIS package and never the reverse; the two are
+ * pinned together behaviourally by that package's
+ * `__tests__/style-section-boundary.test.ts`, which runs the real composer
+ * through this clamp.
+ */
+const STYLE_SECTION_HEADER_LINE = "[style]:\n"
+
+/**
+ * The `Avoid: …` suffix `applyVideoNegativePrompt` folds into a prompt, with the
+ * separator the base prompt calls for: a blank line when the base ends INSIDE an
+ * unterminated `[style]` section, a single newline otherwise.
+ *
+ * `base` omitted = the WIDEST form, which is what a caller reserving room before
+ * the prompt exists must budget for (`effectiveVideoPromptCeiling`).
+ */
+export function videoNegativeSuffix(negativePrompt: string, base?: string): string {
+  const gapAt = base?.lastIndexOf("\n\n") ?? -1
+  const lastBlock = base === undefined ? undefined : (gapAt >= 0 ? base.slice(gapAt + 2) : base)
+  const separator = lastBlock === undefined || lastBlock.startsWith(STYLE_SECTION_HEADER_LINE)
+    ? "\n\n"
+    : "\n"
+  return `${separator}Avoid: ${negativePrompt}`
+}
+
 /**
  * Apply the negative prompt to a video-provider request.
  *
@@ -306,6 +335,8 @@ export const NATIVE_NEGATIVE_VIDEO_PROVIDERS = new Set<string>([
  * Otherwise, the helper appends `Avoid: <negativePrompt>` to the prompt
  * (consistent with `buildImagePrompt` in `prompt-builder.ts`) so the model
  * still sees the negative intent, and returns `nativeNegativePrompt = undefined`.
+ * The line is separated by {@link videoNegativeSuffix}, which closes an open
+ * `[style]` section with a blank line rather than reading as a look clause.
  *
  * Empty / missing negative is a no-op.
  *
@@ -338,7 +369,10 @@ export function applyVideoNegativePrompt(
   // assembler), then clamp the whole to the model cap.
   const base = prompt && prompt.trim().length > 0 ? prompt : ""
   if (!base) return { prompt: `Avoid: ${neg}`.slice(0, promptMax), nativeNegativePrompt: undefined }
-  const avoid = `\nAvoid: ${neg}`
+  // The separator is decided on the WHOLE base: the clamp below can only cut the
+  // tail, and a cut either leaves the `[style]` section behind or lands inside
+  // it, so the suffix never needs to grow after the reservation.
+  const avoid = videoNegativeSuffix(neg, base)
   const room = Math.max(0, promptMax - avoid.length)
   const injected = `${base.slice(0, room)}${avoid}`.slice(0, promptMax)
   return { prompt: injected, nativeNegativePrompt: undefined }

package/src/producer-types.ts

@@ -130,6 +130,12 @@ export const DYNAMIC_PRODUCER_TYPES: ReadonlySet<string> = new Set([
   // EVERY producer set or its outputs can't connect (was the "cannot connect
   // the outputs of voice-changer-pro" bug). Guarded by producer-types.test.ts.
   "voice-changer-pro",
+  // Dubbing joined the dual-mode family with the full-surface upgrade:
+  // audio in → dubbed audio; video in (or a video sourceUrl) → dubbed VIDEO
+  // (+ audio sidecar). Same wiring contract as voice-changer; stays in
+  // AUDIO_PRODUCER_TYPES as its default. Explicitly asserted in
+  // producer-types.test.ts (the suite does not fail on omission).
+  "dubbing",
   "reduce",
   // Dual-output time chunker (UI label "Split into Chunks"; type id stays
   // "split-media"): video in → video chunks, audio in → audio chunks — two

package/src/types.ts

@@ -163,13 +163,19 @@ export interface ConnectedReference {
    */
   readonly defaultUsageMode?: UsageMode
   /**
-   * Character node's HYBRID `defaultRole` (the role-dropdown pick: a
-   * `REFERENCE_ROLE_PRESETS["wired-character"]` value or a sanitized Custom
-   * slug) propagated into every entry derived from that node. Read via
+   * The reference's HYBRID `defaultRole` (the role-dropdown pick: a
+   * `REFERENCE_ROLE_PRESETS[source]` value or a sanitized Custom slug)
+   * propagated into every entry derived from that node. Read via
    * `resolveDefaultRole(defaultRole, defaultUsageMode, source)` at the hybrid
    * resolver sites — it takes precedence over `defaultUsageMode`. Absent for
-   * non-character refs and for nodes that never set a role (fall back to the
-   * `defaultUsageMode`-derived role, then the source default).
+   * nodes that never set a role (fall back to the `defaultUsageMode`-derived
+   * role, then the source default).
+   *
+   * Written by the character node's role dropdown, and accepted from any source
+   * on the wire (`connectedReferenceSchema`). The LOCATION paths read it through
+   * their own `resolveLocationRole` chain rather than `resolveDefaultRole` — the
+   * location role vocabulary is mode-derived and slug-normalized — so it is NOT
+   * a character-only field: do not re-narrow this doc to characters.
    */
   readonly defaultRole?: string
   /**

package/src/workflow-export.ts

@@ -96,6 +96,22 @@ export interface WorkflowPortability {
   unreachableMedia: WorkflowMediaRef[]
 }
 
+/** The four entity kinds a bundle's `assets` can carry. */
+export type WorkflowAssetKind = "character" | "object" | "creature" | "location"
+
+/**
+ * A bundled entity the import declined to re-create (#1088). The workflow
+ * still lands — the film is the thing the importer asked for — so this is how
+ * they hear that an `@` chip arrived unbound.
+ */
+export interface WorkflowImportSkippedAsset {
+  kind: WorkflowAssetKind
+  /** The entity's id IN THE BUNDLE (the exporter's row id). */
+  id: string
+  name: string
+  reason: string
+}
+
 /**
  * What the importer did about the bundle's media (#866). Publicly reachable
  * media that is not already on the importing instance's own storage is
@@ -103,11 +119,29 @@ export interface WorkflowPortability {
  * a host the importer cannot reach is left as-is and listed (`unreachable`);
  * anything declined for another reason (too large, not a media type, over
  * the per-import cap, upload failed) is listed with the reason (`skipped`).
+ *
+ * The bundle's ENTITY images (`assets`) ride the same walk (#1088) — with one
+ * rule of their own: they are copied even when they already sit on this
+ * instance, because they are the EXPORTER's bytes and the two accounts'
+ * lifecycles are uncorrelated (their delete, their quarantine sweep, their
+ * retention reaper). Only bytes the importer already owns are left alone.
  */
 export interface WorkflowImportReport {
   rehosted: number
   unreachable: WorkflowMediaRef[]
   skipped: Array<WorkflowMediaRef & { reason: string }>
+  /**
+   * Bundled entity id (the EXPORTER's) → the row created under the importer,
+   * for every entity the import re-created. Present whenever the bundle
+   * carried `assets`. A client that holds chips outside the graph — a
+   * timeline, a copy-a-shared-production path that never posts to
+   * `/v1/workflows/import` — re-points them with this; the server has already
+   * re-pointed every `references[]` entry inside the nodes it stored.
+   */
+  assetIdMap?: Record<string, string>
+  /** Entities the import declined to create (storage quota). The workflow
+   *  still landed; chips bound to these arrive unresolvable. */
+  assetsSkipped?: WorkflowImportSkippedAsset[]
   /** Anything else the importer should know, e.g. copies were made but the
    *  workflow could not be updated to use them. */
   notes?: string[]