@nodaro/shared 1.12.0 → 1.13.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nodaro/shared",
-  "version": "1.12.0",
+  "version": "1.13.0",
   "description": "Shared types, model catalog, wire contracts, and structural vocabularies for the Nodaro platform and SDK.",
   "type": "module",
   "license": "Apache-2.0",

package/src/__tests__/llm-models.test.ts

@@ -12,6 +12,7 @@ import {
   effectiveReasoningEffort,
 } from "../llm-models.js"
 import type { LlmModelDef, LlmTier, LlmFeature } from "../llm-models.js"
+import { PIPELINE_PINNABLE_SCRIPT_LLMS } from "../pipeline-types.js"
 
 // The provider-$ per-token rate table and `calculateLlmCost` moved to
 // backend/src/lib/pricing/llm-cost.ts (S5) — its tests live in
@@ -128,6 +129,32 @@ describe("LLM_MODEL_IDS", () => {
 // getLlmModel
 // ---------------------------------------------------------------------------
 describe("getLlmModel", () => {
+  // Dash-alias resolution: wire contracts (PIPELINE_PINNABLE_SCRIPT_LLMS,
+  // provider slugs, persisted configs) carry dash forms while LLM_MODELS keys
+  // canonical dot ids — getLlmModel must accept both or the film pipeline's
+  // own script default throws "Unknown LLM model" at run time.
+  it("resolves dash-form aliases to their canonical dot-form models", () => {
+    expect(getLlmModel("claude-sonnet-4-6")?.id).toBe("claude-sonnet-4.6")
+    expect(getLlmModel("claude-opus-4-7")?.id).toBe("claude-opus-4.7")
+    expect(getLlmModel("claude-haiku-4-5")?.id).toBe("claude-haiku-4.5")
+  })
+
+  it("resolves every PIPELINE_PINNABLE_SCRIPT_LLMS member (the film pipeline's pin surface)", () => {
+    for (const id of PIPELINE_PINNABLE_SCRIPT_LLMS) {
+      expect(getLlmModel(id), `pinnable script llm ${id} must resolve`).toBeDefined()
+    }
+  })
+
+  it("resolves provider slugs as historical aliases", () => {
+    const dated = LLM_MODELS.find((m) => m.directFallbackModel && m.directFallbackModel !== m.id)
+    if (dated) expect(getLlmModel(dated.directFallbackModel!)?.id).toBe(dated.id)
+  })
+
+  it("still returns undefined for a genuinely unknown id", () => {
+    expect(getLlmModel("claude-sonnet-9-9")).toBeUndefined()
+    expect(getLlmModel("not-a-model")).toBeUndefined()
+  })
+
   it('returns model def for "gemini-3-flash"', () => {
     const model = getLlmModel("gemini-3-flash")
     expect(model).toBeDefined()

package/src/index.ts

@@ -467,6 +467,7 @@ export type { LocationCatalogRef } from "./location-preset-catalog-map.js"
 
 export {
   PARAMETER_NODE_TYPES,
+  HINT_EXEMPT_PARAMETER_TYPES,
   getParameterValue,
 } from "./parameter-node-value.js"
 

package/src/llm-models.ts

@@ -327,8 +327,29 @@ export function getLlmModalityCaps(modelId: string | undefined): { image: boolea
   return LLM_MODALITY_CAPS[modelId] ?? { image: true, video: false, audio: false }
 }
 
+/**
+ * Dash-form aliases resolve to their canonical dot-form ids. Several wire
+ * contracts carry dash forms (`PIPELINE_PINNABLE_SCRIPT_LLMS`, provider slugs,
+ * configs persisted before the id scheme settled), while `LLM_MODELS` keys the
+ * canonical `major.minor` form — an exact-only lookup makes every such caller
+ * throw "Unknown LLM model" at run time. Normalizing here (instead of editing
+ * the enums) keeps stored configs and published-package consumers valid.
+ */
+function dashAliasToCanonical(id: string): string {
+  return id.replace(/-(\d+)-(\d+)$/, "-$1.$2")
+}
+
 export function getLlmModel(id: string): LlmModelDef | undefined {
-  return LLM_MODELS.find((m) => m.id === id)
+  const exact = LLM_MODELS.find((m) => m.id === id)
+  if (exact) return exact
+  const canonical = dashAliasToCanonical(id)
+  if (canonical !== id) {
+    const aliased = LLM_MODELS.find((m) => m.id === canonical)
+    if (aliased) return aliased
+  }
+  // Last resort: provider slugs double as historical aliases (e.g. the
+  // dated Anthropic slugs) — accept any model whose slug matches exactly.
+  return LLM_MODELS.find((m) => m.kieSlugOrModel === id || m.directFallbackModel === id)
 }
 
 export function getLlmTier(id: string): LlmTier {

package/src/parameter-node-value.ts

@@ -57,6 +57,26 @@ export const PARAMETER_NODE_TYPES: ReadonlySet<string> = new Set([
   "voice-delivery",
 ])
 
+/**
+ * Parameter types that intentionally produce NO prompt hint from
+ * `getParameterPromptHint` (in `@nodaro/prompts`). They carry pure runtime
+ * parameters — counts, durations, aspect ratios, legacy motion intensity —
+ * consumed by the executor directly, never appended to a downstream prompt.
+ *
+ * Consumers that treat "parameter node" as "text producer" (the `{Label}`
+ * auto-fill in `main-text-handle.ts`, ref-map builders) must exclude these:
+ * their extracted output is undefined, so an auto-filled `{Label}` would stay
+ * in the outgoing prompt as literal brace text. Guarded by
+ * `parameter-registry-sync.test.ts` (each member really returns "") and
+ * `main-text-handle.test.ts` (members are not text-producing).
+ */
+export const HINT_EXEMPT_PARAMETER_TYPES: ReadonlySet<string> = new Set([
+  "motion",
+  "scene-count",
+  "duration",
+  "aspect-ratio",
+])
+
 export function getParameterValue(
   data: Record<string, unknown>,
   nodeType: string,