@nodaro/prompts 1.32.0 → 1.33.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nodaro/prompts",
-  "version": "1.32.0",
+  "version": "1.33.0",
   "description": "Nodaro's prompt-engineering layer — person/picker catalogs with prompt hints, identity-lock clauses, entity prompt builders, brand presets, and prompt/reference assembly shared by the Nodaro platform and SDK.",
   "type": "module",
   "license": "FSL-1.1-Apache-2.0",
@@ -20,7 +20,7 @@
     "test": "vitest run"
   },
   "dependencies": {
-    "@nodaro/shared": "^3.23.0"
+    "@nodaro/shared": "^3.24.0"
   },
   "devDependencies": {
     "tsup": "^8.5.0",

package/src/__tests__/node-send-text.test.ts

@@ -64,6 +64,15 @@ describe("computeNodeSendText", () => {
     expect(computeNodeSendText("collection-write", {}, { override: "row 3", wired: "the wire", refMap })).toBe("row 3")
   })
 
+  it("collection-write: a typed field counts with its {Node} references resolved, as the engines send it (#1890)", () => {
+    const empty = new Map<string, string>()
+    // A feed with nothing new: an empty fallback is nothing to save, so the node skips.
+    expect(computeNodeSendText("collection-write", { title: "{Feed || }" }, { wired: "", refMap: empty })).toBe("")
+    expect(computeNodeSendText("collection-write", { title: "{Feed || untitled}" }, { wired: "", refMap: empty })).toBe("untitled")
+    expect(computeNodeSendText("collection-write", { title: "Breaking: {Feed}" }, { wired: "", refMap: new Map([["feed", "Telegram turns ten"]]) }))
+      .toBe("Breaking: Telegram turns ten")
+  })
+
   it("prompt pre/post text never counts as something to send: an empty core with a prefix is nothing", () => {
     const refMap = new Map<string, string>()
     const affixed = { userInput: "", promptPrefix: "Write a news item about:", promptSuffix: "Keep it short." }

package/src/node-send-text.ts

@@ -1,4 +1,4 @@
-import { SOCIAL_POST_NODE_TYPES } from "@nodaro/shared"
+import { resolveNodeRefs, SOCIAL_POST_NODE_TYPES } from "@nodaro/shared"
 import { computeLlmChatFields, computeNodePrompt, computeScriptTopic } from "./resolve-prompt.js"
 
 /**
@@ -111,7 +111,12 @@ export function computeNodeSendText(
       // else a title, text or link typed on the node. A picture alone is a
       // record too, but it never starves the node: only a wired TEXT input that
       // produced nothing can (the skip rule's precondition).
-      const typed = [data.title, data.text, data.link].find((v): v is string => present(v as string | undefined))
+      // A typed field counts as the engines send it, its `{Node}` references
+      // resolved: `{Feed || }` over a feed with nothing new is empty, so the
+      // node skips instead of failing with an empty record (#1890).
+      const typed = [data.title, data.text, data.link]
+        .map((v) => (typeof v === "string" ? resolveNodeRefs(v, args.refMap) : v))
+        .find((v): v is string => present(v as string | undefined))
       return [args.override, args.wired, typed].find(present) ?? ""
     }
     default: