@noctcore/eslint-plugin-code-quality 0.2.0 → 0.2.2

package/dist/index.cjs

@@ -1411,7 +1411,7 @@ var rules = {
 
 // src/index.ts
 var NAMESPACE = "noctcore-code-quality";
-var VERSION = "0.2.0";
+var VERSION = "0.2.2";
 var plugin = {
   meta: { name: "@noctcore/eslint-plugin-code-quality", version: VERSION },
   rules,

package/dist/index.js

@@ -1373,7 +1373,7 @@ var rules = {
 
 // src/index.ts
 var NAMESPACE = "noctcore-code-quality";
-var VERSION = "0.2.0";
+var VERSION = "0.2.2";
 var plugin = {
   meta: { name: "@noctcore/eslint-plugin-code-quality", version: VERSION },
   rules,

package/docs/rules/fake-timers-must-be-restored.md

@@ -22,7 +22,7 @@ the file runs.
 A contract suite often owns the restore: the spec installs fake timers inside a helper it hands to
 the suite, and the suite restores them in its own `afterEach`.
 
-```ts
+```ts prose reason="two files: the rule reads the imported suite from disk"
 // provider.contract-suite.ts
 export function runProviderContract(subject: Subject): void {
   describe('provider contract', () => {
@@ -51,8 +51,7 @@ re-exported, never called, does not count.
 For a suite the rule cannot resolve (a path alias or a workspace package), name it in
 `sharedSuiteModules`.
 
-```ts
-// Bad
+```ts bad filename=src/session.test.ts
 beforeEach(() => {
   vi.useFakeTimers();
 });
@@ -63,8 +62,7 @@ it('expires the session', () => {
 });
 ```
 
-```ts
-// Good
+```ts good filename=src/session.test.ts
 beforeEach(() => {
   vi.useFakeTimers();
 });

package/docs/rules/interface-prefix-i.md

@@ -19,12 +19,14 @@ dictated by the module being augmented (`Register`, `Window`).
 
 Report-only: a rename touches every reference, which a single-file fixer cannot do safely.
 
-```ts
-// ✗ interface UserProfile { id: string; }
-// ✗ interface Input { value: string; }
+```ts bad reports=2
+interface UserProfile { id: string; }
+interface Input { value: string; }
+```
 
-// ✓ interface IUserProfile { id: string; }
-// ✓ declare global { interface Window { electron: unknown; } }  // augmentation
+```ts good
+interface IUserProfile { id: string; }
+declare global { interface Window { electron: unknown; } } // augmentation
 ```
 
 ## Options

package/docs/rules/no-bare-date-now.md

@@ -16,16 +16,20 @@ branch depends on the real clock. Routing wall-clock reads through a shared `clo
 `new Date(value)` with an argument is a **parse** of an explicit instant, not a bare clock read, and
 is never flagged. Files covered by `allowIn` are skipped entirely.
 
-```ts
-// ✗ bare clock reads in business logic
+```ts bad reports=2
+// bare clock reads in business logic
 const start = Date.now();
 const created = new Date();
+```
+
+```ts good
+import { now, nowMs } from './clock';
 
-// ✓ through the clock seam
+// through the clock seam
 const start = nowMs();
 const created = now();
 
-// ✓ parsing an explicit instant
+// parsing an explicit instant
 const at = new Date('2026-01-01T00:00:00Z');
 ```
 

package/docs/rules/no-conditional-expect.md

@@ -26,8 +26,7 @@ loop or `if` that generates tests does not flag the expects inside those tests.
 A test that calls `expect.assertions(n)` or `expect.hasAssertions()` is exempt: a skipped branch
 already fails it.
 
-```ts
-// Bad
+```ts bad filename=src/parse.test.ts reports=2
 it('rejects bad input', async () => {
   try {
     await parse('');
@@ -44,8 +43,7 @@ it('returns the value', () => {
 });
 ```
 
-```ts
-// Good
+```ts good filename=src/parse.test.ts
 it('rejects bad input', async () => {
   await expect(parse('')).rejects.toBeInstanceOf(ParseError);
 });

package/docs/rules/no-focused-tests.md

@@ -15,13 +15,15 @@ focused test a lint error so it can't merge.
 - The Jest/Jasmine focused-call forms `fdescribe(...)`, `fit(...)`, `ddescribe(...)` — but only as a
   bare-identifier callee, so an unrelated `obj.fit(...)` method is not flagged.
 
-```ts
-// ✗ it.only('runs', () => {});
-// ✗ test.concurrent.only('case', () => {});
-// ✗ fdescribe('suite', () => {});
+```ts bad filename=src/example.test.ts reports=3
+it.only('runs', () => {});
+test.concurrent.only('case', () => {});
+fdescribe('suite', () => {});
+```
 
-// ✓ it('runs', () => {});
-// ✓ layout.fit('contain');   // not a test runner
+```ts good filename=src/example.test.ts
+it('runs', () => {});
+layout.fit('contain'); // not a test runner
 ```
 
 ## Options

package/docs/rules/no-historical-comments.md

@@ -15,11 +15,13 @@ Line and block comments (JSDoc `/** … */` blocks are exempt) matching narrow p
 `before/after the fix`, `before/after the refactor`, `we/this used to`, `used to be`, `no longer`,
 `kept for backwards/legacy/compat`, `was/were a bug/footgun`, and `historical(ly)`.
 
-```ts
-// ✗ We used to read process.env directly here.
-// ✗ Before the fix this collapsed to {}.
+```ts bad reports=2
+// We used to read process.env directly here.
+// Before the fix this collapsed to {}.
+```
 
-// ✓ Caps concurrent connections to avoid pool exhaustion.
+```ts good
+// Caps concurrent connections to avoid pool exhaustion.
 ```
 
 ## Options

package/docs/rules/no-narration-comments.md

@@ -17,12 +17,14 @@ construction: `here we`, `now we`, `first[,] we`, `then[,] we`, `next[,] we`, `f
 
 A bare leading word ("Next attempt…", "First run…") is fine — only the "we"/"let's" narration form matches.
 
-```ts
-// ✗ Now we attach the user to the socket.
-// ✗ Let's validate the session token.
+```ts bad reports=2
+// Now we attach the user to the socket.
+// Let's validate the session token.
+```
 
-// ✓ WHY: Prisma reuses the pooled connection across requests.
-// ✓ call next() to continue the middleware chain
+```ts good
+// WHY: Prisma reuses the pooled connection across requests.
+// call next() to continue the middleware chain
 ```
 
 ## Options

package/docs/rules/no-pr-reference-comments.md

@@ -18,13 +18,15 @@ Comments containing:
 - a `PR #123` / `PR 123` reference;
 - a bare `#123` at a word boundary.
 
-```ts
-// ✗ fixes #123
-// ✗ See https://github.com/noctcore/eslint-plugins/pull/42 for context.
-// ✗ workaround (#88)
+```ts bad reports=3
+// fixes #123
+// See https://github.com/noctcore/eslint-plugins/pull/42 for context.
+// workaround (#88)
+```
 
-// ✓ Trust-proxy depth for single-host Traefik.
-const channel = "#general"; // ✓ not a comment
+```ts good
+// Trust-proxy depth for single-host Traefik.
+const channel = "#general"; // the string is not a comment
 ```
 
 ## Options

package/docs/rules/no-process-exit.md

@@ -16,6 +16,24 @@ Any `process.exit(...)` call in a file **not** covered by `allowIn`. Both the do
 (`process.exit()`) and the computed form (`process['exit']()`) are caught so a computed callee
 cannot bypass the rule.
 
+```ts bad filename=src/orders/orders.service.ts
+if (!order) {
+  process.exit(1);
+}
+```
+
+```ts good filename=src/orders/orders.service.ts
+if (!order) {
+  throw new Error('order not found');
+}
+```
+
+Moving the exit to a CLI entrypoint is the other fix:
+
+```ts good filename=scripts/migrate.ts relocation
+main().catch(() => process.exit(1));
+```
+
 ## Options
 
 | Option | Type | Default | Meaning |

package/docs/rules/no-real-network-in-unit-tests.md

@@ -29,22 +29,27 @@ It does not flag:
 - a client whose module the file mocks (`vi.mock('axios')`, `jest.mock('node-fetch')`);
 - a method that only shares a name (`repository.fetch(1)`, `store.get('k')`).
 
-```ts
-// Bad: src/api/client.test.ts
+```ts bad filename=src/api/client.test.ts
 it('loads the profile', async () => {
   const res = await fetch('https://api.example.com/me');
   expect(res.status).toBe(200);
 });
 ```
 
-```ts
-// Good: src/api/client.test.ts
+```ts good filename=src/api/client.test.ts
 it('loads the profile', async () => {
   vi.stubGlobal('fetch', vi.fn().mockResolvedValue(new Response('{"id":1}')));
   expect(await loadProfile()).toEqual({ id: 1 });
 });
+```
+
+A test that needs the real server moves to an integration suite:
 
-// Good: src/api/client.integration.test.ts runs against a real server.
+```ts good filename=src/api/client.integration.test.ts relocation
+it('loads the profile', async () => {
+  const res = await fetch('https://api.example.com/me');
+  expect(res.status).toBe(200);
+});
 ```
 
 ## Options

package/docs/rules/no-template-trim-empty-ternary.md

@@ -17,12 +17,12 @@ explicitly if the shape recurs in your codebase.
 A `ConditionalExpression` whose test is a `===` / `!==` comparison between an **empty-string literal**
 and a **`.trim()` call on a template literal**, in either order.
 
-```ts
-// ✗
+```ts bad reports=2
 const name = `${first} ${last}`.trim() === '' ? email : `${first} ${last}`.trim();
-const name = '' !== `${a}`.trim() ? `${a}`.trim() : fallback;
+const label = '' !== `${a}`.trim() ? `${a}`.trim() : fallback;
+```
 
-// ✓
+```ts good
 const name = buildDisplayName({ first, last, fallback: email });
 const trimmed = value.trim() === '' ? fallback : value; // not a template literal
 ```

package/docs/rules/no-vacuous-expect.md

@@ -25,8 +25,7 @@ The rule matches on method names, not on a runner import, so it covers Jest, Vit
 A test counts every `expect(...)` matcher plus any call matching `assertionCallees`, so a weak
 `expect` next to `assert.equal(...)`, `expectValidUser(...)` or supertest's `.expect(200)` is fine.
 
-```ts
-// Bad
+```ts bad filename=src/token.test.ts reports=3
 it('should be defined', () => {
   expect(service).toBeDefined();
 });
@@ -40,8 +39,7 @@ it('works', () => {
 });
 ```
 
-```ts
-// Good
+```ts good filename=src/token.test.ts
 it('issues a signed token for the user', () => {
   const token = issueToken({ userId: 'u-1' });
   expect(verify(token)).toEqual({ userId: 'u-1' });

package/docs/rules/prefer-early-return.md

@@ -18,16 +18,18 @@ The **last** statement of a function block that is an `if` with:
 A single-statement `if`, an `if/else`, or an `if` that is not the final statement is left alone —
 those are not body-wraps.
 
-```ts
-// ✗ the whole body is wrapped
+```ts bad
+// the whole body is wrapped
 function handle(x) {
   if (x) {
     doA();
     doB();
   }
 }
+```
 
-// ✓ guard clause
+```ts good
+// guard clause
 function handle(x) {
   if (!x) {
     return;

package/docs/rules/skipped-tests-need-tracking.md

@@ -21,16 +21,18 @@ window above it.
 Faithful to the original text-scanning implementation, the source is scanned line by line, so a marker
 in a trailing comment, a preceding comment, or anywhere in the lookback window is honoured.
 
-```ts
-// ✓ tracked
+```ts bad filename=src/example.test.ts reports=2
+// untracked
+it.skip('later', () => {});
+xdescribe('later', () => {});
+```
+
+```ts good filename=src/example.test.ts
+// tracked
 // TODO(@alice): flaky under CI
 it.skip('later', () => {});
 
 it.skip('later', () => {}); // https://github.com/org/repo/issues/1
-
-// ✗ untracked
-it.skip('later', () => {});
-xdescribe('later', () => {});
 ```
 
 ## Options

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@noctcore/eslint-plugin-code-quality",
-  "version": "0.2.0",
+  "version": "0.2.2",
   "description": "Portable code-quality, comment-hygiene, and test-discipline ESLint rules.",
   "license": "MIT",
   "type": "module",
@@ -46,7 +46,7 @@
     "test": "vitest run"
   },
   "dependencies": {
-    "@noctcore/eslint-utils": "^0.1.0",
+    "@noctcore/eslint-utils": "^0.1.1",
     "@typescript-eslint/utils": "^8.61.1"
   },
   "peerDependencies": {