@noctcore/eslint-plugin-code-quality 0.1.0 → 0.2.0

package/dist/index.js

@@ -7,60 +7,22 @@ var recommended = {
   "noctcore-code-quality/no-narration-comments": "error",
   "noctcore-code-quality/no-pr-reference-comments": "error",
   "noctcore-code-quality/no-focused-tests": "error",
-  "noctcore-code-quality/skipped-tests-need-tracking": "error"
+  "noctcore-code-quality/skipped-tests-need-tracking": "error",
+  "noctcore-code-quality/no-vacuous-expect": "error",
+  "noctcore-code-quality/no-conditional-expect": "error",
+  "noctcore-code-quality/fake-timers-must-be-restored": "error",
+  "noctcore-code-quality/no-real-network-in-unit-tests": "error"
 };
 
-// src/rules/interface-prefix-i.ts
+// src/rules/fake-timers-must-be-restored.ts
+import fs from "fs";
+import path from "path";
 import { AST_NODE_TYPES } from "@typescript-eslint/utils";
 
 // src/createRule.ts
 import { makeCreateRule } from "@noctcore/eslint-utils";
 var createRule = makeCreateRule("code-quality");
 
-// src/rules/interface-prefix-i.ts
-var RULE_NAME = "interface-prefix-i";
-function isAlreadyPrefixed(name) {
-  return /^I[A-Z]/.test(name);
-}
-function isInsideAmbientModule(node) {
-  let current = node.parent;
-  while (current) {
-    if (current.type === AST_NODE_TYPES.TSModuleDeclaration) {
-      return true;
-    }
-    current = current.parent;
-  }
-  return false;
-}
-var interfacePrefixIRule = createRule({
-  name: RULE_NAME,
-  meta: {
-    type: "suggestion",
-    docs: {
-      description: "Interface names must be prefixed with `I` followed by an uppercase letter. Module/global augmentations are exempt."
-    },
-    schema: [],
-    messages: {
-      missingPrefix: "Interface `{{name}}` must be prefixed with `I` (e.g. `I{{name}}`). Rename the declaration and its references."
-    }
-  },
-  defaultOptions: [],
-  create(context) {
-    return {
-      TSInterfaceDeclaration(node) {
-        const name = node.id.name;
-        if (isAlreadyPrefixed(name) || isInsideAmbientModule(node)) {
-          return;
-        }
-        context.report({ node: node.id, messageId: "missingPrefix", data: { name } });
-      }
-    };
-  }
-});
-
-// src/rules/no-bare-date-now.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES2 } from "@typescript-eslint/utils";
-
 // src/utils/allowMatch.ts
 var REGEX_METACHARACTERS = /[.*+?^${}()|[\]\\]/gu;
 function escapeLiteral(text) {
@@ -125,10 +87,216 @@ function matchesAny(filename, globs) {
   return globs.some((glob) => compile(glob).test(normalized));
 }
 
+// src/rules/fake-timers-must-be-restored.ts
+var RULE_NAME = "fake-timers-must-be-restored";
+var DEFAULT_FAKE_TIMER_METHODS = ["useFakeTimers"];
+var DEFAULT_RESTORE_TIMER_METHODS = ["useRealTimers"];
+var DEFAULT_FOLLOW_IMPORTED_SUITES = true;
+var DEFAULT_SHARED_SUITE_MODULES = [];
+var RESOLVE_EXTENSIONS = [".ts", ".tsx", ".mts", ".cts", ".js", ".jsx", ".mjs", ".cjs"];
+var methodList = {
+  type: "array",
+  items: { type: "string", minLength: 1 },
+  uniqueItems: true,
+  minItems: 1
+};
+var optionSchema = {
+  type: "object",
+  additionalProperties: false,
+  properties: {
+    fakeTimerMethods: methodList,
+    restoreTimerMethods: methodList,
+    followImportedSuites: { type: "boolean" },
+    sharedSuiteModules: { type: "array", items: { type: "string", minLength: 1 }, uniqueItems: true }
+  }
+};
+var sourceCache = /* @__PURE__ */ new Map();
+function readSource(file) {
+  try {
+    const stat = fs.statSync(file);
+    if (!stat.isFile()) {
+      return null;
+    }
+    const cached = sourceCache.get(file);
+    if (cached !== void 0 && cached.mtimeMs === stat.mtimeMs) {
+      return cached.text;
+    }
+    const text = fs.readFileSync(file, "utf8");
+    sourceCache.set(file, { mtimeMs: stat.mtimeMs, text });
+    return text;
+  } catch (error) {
+    if (error instanceof Error && "code" in error) {
+      return null;
+    }
+    throw error;
+  }
+}
+function resolveRelative(fromFile, specifier) {
+  const base = path.resolve(path.dirname(fromFile), specifier);
+  const stem = base.replace(/\.(?:[cm]?js|jsx)$/u, "");
+  const candidates = [
+    base,
+    ...RESOLVE_EXTENSIONS.map((ext) => stem + ext),
+    ...RESOLVE_EXTENSIONS.map((ext) => path.join(base, `index${ext}`))
+  ];
+  for (const candidate of candidates) {
+    if (readSource(candidate) !== null) {
+      return candidate;
+    }
+  }
+  return null;
+}
+function escapeRegExp(text) {
+  return text.replace(/[.*+?^${}()|[\]\\]/gu, "\\$&");
+}
+function importIsCalled(sourceCode, declaration) {
+  return sourceCode.getDeclaredVariables(declaration).some(
+    (variable) => variable.references.some((reference) => {
+      const parent = reference.identifier.parent;
+      if (parent.type === AST_NODE_TYPES.CallExpression && parent.callee === reference.identifier) {
+        return true;
+      }
+      return parent.type === AST_NODE_TYPES.MemberExpression && parent.object === reference.identifier && parent.parent.type === AST_NODE_TYPES.CallExpression && parent.parent.callee === parent;
+    })
+  );
+}
+function calledMethodName(node) {
+  const callee = node.callee;
+  if (callee.type === AST_NODE_TYPES.Identifier) {
+    return callee.name;
+  }
+  if (callee.type === AST_NODE_TYPES.MemberExpression && !callee.computed && callee.property.type === AST_NODE_TYPES.Identifier) {
+    return callee.property.name;
+  }
+  return null;
+}
+var fakeTimersMustBeRestoredRule = createRule({
+  name: RULE_NAME,
+  meta: {
+    type: "problem",
+    docs: {
+      description: "A test file that calls `useFakeTimers()` must also call `useRealTimers()`, so fake timers do not leak into later tests."
+    },
+    schema: [optionSchema],
+    messages: {
+      timersNotRestored: "`{{method}}()` is called without a matching restore call, so fake timers leak into other tests. Call `useRealTimers()` in an `afterEach`, here or in the shared suite this file runs."
+    }
+  },
+  defaultOptions: [
+    {
+      fakeTimerMethods: [...DEFAULT_FAKE_TIMER_METHODS],
+      restoreTimerMethods: [...DEFAULT_RESTORE_TIMER_METHODS],
+      followImportedSuites: DEFAULT_FOLLOW_IMPORTED_SUITES,
+      sharedSuiteModules: [...DEFAULT_SHARED_SUITE_MODULES]
+    }
+  ],
+  create(context, [options]) {
+    const fakeMethods = new Set(options.fakeTimerMethods ?? DEFAULT_FAKE_TIMER_METHODS);
+    const restoreMethodList = options.restoreTimerMethods ?? DEFAULT_RESTORE_TIMER_METHODS;
+    const restoreMethods = new Set(restoreMethodList);
+    const followImportedSuites = options.followImportedSuites ?? DEFAULT_FOLLOW_IMPORTED_SUITES;
+    const sharedSuiteModules = options.sharedSuiteModules ?? DEFAULT_SHARED_SUITE_MODULES;
+    const restoreCallPattern = new RegExp(
+      `\\b(?:${restoreMethodList.map(escapeRegExp).join("|")})\\s*\\(`,
+      "u"
+    );
+    const fakeCalls = [];
+    const imports = [];
+    let hasRestore = false;
+    function restoredByImportedSuite() {
+      return imports.some((declaration) => {
+        const specifier = declaration.source.value;
+        if (!importIsCalled(context.sourceCode, declaration)) {
+          return false;
+        }
+        if (matchesAny(specifier, sharedSuiteModules)) {
+          return true;
+        }
+        if (!followImportedSuites || !specifier.startsWith(".")) {
+          return false;
+        }
+        const resolved = resolveRelative(context.filename, specifier);
+        const text = resolved === null ? null : readSource(resolved);
+        return text !== null && restoreCallPattern.test(text);
+      });
+    }
+    return {
+      ImportDeclaration(node) {
+        if (node.importKind !== "type") {
+          imports.push(node);
+        }
+      },
+      CallExpression(node) {
+        const method = calledMethodName(node);
+        if (method === null) {
+          return;
+        }
+        if (fakeMethods.has(method)) {
+          fakeCalls.push({ node, method });
+        }
+        if (restoreMethods.has(method)) {
+          hasRestore = true;
+        }
+      },
+      "Program:exit"() {
+        if (fakeCalls.length === 0 || hasRestore || restoredByImportedSuite()) {
+          return;
+        }
+        for (const { node, method } of fakeCalls) {
+          context.report({ node, messageId: "timersNotRestored", data: { method } });
+        }
+      }
+    };
+  }
+});
+
+// src/rules/interface-prefix-i.ts
+import { AST_NODE_TYPES as AST_NODE_TYPES2 } from "@typescript-eslint/utils";
+var RULE_NAME2 = "interface-prefix-i";
+function isAlreadyPrefixed(name) {
+  return /^I[A-Z]/.test(name);
+}
+function isInsideAmbientModule(node) {
+  let current = node.parent;
+  while (current) {
+    if (current.type === AST_NODE_TYPES2.TSModuleDeclaration) {
+      return true;
+    }
+    current = current.parent;
+  }
+  return false;
+}
+var interfacePrefixIRule = createRule({
+  name: RULE_NAME2,
+  meta: {
+    type: "suggestion",
+    docs: {
+      description: "Interface names must be prefixed with `I` followed by an uppercase letter. Module/global augmentations are exempt."
+    },
+    schema: [],
+    messages: {
+      missingPrefix: "Interface `{{name}}` must be prefixed with `I` (e.g. `I{{name}}`). Rename the declaration and its references."
+    }
+  },
+  defaultOptions: [],
+  create(context) {
+    return {
+      TSInterfaceDeclaration(node) {
+        const name = node.id.name;
+        if (isAlreadyPrefixed(name) || isInsideAmbientModule(node)) {
+          return;
+        }
+        context.report({ node: node.id, messageId: "missingPrefix", data: { name } });
+      }
+    };
+  }
+});
+
 // src/rules/no-bare-date-now.ts
-var RULE_NAME2 = "no-bare-date-now";
+import { AST_NODE_TYPES as AST_NODE_TYPES3 } from "@typescript-eslint/utils";
+var RULE_NAME3 = "no-bare-date-now";
 var DEFAULT_ALLOW_IN = ["**/clock.ts", "**/clock/**"];
-var optionSchema = {
+var optionSchema2 = {
   type: "object",
   additionalProperties: false,
   properties: {
@@ -141,19 +309,19 @@ var optionSchema = {
 };
 function isDateNowCall(node) {
   const callee = node.callee;
-  return callee.type === AST_NODE_TYPES2.MemberExpression && !callee.computed && callee.object.type === AST_NODE_TYPES2.Identifier && callee.object.name === "Date" && callee.property.type === AST_NODE_TYPES2.Identifier && callee.property.name === "now";
+  return callee.type === AST_NODE_TYPES3.MemberExpression && !callee.computed && callee.object.type === AST_NODE_TYPES3.Identifier && callee.object.name === "Date" && callee.property.type === AST_NODE_TYPES3.Identifier && callee.property.name === "now";
 }
 function isBareNewDate(node) {
-  return node.callee.type === AST_NODE_TYPES2.Identifier && node.callee.name === "Date" && node.arguments.length === 0;
+  return node.callee.type === AST_NODE_TYPES3.Identifier && node.callee.name === "Date" && node.arguments.length === 0;
 }
 var noBareDateNowRule = createRule({
-  name: RULE_NAME2,
+  name: RULE_NAME3,
   meta: {
     type: "problem",
     docs: {
       description: "Disallow bare `Date.now()` / `new Date()` in business logic. Read wall-clock time through a shared `clock` util (`nowMs()` / `now()`) so time is mockable."
     },
-    schema: [optionSchema],
+    schema: [optionSchema2],
     messages: {
       dateNow: "Use `nowMs()` from the shared `clock` util instead of bare `Date.now()`.",
       newDate: "Use `now()` from the shared `clock` util instead of bare `new Date()`."
@@ -180,20 +348,169 @@ var noBareDateNowRule = createRule({
   }
 });
 
+// src/rules/no-conditional-expect.ts
+import { AST_NODE_TYPES as AST_NODE_TYPES4 } from "@typescript-eslint/utils";
+var RULE_NAME4 = "no-conditional-expect";
+var DEFAULT_CHECK_LOOPS = false;
+var BRANCH_TYPES = /* @__PURE__ */ new Set([
+  AST_NODE_TYPES4.IfStatement,
+  AST_NODE_TYPES4.SwitchCase,
+  AST_NODE_TYPES4.ConditionalExpression,
+  AST_NODE_TYPES4.LogicalExpression,
+  AST_NODE_TYPES4.CatchClause
+]);
+var LOOP_TYPES = /* @__PURE__ */ new Set([
+  AST_NODE_TYPES4.ForStatement,
+  AST_NODE_TYPES4.ForInStatement,
+  AST_NODE_TYPES4.ForOfStatement,
+  AST_NODE_TYPES4.WhileStatement,
+  AST_NODE_TYPES4.DoWhileStatement
+]);
+var RUNNERS = /* @__PURE__ */ new Set(["it", "test", "describe", "suite"]);
+var ASSERTION_COUNT_GUARDS = /* @__PURE__ */ new Set(["assertions", "hasAssertions"]);
+var optionSchema3 = {
+  type: "object",
+  additionalProperties: false,
+  properties: {
+    checkLoops: { type: "boolean" }
+  }
+};
+function isExpectCall(node) {
+  const callee = node.callee;
+  if (callee.type === AST_NODE_TYPES4.Identifier) {
+    return callee.name === "expect";
+  }
+  return callee.type === AST_NODE_TYPES4.MemberExpression && !callee.computed && callee.object.type === AST_NODE_TYPES4.Identifier && callee.property.type === AST_NODE_TYPES4.Identifier && callee.property.name === "expect";
+}
+function isAssertionCountGuard(node) {
+  const callee = node.callee;
+  return callee.type === AST_NODE_TYPES4.MemberExpression && !callee.computed && callee.object.type === AST_NODE_TYPES4.Identifier && callee.object.name === "expect" && callee.property.type === AST_NODE_TYPES4.Identifier && ASSERTION_COUNT_GUARDS.has(callee.property.name);
+}
+function runnerName(callee) {
+  let current = callee;
+  for (; ; ) {
+    if (current.type === AST_NODE_TYPES4.MemberExpression) {
+      current = current.object;
+    } else if (current.type === AST_NODE_TYPES4.CallExpression) {
+      current = current.callee;
+    } else if (current.type === AST_NODE_TYPES4.TaggedTemplateExpression) {
+      current = current.tag;
+    } else {
+      break;
+    }
+  }
+  return current.type === AST_NODE_TYPES4.Identifier ? current.name : null;
+}
+function isRunnerCallback(node) {
+  const parent = node.parent;
+  if (parent.type !== AST_NODE_TYPES4.CallExpression || !parent.arguments.some((argument) => argument === node)) {
+    return false;
+  }
+  const name = runnerName(parent.callee);
+  return name !== null && RUNNERS.has(name);
+}
+function isFunctionNode(node) {
+  return node.type === AST_NODE_TYPES4.ArrowFunctionExpression || node.type === AST_NODE_TYPES4.FunctionExpression || node.type === AST_NODE_TYPES4.FunctionDeclaration;
+}
+function isUnconditionalPart(node, child) {
+  switch (node.type) {
+    case AST_NODE_TYPES4.IfStatement:
+    case AST_NODE_TYPES4.ConditionalExpression:
+      return node.test === child;
+    case AST_NODE_TYPES4.LogicalExpression:
+      return node.left === child;
+    case AST_NODE_TYPES4.SwitchCase:
+      return node.test === child;
+    case AST_NODE_TYPES4.ForStatement:
+      return node.init === child;
+    case AST_NODE_TYPES4.ForInStatement:
+    case AST_NODE_TYPES4.ForOfStatement:
+      return node.right === child;
+    default:
+      return false;
+  }
+}
+var noConditionalExpectRule = createRule({
+  name: RULE_NAME4,
+  meta: {
+    type: "problem",
+    docs: {
+      description: "Disallow `expect()` inside a branch, `catch` or loop that may not run: a skipped assertion lets a broken test pass."
+    },
+    schema: [optionSchema3],
+    messages: {
+      conditionalExpect: "This `expect()` sits inside a branch that may not run, so the test can pass without asserting anything. Assert unconditionally, or add `expect.assertions(n)` to the test."
+    }
+  },
+  defaultOptions: [{ checkLoops: DEFAULT_CHECK_LOOPS }],
+  create(context, [options]) {
+    const checkLoops = options.checkLoops ?? DEFAULT_CHECK_LOOPS;
+    const pending = /* @__PURE__ */ new Map();
+    const guarded = /* @__PURE__ */ new Set();
+    function isConditional(type) {
+      return BRANCH_TYPES.has(type) || checkLoops && LOOP_TYPES.has(type);
+    }
+    function scan(node) {
+      let conditional = false;
+      let child = node;
+      let current = node.parent;
+      while (current !== void 0 && current !== null) {
+        if (isFunctionNode(current) && isRunnerCallback(current)) {
+          return { boundary: current, conditional };
+        }
+        if (isConditional(current.type) && !isUnconditionalPart(current, child)) {
+          conditional = true;
+        }
+        child = current;
+        current = current.parent;
+      }
+      return { boundary: null, conditional };
+    }
+    return {
+      CallExpression(node) {
+        if (isAssertionCountGuard(node)) {
+          guarded.add(scan(node).boundary);
+          return;
+        }
+        if (!isExpectCall(node)) {
+          return;
+        }
+        const { boundary, conditional } = scan(node);
+        if (!conditional) {
+          return;
+        }
+        const list = pending.get(boundary) ?? [];
+        list.push(node);
+        pending.set(boundary, list);
+      },
+      "Program:exit"() {
+        for (const [boundary, calls] of pending) {
+          if (guarded.has(boundary)) {
+            continue;
+          }
+          for (const call of calls) {
+            context.report({ node: call, messageId: "conditionalExpect" });
+          }
+        }
+      }
+    };
+  }
+});
+
 // src/rules/no-focused-tests.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES3 } from "@typescript-eslint/utils";
-var RULE_NAME3 = "no-focused-tests";
+import { AST_NODE_TYPES as AST_NODE_TYPES5 } from "@typescript-eslint/utils";
+var RULE_NAME5 = "no-focused-tests";
 var FOCUSABLE_RUNNERS = /* @__PURE__ */ new Set(["it", "describe", "test"]);
 var FOCUSED_CALL_NAMES = /* @__PURE__ */ new Set(["fdescribe", "fit", "ddescribe"]);
 function rootRunnerName(node) {
   let current = node;
-  while (current.type === AST_NODE_TYPES3.MemberExpression && !current.computed) {
+  while (current.type === AST_NODE_TYPES5.MemberExpression && !current.computed) {
     current = current.object;
   }
-  return current.type === AST_NODE_TYPES3.Identifier ? current.name : null;
+  return current.type === AST_NODE_TYPES5.Identifier ? current.name : null;
 }
 var noFocusedTestsRule = createRule({
-  name: RULE_NAME3,
+  name: RULE_NAME5,
   meta: {
     type: "problem",
     docs: {
@@ -209,7 +526,7 @@ var noFocusedTestsRule = createRule({
   create(context) {
     return {
       MemberExpression(node) {
-        if (node.property.type !== AST_NODE_TYPES3.Identifier || node.property.name !== "only") {
+        if (node.property.type !== AST_NODE_TYPES5.Identifier || node.property.name !== "only") {
           return;
         }
         const runner = rootRunnerName(node.object);
@@ -222,7 +539,7 @@ var noFocusedTestsRule = createRule({
         }
       },
       CallExpression(node) {
-        if (node.callee.type === AST_NODE_TYPES3.Identifier && FOCUSED_CALL_NAMES.has(node.callee.name)) {
+        if (node.callee.type === AST_NODE_TYPES5.Identifier && FOCUSED_CALL_NAMES.has(node.callee.name)) {
           const name = node.callee.name;
           context.report({
             node: node.callee,
@@ -247,7 +564,7 @@ function looksLikeJsDoc(comment) {
 }
 
 // src/rules/no-historical-comments.ts
-var RULE_NAME4 = "no-historical-comments";
+var RULE_NAME6 = "no-historical-comments";
 var HISTORICAL_PATTERNS = [
   /\bbefore\s+the\s+fix\b/iu,
   /\bafter\s+the\s+fix\b/iu,
@@ -262,7 +579,7 @@ var HISTORICAL_PATTERNS = [
   /\bhistorical(?:ly)?\b/iu
 ];
 var noHistoricalCommentsRule = createRule({
-  name: RULE_NAME4,
+  name: RULE_NAME6,
   meta: {
     type: "suggestion",
     docs: {
@@ -305,7 +622,7 @@ var noHistoricalCommentsRule = createRule({
 });
 
 // src/rules/no-narration-comments.ts
-var RULE_NAME5 = "no-narration-comments";
+var RULE_NAME7 = "no-narration-comments";
 var NARRATION_PATTERNS = [
   /^here\s+we\b/iu,
   /^now\s+we\b/iu,
@@ -317,7 +634,7 @@ var NARRATION_PATTERNS = [
   /^let\s+me\b/iu
 ];
 var noNarrationCommentsRule = createRule({
-  name: RULE_NAME5,
+  name: RULE_NAME7,
   meta: {
     type: "suggestion",
     docs: {
@@ -358,7 +675,7 @@ var noNarrationCommentsRule = createRule({
 });
 
 // src/rules/no-pr-reference-comments.ts
-var RULE_NAME6 = "no-pr-reference-comments";
+var RULE_NAME8 = "no-pr-reference-comments";
 var PR_PATTERNS = [
   {
     pattern: /https?:\/\/github\.com\/[^\s)]+\/(?:pull|issues)\/\d+/iu,
@@ -378,7 +695,7 @@ var PR_PATTERNS = [
   }
 ];
 var noPrReferenceCommentsRule = createRule({
-  name: RULE_NAME6,
+  name: RULE_NAME8,
   meta: {
     type: "suggestion",
     docs: {
@@ -422,29 +739,29 @@ var noPrReferenceCommentsRule = createRule({
 import "@typescript-eslint/utils";
 
 // src/utils/ast.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES4 } from "@typescript-eslint/utils";
+import { AST_NODE_TYPES as AST_NODE_TYPES6 } from "@typescript-eslint/utils";
 function isEmptyStringLiteral(node) {
-  return node.type === AST_NODE_TYPES4.Literal && node.value === "";
+  return node.type === AST_NODE_TYPES6.Literal && node.value === "";
 }
 function isStaticMemberAccess(node, objectName, propertyName) {
-  if (node.type !== AST_NODE_TYPES4.MemberExpression || node.object.type !== AST_NODE_TYPES4.Identifier || node.object.name !== objectName) {
+  if (node.type !== AST_NODE_TYPES6.MemberExpression || node.object.type !== AST_NODE_TYPES6.Identifier || node.object.name !== objectName) {
     return false;
   }
   if (node.computed) {
-    return node.property.type === AST_NODE_TYPES4.Literal && node.property.value === propertyName;
+    return node.property.type === AST_NODE_TYPES6.Literal && node.property.value === propertyName;
   }
-  return node.property.type === AST_NODE_TYPES4.Identifier && node.property.name === propertyName;
+  return node.property.type === AST_NODE_TYPES6.Identifier && node.property.name === propertyName;
 }
 
 // src/rules/no-process-exit.ts
-var RULE_NAME7 = "no-process-exit";
+var RULE_NAME9 = "no-process-exit";
 var DEFAULT_ALLOW_IN2 = [
   "**/scripts/**",
   "**/bin/**",
   "**/cli/**",
   "**/*.config.{ts,js,mjs,cjs,cts,mts}"
 ];
-var optionSchema2 = {
+var optionSchema4 = {
   type: "object",
   additionalProperties: false,
   properties: {
@@ -459,13 +776,13 @@ function isProcessExit(node) {
   return isStaticMemberAccess(node.callee, "process", "exit");
 }
 var noProcessExitRule = createRule({
-  name: RULE_NAME7,
+  name: RULE_NAME9,
   meta: {
     type: "problem",
     docs: {
       description: "Disallow `process.exit()` outside bootstrap/shutdown paths and standalone CLIs. Application and service code must throw or reject so the lifecycle can shut down gracefully."
     },
-    schema: [optionSchema2],
+    schema: [optionSchema4],
     messages: {
       processExit: "`process.exit()` is reserved for bootstrap/shutdown and CLI entrypoints. Throw or reject and let the lifecycle handle teardown."
     }
@@ -486,14 +803,207 @@ var noProcessExitRule = createRule({
   }
 });
 
+// src/rules/no-real-network-in-unit-tests.ts
+import path2 from "path";
+import { AST_NODE_TYPES as AST_NODE_TYPES7 } from "@typescript-eslint/utils";
+var RULE_NAME10 = "no-real-network-in-unit-tests";
+var DEFAULT_TEST_FILE_SUFFIXES = [
+  ".test.ts",
+  ".test.tsx",
+  ".spec.ts",
+  ".spec.tsx",
+  ".test.js",
+  ".test.jsx",
+  ".spec.js",
+  ".spec.jsx"
+];
+var DEFAULT_INTEGRATION_MARKERS = [
+  ".integration.test.",
+  ".integration.spec.",
+  ".e2e.test.",
+  ".e2e.spec.",
+  ".e2e-spec.",
+  "/integration/",
+  "/e2e/"
+];
+var DEFAULT_NETWORK_CALLEES = ["fetch"];
+var DEFAULT_HTTP_CLIENTS = ["axios"];
+var HTTP_CLIENT_METHODS = /* @__PURE__ */ new Set([
+  "get",
+  "post",
+  "put",
+  "patch",
+  "delete",
+  "head",
+  "options",
+  "request"
+]);
+var GLOBAL_RECEIVERS = /* @__PURE__ */ new Set(["globalThis", "window", "self", "global"]);
+var MODULE_MOCKERS = /* @__PURE__ */ new Set(["mock", "doMock", "unstable_mockModule"]);
+var GLOBAL_STUBBERS = /* @__PURE__ */ new Set(["stubGlobal", "spyOn", "replaceProperty"]);
+var stringList = {
+  type: "array",
+  items: { type: "string", minLength: 1 },
+  uniqueItems: true
+};
+var optionSchema5 = {
+  type: "object",
+  additionalProperties: false,
+  properties: {
+    testFileSuffixes: stringList,
+    integrationMarkers: stringList,
+    networkCallees: stringList,
+    httpClients: stringList
+  }
+};
+function toPosixRelative(filename, cwd) {
+  const relative = path2.isAbsolute(filename) ? path2.relative(cwd, filename) : filename;
+  return `/${relative.split(path2.sep).join("/")}`;
+}
+function staticPropertyName(member) {
+  if (!member.computed && member.property.type === AST_NODE_TYPES7.Identifier) {
+    return member.property.name;
+  }
+  if (member.property.type === AST_NODE_TYPES7.Literal && typeof member.property.value === "string") {
+    return member.property.value;
+  }
+  return null;
+}
+function stringArgument(node, index) {
+  const argument = node.arguments[index];
+  return argument?.type === AST_NODE_TYPES7.Literal && typeof argument.value === "string" ? argument.value : null;
+}
+var noRealNetworkInUnitTestsRule = createRule({
+  name: RULE_NAME10,
+  meta: {
+    type: "problem",
+    docs: {
+      description: "Unit tests must not perform real network I/O: mock the HTTP client, or move the test to an integration suite."
+    },
+    schema: [optionSchema5],
+    messages: {
+      realNetworkInUnitTest: "Real network call `{{callee}}` in a unit test. Mock it, or move this test to an integration file."
+    }
+  },
+  defaultOptions: [
+    {
+      testFileSuffixes: [...DEFAULT_TEST_FILE_SUFFIXES],
+      integrationMarkers: [...DEFAULT_INTEGRATION_MARKERS],
+      networkCallees: [...DEFAULT_NETWORK_CALLEES],
+      httpClients: [...DEFAULT_HTTP_CLIENTS]
+    }
+  ],
+  create(context, [options]) {
+    const testSuffixes = options.testFileSuffixes ?? DEFAULT_TEST_FILE_SUFFIXES;
+    const integrationMarkers = options.integrationMarkers ?? DEFAULT_INTEGRATION_MARKERS;
+    const networkCallees = new Set(options.networkCallees ?? DEFAULT_NETWORK_CALLEES);
+    const httpClients = new Set(options.httpClients ?? DEFAULT_HTTP_CLIENTS);
+    const relPath = toPosixRelative(context.filename, context.cwd);
+    if (!testSuffixes.some((suffix) => relPath.endsWith(suffix))) {
+      return {};
+    }
+    if (integrationMarkers.some((marker) => relPath.includes(marker))) {
+      return {};
+    }
+    const findings = [];
+    const mocked = /* @__PURE__ */ new Set();
+    const importSources = /* @__PURE__ */ new Map();
+    function isLocalDouble(node, name) {
+      let scope = context.sourceCode.getScope(node);
+      while (scope !== null) {
+        const variable = scope.set.get(name);
+        if (variable !== void 0 && variable.defs.length > 0) {
+          return variable.defs.every((def) => def.type !== "ImportBinding");
+        }
+        scope = scope.upper;
+      }
+      return false;
+    }
+    function recordMock(node) {
+      const callee = node.callee;
+      if (callee.type !== AST_NODE_TYPES7.MemberExpression) {
+        return;
+      }
+      const method = staticPropertyName(callee);
+      if (method !== null && MODULE_MOCKERS.has(method)) {
+        const moduleName = stringArgument(node, 0);
+        if (moduleName !== null) {
+          mocked.add(moduleName);
+        }
+      }
+      if (method !== null && GLOBAL_STUBBERS.has(method)) {
+        const name = method === "stubGlobal" ? stringArgument(node, 0) : stringArgument(node, 1);
+        if (name !== null) {
+          mocked.add(name);
+        }
+      }
+    }
+    function networkCallee(node) {
+      const callee = node.callee;
+      if (callee.type === AST_NODE_TYPES7.Identifier) {
+        const isNetworkName = networkCallees.has(callee.name) || httpClients.has(callee.name);
+        return isNetworkName && !isLocalDouble(callee, callee.name) ? callee.name : null;
+      }
+      if (callee.type !== AST_NODE_TYPES7.MemberExpression) {
+        return null;
+      }
+      const method = staticPropertyName(callee);
+      if (method === null || callee.object.type !== AST_NODE_TYPES7.Identifier) {
+        return null;
+      }
+      const receiver = callee.object.name;
+      if (GLOBAL_RECEIVERS.has(receiver) && networkCallees.has(method)) {
+        return method;
+      }
+      if (httpClients.has(receiver) && HTTP_CLIENT_METHODS.has(method) && !isLocalDouble(callee.object, receiver)) {
+        return `${receiver}.${method}`;
+      }
+      return null;
+    }
+    return {
+      ImportDeclaration(node) {
+        for (const specifier of node.specifiers) {
+          importSources.set(specifier.local.name, node.source.value);
+        }
+      },
+      CallExpression(node) {
+        recordMock(node);
+        const callee = networkCallee(node);
+        if (callee !== null) {
+          findings.push({ node, callee });
+        }
+      },
+      AssignmentExpression(node) {
+        const target = node.left;
+        if (target.type === AST_NODE_TYPES7.MemberExpression && target.object.type === AST_NODE_TYPES7.Identifier && GLOBAL_RECEIVERS.has(target.object.name)) {
+          const name = staticPropertyName(target);
+          if (name !== null) {
+            mocked.add(name);
+          }
+        }
+      },
+      "Program:exit"() {
+        for (const { node, callee } of findings) {
+          const root = callee.split(".")[0] ?? callee;
+          const source = importSources.get(root);
+          if (mocked.has(root) || source !== void 0 && mocked.has(source)) {
+            continue;
+          }
+          context.report({ node, messageId: "realNetworkInUnitTest", data: { callee } });
+        }
+      }
+    };
+  }
+});
+
 // src/rules/no-template-trim-empty-ternary.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES5 } from "@typescript-eslint/utils";
-var RULE_NAME8 = "no-template-trim-empty-ternary";
+import { AST_NODE_TYPES as AST_NODE_TYPES8 } from "@typescript-eslint/utils";
+var RULE_NAME11 = "no-template-trim-empty-ternary";
 function isTrimCallOnTemplate(node) {
-  return node.type === AST_NODE_TYPES5.CallExpression && node.callee.type === AST_NODE_TYPES5.MemberExpression && node.callee.property.type === AST_NODE_TYPES5.Identifier && node.callee.property.name === "trim" && node.callee.object.type === AST_NODE_TYPES5.TemplateLiteral;
+  return node.type === AST_NODE_TYPES8.CallExpression && node.callee.type === AST_NODE_TYPES8.MemberExpression && node.callee.property.type === AST_NODE_TYPES8.Identifier && node.callee.property.name === "trim" && node.callee.object.type === AST_NODE_TYPES8.TemplateLiteral;
 }
 function matchesTemplateTrimEmptyTest(test) {
-  if (test.type !== AST_NODE_TYPES5.BinaryExpression) {
+  if (test.type !== AST_NODE_TYPES8.BinaryExpression) {
     return false;
   }
   if (test.operator !== "===" && test.operator !== "!==") {
@@ -502,7 +1012,7 @@ function matchesTemplateTrimEmptyTest(test) {
   return isTrimCallOnTemplate(test.left) && isEmptyStringLiteral(test.right) || isEmptyStringLiteral(test.left) && isTrimCallOnTemplate(test.right);
 }
 var noTemplateTrimEmptyTernaryRule = createRule({
-  name: RULE_NAME8,
+  name: RULE_NAME11,
   meta: {
     type: "suggestion",
     docs: {
@@ -526,10 +1036,10 @@ var noTemplateTrimEmptyTernaryRule = createRule({
 });
 
 // src/utils/preferEarlyReturn.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES6 } from "@typescript-eslint/utils";
+import { AST_NODE_TYPES as AST_NODE_TYPES9 } from "@typescript-eslint/utils";
 var MIN_CONSEQUENT_STATEMENTS = 2;
 function getFunctionBlockBody(node) {
-  if (node.body.type !== AST_NODE_TYPES6.BlockStatement) {
+  if (node.body.type !== AST_NODE_TYPES9.BlockStatement) {
     return null;
   }
   return node.body;
@@ -539,13 +1049,13 @@ function findWrappedHappyPathIf(body) {
     return null;
   }
   const lastStatement = body.body[body.body.length - 1];
-  if (lastStatement === void 0 || lastStatement.type !== AST_NODE_TYPES6.IfStatement) {
+  if (lastStatement === void 0 || lastStatement.type !== AST_NODE_TYPES9.IfStatement) {
     return null;
   }
   if (lastStatement.alternate !== null) {
     return null;
   }
-  if (lastStatement.consequent.type !== AST_NODE_TYPES6.BlockStatement) {
+  if (lastStatement.consequent.type !== AST_NODE_TYPES9.BlockStatement) {
     return null;
   }
   if (lastStatement.consequent.body.length < MIN_CONSEQUENT_STATEMENTS) {
@@ -555,9 +1065,9 @@ function findWrappedHappyPathIf(body) {
 }
 
 // src/rules/prefer-early-return.ts
-var RULE_NAME9 = "prefer-early-return";
+var RULE_NAME12 = "prefer-early-return";
 var preferEarlyReturnRule = createRule({
-  name: RULE_NAME9,
+  name: RULE_NAME12,
   meta: {
     type: "problem",
     docs: {
@@ -588,8 +1098,189 @@ var preferEarlyReturnRule = createRule({
   }
 });
 
+// src/rules/no-vacuous-expect.ts
+import { AST_NODE_TYPES as AST_NODE_TYPES10 } from "@typescript-eslint/utils";
+var RULE_NAME13 = "no-vacuous-expect";
+var DEFAULT_WEAK_MATCHERS = [
+  "toBeDefined",
+  "toBeTruthy",
+  "toBeFalsy",
+  "not.toBeUndefined"
+];
+var DEFAULT_ASSERTION_CALLEES = ["^assert", "^expect\\w", "\\.expect$"];
+var TYPEOF_RESULTS = /* @__PURE__ */ new Set([
+  "undefined",
+  "object",
+  "boolean",
+  "number",
+  "bigint",
+  "string",
+  "symbol",
+  "function"
+]);
+var EQUALITY_MATCHERS = /* @__PURE__ */ new Set(["toBe", "toEqual", "toStrictEqual"]);
+var TEST_RUNNERS = /* @__PURE__ */ new Set(["it", "test"]);
+var optionSchema6 = {
+  type: "object",
+  additionalProperties: false,
+  properties: {
+    weakMatchers: { type: "array", items: { type: "string", minLength: 1 }, uniqueItems: true },
+    assertionCallees: {
+      type: "array",
+      items: { type: "string", minLength: 1 },
+      uniqueItems: true
+    }
+  }
+};
+function isExpectCall2(node) {
+  return node.type === AST_NODE_TYPES10.CallExpression && node.callee.type === AST_NODE_TYPES10.Identifier && node.callee.name === "expect";
+}
+function matcherCall(node) {
+  const callee = node.callee;
+  if (callee.type !== AST_NODE_TYPES10.MemberExpression || callee.computed || callee.property.type !== AST_NODE_TYPES10.Identifier) {
+    return null;
+  }
+  let negated = false;
+  let current = callee.object;
+  while (current.type === AST_NODE_TYPES10.MemberExpression) {
+    if (!current.computed && current.property.type === AST_NODE_TYPES10.Identifier && current.property.name === "not") {
+      negated = !negated;
+    }
+    current = current.object;
+  }
+  if (!isExpectCall2(current)) {
+    return null;
+  }
+  const name = callee.property.name;
+  return { root: current, matcher: negated ? `not.${name}` : name };
+}
+function calleePath(callee) {
+  if (callee.type === AST_NODE_TYPES10.Identifier) {
+    return callee.name;
+  }
+  if (callee.type === AST_NODE_TYPES10.MemberExpression && !callee.computed && callee.property.type === AST_NODE_TYPES10.Identifier) {
+    const owner = callee.object.type === AST_NODE_TYPES10.Identifier ? callee.object.name : "";
+    return `${owner}.${callee.property.name}`;
+  }
+  return null;
+}
+function runnerName2(callee) {
+  let current = callee;
+  for (; ; ) {
+    if (current.type === AST_NODE_TYPES10.MemberExpression) {
+      current = current.object;
+    } else if (current.type === AST_NODE_TYPES10.CallExpression) {
+      current = current.callee;
+    } else if (current.type === AST_NODE_TYPES10.TaggedTemplateExpression) {
+      current = current.tag;
+    } else {
+      break;
+    }
+  }
+  return current.type === AST_NODE_TYPES10.Identifier ? current.name : null;
+}
+function isTestCallback(node) {
+  const parent = node.parent;
+  if (parent.type !== AST_NODE_TYPES10.CallExpression || parent.arguments[1] !== node) {
+    return false;
+  }
+  const name = runnerName2(parent.callee);
+  return name !== null && TEST_RUNNERS.has(name);
+}
+function isTypeofExpression(node) {
+  return node?.type === AST_NODE_TYPES10.UnaryExpression && node.operator === "typeof";
+}
+function isTypeofResult(node) {
+  return node?.type === AST_NODE_TYPES10.Literal && typeof node.value === "string" && TYPEOF_RESULTS.has(node.value);
+}
+function isLiteralTautology(actual, expected) {
+  return actual?.type === AST_NODE_TYPES10.Literal && expected?.type === AST_NODE_TYPES10.Literal && !("regex" in actual) && actual.value === expected.value;
+}
+var noVacuousExpectRule = createRule({
+  name: RULE_NAME13,
+  meta: {
+    type: "problem",
+    docs: {
+      description: "Disallow vacuous expects (`typeof` checks, literal tautologies, a sole `toBeDefined`/`toBeTruthy`): a test must assert behaviour that a real regression would break."
+    },
+    schema: [optionSchema6],
+    messages: {
+      typeofExpect: "Do not assert on `typeof`; that only proves a binding exists. Assert a result, a thrown error or an observable effect.",
+      tautologyExpect: "This expect compares a literal with itself and can never fail. Assert something a real regression would break.",
+      soleWeakExpect: "A sole `{{matcher}}` does not pin behaviour. Assert on the value or the outcome, or delete the test."
+    }
+  },
+  defaultOptions: [
+    {
+      weakMatchers: [...DEFAULT_WEAK_MATCHERS],
+      assertionCallees: [...DEFAULT_ASSERTION_CALLEES]
+    }
+  ],
+  create(context, [options]) {
+    const weakMatchers = new Set(options.weakMatchers ?? DEFAULT_WEAK_MATCHERS);
+    const assertionCallees = (options.assertionCallees ?? DEFAULT_ASSERTION_CALLEES).map(
+      (source) => new RegExp(source, "u")
+    );
+    const stack = [];
+    function enter(node) {
+      if (isTestCallback(node)) {
+        stack.push({ node, assertions: 0, weak: null });
+      }
+    }
+    function exit(node) {
+      const frame = stack.at(-1);
+      if (frame?.node !== node) {
+        return;
+      }
+      stack.pop();
+      if (frame.assertions === 1 && frame.weak !== null) {
+        context.report({
+          node: frame.weak.node,
+          messageId: "soleWeakExpect",
+          data: { matcher: frame.weak.matcher }
+        });
+      }
+    }
+    return {
+      ArrowFunctionExpression: enter,
+      FunctionExpression: enter,
+      "ArrowFunctionExpression:exit": exit,
+      "FunctionExpression:exit": exit,
+      CallExpression(node) {
+        const frame = stack.at(-1);
+        const call = matcherCall(node);
+        if (call === null) {
+          const path3 = calleePath(node.callee);
+          if (frame !== void 0 && path3 !== null && assertionCallees.some((re) => re.test(path3))) {
+            frame.assertions += 1;
+          }
+          return;
+        }
+        if (frame !== void 0) {
+          frame.assertions += 1;
+          if (weakMatchers.has(call.matcher)) {
+            frame.weak = { node, matcher: call.matcher };
+          }
+        }
+        const negated = call.matcher.startsWith("not.");
+        const base = negated ? call.matcher.slice("not.".length) : call.matcher;
+        if (!EQUALITY_MATCHERS.has(base)) {
+          return;
+        }
+        const actual = call.root.arguments[0];
+        const expected = node.arguments[0];
+        if (isTypeofExpression(actual) && isTypeofResult(expected)) {
+          context.report({ node, messageId: "typeofExpect" });
+        } else if (!negated && isLiteralTautology(actual, expected)) {
+          context.report({ node, messageId: "tautologyExpect" });
+        }
+      }
+    };
+  }
+});
+
 // src/rules/skipped-tests-need-tracking.ts
-var RULE_NAME10 = "skipped-tests-need-tracking";
+var RULE_NAME14 = "skipped-tests-need-tracking";
 var SKIP_PATTERNS = [
   { pattern: /\b(?:it|test|describe)\.skip\s*\(/u, label: ".skip(" },
   { pattern: /\b(?:it|test|describe)\.fixme\s*\(/u, label: ".fixme(" },
@@ -599,7 +1290,7 @@ var SKIP_PATTERNS = [
 ];
 var DEFAULT_MARKERS = ["https?://\\S+", "TODO\\(@?\\S+\\)"];
 var DEFAULT_LOOKBACK = 30;
-var optionSchema3 = {
+var optionSchema7 = {
   type: "object",
   additionalProperties: false,
   properties: {
@@ -613,13 +1304,13 @@ var optionSchema3 = {
   }
 };
 var skippedTestsNeedTrackingRule = createRule({
-  name: RULE_NAME10,
+  name: RULE_NAME14,
   meta: {
     type: "problem",
     docs: {
       description: "Skipped tests (`.skip` / `.fixme` / `xit` / `xdescribe`) must carry a tracking marker (an issue URL or `TODO(@owner)`) on or above the line, so the debt has an owner instead of rotting silently."
     },
-    schema: [optionSchema3],
+    schema: [optionSchema7],
     messages: {
       needsTracking: "Skipped test `{{label}}` has no tracking marker. Add an issue URL or `TODO(@owner)` on the same line or above so the skip has an owner."
     }
@@ -671,6 +1362,10 @@ var rules = {
   "no-pr-reference-comments": noPrReferenceCommentsRule,
   "no-focused-tests": noFocusedTestsRule,
   "skipped-tests-need-tracking": skippedTestsNeedTrackingRule,
+  "no-vacuous-expect": noVacuousExpectRule,
+  "no-conditional-expect": noConditionalExpectRule,
+  "fake-timers-must-be-restored": fakeTimersMustBeRestoredRule,
+  "no-real-network-in-unit-tests": noRealNetworkInUnitTestsRule,
   // Available but omitted from `recommended` (opinionated / niche).
   "interface-prefix-i": interfacePrefixIRule,
   "no-template-trim-empty-ternary": noTemplateTrimEmptyTernaryRule
@@ -678,7 +1373,7 @@ var rules = {
 
 // src/index.ts
 var NAMESPACE = "noctcore-code-quality";
-var VERSION = "0.1.0";
+var VERSION = "0.2.0";
 var plugin = {
   meta: { name: "@noctcore/eslint-plugin-code-quality", version: VERSION },
   rules,