@nocobase/flow-engine 2.0.0-alpha.7 → 2.0.0-alpha.71

package/src/__tests__/blockScopedFlowEngine.test.ts

@@ -0,0 +1,154 @@
+/**
+ * This file is part of the NocoBase (R) project.
+ * Copyright (c) 2020-2024 NocoBase Co., Ltd.
+ * Authors: NocoBase Team.
+ *
+ * This project is dual-licensed under AGPL-3.0 and NocoBase Commercial License.
+ * For more information, please refer to: https://www.nocobase.com/agreement.
+ */
+
+import { describe, expect, it, vi } from 'vitest';
+import { APIClient as SDKApiClient } from '@nocobase/sdk';
+import { FlowEngine } from '../flowEngine';
+import { createBlockScopedEngine } from '../BlockScopedFlowEngine';
+import { FlowModel } from '../models';
+
+describe('BlockScopedFlowEngine', () => {
+  it('shares global actions/events and model classes with parent', async () => {
+    const parent = new FlowEngine();
+    // 在运行时 host app 会注入 api，这里补一个最小 mock，避免偶发访问 ctx.auth 抛错
+    const api = new SDKApiClient({ storageType: 'memory' });
+    api.auth.role = 'guest';
+    api.auth.locale = 'en-US';
+    api.auth.token = 't';
+    parent.context.defineProperty('api', { value: api });
+    parent.registerActions({
+      ping: {
+        name: 'ping',
+        handler: () => 'pong',
+      },
+    });
+    const child = createBlockScopedEngine(parent);
+
+    // child can read parent's action
+    expect(child.getAction('ping')).toBeDefined();
+
+    // registering via child should affect parent
+    child.registerActions({ pong: { name: 'pong', handler: () => 'ok' } });
+    expect(parent.getAction('pong')).toBeDefined();
+
+    // model class resolution is proxied
+    class TestModel extends FlowModel {}
+    parent.registerModels({ TestModel });
+    expect(child.getModelClass('TestModel')).toBeDefined();
+  });
+
+  it('isolates model instances map and beforeRender cache across engines with identical model uid', async () => {
+    const parent = new FlowEngine();
+    // 提供最小 api mock，满足 ctx.auth 相关 getter
+    const api = new SDKApiClient({ storageType: 'memory' });
+    api.auth.role = 'guest';
+    api.auth.locale = 'en-US';
+    api.auth.token = 't';
+    parent.context.defineProperty('api', { value: api });
+    const child = createBlockScopedEngine(parent);
+
+    let count = 0;
+    class CounterModel extends FlowModel {}
+    CounterModel.registerFlow({
+      key: 'autoCounter',
+      steps: {
+        s1: {
+          handler: async () => {
+            count += 1;
+            return count;
+          },
+        },
+      },
+    });
+
+    const uid = 'model-uid-cache';
+    const pm = parent.createModel<CounterModel>({ use: CounterModel, uid });
+    const cm = child.createModel<CounterModel>({ use: CounterModel, uid });
+
+    await pm.dispatchEvent('beforeRender');
+    expect(count).toBe(1);
+
+    // If cache was shared, the next call would hit cache and not increment.
+    await cm.dispatchEvent('beforeRender');
+    expect(count).toBe(2);
+  });
+
+  it('stacks engines and repairs chain when unlinking a middle block-scoped engine', () => {
+    const root = new FlowEngine();
+    // 提供最小 api mock，满足 ctx.auth 相关 getter
+    const api = new SDKApiClient({ storageType: 'memory' });
+    api.auth.role = 'guest';
+    api.auth.locale = 'en-US';
+    api.auth.token = 't';
+    root.context.defineProperty('api', { value: api });
+    const c1 = createBlockScopedEngine(root);
+    const c2 = createBlockScopedEngine(root);
+    const c3 = createBlockScopedEngine(root);
+
+    // chain root -> c1 -> c2 -> c3
+    expect(root.nextEngine).toBeTruthy();
+    expect(root.nextEngine?.nextEngine).toBeTruthy();
+    expect(root.nextEngine?.nextEngine?.nextEngine).toBeTruthy();
+
+    // unlink middle (c2) should link c1 <-> c3 and keep the tail intact
+    c2.unlinkFromStack();
+
+    // root.nextEngine 指向的是被代理的本地 FlowEngine 实例，不与 c1 的 Proxy 引用相等
+    // 这里通过前后指针关系来校验链修复是否正确
+    const first = root.nextEngine;
+    const second = first?.nextEngine;
+    expect(first?.previousEngine).toBe(root);
+    expect(second?.previousEngine).toBe(first);
+    expect(second?.nextEngine).toBeUndefined();
+  });
+
+  it('global model lookup traverses from top to root across stack', () => {
+    const root = new FlowEngine();
+    // 提供最小 api mock，满足 ctx.auth 相关 getter
+    const api = new SDKApiClient({ storageType: 'memory' });
+    api.auth.role = 'guest';
+    api.auth.locale = 'en-US';
+    api.auth.token = 't';
+    root.context.defineProperty('api', { value: api });
+    const c1 = createBlockScopedEngine(root);
+    const c2 = createBlockScopedEngine(root);
+
+    class TM extends FlowModel {}
+    const uid = 'same-uid-global-lookup';
+    const mRoot = root.createModel<TM>({ use: TM, uid });
+    const m1 = c1.createModel<TM>({ use: TM, uid });
+    const m2 = c2.createModel<TM>({ use: TM, uid });
+
+    // sanity: each scope returns its own when not global
+    expect(root.getModel(uid)).toBe(mRoot);
+    expect(c1.getModel(uid)).toBe(m1);
+    expect(c2.getModel(uid)).toBe(m2);
+
+    // global search from any engine hits the top-most engine's instance first
+    expect(root.getModel(uid, true)).toBe(m2);
+    expect(c1.getModel(uid, true)).toBe(m2);
+    expect(c2.getModel(uid, true)).toBe(m2);
+  });
+
+  it('delegates saveModel to parent (concurrency gate sharing)', async () => {
+    const parent = new FlowEngine();
+    // 提供最小 api mock，满足 ctx.auth 相关 getter
+    const api = new SDKApiClient({ storageType: 'memory' });
+    api.auth.role = 'guest';
+    api.auth.locale = 'en-US';
+    api.auth.token = 't';
+    parent.context.defineProperty('api', { value: api });
+    const child = createBlockScopedEngine(parent);
+    const spy = vi.spyOn(parent, 'saveModel').mockResolvedValueOnce(true);
+    class T extends FlowModel {}
+    const m = child.createModel<T>({ use: T });
+    await child.saveModel(m);
+    expect(spy).toHaveBeenCalledOnce();
+  });
+});

package/src/__tests__/createViewMeta.popup.test.ts

@@ -0,0 +1,203 @@
+/**
+ * This file is part of the NocoBase (R) project.
+ * Copyright (c) 2020-2024 NocoBase Co., Ltd.
+ * Authors: NocoBase Team.
+ *
+ * This project is dual-licensed under AGPL-3.0 and NocoBase Commercial License.
+ * For more information, please refer to: https://www.nocobase.com/agreement.
+ */
+
+import { describe, it, expect, vi } from 'vitest';
+import { FlowContext } from '../flowContext';
+import { FlowEngine } from '../flowEngine';
+import type { FlowView } from '../views/FlowView';
+import { createPopupMeta } from '../views/createViewMeta';
+
+describe('createPopupMeta - popup variables', () => {
+  function makeCtx() {
+    const engine = new FlowEngine();
+    const ctx = new FlowContext();
+    ctx.defineProperty('engine', { value: engine });
+    // 简化 i18n：直接返回 key
+    ctx.defineProperty('t', { value: (s: string) => s });
+    return { engine, ctx };
+  }
+
+  it('buildVariablesParams(record) uses anchor view instead of ctx.view', async () => {
+    const { engine, ctx } = makeCtx();
+
+    // 模拟锚定弹窗视图（被测试目标）
+    const anchorView: FlowView = {
+      type: 'embed',
+      inputArgs: {},
+      Header: null,
+      Footer: null,
+      close: () => void 0,
+      update: () => void 0,
+      navigation: {
+        viewStack: [
+          {
+            viewUid: 'base-page-uid',
+          },
+          {
+            viewUid: 'popup-uid',
+            filterByTk: 111,
+            sourceId: 42,
+          },
+        ],
+      } as any,
+    } as any;
+
+    // ctx.view 指向另一个（例如设置弹窗）
+    ctx.defineProperty('view', {
+      value: {
+        type: 'dialog',
+        inputArgs: {},
+        navigation: {
+          viewStack: [
+            {
+              viewUid: 'settings-uid',
+              filterByTk: 9999,
+            },
+          ],
+        },
+      },
+    });
+
+    // 为两个视图 uid 注入不同的 openView 配置，确保只取锚定视图
+    const popupModel = {
+      getStepParams: vi.fn((_fk: string, sk: string) =>
+        sk === 'openView'
+          ? {
+              collectionName: 'posts',
+              dataSourceKey: 'main',
+              associationName: 'users.posts',
+            }
+          : undefined,
+      ),
+    } as any;
+    const settingsModel = {
+      getStepParams: vi.fn((_fk: string, sk: string) =>
+        sk === 'openView'
+          ? {
+              collectionName: 'comments',
+              dataSourceKey: 'main',
+            }
+          : undefined,
+      ),
+    } as any;
+
+    const getModelSpy = vi.spyOn(engine as any, 'getModel');
+    getModelSpy.mockImplementation((uid: string) => (uid === 'popup-uid' ? popupModel : settingsModel));
+
+    const metaFactory = createPopupMeta(ctx, anchorView);
+    const meta = (await metaFactory())!;
+
+    // record 应来自锚定视图的 openView 配置
+    const vars = (await meta.buildVariablesParams!(ctx)) as any;
+    expect(vars).toBeTruthy();
+    expect(vars.record).toEqual({
+      collection: 'posts',
+      dataSourceKey: 'main',
+      filterByTk: 111,
+      associationName: 'users.posts',
+      sourceId: 42,
+    });
+
+    // 确认没有误用 ctx.view（settings-uid）的集合
+    expect(vars.record.collection).not.toBe('comments');
+  });
+
+  it('properties() provides a record factory node (lazy) with title', async () => {
+    const { engine, ctx } = makeCtx();
+    // 只要能通过 anchorView 推断到集合名和主键即可；集合详情在懒加载时再取
+    const anchorView: FlowView = {
+      type: 'embed',
+      inputArgs: {},
+      Header: null,
+      Footer: null,
+      close: () => void 0,
+      update: () => void 0,
+      navigation: { viewStack: [{ viewUid: 'base-page-uid' }, { viewUid: 'popup-uid', filterByTk: 1 }] } as any,
+    } as any;
+    const popupModel = {
+      getStepParams: vi.fn((_fk: string, sk: string) =>
+        sk === 'openView'
+          ? {
+              collectionName: 'tasks',
+              dataSourceKey: 'main',
+            }
+          : undefined,
+      ),
+    } as any;
+    vi.spyOn(engine as any, 'getModel').mockImplementation(() => popupModel);
+
+    const meta = (await createPopupMeta(ctx, anchorView)())!;
+    const props = typeof meta.properties === 'function' ? await (meta.properties as any)() : meta.properties || {};
+    // 断言存在 record 节点工厂，且有标题（懒加载，不触发集合访问）
+    expect(typeof props.record).toBe('function');
+    expect((props.record as any).title).toBe('Current popup record');
+    expect((props.record as any).hasChildren).toBe(true);
+  });
+
+  it('treats views with openerUids as popup (meta visible)', async () => {
+    const { ctx } = makeCtx();
+
+    // openerUids 作为路由栈缺失时的兜底标记：即使没有 navigation.viewStack，也应展示 ctx.popup 元信息
+    const anchorView: FlowView = {
+      type: 'dialog',
+      inputArgs: {
+        openerUids: ['opener-uid-1'],
+        viewUid: 'popup-uid',
+        dataSourceKey: 'main',
+        collectionName: 'posts',
+        filterByTk: 1,
+      },
+      Header: null,
+      Footer: null,
+      close: () => void 0,
+      update: () => void 0,
+    } as any;
+
+    const meta = (await createPopupMeta(ctx, anchorView)())!;
+    expect(typeof meta.hidden).toBe('function');
+    expect((meta.hidden as any)()).toBe(false);
+    expect(typeof meta.disabled).toBe('function');
+    expect((meta.disabled as any)()).toBe(false);
+
+    const vars = (await meta.buildVariablesParams!(ctx)) as any;
+    expect(vars).toBeTruthy();
+    expect(vars.record).toEqual({
+      collection: 'posts',
+      dataSourceKey: 'main',
+      filterByTk: 1,
+      associationName: undefined,
+      sourceId: undefined,
+    });
+  });
+
+  it('does not expose popup.record without filterByTk', async () => {
+    const { ctx } = makeCtx();
+
+    const anchorView: FlowView = {
+      type: 'dialog',
+      inputArgs: {
+        openerUids: ['opener-uid-1'],
+        viewUid: 'popup-uid',
+        dataSourceKey: 'main',
+        collectionName: 'posts',
+        // filterByTk 缺失：不应展示“当前弹窗记录”变量
+      },
+      Header: null,
+      Footer: null,
+      close: () => void 0,
+      update: () => void 0,
+    } as any;
+
+    ctx.defineProperty('view', { value: anchorView });
+
+    const meta = (await createPopupMeta(ctx, anchorView)())!;
+    const props = typeof meta.properties === 'function' ? await (meta.properties as any)() : meta.properties || {};
+    expect(props.record).toBeUndefined();
+  });
+});

package/src/__tests__/flow-engine.test.ts

@@ -98,6 +98,9 @@ describe('FlowEngine', () => {
         return true;
       }
       async move() {}
+      async duplicate() {
+        return null;
+      }
     }
 
     let repo: MockFlowModelRepository;

package/src/__tests__/flowContext.test.ts

@@ -241,6 +241,7 @@ describe('FlowContext properties and methods', () => {
         parentTitles: undefined,
         disabled: false,
         disabledReason: undefined,
+        hidden: false,
         children: undefined,
       },
       {
@@ -253,6 +254,7 @@ describe('FlowContext properties and methods', () => {
         parentTitles: undefined,
         disabled: false,
         disabledReason: undefined,
+        hidden: false,
         children: [
           {
             name: 'baz',
@@ -264,6 +266,7 @@ describe('FlowContext properties and methods', () => {
             parentTitles: ['Bar'],
             disabled: false,
             disabledReason: undefined,
+            hidden: false,
             children: undefined,
           },
           {
@@ -276,6 +279,7 @@ describe('FlowContext properties and methods', () => {
             parentTitles: ['Bar'],
             disabled: false,
             disabledReason: undefined,
+            hidden: false,
             children: undefined,
           },
         ],
@@ -316,6 +320,7 @@ describe('FlowContext properties and methods', () => {
         parentTitles: undefined,
         disabled: false,
         disabledReason: undefined,
+        hidden: false,
         children: undefined,
       },
       {
@@ -328,6 +333,7 @@ describe('FlowContext properties and methods', () => {
         parentTitles: undefined,
         disabled: false,
         disabledReason: undefined,
+        hidden: false,
         children: [
           {
             name: 'x',
@@ -339,6 +345,7 @@ describe('FlowContext properties and methods', () => {
             parentTitles: ['Local Bar'],
             disabled: false,
             disabledReason: undefined,
+            hidden: false,
             children: undefined,
           },
         ],
@@ -390,6 +397,7 @@ describe('FlowContext properties and methods', () => {
       parentTitles: undefined,
       disabled: false,
       disabledReason: undefined,
+      hidden: false,
       children: [
         {
           name: 'field1',
@@ -401,6 +409,7 @@ describe('FlowContext properties and methods', () => {
           parentTitles: ['Sync Property'],
           disabled: false,
           disabledReason: undefined,
+          hidden: false,
           children: undefined,
         },
         {
@@ -413,6 +422,7 @@ describe('FlowContext properties and methods', () => {
           parentTitles: ['Sync Property'],
           disabled: false,
           disabledReason: undefined,
+          hidden: false,
           children: undefined,
         },
       ],
@@ -436,6 +446,7 @@ describe('FlowContext properties and methods', () => {
         parentTitles: ['Async Property'],
         disabled: false,
         disabledReason: undefined,
+        hidden: false,
         children: undefined,
       },
       {
@@ -448,6 +459,7 @@ describe('FlowContext properties and methods', () => {
         parentTitles: ['Async Property'],
         disabled: false,
         disabledReason: undefined,
+        hidden: false,
         children: undefined,
       },
     ]);
@@ -747,6 +759,96 @@ describe('FlowEngine context', () => {
     expect(engine.context.appName).toBe('NocoBase');
   });
 
+  it('ctx.sql should resolve template variables from caller context in delegate chain', async () => {
+    const engine = new FlowEngine();
+    const request = vi.fn(async () => ({ data: { data: [] } }));
+    engine.context.defineProperty('api', {
+      value: { request },
+    });
+    engine.context.defineProperty('minId', {
+      get: () => 999,
+      cache: false,
+    });
+
+    const callerCtx = new FlowContext();
+    callerCtx.addDelegate(engine.context);
+    callerCtx.defineProperty('minId', {
+      get: () => 1,
+      cache: false,
+    });
+
+    await callerCtx.sql.run('SELECT * FROM users WHERE id > {{ctx.minId}}', { type: 'selectRows' });
+
+    expect(request).toHaveBeenCalledTimes(1);
+    const config = request.mock.calls[0]?.[0];
+    expect(config?.url).toBe('flowSql:run');
+    expect(config?.data.bind.__var1).toBe(1);
+  });
+
+  it('ctx.sql should not share repository instance between different caller contexts', async () => {
+    const engine = new FlowEngine();
+    const request = vi.fn(async () => ({ data: { data: [] } }));
+    engine.context.defineProperty('api', {
+      value: { request },
+    });
+
+    const caller1 = new FlowContext();
+    caller1.addDelegate(engine.context);
+    caller1.defineProperty('minId', {
+      get: () => 1,
+      cache: false,
+    });
+
+    const caller2 = new FlowContext();
+    caller2.addDelegate(engine.context);
+    caller2.defineProperty('minId', {
+      get: () => 2,
+      cache: false,
+    });
+
+    expect(caller1.sql).not.toBe(caller2.sql);
+
+    await caller1.sql.run('SELECT * FROM users WHERE id > {{ctx.minId}}', { type: 'selectRows' });
+    await caller2.sql.run('SELECT * FROM users WHERE id > {{ctx.minId}}', { type: 'selectRows' });
+
+    expect(request).toHaveBeenCalledTimes(2);
+    const config1 = request.mock.calls[0]?.[0];
+    const config2 = request.mock.calls[1]?.[0];
+    expect(config1?.data.bind.__var1).toBe(1);
+    expect(config2?.data.bind.__var1).toBe(2);
+  });
+
+  it('engine.context.sql should keep working when accessed directly', async () => {
+    const engine = new FlowEngine();
+    const request = vi.fn(async () => ({ data: { data: [] } }));
+    engine.context.defineProperty('api', {
+      value: { request },
+    });
+    engine.context.defineProperty('minId', {
+      get: () => 3,
+      cache: false,
+    });
+
+    await engine.context.sql.run('SELECT * FROM users WHERE id > {{ctx.minId}}', { type: 'selectRows' });
+
+    expect(request).toHaveBeenCalledTimes(1);
+    const config = request.mock.calls[0]?.[0];
+    expect(config?.url).toBe('flowSql:run');
+    expect(config?.data.bind.__var1).toBe(3);
+  });
+
+  it('engine.context.getVar should resolve variable by path', async () => {
+    const engine = new FlowEngine();
+    engine.context.defineProperty('foo', { value: { bar: 1 } });
+
+    const v1 = await (engine.context as any).getVar('ctx.foo.bar');
+    expect(v1).toBe(1);
+
+    await expect((engine.context as any).getVar('{{ ctx.foo.bar }}')).rejects.toThrow();
+
+    await expect((engine.context as any).getVar('foo.bar')).rejects.toThrow();
+  });
+
   it('engine.context.runAction should resolve action from engine.getAction', async () => {
     const engine = new FlowEngine();
 
@@ -997,6 +1099,7 @@ describe('FlowContext delayed meta loading', () => {
       parentTitles: ['Delayed User'],
       disabled: false,
       disabledReason: undefined,
+      hidden: false,
       children: undefined,
     });
     expect(children[1]).toEqual({
@@ -1009,6 +1112,7 @@ describe('FlowContext delayed meta loading', () => {
       parentTitles: ['Delayed User'],
       disabled: false,
       disabledReason: undefined,
+      hidden: false,
       children: undefined,
     });
   });
@@ -1282,6 +1386,58 @@ describe('FlowContext resolveOnServer selective server resolution', () => {
     // server was called
     expect(api.request).toHaveBeenCalledTimes(1);
   });
+
+  it('skips server call when all vars require contextParams but none provided', async () => {
+    const engine = new FlowEngine();
+    const api = { request: vi.fn() } as any;
+    engine.context.defineProperty('api', { value: api });
+
+    engine.context.defineProperty('foo', {
+      value: { a: 1 },
+      resolveOnServer: true,
+      serverOnlyWhenContextParams: true,
+      meta: async () => ({
+        type: 'object',
+        title: 'Foo',
+        // no buildVariablesParams -> empty contextParams
+      }),
+    });
+
+    const tpl = { a: '{{ ctx.foo.a }}' } as any;
+    const out = await (engine.context as any).resolveJsonTemplate(tpl);
+    expect(out).toEqual({ a: 1 });
+    // skipped server, because all server vars (only foo) require contextParams but none present
+    expect(api.request).not.toHaveBeenCalled();
+  });
+
+  it('still calls server when at least one var has contextParams (even if others require contextParams but none)', async () => {
+    const engine = new FlowEngine();
+    const api = { request: vi.fn(async () => ({ data: { ok: true } })) } as any;
+    engine.context.defineProperty('api', { value: api });
+
+    // foo: requires contextParams but none will be provided
+    engine.context.defineProperty('foo', {
+      value: { a: 1 },
+      resolveOnServer: true,
+      serverOnlyWhenContextParams: true,
+      meta: async () => ({ type: 'object', title: 'Foo' }),
+    });
+
+    // user: provides contextParams via builder
+    engine.context.defineProperty('user', {
+      value: { id: 9 },
+      resolveOnServer: true,
+      meta: async () => ({
+        type: 'object',
+        title: 'User',
+        buildVariablesParams: () => ({ collection: 'users', filterByTk: 9, dataSourceKey: 'main' }),
+      }),
+    });
+
+    const tpl = { a: '{{ ctx.foo.a }}', u: '{{ ctx.user.id }}' } as any;
+    await (engine.context as any).resolveJsonTemplate(tpl);
+    expect(api.request).toHaveBeenCalledTimes(1);
+  });
 });
 
 describe('FlowContext.getPropertyOptions()', () => {
@@ -1369,6 +1525,7 @@ describe('FlowContext getPropertyMetaTree with value parameter', () => {
       parentTitles: undefined,
       disabled: false,
       disabledReason: undefined,
+      hidden: false,
       children: undefined,
     });
     expect(subTree[1]).toEqual({
@@ -1381,6 +1538,7 @@ describe('FlowContext getPropertyMetaTree with value parameter', () => {
       parentTitles: undefined,
       disabled: false,
       disabledReason: undefined,
+      hidden: false,
       children: undefined,
     });
   });
@@ -1566,6 +1724,7 @@ describe('FlowContext getPropertyMetaTree with value parameter', () => {
       parentTitles: ['User', 'User Profile'],
       disabled: false,
       disabledReason: undefined,
+      hidden: false,
       children: undefined,
     });
     expect(profileSubTree[1]).toEqual({
@@ -1578,6 +1737,7 @@ describe('FlowContext getPropertyMetaTree with value parameter', () => {
       parentTitles: ['User', 'User Profile'],
       disabled: false,
       disabledReason: undefined,
+      hidden: false,
       children: undefined,
     });
   });