@nocobase/client-v2 2.2.0-alpha.7 → 2.2.0-alpha.8

package/src/flow/components/filter/VariableFilterItem.tsx

@@ -62,6 +62,51 @@ async function buildCollectionLeftMetaTreeLocal(ctx: any): Promise<MetaTreeNode[
   return await resolve(subTree);
 }
 
+function buildCollectionFieldMetaNode(collection: any, path: string[]): MetaTreeNode | null {
+  if (!collection || !path.length) {
+    return null;
+  }
+
+  const normalizedPath = path[0] === 'collection' ? path.slice(1) : path;
+  if (!normalizedPath.length) {
+    return null;
+  }
+
+  const parentTitles: string[] = [];
+  let currentCollection = collection;
+  let currentNode: MetaTreeNode | null = null;
+
+  for (const segment of normalizedPath) {
+    const field =
+      currentCollection?.getField?.(segment) ??
+      currentCollection?.getFields?.()?.find?.((candidate: any) => candidate?.name === segment);
+    if (!field) {
+      return null;
+    }
+
+    const title = field.title || field.uiSchema?.title || field.name || segment;
+    currentNode = {
+      name: field.name || segment,
+      title,
+      type: field.type,
+      interface: field.interface,
+      uiSchema: field.uiSchema,
+      options: field.options,
+      paths: ['collection', ...normalizedPath.slice(0, parentTitles.length + 1)],
+      parentTitles: [...parentTitles],
+    } as MetaTreeNode;
+
+    if (field.targetCollection) {
+      parentTitles.push(title);
+      currentCollection = field.targetCollection;
+    } else {
+      currentCollection = null;
+    }
+  }
+
+  return currentNode;
+}
+
 export interface VariableFilterItemValue {
   path: string;
   operator: string;
@@ -75,6 +120,7 @@ export interface VariableFilterItemProps {
   /** 筛选条件值对象 */
   value: VariableFilterItemValue;
   model: FlowModel;
+  disabled?: boolean;
   /**
    * 是否启用右侧 VariableInput（变量或静态值二合一）。
    * 默认 false：保持原有行为，右侧仅静态输入组件。
@@ -265,11 +311,48 @@ function normalizeRightValueInput(input: unknown) {
   return input;
 }
 
+function findMetaTreeNodeByPath(metaTree: MetaTreeNode[], targetPath: string[]): MetaTreeNode | null {
+  if (!Array.isArray(metaTree) || !targetPath.length) {
+    return null;
+  }
+
+  const traverseByName = (nodes: MetaTreeNode[], path: string[]): MetaTreeNode | null => {
+    if (!path.length) {
+      return null;
+    }
+
+    const [head, ...rest] = path;
+    const matched = nodes.find((node) => String(node.name) === String(head));
+    if (!matched) {
+      return null;
+    }
+    if (!rest.length) {
+      return matched;
+    }
+    if (!Array.isArray(matched.children)) {
+      return null;
+    }
+    return traverseByName(matched.children as MetaTreeNode[], rest);
+  };
+
+  const byNames = traverseByName(metaTree, targetPath);
+  if (byNames) {
+    return byNames;
+  }
+
+  const topNames = new Set(metaTree.map((node) => String(node.name)));
+  if (!topNames.has(String(targetPath[0]))) {
+    return traverseByName(metaTree, targetPath.slice(1));
+  }
+
+  return null;
+}
+
 /**
  * 上下文筛选项组件
  */
 export const VariableFilterItem: React.FC<VariableFilterItemProps> = observer(
-  ({ value, model, rightAsVariable, rightMetaTree, ignoreFieldNames, maxAssociationFieldDepth }) => {
+  ({ value, model, disabled = false, rightAsVariable, rightMetaTree, ignoreFieldNames, maxAssociationFieldDepth }) => {
     // 使用 View 上下文，确保可访问 ctx.view 的异步子树
     const ctx = useFlowViewContext();
     const t = model.translate;
@@ -334,6 +417,9 @@ export const VariableFilterItem: React.FC<VariableFilterItemProps> = observer(
     // 处理左侧值变化（值由 converters 决定如何解析）
     const handleLeftChange = useCallback(
       (variableValue: string, meta?: MetaTreeNode) => {
+        if (disabled) {
+          return;
+        }
         const prevPath = value.path || '';
         const nextPath = variableValue || '';
         const changed = nextPath !== prevPath;
@@ -348,7 +434,7 @@ export const VariableFilterItem: React.FC<VariableFilterItemProps> = observer(
           setLeftMeta(meta);
         }
       },
-      [value],
+      [disabled, value],
     );
 
     // 自定义转换器来捕获 MetaTreeNode，并在选择左值时设置默认操作符
@@ -376,6 +462,9 @@ export const VariableFilterItem: React.FC<VariableFilterItemProps> = observer(
     // 处理操作符变化
     const handleOperatorChange = useCallback(
       (operatorValue: string) => {
+        if (disabled) {
+          return;
+        }
         value.operator = operatorValue;
         const cur = operatorMetaList.find((op) => op.value === operatorValue);
         if (cur?.noValue) {
@@ -386,7 +475,7 @@ export const VariableFilterItem: React.FC<VariableFilterItemProps> = observer(
           value.noValue = false;
         }
       },
-      [operatorMetaList, value],
+      [disabled, operatorMetaList, value],
     );
 
     // 使用公共静态输入渲染器（抽取到 utils）
@@ -464,9 +553,12 @@ export const VariableFilterItem: React.FC<VariableFilterItemProps> = observer(
 
     const setRightValue = useCallback(
       (next: unknown) => {
+        if (disabled) {
+          return;
+        }
         value.value = normalizeRightValueInput(next) as VariableFilterItemValue['value'];
       },
-      [value],
+      [disabled, value],
     );
 
     // 右侧静态输入（无变量模式）与右侧 VariableInput 的静态渲染组件，统一复用
@@ -520,6 +612,7 @@ export const VariableFilterItem: React.FC<VariableFilterItemProps> = observer(
               {...nextProps}
               style={{ width: '100%', ...pickStyle(nextProps.style) }}
               value={normalized}
+              disabled={disabled}
               onChange={(vals: any) => setRightValue(vals)}
             />
           </div>
@@ -529,10 +622,19 @@ export const VariableFilterItem: React.FC<VariableFilterItemProps> = observer(
       const Comp = staticInputRenderer;
       return (
         <div style={{ flex: '1 1 40%', minWidth: 160, maxWidth: '100%' }}>
-          <Comp value={rightValue} onChange={(val) => setRightValue(val)} />
+          <Comp value={rightValue} onChange={(val) => setRightValue(val)} disabled={disabled} />
         </div>
       );
-    }, [operator, operatorMetaList, rightValue, staticInputRenderer, model.context.app, setRightValue, enumOptions]);
+    }, [
+      disabled,
+      operator,
+      operatorMetaList,
+      rightValue,
+      staticInputRenderer,
+      model.context.app,
+      setRightValue,
+      enumOptions,
+    ]);
 
     // Null 占位组件（仿照 DefaultValue.tsx 的实现）
     const NullComponent = useMemo(() => {
@@ -652,6 +754,34 @@ export const VariableFilterItem: React.FC<VariableFilterItemProps> = observer(
       };
     }, [getFieldInterface, model, maxAssociationFieldDepth]);
 
+    useEffect(() => {
+      if (leftMeta || !value.path) {
+        return;
+      }
+
+      let cancelled = false;
+      const restore = async () => {
+        const nodes = await enhancedMetaTree();
+        if (cancelled) {
+          return;
+        }
+        const path = customConverters.resolvePathFromValue(value.path);
+        if (!path?.length) {
+          return;
+        }
+        const matched =
+          findMetaTreeNodeByPath(nodes, path) || buildCollectionFieldMetaNode(model.context.collection, path);
+        if (matched) {
+          setLeftMeta(matched);
+        }
+      };
+
+      restore();
+      return () => {
+        cancelled = true;
+      };
+    }, [customConverters, enhancedMetaTree, leftMeta, model.context.collection, value.path]);
+
     return (
       <Space wrap style={{ width: '100%' }}>
         <VariableInput
@@ -659,6 +789,7 @@ export const VariableFilterItem: React.FC<VariableFilterItemProps> = observer(
           metaTree={enhancedMetaTree}
           onChange={handleLeftChange}
           converters={customConverters}
+          disabled={disabled}
           showValueComponent={false}
           style={{ flex: '1 1 40%', minWidth: 160, maxWidth: '100%' }}
           onlyLeafSelectable={true}
@@ -670,6 +801,7 @@ export const VariableFilterItem: React.FC<VariableFilterItemProps> = observer(
           style={{ flex: '0 0 140px', minWidth: 120, maxWidth: '100%' }}
           placeholder={t('Comparison')}
           value={operator || undefined}
+          disabled={disabled}
           onChange={handleOperatorChange}
         >
           {operatorOptions.map((op) => (
@@ -686,6 +818,7 @@ export const VariableFilterItem: React.FC<VariableFilterItemProps> = observer(
               onChange={(v) => setRightValue(v)}
               metaTree={mergedRightMetaTree}
               converters={rightConverters}
+              disabled={disabled}
               showValueComponent
               style={{ flex: '1 1 40%', minWidth: 160, maxWidth: '100%' }}
               placeholder={t('Enter value')}

package/src/flow/components/filter/__tests__/FilterGroup.test.tsx

@@ -140,4 +140,49 @@ describe('FilterGroup closeIcon', () => {
     expect(onChange).toHaveBeenCalledTimes(1);
     expect(value.items[0].items).toHaveLength(1);
   });
+
+  it('disables close and add actions when the filter group is disabled', () => {
+    const value = {
+      logic: '$and',
+      items: [
+        {
+          path: 'name',
+          operator: 'eq',
+          value: 'test',
+        },
+      ],
+    };
+    const onRemove = vi.fn();
+    const onChange = vi.fn();
+
+    renderWithProviders(
+      <FilterGroup
+        value={value}
+        FilterItem={DummyFilterItem}
+        showBorder
+        onRemove={onRemove}
+        onChange={onChange}
+        disabled
+      />,
+    );
+
+    const closeButtons = screen
+      .getAllByLabelText('icon-close')
+      .map((element) => element.closest('button'))
+      .filter(Boolean) as HTMLButtonElement[];
+    expect(closeButtons).toHaveLength(2);
+    expect(closeButtons[0]).toBeDisabled();
+    expect(closeButtons[1]).toBeDisabled();
+    expect(screen.getByText('Add condition').closest('button')).toBeDisabled();
+    expect(screen.getByText('Add condition group').closest('button')).toBeDisabled();
+
+    fireEvent.click(closeButtons[0]);
+    fireEvent.click(closeButtons[1]);
+    fireEvent.click(screen.getByText('Add condition').closest('button') as HTMLButtonElement);
+    fireEvent.click(screen.getByText('Add condition group').closest('button') as HTMLButtonElement);
+
+    expect(onRemove).not.toHaveBeenCalled();
+    expect(onChange).not.toHaveBeenCalled();
+    expect(value.items).toHaveLength(1);
+  });
 });

package/src/flow/components/filter/__tests__/VariableFilterItem.leftMetaTree.test.tsx

@@ -193,4 +193,13 @@ describe('VariableFilterItem with leftMetaTree', () => {
     fireEvent.click(screen.getByTestId('variable-input'));
     expect(value.path).toBe('title');
   });
+
+  it('restores the saved left meta so the operator select shows its label on reopen', async () => {
+    const value = { path: 'title', operator: '$eq', value: 'x' } as any;
+    const model = createModelWithCollection();
+
+    render(<VariableFilterItem value={value} model={model} rightAsVariable={false} />);
+
+    expect(await screen.findByText('Equals')).toBeInTheDocument();
+  });
 });

package/src/flow/components/filter/__tests__/VariableFilterItem.test.tsx

@@ -158,6 +158,27 @@ describe('VariableFilterItem', () => {
     expect(value.value).toBe('abc');
   });
 
+  it('passes disabled through to the left selector, operator select, and right variable input', async () => {
+    const value: VariableFilterItemValue = { path: '', operator: '', value: '' };
+    const model = CreateModel();
+
+    render(<VariableFilterItem value={value} model={model} rightAsVariable disabled />);
+
+    const leftVariableInputProps = (globalThis as any).__LAST_VARIABLE_INPUT_PROPS__;
+    expect(leftVariableInputProps.disabled).toBe(true);
+
+    fireEvent.click(screen.getAllByTestId('variable-input')[0]);
+
+    const variableInputs = screen.getAllByTestId('variable-input');
+    expect(variableInputs.length).toBeGreaterThanOrEqual(2);
+    const rightVariableInputProps = (globalThis as any).__LAST_VARIABLE_INPUT_PROPS__;
+    expect(rightVariableInputProps.disabled).toBe(true);
+
+    const operatorSelect = document.body.querySelector('.ant-select') as HTMLDivElement | null;
+    expect(operatorSelect).not.toBeNull();
+    expect(operatorSelect).toHaveClass('ant-select-disabled');
+  });
+
   it('uses scoped context dataSourceManager when app dataSourceManager has no field interface manager', async () => {
     const value = observable({ path: '', operator: '', value: '' }) as any;
     const model = CreateModel();

package/src/flow/models/blocks/table/TableActionsColumnModel.tsx

@@ -121,10 +121,11 @@ const Columns = observer<any>(({ record, model, index }) => {
           fork.context.defineProperty('recordIndex', {
             get: () => index,
           });
+          const rendererKey = `${fork.uid}:${fork.forkId}`;
           const renderer = (
             <FlowModelRenderer
               showFlowSettings={{ showBorder: false, toolbarPosition: 'above' }}
-              key={fork.uid}
+              key={rendererKey}
               model={fork}
               inputArgs={record}
               fallback={<Skeleton.Button size="small" />}

package/src/flow/models/fields/VariableFieldFormModel.tsx

@@ -48,12 +48,12 @@ export class VariableFieldFormModel extends FlowModel {
       <FormProvider form={this.form}>
         <FormLayout layout={'vertical'}>
           {this.mapSubModels('fields', (field) => {
-            // 确保字段模型具备稳定的 id/name，便于依赖路径的组件（如公式字段）正确解析
+            // Avoid conflicting with the DOM nodeName property when rendering the temporary input.
             const init = field?.getStepParams?.('fieldSettings', 'init') || {};
             const fp = init?.fieldPath as string | undefined;
             if (fp) {
-              const namePath = fp.includes('.') ? fp.split('.') : [fp];
-              const toSet: any = {};
+              const namePath = (fp === 'nodeName' ? '__nb_variable_field_nodeName' : fp).split('.');
+              const toSet: Record<string, unknown> = {};
               if (!field?.props?.id) toSet.id = namePath;
               if (!field?.props?.name) toSet.name = namePath;
               if (Object.keys(toSet).length) field?.setProps?.(toSet);

package/src/flow/models/fields/__tests__/VariableFieldFormModel.test.tsx

@@ -0,0 +1,51 @@
+/**
+ * This file is part of the NocoBase (R) project.
+ * Copyright (c) 2020-2024 NocoBase Co., Ltd.
+ * Authors: NocoBase Team.
+ *
+ * This project is dual-licensed under AGPL-3.0 and NocoBase Commercial License.
+ * For more information, please refer to: https://www.nocobase.com/agreement.
+ */
+
+import { FlowEngine, FlowEngineProvider } from '@nocobase/flow-engine';
+import { render, screen, waitFor } from '@testing-library/react';
+import React from 'react';
+import { describe, expect, it } from 'vitest';
+import { InputFieldModel } from '../InputFieldModel';
+import { VariableFieldFormModel } from '../VariableFieldFormModel';
+
+describe('VariableFieldFormModel', () => {
+  it('uses DOM-safe name and id for temporary controls created from reserved form property names', async () => {
+    const engine = new FlowEngine();
+    engine.registerModels({ InputFieldModel, VariableFieldFormModel });
+    const model = engine.createModel<VariableFieldFormModel>({
+      use: 'VariableFieldFormModel',
+      subModels: {
+        fields: [
+          {
+            use: 'InputFieldModel',
+            stepParams: {
+              fieldSettings: {
+                init: {
+                  fieldPath: 'nodeName',
+                },
+              },
+            },
+          },
+        ],
+      },
+    });
+    const field = model.subModels.fields[0];
+
+    render(<FlowEngineProvider engine={engine}>{model.render()}</FlowEngineProvider>);
+
+    const input = await screen.findByRole('textbox');
+    await waitFor(() => {
+      expect(field.props.name).toEqual(['__nb_variable_field_nodeName']);
+    });
+    expect(input).toHaveAttribute('name', '__nb_variable_field_nodeName');
+    expect(input).toHaveAttribute('id', '__nb_variable_field_nodeName');
+    expect(field.props.id).toEqual(['__nb_variable_field_nodeName']);
+    expect(field.getStepParams('fieldSettings', 'init')).toEqual({ fieldPath: 'nodeName' });
+  });
+});