@nocobase/client-v2 2.1.0-beta.30 → 2.1.0-beta.33

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (101) hide show
  1. package/es/BaseApplication.d.ts +1 -0
  2. package/es/PluginManager.d.ts +1 -0
  3. package/es/components/form/DrawerFormLayout.d.ts +49 -0
  4. package/es/components/form/EnvVariableInput.d.ts +42 -0
  5. package/es/components/form/FileSizeInput.d.ts +27 -0
  6. package/es/components/form/createFormRegistry.d.ts +33 -0
  7. package/es/components/form/index.d.ts +13 -0
  8. package/es/components/index.d.ts +1 -1
  9. package/es/flow/components/FieldAssignRulesEditor.d.ts +1 -0
  10. package/es/flow/components/code-editor/index.d.ts +1 -0
  11. package/es/flow/internal/utils/enumOptionsUtils.d.ts +5 -0
  12. package/es/flow/models/actions/AssociationActionUtils.d.ts +5 -0
  13. package/es/flow/models/blocks/filter-form/FilterFormBlockModel.d.ts +4 -0
  14. package/es/flow/models/blocks/filter-manager/FilterManager.d.ts +5 -1
  15. package/es/flow/models/blocks/shared/legacyDefaultValueMigrationBase.d.ts +1 -0
  16. package/es/flow/models/blocks/table/TableSelectModel.d.ts +8 -0
  17. package/es/flow/models/fields/AssociationFieldModel/SubTableFieldModel/SubTableColumnModel.d.ts +4 -0
  18. package/es/flow/models/fields/ClickableFieldModel.d.ts +3 -0
  19. package/es/flow/models/fields/DisplayEnumFieldModel.d.ts +6 -0
  20. package/es/flow/models/fields/DisplayTitleFieldModel.d.ts +2 -2
  21. package/es/flow/models/utils/displayValueUtils.d.ts +12 -0
  22. package/es/flow-compat/passwordUtils.d.ts +1 -1
  23. package/es/index.mjs +119 -108
  24. package/es/utils/remotePlugins.d.ts +0 -4
  25. package/lib/index.js +122 -111
  26. package/package.json +9 -5
  27. package/src/BaseApplication.tsx +14 -8
  28. package/src/PluginManager.ts +1 -0
  29. package/src/__tests__/app.test.tsx +28 -1
  30. package/src/__tests__/globalDeps.test.ts +1 -0
  31. package/src/__tests__/remotePlugins.test.ts +29 -18
  32. package/src/components/form/DrawerFormLayout.tsx +103 -0
  33. package/src/components/form/EnvVariableInput.tsx +126 -0
  34. package/src/components/form/FileSizeInput.tsx +105 -0
  35. package/src/components/form/createFormRegistry.ts +60 -0
  36. package/src/components/form/index.tsx +14 -0
  37. package/src/components/index.ts +1 -1
  38. package/src/flow/actions/__tests__/dataScopeFilter.test.ts +92 -13
  39. package/src/flow/actions/__tests__/formAssignRules.legacyMigration.test.tsx +173 -0
  40. package/src/flow/actions/__tests__/linkageRules.subFormSetFieldProps.test.ts +476 -1
  41. package/src/flow/actions/__tests__/pattern.test.ts +134 -0
  42. package/src/flow/actions/__tests__/titleField.test.ts +45 -0
  43. package/src/flow/actions/filterFormDefaultValues.tsx +30 -9
  44. package/src/flow/actions/formAssignRules.tsx +24 -9
  45. package/src/flow/actions/linkageRules.tsx +240 -258
  46. package/src/flow/actions/pattern.tsx +41 -6
  47. package/src/flow/actions/setTargetDataScope.tsx +32 -3
  48. package/src/flow/actions/titleField.tsx +4 -2
  49. package/src/flow/actions/validation.tsx +1 -1
  50. package/src/flow/admin-shell/admin-layout/AdminLayoutMenuModels.tsx +0 -4
  51. package/src/flow/admin-shell/admin-layout/__tests__/AdminLayoutMenuModels.test.ts +13 -5
  52. package/src/flow/components/DynamicFlowsIcon.tsx +87 -13
  53. package/src/flow/components/FieldAssignRulesEditor.tsx +2 -0
  54. package/src/flow/components/__tests__/DynamicFlowsIcon.test.tsx +195 -8
  55. package/src/flow/components/__tests__/FieldAssignRulesEditor.test.tsx +81 -4
  56. package/src/flow/components/code-editor/index.tsx +12 -8
  57. package/src/flow/components/filter/LinkageFilterItem.tsx +9 -2
  58. package/src/flow/components/filter/VariableFilterItem.tsx +2 -6
  59. package/src/flow/components/filter/__tests__/LinkageFilterItem.test.tsx +71 -0
  60. package/src/flow/components/filter/__tests__/VariableFilterItem.test.tsx +48 -0
  61. package/src/flow/internal/utils/__tests__/enumOptionsUtils.test.ts +10 -1
  62. package/src/flow/internal/utils/enumOptionsUtils.ts +29 -0
  63. package/src/flow/models/actions/AssociateActionModel.tsx +2 -2
  64. package/src/flow/models/actions/AssociationActionUtils.ts +14 -0
  65. package/src/flow/models/actions/__tests__/AssociationActionModel.test.ts +63 -0
  66. package/src/flow/models/base/CollectionBlockModel.tsx +7 -0
  67. package/src/flow/models/base/PageModel/RootPageModel.tsx +1 -1
  68. package/src/flow/models/blocks/filter-form/FilterFormBlockModel.tsx +33 -9
  69. package/src/flow/models/blocks/filter-form/FilterFormItemModel.tsx +53 -13
  70. package/src/flow/models/blocks/filter-form/__tests__/FilterFormItemModel.getFilterValue.test.ts +63 -3
  71. package/src/flow/models/blocks/filter-form/__tests__/defaultValues.wiring.test.ts +33 -1
  72. package/src/flow/models/blocks/filter-form/__tests__/legacyDefaultValueMigration.test.ts +3 -0
  73. package/src/flow/models/blocks/filter-manager/FilterManager.ts +66 -2
  74. package/src/flow/models/blocks/filter-manager/__tests__/FilterManager.test.ts +270 -0
  75. package/src/flow/models/blocks/form/FormActionModel.tsx +2 -8
  76. package/src/flow/models/blocks/form/FormBlockModel.tsx +8 -5
  77. package/src/flow/models/blocks/form/FormItemModel.tsx +1 -1
  78. package/src/flow/models/blocks/form/__tests__/FormBlockModel.test.tsx +30 -0
  79. package/src/flow/models/blocks/form/__tests__/legacyDefaultValueMigration.test.ts +3 -0
  80. package/src/flow/models/blocks/form/value-runtime/rules.ts +6 -1
  81. package/src/flow/models/blocks/form/value-runtime/runtime.ts +6 -1
  82. package/src/flow/models/blocks/shared/legacyDefaultValueMigrationBase.ts +21 -5
  83. package/src/flow/models/blocks/table/TableBlockModel.tsx +11 -6
  84. package/src/flow/models/blocks/table/TableColumnModel.tsx +8 -2
  85. package/src/flow/models/blocks/table/TableSelectModel.tsx +36 -26
  86. package/src/flow/models/blocks/table/__tests__/TableBlockModel.rowClick.test.ts +69 -0
  87. package/src/flow/models/blocks/table/__tests__/TableColumnModel.test.tsx +132 -1
  88. package/src/flow/models/blocks/table/__tests__/TableSelectModel.test.ts +41 -0
  89. package/src/flow/models/fields/AssociationFieldModel/SubTableFieldModel/SubTableColumnModel.tsx +144 -3
  90. package/src/flow/models/fields/AssociationFieldModel/SubTableFieldModel/__tests__/SubTableColumnModel.rowRecord.test.ts +170 -1
  91. package/src/flow/models/fields/ClickableFieldModel.tsx +55 -6
  92. package/src/flow/models/fields/DisplayEnumFieldModel.tsx +44 -0
  93. package/src/flow/models/fields/DisplayTitleFieldModel.tsx +40 -7
  94. package/src/flow/models/fields/SelectFieldModel.tsx +31 -1
  95. package/src/flow/models/fields/__tests__/ClickableFieldModel.test.ts +202 -1
  96. package/src/flow/models/fields/__tests__/DisplayEnumFieldModel.test.tsx +39 -0
  97. package/src/flow/models/fields/mobile-components/MobileSelect.tsx +2 -1
  98. package/src/flow/models/fields/mobile-components/__tests__/MobileSelect.test.tsx +7 -0
  99. package/src/flow/models/utils/displayValueUtils.ts +57 -0
  100. package/src/utils/globalDeps.ts +11 -0
  101. package/src/utils/remotePlugins.ts +7 -27
@@ -10,6 +10,7 @@
10
10
  import {
11
11
  ActionScene,
12
12
  defineAction,
13
+ extractUsedVariablePaths,
13
14
  FlowModel,
14
15
  MultiRecordResource,
15
16
  useFlowContext,
@@ -20,6 +21,34 @@ import React from 'react';
20
21
  import { FilterGroup, VariableFilterItem } from '../components/filter';
21
22
  import { normalizeDataScopeFilter } from './dataScopeFilter';
22
23
 
24
+ function dependsOnClickedRowRecord(filter: any) {
25
+ if (!filter) {
26
+ return false;
27
+ }
28
+ const used = extractUsedVariablePaths(filter) || {};
29
+ return Object.prototype.hasOwnProperty.call(used, 'clickedRowRecord');
30
+ }
31
+
32
+ function shouldClearClickedRowDataScope(ctx: any, params: any) {
33
+ return ctx.inputArgs?.selected === false && dependsOnClickedRowRecord(params.filter);
34
+ }
35
+
36
+ function resolveTargetDataScopeFilter(ctx: any, params: any, resolvedParams: any) {
37
+ if (shouldClearClickedRowDataScope(ctx, params)) {
38
+ return undefined;
39
+ }
40
+
41
+ return normalizeDataScopeFilter(params.filter, resolvedParams.filter);
42
+ }
43
+
44
+ function shouldRefreshTargetResource(resource: MultiRecordResource) {
45
+ if (resource.hasData()) {
46
+ return true;
47
+ }
48
+
49
+ return resource.getMeta?.('count') !== undefined || resource.getMeta?.('hasNext') !== undefined;
50
+ }
51
+
23
52
  export const setTargetDataScope = defineAction({
24
53
  name: 'setTargetDataScope',
25
54
  title: tExpr('Set data scope'),
@@ -69,20 +98,20 @@ export const setTargetDataScope = defineAction({
69
98
  return;
70
99
  }
71
100
  const model: FlowModel = ctx.model;
101
+ const filter = resolveTargetDataScopeFilter(ctx, params, resolvedParams);
102
+
72
103
  model.scheduleModelOperation(targetBlockUid, (targetModel) => {
73
104
  const resource = targetModel['resource'] as MultiRecordResource;
74
105
  if (!resource) {
75
106
  return;
76
107
  }
77
108
 
78
- const filter = normalizeDataScopeFilter(params.filter, resolvedParams.filter);
79
-
80
109
  if (isEmptyFilter(filter)) {
81
110
  resource.removeFilterGroup(`setTargetDataScope_${ctx.model.uid}`);
82
111
  } else {
83
112
  resource.addFilterGroup(`setTargetDataScope_${ctx.model.uid}`, filter);
84
113
  }
85
- if (resource.hasData()) {
114
+ if (shouldRefreshTargetResource(resource)) {
86
115
  resource.refresh();
87
116
  }
88
117
  });
@@ -43,7 +43,9 @@ export const titleField = defineAction({
43
43
  const options = targetFields
44
44
  .filter((field) =>
45
45
  isTitleFieldInterface(
46
- getFlowFieldInterfaceOptions(field.options?.interface || field.interface, dataSourceManager),
46
+ typeof field.getInterfaceOptions === 'function'
47
+ ? field.getInterfaceOptions()
48
+ : getFlowFieldInterfaceOptions(field.options?.interface || field.interface, dataSourceManager),
47
49
  ),
48
50
  )
49
51
  .map((field) => ({
@@ -59,7 +61,7 @@ export const titleField = defineAction({
59
61
  };
60
62
  },
61
63
  defaultParams: (ctx: any) => {
62
- const titleField = ctx.model.context.collectionField.targetCollectionTitleFieldName;
64
+ const titleField = ctx.model?.context?.collectionField?.targetCollectionTitleFieldName;
63
65
  return {
64
66
  label: ctx.model.parent?.props?.titleField || ctx.model.props.titleField || titleField,
65
67
  };
@@ -18,7 +18,7 @@ export const validation = defineAction({
18
18
  return;
19
19
  }
20
20
  const targetInterface = ctx.model.collectionField.getInterfaceOptions();
21
- if (!targetInterface.validationType) {
21
+ if (!targetInterface?.validationType) {
22
22
  return null;
23
23
  }
24
24
  return {
@@ -628,10 +628,6 @@ export class AdminLayoutMenuItemModel extends FlowModel<AdminLayoutMenuItemStruc
628
628
  )
629
629
  .filter(Boolean) || [];
630
630
 
631
- if (isV2AdminRuntime(this.context.app) && children.length === 0) {
632
- return null;
633
- }
634
-
635
631
  if (options.designable && depth === 0) {
636
632
  children.push(getAdminLayoutMenuInitializerButton('schema-initializer-Menu-side', this, route));
637
633
  }
@@ -311,7 +311,7 @@ describe('AdminLayoutModel menu items', () => {
311
311
  expect(route.children[1]._model).toBe(adminLayoutModel.subModels.menuItems?.[1]);
312
312
  });
313
313
 
314
- it('should filter legacy page menu routes in v2 admin layout', () => {
314
+ it('should filter legacy page menu routes but keep empty groups in v2 admin layout', () => {
315
315
  const adminLayoutModel = engine.createModel<AdminLayoutModel>({
316
316
  uid: 'admin-layout-model',
317
317
  use: AdminLayoutModel,
@@ -369,22 +369,30 @@ describe('AdminLayoutModel menu items', () => {
369
369
  t: (title) => title,
370
370
  });
371
371
 
372
- expect(route.children).toHaveLength(2);
372
+ expect(route.children).toHaveLength(3);
373
373
  expect(route.children[0]).toMatchObject({
374
+ path: '/admin/2',
375
+ redirect: '/admin/2',
376
+ _runtimePath: null,
377
+ _navigationMode: 'spa',
378
+ _isLegacy: false,
379
+ });
380
+ expect(route.children[0].routes).toBeUndefined();
381
+ expect(route.children[1]).toMatchObject({
374
382
  path: '/admin/3',
375
383
  redirect: '/admin/nested-flow-page',
376
384
  _runtimePath: '/apps/demo/v2/admin/nested-flow-page',
377
385
  _navigationMode: 'spa',
378
386
  _isLegacy: false,
379
387
  });
380
- expect(route.children[0].routes).toHaveLength(1);
381
- expect(route.children[0].routes?.[0]).toMatchObject({
388
+ expect(route.children[1].routes).toHaveLength(1);
389
+ expect(route.children[1].routes?.[0]).toMatchObject({
382
390
  path: '/admin/nested-flow-page',
383
391
  _runtimePath: '/apps/demo/v2/admin/nested-flow-page',
384
392
  _navigationMode: 'spa',
385
393
  _isLegacy: false,
386
394
  });
387
- expect(route.children[1]).toMatchObject({
395
+ expect(route.children[2]).toMatchObject({
388
396
  path: '/admin/__admin_layout__/link/4',
389
397
  });
390
398
  });
@@ -28,6 +28,9 @@ import {
28
28
  GLOBAL_EMBED_CONTAINER_ID,
29
29
  EMBED_REPLACING_DATA_KEY,
30
30
  shouldHideEventInSettings,
31
+ DetachedFlowRegistry,
32
+ replaceFlowRegistry,
33
+ serializeFlowRegistry,
31
34
  } from '@nocobase/flow-engine';
32
35
  import { Collapse, Input, Button, Space, Tooltip, Empty, Dropdown, Select } from 'antd';
33
36
  import { uid } from '@formily/shared';
@@ -35,6 +38,9 @@ import { useUpdate } from 'ahooks';
35
38
  import _ from 'lodash';
36
39
 
37
40
  type FlowOnObject = Exclude<FlowDefinition['on'], string | undefined>;
41
+ type FlowRegistryAvailability = {
42
+ hasFlow(flowKey: string): boolean;
43
+ };
38
44
 
39
45
  function isFlowOnObject(on: FlowDefinition['on']): on is FlowOnObject {
40
46
  return !!on && typeof on === 'object';
@@ -93,7 +99,7 @@ function validateFlowOnPhase(onObj: FlowOnObject): 'flowKey' | 'stepKey' | undef
93
99
 
94
100
  export const DynamicFlowsIcon: React.FC<{ model: FlowModel }> = (props) => {
95
101
  const { model } = props;
96
- const t = model.translate.bind(model);
102
+ const t = React.useMemo(() => model.translate.bind(model), [model]);
97
103
 
98
104
  const handleClick = () => {
99
105
  const target = document.querySelector<HTMLDivElement>(`#${GLOBAL_EMBED_CONTAINER_ID}`);
@@ -190,7 +196,17 @@ const FieldLabel = ({
190
196
 
191
197
  // 事件配置组件 - 独立的 observer 组件确保响应式更新
192
198
  const EventConfigSection = observer(
193
- ({ flow, model, flowEngine }: { flow: FlowDefinition; model: FlowModel; flowEngine: any }) => {
199
+ ({
200
+ flow,
201
+ model,
202
+ flowEngine,
203
+ flowRegistry,
204
+ }: {
205
+ flow: FlowDefinition;
206
+ model: FlowModel;
207
+ flowEngine: any;
208
+ flowRegistry: FlowRegistryAvailability;
209
+ }) => {
194
210
  const ctx = useFlowContext<FlowEngineContext>();
195
211
  const t = model.translate.bind(model);
196
212
  const refresh = useUpdate();
@@ -270,9 +286,9 @@ const EventConfigSection = observer(
270
286
  return staticFlows.map((f) => ({
271
287
  value: f.key,
272
288
  label: formatKeyWithTitle(String(f.key), f.title),
273
- disabled: model.flowRegistry.hasFlow(f.key),
289
+ disabled: flowRegistry.hasFlow(f.key),
274
290
  }));
275
- }, [formatKeyWithTitle, model.flowRegistry, staticFlows]);
291
+ }, [flowRegistry, formatKeyWithTitle, staticFlows]);
276
292
 
277
293
  const stepOptions = React.useMemo(() => {
278
294
  if (!flowKeyValue) return [];
@@ -446,12 +462,58 @@ const DynamicFlowsEditor = observer((props: { model: FlowModel }) => {
446
462
  const { model } = props;
447
463
  const ctx = useFlowContext<FlowEngineContext>();
448
464
  const flowEngine = model.flowEngine;
465
+ const latestFlows = serializeFlowRegistry(model.flowRegistry);
466
+ const initialFlowsRef = React.useRef(latestFlows);
467
+ const [draftFlowRegistry] = React.useState(() => new DetachedFlowRegistry(latestFlows));
449
468
  const [submitLoading, setSubmitLoading] = React.useState(false);
450
- const t = model.translate.bind(model);
469
+ const t = React.useMemo(() => model.translate.bind(model), [model]);
470
+ const hasUnsavedChanges = React.useCallback(() => {
471
+ return !_.isEqual(initialFlowsRef.current, serializeFlowRegistry(draftFlowRegistry));
472
+ }, [draftFlowRegistry]);
473
+
474
+ React.useEffect(() => {
475
+ if (_.isEqual(initialFlowsRef.current, latestFlows) || hasUnsavedChanges()) {
476
+ return;
477
+ }
478
+
479
+ replaceFlowRegistry(draftFlowRegistry, latestFlows);
480
+ initialFlowsRef.current = latestFlows;
481
+ }, [draftFlowRegistry, hasUnsavedChanges, latestFlows]);
482
+
483
+ React.useEffect(() => {
484
+ const view = ctx.view;
485
+ const previousBeforeClose = view.beforeClose;
486
+ const beforeClose = async (payload) => {
487
+ if (hasUnsavedChanges()) {
488
+ const confirmed =
489
+ (await ctx.modal?.confirm?.({
490
+ title: t('Unsaved changes'),
491
+ content: t("Are you sure you don't want to save?"),
492
+ okText: t('Confirm'),
493
+ cancelText: t('Cancel'),
494
+ })) ?? true;
495
+
496
+ if (!confirmed) {
497
+ return false;
498
+ }
499
+ }
500
+
501
+ const result = await previousBeforeClose?.(payload);
502
+ return result !== false;
503
+ };
504
+
505
+ view.beforeClose = beforeClose;
506
+
507
+ return () => {
508
+ if (view.beforeClose === beforeClose) {
509
+ view.beforeClose = previousBeforeClose;
510
+ }
511
+ };
512
+ }, [ctx, hasUnsavedChanges, t]);
451
513
 
452
514
  // 添加新流
453
515
  const handleAddFlow = () => {
454
- model.flowRegistry.addFlow(uid(), {
516
+ draftFlowRegistry.addFlow(uid(), {
455
517
  title: t('Event flow'),
456
518
  steps: {},
457
519
  });
@@ -516,7 +578,7 @@ const DynamicFlowsEditor = observer((props: { model: FlowModel }) => {
516
578
  );
517
579
 
518
580
  // 生成折叠面板项
519
- const collapseItems = model.flowRegistry.mapFlows((flow) => {
581
+ const collapseItems = draftFlowRegistry.mapFlows((flow) => {
520
582
  return {
521
583
  key: flow.key,
522
584
  label: renderPanelHeader(flow),
@@ -529,7 +591,7 @@ const DynamicFlowsEditor = observer((props: { model: FlowModel }) => {
529
591
  children: (
530
592
  <div>
531
593
  {/* 事件部分 */}
532
- <EventConfigSection flow={flow} model={model} flowEngine={flowEngine} />
594
+ <EventConfigSection flow={flow} model={model} flowEngine={flowEngine} flowRegistry={draftFlowRegistry} />
533
595
 
534
596
  {/* 步骤部分 */}
535
597
  <div>
@@ -670,13 +732,13 @@ const DynamicFlowsEditor = observer((props: { model: FlowModel }) => {
670
732
  flexShrink: 0,
671
733
  }}
672
734
  >
673
- <Button onClick={() => ctx.view.destroy()}>{t('Cancel')}</Button>
735
+ <Button onClick={() => ctx.view.close()}>{t('Cancel')}</Button>
674
736
  <Button
675
737
  type="primary"
676
738
  loading={submitLoading}
677
739
  onClick={async () => {
678
740
  setSubmitLoading(true);
679
- const invalid = model.flowRegistry
741
+ const invalid = draftFlowRegistry
680
742
  .mapFlows((flow) => {
681
743
  if (!isFlowOnObject(flow.on)) return;
682
744
  normalizeFlowOnPhase(flow.on);
@@ -695,10 +757,11 @@ const DynamicFlowsEditor = observer((props: { model: FlowModel }) => {
695
757
  setSubmitLoading(false);
696
758
  return;
697
759
  }
698
- try {
699
- const afterSaves: Array<() => Promise<void>> = [];
760
+ const previousFlows = serializeFlowRegistry(model.flowRegistry);
761
+ const afterSaves: Array<() => Promise<void>> = [];
700
762
 
701
- for (const flow of model.flowRegistry.mapFlows((it) => it)) {
763
+ try {
764
+ for (const flow of draftFlowRegistry.mapFlows((it) => it)) {
702
765
  for (const step of flow.mapSteps((it) => it)) {
703
766
  const serialized = step.serialize();
704
767
  const actionDef = step.use ? model.getAction(step.use) : undefined;
@@ -731,8 +794,19 @@ const DynamicFlowsEditor = observer((props: { model: FlowModel }) => {
731
794
  }
732
795
  }
733
796
 
797
+ replaceFlowRegistry(model.flowRegistry, serializeFlowRegistry(draftFlowRegistry));
734
798
  await model.flowRegistry.save();
799
+ } catch (error) {
800
+ replaceFlowRegistry(model.flowRegistry, previousFlows);
801
+ setSubmitLoading(false);
802
+ model.context?.message?.error?.('Steps post-save hooks failed to run');
803
+ console.error(error);
804
+ return;
805
+ }
735
806
 
807
+ initialFlowsRef.current = serializeFlowRegistry(model.flowRegistry);
808
+
809
+ try {
736
810
  for (const runAfterSave of afterSaves) {
737
811
  await runAfterSave();
738
812
  }
@@ -35,6 +35,7 @@ type CollectionFieldLike = {
35
35
  title?: unknown;
36
36
  type?: unknown;
37
37
  interface?: unknown;
38
+ uiSchema?: unknown;
38
39
  targetKey?: unknown;
39
40
  targetCollectionTitleFieldName?: unknown;
40
41
  targetCollection?: any;
@@ -194,6 +195,7 @@ export const FieldAssignRulesEditor: React.FC<FieldAssignRulesEditorProps> = (pr
194
195
  title,
195
196
  type: String(f.type || 'string'),
196
197
  interface: fieldInterface,
198
+ uiSchema: (f as any).uiSchema,
197
199
  paths: [...basePaths, name],
198
200
  };
199
201
 
@@ -10,7 +10,7 @@
10
10
  import React from 'react';
11
11
  import { beforeEach, describe, expect, it, vi } from 'vitest';
12
12
  import { render, screen, userEvent, waitFor } from '@nocobase/test/client';
13
- import { FlowEngine, FlowModel, GLOBAL_EMBED_CONTAINER_ID } from '@nocobase/flow-engine';
13
+ import { ActionScene, FlowEngine, FlowModel, GLOBAL_EMBED_CONTAINER_ID } from '@nocobase/flow-engine';
14
14
  import { DynamicFlowsIcon } from '../DynamicFlowsIcon';
15
15
 
16
16
  const mockState = vi.hoisted(() => ({
@@ -30,15 +30,31 @@ vi.mock('antd', async (importOriginal) => {
30
30
  const actual = await importOriginal<typeof import('antd')>();
31
31
  return {
32
32
  ...actual,
33
- Button: ({ children, onClick, ...props }: any) => (
33
+ Button: ({ children, onClick, icon: _icon, loading: _loading, ...props }: any) => (
34
34
  <button type="button" onClick={onClick} {...props}>
35
35
  {children}
36
36
  </button>
37
37
  ),
38
38
  Collapse: ({ items }: any) => (
39
- <div data-testid="collapse">{items?.map((item: any) => <div key={item.key}>{item.children}</div>)}</div>
39
+ <div data-testid="collapse">
40
+ {items?.map((item: any) => (
41
+ <div key={item.key}>
42
+ {item.label}
43
+ {item.children}
44
+ </div>
45
+ ))}
46
+ </div>
47
+ ),
48
+ Dropdown: ({ children, menu }: any) => (
49
+ <div>
50
+ {children}
51
+ {menu?.items?.map((item: any) => (
52
+ <button key={item.key} type="button" onClick={item.onClick}>
53
+ {item.label}
54
+ </button>
55
+ ))}
56
+ </div>
40
57
  ),
41
- Dropdown: ({ children }: any) => <div>{children}</div>,
42
58
  Empty: ({ description }: any) => <div>{description}</div>,
43
59
  Input: (props: any) => <input {...props} />,
44
60
  Select: (props: any) => {
@@ -70,10 +86,16 @@ const openDynamicFlowsEditor = async (model: FlowModel) => {
70
86
  const embedCall = (model.context.viewer.embed as any).mock.calls.at(-1)?.[0];
71
87
  expect(embedCall?.content).toBeTruthy();
72
88
 
73
- render(embedCall.content);
89
+ const editor = render(embedCall.content);
90
+
91
+ return {
92
+ embedCall,
93
+ view: mockState.flowContextValue.view,
94
+ editor,
95
+ };
74
96
  };
75
97
 
76
- const createModel = (options: { preventClose?: boolean; hiddenClose?: boolean } = {}) => {
98
+ const createModel = (options: { preventClose?: boolean; hiddenClose?: boolean; saveStepParams?: any } = {}) => {
77
99
  const engine = new FlowEngine();
78
100
  engine.translate = vi.fn((key: string) => key) as any;
79
101
  engine.flowSettings.renderStepForm = vi.fn(() => null) as any;
@@ -95,6 +117,14 @@ const createModel = (options: { preventClose?: boolean; hiddenClose?: boolean }
95
117
  handler: vi.fn(),
96
118
  },
97
119
  });
120
+ LocalTestModel.registerActions({
121
+ notify: {
122
+ name: 'notify',
123
+ title: 'Notify',
124
+ scene: ActionScene.DYNAMIC_EVENT_FLOW,
125
+ handler: vi.fn(),
126
+ },
127
+ });
98
128
 
99
129
  const model = new LocalTestModel({
100
130
  uid: `test-model-${Math.random().toString(36).slice(2, 8)}`,
@@ -122,17 +152,55 @@ const createModel = (options: { preventClose?: boolean; hiddenClose?: boolean }
122
152
  destroy: vi.fn(),
123
153
  },
124
154
  });
155
+ model.context.defineProperty('message', {
156
+ value: {
157
+ error: vi.fn(),
158
+ success: vi.fn(),
159
+ },
160
+ });
161
+ vi.spyOn(model, 'saveStepParams').mockImplementation(options.saveStepParams || vi.fn(async () => undefined));
125
162
 
126
163
  return model;
127
164
  };
128
165
 
166
+ const createView = () => {
167
+ let destroyed = false;
168
+ let closingPromise: Promise<boolean | void> | undefined;
169
+ const view = {
170
+ close: vi.fn(function () {
171
+ if (destroyed) {
172
+ return Promise.resolve(true);
173
+ }
174
+ if (closingPromise) {
175
+ return closingPromise;
176
+ }
177
+ closingPromise = (async () => {
178
+ const allowed = await view.beforeClose?.({});
179
+ if (allowed === false) {
180
+ closingPromise = undefined;
181
+ return false;
182
+ }
183
+ view.destroy();
184
+ return true;
185
+ })();
186
+ return closingPromise;
187
+ }),
188
+ destroy: vi.fn(() => {
189
+ destroyed = true;
190
+ }),
191
+ beforeClose: undefined as any,
192
+ };
193
+ return view;
194
+ };
195
+
129
196
  describe('DynamicFlowsIcon', () => {
130
197
  beforeEach(() => {
131
198
  mockState.capturedSelectProps.length = 0;
132
199
  mockState.flowContextValue = {
133
- view: {
134
- destroy: vi.fn(),
200
+ modal: {
201
+ confirm: vi.fn(),
135
202
  },
203
+ view: createView(),
136
204
  };
137
205
  document.body.innerHTML = `<div id="${GLOBAL_EMBED_CONTAINER_ID}"></div>`;
138
206
  });
@@ -190,4 +258,123 @@ describe('DynamicFlowsIcon', () => {
190
258
  expect(screen.getByTestId('collapse')).toBeInTheDocument();
191
259
  });
192
260
  });
261
+
262
+ it('keeps added event flows in draft until saved', async () => {
263
+ const model = createModel();
264
+
265
+ await openDynamicFlowsEditor(model);
266
+ await userEvent.click(screen.getByRole('button', { name: 'Add event flow' }));
267
+
268
+ expect(model.flowRegistry.getFlows().size).toBe(1);
269
+ expect(model.flowRegistry.hasFlow('flow1')).toBe(true);
270
+ });
271
+
272
+ it('blocks cancel when draft has unsaved changes and confirmation is rejected', async () => {
273
+ const model = createModel();
274
+ mockState.flowContextValue.modal.confirm.mockResolvedValue(false);
275
+ const { view } = await openDynamicFlowsEditor(model);
276
+
277
+ await userEvent.click(screen.getByRole('button', { name: 'Add event flow' }));
278
+ await userEvent.click(screen.getByRole('button', { name: 'Cancel' }));
279
+
280
+ expect(mockState.flowContextValue.modal.confirm).toHaveBeenCalledWith({
281
+ title: 'Unsaved changes',
282
+ content: "Are you sure you don't want to save?",
283
+ okText: 'Confirm',
284
+ cancelText: 'Cancel',
285
+ });
286
+ expect(view.destroy).not.toHaveBeenCalled();
287
+ expect(model.flowRegistry.getFlows().size).toBe(1);
288
+ });
289
+
290
+ it('runs only one unsaved confirmation while cancel is pending', async () => {
291
+ const model = createModel();
292
+ let resolveConfirm: (value: boolean) => void;
293
+ mockState.flowContextValue.modal.confirm.mockImplementation(
294
+ () => new Promise<boolean>((resolve) => (resolveConfirm = resolve)),
295
+ );
296
+ const { view } = await openDynamicFlowsEditor(model);
297
+
298
+ await userEvent.click(screen.getByRole('button', { name: 'Add event flow' }));
299
+ const cancelButton = screen.getByRole('button', { name: 'Cancel' });
300
+ await userEvent.click(cancelButton);
301
+ await userEvent.click(cancelButton);
302
+
303
+ expect(mockState.flowContextValue.modal.confirm).toHaveBeenCalledTimes(1);
304
+
305
+ resolveConfirm(true);
306
+ await waitFor(() => expect(view.destroy).toHaveBeenCalledTimes(1));
307
+ });
308
+
309
+ it('discards draft changes after confirmed cancel', async () => {
310
+ const model = createModel();
311
+ mockState.flowContextValue.modal.confirm.mockResolvedValue(true);
312
+ const { view } = await openDynamicFlowsEditor(model);
313
+
314
+ await userEvent.click(screen.getByRole('button', { name: 'Add event flow' }));
315
+ await userEvent.click(screen.getByRole('button', { name: 'Cancel' }));
316
+
317
+ expect(view.destroy).toHaveBeenCalledTimes(1);
318
+ expect(model.flowRegistry.getFlows().size).toBe(1);
319
+ expect(model.flowRegistry.hasFlow('flow1')).toBe(true);
320
+ });
321
+
322
+ it('discards existing event flow edits after confirmed cancel', async () => {
323
+ const model = createModel();
324
+ mockState.flowContextValue.modal.confirm.mockResolvedValue(true);
325
+ const { view } = await openDynamicFlowsEditor(model);
326
+
327
+ const titleInput = screen.getByPlaceholderText('Enter flow title');
328
+ await userEvent.clear(titleInput);
329
+ await userEvent.type(titleInput, 'Changed flow');
330
+ await userEvent.click(screen.getByRole('button', { name: 'Cancel' }));
331
+
332
+ expect(view.destroy).toHaveBeenCalledTimes(1);
333
+ expect(model.flowRegistry.getFlow('flow1')?.title).toBe('Event flow');
334
+ });
335
+
336
+ it('discards added draft steps after confirmed cancel', async () => {
337
+ const model = createModel();
338
+ mockState.flowContextValue.modal.confirm.mockResolvedValue(true);
339
+ const { view } = await openDynamicFlowsEditor(model);
340
+
341
+ expect(model.flowRegistry.getFlow('flow1')?.getSteps().size).toBe(0);
342
+
343
+ await userEvent.click(screen.getByRole('button', { name: 'Notify' }));
344
+ await userEvent.click(screen.getByRole('button', { name: 'Cancel' }));
345
+
346
+ expect(view.destroy).toHaveBeenCalledTimes(1);
347
+ expect(model.flowRegistry.getFlow('flow1')?.getSteps().size).toBe(0);
348
+ });
349
+
350
+ it('does not keep discarded draft changes after reopening the editor', async () => {
351
+ const model = createModel();
352
+ mockState.flowContextValue.modal.confirm.mockResolvedValue(true);
353
+
354
+ const firstEditor = await openDynamicFlowsEditor(model);
355
+ await userEvent.click(screen.getByRole('button', { name: 'Add event flow' }));
356
+ await userEvent.click(screen.getByRole('button', { name: 'Cancel' }));
357
+ firstEditor.editor.unmount();
358
+
359
+ mockState.capturedSelectProps.length = 0;
360
+ mockState.flowContextValue.view = createView();
361
+ const secondEditor = await openDynamicFlowsEditor(model);
362
+
363
+ expect(secondEditor.editor.container.querySelectorAll('input[placeholder="Enter flow title"]')).toHaveLength(1);
364
+ expect(model.flowRegistry.getFlows().size).toBe(1);
365
+ });
366
+
367
+ it('saves draft event flows into the real registry', async () => {
368
+ const saveStepParams = vi.fn(async () => undefined);
369
+ const model = createModel({ saveStepParams });
370
+ const { view } = await openDynamicFlowsEditor(model);
371
+
372
+ await userEvent.click(screen.getByRole('button', { name: 'Add event flow' }));
373
+ await userEvent.click(screen.getByRole('button', { name: 'Save' }));
374
+
375
+ expect(saveStepParams).toHaveBeenCalledTimes(1);
376
+ expect(model.flowRegistry.getFlows().size).toBe(2);
377
+ expect(view.destroy).toHaveBeenCalledTimes(1);
378
+ expect(model.context.message.success).toHaveBeenCalledWith('Configuration saved');
379
+ });
193
380
  });