@nocobase/cli-v1 2.2.0-alpha.7 → 2.2.0-beta.10

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nocobase/cli-v1",
-  "version": "2.2.0-alpha.7",
+  "version": "2.2.0-beta.10",
   "description": "",
   "license": "Apache-2.0",
   "main": "./src/index.js",
@@ -9,9 +9,9 @@
     "nocobase-v1": "./bin/index.js"
   },
   "dependencies": {
-    "@nocobase/cli": "2.2.0-alpha.7",
+    "@nocobase/cli": "2.2.0-beta.10",
     "@nocobase/license-kit": "^0.3.8",
-    "@nocobase/utils": "2.2.0-alpha.7",
+    "@nocobase/utils": "2.2.0-beta.10",
     "chalk": "^4.1.1",
     "commander": "^9.2.0",
     "deepmerge": "^4.3.1",
@@ -33,5 +33,5 @@
     "url": "git+https://github.com/nocobase/nocobase.git",
     "directory": "packages/core/cli"
   },
-  "gitHead": "34ba02960fca9ab0b6881d3db7040a8a64067bba"
+  "gitHead": "d572beec24de46df948f28db72b25303a63bf62d"
 }

package/src/__tests__/build-index-html.test.js

@@ -24,8 +24,6 @@ function createAppPackageRoot() {
     [
       "window['__nocobase_app_dev__'] = {{env.NOCOBASE_APP_DEV}};",
       "window['__nocobase_public_path__'] = '{{env.APP_PUBLIC_PATH}}';",
-      "window['__nocobase_modern_client_prefix__'] = '{{env.APP_MODERN_CLIENT_PREFIX}}';",
-      "window['__nocobase_app_client_entry_mode__'] = '{{env.APP_CLIENT_ENTRY_MODE}}';",
     ].join('\n'),
     'utf-8',
   );
@@ -75,43 +73,11 @@ describe('cli-v1 buildIndexHtml', () => {
     process.env.APP_PACKAGE_ROOT = appRoot;
     process.env.APP_PUBLIC_PATH = '/';
     process.env.NOCOBASE_APP_DEV = '';
-    process.env.APP_MODERN_CLIENT_PREFIX = 'console';
-    process.env.APP_CLIENT_ENTRY_MODE = 'modern-default';
 
     buildIndexHtml();
 
     const html = fs.readFileSync(path.join(appRoot, 'dist/client/index.html'), 'utf-8');
     expect(html).toContain("window['__nocobase_app_dev__'] = false;");
-    expect(html).toContain("window['__nocobase_modern_client_prefix__'] = 'console';");
-    expect(html).toContain("window['__nocobase_app_client_entry_mode__'] = 'modern-default';");
-    fs.removeSync(appRoot);
-  });
-
-  test('refreshes cached tpl when new runtime placeholders are missing', () => {
-    const appRoot = createAppPackageRoot();
-    const tplPath = path.join(appRoot, 'dist/client/index.html.tpl');
-    const indexPath = path.join(appRoot, 'dist/client/index.html');
-    fs.writeFileSync(tplPath, "window['__nocobase_public_path__'] = '{{env.APP_PUBLIC_PATH}}';", 'utf-8');
-    fs.writeFileSync(
-      indexPath,
-      [
-        "window['__nocobase_public_path__'] = '{{env.APP_PUBLIC_PATH}}';",
-        "window['__nocobase_modern_client_prefix__'] = '{{env.APP_MODERN_CLIENT_PREFIX}}';",
-        "window['__nocobase_app_client_entry_mode__'] = '{{env.APP_CLIENT_ENTRY_MODE}}';",
-      ].join('\n'),
-      'utf-8',
-    );
-    process.argv = ['node', 'nocobase-v1', 'start'];
-    process.env.APP_PACKAGE_ROOT = appRoot;
-    process.env.APP_PUBLIC_PATH = '/';
-    process.env.APP_MODERN_CLIENT_PREFIX = 'v';
-    process.env.APP_CLIENT_ENTRY_MODE = 'modern-only';
-
-    buildIndexHtml();
-
-    const tpl = fs.readFileSync(tplPath, 'utf-8');
-    expect(tpl).toContain('__nocobase_modern_client_prefix__');
-    expect(tpl).toContain('__nocobase_app_client_entry_mode__');
     fs.removeSync(appRoot);
   });
 });

package/src/__tests__/dev-command.test.js

@@ -9,7 +9,7 @@
 
 /* eslint-env jest */
 
-const { buildAppDevForwardArgs, forwardDevToAppDev, resolveDevRuntimeMode } = require('../commands/dev')._test;
+const { buildAppDevForwardArgs, forwardDevToAppDev } = require('../commands/dev')._test;
 
 describe('cli-v1 dev command', () => {
   test('buildAppDevForwardArgs rewrites dev argv to app-dev while preserving extra args', () => {
@@ -31,31 +31,4 @@ describe('cli-v1 dev command', () => {
 
     expect(calls).toEqual([['nocobase-v1', ['app-dev', '--port', '13000', '--db-sync']]]);
   });
-
-  test('resolveDevRuntimeMode keeps both clients in legacy-default', () => {
-    expect(resolveDevRuntimeMode({ appClientEntryMode: 'legacy-default' })).toMatchObject({
-      useModernOnlyEntryMode: false,
-      shouldRunClient: true,
-      shouldRunClientV2: true,
-      shouldRunServer: true,
-    });
-  });
-
-  test('resolveDevRuntimeMode only runs v2 client and server in modern-only', () => {
-    expect(resolveDevRuntimeMode({ appClientEntryMode: 'modern-only' })).toMatchObject({
-      useModernOnlyEntryMode: true,
-      shouldRunClient: false,
-      shouldRunClientV2: true,
-      shouldRunServer: true,
-    });
-  });
-
-  test('resolveDevRuntimeMode preserves explicit client-v2-only flag behavior', () => {
-    expect(resolveDevRuntimeMode({ clientV2Only: true, appClientEntryMode: 'legacy-default' })).toMatchObject({
-      useModernOnlyEntryMode: false,
-      shouldRunClient: false,
-      shouldRunClientV2: true,
-      shouldRunServer: false,
-    });
-  });
 });

package/src/commands/dev.js

@@ -20,7 +20,6 @@ const {
   isPortReachable,
   buildWSURL,
   checkDBDialect,
-  resolveAppClientEntryMode,
 } = require('../util');
 const { getPortPromise } = require('portfinder');
 const chokidar = require('chokidar');
@@ -48,25 +47,6 @@ function buildAppDevForwardArgs(argv = process.argv) {
   return ['app-dev', ...argv.slice(3)];
 }
 
-function resolveDevRuntimeMode(opts = {}) {
-  const appClientEntryMode = opts.appClientEntryMode || resolveAppClientEntryMode();
-  const useModernOnlyEntryMode = appClientEntryMode === 'modern-only';
-  const clientV2Only = !!opts.clientV2Only;
-  const forceClient = !!opts.client;
-  const forceServer = !!opts.server;
-  const shouldRunClientV2 = clientV2Only || useModernOnlyEntryMode || forceClient || !forceServer;
-  const shouldRunClient = !clientV2Only && !useModernOnlyEntryMode && (forceClient || !forceServer);
-  const shouldRunServer = !clientV2Only && (forceServer || !forceClient || useModernOnlyEntryMode);
-
-  return {
-    appClientEntryMode,
-    useModernOnlyEntryMode,
-    shouldRunClientV2,
-    shouldRunClient,
-    shouldRunServer,
-  };
-}
-
 async function forwardDevToAppDev({ argv = process.argv, runCommand = run } = {}) {
   await runCommand('nocobase-v1', buildAppDevForwardArgs(argv));
 }
@@ -127,9 +107,9 @@ module.exports = (cli) => {
       nodeCheck();
       await postCheck(opts);
 
-      const { useModernOnlyEntryMode, shouldRunClientV2, shouldRunClient, shouldRunServer } = resolveDevRuntimeMode(
-        opts,
-      );
+      const shouldRunClientV2 = clientV2Only || client || !server;
+      const shouldRunClient = !clientV2Only && (client || !server);
+      const shouldRunServer = !clientV2Only && (server || !client);
       const shouldRunClientWithRsbuild = shouldRunClient && !!rsbuild;
 
       if (shouldRunServer && server) {
@@ -140,16 +120,12 @@ module.exports = (cli) => {
         });
       }
 
-      if (shouldRunClientV2 && !clientV2Only && !useModernOnlyEntryMode) {
+      if (shouldRunClientV2 && !clientV2Only) {
         clientV2Port = await getPortPromise({
           port: 1 * clientPort + 2,
         });
       }
 
-      if (useModernOnlyEntryMode) {
-        clientV2Port = APP_PORT;
-      }
-
       let subprocessClient;
       let subprocessClientV2;
 
@@ -330,5 +306,4 @@ module.exports = (cli) => {
 module.exports._test = {
   buildAppDevForwardArgs,
   forwardDevToAppDev,
-  resolveDevRuntimeMode,
 };

package/src/util.js

@@ -432,30 +432,6 @@ const DEFAULT_MODERN_CLIENT_PREFIX = 'v';
 
 exports.DEFAULT_MODERN_CLIENT_PREFIX = DEFAULT_MODERN_CLIENT_PREFIX;
 
-const DEFAULT_APP_CLIENT_ENTRY_MODE = 'legacy-default';
-const APP_CLIENT_ENTRY_MODES = new Set(['legacy-default', 'modern-default', 'modern-only']);
-
-exports.DEFAULT_APP_CLIENT_ENTRY_MODE = DEFAULT_APP_CLIENT_ENTRY_MODE;
-
-function isAppClientEntryMode(value) {
-  return APP_CLIENT_ENTRY_MODES.has(String(value || '').trim());
-}
-
-exports.isAppClientEntryMode = isAppClientEntryMode;
-
-function normalizeAppClientEntryMode(value) {
-  const normalized = String(value || '').trim();
-  return isAppClientEntryMode(normalized) ? normalized : DEFAULT_APP_CLIENT_ENTRY_MODE;
-}
-
-exports.normalizeAppClientEntryMode = normalizeAppClientEntryMode;
-
-function resolveAppClientEntryMode() {
-  return normalizeAppClientEntryMode(process.env.APP_CLIENT_ENTRY_MODE);
-}
-
-exports.resolveAppClientEntryMode = resolveAppClientEntryMode;
-
 // Normalize APP_MODERN_CLIENT_PREFIX (accepts `v`, `/v`, `/v/`)
 // down to a bare segment like `v`.
 function normalizeModernClientPrefix(value) {
@@ -479,13 +455,6 @@ function isAppDevHtml() {
   return process.argv[2] === 'app-dev' || process.env.NOCOBASE_APP_DEV === 'true';
 }
 
-function shouldRefreshLegacyIndexTemplate(data = '') {
-  return (
-    !data.includes("window['__nocobase_modern_client_prefix__']") ||
-    !data.includes("window['__nocobase_app_client_entry_mode__']")
-  );
-}
-
 function buildIndexHtml(force = false) {
   if (process.env.NOCOBASE_EXTRACT_CLIENT_ASSETS === 'true') {
     return;
@@ -500,15 +469,11 @@ function buildIndexHtml(force = false) {
   }
   if (!fs.existsSync(tpl)) {
     fs.copyFileSync(file, tpl);
-  } else if (shouldRefreshLegacyIndexTemplate(fs.readFileSync(tpl, 'utf-8'))) {
-    fs.copyFileSync(file, tpl);
   }
   const data = fs.readFileSync(tpl, 'utf-8');
   let replacedData = data
     .replace(/\{\{env.CDN_BASE_URL\}\}/g, process.env.CDN_BASE_URL)
     .replace(/\{\{env.APP_PUBLIC_PATH\}\}/g, process.env.APP_PUBLIC_PATH)
-    .replace(/\{\{env.APP_MODERN_CLIENT_PREFIX\}\}/g, normalizeModernClientPrefix(process.env.APP_MODERN_CLIENT_PREFIX))
-    .replace(/\{\{env.APP_CLIENT_ENTRY_MODE\}\}/g, resolveAppClientEntryMode())
     .replace(/\{\{env.API_CLIENT_SHARE_TOKEN\}\}/g, process.env.API_CLIENT_SHARE_TOKEN || 'false')
     .replace(/\{\{env.API_CLIENT_STORAGE_TYPE\}\}/g, process.env.API_CLIENT_STORAGE_TYPE)
     .replace(/\{\{env.API_CLIENT_STORAGE_PREFIX\}\}/g, process.env.API_CLIENT_STORAGE_PREFIX)
@@ -649,7 +614,6 @@ exports.initEnv = function initEnv() {
     CDN_BASE_URL: '',
     APP_PUBLIC_PATH: '/',
     APP_MODERN_CLIENT_PREFIX: DEFAULT_MODERN_CLIENT_PREFIX,
-    APP_CLIENT_ENTRY_MODE: DEFAULT_APP_CLIENT_ENTRY_MODE,
     ESM_CDN_BASE_URL: 'https://esm.sh',
     ESM_CDN_SUFFIX: '',
   };
@@ -701,14 +665,6 @@ exports.initEnv = function initEnv() {
     }
   }
 
-  const rawAppClientEntryMode = String(process.env.APP_CLIENT_ENTRY_MODE || '').trim();
-  if (rawAppClientEntryMode && !isAppClientEntryMode(rawAppClientEntryMode)) {
-    console.warn(
-      `Unknown APP_CLIENT_ENTRY_MODE "${rawAppClientEntryMode}", falling back to ${DEFAULT_APP_CLIENT_ENTRY_MODE}.`,
-    );
-  }
-  process.env.APP_CLIENT_ENTRY_MODE = normalizeAppClientEntryMode(rawAppClientEntryMode);
-
   if (!process.env.__env_modified__ && process.env.APP_PUBLIC_PATH) {
     const publicPath = process.env.APP_PUBLIC_PATH.replace(/\/$/g, '');
     const keys = ['API_BASE_PATH', 'WS_PATH', 'PLUGIN_STATICS_PATH'];