@nocobase/app-template-default 1.0.0-beta.70 → 1.0.0-beta.71

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
@@ -126,7 +126,7 @@ function LevelControl({
126
126
  if (levels.length === 0) return null;
127
127
  if (levels.length === 1)
128
128
  return (
129
- <span className='block truncate px-2.5 text-sm text-muted-foreground'>
129
+ <span className='flex min-h-7 min-w-0 items-center px-2 text-xs text-muted-foreground'>
130
130
  {levels[0]?.label}
131
131
  </span>
132
132
  );
@@ -141,7 +141,7 @@ function LevelControl({
141
141
  >
142
142
  <SelectTrigger
143
143
  size='sm'
144
- className='h-6 w-auto max-w-48 gap-1 border-0 bg-muted/50 px-2 text-xs shadow-none'
144
+ className='h-7 w-full min-w-0 max-w-full flex-1 gap-1 border-0 bg-muted/50 px-2 text-xs shadow-none'
145
145
  aria-label={label}
146
146
  >
147
147
  <SelectValue />
@@ -162,6 +162,7 @@ function LevelControl({
162
162
  function PermissionRow({
163
163
  row,
164
164
  controlId,
165
+ showScopeLabels = false,
165
166
  readOnly,
166
167
  labels,
167
168
  onEnabledChange,
@@ -169,6 +170,7 @@ function PermissionRow({
169
170
  }: {
170
171
  readonly row: PermissionEditorRow;
171
172
  readonly controlId: string;
173
+ readonly showScopeLabels?: boolean;
172
174
  readonly readOnly: boolean;
173
175
  readonly labels: PermissionEditorLabels;
174
176
  readonly onEnabledChange: (rowId: string, enabled: boolean) => void;
@@ -179,7 +181,7 @@ function PermissionRow({
179
181
  data-slot='permission-row'
180
182
  className='flex min-w-0 flex-col gap-1 rounded-md px-2 py-1.5'
181
183
  >
182
- <div className='flex min-h-6 min-w-0 flex-wrap items-center gap-2'>
184
+ <div className='grid min-h-6 min-w-0 grid-cols-[auto_auto_minmax(0,1fr)] items-center gap-x-2 @2xl:grid-cols-[auto_minmax(0,1fr)] gap-y-1'>
183
185
  <Checkbox
184
186
  id={controlId}
185
187
  checked={row.enabled}
@@ -189,35 +191,45 @@ function PermissionRow({
189
191
  />
190
192
  <label
191
193
  htmlFor={controlId}
192
- className='min-w-0 cursor-pointer text-sm leading-5 font-medium break-words'
194
+ className='min-h-6 min-w-0 max-w-36 cursor-pointer text-sm leading-6 font-medium break-words @2xl:max-w-none'
193
195
  >
194
196
  {row.label}
195
197
  </label>
196
198
  {row.enabled && row.levels ? (
197
- <LevelControl
198
- label={labels.levelFor(row.label)}
199
- levels={row.levels}
200
- value={row.level ?? ''}
201
- disabled={readOnly}
202
- onChange={(level) => onLevelChange(row.id, level)}
203
- />
199
+ <div className='col-start-3 min-w-0 @2xl:col-start-2'>
200
+ <LevelControl
201
+ label={labels.levelFor(row.label)}
202
+ levels={row.levels}
203
+ value={row.level ?? ''}
204
+ disabled={readOnly}
205
+ onChange={(level) => onLevelChange(row.id, level)}
206
+ />
207
+ </div>
204
208
  ) : null}
205
209
  {row.enabled &&
206
210
  row.scopes?.map((scope) => (
207
- <div key={scope.id} className='flex min-w-0 items-center gap-1'>
208
- {row.scopes && row.scopes.length > 1 && (
209
- <span className='text-xs text-muted-foreground'>
211
+ <div
212
+ key={scope.id}
213
+ className={cn(
214
+ 'col-start-3 grid min-w-0 gap-1 @2xl:col-start-2',
215
+ showScopeLabels && 'col-span-2 col-start-2 @2xl:col-span-1',
216
+ )}
217
+ >
218
+ {(showScopeLabels || (row.scopes && row.scopes.length > 1)) && (
219
+ <span className='text-xs leading-5 text-muted-foreground'>
210
220
  {scope.label}
211
221
  </span>
212
222
  )}
213
- <LevelControl
214
- label={labels.levelFor(`${row.label} · ${scope.label}`)}
215
- levels={scope.levels}
216
- value={scope.level ?? ''}
217
- disabled={readOnly}
218
- onChange={(level) => onLevelChange(scope.id, level)}
219
- />
220
- {scope.configuration}
223
+ <div className='flex min-h-7 min-w-0 items-center gap-1'>
224
+ <LevelControl
225
+ label={labels.levelFor(`${row.label} · ${scope.label}`)}
226
+ levels={scope.levels}
227
+ value={scope.level ?? ''}
228
+ disabled={readOnly}
229
+ onChange={(level) => onLevelChange(scope.id, level)}
230
+ />
231
+ {scope.configuration}
232
+ </div>
221
233
  </div>
222
234
  ))}
223
235
  </div>
@@ -280,7 +292,7 @@ export function PermissionEditor({
280
292
  return (
281
293
  <div className='@container flex min-w-0 flex-col overflow-hidden rounded-xl border bg-card'>
282
294
  <div className='flex flex-wrap items-center gap-3 border-b p-3'>
283
- <div className='relative min-w-0 flex-1'>
295
+ <div className='relative min-w-48 flex-1'>
284
296
  <SearchIcon
285
297
  aria-hidden
286
298
  className='pointer-events-none absolute top-1/2 left-3 size-4 -translate-y-1/2 text-muted-foreground'
@@ -296,7 +308,7 @@ export function PermissionEditor({
296
308
  </div>
297
309
  <label
298
310
  htmlFor={`${id}-enabled`}
299
- className='flex items-center gap-2 text-sm'
311
+ className='flex shrink-0 items-center gap-2 text-sm whitespace-nowrap'
300
312
  >
301
313
  <Switch
302
314
  id={`${id}-enabled`}
@@ -322,7 +334,7 @@ export function PermissionEditor({
322
334
  <div className='flex max-h-128 min-w-0 flex-col overflow-auto @2xl:flex-row'>
323
335
  <nav
324
336
  aria-label={words.navigation}
325
- className='flex shrink-0 gap-1 overflow-x-auto border-b bg-muted/25 p-2 @2xl:sticky @2xl:top-0 @2xl:max-h-128 @2xl:w-48 @2xl:self-start @2xl:flex-col @2xl:border-r @2xl:border-b-0'
337
+ className='flex shrink-0 gap-1 overflow-x-auto border-b bg-muted/25 p-2 @2xl:sticky @2xl:top-0 @2xl:max-h-128 @2xl:w-64 @2xl:self-start @2xl:flex-col @2xl:border-r @2xl:border-b-0'
326
338
  >
327
339
  {sections.map((section) => {
328
340
  const rows = section.groups.flatMap((group) => group.rows);
@@ -338,13 +350,18 @@ export function PermissionEditor({
338
350
  setEnabledOnly(false);
339
351
  }}
340
352
  className={cn(
341
- 'h-auto shrink-0 justify-between gap-4 px-3 py-2.5 text-left whitespace-normal',
353
+ 'h-auto shrink-0 justify-between gap-3 px-3 py-2 text-left whitespace-nowrap @2xl:w-full @2xl:min-w-0',
342
354
  section.id === active &&
343
355
  'bg-primary/10 text-primary hover:bg-primary/15',
344
356
  )}
345
357
  >
346
- <span>{section.title}</span>
347
- <span className='rounded-md bg-background px-1.5 py-0.5 text-xs tabular-nums'>
358
+ <span
359
+ className='min-w-0 @2xl:flex-1 @2xl:truncate'
360
+ title={section.title}
361
+ >
362
+ {section.title}
363
+ </span>
364
+ <span className='shrink-0 rounded-md bg-background px-1.5 py-0.5 text-xs tabular-nums'>
348
365
  {rows.filter((row) => row.enabled).length}/{rows.length}
349
366
  </span>
350
367
  </Button>
@@ -357,6 +374,9 @@ export function PermissionEditor({
357
374
  const original =
358
375
  sections.find((item) => item.id === section.id) ?? section;
359
376
  const singleResource = original.groups.length === 1;
377
+ const showScopeLabels = original.groups.some((group) =>
378
+ group.rows.some((row) => (row.scopes?.length ?? 0) > 1),
379
+ );
360
380
  const keys = [
361
381
  ...new Set(
362
382
  original.groups
@@ -369,16 +389,30 @@ export function PermissionEditor({
369
389
  ...common.filter((key) => keys.includes(key)),
370
390
  ...keys.filter((key) => !common.includes(key)),
371
391
  ];
372
- // Dense or unclassified catalogs keep the wrapping layout instead of hiding actions.
373
392
  const aligned =
374
393
  columns.length > 0 &&
375
- columns.length <= 7 &&
394
+ columns.length <= 4 &&
376
395
  original.groups.every(
377
396
  (group) =>
378
397
  group.rows.every((row) => row.actionKey) &&
379
398
  new Set(group.rows.map((row) => row.actionKey)).size ===
380
399
  group.rows.length,
381
400
  );
401
+ // Keep action columns only when each has room for its label and scope.
402
+ const alignment = [
403
+ '',
404
+ '@3xl:grid-cols-(--permission-columns)',
405
+ '@3xl:grid-cols-(--permission-columns)',
406
+ '@5xl:grid-cols-(--permission-columns)',
407
+ '@7xl:grid-cols-(--permission-columns)',
408
+ ][columns.length];
409
+ const placement = [
410
+ '',
411
+ '@3xl:col-start-(--permission-column) @3xl:row-start-1',
412
+ '@3xl:col-start-(--permission-column) @3xl:row-start-1',
413
+ '@5xl:col-start-(--permission-column) @5xl:row-start-1',
414
+ '@7xl:col-start-(--permission-column) @7xl:row-start-1',
415
+ ][columns.length];
382
416
  return (
383
417
  <section
384
418
  key={section.id}
@@ -430,11 +464,11 @@ export function PermissionEditor({
430
464
  return (
431
465
  <div
432
466
  key={group.id}
433
- className='grid min-w-0 gap-2 p-3 @xl:grid-cols-[minmax(8rem,1fr)_minmax(0,4fr)]'
467
+ className='grid min-w-0 gap-2 p-3 @3xl:grid-cols-[9rem_minmax(0,1fr)]'
434
468
  data-slot='permission-resource'
435
469
  >
436
- <div className='flex min-w-0 flex-col justify-center gap-1'>
437
- <h3 className='text-sm font-medium break-words'>
470
+ <div className='flex min-w-0 flex-col gap-1 py-1.5'>
471
+ <h3 className='min-h-6 text-sm leading-6 font-medium break-words'>
438
472
  {group.title ?? section.title}
439
473
  </h3>
440
474
  {group.hint && (
@@ -442,7 +476,12 @@ export function PermissionEditor({
442
476
  {group.hint}
443
477
  </p>
444
478
  )}
445
- <div className='flex items-center gap-2 text-xs text-muted-foreground'>
479
+ <div
480
+ className={cn(
481
+ 'flex min-h-7 items-center gap-2 text-xs text-muted-foreground',
482
+ showScopeLabels && '@3xl:mt-6',
483
+ )}
484
+ >
446
485
  {onEnabledBatchChange &&
447
486
  totalRows.length > 1 &&
448
487
  selectable.length > 0 && (
@@ -514,9 +553,8 @@ export function PermissionEditor({
514
553
  </div>
515
554
  <div
516
555
  className={cn(
517
- 'flex min-w-0 flex-wrap items-start gap-x-3 gap-y-1',
518
- aligned &&
519
- '@4xl:grid @4xl:grid-cols-(--permission-columns) @4xl:gap-x-1',
556
+ 'grid min-w-0 grid-cols-[repeat(auto-fill,minmax(min(100%,14rem),1fr))] items-start gap-x-2 gap-y-1',
557
+ aligned && alignment,
520
558
  )}
521
559
  style={
522
560
  {
@@ -524,42 +562,42 @@ export function PermissionEditor({
524
562
  } as CSSProperties
525
563
  }
526
564
  >
527
- {(aligned
528
- ? [...group.rows].sort(
529
- (a, b) =>
530
- columns.indexOf(a.actionKey ?? '') -
531
- columns.indexOf(b.actionKey ?? ''),
532
- )
533
- : group.rows
534
- ).map((row) => (
535
- <div
536
- key={row.id}
537
- className={cn(
538
- 'min-w-0',
539
- aligned &&
540
- '@4xl:col-start-(--permission-column) @4xl:row-start-1',
541
- )}
542
- style={
543
- {
544
- '--permission-column':
545
- columns.indexOf(row.actionKey ?? '') + 1,
546
- } as CSSProperties
547
- }
548
- >
549
- <PermissionRow
550
- controlId={`${id}-${row.id}`}
551
- row={row}
552
- readOnly={readOnly}
553
- labels={words}
554
- onEnabledChange={(rowId, on) => {
555
- if (enabledOnly && !on)
556
- searchRef.current?.focus();
557
- onEnabledChange(rowId, on);
558
- }}
559
- onLevelChange={onLevelChange}
560
- />
561
- </div>
562
- ))}
565
+ {[...group.rows]
566
+ .sort(
567
+ (a, b) =>
568
+ columns.indexOf(a.actionKey ?? '') -
569
+ columns.indexOf(b.actionKey ?? ''),
570
+ )
571
+ .map((row) => (
572
+ <div
573
+ key={row.id}
574
+ className={cn(
575
+ 'min-w-0',
576
+ aligned && placement,
577
+ )}
578
+ style={
579
+ {
580
+ '--permission-column':
581
+ columns.indexOf(row.actionKey ?? '') +
582
+ 1,
583
+ } as CSSProperties
584
+ }
585
+ >
586
+ <PermissionRow
587
+ controlId={`${id}-${row.id}`}
588
+ row={row}
589
+ showScopeLabels={showScopeLabels}
590
+ readOnly={readOnly}
591
+ labels={words}
592
+ onEnabledChange={(rowId, on) => {
593
+ if (enabledOnly && !on)
594
+ searchRef.current?.focus();
595
+ onEnabledChange(rowId, on);
596
+ }}
597
+ onLevelChange={onLevelChange}
598
+ />
599
+ </div>
600
+ ))}
563
601
  </div>
564
602
  </div>
565
603
  );
@@ -97,6 +97,7 @@ const settings = {
97
97
  selectAllPermissions: 'All',
98
98
  selectVisiblePermissions: 'Select visible permissions in {{name}}',
99
99
  permissionSummary: '{{enabled}} of {{total}} enabled',
100
+ preservedRecordScope: 'Keep existing configuration',
100
101
  noRecordScope: 'No records (not authorized)',
101
102
  permissionFilter: {
102
103
  limit: 'Up to 20 conditions',
@@ -88,18 +88,19 @@ const settings = {
88
88
  total_other: '共 {{count}} 位用户',
89
89
  access: '访问',
90
90
  permissionSearch: '搜索分类、分组或权限',
91
- enabledOnly: '仅看已开启',
91
+ enabledOnly: '仅显示已授权',
92
92
  noPermissions: '暂无可配置权限',
93
93
  permissionCategories: '权限分类',
94
94
  selectAllPermissions: '全选',
95
95
  selectVisiblePermissions: '选择“{{name}}”中显示的权限',
96
- permissionSummary: '已开启 {{enabled}} / {{total}}',
97
- noRecordScope: '无记录(未授权)',
96
+ permissionSummary: '已授权 {{enabled}} / {{total}}',
97
+ noRecordScope: '不允许访问数据',
98
+ preservedRecordScope: '保留现有配置',
98
99
  permissionFilter: {
99
100
  limit: '最多支持 20 个条件',
100
- configure: '筛选条件',
101
- title: '配置记录筛选',
102
- description: '应用条件后还需保存角色,权限才会生效。',
101
+ configure: '设置条件',
102
+ title: '设置数据范围',
103
+ description: '仅允许访问符合以下条件的数据,保存角色后生效。',
103
104
  all: '满足全部条件',
104
105
  any: '满足任一条件',
105
106
  field: '字段',
@@ -24,19 +24,28 @@ export function pagePermissionResources(
24
24
  titles: PagePermissionTitles,
25
25
  unnamed: (path: string) => string,
26
26
  ): CatalogResource[] {
27
- return routes.flatMap((route) => [
28
- ...(route.componentLoader &&
29
- typeof route.authz === 'object' &&
30
- route.authz.resource.type === 'page'
31
- ? [
32
- {
27
+ const resources = new Map<string, CatalogResource>();
28
+ const visit = (items: readonly AppClientRegisteredRoute[]): void => {
29
+ for (const route of items) {
30
+ if (
31
+ route.componentLoader &&
32
+ typeof route.authz === 'object' &&
33
+ route.authz.resource.type === 'page'
34
+ ) {
35
+ const id = route.authz.resource.id;
36
+ // Resolved child routes may inherit the parent's authorization resource.
37
+ // They share one grant, so showing independent checkboxes is misleading.
38
+ if (!resources.has(id))
39
+ resources.set(id, {
33
40
  type: 'page',
34
- id: route.authz.resource.id,
41
+ id,
35
42
  title: pagePermissionTitle(route, titles) ?? unnamed(route.path),
36
43
  actions: [{ name: 'access', title: { key: 'settings.access' } }],
37
- },
38
- ]
39
- : []),
40
- ...pagePermissionResources(route.children ?? [], titles, unnamed),
41
- ]);
44
+ });
45
+ }
46
+ visit(route.children ?? []);
47
+ }
48
+ };
49
+ visit(routes);
50
+ return [...resources.values()];
42
51
  }
@@ -17,6 +17,15 @@ export function setPermission(
17
17
  action: string,
18
18
  enabled: boolean,
19
19
  ): readonly PermissionGrant[] {
20
+ const existing =
21
+ grants
22
+ .find(
23
+ (grant) =>
24
+ grant.resource.type === resource.type &&
25
+ grant.resource.id === resource.id,
26
+ )
27
+ ?.actions.some((entry) => entry.action === action) ?? false;
28
+ if (existing === enabled) return grants;
20
29
  const next = grants.map((grant) => ({
21
30
  ...grant,
22
31
  actions: [...grant.actions],
@@ -87,40 +96,55 @@ export function permissionSections(
87
96
  return {
88
97
  ...row,
89
98
  scopes: granted
90
- ? (resource.dataScopes?.[action.name] ?? []).map((scope) => ({
91
- id: JSON.stringify([
92
- resource.type,
93
- resource.id,
94
- action.name,
95
- scope.key,
96
- ]),
97
- label: text(
98
- typeof scope.title === 'string' &&
99
- scope.title === scope.collection
100
- ? { key: 'settings.recordScope' }
101
- : scope.title,
102
- ),
103
- levels: [
104
- {
105
- value: '',
106
- label: text({ key: 'settings.noRecordScope' }),
107
- },
108
- ...scope.recordAccess.map((key) => ({
109
- value: key,
110
- label: text(
111
- catalog.recordAccess.find(
112
- (entry) => entry.key === key,
113
- )?.title ?? key,
114
- ),
115
- })),
116
- ],
117
- level: scopeSelectionKey(
99
+ ? (resource.dataScopes?.[action.name] ?? []).map((scope) => {
100
+ const value = scopeSelectionKey(
118
101
  granted.policy?.scopes &&
119
102
  typeof granted.policy.scopes === 'object'
120
103
  ? Reflect.get(granted.policy.scopes, scope.key)
121
104
  : undefined,
122
- ),
123
- }))
105
+ );
106
+ const preserved =
107
+ value !== '' && !scope.recordAccess.includes(value);
108
+ return {
109
+ id: JSON.stringify([
110
+ resource.type,
111
+ resource.id,
112
+ action.name,
113
+ scope.key,
114
+ ]),
115
+ label: text(
116
+ typeof scope.title === 'string' &&
117
+ scope.title === scope.collection
118
+ ? { key: 'settings.recordScope' }
119
+ : scope.title,
120
+ ),
121
+ levels: [
122
+ ...(preserved
123
+ ? [
124
+ {
125
+ value,
126
+ label: text({
127
+ key: 'settings.preservedRecordScope',
128
+ }),
129
+ },
130
+ ]
131
+ : []),
132
+ {
133
+ value: '',
134
+ label: text({ key: 'settings.noRecordScope' }),
135
+ },
136
+ ...scope.recordAccess.map((key) => ({
137
+ value: key,
138
+ label: text(
139
+ catalog.recordAccess.find(
140
+ (entry) => entry.key === key,
141
+ )?.title ?? key,
142
+ ),
143
+ })),
144
+ ],
145
+ level: value,
146
+ };
147
+ })
124
148
  : [],
125
149
  };
126
150
  }),
@@ -136,6 +160,11 @@ export function setScope(
136
160
  value: unknown,
137
161
  ): readonly PermissionGrant[] {
138
162
  const [type, id, action, scope] = JSON.parse(rowId) as string[];
163
+ if (
164
+ typeof value === 'string' &&
165
+ scopeSelectionKey(getScopeSelection(grants, rowId)) === value
166
+ )
167
+ return grants;
139
168
  return grants.map((grant) =>
140
169
  grant.resource.type !== type || grant.resource.id !== id
141
170
  ? grant
@@ -216,7 +245,7 @@ function scopeSelectionKey(value: unknown): string {
216
245
  typeof Reflect.get(value, 'key') === 'string'
217
246
  )
218
247
  return String(Reflect.get(value, 'key'));
219
- return '';
248
+ return value == null || value === '' ? '' : '__preserved_scope__';
220
249
  }
221
250
 
222
251
  /** Legacy bare custom-filter keys require configuration before saving. */
package/package.json CHANGED
@@ -1,7 +1,7 @@
1
1
  {
2
2
  "name": "@nocobase/app-template-default",
3
3
  "displayName": "Default Template",
4
- "version": "1.0.0-beta.70",
4
+ "version": "1.0.0-beta.71",
5
5
  "type": "module",
6
6
  "prettier": "@nocobase/dev-config/prettier",
7
7
  "engines": {
@@ -9,7 +9,7 @@
9
9
  },
10
10
  "nocobase": {
11
11
  "templateKind": "app",
12
- "defaultTemplateVersion": "1.0.0-beta.70"
12
+ "defaultTemplateVersion": "1.0.0-beta.71"
13
13
  },
14
14
  "devDependencies": {
15
15
  "@ai-sdk/react": "2.0.0",
@@ -79,13 +79,13 @@
79
79
  "elkjs": "^0.10.2",
80
80
  "@nocobase/app-client": "^3.0.0-beta.2",
81
81
  "@nocobase/app-plugin-template-print": "0.0.2-beta.2",
82
- "@nocobase/app-skills": "0.1.0-beta.38",
82
+ "@nocobase/app-skills": "0.1.0-beta.39",
83
83
  "@nocobase/app-testing": "0.1.0-beta.4",
84
84
  "@nocobase/app-websocket": "^0.0.2-beta.0",
85
85
  "@nocobase/dev-config": "0.1.0-beta.23",
86
- "@nocobase/drive": "^0.1.0-beta.6",
87
- "@nocobase/session": "^0.1.0-beta.3",
88
- "@nocobase/logging": "^0.1.0-beta.7"
86
+ "@nocobase/drive": "^0.1.0-beta.7",
87
+ "@nocobase/logging": "^0.1.0-beta.7",
88
+ "@nocobase/session": "^0.1.0-beta.3"
89
89
  },
90
90
  "files": [
91
91
  ".prettierignore",
@@ -156,7 +156,7 @@
156
156
  "@nocobase/app-plugin-notification-providers": "^0.2.0-beta.12",
157
157
  "@nocobase/app-plugin-scheduler": "^1.0.0-beta.17",
158
158
  "@nocobase/app-plugin-users": "^2.0.0-beta.5",
159
- "@nocobase/app-server": "^2.0.0-beta.8",
159
+ "@nocobase/app-server": "^2.0.0-beta.9",
160
160
  "@nocobase/config": "^0.1.0-beta.3",
161
161
  "@nocobase/db": "^1.0.0-beta.21",
162
162
  "@nocobase/db-sqlite": "^0.1.0-beta.6",
@@ -475,3 +475,65 @@ it('aligns semantic actions across resources without dropping special or filtere
475
475
  view.container.querySelectorAll('[data-slot=permission-row]'),
476
476
  ).toHaveLength(1);
477
477
  });
478
+
479
+ it('keeps scope captions consistent in a category with multiple data ranges, including when filtered', async () => {
480
+ const level = [{ value: 'all', label: 'All records' }];
481
+ render(
482
+ <PermissionEditor
483
+ sections={[
484
+ {
485
+ id: 'business',
486
+ title: 'Business',
487
+ groups: [
488
+ {
489
+ id: 'quotes',
490
+ title: 'Quotes',
491
+ rows: [
492
+ {
493
+ id: 'view',
494
+ label: 'View quotes',
495
+ enabled: true,
496
+ scopes: [
497
+ {
498
+ id: 'view-records',
499
+ label: 'Visible quotes',
500
+ level: 'all',
501
+ levels: level,
502
+ },
503
+ ],
504
+ },
505
+ {
506
+ id: 'submit',
507
+ label: 'Submit quote',
508
+ enabled: true,
509
+ scopes: [
510
+ {
511
+ id: 'submit-projects',
512
+ label: 'Linked projects',
513
+ level: 'all',
514
+ levels: level,
515
+ },
516
+ {
517
+ id: 'submit-quotes',
518
+ label: 'Allowed quotes',
519
+ level: 'all',
520
+ levels: level,
521
+ },
522
+ ],
523
+ },
524
+ ],
525
+ },
526
+ ],
527
+ },
528
+ ]}
529
+ onEnabledChange={vi.fn()}
530
+ onLevelChange={vi.fn()}
531
+ />,
532
+ );
533
+ expect(screen.getByText('Visible quotes')).toBeVisible();
534
+ expect(screen.getByText('Linked projects')).toBeVisible();
535
+ expect(screen.getByText('Allowed quotes')).toBeVisible();
536
+ await userEvent.type(screen.getByRole('textbox'), 'View quotes');
537
+ expect(screen.queryByText('Linked projects')).not.toBeInTheDocument();
538
+ expect(screen.getByText('Visible quotes')).toBeVisible();
539
+ });
@@ -1,6 +1,7 @@
1
1
  import { describe, expect, it } from 'vitest';
2
2
  import {
3
3
  resolveAppClientContributions,
4
+ defineAppRoutes,
4
5
  type AppClientRegisteredRoute,
5
6
  } from '@nocobase/app-client/plugins';
6
7
  import applicationRoutes from '../../client/routes.js';
@@ -70,7 +71,7 @@ describe('page permission labels', () => {
70
71
  expect(names.has(name), `Stale permission title: ${name}`).toBe(true);
71
72
  });
72
73
 
73
- it('preserves the complete application page-resource identity list', () => {
74
+ it('preserves each unique application page-resource identity', () => {
74
75
  const expected = pages.map((route) => {
75
76
  if (typeof route.authz !== 'object')
76
77
  throw new Error('Expected page authorization');
@@ -86,7 +87,9 @@ describe('page permission labels', () => {
86
87
  id,
87
88
  actions: actions.map((action) => action.name),
88
89
  })),
89
- ).toEqual(expected);
90
+ ).toEqual([
91
+ ...new Map(expected.map((resource) => [resource.id, resource])).values(),
92
+ ]);
90
93
  });
91
94
 
92
95
  const fixture = () =>
@@ -221,3 +224,80 @@ describe('page permission labels', () => {
221
224
  ).toEqual([]);
222
225
  });
223
226
  });
227
+
228
+ it('lists inherited and repeated page resources once while retaining independent child grants', () => {
229
+ const input = resolveAppClientContributions([
230
+ {
231
+ packageName: 'shared-pages',
232
+ source: 'application',
233
+ routes: defineAppRoutes([
234
+ {
235
+ name: 'repairs',
236
+ path: '/repairs',
237
+ authz: {
238
+ resource: { type: 'page', id: 'repairs' },
239
+ action: 'access',
240
+ },
241
+ navigation: { title: 'repairs.mine' },
242
+ componentLoader: async () => ({ default: () => null }),
243
+ children: [
244
+ {
245
+ name: 'repairCreate',
246
+ path: 'create',
247
+ componentLoader: async () => ({ default: () => null }),
248
+ },
249
+ {
250
+ name: 'repairDetail',
251
+ path: ':id',
252
+ componentLoader: async () => ({ default: () => null }),
253
+ children: [
254
+ {
255
+ name: 'repairConfirm',
256
+ path: 'confirm',
257
+ componentLoader: async () => ({ default: () => null }),
258
+ },
259
+ ],
260
+ },
261
+ {
262
+ name: 'repairAudit',
263
+ path: 'audit',
264
+ authz: {
265
+ resource: { type: 'page', id: 'repair-audit' },
266
+ action: 'access',
267
+ },
268
+ navigation: { title: 'repairs.audit' },
269
+ componentLoader: async () => ({ default: () => null }),
270
+ },
271
+ ],
272
+ },
273
+ {
274
+ name: 'repairsAlias',
275
+ path: '/repairs-alias',
276
+ authz: {
277
+ resource: { type: 'page', id: 'repairs' },
278
+ action: 'access',
279
+ },
280
+ componentLoader: async () => ({ default: () => null }),
281
+ },
282
+ ]),
283
+ },
284
+ ]);
285
+ const before = flatten(input.routes).map(({ id, name, authz }) => ({
286
+ id,
287
+ name,
288
+ authz,
289
+ }));
290
+ const result = pagePermissionResources(
291
+ input.routes,
292
+ {},
293
+ (path) => `Unnamed (${path})`,
294
+ );
295
+ expect(result.map(({ id }) => id)).toEqual(['repairs', 'repair-audit']);
296
+ expect(result[0]!.title).toEqual({ key: 'repairs.mine', ns: 'shared-pages' });
297
+ expect(
298
+ flatten(input.routes).map(({ id, name, authz }) => ({ id, name, authz })),
299
+ ).toEqual(before);
300
+ expect(
301
+ pagePermissionResources(input.routes, {}, (path) => `Unnamed (${path})`),
302
+ ).toEqual(result);
303
+ });
@@ -166,3 +166,80 @@ it('replaces a raw collection scope caption with localized data-range text', ()
166
166
  'Record scope',
167
167
  );
168
168
  });
169
+
170
+ it('preserves an existing policy when enabling the same permission again', () => {
171
+ const original = [
172
+ {
173
+ resource: { type: 'composite', id: 'orders' },
174
+ actions: [
175
+ {
176
+ action: 'edit',
177
+ policy: {
178
+ type: 'composite',
179
+ scopes: {
180
+ records: {
181
+ type: 'recordAccess',
182
+ key: 'mine',
183
+ params: { ownerField: 'assignee' },
184
+ },
185
+ },
186
+ extra: true,
187
+ },
188
+ },
189
+ ],
190
+ },
191
+ ];
192
+ expect(setPermission(original, resource, 'edit', true)).toBe(original);
193
+ expect(
194
+ setScope(
195
+ original,
196
+ JSON.stringify(['composite', 'orders', 'edit', 'records']),
197
+ 'mine',
198
+ ),
199
+ ).toBe(original);
200
+ });
201
+
202
+ it.each(['retiredScope', { type: 'legacyPolicy', filter: { owner: 'me' } }])(
203
+ 'shows a preserved selection for an unrecognized scope without rewriting it: %j',
204
+ (value) => {
205
+ const catalog = {
206
+ sections: [
207
+ {
208
+ name: 'business',
209
+ title: 'Business',
210
+ subsections: [
211
+ { name: 'orders', title: 'Orders', resources: [resource] },
212
+ ],
213
+ },
214
+ ],
215
+ recordAccess: [
216
+ { key: 'mine', title: 'Mine' },
217
+ { key: 'all', title: 'All' },
218
+ ],
219
+ } as unknown as Parameters<typeof permissionSections>[0];
220
+ const original = [
221
+ {
222
+ resource: { type: 'composite', id: 'orders' },
223
+ actions: [
224
+ {
225
+ action: 'edit',
226
+ policy: { type: 'composite', scopes: { records: value } },
227
+ },
228
+ ],
229
+ },
230
+ ];
231
+ const before = JSON.stringify(original);
232
+ const sections = permissionSections(catalog, original, (text) =>
233
+ typeof text === 'string' ? text : text.key,
234
+ );
235
+ const scope = sections[0]!.groups[0]!.rows[0]!.scopes![0]!;
236
+ expect(
237
+ scope.levels.find((level) => level.value === scope.level)?.label,
238
+ ).toBe('settings.preservedRecordScope');
239
+ expect(setScope(original, scope.id, scope.level!)).toBe(original);
240
+ expect(JSON.stringify(original)).toBe(before);
241
+ expect(
242
+ setScope(original, scope.id, 'all')[0]!.actions[0]!.policy!.scopes,
243
+ ).toEqual({ records: 'all' });
244
+ },
245
+ );