@nocobase/app-template-default 1.0.0-beta.57 → 1.0.0-beta.59

package/tests/logic/dev-routes-production-build.test.ts

@@ -1,168 +0,0 @@
-// @vitest-environment node
-// Vite's esbuild dependency asserts that `new TextEncoder().encode('')` yields a real Uint8Array, which jsdom's
-// globals break. This file drives an actual production build, so it runs under Node rather than the shared jsdom
-// environment the React tests use.
-import {
-  mkdtemp,
-  mkdir,
-  readFile,
-  readdir,
-  rm,
-  writeFile,
-} from 'node:fs/promises';
-import { readFileSync } from 'node:fs';
-import { findPackageJSON } from 'node:module';
-import { tmpdir } from 'node:os';
-import path from 'node:path';
-import { build } from 'vite';
-import { afterAll, beforeAll, describe, expect, it } from 'vitest';
-
-/**
- * The guarantee under test is a build-time one: nothing a plugin declares through `defineDevRoutes()` may reach a
- * production bundle. A unit test cannot show that — only a real production build can, because the guarantee comes
- * from Vite replacing `import.meta.env.PROD` with `true` and then dropping the branch that becomes unreachable.
- *
- * The fixture builds against the real `@nocobase/app-client` helpers rather than a stand-in, so the test fails if the
- * guard inside `defineDevRoutes()` is ever weakened.
- */
-
-const appClientPackagePath = findPackageJSON(
-  '@nocobase/app-client',
-  import.meta.url,
-);
-if (!appClientPackagePath) {
-  throw new Error('Cannot resolve @nocobase/app-client/package.json');
-}
-const appClientPackage = JSON.parse(
-  readFileSync(appClientPackagePath, 'utf8'),
-) as { exports?: { './plugins'?: { import?: string } } };
-const appClientPluginsExport = appClientPackage.exports?.['./plugins']?.import;
-if (!appClientPluginsExport) {
-  throw new Error('@nocobase/app-client does not export ./plugins');
-}
-const appClientPlugins = path.resolve(
-  path.dirname(appClientPackagePath),
-  appClientPluginsExport,
-);
-
-const DEV_PAGE_MARKER = 'dev_page_marker_a7f3c1';
-const DEV_ONLY_DEPENDENCY_MARKER = 'dev_only_dependency_marker_a7f3c1';
-const SETTINGS_PAGE_MARKER = 'settings_page_marker_a7f3c1';
-
-let workspace: string;
-let bundle: string;
-
-async function readBundle(outputDirectory: string): Promise<string> {
-  const entries = await readdir(outputDirectory, {
-    recursive: true,
-    withFileTypes: true,
-  });
-  const files = entries.filter((entry) => entry.isFile());
-  const contents = await Promise.all(
-    files.map((entry) =>
-      readFile(path.join(entry.parentPath, entry.name), 'utf8'),
-    ),
-  );
-  return contents.join('\n');
-}
-
-beforeAll(async () => {
-  workspace = await mkdtemp(path.join(tmpdir(), 'nocobase-dev-routes-'));
-  const source = path.join(workspace, 'src');
-  await mkdir(source, { recursive: true });
-
-  await writeFile(
-    path.join(source, 'dev-only-dependency.ts'),
-    `export const devOnlyDependency = '${DEV_ONLY_DEPENDENCY_MARKER}';\n`,
-  );
-  await writeFile(
-    path.join(source, 'dev-page.tsx'),
-    `import { devOnlyDependency } from './dev-only-dependency.js';\n\n` +
-      `export default function DevPage() {\n` +
-      `  return '${DEV_PAGE_MARKER}' + devOnlyDependency;\n` +
-      `}\n`,
-  );
-  await writeFile(
-    path.join(source, 'settings-page.tsx'),
-    `export default function SettingsPage() {\n` +
-      `  return '${SETTINGS_PAGE_MARKER}';\n` +
-      `}\n`,
-  );
-  // The entry mirrors how a plugin declares both surfaces side by side, so the settings page acts as the control: it
-  // must survive exactly the build that drops the dev page.
-  await writeFile(
-    path.join(source, 'main.ts'),
-    `import { defineDevRoutes, defineSettingsRoutes } from '@nocobase/app-client/plugins';\n\n` +
-      `const routes = [\n` +
-      `  defineSettingsRoutes([\n` +
-      `    {\n` +
-      `      name: 'settings-page',\n` +
-      `      path: '/settings-page',\n` +
-      `      navigation: { title: 'Settings page' },\n` +
-      `      componentLoader: () => import('./settings-page.js'),\n` +
-      `    },\n` +
-      `  ]),\n` +
-      `  defineDevRoutes([\n` +
-      `    {\n` +
-      `      name: 'dev-page',\n` +
-      `      path: '/dev-page',\n` +
-      `      navigation: { title: 'Dev page' },\n` +
-      `      componentLoader: () => import('./dev-page.js'),\n` +
-      `    },\n` +
-      `  ]),\n` +
-      `];\n\n` +
-      `globalThis.__routes = routes;\n`,
-  );
-
-  // Vite decides `import.meta.env.PROD` from NODE_ENV, not from the build mode. Vitest sets NODE_ENV=test, under
-  // which Vite treats even `mode: 'production'` as a non-production build and leaves the dev branch in place — so the
-  // variable has to be set for the duration of the build, or this test would assert against a development bundle.
-  const previousNodeEnv = process.env.NODE_ENV;
-  process.env.NODE_ENV = 'production';
-  try {
-    await build({
-      root: workspace,
-      logLevel: 'silent',
-      resolve: {
-        alias: [
-          {
-            find: '@nocobase/app-client/plugins',
-            replacement: appClientPlugins,
-          },
-        ],
-      },
-      build: {
-        outDir: 'dist',
-        rollupOptions: { input: path.join(source, 'main.ts') },
-      },
-    });
-  } finally {
-    if (previousNodeEnv === undefined) {
-      delete process.env.NODE_ENV;
-    } else {
-      process.env.NODE_ENV = previousNodeEnv;
-    }
-  }
-
-  bundle = await readBundle(path.join(workspace, 'dist'));
-}, 120_000);
-
-afterAll(async () => {
-  if (workspace) {
-    await rm(workspace, { recursive: true, force: true });
-  }
-});
-
-describe('dev routes in a production build', () => {
-  it('builds the settings page that acts as the control', () => {
-    expect(bundle).toContain(SETTINGS_PAGE_MARKER);
-  });
-
-  it('drops the dev page component', () => {
-    expect(bundle).not.toContain(DEV_PAGE_MARKER);
-  });
-
-  it('drops a module only a dev page imports', () => {
-    expect(bundle).not.toContain(DEV_ONLY_DEPENDENCY_MARKER);
-  });
-});

package/tests/logic/plugin-page-authz.test.ts

@@ -1,76 +0,0 @@
-// @vitest-environment node
-
-import {
-  resolveAppClientContributions,
-  type AppClientRegisteredRoute,
-} from '@nocobase/app-client/plugins';
-import { describe, expect, it } from 'vitest';
-
-import clientPlugins from '../../client/plugins.js';
-
-// The plugins whose pages the permission workspace offers as page grants. The AI employee settings are granted under
-// System management instead, one settings item per page.
-const PAGE_GRANT_PLUGINS = [
-  '@nocobase/app-plugin-users',
-  '@nocobase/app-plugin-notification',
-  '@nocobase/app-plugin-api-keys',
-  '@nocobase/app-plugin-database-explorer',
-];
-
-describe('plugin page authorization', () => {
-  it('offers a page grant for each listed plugin', () => {
-    const resolved = resolveAppClientContributions(
-      clientPlugins.plugins.map((plugin) => ({
-        packageName: plugin.packageName,
-        source: 'plugin' as const,
-        routes: plugin.routes,
-      })),
-    );
-    const pages = entryPages([
-      ...resolved.routes,
-      ...resolved.settingsRouteTree,
-    ]).filter((route) => PAGE_GRANT_PLUGINS.includes(route.packageName));
-
-    // A page may check another resource type; each plugin still offers a page grant.
-    const granted = pages.filter(
-      (route) =>
-        typeof route.authz === 'object' &&
-        route.authz.resource.type === 'page' &&
-        route.authz.action === 'access',
-    );
-    expect(new Set(granted.map((route) => route.packageName))).toEqual(
-      new Set(PAGE_GRANT_PLUGINS),
-    );
-  });
-
-  it('checks a System management settings item on every AI employee settings page', () => {
-    const resolved = resolveAppClientContributions(
-      clientPlugins.plugins.map((plugin) => ({
-        packageName: plugin.packageName,
-        source: 'plugin' as const,
-        routes: plugin.routes,
-      })),
-    );
-    const pages = entryPages(resolved.settingsRouteTree).filter(
-      (route) => route.packageName === '@nocobase/app-plugin-ai-employee',
-    );
-    expect(pages.length).toBeGreaterThan(0);
-    for (const page of pages)
-      expect({ id: page.id, authz: page.authz }).toMatchObject({
-        id: page.id,
-        authz: {
-          resource: { type: 'settings', id: expect.stringMatching(/^ai\./) },
-          action: 'read',
-        },
-      });
-  });
-});
-
-/** Pages without a page above them: nested pages share their parent's check. */
-function entryPages(
-  routes: readonly AppClientRegisteredRoute[],
-): AppClientRegisteredRoute[] {
-  return routes.flatMap((route) =>
-    route.componentLoader ? [route] : entryPages(route.children ?? []),
-  );
-}