@nockchain/rose 0.1.4-nightly.5 → 0.1.4-nightly.6

package/PROVIDER_COMPATIBILITY.md

@@ -0,0 +1,141 @@
+# Provider Compatibility Guide
+
+Rose wallet implements [EIP-6963: Multi Injected Provider Discovery](https://eips.ethereum.org/EIPS/eip-6963) for multi-wallet support.
+
+## Quick Start
+
+```typescript
+import { NockchainProvider } from '@nockchain/sdk';
+
+// Simple approach
+const nockchain = new NockchainProvider();
+await nockchain.connect();
+
+// Wait for provider (recommended)
+const found = await NockchainProvider.waitForInstallation(3000);
+if (found) {
+  const nockchain = new NockchainProvider();
+  await nockchain.connect();
+}
+```
+
+## How It Works
+
+Rose uses **EIP-6963 events** instead of global namespaces:
+
+1. Rose announces itself via `eip6963:announceProvider` event
+2. dApps request providers via `eip6963:requestProvider` event
+3. No `window.nockchain` pollution - pure event-based discovery
+
+**Benefits:**
+
+- ✅ No race conditions or namespace collisions
+- ✅ Multiple wallets coexist peacefully
+- ✅ Industry standard (Ethereum EIP-6963)
+
+## Discovery Methods
+
+```typescript
+// Check if installed (synchronous)
+if (NockchainProvider.isInstalled()) {
+  const nockchain = new NockchainProvider();
+}
+
+// Wait for provider (async, handles race conditions)
+const found = await NockchainProvider.waitForInstallation(3000);
+
+// Discover all providers
+const providers = NockchainProvider.discoverProviders();
+providers.forEach(({ info, provider }) => {
+  console.log(info.name, info.rdns);
+});
+```
+
+## Manual Event Listening
+
+```typescript
+window.addEventListener('eip6963:announceProvider', event => {
+  const { info, provider } = event.detail;
+  if (info.rdns === 'net.nockchain.rose') {
+    // Use Rose provider
+  }
+});
+
+window.dispatchEvent(new Event('eip6963:requestProvider'));
+```
+
+## Building a Wallet Extension
+
+```typescript
+// Your inpage script
+class YourProvider {
+  request(args) {
+    /* EIP-1193 implementation */
+  }
+}
+
+const provider = new YourProvider();
+Object.freeze(provider);
+
+const info = {
+  uuid: crypto.randomUUID(),
+  name: 'Your Wallet',
+  icon: 'data:image/svg+xml,...', // 96x96px
+  rdns: 'com.example.wallet',
+};
+
+function announceProvider() {
+  window.dispatchEvent(
+    new CustomEvent('eip6963:announceProvider', {
+      detail: Object.freeze({ info, provider }),
+    })
+  );
+}
+
+announceProvider();
+window.addEventListener('eip6963:requestProvider', announceProvider);
+```
+
+## Complete Example
+
+```typescript
+import { NockchainProvider, WalletNotInstalledError } from '@nockchain/sdk';
+
+async function connectWallet() {
+  try {
+    const found = await NockchainProvider.waitForInstallation(3000);
+    if (!found) {
+      alert('Please install Rose wallet');
+      return;
+    }
+
+    const nockchain = new NockchainProvider();
+    const { pkh } = await nockchain.connect();
+
+    const tx = nockchain.transaction().to('recipient_address').amount(1_000_000).build();
+
+    const txId = await nockchain.sendTransaction(tx);
+    console.log('Transaction sent:', txId);
+  } catch (error) {
+    console.error('Connection failed:', error);
+  }
+}
+```
+
+## Troubleshooting
+
+**Provider not found?**
+
+- Ensure Rose extension is installed and enabled
+- Refresh the page after installing/reloading extension
+- Use `waitForInstallation()` for race conditions
+
+**After extension reload:**
+
+- Always refresh the dApp page
+- Inpage script only injects once per page load
+
+## Resources
+
+- [EIP-6963 Specification](https://eips.ethereum.org/EIPS/eip-6963)
+- [Nockchain Documentation](https://nockchain.org)

package/extension/inpage/index.ts

@@ -1,6 +1,7 @@
 /**
  * Inpage Provider: Injected into web pages
- * Exposes window.nockchain with EIP-1193-style API
+ * Implements EIP-6963 Multi Injected Provider Discovery
+ * and EIP-1193 Provider API
  *
  * NOTE: This file runs in the MAIN world and cannot use any imports or Chrome APIs
  */
@@ -11,12 +12,33 @@ import { version } from '../../package.json';
 // Inline constant to avoid imports
 const MESSAGE_TARGET = 'ROSE';
 
+// EIP-6963 types (inline to avoid circular dependencies)
+interface EIP6963ProviderInfo {
+  uuid: string;
+  name: string;
+  icon: string;
+  rdns: string;
+}
+
+interface EIP6963ProviderDetail {
+  info: EIP6963ProviderInfo;
+  provider: InjectedNockchain;
+}
+
+// EIP-6963 Provider Info for Rose Wallet
+const PROVIDER_INFO: EIP6963ProviderInfo = {
+  uuid: '350670db-19fa-4704-a166-e52e178b59d2',
+  name: 'Rose',
+  icon: 'data:image/svg+xml,%3Csvg version="1.2" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 2120 2120" width="96" height="96"%3E%3Cstyle%3E.s0%7Bfill:%23ec1e24%7D.s1%7Bfill:%23e51d25%7D.s2%7Bfill:%230f8945%7D.s3%7Bfill:%230a7e40%7D%3C/style%3E%3Cg id="Layer 1"%3E%3Cg%3E%3Cpath class="s0" d="m1141.12 574.61l-85.01 53.22c-20.3 10.36-40.1 22.84-60.16 30.45-49.08 18.59-96.03 40.49-147.89 59.18-54.93 18.09-54.19 13.65-66.34 49.66-6.4 17.8-18.35 39.63-17.9 58.38-12.06 66.85-20.4 114.97 3.28 189.1 2.69 8.89 3.96 14.2 8.36 19.43 2.58 6.12 7.4 14.5 10.07 19.59l14.59 23.44c4.02 5.55 3.11 4.08 6.38 10.26 2.99 5.45 4.22 7.29 8.61 12.53 25.19 33.02 7.94 56.12 129.82 68.81 61.46 6.39 80.86 6.35 136.09-7.21 8.64-3.75 15.56-7.65 25.89-10.91 9.99-3.29 16.25-7.59 25.64-11.97 40.4-18.31 72.77-51.87 100.64-85.47 22.49-27.49 69.69-96.14 83.16-127.53 3.94-9.36 3.95-13.51 8.57-22.81 40.75-82.03 73.22-220.2 71.51-315.97-0.38-35.37-1.11-62.81-4.49-95.67-1.3-12.93-4.7-29.51-7.89-44.68l-0.38-3.5q-0.68-4.22-1.53-6.37c-1.46-7.06-9.65-40.34-7.8-45.72-1.49-6.71-0.26-20.81-16.5-9.4-9.48 5.41-71.09 72.45-90.28 89.84-45.75 40.01-84.95 68.47-126.44 103.32z"/%3E%3Cpath class="s2" d="m1113.77 1171.23l-24.83 10.66c-1.68 19.26 8.4 22.9 21.15 31.64 3.26 2.36 33.95 19.93 36.3 20.83 11.39 4.45 37.71 8.48 51.06 10.33 38.19-0.83 113.88 1.25 147.03 10.38 3.38 0.98 29.68 13.32 32.28 15.28 3.29 2.02 17.7 19.56 30.35 9.57 17.75-48.69-51.06-113.92-76.47-132.42-36.48-26.73-82.55-54.65-107.35-44.34-14.36 5.68-76.04 53.67-109.52 68.07z"/%3E%3Cpath class="s3" d="m985.44 1204.75q31.91-2.42 63.82-4.83c152.67 562.41-158.23 1208.49-279.97 1584.18-47.44-16.26-63.24-21.79-110.67-38.04 147.3-327.05 482.61-955.06 326.82-1541.31z"/%3E%3C/g%3E%3C/g%3E%3C/svg%3E',
+  rdns: 'net.nockchain.rose',
+};
+
 class NockchainProvider implements InjectedNockchain {
   name: string = 'rose';
   version: string = version;
 
   /**
-   * Make a request to the wallet
+   * Make a request to the wallet (EIP-1193 compatible)
    * @param args - Request arguments with method and params
    */
   request<T = unknown>(args: RpcRequest): Promise<T> {
@@ -70,17 +92,32 @@ class NockchainProvider implements InjectedNockchain {
   }
 }
 
-// Inject provider into window
+// Create the provider instance
 const provider = new NockchainProvider();
-const globalNockchain = (window as any).nockchain ?? {};
-globalNockchain.providers = Array.isArray(globalNockchain.providers)
-  ? globalNockchain.providers
-  : [];
-if (!globalNockchain.providers.some((p: { name: string }) => p.name === provider.name)) {
-  globalNockchain.providers.push(provider);
+
+// Freeze the provider to prevent tampering (EIP-6963 recommendation)
+Object.freeze(provider);
+
+/**
+ * Announce the Rose provider using EIP-6963 events
+ */
+function announceProvider() {
+  const detail: EIP6963ProviderDetail = Object.freeze({
+    info: PROVIDER_INFO,
+    provider: provider,
+  });
+
+  window.dispatchEvent(
+    new CustomEvent('eip6963:announceProvider', {
+      detail,
+    })
+  );
 }
-// Preserve existing global while registering this provider
-(window as any).nockchain = globalNockchain;
 
-// Announce provider availability
-window.dispatchEvent(new Event(`nockchain_${provider.name}#initialized`));
+// Announce immediately on load
+announceProvider();
+
+// Listen for provider requests and re-announce (EIP-6963 pattern)
+window.addEventListener('eip6963:requestProvider', () => {
+  announceProvider();
+});

package/extension/manifest.json

@@ -2,7 +2,7 @@
   "manifest_version": 3,
   "name": "Rose Wallet",
   "homepage_url": "https://nockchain.net",
-  "version": "0.1.4.5",
+  "version": "0.1.4.6",
   "description": "Rose Wallet - Browser Wallet for Nockchain",
   "icons": {
     "16": "icons/rose16.png",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nockchain/rose",
-  "version": "0.1.4-nightly.5",
+  "version": "0.1.4-nightly.6",
   "description": "Rose - Chrome Wallet Extension for Nockchain",
   "type": "module",
   "scripts": {
@@ -14,7 +14,7 @@
   "dependencies": {
     "@fontsource/inter": "5.2.8",
     "@fontsource/lora": "5.2.8",
-    "@nockchain/sdk": "0.1.4-nightly.5",
+    "@nockchain/sdk": "0.1.4-nightly.6",
     "@scure/base": "2.0.0",
     "@scure/bip39": "2.0.1",
     "react": "19.2.3",

package/sdk/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@nockchain/sdk",
-  "version": "0.1.4-nightly.5",
+  "version": "0.1.4-nightly.6",
   "description": "TypeScript SDK for interacting with Nockchain wallet extensions",
   "type": "module",
   "main": "./dist/index.js",

package/sdk/src/provider.ts

@@ -1,8 +1,16 @@
 /**
  * NockchainProvider - Main SDK class for interacting with Rose wallet
+ * Supports EIP-6963 Multi Injected Provider Discovery
  */
 
-import type { Transaction, NockchainEvent, EventListener, InjectedNockchain } from './types.js';
+import type {
+  Transaction,
+  NockchainEvent,
+  EventListener,
+  InjectedNockchain,
+  EIP6963ProviderDetail,
+  EIP6963AnnounceProviderEvent,
+} from './types.js';
 import { TransactionBuilder } from './transaction.js';
 import { WalletNotInstalledError, UserRejectedError, RpcError, NoAccountError } from './errors.js';
 import { PROVIDER_METHODS } from './constants.js';
@@ -42,19 +50,14 @@ export class NockchainProvider {
       throw new Error('NockchainProvider can only be used in a browser environment');
     }
 
-    // Verify Rose extension is installed and authentic
-    if (!NockchainProvider.isInstalled()) {
-      throw new WalletNotInstalledError();
-    }
-
-    const injected = window.nockchain;
+    // Discover Rose provider using EIP-6963
+    const eip6963Provider = NockchainProvider.discoverEIP6963Provider();
 
-    // TODO: remove this duplicate check
-    if (!injected) {
+    if (!eip6963Provider) {
       throw new WalletNotInstalledError();
     }
 
-    this.injected = injected;
+    this.injected = eip6963Provider;
     this.eventListeners = new Map();
 
     // Initialize event listeners for wallet events
@@ -381,16 +384,126 @@ export class NockchainProvider {
     }
   }
 
+  /**
+   * Discover Rose provider using EIP-6963 (preferred method)
+   * @returns The Rose provider if found, null otherwise
+   * @private
+   */
+  private static discoverEIP6963Provider(): InjectedNockchain | null {
+    if (typeof window === 'undefined') {
+      return null;
+    }
+
+    let roseProvider: InjectedNockchain | null = null;
+
+    // Synchronous event listener - must be added before dispatching
+    const handler = (event: Event) => {
+      const announceEvent = event as EIP6963AnnounceProviderEvent;
+      if (announceEvent.detail?.info?.rdns === 'net.nockchain.rose') {
+        roseProvider = announceEvent.detail.provider;
+      }
+    };
+
+    // Add listener synchronously
+    window.addEventListener('eip6963:announceProvider', handler);
+
+    // Request providers to announce themselves
+    // Providers that are already loaded will respond synchronously
+    window.dispatchEvent(new Event('eip6963:requestProvider'));
+
+    // Clean up listener immediately (synchronous announcements already happened)
+    window.removeEventListener('eip6963:announceProvider', handler);
+
+    return roseProvider;
+  }
+
+  /**
+   * Discover all available Nockchain providers using EIP-6963
+   * @returns Array of provider details
+   */
+  static discoverProviders(): EIP6963ProviderDetail[] {
+    if (typeof window === 'undefined') {
+      return [];
+    }
+
+    const providers: EIP6963ProviderDetail[] = [];
+
+    const handler = (event: Event) => {
+      const announceEvent = event as EIP6963AnnounceProviderEvent;
+      if (announceEvent.detail) {
+        providers.push(announceEvent.detail);
+      }
+    };
+
+    window.addEventListener('eip6963:announceProvider', handler);
+    window.dispatchEvent(new Event('eip6963:requestProvider'));
+    window.removeEventListener('eip6963:announceProvider', handler);
+
+    return providers;
+  }
+
   /**
    * Check if the Rose extension is installed and authentic
-   * @returns true if the extension is installed
+   * Uses EIP-6963 discovery (synchronous check)
+   *
+   * Note: This performs synchronous discovery which only works if the provider
+   * has already announced itself. For async discovery, use waitForInstallation().
+   *
+   * @returns true if the extension is installed and has announced itself
    */
   static isInstalled(): boolean {
-    if (typeof window === 'undefined' || !window.nockchain?.providers) {
+    if (typeof window === 'undefined') {
       return false;
     }
-    return window.nockchain.providers.some(
-      (provider: { name?: string }) => provider && provider.name === 'rose'
-    );
+
+    const eip6963Provider = NockchainProvider.discoverEIP6963Provider();
+    return eip6963Provider !== null;
+  }
+
+  /**
+   * Wait for the Rose extension to be available
+   * Useful if the extension might load after your script
+   * Uses EIP-6963 discovery
+   * @param timeout - Maximum time to wait in milliseconds (default: 3000)
+   * @returns Promise that resolves to true if found, false if timeout
+   */
+  static async waitForInstallation(timeout = 3000): Promise<boolean> {
+    if (NockchainProvider.isInstalled()) {
+      return true;
+    }
+
+    return new Promise(resolve => {
+      const startTime = Date.now();
+      let resolved = false;
+
+      const checkAndResolve = (found: boolean) => {
+        if (!resolved) {
+          resolved = true;
+          clearInterval(checkInterval);
+          window.removeEventListener('eip6963:announceProvider', eip6963Handler);
+          resolve(found);
+        }
+      };
+
+      const checkInterval = setInterval(() => {
+        if (NockchainProvider.isInstalled()) {
+          checkAndResolve(true);
+        } else if (Date.now() - startTime > timeout) {
+          checkAndResolve(false);
+        }
+      }, 100);
+
+      // Listen for EIP-6963 announcements
+      const eip6963Handler = (event: Event) => {
+        const announceEvent = event as EIP6963AnnounceProviderEvent;
+        if (announceEvent.detail?.info?.rdns === 'net.nockchain.rose') {
+          checkAndResolve(true);
+        }
+      };
+      window.addEventListener('eip6963:announceProvider', eip6963Handler);
+
+      // Request providers to announce themselves
+      window.dispatchEvent(new Event('eip6963:requestProvider'));
+    });
   }
 }

package/sdk/src/types.ts

@@ -51,7 +51,7 @@ export type NockchainEvent = 'accountsChanged' | 'chainChanged' | 'connect' | 'd
 export type EventListener<T = unknown> = (data: T) => void;
 
 /**
- * Interface for the injected window.nockchain object
+ * Interface for the injected window.nockchain object (EIP-1193 compatible)
  */
 export interface InjectedNockchain {
   /**
@@ -62,18 +62,53 @@ export interface InjectedNockchain {
   request<T = unknown>(request: RpcRequest): Promise<T>;
 
   /**
-   * Provider names and versions (e.g., 'rose', 'iris')
+   * Provider name (e.g., 'rose', 'iris')
    */
-  providers?: { name: string; version: string }[];
+  name?: string;
+
+  /**
+   * Provider version
+   */
+  version?: string;
+}
+
+/**
+ * EIP-6963 Provider Info
+ * Metadata about the wallet provider
+ */
+export interface EIP6963ProviderInfo {
+  /** Globally unique identifier (UUIDv4) */
+  uuid: string;
+  /** Human-readable name of the wallet */
+  name: string;
+  /** Data URI for the wallet icon (96x96px minimum) */
+  icon: string;
+  /** Reverse DNS identifier (e.g., 'net.nockchain.rose') */
+  rdns: string;
+}
+
+/**
+ * EIP-6963 Provider Detail
+ * Combined provider info and EIP-1193 provider
+ */
+export interface EIP6963ProviderDetail {
+  info: EIP6963ProviderInfo;
+  provider: InjectedNockchain;
+}
+
+/**
+ * EIP-6963 Announce Provider Event
+ */
+export interface EIP6963AnnounceProviderEvent extends CustomEvent {
+  type: 'eip6963:announceProvider';
+  detail: EIP6963ProviderDetail;
 }
 
 /**
- * Extended Window interface with nockchain property
+ * EIP-6963 Request Provider Event
  */
-declare global {
-  interface Window {
-    nockchain?: InjectedNockchain;
-  }
+export interface EIP6963RequestProviderEvent extends Event {
+  type: 'eip6963:requestProvider';
 }
 
 /**