@nmzpy/pi-ember-stack 0.1.6 → 0.2.2

package/README.md

@@ -1,91 +1,91 @@
-# pi-ember-stack
-
-The Ember-owned pi package. It installs the complete Ember agent workflow as
-one package:
-
-- Primary modes: `/coder`, `/architect`, `/doctor`, `/orchestrator`, and
-  `/ui-doctor`.
-- Inline `questionnaire` UI for decision-oriented questions. Agents are told to
-  prefer it when they need a user choice.
-- A compact native `edit` renderer that shows the filename and a single
-  `+N / -N` result row.
-- Vendored subagent support with bundled `coder` and `architect` definitions,
-  plus the upstream bundled roles.
-- Bundled Devin auth/provider support, including OAuth, model catalog refresh,
-  and streaming transport.
-- A self-contained `Ctrl+Space` mode-cycle shortcut and a footer showing the
-  active mode, model, and thinking variant.
-
-## Plugin registry
-
-The package has one top-level pi extension which dispatches to the internal
-plugins under `plugins/`. Ember projects enable them in `.pi/ember-stack.json`:
-
-```json
-{
+# pi-ember-stack
+
+The Ember-owned pi package. It installs the complete Ember agent workflow as
+one package:
+
+- Primary modes: `/coder`, `/architect`, `/doctor`, `/orchestrator`, and
+  `/ui-doctor`.
+- Inline `questionnaire` UI for decision-oriented questions. Agents are told to
+  prefer it when they need a user choice.
+- A compact native `edit` renderer that shows the filename and a single
+  `+N / -N` result row.
+- Vendored subagent support with bundled `coder` and `architect` definitions,
+  plus the upstream bundled roles.
+- Bundled Devin auth/provider support, including OAuth, model catalog refresh,
+  and streaming transport.
+- A self-contained `Ctrl+Space` mode-cycle shortcut and a footer showing the
+  active mode, model, and thinking variant.
+
+## Plugin registry
+
+The package has one top-level pi extension which dispatches to the internal
+plugins under `plugins/`. Ember projects enable them in `.pi/ember-stack.json`:
+
+```json
+{
   "plugins": ["pi-compact-tools", "pi-custom-agents", "devin-auth"]
-}
-```
-
-Remove a plugin ID to disable it, or use `/stack-plugins` to toggle one from
-the TUI. Restart pi after changing the list. The available plugins are:
-
+}
+```
+
+Remove a plugin ID to disable it, or use `/stack-plugins` to toggle one from
+the TUI. Restart pi after changing the list. The available plugins are:
+
 - `pi-compact-tools`: collapsed native edit rendering.
 - `pi-custom-agents`: questionnaire UI, primary modes, plans, subagent tool, and bundled agent definitions.
-- `devin-auth`: Devin provider, OAuth, catalog refresh, and streaming.
-
-## Project setup
-
-The Ember repository contains a project-local `.pi/settings.json` entry for:
-
-```json
+- `devin-auth`: Devin provider, OAuth, catalog refresh, and streaming.
+
+## Project setup
+
+The Ember repository contains a project-local `.pi/settings.json` entry for:
+
+```json
 "npm:@nmzpy/pi-ember-stack@0.1.6"
-```
-
-On a new clone, start pi from the project directory. Pi will ask for a
-one-time project trust decision before it installs the package into the
-project-local `.pi/npm/` directory. The same decision can be approved
-non-interactively with:
-
-```text
-pi --approve
-```
-
-Project trust is intentionally a user decision; a repository cannot safely
-bypass it. After trust, normal startup is just `pi` from the Ember directory.
-
-When a new version is intentionally released, update the pinned version in
-the project settings and run:
-
-```text
-pi update --extensions
-```
-
-Third-party utilities such as pi-fff and image paste remain separate package
-entries. Devin auth is now bundled as a stack plugin, but credentials and
-provider secrets stay in the machine-local pi configuration and are not part
-of this repository.
-
-## Development
-
+```
+
+On a new clone, start pi from the project directory. Pi will ask for a
+one-time project trust decision before it installs the package into the
+project-local `.pi/npm/` directory. The same decision can be approved
+non-interactively with:
+
+```text
+pi --approve
+```
+
+Project trust is intentionally a user decision; a repository cannot safely
+bypass it. After trust, normal startup is just `pi` from the Ember directory.
+
+When a new version is intentionally released, update the pinned version in
+the project settings and run:
+
+```text
+pi update --extensions
+```
+
+Third-party utilities such as pi-fff and image paste remain separate package
+entries. Devin auth is now bundled as a stack plugin, but credentials and
+provider secrets stay in the machine-local pi configuration and are not part
+of this repository.
+
+## Development
+
 The package entrypoint is `plugins/index.ts`. Compact tools are under
 `plugins/pi-compact-tools/`, while questionnaire, primary modes, plans,
 subagents, and bundled agents are under `plugins/pi-custom-agents/`. Devin auth
 is under `plugins/devin-auth/`.
-
-Run the package typecheck with:
-
-```text
-npm install
-npm run typecheck
-```
-
-## Release
-
-Run `./gacp.sh --release` to bump the patch version, typecheck, commit, tag,
-push, and publish the package to npm. This only publishes the package; update
-Ember's pinned package version separately when you want the project to install it.
-
-The package is cross-platform: bundled paths are resolved from `import.meta.url`
-and do not depend on a Windows home directory or the current working
-directory.
+
+Run the package typecheck with:
+
+```text
+npm install
+npm run typecheck
+```
+
+## Release
+
+Run `./gacp.sh --release` to bump the patch version, typecheck, commit, tag,
+push, and publish the package to npm. This only publishes the package; update
+Ember's pinned package version separately when you want the project to install it.
+
+The package is cross-platform: bundled paths are resolved from `import.meta.url`
+and do not depend on a Windows home directory or the current working
+directory.

package/package.json

@@ -1,49 +1,63 @@
-{
-  "name": "@nmzpy/pi-ember-stack",
-  "version": "0.1.6",
+{
+  "name": "@nmzpy/pi-ember-stack",
+  "version": "0.2.2",
   "description": "Ember's configurable pi plugin stack with modes, questionnaire, compact edits, subagents, and Devin auth",
-  "type": "module",
-  "license": "MIT",
-  "keywords": [
-    "pi-package",
-    "pi-extension",
-    "ember"
-  ],
-  "repository": {
-    "type": "git",
-    "url": "git+https://github.com/nmzpy/pi-ember-stack.git"
-  },
-  "bugs": {
-    "url": "https://github.com/nmzpy/pi-ember-stack/issues"
-  },
-  "scripts": {
-    "typecheck": "tsc --noEmit"
-  },
-  "files": [
-    "README.md",
-    "ATTRIBUTION.md",
-    "tsconfig.json",
-    "plugins"
-  ],
-  "pi": {
-    "extensions": [
-      "./plugins/index.ts"
-    ]
-  },
-  "peerDependencies": {
-    "@earendil-works/pi-ai": "*",
-    "@earendil-works/pi-agent-core": "*",
-    "@earendil-works/pi-coding-agent": "*",
-    "@earendil-works/pi-tui": "*",
-    "typebox": "*"
-  },
-  "devDependencies": {
-    "@earendil-works/pi-ai": "^0.80.6",
-    "@earendil-works/pi-agent-core": "^0.80.6",
-    "@earendil-works/pi-coding-agent": "^0.80.6",
-    "@earendil-works/pi-tui": "^0.80.6",
-    "@types/node": "^20.19.43",
-    "typebox": "^1.3.1",
-    "typescript": "^5.9.3"
-  }
-}
+  "type": "module",
+  "license": "MIT",
+  "keywords": [
+    "pi-package",
+    "pi-extension",
+    "ember"
+  ],
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/nmzpy/pi-ember-stack.git"
+  },
+  "bugs": {
+    "url": "https://github.com/nmzpy/pi-ember-stack/issues"
+  },
+  "scripts": {
+    "typecheck": "tsc --noEmit",
+    "lint": "biome lint",
+    "format": "biome format --write",
+    "check": "biome check"
+  },
+  "files": [
+    "README.md",
+    "ATTRIBUTION.md",
+    "tsconfig.json",
+    "plugins"
+  ],
+  "exports": {
+    ".": "./plugins/index.ts",
+    "./renderer": "./plugins/pi-compact-tools/renderer.ts"
+  },
+  "pi": {
+    "extensions": [
+      "./plugins/index.ts"
+    ]
+  },
+  "dependencies": {
+    "@ff-labs/fff-node": "0.9.6",
+    "@sinclair/typebox": "^0.34.0"
+  },
+  "peerDependencies": {
+    "@earendil-works/pi-agent-core": "*",
+    "@earendil-works/pi-ai": "*",
+    "@earendil-works/pi-coding-agent": "*",
+    "@earendil-works/pi-tui": "*",
+    "typebox": "*"
+  },
+  "devDependencies": {
+    "@biomejs/biome": "^2.5.3",
+    "@earendil-works/pi-agent-core": "^0.80.6",
+    "@earendil-works/pi-ai": "^0.80.6",
+    "@earendil-works/pi-coding-agent": "^0.80.6",
+    "@earendil-works/pi-tui": "^0.80.6",
+    "@ff-labs/fff-node": "0.9.6",
+    "@sinclair/typebox": "^0.34.0",
+    "@types/node": "^20.19.43",
+    "typebox": "^1.3.1",
+    "typescript": "^5.9.3"
+  }
+}

package/plugins/devin-auth/extensions/index.ts

@@ -5,7 +5,7 @@
  *  - OAuth login via Windsurf's browser sign-in flow (`loginDevin`)
  *  - A no-op token refresh (Windsurf api_keys are long-lived)
  *  - Live model catalog fetch from Cognition's GetCascadeModelConfigs
- *    after login, filtered to 11 wanted model families
+ *    after login, surfacing every model the account has access to
  *  - `/devin-refresh` command to manually re-fetch the catalog
  *  - `/devin-status` command to check auth state
  *  - `session_start` auto-fetch when already logged in
@@ -15,7 +15,8 @@
  * and auth are handled internally via the OAuth-issued api_key.
  */
 
-import type { ExtensionAPI } from '@earendil-works/pi-coding-agent';
+import type { ExtensionAPI, ProviderModelConfig } from '@earendil-works/pi-coding-agent';
+import { AuthStorage } from '@earendil-works/pi-coding-agent';
 import type {
     Api,
     Model,
@@ -24,7 +25,7 @@ import type {
 } from '@earendil-works/pi-ai';
 import { streamDevin } from '../src/stream.js';
 import { loginDevin } from '../src/oauth/login.js';
-import { buildLiveModels, FALLBACK_MODELS, DEFAULT_HOST } from '../src/models.js';
+import { buildLiveModels, DEFAULT_HOST } from '../src/models.js';
 import { getCachedCatalog, clearCachedCatalog } from '../src/cloud-direct/catalog.js';
 import { DEFAULT_REGION } from '../src/oauth/types.js';
 
@@ -38,7 +39,34 @@ const PLACEHOLDER_BASE_URL = DEFAULT_HOST;
 
 let _pi: ExtensionAPI | null = null;
 
-function registerDevinProvider(pi: ExtensionAPI, models: typeof FALLBACK_MODELS): void {
+/**
+ * Fetch the live catalog using credentials already in auth.json and register
+ * the resulting models. Called during the awaited factory load so devin
+ * models exist before pi flushes pending provider registrations and restores
+ * the session model.
+ *
+ * Reads auth.json directly via AuthStorage (the model registry is not bound
+ * yet during factory load). Silently no-ops when not signed in or the fetch
+ * fails — the session_start handler re-attempts once the registry is live.
+ */
+async function primeCatalogFromStoredAuth(): Promise<void> {
+    if (!_pi) return;
+    try {
+        const authStorage = AuthStorage.create();
+        const apiKey = await authStorage.getApiKey(PROVIDER_ID, { includeFallback: false });
+        if (!apiKey) return;
+        const catalog = await getCachedCatalog(apiKey, DEFAULT_HOST);
+        const liveModels = buildLiveModels(catalog);
+        if (liveModels.length > 0) {
+            registerDevinProvider(_pi, liveModels);
+        }
+    } catch {
+        // Not signed in, network failure, or schema drift — keep the empty
+        // model list and let session_start retry once the registry is bound.
+    }
+}
+
+function registerDevinProvider(pi: ExtensionAPI, models: ProviderModelConfig[]): void {
     pi.registerProvider(PROVIDER_ID, {
         name: PROVIDER_NAME,
         api: API_IDENTIFIER,
@@ -58,7 +86,7 @@ function registerDevinProvider(pi: ExtensionAPI, models: typeof FALLBACK_MODELS)
                         const liveModels = buildLiveModels(catalog);
                         registerDevinProvider(_pi, liveModels);
                     } catch {
-                        // keep static models if catalog fetch fails
+                        // keep current models if catalog fetch fails
                     }
                 }
                 return credentials;
@@ -80,9 +108,41 @@ function registerDevinProvider(pi: ExtensionAPI, models: typeof FALLBACK_MODELS)
 export default async function (pi: ExtensionAPI): Promise<void> {
     _pi = pi;
 
-    registerDevinProvider(pi, FALLBACK_MODELS);
+    // Swallow AbortError unhandled rejections that arise when the user
+    // cancels an in-flight agent run (Escape during streaming). The agent's
+    // AbortController.abort() sets signal.reason to a DOMException
+    // [AbortError]; late rejections from fetch body streams, reader.cancel(),
+    // or the anySignal polyfill can surface as unhandled rejections that —
+    // on Node ≥15 with --unhandled-rejections=throw (the default in Node 25)
+    // — trigger pi's uncaughtException handler and crash the process.
+    // These are expected during cancellation, not real errors.
+    //
+    // Non-abort rejections are genuine bugs: temporarily remove the guard,
+    // re-emit so pi's crash handler surfaces them, then re-attach.
+    const abortRejectionHandler = (reason: unknown): void => {
+        const isAbort =
+            reason instanceof DOMException && reason.name === 'AbortError';
+        if (isAbort) return; // expected during cancellation
+        // Re-emit non-abort rejections so they are not silently swallowed.
+        process.off('unhandledRejection', abortRejectionHandler);
+        process.emit('unhandledRejection', reason, Promise.reject(reason));
+        process.on('unhandledRejection', abortRejectionHandler);
+    };
+    process.on('unhandledRejection', abortRejectionHandler);
+
+    // Register with an empty model list first so the provider (and OAuth
+    // login support) is known even before the catalog arrives. Then, if we
+    // already have credentials in auth.json, fetch the live catalog now —
+    // during the awaited factory load, before pi flushes pending provider
+    // registrations and restores the session model. This is what makes
+    // `devin/glm-5-2` resolvable on resume instead of falling back to the
+    // default provider with a "Could not restore model" warning.
+    registerDevinProvider(pi, []);
+    await primeCatalogFromStoredAuth();
 
     pi.on('session_start', async (_event, ctx) => {
+        // Re-prime in case credentials were added via /login since load, or
+        // the catalog TTL expired during a long-lived session.
         try {
             const apiKey = await ctx.modelRegistry.getApiKeyForProvider(PROVIDER_ID);
             if (apiKey && _pi) {
@@ -91,7 +151,7 @@ export default async function (pi: ExtensionAPI): Promise<void> {
                 registerDevinProvider(_pi, liveModels);
             }
         } catch {
-            // keep static models
+            // keep current models
         }
     });
 
@@ -137,5 +197,6 @@ export default async function (pi: ExtensionAPI): Promise<void> {
 
     pi.on('session_shutdown', async () => {
         _pi = null;
+        process.off('unhandledRejection', abortRejectionHandler);
     });
 }