@nmakarov/cli-toolkit 0.43.0 → 0.46.0

package/dist/index.js

@@ -2283,23 +2283,18 @@ function defaultFileSynopsisFunction(fileEntry, data) {
   const timestamps = [];
   const statusCounts = {};
   for (const item of data) {
-    let ts = null;
-    let status = null;
+    if (!item || typeof item !== "object") continue;
     for (const [key, value] of Object.entries(item)) {
       const k = key.toLowerCase();
-      if (k === "modificationtimestamp") {
-        ts = new Date(value).getTime();
+      if (k.endsWith("modificationtimestamp") && value != null && value !== "") {
+        const ts = new Date(value).getTime();
+        if (!Number.isNaN(ts)) timestamps.push(ts);
       }
-      if (k === "standardstatus") {
-        status = value;
+      if (k === "standardstatus" && value != null && value !== "") {
+        const status = String(value);
+        statusCounts[status] = (statusCounts[status] || 0) + 1;
       }
     }
-    if (ts && !isNaN(ts)) {
-      timestamps.push(ts);
-    }
-    if (status !== null && status !== void 0) {
-      statusCounts[status] = (statusCounts[status] || 0) + 1;
-    }
   }
   const result = { ...fileEntry };
   if (timestamps.length) {
@@ -2318,27 +2313,38 @@ function defaultVersionSynopsisFunction(metadata) {
   const timestamps = [];
   const statusCounts = {};
   for (const file of metadata.files) {
-    if (file.minModificationTimestamp) {
+    if (file?.minModificationTimestamp) {
       const minTs = new Date(file.minModificationTimestamp).getTime();
-      if (!isNaN(minTs)) timestamps.push(minTs);
+      if (!Number.isNaN(minTs)) timestamps.push(minTs);
     }
-    if (file.maxModificationTimestamp) {
+    if (file?.maxModificationTimestamp) {
       const maxTs = new Date(file.maxModificationTimestamp).getTime();
-      if (!isNaN(maxTs)) timestamps.push(maxTs);
+      if (!Number.isNaN(maxTs)) timestamps.push(maxTs);
     }
-    if (file.StandardStatuses && typeof file.StandardStatuses === "object") {
+    if (file?.StandardStatuses && typeof file.StandardStatuses === "object") {
       for (const [status, count] of Object.entries(file.StandardStatuses)) {
-        statusCounts[status] = (statusCounts[status] || 0) + count;
+        statusCounts[status] = (statusCounts[status] || 0) + Number(count || 0);
       }
     }
   }
   const result = { ...metadata };
+  const synopsis = {
+    ...metadata.synopsis && typeof metadata.synopsis === "object" ? metadata.synopsis : {}
+  };
   if (timestamps.length) {
-    result.minModificationTimestamp = new Date(Math.min(...timestamps)).toISOString();
-    result.maxModificationTimestamp = new Date(Math.max(...timestamps)).toISOString();
+    const minIso = new Date(Math.min(...timestamps)).toISOString();
+    const maxIso = new Date(Math.max(...timestamps)).toISOString();
+    result.minModificationTimestamp = minIso;
+    result.maxModificationTimestamp = maxIso;
+    synopsis.minModificationTimestamp = minIso;
+    synopsis.maxModificationTimestamp = maxIso;
   }
   if (Object.keys(statusCounts).length > 0) {
     result.StandardStatuses = statusCounts;
+    synopsis.StandardStatuses = statusCounts;
+  }
+  if (Object.keys(synopsis).length) {
+    result.synopsis = synopsis;
   }
   return result;
 }
@@ -3472,10 +3478,35 @@ async function ensureSchemaEverywhere(dbs, spec, options = {}) {
 // src/db/index.js
 var KNEX_DEFAULTS = {
   testConnection: true,
-  pool: { min: 2, max: 10 },
+  // min: 0 avoids holding idle sockets that go stale during long-running CLIs
+  pool: { min: 0, max: 10, idleTimeoutMillis: 3e4 },
   acquireConnectionTimeout: 1e4,
   ssl: { rejectUnauthorized: false }
 };
+var CONNECTION_ERROR_CODES = /* @__PURE__ */ new Set([
+  "ECONNRESET",
+  "ECONNREFUSED",
+  "EPIPE",
+  "ETIMEDOUT",
+  "ENOTFOUND",
+  "EHOSTUNREACH",
+  "ENETUNREACH",
+  "ECONNABORTED",
+  "CONNECTION_ENDED",
+  "CONNECTION_CLOSED",
+  // PostgreSQL SQLSTATE class 08xxx (connection exception) + admin shutdowns
+  "08000",
+  "08001",
+  "08003",
+  "08004",
+  "08006",
+  "08007",
+  "08P01",
+  "57P01",
+  "57P02",
+  "57P03"
+]);
+var CONNECTION_ERROR_MESSAGE_RE = /connection (terminated|ended|closed|destroyed|reset|refused|not open)|Connection terminated unexpectedly|Client has encountered a connection error|server closed the connection|Cannot use a pool after calling end|This socket has been ended|connect ECONNRESET|Timeout acquiring a connection/i;
 var Db = class _Db {
   static async init(context, options = {}) {
     const buildConfig = async () => {
@@ -3723,10 +3754,11 @@ var Db = class _Db {
     this.knexInstance = null;
     this.isConnected = false;
     this.queriesLog = [];
+    this._reconnectPromise = null;
     this.config = {
       testConnection: true,
       profile: false,
-      pool: { min: 2, max: 10 },
+      pool: { min: 0, max: 10, idleTimeoutMillis: 3e4 },
       acquireConnectionTimeout: 1e4,
       ssl: { rejectUnauthorized: false },
       logger: console,
@@ -3744,7 +3776,7 @@ var Db = class _Db {
         if (!inst.knexInstance) {
           throw new Error("Db: Not connected. Call connect() first.");
         }
-        return inst.knexInstance(...argumentsList);
+        return inst.wrapQueryBuilder(inst.knexInstance(...argumentsList));
       },
       get: (target, prop) => {
         if (prop === "_instance") {
@@ -3754,8 +3786,12 @@ var Db = class _Db {
         const ownMethods = [
           "connect",
           "disconnect",
+          "reconnect",
           "testConnection",
           "tableExists",
+          "raw",
+          "withConnectionRetry",
+          "isConnectionError",
           "getQueryLog",
           "getKnex",
           "isConnectedToDb",
@@ -3775,6 +3811,9 @@ var Db = class _Db {
         if (inst.knexInstance) {
           const knexProp = inst.knexInstance[prop];
           if (typeof knexProp === "function") {
+            if (prop === "raw") {
+              return (...args) => inst.raw(...args);
+            }
             return knexProp.bind(inst.knexInstance);
           }
           return knexProp;
@@ -3854,6 +3893,130 @@ var Db = class _Db {
       throw error;
     }
   }
+  /**
+   * True when the error indicates a dead socket / pool that a fresh connect may fix.
+   * Safe to call as `Db.prototype.isConnectionError(err)` or via a connected handle.
+   */
+  isConnectionError(error) {
+    if (!error) {
+      return false;
+    }
+    if (error instanceof AggregateError && Array.isArray(error.errors)) {
+      return error.errors.some((e) => this.isConnectionError(e));
+    }
+    const code = error.code ?? error.errno;
+    if (code != null && CONNECTION_ERROR_CODES.has(String(code))) {
+      return true;
+    }
+    const msg = error instanceof Error ? error.message : String(error);
+    return CONNECTION_ERROR_MESSAGE_RE.test(msg);
+  }
+  /**
+   * Destroy the current knex pool and open a new one. Concurrent callers share one attempt.
+   */
+  async reconnect() {
+    if (this._reconnectPromise) {
+      await this._reconnectPromise;
+      return;
+    }
+    this._reconnectPromise = (async () => {
+      const old = this.knexInstance;
+      this.isConnected = false;
+      this.knexInstance = null;
+      this.queriesLog = [];
+      if (old) {
+        try {
+          await old.destroy();
+        } catch (error) {
+          this.logger.debug?.(
+            `[Db] destroy during reconnect: ${this.getErrorMessage(error)}`
+          );
+        }
+      }
+      await this.connect();
+    })();
+    try {
+      await this._reconnectPromise;
+    } finally {
+      this._reconnectPromise = null;
+    }
+  }
+  async reconnectAfterConnectionError(error) {
+    this.logger.warn?.(
+      `[Db] Connection lost (${this.getErrorMessage(error)}) \u2014 reconnecting\u2026`
+    );
+    await this.reconnect();
+  }
+  /**
+   * Run `fn`; on a connection error, reconnect once (by default) and retry `fn`.
+   * `fn` should look up `this.knexInstance` each call so the retry uses the new client.
+   */
+  async withConnectionRetry(fn, { retries = 1 } = {}) {
+    let lastError;
+    for (let attempt = 0; attempt <= retries; attempt++) {
+      try {
+        return await fn();
+      } catch (error) {
+        lastError = error;
+        if (!this.isConnectionError(error) || attempt >= retries) {
+          throw error;
+        }
+        await this.reconnectAfterConnectionError(error);
+      }
+    }
+    throw lastError;
+  }
+  /**
+   * Wrap a knex QueryBuilder / Raw so that awaiting it retries once after reconnect
+   * when the first attempt dies with a connection error.
+   */
+  wrapQueryBuilder(builder) {
+    if (!builder || typeof builder.then !== "function" || builder.__dbReconnectWrapped) {
+      return builder;
+    }
+    builder.__dbReconnectWrapped = true;
+    const inst = this;
+    const protoThen = Object.getPrototypeOf(builder)?.then;
+    if (typeof protoThen !== "function") {
+      return builder;
+    }
+    builder.then = function(onFulfilled, onRejected) {
+      const run2 = async () => {
+        try {
+          return await protoThen.call(builder);
+        } catch (error) {
+          if (!inst.isConnectionError(error)) {
+            throw error;
+          }
+          await inst.reconnectAfterConnectionError(error);
+          if (typeof builder.clone === "function") {
+            const retry = builder.clone();
+            retry.client = inst.knexInstance.client;
+            return await protoThen.call(retry);
+          }
+          if (typeof builder.toSQL === "function" && inst.knexInstance) {
+            const sql = builder.toSQL();
+            const statements = Array.isArray(sql) ? sql : [sql];
+            let last;
+            for (const stmt of statements) {
+              last = await inst.knexInstance.raw(stmt.sql, stmt.bindings);
+            }
+            return last;
+          }
+          throw error;
+        }
+      };
+      return run2().then(onFulfilled, onRejected);
+    };
+    return builder;
+  }
+  /** knex.raw with auto-reconnect on dead connections. */
+  raw(...args) {
+    if (!this.knexInstance) {
+      throw new Error("Db: Not connected. Call connect() first.");
+    }
+    return this.wrapQueryBuilder(this.knexInstance.raw(...args));
+  }
   getErrorMessage(error) {
     if (error instanceof AggregateError) {
       const errors = error.errors || [];
@@ -4024,7 +4187,9 @@ var Db = class _Db {
       throw new Error("Db: Not connected. Call connect() first.");
     }
     try {
-      return await this.knexInstance.schema.hasTable(tableName);
+      return await this.withConnectionRetry(
+        () => this.knexInstance.schema.hasTable(tableName)
+      );
     } catch (error) {
       this.logger.error?.(`[Db] Error checking table existence: ${error.message}`);
       throw error;
@@ -6321,22 +6486,46 @@ async function ensureTaskTables(context, options = {}) {
       }
     }
     const { actions } = await ensureSchema(db, spec, { dryRun, logger: context.logger });
+    const legacyDrops = await dropLegacyTaskNameColumn(db, [tasksTable, historyTable], {
+      dryRun,
+      log,
+      label
+    });
+    const allActions = [...actions, ...legacyDrops];
     if (dryRun) {
-      if (actions.length === 0) {
+      if (allActions.length === 0) {
         log.info?.(`[tasks-schema] dryRun \u2014 ${label}: queue "${queueName}" already up to date; no DDL`);
       } else {
         log.info?.(
-          `[tasks-schema] dryRun \u2014 ${label}: would run ${actions.length} statement(s) for queue "${queueName}":`
+          `[tasks-schema] dryRun \u2014 ${label}: would run ${allActions.length} statement(s) for queue "${queueName}":`
         );
-        for (const s of actions) log.info?.(`  - ${s}`);
+        for (const s of allActions) log.info?.(`  - ${s}`);
       }
-    } else if (actions.length > 0) {
+    } else if (allActions.length > 0) {
       log.info?.(
-        `[tasks-schema] ${label}: applied ${actions.length} DDL statement(s) for queue "${queueName}"`
+        `[tasks-schema] ${label}: applied ${allActions.length} DDL statement(s) for queue "${queueName}"`
       );
     }
   }
 }
+async function dropLegacyTaskNameColumn(db, tableNames, { dryRun, log, label }) {
+  const actions = [];
+  for (const table of tableNames) {
+    if (!await db.tableExists(table).catch(() => false)) continue;
+    const hasTask = await db.schema.hasColumn(table, "task");
+    const hasName = await db.schema.hasColumn(table, "name");
+    if (!hasTask || !hasName) continue;
+    const sql = `ALTER TABLE "${table}" DROP COLUMN IF EXISTS "task"`;
+    actions.push(sql);
+    if (dryRun) {
+      log?.info?.(`[tasks-schema] dryRun \u2014 ${label}: ${sql}`);
+    } else {
+      await db.raw(sql);
+      log?.info?.(`[tasks-schema] ${label}: dropped legacy column ${table}.task`);
+    }
+  }
+  return actions;
+}
 async function enqueueTask(context, options) {
   const db = getDb(context);
   const queueName = options.queueName ?? "tasks";
@@ -6353,7 +6542,7 @@ async function enqueueTask(context, options) {
   } else if (schedule) {
     nextRunAt = nextTimeMatch(schedule, /* @__PURE__ */ new Date());
   }
-  await db(tasksTable).insert({
+  const row = {
     id,
     name,
     params: toJsonColumn(options.params ?? null),
@@ -6367,9 +6556,21 @@ async function enqueueTask(context, options) {
     server_name: options.serverName ?? null,
     status: "idle",
     status_changed_at: db.fn.now()
-  });
+  };
+  if (await tableHasLegacyTaskColumn(db, tasksTable)) {
+    row.task = name;
+  }
+  await db(tasksTable).insert(row);
   return id;
 }
+var legacyTaskColumnCache = /* @__PURE__ */ new Map();
+async function tableHasLegacyTaskColumn(db, tableName) {
+  const key = `${db?.config?.name ?? "db"}:${tableName}`;
+  if (!legacyTaskColumnCache.has(key)) {
+    legacyTaskColumnCache.set(key, await db.schema.hasColumn(tableName, "task"));
+  }
+  return legacyTaskColumnCache.get(key);
+}
 async function updateTaskProgress(context, tasksTable, taskId, progress) {
   const db = getDb(context);
   await db(tasksTable).where({ id: taskId }).update({