@nkzw/codiff-core 1.14.0 → 1.15.0

package/dist/app/components/ReviewCodeView.d.ts

@@ -3,6 +3,7 @@ import { type ReactNode } from 'react';
 import type { CodiffDiffStyle, CodiffKeymap } from '../../config/types.ts';
 import type { CodeViewInstance, DiffSearchMatch, ReviewComment, ReviewIdentity, ReviewScrollTarget, WalkthroughNote } from '../../lib/app-types.ts';
 import type { ChangedFile, CodiffPreferences, CommitMetadata, DefinitionCandidate, DefinitionSearchRequest, DefinitionSearchResult, DiffImageContentRequest, DiffImageContentResult, DiffSection, GitIdentity, PullRequestCodeQualityFinding, ReviewSource } from '../../types.ts';
+import { type CodeEditingStore } from '../hooks/useCodeEditing.ts';
 type PullRequestSource = Extract<ReviewSource, {
     type: 'pull-request';
 }>;
@@ -39,13 +40,14 @@ type HeaderReviewDiffBlock = {
     selected?: boolean;
 };
 export type ReviewDiffBlock = FileReviewDiffBlock | HeaderReviewDiffBlock;
-export declare function ReviewCodeView({ activeSearchMatch, agentId, agentLabel, allowViewedToggle, blocks, bottomInset, codeQualityFindings, collapsed, comments, commitMetadata, diffLineHeight, diffStyle, disableWorkerPool, expandedReviewKeys, files, focusCommentId, focusCommentRequest, forceExpandedPaths, gitIdentity, hunkNavigation, initialMarkdownPreviewSectionIds, isReadOnly, itemVersionByKey, keymap, loadingSectionIds, onActiveBlockChange, onAskCodex, onCommentDraftChange, onCreateComment, onDeleteComment, onFindDefinitions, onLoadImageContent, onLoadSection, onLoadSectionContents, onOpenDefinition, onOpenFile, onRefreshMarkdown, onResolveThread, onSaveCommentEdit, onSelectPathFromScroll, onSubmitComment, onToggleCollapsed, onToggleViewed, onUpdateComment, onUpdateSourceDescription, onUpdateSourceTitle, onUploadSourceDescriptionAsset, reviewIdentityByPath, scrollTarget, searchQuery, selectedPath, showSourceDescription, showWhitespace, source, sourceDescriptionActions, sourceDescriptionFooter, supportsReviewCommentActions, theme, viewed, walkthroughNotes, wordWrap, }: {
+export declare function ReviewCodeView({ activeSearchMatch, agentId, agentLabel, allowViewedToggle, blocks, bottomInset, codeEditingStore, codeQualityFindings, collapsed, comments, commitMetadata, diffLineHeight, diffStyle, disableWorkerPool, expandedReviewKeys, files, focusCommentId, focusCommentRequest, forceExpandedPaths, gitIdentity, hunkNavigation, initialMarkdownPreviewSectionIds, isReadOnly, itemVersionByKey, keymap, loadingSectionIds, onActiveBlockChange, onAskCodex, onCommentDraftChange, onCreateComment, onDeleteComment, onFindDefinitions, onLoadImageContent, onLoadSection, onLoadSectionContents, onOpenDefinition, onOpenFile, onRefreshMarkdown, onResolveThread, onSaveCommentEdit, onSelectPathFromScroll, onSubmitComment, onToggleCollapsed, onToggleViewed, onUpdateComment, onUpdateSourceDescription, onUpdateSourceTitle, onUploadSourceDescriptionAsset, reviewIdentityByPath, scrollTarget, searchQuery, selectedPath, showSourceDescription, showWhitespace, source, sourceDescriptionActions, sourceDescriptionFooter, supportsReviewCommentActions, theme, viewed, walkthroughNotes, wordWrap, }: {
     activeSearchMatch: DiffSearchMatch | null;
     agentId: 'codex' | 'claude' | 'opencode' | 'pi';
     agentLabel: string;
     allowViewedToggle?: boolean;
     blocks?: ReadonlyArray<ReviewDiffBlock>;
     bottomInset?: number;
+    codeEditingStore?: CodeEditingStore;
     codeQualityFindings?: ReadonlyArray<PullRequestCodeQualityFinding>;
     collapsed: ReadonlySet<string>;
     comments: ReadonlyArray<ReviewComment>;

package/dist/app/hooks/code-editing-store.d.ts

@@ -0,0 +1,68 @@
+import type { CodeViewDiffItem, CodeViewItem } from '@pierre/diffs';
+import type { CodeViewItemMetadata, ReviewAnnotationMetadata } from '../../lib/app-types.ts';
+import type { RepositoryFileDocument } from '../../types.ts';
+export declare const CODE_AUTOSAVE_DELAY = 300;
+export type EditSession = {
+    dirty: boolean;
+    document: RepositoryFileDocument;
+    finishing?: 'done' | 'revert';
+    hasChanges: boolean;
+    item: CodeViewDiffItem<ReviewAnnotationMetadata>;
+    metadata: CodeViewItemMetadata;
+    originalContent: string;
+    saveError?: string;
+    saving?: boolean;
+    sourceKey: string;
+};
+declare const createFileEditingStore: (onChange: () => void) => {
+    draftRef: {
+        current: string;
+    };
+    finish: (revert: boolean, beforeClose?: () => Promise<void>) => Promise<boolean>;
+    flush: () => Promise<boolean>;
+    getSnapshot: () => EditSession | null;
+    setDraft: (content: string) => void;
+    setSession: (session: EditSession | null) => void;
+};
+export type CodeEditingSession = ReturnType<typeof createFileEditingStore>;
+export declare const getCodeEditKey: (sourceKey: string, itemId: string) => string;
+export declare const createCodeEditingStore: () => {
+    clear: () => void;
+    flush: (sourceKey: string) => Promise<boolean[]>;
+    get: (sourceKey: string, itemId: string) => {
+        draftRef: {
+            current: string;
+        };
+        finish: (revert: boolean, beforeClose?: () => Promise<void>) => Promise<boolean>;
+        flush: () => Promise<boolean>;
+        getSnapshot: () => EditSession | null;
+        setDraft: (content: string) => void;
+        setSession: (session: EditSession | null) => void;
+    } | undefined;
+    getForItem: (item: CodeViewItem<ReviewAnnotationMetadata>) => {
+        draftRef: {
+            current: string;
+        };
+        finish: (revert: boolean, beforeClose?: () => Promise<void>) => Promise<boolean>;
+        flush: () => Promise<boolean>;
+        getSnapshot: () => EditSession | null;
+        setDraft: (content: string) => void;
+        setSession: (session: EditSession | null) => void;
+    } | undefined;
+    getSnapshot: () => ReadonlyMap<string, EditSession>;
+    hasFile: (path: string) => boolean;
+    hasUnsavedEdits: () => boolean;
+    start: (session: EditSession) => {
+        draftRef: {
+            current: string;
+        };
+        finish: (revert: boolean, beforeClose?: () => Promise<void>) => Promise<boolean>;
+        flush: () => Promise<boolean>;
+        getSnapshot: () => EditSession | null;
+        setDraft: (content: string) => void;
+        setSession: (session: EditSession | null) => void;
+    } | null;
+    subscribe: (listener: () => void) => () => void;
+};
+export type CodeEditingStore = ReturnType<typeof createCodeEditingStore>;
+export {};

package/dist/app/hooks/useCodeEditing.d.ts

@@ -0,0 +1,34 @@
+import { type CodeViewItem, type FileDiffLoadedFiles } from '@pierre/diffs';
+import type { EditorChangeEvent, EditorFactory, EditorOptions, EditorType } from '@pierre/diffs/edit';
+import type { CodeViewHandle, CodeViewItemEditCompleteHandler } from '@pierre/diffs/react';
+import { type RefObject } from 'react';
+import type { CodiffKeymap } from '../../config/types.ts';
+import type { CodeViewItemMetadata, ReviewAnnotationMetadata } from '../../lib/app-types.ts';
+import type { ChangedFile, DiffSection } from '../../types.ts';
+import { type CodeEditingStore, type EditSession } from './code-editing-store.ts';
+export { createCodeEditingStore, type CodeEditingStore } from './code-editing-store.ts';
+export declare const createCodeEditor: EditorFactory<ReviewAnnotationMetadata, undefined>;
+export declare function useUnsavedCodeEditsGuard(store: CodeEditingStore): void;
+export declare function useCodeEditing({ codeViewRef, items, keymap, onLoadSectionContents, onRefresh, selectedItemId, sourceKey, store: sharedStore, }: {
+    codeViewRef: RefObject<CodeViewHandle<ReviewAnnotationMetadata, undefined> | null>;
+    items: ReadonlyArray<CodeViewItem<ReviewAnnotationMetadata>>;
+    keymap?: CodiffKeymap;
+    onLoadSectionContents?: (file: ChangedFile, section: DiffSection) => Promise<FileDiffLoadedFiles>;
+    onRefresh?: (file: ChangedFile, section: DiffSection) => Promise<boolean>;
+    selectedItemId?: string;
+    sourceKey: string;
+    store?: CodeEditingStore;
+}): {
+    canStartEdit: (itemId: string, path: string) => boolean;
+    doneEdit: (itemId: string) => Promise<void>;
+    editorOptions: EditorOptions<EditorType, ReviewAnnotationMetadata, undefined>;
+    getError: (itemId: string) => string | undefined;
+    isBusy: (itemId: string) => boolean;
+    items: readonly CodeViewItem<ReviewAnnotationMetadata>[];
+    onItemEditChange: (event: EditorChangeEvent<EditorType, ReviewAnnotationMetadata, undefined>, item: CodeViewItem<ReviewAnnotationMetadata>) => void;
+    onItemEditComplete: CodeViewItemEditCompleteHandler<ReviewAnnotationMetadata, undefined>;
+    prepareEdit: (item: CodeViewItem<ReviewAnnotationMetadata>, metadata: CodeViewItemMetadata) => Promise<void>;
+    revertEdit: (itemId: string) => Promise<void>;
+    sessions: Map<string, EditSession>;
+    startEdit: (item: CodeViewItem<ReviewAnnotationMetadata>, metadata: CodeViewItemMetadata) => Promise<void>;
+};

package/dist/config/types.d.ts

@@ -30,6 +30,8 @@ export type CodiffKeymap = {
     commandBar: KeyCombo;
     diffSearch: KeyCombo;
     discardComment: KeyCombo;
+    doneEditing: KeyCombo;
+    editFile: KeyCombo;
     fileFilter: KeyCombo;
     nextHunk: KeyComboBinding;
     nextSearchMatch: KeyCombo;

package/dist/lib/code-view-options.d.ts

@@ -1,5 +1,4 @@
-import type { DiffSection, GitFileStatus } from '../types.ts';
-export declare const statusLabel: Record<GitFileStatus, string>;
+import type { DiffSection } from '../types.ts';
 export declare const sectionLabel: Record<DiffSection['kind'], string>;
 export declare const DEFAULT_PADDING = 11;
 export declare const codeViewLayout: {

package/dist/lib/narrative-walkthrough-diff.d.ts

@@ -106,10 +106,14 @@ declare const getSectionWalkthroughHunks: (file: {
     sectionKind: string;
     status: string;
 }[];
+/** Read the source-order hunk ordinal from a section-scoped id.
+ * @param {string} sectionId @param {string} hunkId
+ */
+declare const getHunkOrdinal: (sectionId: string, hunkId: string) => number | null;
 /**
  * @param {string} patch
  * @param {string} sectionId
  * @param {ReadonlyArray<string>} hunkIds
  */
 declare const filterPatchToHunkIds: (patch: string, sectionId: string, hunkIds: ReadonlyArray<string>) => string | null;
-export { buildAnchorDisplay, extractPatchHunks, filterPatchToHunkIds, getSectionWalkthroughHunks, HUNK_HEADER, hunkDisplayEnd, hunkDisplayStart, isGeneratedWalkthroughFile, isGeneratedWalkthroughPath, isSyntheticWalkthroughHunk, parseHunkHeader, sumHunkLineCounts, };
+export { buildAnchorDisplay, extractPatchHunks, filterPatchToHunkIds, getHunkOrdinal, getSectionWalkthroughHunks, HUNK_HEADER, hunkDisplayEnd, hunkDisplayStart, isGeneratedWalkthroughFile, isGeneratedWalkthroughPath, isSyntheticWalkthroughHunk, parseHunkHeader, sumHunkLineCounts, };

package/dist/lib/narrative-walkthrough-diff.mjs

@@ -209,7 +209,9 @@ const getSectionWalkthroughHunks = (file, section) => {
 	}));
 	return shouldCreateSyntheticHunk(file, section) ? [createSyntheticSectionHunk(file, section)] : [];
 };
-/** @param {string} sectionId @param {string} hunkId */
+/** Read the source-order hunk ordinal from a section-scoped id.
+* @param {string} sectionId @param {string} hunkId
+*/
 const getHunkOrdinal = (sectionId, hunkId) => {
 	const prefix = `${sectionId}:h`;
 	if (!hunkId.startsWith(prefix)) return null;
@@ -256,4 +258,4 @@ const filterPatchToHunkIds = (patch, sectionId, hunkIds) => {
 	return patch.endsWith("\n") && !focused.endsWith("\n") ? `${focused}\n` : focused;
 };
 //#endregion
-export { HUNK_HEADER, buildAnchorDisplay, extractPatchHunks, filterPatchToHunkIds, getSectionWalkthroughHunks, hunkDisplayEnd, hunkDisplayStart, isGeneratedWalkthroughFile, isGeneratedWalkthroughPath, isSyntheticWalkthroughHunk, parseHunkHeader, sumHunkLineCounts };
+export { HUNK_HEADER, buildAnchorDisplay, extractPatchHunks, filterPatchToHunkIds, getHunkOrdinal, getSectionWalkthroughHunks, hunkDisplayEnd, hunkDisplayStart, isGeneratedWalkthroughFile, isGeneratedWalkthroughPath, isSyntheticWalkthroughHunk, parseHunkHeader, sumHunkLineCounts };

package/dist/lib/narrative-walkthrough.d.ts

@@ -64,7 +64,7 @@ export type WalkthroughHunkRun = {
 };
 /** Resolve one normalized hunk to its exact live `ChangedFile` and `DiffSection`. */
 export declare const resolveWalkthroughHunkFile: (hunk: WalkthroughHunk, files: ReadonlyArray<ChangedFile>) => ResolvedWalkthroughHunkFile | null;
-/** Resolve item hunks in authored order, coalescing adjacent hunks from the same file section. */
+/** Resolve authored hunk order, coalescing only forward runs within each file section. */
 export declare const resolveWalkthroughHunkRuns: (item: WalkthroughHunkGroup, files: ReadonlyArray<ChangedFile>) => ReadonlyArray<WalkthroughHunkRun>;
 export declare const getWalkthroughRunNote: (item: WalkthroughHunkGroup, run: WalkthroughHunkRun) => string | undefined;
 /**