@nklisch/pi-enhanced 0.1.3 → 0.1.4

package/node_modules/@nklisch/pi-clearance/src/runtime/config-commands/allow.ts

@@ -1,6 +1,10 @@
 import type { ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
 
 import type { ToolAnalyzerRegistry } from "../../parse/registry.ts";
+import {
+  CLEARANCE_ALLOW_REQUEST_CUSTOM_TYPE,
+  type ClearanceAllowRequestDetails,
+} from "../allow-request-message.ts";
 import type { ToolShape } from "../../parse/shape.ts";
 import {
   flattenStages,
@@ -385,10 +389,30 @@ async function handoff(
   if (!prepared.ok) return prepared.report;
 
   try {
+    const details: ClearanceAllowRequestDetails = {
+      brief: prepared.brief,
+      form: prepared.form,
+    };
     if (ctx.isIdle()) {
-      await pi.sendUserMessage(prepared.brief);
+      await pi.sendMessage(
+        {
+          customType: CLEARANCE_ALLOW_REQUEST_CUSTOM_TYPE,
+          content: prepared.brief,
+          display: true,
+          details,
+        },
+        { triggerTurn: true },
+      );
     } else {
-      await pi.sendUserMessage(prepared.brief, { deliverAs: "followUp" });
+      await pi.sendMessage(
+        {
+          customType: CLEARANCE_ALLOW_REQUEST_CUSTOM_TYPE,
+          content: prepared.brief,
+          display: true,
+          details,
+        },
+        { deliverAs: "followUp" },
+      );
     }
   } catch (error: unknown) {
     const message = errorMessage(error);

package/node_modules/@nklisch/pi-clearance/src/runtime/config-commands/packs.ts

@@ -165,7 +165,7 @@ export interface DefaultPackListingDetails
 }
 
 /**
- * Human-facing default pack listing used by `/auto-reviewer packs` and
+ * Human-facing default pack listing used by `/clearance packs` and
  * settings drill-downs. Titles are the primary labels; stable pack ids stay as
  * secondary metadata so humans do not have to scan dot/colon-path identifiers.
  */
@@ -221,7 +221,7 @@ export async function handlePackMutationCommand(input: {
       reason:
         "Pack enable/disable requires interactive Pi UI confirmation; no config changes were written.",
       markdownLines: [
-        "- Mutating `/auto-reviewer packs enable|disable` commands require Pi UI confirmation.",
+        "- Mutating `/clearance packs enable|disable` commands require Pi UI confirmation.",
         "- No config changes were written.",
       ],
     });
@@ -338,7 +338,7 @@ export async function handlePackMutationCommand(input: {
   };
 
   return {
-    title: "Auto-reviewer pack enablement updated",
+    title: "Pi Clearance pack enablement updated",
     summary: `${packId} ${request.action} planned for ${target.target.scope}; effective state ${formatEffectiveState(effectivePack)}.`,
     markdown: formatPackMutationSuccessMarkdown(details),
     details,
@@ -1038,7 +1038,7 @@ function formatPackExplorerNameCell(
   const secondary = idsPrimary
     ? escapeCell(pack.title)
     : `\`${escapeCell(pack.id)}\``;
-  return `${primary}<br><small>${secondary}</small>`;
+  return `${primary} — ${secondary}`;
 }
 
 function formatPackExplorerScope(pack: AutoReviewerPackExplorerView): string {
@@ -1362,7 +1362,7 @@ function formatPackMutationSuccessMarkdown(
   details: PackMutationSuccessDetails,
 ): string {
   const lines = [
-    "# Auto-reviewer pack enablement updated",
+    "# Pi Clearance pack enablement updated",
     "",
     `- Pack: \`${details.request.packId}\``,
     `- Action: ${details.request.action}`,
@@ -1513,7 +1513,7 @@ function escapeCell(value: string): string {
 }
 
 function packConfirmationTitle(plan: PackEnablementPlan): string {
-  return `${capitalize(plan.request.action)} auto-reviewer pack?`;
+  return `${capitalize(plan.request.action)} Pi Clearance pack?`;
 }
 
 function yesNo(value: boolean): string {

package/node_modules/@nklisch/pi-clearance/src/runtime/config-commands/scope.ts

@@ -146,7 +146,7 @@ export async function handleScopeCommand(
       reason:
         "Project scope changes require interactive Pi UI confirmation; no config changes were written.",
       markdownLines: [
-        "- Mutating `/auto-reviewer scope` commands require Pi UI confirmation.",
+        "- Mutating `/clearance scope` commands require Pi UI confirmation.",
         "- No config changes were written.",
       ],
       change: parsed.change,
@@ -232,7 +232,7 @@ export async function handleScopeCommand(
   };
 
   return {
-    title: "Auto-reviewer project scope updated",
+    title: "Pi Clearance project scope updated",
     summary: `${planned.plan.title}; changed ${apply.changed ? "yes" : "no"}.`,
     markdown: formatScopeMutationSuccessMarkdown(details),
     details,
@@ -292,7 +292,7 @@ async function handleScopeStatus(
 
   const details = scopeStatusFromConfig(policy.policy.config);
   return {
-    title: "Auto-reviewer project scope",
+    title: "Pi Clearance project scope",
     summary: `Project scope has ${details.raw.roots.length} configured root(s), ${details.raw.writableDirectories.length} configured writable path(s), and unknown paths ${details.raw.unknownPathBehavior}.`,
     markdown: formatScopeStatusMarkdown(details),
     details,
@@ -476,7 +476,7 @@ function scopeStatusFromConfig(config: ResolvedConfig): ScopeStatusDetails {
 
 function formatScopeStatusMarkdown(details: ScopeStatusDetails): string {
   const lines = [
-    "# Auto-reviewer project scope",
+    "# Pi Clearance project scope",
     "",
     "Project scope is lexical-only: it normalizes strings but does not follow symlinks, check filesystem existence, or provide sandbox containment.",
     "",
@@ -618,7 +618,7 @@ function formatScopeMutationSuccessMarkdown(
   details: ScopeMutationSuccessDetails,
 ): string {
   const lines = [
-    "# Auto-reviewer project scope updated",
+    "# Pi Clearance project scope updated",
     "",
     `- Change: ${details.plan.title}`,
     `- Target file: \`${details.plan.target.path}\``,

package/node_modules/@nklisch/pi-clearance/src/runtime/config-commands/settings/actions.ts

@@ -1,7 +1,10 @@
 export type SettingsActionId =
+  | "mode.select"
   | "mode.set"
   | "reviewer.open"
   | "reviewer.model"
+  | "reviewer.posture.select"
+  | "reviewer.posture.set"
   | "reviewer.prompt-append"
   | "reviewer.prompt-override.set"
   | "reviewer.prompt-override.clear"
@@ -9,15 +12,20 @@ export type SettingsActionId =
   | "scope.add-path"
   | "scope.remove-path"
   | "scope.unknown-path"
+  | "scope.unknown-path.select"
   | "scope.safe-home-defaults"
   | "scope.agent-support-defaults"
   | "scope.preset"
+  | "scope.preset.select"
   | "packs.open"
   | "packs.show"
   | "packs.enable"
   | "packs.disable"
   | "briefing.open"
   | "briefing.mode"
+  | "briefing.mode.select"
+  | "gated-tools.add"
+  | "gated-tools.remove"
   | "briefing.model-label"
   | "briefing.accent";
 
@@ -28,6 +36,9 @@ export interface SettingsAction {
 
 export const WRITE_ACTION_IDS = [
   "mode.set",
+  "reviewer.posture.set",
+  "gated-tools.add",
+  "gated-tools.remove",
   "reviewer.model",
   "reviewer.prompt-append",
   "reviewer.prompt-override.set",

package/node_modules/@nklisch/pi-clearance/src/runtime/config-commands/settings/dispatcher.ts

@@ -2,10 +2,12 @@ import type { ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
 
 import {
   type ProjectScopeListField,
+  planGatedToolCommandChange,
   planModeCommandChange,
   planProjectScopeCommandChange,
   planReviewerCommandChange,
   planReviewNoteDisplayCommandChange,
+  type GatedToolCommandChange,
   type ReviewerCommandChange,
   type ReviewNoteDisplayCommandChange,
   type ScopeCommandChange,
@@ -15,9 +17,17 @@ import {
   type ConfigCommandApplyResult,
   type ConfigCommandPlan,
 } from "../../../config/config-command-writer.ts";
-import type { ClearanceMode } from "../../../config/schema.ts";
+import {
+  CLEARANCE_MODES,
+  type ClearanceMode,
+  REVIEW_NOTE_MODES,
+} from "../../../config/schema.ts";
 import type { JsonPatchOperation } from "../../../replay/proposal-schema.ts";
 import { detectReviewDecisionDisplayCapability } from "../../review-decision-display.ts";
+import {
+  isShippedReviewerPostureId,
+  SHIPPED_REVIEWER_POSTURE_OPTIONS,
+} from "../../reviewer-prompts.ts";
 import {
   handlePackMutationCommand,
   type PackMutationRequest,
@@ -36,6 +46,11 @@ import {
   type SettingsActionId,
 } from "./actions.ts";
 import { renderPacksOpenDrill, renderPacksShowDrill } from "./panels/packs.ts";
+import {
+  ACTIVE_SESSION_MODEL_LABEL,
+  availableReviewerModels,
+  type ReviewerModelOption,
+} from "./model-options.ts";
 
 export interface SettingsDispatchDependencies
   extends AutoReviewerCommandDependencies {}
@@ -83,6 +98,10 @@ export async function dispatchSettingsAction(
   ctx: ExtensionCommandContext,
   deps: SettingsDispatchDependencies,
 ): Promise<CommandReport<SettingsDispatchDetails | unknown>> {
+  const selected = await resolveSelectorAction(action, ctx, deps);
+  if (!selected.ok) return selected.report;
+  action = selected.action;
+
   if (isDrillAction(action.id)) {
     if (action.id === "packs.open") {
       return await renderPacksOpenDrill({ action, ctx, deps });
@@ -133,6 +152,11 @@ export async function dispatchSettingsAction(
           mode: change.mode,
           resolvedConfig: policy.policy.config,
         });
+      case "gated-tools":
+        return planGatedToolCommandChange({
+          change: change.change,
+          resolvedConfig: policy.policy.config,
+        });
       case "reviewer":
         return planReviewerCommandChange({
           change: change.change,
@@ -236,8 +260,217 @@ export function settingsUiRequiredReport(
   };
 }
 
+async function resolveSelectorAction(
+  action: SettingsAction,
+  ctx: ExtensionCommandContext,
+  deps: SettingsDispatchDependencies,
+): Promise<
+  | { readonly ok: true; readonly action: SettingsAction }
+  | { readonly ok: false; readonly report: CommandReport }
+> {
+  const isSelector =
+    action.id === "mode.select" ||
+    (action.id === "reviewer.model" && !Object.hasOwn(action.args, "model")) ||
+    action.id === "reviewer.posture.select" ||
+    action.id === "scope.preset.select" ||
+    action.id === "scope.unknown-path.select" ||
+    action.id === "briefing.mode.select" ||
+    (action.id === "gated-tools.add" &&
+      !Object.hasOwn(action.args, "toolName"));
+  if (!isSelector) return { ok: true, action };
+  if (ctx.hasUI !== true)
+    return { ok: false, report: settingsUiRequiredReport(action) };
+
+  const policy = await resolvePolicyReport(ctx, deps);
+  if (!policy.ok) return { ok: false, report: policy.report };
+  const reviewerModelOptions =
+    action.id === "reviewer.model" ? availableReviewerModels(ctx) : [];
+  const options = selectorOptions(
+    action,
+    deps,
+    reviewerModelOptions,
+    policy.policy.config.gatedTools ?? [],
+  );
+  if (options.length === 0) {
+    return {
+      ok: false,
+      report: invalidActionReport(
+        action,
+        "No choices are available in the current Pi session.",
+      ),
+    };
+  }
+
+  let selected: string | undefined;
+  try {
+    selected = await ctx.ui.select(selectorTitle(action), [...options]);
+  } catch {
+    selected = undefined;
+  }
+  if (selected === undefined) {
+    return {
+      ok: false,
+      report: {
+        title: "Settings selection cancelled",
+        summary: "No setting was selected; no config changes were written.",
+        markdown:
+          "# Settings selection cancelled\n\nNo config changes were written.",
+        details: { reason: "cancelled", action },
+        level: "warning",
+      },
+    };
+  }
+
+  const selectedAction = selectorSelection(
+    action,
+    selected,
+    reviewerModelOptions,
+  );
+  return selectedAction === undefined
+    ? {
+        ok: false,
+        report: invalidActionReport(action, "Unknown settings selection."),
+      }
+    : { ok: true, action: selectedAction };
+}
+
+function selectorOptions(
+  action: SettingsAction,
+  deps: SettingsDispatchDependencies,
+  reviewerModelOptions: readonly ReviewerModelOption[],
+  gatedTools: readonly string[],
+): readonly string[] {
+  switch (action.id) {
+    case "mode.select":
+      return CLEARANCE_MODES.map((mode) => modeLabel(mode));
+    case "reviewer.model":
+      return [
+        ACTIVE_SESSION_MODEL_LABEL,
+        ...reviewerModelOptions.map((model) => model.label),
+      ];
+    case "reviewer.posture.select":
+      return SHIPPED_REVIEWER_POSTURE_OPTIONS.map((option) => option.label);
+    case "scope.preset.select":
+      return ["Project only", "Home + project", "Full minus danger list"];
+    case "scope.unknown-path.select":
+      return ["Review unknown paths", "Deny unknown paths"];
+    case "briefing.mode.select":
+      return REVIEW_NOTE_MODES.map((mode) => `Note mode: ${mode}`);
+    case "gated-tools.add": {
+      const metadata = deps.toolMetadata?.();
+      return metadata === undefined
+        ? []
+        : activeToolNames(metadata)
+            .filter((name) => name !== "bash")
+            .filter((name) => !gatedTools.includes(name));
+    }
+    default:
+      return [];
+  }
+}
+
+function selectorTitle(action: SettingsAction): string {
+  switch (action.id) {
+    case "mode.select":
+      return "Choose Clearance mode";
+    case "reviewer.model":
+      return "Choose reviewer model";
+    case "reviewer.posture.select":
+      return "Choose reviewer posture";
+    case "scope.preset.select":
+      return "Choose scope preset";
+    case "scope.unknown-path.select":
+      return "Choose unknown-path behavior";
+    case "briefing.mode.select":
+      return "Choose briefing mode";
+    case "gated-tools.add":
+      return "Add exact gated non-Bash tool";
+    default:
+      return "Choose setting";
+  }
+}
+
+function selectorSelection(
+  action: SettingsAction,
+  selected: string,
+  reviewerModelOptions: readonly ReviewerModelOption[],
+): SettingsAction | undefined {
+  switch (action.id) {
+    case "mode.select": {
+      const mode = CLEARANCE_MODES.find(
+        (candidate) => selected === modeLabel(candidate),
+      );
+      return mode === undefined
+        ? undefined
+        : { id: "mode.set", args: { mode } };
+    }
+    case "reviewer.model": {
+      if (selected === ACTIVE_SESSION_MODEL_LABEL)
+        return { id: "reviewer.model", args: { model: null } };
+      const model = reviewerModelOptions.find(
+        (candidate) => candidate.label === selected,
+      );
+      return model === undefined
+        ? undefined
+        : { id: "reviewer.model", args: { model: model.spec } };
+    }
+    case "reviewer.posture.select": {
+      const posture = SHIPPED_REVIEWER_POSTURE_OPTIONS.find(
+        (option) => option.label === selected,
+      )?.id;
+      return posture === undefined
+        ? undefined
+        : { id: "reviewer.posture.set", args: { promptPosture: posture } };
+    }
+    case "scope.preset.select": {
+      const preset = {
+        "Project only": "project",
+        "Home + project": "home",
+        "Full minus danger list": "unrestricted",
+      }[selected];
+      return preset === undefined
+        ? undefined
+        : { id: "scope.preset", args: { preset } };
+    }
+    case "scope.unknown-path.select":
+      return selected === "Review unknown paths"
+        ? { id: "scope.unknown-path", args: { behavior: "review" } }
+        : selected === "Deny unknown paths"
+          ? { id: "scope.unknown-path", args: { behavior: "deny" } }
+          : undefined;
+    case "briefing.mode.select": {
+      const mode = selected.replace(/^Note mode: /, "");
+      return (REVIEW_NOTE_MODES as readonly string[]).includes(mode)
+        ? { id: "briefing.mode", args: { mode } }
+        : undefined;
+    }
+    case "gated-tools.add":
+      return { id: "gated-tools.add", args: { toolName: selected } };
+    default:
+      return undefined;
+  }
+}
+
+function modeLabel(mode: ClearanceMode): string {
+  return mode[0]?.toUpperCase() + mode.slice(1);
+}
+
+function activeToolNames(metadata: {
+  readonly activeToolNames: readonly string[];
+  readonly allToolNames: readonly string[];
+}): readonly string[] {
+  return metadata.activeToolNames.length > 0
+    ? metadata.activeToolNames
+    : metadata.allToolNames;
+}
+
 type MaterializedSettingsChange =
   | { readonly ok: true; readonly kind: "mode"; readonly mode: ClearanceMode }
+  | {
+      readonly ok: true;
+      readonly kind: "gated-tools";
+      readonly change: GatedToolCommandChange;
+    }
   | {
       readonly ok: true;
       readonly kind: "reviewer";
@@ -266,6 +499,41 @@ function materializeSettingsAction(
       }
       return { ok: true, kind: "mode", mode };
     }
+    case "gated-tools.add":
+    case "gated-tools.remove": {
+      const toolName = stringArg(action, "toolName");
+      if (toolName === undefined) {
+        return invalidArg(action, "toolName", "an exact non-Bash tool name");
+      }
+      return {
+        ok: true,
+        kind: "gated-tools",
+        change: {
+          kind: action.id === "gated-tools.add" ? "add" : "remove",
+          toolName,
+        },
+      };
+    }
+    case "reviewer.posture.set": {
+      const promptPosture = stringArg(action, "promptPosture");
+      if (
+        promptPosture === undefined ||
+        !isShippedReviewerPostureId(promptPosture)
+      ) {
+        return invalidArg(
+          action,
+          "promptPosture",
+          SHIPPED_REVIEWER_POSTURE_OPTIONS.map((option) => option.id).join(
+            ", ",
+          ),
+        );
+      }
+      return {
+        ok: true,
+        kind: "reviewer",
+        change: { kind: "prompt-posture", promptPosture },
+      };
+    }
     case "reviewer.model": {
       const model = nullableStringArg(action, "model");
       if (!model.ok) return { ok: false, reason: model.reason };
@@ -383,6 +651,11 @@ function materializeSettingsAction(
         change: { kind: "accent", enabled },
       };
     }
+    case "mode.select":
+    case "reviewer.posture.select":
+    case "scope.preset.select":
+    case "scope.unknown-path.select":
+    case "briefing.mode.select":
     case "reviewer.open":
     case "scope.open":
     case "packs.open":

package/node_modules/@nklisch/pi-clearance/src/runtime/config-commands/settings/model-options.ts

@@ -0,0 +1,52 @@
+import type { ExtensionCommandContext } from "@earendil-works/pi-coding-agent";
+
+import type { ReviewerModelRegistry } from "../../reviewer-model.ts";
+
+export interface ReviewerModelOption {
+  /** Canonical provider/modelId spec written to config. */
+  readonly spec: string;
+  /** Human-facing label shown by Pi's selector. */
+  readonly label: string;
+}
+
+export const ACTIVE_SESSION_MODEL_LABEL = "Use active session model" as const;
+export const REVIEWER_MODEL_OPTION_LIMIT = 12;
+
+/**
+ * Return the same capped, auth-filtered model catalog for both read models and
+ * selector dispatch. Keeping the spec beside its label avoids rebuilding a
+ * potentially different provider/model mapping at the point of selection.
+ */
+export function availableReviewerModels(
+  ctx: ExtensionCommandContext,
+): readonly ReviewerModelOption[] {
+  const registry = (ctx as { readonly modelRegistry?: unknown })
+    .modelRegistry as ReviewerModelRegistry | undefined;
+  if (
+    registry === undefined ||
+    typeof registry.getAll !== "function" ||
+    typeof registry.hasConfiguredAuth !== "function"
+  ) {
+    return [];
+  }
+
+  try {
+    return registry
+      .getAll()
+      .filter((model) => registry.hasConfiguredAuth(model))
+      .map((model) => {
+        const spec = `${model.provider}/${model.id}`;
+        return {
+          spec,
+          label:
+            typeof model.name === "string" && model.name.length > 0
+              ? `${model.name} (${spec})`
+              : spec,
+        };
+      })
+      .sort((a, b) => a.spec.localeCompare(b.spec))
+      .slice(0, REVIEWER_MODEL_OPTION_LIMIT);
+  } catch {
+    return [];
+  }
+}