@njweber/app-check 0.1.0 → 0.2.0

package/README.md

@@ -9,8 +9,10 @@ npx @njweber/app-check ./build/app-release.aab ./build/YourApp.ipa ./assets/icon
 
 | Artifact | What it's checked for | Under the hood |
 |---|---|---|
-| `*.aab`, `*.apk` | Android 16 KB page-size compliance | [`store-check`](https://github.com/nwebersoftware/store-check) |
-| `*.ipa` | App Store submission pitfalls | [`ipa-check`](https://github.com/nwebersoftware/ipa-check) |
+| `*.aab` | Android 16 KB page size **and** the manifest audit | [`store-check`](https://github.com/nwebersoftware/store-check) + [`manifest-check`](https://github.com/nwebersoftware/manifest-check) |
+| `*.apk` | Android 16 KB page size | [`store-check`](https://github.com/nwebersoftware/store-check) |
+| `AndroidManifest.xml` | Android manifest audit | [`manifest-check`](https://github.com/nwebersoftware/manifest-check) |
+| `*.ipa` | App Store submission pitfalls **and** privacy usage descriptions | [`ipa-check`](https://github.com/nwebersoftware/ipa-check) + [`privacy-check`](https://github.com/nwebersoftware/privacy-check) |
 | `*.png` | icon size / alpha rules | [`icon-check`](https://github.com/nwebersoftware/icon-check) |
 
 ```
@@ -57,7 +59,11 @@ to discover mid-review.
 
 ## Family
 
-Each check is also its own focused tool: `store-check` · `ipa-check` · `icon-check`.
+Each check is also its own focused tool: `store-check` · `manifest-check` · `ipa-check` · `privacy-check` · `icon-check`.
+
+An `.ipa` deliberately runs **two** audits — submission shape (`ipa-check`) and privacy declarations
+(`privacy-check`). An `.aab` runs **two** as well — the 16 KB page-size check (`store-check`) and the
+manifest audit (`manifest-check`).
 
 ## License
 

package/bin/app-check.mjs

@@ -1,8 +1,8 @@
 #!/usr/bin/env node
 import { readFileSync, readdirSync } from 'node:fs';
-import { extname, join } from 'node:path';
+import { join } from 'node:path';
 
-import { classify, runCheck, SUPPORTED } from '../src/run.mjs';
+import { classify, checksFor, runCheck } from '../src/run.mjs';
 
 const HELP = `app-check — check a mobile build before the stores do
 
@@ -47,7 +47,7 @@ function collect(dir, out = []) {
     if (e.name.startsWith('.') || SKIP.has(e.name)) continue;
     const p = join(dir, e.name);
     if (e.isDirectory()) collect(p, out);
-    else if (SUPPORTED.includes(extname(e.name).toLowerCase())) out.push(p);
+    else if (classify(e.name)) out.push(p);
   }
   return out;
 }
@@ -79,10 +79,12 @@ for (const file of files) {
     badInput = true;
     continue;
   }
-  const co = { label: file };
-  if (kind === 'icon' && opts.android) co.platform = 'android';
-  if (kind === 'ios' && opts.bundleId) co.bundleId = opts.bundleId;
-  results.push(runCheck(kind, buf, co));
+  for (const k of checksFor(kind, file)) {
+    const co = { label: file };
+    if (k === 'icon' && opts.android) co.platform = 'android';
+    if (k === 'ios' && opts.bundleId) co.bundleId = opts.bundleId;
+    results.push(runCheck(k, buf, co));
+  }
 }
 
 const failed = results.filter((r) => !r.report.ok).length;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@njweber/app-check",
-  "version": "0.1.0",
+  "version": "0.2.0",
   "description": "One command to check a mobile build before the stores do — Android 16 KB page size, iOS .ipa pitfalls, and icon rules.",
   "type": "module",
   "bin": {
@@ -19,7 +19,9 @@
   "engines": { "node": ">=18" },
   "dependencies": {
     "@njweber/store-check": "^0.1.0",
+    "@njweber/android-manifest-check": "^0.1.0",
     "@njweber/ipa-check": "^0.1.0",
+    "@njweber/privacy-check": "^0.1.0",
     "icon-check": "^0.1.0"
   }
 }

package/src/run.mjs

@@ -1,22 +1,35 @@
 import { checkArtifact, formatReport as fmtAndroid } from '@njweber/store-check/src/check.mjs';
+import { checkManifest, formatReport as fmtManifest } from '@njweber/android-manifest-check/src/check.mjs';
 import { checkIpa, formatReport as fmtIpa } from '@njweber/ipa-check/src/check.mjs';
+import { checkPrivacy, formatReport as fmtPrivacy } from '@njweber/privacy-check/src/check.mjs';
 import { checkIcon, formatReport as fmtIcon } from 'icon-check/src/check.mjs';
 
 const TOOLS = {
   android: { name: 'store-check', run: (buf) => checkArtifact(buf), fmt: fmtAndroid },
+  manifest: { name: 'manifest-check', run: (buf) => checkManifest(buf), fmt: fmtManifest },
   ios: { name: 'ipa-check', run: (buf, o) => checkIpa(buf, o), fmt: fmtIpa },
+  privacy: { name: 'privacy-check', run: (buf) => checkPrivacy(buf), fmt: fmtPrivacy },
   icon: { name: 'icon-check', run: (buf, o) => checkIcon(buf, o), fmt: fmtIcon },
 };
 
-/** Map a file path to the check that applies, by extension. */
+/** Map a file path to the primary check that applies. */
 export function classify(file) {
   const lower = String(file).toLowerCase();
+  if (lower.endsWith('androidmanifest.xml')) return 'manifest';
   if (lower.endsWith('.aab') || lower.endsWith('.apk')) return 'android';
   if (lower.endsWith('.ipa')) return 'ios';
   if (lower.endsWith('.png')) return 'icon';
   return null;
 }
 
+/** Every check that should run for an artifact (some artifacts get more than one audit). */
+export function checksFor(kind, file = '') {
+  const lower = String(file).toLowerCase();
+  if (kind === 'ios') return ['ios', 'privacy'];
+  if (kind === 'android') return lower.endsWith('.aab') ? ['android', 'manifest'] : ['android'];
+  return [kind];
+}
+
 /**
  * Run one check, never throwing: a bad artifact becomes a failing result, not a crash.
  * Returns { kind, name, label, report, text, error }.