@nitpicker/core 0.22.0 → 0.22.1

package/lib/page-analysis-worker.d.ts

@@ -7,13 +7,21 @@
  * 1. Dynamically imports the configured plugin via {@link importModules}
  *    (cached after the first task on the same worker)
  * 2. If the plugin implements `eachPage`:
- *    - Creates a JSDOM instance from the raw HTML
+ *    - Creates a JSDOM instance from the raw HTML, with `runScripts:
+ *      'outside-only'` so that plugins can use `window.eval` to run
+ *      DOM-scoped scripts (e.g. injecting a browser-oriented library that
+ *      needs to bind to that specific window — see
+ *      `@nitpicker/analyze-axe`'s `injectAxe`)
  *    - Calls the plugin's `eachPage` hook with the DOM window
  *    - Closes the JSDOM window to free memory
  * 3. Returns the plugin result as {@link ReportPage} or `null`
  *
  * One invocation processes exactly one plugin × one page, even though
  * the worker hosting this module handles many tasks over its lifetime.
+ * `eachPage` plugins must not rely on `dom.window` being reachable from
+ * `globalThis` — nothing exposes it there — and must not cache state that
+ * outlives a single call, since the window backing it is closed once the
+ * call returns.
  * @module
  */
 import type { Plugin, ReportPage } from './types.js';

package/lib/page-analysis-worker.js

@@ -7,35 +7,25 @@
  * 1. Dynamically imports the configured plugin via {@link importModules}
  *    (cached after the first task on the same worker)
  * 2. If the plugin implements `eachPage`:
- *    - Creates a JSDOM instance from the raw HTML
+ *    - Creates a JSDOM instance from the raw HTML, with `runScripts:
+ *      'outside-only'` so that plugins can use `window.eval` to run
+ *      DOM-scoped scripts (e.g. injecting a browser-oriented library that
+ *      needs to bind to that specific window — see
+ *      `@nitpicker/analyze-axe`'s `injectAxe`)
  *    - Calls the plugin's `eachPage` hook with the DOM window
  *    - Closes the JSDOM window to free memory
  * 3. Returns the plugin result as {@link ReportPage} or `null`
  *
  * One invocation processes exactly one plugin × one page, even though
  * the worker hosting this module handles many tasks over its lifetime.
+ * `eachPage` plugins must not rely on `dom.window` being reachable from
+ * `globalThis` — nothing exposes it there — and must not cache state that
+ * outlives a single call, since the window backing it is closed once the
+ * call returns.
  * @module
  */
 import { JSDOM } from 'jsdom';
 import { importModules } from './import-modules.js';
-/**
- * Set of critical Node.js global properties that must never be overwritten
- * by JSDOM window properties.
- */
-const PROTECTED_GLOBALS = new Set([
-    'process',
-    'global',
-    'globalThis',
-    'console',
-    'Buffer',
-    'setTimeout',
-    'setInterval',
-    'clearTimeout',
-    'clearInterval',
-    'setImmediate',
-    'clearImmediate',
-    'queueMicrotask',
-]);
 /**
  * Executes a single plugin's `eachPage` hook against a single page.
  * @template T - Column key union from the plugin's headers.
@@ -58,23 +48,6 @@ export default async function (data, urlEventBus, num, total) {
         url: url.href,
         runScripts: 'outside-only',
     });
-    // Expose JSDOM globals so that browser-oriented libraries
-    // (axe-core, @medv/finder, etc.) that inspect the global scope
-    // can find `window`, `document`, `Node`, and other DOM APIs.
-    const g = globalThis;
-    const domGlobalKeys = [];
-    for (const key of Object.getOwnPropertyNames(dom.window)) {
-        if (key in g || PROTECTED_GLOBALS.has(key)) {
-            continue;
-        }
-        try {
-            g[key] = dom.window[key];
-            domGlobalKeys.push(key);
-        }
-        catch {
-            // Some window properties throw on access — skip them
-        }
-    }
     try {
         const report = await analyzeMod.eachPage({
             url,
@@ -90,9 +63,6 @@ export default async function (data, urlEventBus, num, total) {
         throw new Error(`[${plugin.name}] ${message}`);
     }
     finally {
-        for (const key of domGlobalKeys) {
-            delete g[key];
-        }
         dom.window.close();
     }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@nitpicker/core",
-	"version": "0.22.0",
+	"version": "0.22.1",
 	"description": "Plugin-based page analysis engine for Nitpicker",
 	"author": "D-ZERO",
 	"license": "Apache-2.0",
@@ -31,7 +31,7 @@
 	},
 	"dependencies": {
 		"@d-zero/dealer": "1.14.0",
-		"@d-zero/page-cluster": "0.6.3",
+		"@d-zero/page-cluster": "0.6.4",
 		"@d-zero/shared": "0.23.0",
 		"@nitpicker/crawler": "0.22.0",
 		"@nitpicker/types": "0.22.0",
@@ -39,5 +39,5 @@
 		"cosmiconfig": "10.0.1",
 		"jsdom": "30.0.1"
 	},
-	"gitHead": "934b1714f4394effb3865d84bf8348ed74f45840"
+	"gitHead": "ec937f6442b1aa0ed06e68cfde2abaa21a66358c"
 }