@niondigital/eslint-config-base 3.1.0 → 5.0.0

package/CHANGELOG.md

@@ -0,0 +1,63 @@
+# Change Log
+
+All notable changes to this project will be documented in this file.
+See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
+
+# [5.0.0](https://github.com/niondigital/javascript-style/compare/v4.0.0...v5.0.0) (2026-07-14)
+
+- feat(eslint-config-base)!: enforce size backstops and no-console (#7) ([e39251c](https://github.com/niondigital/javascript-style/commit/e39251c749533e59ec3b2b6af361f5352254eeaf)), closes [#7](https://github.com/niondigital/javascript-style/issues/7)
+
+### BREAKING CHANGES
+
+- consumer projects now error on files/functions over the
+  size limits and on any console call; suppress per file via additionalRules
+  or additionalConfig where console output is legitimate.
+
+# [4.0.0](https://github.com/niondigital/javascript-style/compare/v3.1.0...v4.0.0) (2026-06-16)
+
+- feat!: upgrade all config packages to newest versions (v4.0.0) (#4) ([31ad2f0](https://github.com/niondigital/javascript-style/commit/31ad2f0b26f1c6e57a90d14bed435abbfba091c2)), closes [#4](https://github.com/niondigital/javascript-style/issues/4)
+
+### BREAKING CHANGES
+
+- consumers must use ESLint 10 and TypeScript 6.
+
+- feat!: require stylelint 17 + cssnano 8; freeze CSS property order
+
+Bump stylelint-config to stylelint 17, stylelint-config-standard 40 and
+stylelint-config-clean-order 10 (adds stylelint-order 8 as a peer), and
+postcss-config to cssnano 8 and @csstools/postcss-global-data 4.
+
+Behavior preserved: stylelint-config-standard 40 changes no rules. clean-order 10
+reordered/extended its propertyGroups, which would change order/properties-order,
+so the v3.x property order is now owned in stylelint-config/property-order.js and
+no longer tracks clean-order. The resolved stylelint ruleset is identical to v16.
+
+Note (not a lint rule): cssnano 8 no longer alphabetically sorts declarations, so
+minified output preserves source order. CSS rendering is unchanged.
+
+- consumers must use stylelint 17 and cssnano 8.
+
+- build: upgrade repo tooling (lerna 9, lint-staged 17, commitlint 21)
+
+- chore: set internal workspace peer ranges to ^4.0.0
+
+- build: raise Node floor to 24.11, bump postcss-preset-env, extend harness
+
+Addresses the final review:
+
+- Raise root engines.node to >=24.11.0 (cssnano 8's engine floor; >=24.0.0 was
+  inaccurate). .nvmrc already resolves to a satisfying Node 24.x.
+- Bump postcss-preset-env peer/dev floor ^11.1.2 -> ^11.3.1 (latest; it was the
+  only dependency left below its newest patch).
+- Harden validate:check to also fail on untracked snapshot files.
+- Add ESLint lint-output snapshots (rule firing on a violations fixture) and a
+  @niondigital/commitlint-config resolved-rules snapshot, closing harness gaps.
+
+* feat(stylelint-config): adopt clean-order 10 property order
+
+Supersedes the interim freeze: per decision, use stylelint-config-clean-order@10's
+updated propertyGroups for order/properties-order (443 -> 468 properties) instead
+of the frozen v3.x list. CSS property ordering changes accordingly; no other
+stylelint rule changes (verified: only order/properties-order differs).
+
+- feat(setup): add root ESLint flat config so the repo lints its own source

package/README.md

@@ -2,6 +2,13 @@
 
 Shared ESLint config as base by [nion digital](https://www.nion-digital.com).
 
+## Enforced rules
+
+On top of `eslint:recommended` and `typescript-eslint` recommended, this config enforces:
+
+- **Size backstops**: `max-lines` (400, error), `max-lines-per-function` (80), `complexity` (12). Test files (`*.{test,spec}.*`, `__tests__/`, `__mocks__/`) are exempt from all three.
+- **No `console`**: use a logging facade instead. Override per file via `additionalRules` / `additionalConfig` for legitimate CLI tooling.
+
 ## Installation
 
 1. Install package as a dev dependency:

package/config.js

@@ -5,6 +5,19 @@ import tseslint from 'typescript-eslint';
 export default ({ ignores = [], additionalRules = {}, additionalConfig = [] } = {}) => {
 	const rules = {
 		'no-undef': 'off',
+		// ESLint 10 / @eslint/js 10 behavior preservation: keep the ESLint 9 effective
+		// ruleset. v10's `recommended` set added three rules and flipped one default;
+		// neutralize them so upgrading does not change which rules are enforced.
+		// Consumers can still opt in to the new rules via `additionalRules`.
+		'no-unassigned-vars': 'off', // newly added to v10 recommended
+		'no-useless-assignment': 'off', // newly added to v10 recommended
+		'preserve-caught-error': 'off', // newly added to v10 recommended
+		'no-shadow-restricted-names': ['error', { reportGlobalThis: false }], // v10 flipped reportGlobalThis default to true
+		// Size backstops against god-files and sprawling functions.
+		'max-lines': ['error', { max: 400, skipBlankLines: true, skipComments: true }],
+		'max-lines-per-function': ['error', { max: 80, skipBlankLines: true, skipComments: true }],
+		complexity: ['error', { max: 12 }],
+		'no-console': 'error', // use a logging facade, not console
 		...additionalRules,
 	};
 
@@ -14,5 +27,14 @@ export default ({ ignores = [], additionalRules = {}, additionalConfig = [] } =
 		...additionalConfig,
 		{ ignores },
 		{ rules },
+		// Tests are exempt from the size backstops.
+		{
+			files: ['**/*.{test,spec}.{js,jsx,ts,tsx,mjs,cjs,mts,cts}', '**/__tests__/**', '**/__mocks__/**'],
+			rules: {
+				'max-lines': 'off',
+				'max-lines-per-function': 'off',
+				complexity: 'off',
+			},
+		},
 	]);
 };

package/package.json

@@ -1,7 +1,7 @@
 {
 	"name": "@niondigital/eslint-config-base",
 	"type": "module",
-	"version": "3.1.0",
+	"version": "5.0.0",
 	"author": "Dominik Gallitzendörfer <dominik.gallitzendoerfer@nion-digital.com>",
 	"main": "./config.js",
 	"repository": "https://github.com/niondigital/javascript-style",
@@ -11,10 +11,10 @@
 		"eslint-config"
 	],
 	"peerDependencies": {
-		"@eslint/js": "^9.37.0",
-		"eslint": "^9.37.0",
-		"typescript": "^5.9.3",
-		"typescript-eslint": "^8.46.0"
+		"@eslint/js": "^10.0.1",
+		"eslint": "^10.5.0",
+		"typescript": "^6.0.3",
+		"typescript-eslint": "^8.61.1"
 	},
-	"gitHead": "189bdd8ef1105fa32304738f3c7745945b82dbcb"
+	"gitHead": "0b2cf8519a4fd029222f5d70cb1f94523e1d34de"
 }