@ninetailed/experience.js-plugin-preview 7.17.2 → 7.17.5

package/index.cjs.js

@@ -5,6 +5,7 @@ Object.defineProperty(exports, '__esModule', { value: true });
 var experience_jsShared = require('@ninetailed/experience.js-shared');
 var experience_js = require('@ninetailed/experience.js');
 var experience_jsPluginAnalytics = require('@ninetailed/experience.js-plugin-analytics');
+var radash = require('radash');
 
 function _interopNamespace(e) {
     if (e && e.__esModule) return e;
@@ -229,21 +230,20 @@ class NinetailedPreviewPlugin extends experience_jsPluginAnalytics.NinetailedPlu
         // Handle entry replacements as before
         const entryReplacementComponents = experience.components.filter(component => component.type === experience_jsShared.ComponentTypeEnum.EntryReplacement && 'id' in component.baseline);
         const baselineComponent = entryReplacementComponents.find(component => component.baseline.id === baseline.id);
-        // Get the selected variant index
         const variantIndex = this.pluginApi.experienceVariantIndexes[experience.id];
-        // Handle variable components for this experience (NEW CODE)
-        if (variantIndex !== undefined) {
-          // Process all variable components for this experience
+        // Natural evaluation should not create overwrites, letting the core SDK handle variable evaluation
+        if (variantIndex !== undefined && this.experienceVariantIndexOverwrites[experience.id] !== undefined) {
+          // Only set variable overwrites when there's an explicit preview override for this experience
           const variableComponents = experience.components.filter(component => component.type === experience_jsShared.ComponentTypeEnum.InlineVariable);
           // Set variable values based on the selected variant index
           variableComponents.forEach(component => {
             const key = component.key;
             let value;
             if (variantIndex === 0) {
-              value = component.baseline;
+              value = component.baseline.value;
             } else {
               const variant = component.variants[variantIndex - 1];
-              value = variant && 'value' in variant ? variant.value : component.baseline;
+              value = variant && 'value' in variant ? variant.value : component.baseline.value;
             }
             // Set the variable in our changes system
             this.setVariableValue({
@@ -397,29 +397,28 @@ class NinetailedPreviewPlugin extends experience_jsPluginAnalytics.NinetailedPlu
       experience_jsShared.logger.warn(`You cannot deactivate an unknown audience (id: ${id}). How did you get it in the first place?`);
       return;
     }
-    this.experienceVariantIndexOverwrites = Object.entries(this.experienceVariantIndexOverwrites).filter(([key, _]) => {
-      return !this.experiences.filter(experience => {
-        var _b;
-        return ((_b = experience.audience) === null || _b === void 0 ? void 0 : _b.id) === id;
-      }).map(experience => experience.id).includes(key);
-    }).reduce((acc, [key, value]) => {
-      return Object.assign(Object.assign({}, acc), {
-        [key]: value
-      });
-    }, {});
-    this.audienceOverwrites = Object.assign(Object.assign({}, this.audienceOverwrites), {
-      [id]: false
-    });
-    this.onChange();
-    this.experiences.filter(experience => {
+    // Identify all experiences that belong to this audience
+    const experiencesToReset = this.experiences.filter(experience => {
       var _b;
       return ((_b = experience.audience) === null || _b === void 0 ? void 0 : _b.id) === id;
-    }).forEach(experience => {
+    });
+    // 1. Reset each experience to baseline BEFORE removing the audience so the guard in setExperienceVariant passes
+    experiencesToReset.forEach(experience => {
       this.setExperienceVariant({
         experienceId: experience.id,
         variantIndex: 0
       });
     });
+    // 2. Remove experience variant index overwrites for these experiences
+    const experienceIdsToReset = experiencesToReset.map(e => e.id);
+    this.experienceVariantIndexOverwrites = Object.fromEntries(Object.entries(this.experienceVariantIndexOverwrites).filter(([key]) => !experienceIdsToReset.includes(key)));
+    // 3. Remove any variable overwrites that were set for these experiences (prevents being stuck on a variant value)
+    if (experienceIdsToReset.length > 0) {
+      this.variableOverwrites = Object.fromEntries(Object.entries(this.variableOverwrites).filter(([, change]) => {
+        var _b;
+        return !(((_b = change.meta) === null || _b === void 0 ? void 0 : _b.experienceId) && experienceIdsToReset.includes(change.meta.experienceId));
+      }));
+    }
     this.audienceOverwrites = Object.assign(Object.assign({}, this.audienceOverwrites), {
       [id]: false
     });
@@ -433,6 +432,22 @@ class NinetailedPreviewPlugin extends experience_jsPluginAnalytics.NinetailedPlu
       experience_jsShared.logger.warn(`You cannot reset an unknown audience (id: ${id}). How did you get it in the first place?`);
       return;
     }
+    // Identify all experiences that belong to this audience
+    const experiencesToReset = this.experiences.filter(experience => {
+      var _b;
+      return ((_b = experience.audience) === null || _b === void 0 ? void 0 : _b.id) === id;
+    });
+    if (experiencesToReset.length > 0) {
+      const experienceIdsToReset = experiencesToReset.map(e => e.id);
+      // 1. Clear any variable overwrites that were set for these experiences (allows natural evaluation)
+      this.variableOverwrites = Object.fromEntries(Object.entries(this.variableOverwrites).filter(([, change]) => {
+        var _b;
+        return !(((_b = change.meta) === null || _b === void 0 ? void 0 : _b.experienceId) && experienceIdsToReset.includes(change.meta.experienceId));
+      }));
+      // 2. Clear experience variant index overwrites for these experiences (allows natural variant selection)
+      this.experienceVariantIndexOverwrites = Object.fromEntries(Object.entries(this.experienceVariantIndexOverwrites).filter(([key]) => !experienceIdsToReset.includes(key)));
+    }
+    // 3. Remove audience override (allows natural audience evaluation)
     const _b = this.audienceOverwrites,
       _c = id;
       _b[_c];
@@ -519,7 +534,7 @@ class NinetailedPreviewPlugin extends experience_jsPluginAnalytics.NinetailedPlu
     }
     const overrideKey = `${experienceId}:${key}`;
     // Only create new object if actually changing
-    if (((_b = this.variableOverwrites[overrideKey]) === null || _b === void 0 ? void 0 : _b.value) === value) {
+    if (radash.isEqual((_b = this.variableOverwrites[overrideKey]) === null || _b === void 0 ? void 0 : _b.value, value)) {
       return; // No change needed
     }
 
@@ -556,7 +571,7 @@ class NinetailedPreviewPlugin extends experience_jsPluginAnalytics.NinetailedPlu
   get pluginApi() {
     var _b;
     return {
-      version: "7.17.2" ,
+      version: "7.17.5" ,
       open: this.open.bind(this),
       close: this.close.bind(this),
       toggle: this.toggle.bind(this),

package/index.esm.js

@@ -1,6 +1,7 @@
 import { logger, ComponentTypeEnum, ChangeTypes, unionBy } from '@ninetailed/experience.js-shared';
 import { OnChangeEmitter, PROFILE_CHANGE, isExperienceMatch, selectDistribution } from '@ninetailed/experience.js';
 import { NinetailedPlugin } from '@ninetailed/experience.js-plugin-analytics';
+import { isEqual } from 'radash';
 
 function _objectWithoutPropertiesLoose(source, excluded) {
   if (source == null) return {};
@@ -202,13 +203,11 @@ class NinetailedPreviewPlugin extends NinetailedPlugin {
         // Handle entry replacements as before
         const entryReplacementComponents = experience.components.filter(component => component.type === ComponentTypeEnum.EntryReplacement && 'id' in component.baseline);
         const baselineComponent = entryReplacementComponents.find(component => component.baseline.id === baseline.id);
-
-        // Get the selected variant index
         const variantIndex = this.pluginApi.experienceVariantIndexes[experience.id];
 
-        // Handle variable components for this experience (NEW CODE)
-        if (variantIndex !== undefined) {
-          // Process all variable components for this experience
+        // Natural evaluation should not create overwrites, letting the core SDK handle variable evaluation
+        if (variantIndex !== undefined && this.experienceVariantIndexOverwrites[experience.id] !== undefined) {
+          // Only set variable overwrites when there's an explicit preview override for this experience
           const variableComponents = experience.components.filter(component => component.type === ComponentTypeEnum.InlineVariable);
 
           // Set variable values based on the selected variant index
@@ -216,10 +215,10 @@ class NinetailedPreviewPlugin extends NinetailedPlugin {
             const key = component.key;
             let value;
             if (variantIndex === 0) {
-              value = component.baseline;
+              value = component.baseline.value;
             } else {
               const variant = component.variants[variantIndex - 1];
-              value = variant && 'value' in variant ? variant.value : component.baseline;
+              value = variant && 'value' in variant ? variant.value : component.baseline.value;
             }
 
             // Set the variable in our changes system
@@ -379,29 +378,32 @@ class NinetailedPreviewPlugin extends NinetailedPlugin {
       logger.warn(`You cannot deactivate an unknown audience (id: ${id}). How did you get it in the first place?`);
       return;
     }
-    this.experienceVariantIndexOverwrites = Object.entries(this.experienceVariantIndexOverwrites).filter(([key, _]) => {
-      return !this.experiences.filter(experience => {
-        var _experience$audience2;
-        return ((_experience$audience2 = experience.audience) == null ? void 0 : _experience$audience2.id) === id;
-      }).map(experience => experience.id).includes(key);
-    }).reduce((acc, [key, value]) => {
-      return Object.assign({}, acc, {
-        [key]: value
-      });
-    }, {});
-    this.audienceOverwrites = Object.assign({}, this.audienceOverwrites, {
-      [id]: false
+
+    // Identify all experiences that belong to this audience
+    const experiencesToReset = this.experiences.filter(experience => {
+      var _experience$audience2;
+      return ((_experience$audience2 = experience.audience) == null ? void 0 : _experience$audience2.id) === id;
     });
-    this.onChange();
-    this.experiences.filter(experience => {
-      var _experience$audience3;
-      return ((_experience$audience3 = experience.audience) == null ? void 0 : _experience$audience3.id) === id;
-    }).forEach(experience => {
+
+    // 1. Reset each experience to baseline BEFORE removing the audience so the guard in setExperienceVariant passes
+    experiencesToReset.forEach(experience => {
       this.setExperienceVariant({
         experienceId: experience.id,
         variantIndex: 0
       });
     });
+
+    // 2. Remove experience variant index overwrites for these experiences
+    const experienceIdsToReset = experiencesToReset.map(e => e.id);
+    this.experienceVariantIndexOverwrites = Object.fromEntries(Object.entries(this.experienceVariantIndexOverwrites).filter(([key]) => !experienceIdsToReset.includes(key)));
+
+    // 3. Remove any variable overwrites that were set for these experiences (prevents being stuck on a variant value)
+    if (experienceIdsToReset.length > 0) {
+      this.variableOverwrites = Object.fromEntries(Object.entries(this.variableOverwrites).filter(([, change]) => {
+        var _change$meta;
+        return !((_change$meta = change.meta) != null && _change$meta.experienceId && experienceIdsToReset.includes(change.meta.experienceId));
+      }));
+    }
     this.audienceOverwrites = Object.assign({}, this.audienceOverwrites, {
       [id]: false
     });
@@ -415,6 +417,26 @@ class NinetailedPreviewPlugin extends NinetailedPlugin {
       logger.warn(`You cannot reset an unknown audience (id: ${id}). How did you get it in the first place?`);
       return;
     }
+
+    // Identify all experiences that belong to this audience
+    const experiencesToReset = this.experiences.filter(experience => {
+      var _experience$audience3;
+      return ((_experience$audience3 = experience.audience) == null ? void 0 : _experience$audience3.id) === id;
+    });
+    if (experiencesToReset.length > 0) {
+      const experienceIdsToReset = experiencesToReset.map(e => e.id);
+
+      // 1. Clear any variable overwrites that were set for these experiences (allows natural evaluation)
+      this.variableOverwrites = Object.fromEntries(Object.entries(this.variableOverwrites).filter(([, change]) => {
+        var _change$meta2;
+        return !((_change$meta2 = change.meta) != null && _change$meta2.experienceId && experienceIdsToReset.includes(change.meta.experienceId));
+      }));
+
+      // 2. Clear experience variant index overwrites for these experiences (allows natural variant selection)
+      this.experienceVariantIndexOverwrites = Object.fromEntries(Object.entries(this.experienceVariantIndexOverwrites).filter(([key]) => !experienceIdsToReset.includes(key)));
+    }
+
+    // 3. Remove audience override (allows natural audience evaluation)
     const _this$audienceOverwri = this.audienceOverwrites,
       audienceOverwrites = _objectWithoutPropertiesLoose(_this$audienceOverwri, [id].map(_toPropertyKey));
     this.audienceOverwrites = audienceOverwrites;
@@ -502,7 +524,7 @@ class NinetailedPreviewPlugin extends NinetailedPlugin {
     const overrideKey = `${experienceId}:${key}`;
 
     // Only create new object if actually changing
-    if (((_this$variableOverwri = this.variableOverwrites[overrideKey]) == null ? void 0 : _this$variableOverwri.value) === value) {
+    if (isEqual((_this$variableOverwri = this.variableOverwrites[overrideKey]) == null ? void 0 : _this$variableOverwri.value, value)) {
       return; // No change needed
     }
 
@@ -542,7 +564,7 @@ class NinetailedPreviewPlugin extends NinetailedPlugin {
   get pluginApi() {
     var _this$profile;
     return {
-      version: "7.17.2" ,
+      version: "7.17.5" ,
       open: this.open.bind(this),
       close: this.close.bind(this),
       toggle: this.toggle.bind(this),
@@ -645,9 +667,9 @@ class NinetailedPreviewPlugin extends NinetailedPlugin {
 
     // Filter out changes that we're overriding
     const filteredChanges = inputChanges.filter(change => {
-      var _change$meta;
+      var _change$meta3;
       if (change.type !== ChangeTypes.Variable) return true;
-      const changeKey = (_change$meta = change.meta) != null && _change$meta.experienceId ? this.getOverrideKey(change.meta.experienceId, change.key) : change.key;
+      const changeKey = (_change$meta3 = change.meta) != null && _change$meta3.experienceId ? this.getOverrideKey(change.meta.experienceId, change.key) : change.key;
       return !this.variableOverwrites[changeKey];
     });
     const effectiveChanges = [...filteredChanges, ...Object.values(this.variableOverwrites)];

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ninetailed/experience.js-plugin-preview",
-  "version": "7.17.2",
+  "version": "7.17.5",
   "description": "Ninetailed SDK plugin for preview",
   "license": "MIT",
   "repository": {
@@ -15,10 +15,11 @@
     "a/b testing"
   ],
   "dependencies": {
-    "@ninetailed/experience.js-shared": "7.17.2",
-    "@ninetailed/experience.js": "7.17.2",
-    "@ninetailed/experience.js-preview-bridge": "7.17.2",
-    "@ninetailed/experience.js-plugin-analytics": "7.17.2"
+    "@ninetailed/experience.js-shared": "7.17.5",
+    "@ninetailed/experience.js": "7.17.5",
+    "@ninetailed/experience.js-preview-bridge": "7.17.5",
+    "@ninetailed/experience.js-plugin-analytics": "7.17.5",
+    "radash": "10.9.0"
   },
   "module": "./index.esm.js",
   "main": "./index.cjs.js"