@nifrajs/cli 4.0.0 → 4.0.2

package/src/sync-manifest.ts

@@ -21,6 +21,14 @@ const GENERATED_MARKER = "GENERATED by @nifrajs/web generateServerManifest"
 // routes dir relative to the manifest and strips imports to route-relative keys.
 const ROUTES_PREFIX = /["'](\.{1,2}(?:\/[^"'/]+)*?\/routes\/)[^"']+["']/
 const IGNORED = /(^|\/)(node_modules|dist(-[a-z0-9]+)?|build|\.nifra|\.git|\.wrangler|coverage)\//
+// The fs codes that mean the routes dir is absent or unreadable. Every other throw is the route table
+// refusing to build, which must fail the command rather than read as "no manifest found".
+const ROUTES_DIR_UNAVAILABLE = new Set(["ENOENT", "ENOTDIR", "EACCES", "EPERM"])
+
+function routesDirUnavailable(error: unknown): boolean {
+  if (typeof error !== "object" || error === null || !("code" in error)) return false
+  return typeof error.code === "string" && ROUTES_DIR_UNAVAILABLE.has(error.code)
+}
 
 export interface SyncManifestResult {
   /** The committed server-manifest file (relative to cwd). */
@@ -34,12 +42,16 @@ export interface SyncManifestResult {
   /** Set when the sync was REFUSED because discovery found zero routes for a manifest that had some
    * (`routes/` likely emptied by mistake) - the manifest was left untouched rather than wiped. */
   readonly refusedEmpty?: boolean
+  /** Set when the `routes/` tree could not be built into a route table (a duplicate route, two routes of
+   * one shape sharing a path, ...) - the manifest was left untouched and the sync failed. */
+  readonly error?: string
 }
 
 /**
  * Discover every generated `server-manifest.ts` under `cwd` and re-sync its route table from the live
  * `routes/` tree, preserving baked client assets. Returns one result per generated manifest. Never throws
- * on a per-manifest miss (an unreadable/absent routes dir is skipped).
+ * on a per-manifest failure: an absent or unreadable routes dir is skipped, and a route table that fails
+ * to build is reported in that manifest's `error`.
  */
 export async function syncServerManifests(cwd: string): Promise<SyncManifestResult[]> {
   const { discoverRoutes } = await import("@nifrajs/web/fs")
@@ -60,8 +72,11 @@ export async function syncServerManifests(cwd: string): Promise<SyncManifestResu
     let next: string
     try {
       next = resyncServerManifestSource(source, discoverRoutes(routesDir), routesPrefix)
-    } catch {
-      continue // routes dir gone/unreadable - not a manifest we can sync
+    } catch (error) {
+      if (routesDirUnavailable(error)) continue // not a manifest we can sync
+      const message = error instanceof Error ? error.message : String(error)
+      results.push({ file: rel, changed: false, added: [], removed: [], error: message })
+      continue
     }
     const before = parseManifestRouteFiles(source, routesPrefix)
     const after = parseManifestRouteFiles(next, routesPrefix)
@@ -81,33 +96,48 @@ export async function syncServerManifests(cwd: string): Promise<SyncManifestResu
   return results.sort((a, b) => codeUnitOrder(a.file, b.file))
 }
 
-/** CLI entry: sync every generated manifest, print a per-file summary + the client-rebuild caveat. */
-export async function runSyncManifest(cwd: string): Promise<boolean> {
-  const results = await syncServerManifests(cwd)
-  if (results.length === 0) {
-    console.log("nifra sync-manifest: no generated server-manifest.ts found under this directory.")
-    return true
-  }
+/** True when no manifest's route table failed to build. */
+export function syncManifestsOk(results: readonly SyncManifestResult[]): boolean {
+  return results.every((r) => r.error === undefined)
+}
+
+/** Per-file summary lines + the client-rebuild caveat. */
+export function renderSyncManifestResults(results: readonly SyncManifestResult[]): string[] {
+  if (results.length === 0)
+    return ["nifra sync-manifest: no generated server-manifest.ts found under this directory."]
+  const lines: string[] = []
   let anyChanged = false
   for (const r of results) {
-    if (r.refusedEmpty) {
-      console.log(
+    if (r.error !== undefined) {
+      lines.push(
+        `✖ ${r.file}: routes/ does not build a route table; left untouched.`,
+        `    ${r.error}`,
+      )
+    } else if (r.refusedEmpty) {
+      lines.push(
         `⚠ ${r.file}: refused - routes/ has zero routes but the manifest had some; left untouched (delete the manifest yourself if this is intentional).`,
       )
     } else if (r.changed) {
       anyChanged = true
-      console.log(`✓ synced ${r.file}`)
-      if (r.added.length > 0) console.log(`    added:   ${r.added.join(", ")}`)
-      if (r.removed.length > 0) console.log(`    removed: ${r.removed.join(", ")}`)
+      lines.push(`✓ synced ${r.file}`)
+      if (r.added.length > 0) lines.push(`    added:   ${r.added.join(", ")}`)
+      if (r.removed.length > 0) lines.push(`    removed: ${r.removed.join(", ")}`)
     } else {
-      console.log(`• ${r.file} already in sync`)
+      lines.push(`• ${r.file} already in sync`)
     }
   }
   if (anyChanged) {
-    console.log(
+    lines.push(
       "\nRe-synced the server manifest's route table. If you added or changed a HYDRATING route\n" +
         "component (not just a loader / SSR-only route), also run a full build so the client bundle matches.",
     )
   }
-  return true
+  return lines
+}
+
+/** CLI entry: sync every generated manifest and print the summary. False when a route table failed to build. */
+export async function runSyncManifest(cwd: string): Promise<boolean> {
+  const results = await syncServerManifests(cwd)
+  console.log(renderSyncManifestResults(results).join("\n"))
+  return syncManifestsOk(results)
 }