@nielspeter/eess-ts 0.4.0 → 0.5.0

package/dist/rules/metrics.js

@@ -17,38 +17,69 @@ function getMemberName(cls, member) {
     return `${clsName}.constructor`;
 }
 /**
- * No method/constructor/getter/setter in the class may exceed the given
- * cyclomatic complexity.
+ * A ceiling on one measurement of every callable member of every class.
  *
- * @example
- * ```ts
- * import { maxCyclomaticComplexity } from '@nielspeter/eess-ts/rules/metrics'
+ * `maxCyclomaticComplexity`, `maxMethodLines` and `maxParameters` were the same
+ * nested walk three times over — `no-copy-paste` reported them at 98% — and the
+ * walk is the part that must not drift: a metric that visited methods but not
+ * accessors would report a clean ceiling for a class whose getter breaches it,
+ * which is a pass constructed from a partial scan (ADR-010).
  *
- * classes(p).should().satisfy(maxCyclomaticComplexity(15)).check()
- * ```
+ * `unit` is threaded rather than derived from `metric`: `lines` kept its name
+ * when `linesOfCode` stopped counting comments, and the baseline refuses to
+ * compare across a unit change precisely so that silent tripling cannot happen
+ * again (bug 0171). A metric whose name already says what it counts passes
+ * nothing here.
  */
-export function maxCyclomaticComplexity(threshold) {
+function memberCeiling(threshold, spec) {
     return {
-        description: `have no method with cyclomatic complexity > ${String(threshold)}`,
+        description: spec.description,
         evaluate(elements, context) {
             const violations = [];
             for (const cls of elements) {
                 for (const member of getClassMembers(cls)) {
-                    const cc = cyclomaticComplexity(member.getBody());
-                    if (cc > threshold) {
-                        violations.push(metricViolation(member, {
-                            metric: 'complexity',
-                            measured: cc,
-                            qualifiedName: getMemberName(cls, member),
-                            message: `${getMemberName(cls, member)} has cyclomatic complexity ${String(cc)} (max: ${String(threshold)}) — split into smaller methods`,
-                        }, context));
-                    }
+                    const value = spec.measure(member);
+                    if (value <= threshold)
+                        continue;
+                    const name = getMemberName(cls, member);
+                    violations.push(metricViolation(member, {
+                        metric: spec.metric,
+                        ...(spec.unit === undefined ? {} : { unit: spec.unit }),
+                        // Written long-hand deliberately: `measured,` is a
+                        // ShorthandPropertyAssignment, and the producer census in
+                        // `every-metric-finding-carries-its-unit.test.ts` walks
+                        // PropertyAssignment. Shorthand here made this producer
+                        // invisible to it — the census now sees both kinds, and this
+                        // spelling keeps the two from having to agree twice.
+                        measured: value,
+                        qualifiedName: name,
+                        message: spec.message(name, value),
+                    }, context));
                 }
             }
             return violations;
         },
     };
 }
+/**
+ * No method/constructor/getter/setter in the class may exceed the given
+ * cyclomatic complexity.
+ *
+ * @example
+ * ```ts
+ * import { maxCyclomaticComplexity } from '@nielspeter/eess-ts/rules/metrics'
+ *
+ * classes(p).should().satisfy(maxCyclomaticComplexity(15)).check()
+ * ```
+ */
+export function maxCyclomaticComplexity(threshold) {
+    return memberCeiling(threshold, {
+        description: `have no method with cyclomatic complexity > ${String(threshold)}`,
+        metric: 'complexity',
+        measure: (member) => cyclomaticComplexity(member.getBody()),
+        message: (name, cc) => `${name} has cyclomatic complexity ${String(cc)} (max: ${String(threshold)}) — split into smaller methods`,
+    });
+}
 /**
  * No class may exceed the given number of CODE lines — comments and blank
  * lines are not counted (bug 0170).
@@ -93,29 +124,15 @@ export function maxClassLines(threshold) {
  * ```
  */
 export function maxMethodLines(threshold) {
-    return {
+    return memberCeiling(threshold, {
         description: `have no method longer than ${String(threshold)} code lines`,
-        evaluate(elements, context) {
-            const violations = [];
-            for (const cls of elements) {
-                for (const member of getClassMembers(cls)) {
-                    const loc = linesOfCode(member);
-                    if (loc > threshold) {
-                        violations.push(metricViolation(member, {
-                            metric: 'lines',
-                            // `code-lines` since bug 0170 — the metric kept its name when it stopped
-                            // counting comments, and the baseline must not compare across that.
-                            unit: 'code-lines',
-                            measured: loc,
-                            qualifiedName: getMemberName(cls, member),
-                            message: `${getMemberName(cls, member)} has ${String(loc)} code lines (max: ${String(threshold)})`,
-                        }, context));
-                    }
-                }
-            }
-            return violations;
-        },
-    };
+        metric: 'lines',
+        // `code-lines` since bug 0170 — the metric kept its name when it stopped
+        // counting comments, and the baseline must not compare across that.
+        unit: 'code-lines',
+        measure: (member) => linesOfCode(member),
+        message: (name, loc) => `${name} has ${String(loc)} code lines (max: ${String(threshold)})`,
+    });
 }
 /**
  * No class may have more than the given number of methods.
@@ -161,26 +178,12 @@ export function maxMethods(threshold) {
  * ```
  */
 export function maxParameters(threshold) {
-    return {
+    return memberCeiling(threshold, {
         description: `have no method with more than ${String(threshold)} parameters`,
-        evaluate(elements, context) {
-            const violations = [];
-            for (const cls of elements) {
-                for (const member of getClassMembers(cls)) {
-                    const params = member.getParameters().length;
-                    if (params > threshold) {
-                        violations.push(metricViolation(member, {
-                            metric: 'parameters',
-                            measured: params,
-                            qualifiedName: getMemberName(cls, member),
-                            message: `${getMemberName(cls, member)} has ${String(params)} parameters (max: ${String(threshold)}) — use an options object`,
-                        }, context));
-                    }
-                }
-            }
-            return violations;
-        },
-    };
+        metric: 'parameters',
+        measure: (member) => member.getParameters().length,
+        message: (name, params) => `${name} has ${String(params)} parameters (max: ${String(threshold)}) — use an options object`,
+    });
 }
 // Re-export function-level metric conditions from the same sub-path
 export { maxFunctionComplexity, maxFunctionLines, maxFunctionParameters, } from './metrics-function.js';

package/dist/rules/metrics.js.map

@@ -1 +1 @@
-{"version":3,"file":"metrics.js","sourceRoot":"","sources":["../../src/rules/metrics.ts"],"names":[],"mappings":"AASA,OAAO,EAAE,oBAAoB,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAA;AAC5E,OAAO,EAAE,eAAe,EAAE,MAAM,6BAA6B,CAAA;AAS7D,SAAS,eAAe,CAAC,GAAqB;IAC5C,OAAO;QACL,GAAG,GAAG,CAAC,UAAU,EAAE;QACnB,GAAG,GAAG,CAAC,eAAe,EAAE;QACxB,GAAG,GAAG,CAAC,eAAe,EAAE;QACxB,GAAG,GAAG,CAAC,eAAe,EAAE;KACzB,CAAA;AACH,CAAC;AAED,SAAS,aAAa,CAAC,GAAqB,EAAE,MAAmB;IAC/D,MAAM,OAAO,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,CAAA;IAC9C,IAAI,SAAS,IAAI,MAAM,IAAI,OAAO,MAAM,CAAC,OAAO,KAAK,UAAU,EAAE,CAAC;QAChE,MAAM,UAAU,GAAG,MAAM,CAAC,MAAM,CAAC,OAAO,EAAE,CAAC,CAAA;QAC3C,OAAO,GAAG,OAAO,IAAI,UAAU,EAAE,CAAA;IACnC,CAAC;IACD,OAAO,GAAG,OAAO,cAAc,CAAA;AACjC,CAAC;AAED;;;;;;;;;;GAUG;AACH,MAAM,UAAU,uBAAuB,CAAC,SAAiB;IACvD,OAAO;QACL,WAAW,EAAE,+CAA+C,MAAM,CAAC,SAAS,CAAC,EAAE;QAC/E,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,KAAK,MAAM,MAAM,IAAI,eAAe,CAAC,GAAG,CAAC,EAAE,CAAC;oBAC1C,MAAM,EAAE,GAAG,oBAAoB,CAAC,MAAM,CAAC,OAAO,EAAE,CAAC,CAAA;oBACjD,IAAI,EAAE,GAAG,SAAS,EAAE,CAAC;wBACnB,UAAU,CAAC,IAAI,CACb,eAAe,CACb,MAAM,EACN;4BACE,MAAM,EAAE,YAAY;4BACpB,QAAQ,EAAE,EAAE;4BACZ,aAAa,EAAE,aAAa,CAAC,GAAG,EAAE,MAAM,CAAC;4BACzC,OAAO,EAAE,GAAG,aAAa,CAAC,GAAG,EAAE,MAAM,CAAC,8BAA8B,MAAM,CAAC,EAAE,CAAC,UAAU,MAAM,CAAC,SAAS,CAAC,gCAAgC;yBAC1I,EACD,OAAO,CACR,CACF,CAAA;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;;GAUG;AACH,MAAM,UAAU,aAAa,CAAC,SAAiB;IAC7C,OAAO;QACL,WAAW,EAAE,qBAAqB,MAAM,CAAC,SAAS,CAAC,aAAa;QAChE,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,MAAM,GAAG,GAAG,WAAW,CAAC,GAAG,CAAC,CAAA;gBAC5B,IAAI,GAAG,GAAG,SAAS,EAAE,CAAC;oBACpB,UAAU,CAAC,IAAI,CACb,eAAe,CACb,GAAG,EACH;wBACE,MAAM,EAAE,OAAO;wBACf,yEAAyE;wBACzE,oEAAoE;wBACpE,IAAI,EAAE,YAAY;wBAClB,QAAQ,EAAE,GAAG;wBACb,OAAO,EAAE,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,QAAQ,MAAM,CAAC,GAAG,CAAC,qBAAqB,MAAM,CAAC,SAAS,CAAC,6CAA6C;qBACjJ,EACD,OAAO,CACR,CACF,CAAA;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;GASG;AACH,MAAM,UAAU,cAAc,CAAC,SAAiB;IAC9C,OAAO;QACL,WAAW,EAAE,8BAA8B,MAAM,CAAC,SAAS,CAAC,aAAa;QACzE,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,KAAK,MAAM,MAAM,IAAI,eAAe,CAAC,GAAG,CAAC,EAAE,CAAC;oBAC1C,MAAM,GAAG,GAAG,WAAW,CAAC,MAAM,CAAC,CAAA;oBAC/B,IAAI,GAAG,GAAG,SAAS,EAAE,CAAC;wBACpB,UAAU,CAAC,IAAI,CACb,eAAe,CACb,MAAM,EACN;4BACE,MAAM,EAAE,OAAO;4BACf,yEAAyE;4BACzE,oEAAoE;4BACpE,IAAI,EAAE,YAAY;4BAClB,QAAQ,EAAE,GAAG;4BACb,aAAa,EAAE,aAAa,CAAC,GAAG,EAAE,MAAM,CAAC;4BACzC,OAAO,EAAE,GAAG,aAAa,CAAC,GAAG,EAAE,MAAM,CAAC,QAAQ,MAAM,CAAC,GAAG,CAAC,qBAAqB,MAAM,CAAC,SAAS,CAAC,GAAG;yBACnG,EACD,OAAO,CACR,CACF,CAAA;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,UAAU,CAAC,SAAiB;IAC1C,OAAO;QACL,WAAW,EAAE,qBAAqB,MAAM,CAAC,SAAS,CAAC,UAAU;QAC7D,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,MAAM,KAAK,GAAG,GAAG,CAAC,UAAU,EAAE,CAAC,MAAM,CAAA;gBACrC,IAAI,KAAK,GAAG,SAAS,EAAE,CAAC;oBACtB,UAAU,CAAC,IAAI,CACb,eAAe,CACb,GAAG,EACH;wBACE,MAAM,EAAE,SAAS;wBACjB,QAAQ,EAAE,KAAK;wBACf,OAAO,EAAE,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,QAAQ,MAAM,CAAC,KAAK,CAAC,kBAAkB,MAAM,CAAC,SAAS,CAAC,6CAA6C;qBAChJ,EACD,OAAO,CACR,CACF,CAAA;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,aAAa,CAAC,SAAiB;IAC7C,OAAO;QACL,WAAW,EAAE,iCAAiC,MAAM,CAAC,SAAS,CAAC,aAAa;QAC5E,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,KAAK,MAAM,MAAM,IAAI,eAAe,CAAC,GAAG,CAAC,EAAE,CAAC;oBAC1C,MAAM,MAAM,GAAG,MAAM,CAAC,aAAa,EAAE,CAAC,MAAM,CAAA;oBAC5C,IAAI,MAAM,GAAG,SAAS,EAAE,CAAC;wBACvB,UAAU,CAAC,IAAI,CACb,eAAe,CACb,MAAM,EACN;4BACE,MAAM,EAAE,YAAY;4BACpB,QAAQ,EAAE,MAAM;4BAChB,aAAa,EAAE,aAAa,CAAC,GAAG,EAAE,MAAM,CAAC;4BACzC,OAAO,EAAE,GAAG,aAAa,CAAC,GAAG,EAAE,MAAM,CAAC,QAAQ,MAAM,CAAC,MAAM,CAAC,qBAAqB,MAAM,CAAC,SAAS,CAAC,2BAA2B;yBAC9H,EACD,OAAO,CACR,CACF,CAAA;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED,oEAAoE;AACpE,OAAO,EACL,qBAAqB,EACrB,gBAAgB,EAChB,qBAAqB,GACtB,MAAM,uBAAuB,CAAA"}
+{"version":3,"file":"metrics.js","sourceRoot":"","sources":["../../src/rules/metrics.ts"],"names":[],"mappings":"AASA,OAAO,EAAE,oBAAoB,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAA;AAC5E,OAAO,EAAE,eAAe,EAAE,MAAM,6BAA6B,CAAA;AAS7D,SAAS,eAAe,CAAC,GAAqB;IAC5C,OAAO;QACL,GAAG,GAAG,CAAC,UAAU,EAAE;QACnB,GAAG,GAAG,CAAC,eAAe,EAAE;QACxB,GAAG,GAAG,CAAC,eAAe,EAAE;QACxB,GAAG,GAAG,CAAC,eAAe,EAAE;KACzB,CAAA;AACH,CAAC;AAED,SAAS,aAAa,CAAC,GAAqB,EAAE,MAAmB;IAC/D,MAAM,OAAO,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,CAAA;IAC9C,IAAI,SAAS,IAAI,MAAM,IAAI,OAAO,MAAM,CAAC,OAAO,KAAK,UAAU,EAAE,CAAC;QAChE,MAAM,UAAU,GAAG,MAAM,CAAC,MAAM,CAAC,OAAO,EAAE,CAAC,CAAA;QAC3C,OAAO,GAAG,OAAO,IAAI,UAAU,EAAE,CAAA;IACnC,CAAC;IACD,OAAO,GAAG,OAAO,cAAc,CAAA;AACjC,CAAC;AAED;;;;;;;;;;;;;;GAcG;AACH,SAAS,aAAa,CACpB,SAAiB,EACjB,IAMC;IAED,OAAO;QACL,WAAW,EAAE,IAAI,CAAC,WAAW;QAC7B,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,KAAK,MAAM,MAAM,IAAI,eAAe,CAAC,GAAG,CAAC,EAAE,CAAC;oBAC1C,MAAM,KAAK,GAAG,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,CAAA;oBAClC,IAAI,KAAK,IAAI,SAAS;wBAAE,SAAQ;oBAChC,MAAM,IAAI,GAAG,aAAa,CAAC,GAAG,EAAE,MAAM,CAAC,CAAA;oBACvC,UAAU,CAAC,IAAI,CACb,eAAe,CACb,MAAM,EACN;wBACE,MAAM,EAAE,IAAI,CAAC,MAAM;wBACnB,GAAG,CAAC,IAAI,CAAC,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,CAAC;wBACvD,mDAAmD;wBACnD,0DAA0D;wBAC1D,wDAAwD;wBACxD,wDAAwD;wBACxD,6DAA6D;wBAC7D,qDAAqD;wBACrD,QAAQ,EAAE,KAAK;wBACf,aAAa,EAAE,IAAI;wBACnB,OAAO,EAAE,IAAI,CAAC,OAAO,CAAC,IAAI,EAAE,KAAK,CAAC;qBACnC,EACD,OAAO,CACR,CACF,CAAA;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;;GAUG;AACH,MAAM,UAAU,uBAAuB,CAAC,SAAiB;IACvD,OAAO,aAAa,CAAC,SAAS,EAAE;QAC9B,WAAW,EAAE,+CAA+C,MAAM,CAAC,SAAS,CAAC,EAAE;QAC/E,MAAM,EAAE,YAAY;QACpB,OAAO,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,oBAAoB,CAAC,MAAM,CAAC,OAAO,EAAE,CAAC;QAC3D,OAAO,EAAE,CAAC,IAAI,EAAE,EAAE,EAAE,EAAE,CACpB,GAAG,IAAI,8BAA8B,MAAM,CAAC,EAAE,CAAC,UAAU,MAAM,CAAC,SAAS,CAAC,gCAAgC;KAC7G,CAAC,CAAA;AACJ,CAAC;AAED;;;;;;;;;;GAUG;AACH,MAAM,UAAU,aAAa,CAAC,SAAiB;IAC7C,OAAO;QACL,WAAW,EAAE,qBAAqB,MAAM,CAAC,SAAS,CAAC,aAAa;QAChE,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,MAAM,GAAG,GAAG,WAAW,CAAC,GAAG,CAAC,CAAA;gBAC5B,IAAI,GAAG,GAAG,SAAS,EAAE,CAAC;oBACpB,UAAU,CAAC,IAAI,CACb,eAAe,CACb,GAAG,EACH;wBACE,MAAM,EAAE,OAAO;wBACf,yEAAyE;wBACzE,oEAAoE;wBACpE,IAAI,EAAE,YAAY;wBAClB,QAAQ,EAAE,GAAG;wBACb,OAAO,EAAE,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,QAAQ,MAAM,CAAC,GAAG,CAAC,qBAAqB,MAAM,CAAC,SAAS,CAAC,6CAA6C;qBACjJ,EACD,OAAO,CACR,CACF,CAAA;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;GASG;AACH,MAAM,UAAU,cAAc,CAAC,SAAiB;IAC9C,OAAO,aAAa,CAAC,SAAS,EAAE;QAC9B,WAAW,EAAE,8BAA8B,MAAM,CAAC,SAAS,CAAC,aAAa;QACzE,MAAM,EAAE,OAAO;QACf,yEAAyE;QACzE,oEAAoE;QACpE,IAAI,EAAE,YAAY;QAClB,OAAO,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,WAAW,CAAC,MAAM,CAAC;QACxC,OAAO,EAAE,CAAC,IAAI,EAAE,GAAG,EAAE,EAAE,CAAC,GAAG,IAAI,QAAQ,MAAM,CAAC,GAAG,CAAC,qBAAqB,MAAM,CAAC,SAAS,CAAC,GAAG;KAC5F,CAAC,CAAA;AACJ,CAAC;AAED;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,UAAU,CAAC,SAAiB;IAC1C,OAAO;QACL,WAAW,EAAE,qBAAqB,MAAM,CAAC,SAAS,CAAC,UAAU;QAC7D,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,MAAM,KAAK,GAAG,GAAG,CAAC,UAAU,EAAE,CAAC,MAAM,CAAA;gBACrC,IAAI,KAAK,GAAG,SAAS,EAAE,CAAC;oBACtB,UAAU,CAAC,IAAI,CACb,eAAe,CACb,GAAG,EACH;wBACE,MAAM,EAAE,SAAS;wBACjB,QAAQ,EAAE,KAAK;wBACf,OAAO,EAAE,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,QAAQ,MAAM,CAAC,KAAK,CAAC,kBAAkB,MAAM,CAAC,SAAS,CAAC,6CAA6C;qBAChJ,EACD,OAAO,CACR,CACF,CAAA;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,aAAa,CAAC,SAAiB;IAC7C,OAAO,aAAa,CAAC,SAAS,EAAE;QAC9B,WAAW,EAAE,iCAAiC,MAAM,CAAC,SAAS,CAAC,aAAa;QAC5E,MAAM,EAAE,YAAY;QACpB,OAAO,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,aAAa,EAAE,CAAC,MAAM;QAClD,OAAO,EAAE,CAAC,IAAI,EAAE,MAAM,EAAE,EAAE,CACxB,GAAG,IAAI,QAAQ,MAAM,CAAC,MAAM,CAAC,qBAAqB,MAAM,CAAC,SAAS,CAAC,2BAA2B;KACjG,CAAC,CAAA;AACJ,CAAC;AAED,oEAAoE;AACpE,OAAO,EACL,qBAAqB,EACrB,gBAAgB,EAChB,qBAAqB,GACtB,MAAM,uBAAuB,CAAA"}

package/dist/smells/clusters.d.ts

@@ -0,0 +1,78 @@
+import type { ArchFunction } from '../models/arch-function.js';
+import type { SimilarPair } from './similar-pairs.js';
+/**
+ * At least two bodies — a cluster is built from a pair, so it can never hold
+ * fewer.
+ *
+ * Typed rather than asserted so `clusterViolation` can be TOTAL. It used to
+ * return `ArchViolation | undefined` on a lookup that cannot fail, and the
+ * caller dropped that with `if (violation)` — a finding vanishing with no
+ * diagnostic. Architecture review of bug 0242 pointed out that the file
+ * rejected exactly that shape for `pairViolation` one screen above, with the
+ * argument that applies here word for word: unreachable today is not a defence,
+ * the type is what stops it becoming reachable.
+ */
+type NonEmptyMembers = readonly [ArchFunction, ArchFunction, ...ArchFunction[]];
+/** A group of bodies that are mutually reachable through reported similarity. */
+export interface SimilarCluster {
+    /**
+     * Members, in first-seen order — i.e. the source walk's, which is a property
+     * of the filesystem.
+     *
+     * The first is NOT what the violation anchors to; it was until bug 0242, and
+     * this comment said so for as long. `clusterViolation` picks the anchor by
+     * path then line, and sorts the members it shows, precisely so neither depends
+     * on this order.
+     */
+    readonly members: NonEmptyMembers;
+    /** The pairs that put these members in one group. */
+    readonly pairs: readonly SimilarPair[];
+    /** Highest similarity among {@link pairs}. */
+    readonly peakSimilarity: number;
+}
+/**
+ * Group reported pairs into connected components.
+ *
+ * A pair is the wrong unit of report and it is not a close call. Measured on a
+ * ~5,600-file production monorepo: 407 clusters produced **4,770** pair
+ * findings, the eight largest clusters alone produced 49% of them, one cluster
+ * of 89 members produced 398, and the worst single function was named 29 times.
+ *
+ * Every one of those findings can be true and the output is still unreadable,
+ * because N mutually-similar bodies carry ONE observation and emit N^2/2 lines
+ * of it. The observation is "these 89 share a shape", which is also the unit a
+ * reader can act on. That is what this returns.
+ */
+export declare function clusterPairs(pairs: readonly SimilarPair[]): SimilarCluster[];
+/**
+ * How likely a cluster is to be worth acting on, highest first.
+ *
+ * Not a filter and deliberately not a score change — the similarity number is
+ * left exactly as it was. This decides only what a reader sees first, because at
+ * 4,770 findings the order IS the product.
+ *
+ * The signal is the one the fingerprint throws away: a body's identifiers are
+ * ignored by design (that is what makes the score a type-2 clone score), and so
+ * is the DECLARATION's own name, which is where the evidence was. Measured over
+ * that same corpus, bucketed by how the two names relate:
+ *
+ * | bucket                        | share | reading                    |
+ * | ----------------------------- | ----- | -------------------------- |
+ * | different file, different name | 56%  | convergent idiom           |
+ * | same class                     | 20%  | siblings, often extractable |
+ * | different file, SAME name      | 14%  | a COPY of one function     |
+ * | same file, different class     | 10%  | co-located                 |
+ *
+ * Two pairs from that run, both scored 100%: `timestampPrefix` in two files (a
+ * literal copy) and two unrelated SDK wrapper methods (a shared idiom). Same
+ * number on screen, opposite verdicts, and the thing that separates them costs
+ * nothing to compute.
+ *
+ * **It is a ranking and not a filter on purpose.** Dropping the different-name
+ * bucket would discard real same-class duplication — one repository in that
+ * corpus has six `exists*` methods differing only in a table name. Dropping
+ * cross-file would have discarded the finding that led to bug 0227.
+ */
+export declare function clusterRank(cluster: SimilarCluster): number;
+export {};
+//# sourceMappingURL=clusters.d.ts.map

package/dist/smells/clusters.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"clusters.d.ts","sourceRoot":"","sources":["../../src/smells/clusters.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,4BAA4B,CAAA;AAC9D,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAA;AAErD;;;;;;;;;;;GAWG;AACH,KAAK,eAAe,GAAG,SAAS,CAAC,YAAY,EAAE,YAAY,EAAE,GAAG,YAAY,EAAE,CAAC,CAAA;AAE/E,iFAAiF;AACjF,MAAM,WAAW,cAAc;IAC7B;;;;;;;;OAQG;IACH,QAAQ,CAAC,OAAO,EAAE,eAAe,CAAA;IACjC,qDAAqD;IACrD,QAAQ,CAAC,KAAK,EAAE,SAAS,WAAW,EAAE,CAAA;IACtC,8CAA8C;IAC9C,QAAQ,CAAC,cAAc,EAAE,MAAM,CAAA;CAChC;AAED;;;;;;;;;;;;GAYG;AACH,wBAAgB,YAAY,CAAC,KAAK,EAAE,SAAS,WAAW,EAAE,GAAG,cAAc,EAAE,CAkE5E;AAED;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA4BG;AACH,wBAAgB,WAAW,CAAC,OAAO,EAAE,cAAc,GAAG,MAAM,CAa3D"}

package/dist/smells/clusters.js

@@ -0,0 +1,124 @@
+import { ArchConfigError } from '@nielspeter/eess';
+/**
+ * Group reported pairs into connected components.
+ *
+ * A pair is the wrong unit of report and it is not a close call. Measured on a
+ * ~5,600-file production monorepo: 407 clusters produced **4,770** pair
+ * findings, the eight largest clusters alone produced 49% of them, one cluster
+ * of 89 members produced 398, and the worst single function was named 29 times.
+ *
+ * Every one of those findings can be true and the output is still unreadable,
+ * because N mutually-similar bodies carry ONE observation and emit N^2/2 lines
+ * of it. The observation is "these 89 share a shape", which is also the unit a
+ * reader can act on. That is what this returns.
+ */
+export function clusterPairs(pairs) {
+    const parent = new Map();
+    const find = (x) => {
+        let root = parent.get(x) ?? x;
+        if (root === x) {
+            parent.set(x, x);
+            return x;
+        }
+        root = find(root);
+        parent.set(x, root);
+        return root;
+    };
+    const union = (a, b) => {
+        const ra = find(a);
+        const rb = find(b);
+        if (ra !== rb)
+            parent.set(ra, rb);
+    };
+    for (const pair of pairs)
+        union(pair.a, pair.b);
+    // First-seen order throughout, so the report is stable across runs. Map
+    // iteration order is insertion order, and `pairs` arrives in the order the
+    // comparison found them, which is the source-file walk order.
+    const byRoot = new Map();
+    const seen = new Set();
+    for (const pair of pairs) {
+        const root = find(pair.a);
+        let entry = byRoot.get(root);
+        if (!entry) {
+            entry = { members: [], pairs: [] };
+            byRoot.set(root, entry);
+        }
+        entry.pairs.push(pair);
+        for (const fn of [pair.a, pair.b]) {
+            if (seen.has(fn))
+                continue;
+            seen.add(fn);
+            entry.members.push(fn);
+        }
+    }
+    // Narrowed here, at the one place clusters are constructed, rather than at
+    // every place they are read. An entry exists only because a pair created it,
+    // and both of that pair's ends are pushed, so `members` always holds at least
+    // two — but the compiler cannot see that through `push`. A cluster that
+    // somehow held fewer is a broken invariant in THIS function, and dropping it
+    // silently at emission is what the type change exists to prevent, so it is
+    // reported as a configuration finding rather than filtered away.
+    return [...byRoot.values()].map((entry) => {
+        const [first, second, ...rest] = entry.members;
+        if (!first || !second) {
+            throw new ArchConfigError('duplicateBodies', 'a similarity cluster was built with fewer than two members, which cannot happen: ' +
+                'every cluster is created from a pair and both of its ends are recorded. ' +
+                'This is a defect in clusterPairs, not in the code being analysed.');
+        }
+        // Annotated, never cast (ADR-005): the annotation makes the compiler CHECK
+        // the literal is a valid `NonEmptyMembers`, where a cast would only assert
+        // it.
+        const members = [first, second, ...rest];
+        return {
+            members,
+            pairs: entry.pairs,
+            peakSimilarity: entry.pairs.reduce((best, p) => Math.max(best, p.similarity), 0),
+        };
+    });
+}
+/**
+ * How likely a cluster is to be worth acting on, highest first.
+ *
+ * Not a filter and deliberately not a score change — the similarity number is
+ * left exactly as it was. This decides only what a reader sees first, because at
+ * 4,770 findings the order IS the product.
+ *
+ * The signal is the one the fingerprint throws away: a body's identifiers are
+ * ignored by design (that is what makes the score a type-2 clone score), and so
+ * is the DECLARATION's own name, which is where the evidence was. Measured over
+ * that same corpus, bucketed by how the two names relate:
+ *
+ * | bucket                        | share | reading                    |
+ * | ----------------------------- | ----- | -------------------------- |
+ * | different file, different name | 56%  | convergent idiom           |
+ * | same class                     | 20%  | siblings, often extractable |
+ * | different file, SAME name      | 14%  | a COPY of one function     |
+ * | same file, different class     | 10%  | co-located                 |
+ *
+ * Two pairs from that run, both scored 100%: `timestampPrefix` in two files (a
+ * literal copy) and two unrelated SDK wrapper methods (a shared idiom). Same
+ * number on screen, opposite verdicts, and the thing that separates them costs
+ * nothing to compute.
+ *
+ * **It is a ranking and not a filter on purpose.** Dropping the different-name
+ * bucket would discard real same-class duplication — one repository in that
+ * corpus has six `exists*` methods differing only in a table name. Dropping
+ * cross-file would have discarded the finding that led to bug 0227.
+ */
+export function clusterRank(cluster) {
+    const bare = (fn) => (fn.getName() ?? '<anonymous>').split('.').pop() ?? '';
+    const file = (fn) => fn.getSourceFile().getFilePath();
+    let best = 0;
+    for (const pair of cluster.pairs) {
+        const sameFile = file(pair.a) === file(pair.b);
+        const sameName = bare(pair.a) === bare(pair.b);
+        // A copy of one function into another file is the most actionable thing
+        // this detector can find, and the cheapest to verify.
+        const score = !sameFile && sameName ? 3 : sameFile ? 2 : 1;
+        if (score > best)
+            best = score;
+    }
+    return best;
+}
+//# sourceMappingURL=clusters.js.map

package/dist/smells/clusters.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"clusters.js","sourceRoot":"","sources":["../../src/smells/clusters.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,eAAe,EAAE,MAAM,kBAAkB,CAAA;AAoClD;;;;;;;;;;;;GAYG;AACH,MAAM,UAAU,YAAY,CAAC,KAA6B;IACxD,MAAM,MAAM,GAAG,IAAI,GAAG,EAA8B,CAAA;IACpD,MAAM,IAAI,GAAG,CAAC,CAAe,EAAgB,EAAE;QAC7C,IAAI,IAAI,GAAG,MAAM,CAAC,GAAG,CAAC,CAAC,CAAC,IAAI,CAAC,CAAA;QAC7B,IAAI,IAAI,KAAK,CAAC,EAAE,CAAC;YACf,MAAM,CAAC,GAAG,CAAC,CAAC,EAAE,CAAC,CAAC,CAAA;YAChB,OAAO,CAAC,CAAA;QACV,CAAC;QACD,IAAI,GAAG,IAAI,CAAC,IAAI,CAAC,CAAA;QACjB,MAAM,CAAC,GAAG,CAAC,CAAC,EAAE,IAAI,CAAC,CAAA;QACnB,OAAO,IAAI,CAAA;IACb,CAAC,CAAA;IACD,MAAM,KAAK,GAAG,CAAC,CAAe,EAAE,CAAe,EAAQ,EAAE;QACvD,MAAM,EAAE,GAAG,IAAI,CAAC,CAAC,CAAC,CAAA;QAClB,MAAM,EAAE,GAAG,IAAI,CAAC,CAAC,CAAC,CAAA;QAClB,IAAI,EAAE,KAAK,EAAE;YAAE,MAAM,CAAC,GAAG,CAAC,EAAE,EAAE,EAAE,CAAC,CAAA;IACnC,CAAC,CAAA;IACD,KAAK,MAAM,IAAI,IAAI,KAAK;QAAE,KAAK,CAAC,IAAI,CAAC,CAAC,EAAE,IAAI,CAAC,CAAC,CAAC,CAAA;IAE/C,wEAAwE;IACxE,2EAA2E;IAC3E,8DAA8D;IAC9D,MAAM,MAAM,GAAG,IAAI,GAAG,EAAmE,CAAA;IACzF,MAAM,IAAI,GAAG,IAAI,GAAG,EAAgB,CAAA;IACpC,KAAK,MAAM,IAAI,IAAI,KAAK,EAAE,CAAC;QACzB,MAAM,IAAI,GAAG,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QACzB,IAAI,KAAK,GAAG,MAAM,CAAC,GAAG,CAAC,IAAI,CAAC,CAAA;QAC5B,IAAI,CAAC,KAAK,EAAE,CAAC;YACX,KAAK,GAAG,EAAE,OAAO,EAAE,EAAE,EAAE,KAAK,EAAE,EAAE,EAAE,CAAA;YAClC,MAAM,CAAC,GAAG,CAAC,IAAI,EAAE,KAAK,CAAC,CAAA;QACzB,CAAC;QACD,KAAK,CAAC,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;QACtB,KAAK,MAAM,EAAE,IAAI,CAAC,IAAI,CAAC,CAAC,EAAE,IAAI,CAAC,CAAC,CAAC,EAAE,CAAC;YAClC,IAAI,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC;gBAAE,SAAQ;YAC1B,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,CAAA;YACZ,KAAK,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;QACxB,CAAC;IACH,CAAC;IAED,2EAA2E;IAC3E,6EAA6E;IAC7E,8EAA8E;IAC9E,wEAAwE;IACxE,6EAA6E;IAC7E,2EAA2E;IAC3E,iEAAiE;IACjE,OAAO,CAAC,GAAG,MAAM,CAAC,MAAM,EAAE,CAAC,CAAC,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE;QACxC,MAAM,CAAC,KAAK,EAAE,MAAM,EAAE,GAAG,IAAI,CAAC,GAAG,KAAK,CAAC,OAAO,CAAA;QAC9C,IAAI,CAAC,KAAK,IAAI,CAAC,MAAM,EAAE,CAAC;YACtB,MAAM,IAAI,eAAe,CACvB,iBAAiB,EACjB,mFAAmF;gBACjF,0EAA0E;gBAC1E,mEAAmE,CACtE,CAAA;QACH,CAAC;QACD,2EAA2E;QAC3E,2EAA2E;QAC3E,MAAM;QACN,MAAM,OAAO,GAAoB,CAAC,KAAK,EAAE,MAAM,EAAE,GAAG,IAAI,CAAC,CAAA;QACzD,OAAO;YACL,OAAO;YACP,KAAK,EAAE,KAAK,CAAC,KAAK;YAClB,cAAc,EAAE,KAAK,CAAC,KAAK,CAAC,MAAM,CAAC,CAAC,IAAI,EAAE,CAAC,EAAE,EAAE,CAAC,IAAI,CAAC,GAAG,CAAC,IAAI,EAAE,CAAC,CAAC,UAAU,CAAC,EAAE,CAAC,CAAC;SACjF,CAAA;IACH,CAAC,CAAC,CAAA;AACJ,CAAC;AAED;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA4BG;AACH,MAAM,UAAU,WAAW,CAAC,OAAuB;IACjD,MAAM,IAAI,GAAG,CAAC,EAAgB,EAAU,EAAE,CAAC,CAAC,EAAE,CAAC,OAAO,EAAE,IAAI,aAAa,CAAC,CAAC,KAAK,CAAC,GAAG,CAAC,CAAC,GAAG,EAAE,IAAI,EAAE,CAAA;IACjG,MAAM,IAAI,GAAG,CAAC,EAAgB,EAAU,EAAE,CAAC,EAAE,CAAC,aAAa,EAAE,CAAC,WAAW,EAAE,CAAA;IAC3E,IAAI,IAAI,GAAG,CAAC,CAAA;IACZ,KAAK,MAAM,IAAI,IAAI,OAAO,CAAC,KAAK,EAAE,CAAC;QACjC,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,KAAK,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QAC9C,MAAM,QAAQ,GAAG,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,KAAK,IAAI,CAAC,IAAI,CAAC,CAAC,CAAC,CAAA;QAC9C,wEAAwE;QACxE,sDAAsD;QACtD,MAAM,KAAK,GAAG,CAAC,QAAQ,IAAI,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,CAAA;QAC1D,IAAI,KAAK,GAAG,IAAI;YAAE,IAAI,GAAG,KAAK,CAAA;IAChC,CAAC;IACD,OAAO,IAAI,CAAA;AACb,CAAC"}

package/dist/smells/duplicate-bodies.d.ts

@@ -65,13 +65,47 @@ export declare class DuplicateBodiesBuilder extends SmellBuilder {
     private collectFilteredFunctions;
     /** Build violations from similar pairs. */
     /**
-     * Report order: by folder when `.groupByFolder()` asked for it, otherwise the
-     * order the pairs were found in.
+     * Report order for pairs — which, measured, never has anything to order.
      *
-     * Extracted from {@link buildViolations} so that method is the violation
-     * shape and nothing else — presentation order is a separate decision.
+     * Extracted from {@link buildViolations} so that method is the violation shape
+     * and nothing else. Enforcement review of bug 0242 read this as a live defect
+     * (keyed on `a`, i.e. walk order, while the finding reports at the anchor).
+     * Probing it says otherwise: {@link buildViolations} is reached only from
+     * {@link buildClusterViolations} for a cluster of two or fewer members, and
+     * such a cluster carries exactly one pair. Instrumented to throw on more than
+     * one, the whole `packages/ts` suite (3604 tests) produced **zero** hits.
+     *
+     * So this cannot reorder anything today, and {@link orderedClusters} is what
+     * actually orders the output. The key is corrected anyway — being right if
+     * this ever becomes reachable costs one expression — but the correction fixes
+     * no observable behaviour, and saying otherwise would be the kind of unmeasured
+     * claim this repo keeps catching.
      */
     private orderedPairs;
+    /**
+     * One violation per CLUSTER of mutually-similar bodies, not per pair.
+     *
+     * A pair is the wrong unit and it is not a close call. Measured on a
+     * ~5,600-file production monorepo: 407 clusters emitted **4,770** pair
+     * findings — more findings than the 3,810 bodies that produced them. The
+     * eight largest clusters were 49% of the output, one cluster of 89 members
+     * emitted 398 lines, and the worst single function was named 29 times. Every
+     * one of those can be TRUE and the report is still unreadable, because N
+     * mutually-similar bodies carry one observation and emit N^2/2 lines of it.
+     *
+     * Two-member clusters — the common case — keep the exact message and identity
+     * they had before, so existing baselines for them are untouched. Only a group
+     * of three or more collapses, which is where the inflation lives.
+     */
+    /**
+     * Report order.
+     *
+     * Rank is presentation only — no pair is dropped and no score changes. At four
+     * thousand findings the ORDER is the product: what a reader sees first decides
+     * whether they read at all. `.groupByFolder()` still wins when asked for.
+     */
+    private orderedClusters;
+    private buildClusterViolations;
     private buildViolations;
 }
 //# sourceMappingURL=duplicate-bodies.d.ts.map

package/dist/smells/duplicate-bodies.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"duplicate-bodies.d.ts","sourceRoot":"","sources":["../../src/smells/duplicate-bodies.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,kBAAkB,CAAA;AAIvD,OAAO,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAA;AAIjD,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,kBAAkB,CAAA;AACrD,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAA;AASrD,qBAAa,sBAAuB,SAAQ,YAAY;IACtD,OAAO,CAAC,cAAc,CAAO;IAC7B,OAAO,CAAC,sBAAsB,CAAI;gBAEtB,OAAO,EAAE,WAAW;IAIhC,uDAAuD;IACvD,iBAAiB,CAAC,SAAS,EAAE,MAAM,GAAG,IAAI;IAM1C;;;;;;;;;OASG;IACH,qBAAqB,CAAC,CAAC,EAAE,MAAM,GAAG,IAAI;IAMtC;;;;;;;;;;;;OAYG;IACM,YAAY,IAAI,eAAe;IAOxC,SAAS,CAAC,MAAM,IAAI,aAAa,EAAE;IAOnC,SAAS,CAAC,QAAQ,IAAI,MAAM;IAqB5B,0DAA0D;IAC1D;;;;OAIG;IACH,OAAO,CAAC,iBAAiB;IAoBzB,6DAA6D;IAC7D,OAAO,CAAC,aAAa;IAOrB,+DAA+D;IAC/D;;;;;;;;;;;;;OAaG;IACH,OAAO,CAAC,QAAQ;IAIhB,gDAAgD;IAChD,aAAa,IAAI,MAAM;IAIvB,OAAO,CAAC,wBAAwB;IAmChC,2CAA2C;IAC3C;;;;;;OAMG;IACH,OAAO,CAAC,YAAY;IASpB,OAAO,CAAC,eAAe;CA2CxB"}
+{"version":3,"file":"duplicate-bodies.d.ts","sourceRoot":"","sources":["../../src/smells/duplicate-bodies.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,eAAe,EAAE,MAAM,kBAAkB,CAAA;AAIvD,OAAO,EAAE,YAAY,EAAE,MAAM,oBAAoB,CAAA;AAOjD,OAAO,KAAK,EAAE,aAAa,EAAE,MAAM,kBAAkB,CAAA;AACrD,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAA;AASrD,qBAAa,sBAAuB,SAAQ,YAAY;IACtD,OAAO,CAAC,cAAc,CAAO;IAC7B,OAAO,CAAC,sBAAsB,CAAI;gBAEtB,OAAO,EAAE,WAAW;IAIhC,uDAAuD;IACvD,iBAAiB,CAAC,SAAS,EAAE,MAAM,GAAG,IAAI;IAM1C;;;;;;;;;OASG;IACH,qBAAqB,CAAC,CAAC,EAAE,MAAM,GAAG,IAAI;IAMtC;;;;;;;;;;;;OAYG;IACM,YAAY,IAAI,eAAe;IAOxC,SAAS,CAAC,MAAM,IAAI,aAAa,EAAE;IAOnC,SAAS,CAAC,QAAQ,IAAI,MAAM;IAqB5B,0DAA0D;IAC1D;;;;OAIG;IACH,OAAO,CAAC,iBAAiB;IAoBzB,6DAA6D;IAC7D,OAAO,CAAC,aAAa;IAOrB,+DAA+D;IAC/D;;;;;;;;;;;;;OAaG;IACH,OAAO,CAAC,QAAQ;IAIhB,gDAAgD;IAChD,aAAa,IAAI,MAAM;IAIvB,OAAO,CAAC,wBAAwB;IAmChC,2CAA2C;IAC3C;;;;;;;;;;;;;;;;OAgBG;IACH,OAAO,CAAC,YAAY;IAepB;;;;;;;;;;;;;;OAcG;IACH;;;;;;OAMG;IACH,OAAO,CAAC,eAAe;IA8BvB,OAAO,CAAC,sBAAsB;IAe9B,OAAO,CAAC,eAAe;CAIxB"}

package/dist/smells/duplicate-bodies.js

@@ -1,9 +1,11 @@
 import picomatch from 'picomatch';
 import path from 'node:path';
-import { selectionMemo } from '@nielspeter/eess';
+import { selectionMemo } from '@nielspeter/eess/internal';
 import { SmellBuilder } from './smell-builder.js';
 import { collectFunctions } from '../models/arch-function.js';
 import { fingerprintAll, findSimilarPairs } from './similar-pairs.js';
+import { anchorFile, clusterViolation, pairViolation } from './duplicate-report.js';
+import { clusterPairs, clusterRank } from './clusters.js';
 import { relativeToRoot } from '../core/project-relative.js';
 /** Test file patterns for ignoreTests(). */
 const TEST_PATTERNS = ['**/*.test.ts', '**/*.spec.ts', '**/__tests__/**'];
@@ -58,7 +60,7 @@ export class DuplicateBodiesBuilder extends SmellBuilder {
         const functions = this.selected();
         const fingerprinted = fingerprintAll(functions);
         const pairs = findSimilarPairs(fingerprinted, this._minSimilarity, this._minDistinctVocabulary);
-        return this.buildViolations(pairs);
+        return this.buildClusterViolations(pairs);
     }
     describe() {
         const scope = this._folders.length > 0 ? this._folders.join(', ') : 'all files';
@@ -155,58 +157,105 @@ export class DuplicateBodiesBuilder extends SmellBuilder {
     }
     /** Build violations from similar pairs. */
     /**
-     * Report order: by folder when `.groupByFolder()` asked for it, otherwise the
-     * order the pairs were found in.
+     * Report order for pairs — which, measured, never has anything to order.
      *
-     * Extracted from {@link buildViolations} so that method is the violation
-     * shape and nothing else — presentation order is a separate decision.
+     * Extracted from {@link buildViolations} so that method is the violation shape
+     * and nothing else. Enforcement review of bug 0242 read this as a live defect
+     * (keyed on `a`, i.e. walk order, while the finding reports at the anchor).
+     * Probing it says otherwise: {@link buildViolations} is reached only from
+     * {@link buildClusterViolations} for a cluster of two or fewer members, and
+     * such a cluster carries exactly one pair. Instrumented to throw on more than
+     * one, the whole `packages/ts` suite (3604 tests) produced **zero** hits.
+     *
+     * So this cannot reorder anything today, and {@link orderedClusters} is what
+     * actually orders the output. The key is corrected anyway — being right if
+     * this ever becomes reachable costs one expression — but the correction fixes
+     * no observable behaviour, and saying otherwise would be the kind of unmeasured
+     * claim this repo keeps catching.
      */
     orderedPairs(pairs) {
         if (!this._groupByFolder)
             return pairs;
-        return [...pairs].sort((x, y) => {
-            const folderA = path.dirname(x.a.getSourceFile().getFilePath());
-            const folderB = path.dirname(y.a.getSourceFile().getFilePath());
-            return folderA.localeCompare(folderB);
+        // Keyed on the ANCHOR's folder, not on `a`'s. Which endpoint is `a` is the
+        // source walk; the anchor is where the finding says it is (bug 0242). While
+        // those agreed this was invisible, and after the anchor moved a finding
+        // reported in one folder would sort into another folder's group — the one
+        // thing this option exists to prevent.
+        const keyed = pairs.map((pair) => ({
+            pair,
+            folder: path.dirname(anchorFile([pair.a, pair.b])),
+        }));
+        keyed.sort((x, y) => (x.folder < y.folder ? -1 : x.folder > y.folder ? 1 : 0));
+        return keyed.map((k) => k.pair);
+    }
+    /**
+     * One violation per CLUSTER of mutually-similar bodies, not per pair.
+     *
+     * A pair is the wrong unit and it is not a close call. Measured on a
+     * ~5,600-file production monorepo: 407 clusters emitted **4,770** pair
+     * findings — more findings than the 3,810 bodies that produced them. The
+     * eight largest clusters were 49% of the output, one cluster of 89 members
+     * emitted 398 lines, and the worst single function was named 29 times. Every
+     * one of those can be TRUE and the report is still unreadable, because N
+     * mutually-similar bodies carry one observation and emit N^2/2 lines of it.
+     *
+     * Two-member clusters — the common case — keep the exact message and identity
+     * they had before, so existing baselines for them are untouched. Only a group
+     * of three or more collapses, which is where the inflation lives.
+     */
+    /**
+     * Report order.
+     *
+     * Rank is presentation only — no pair is dropped and no score changes. At four
+     * thousand findings the ORDER is the product: what a reader sees first decides
+     * whether they read at all. `.groupByFolder()` still wins when asked for.
+     */
+    orderedClusters(clusters) {
+        // Decorated once, then sorted. `anchorFile` asks ts-morph for a path and a
+        // line per member, and a comparator runs O(n log n) times — on the 407
+        // clusters this module's own comments measure, computing it inside the
+        // comparator is tens of thousands of avoidable calls.
+        const keyed = clusters.map((cluster) => {
+            // The ANCHOR's folder, not `members[0]`'s: `members[0]` is the source walk
+            // and the finding is reported at the path-then-line minimum (bug 0242), so
+            // grouping on the walk would file a finding under a folder it is not
+            // reported in — the one thing `.groupByFolder()` exists to prevent.
+            const anchor = anchorFile(cluster.members);
+            return { cluster, anchor, folder: path.dirname(anchor), rank: clusterRank(cluster) };
+        });
+        // Plain `<`, not `localeCompare`: the latter's result depends on the
+        // runtime's ICU build and default locale, which is this record's own failure
+        // class — a report that reads differently on two machines — in the
+        // expression fixing it. `comparePositions` next door uses `<` too.
+        const text = (x, y) => (x < y ? -1 : x > y ? 1 : 0);
+        keyed.sort((x, y) => {
+            const primary = this._groupByFolder ? text(x.folder, y.folder) : y.rank - x.rank;
+            // The tie-break is what makes the SEQUENCE deterministic, and without it
+            // the default path had none: `clusterRank` returns one of four values over
+            // hundreds of clusters, and `Array#sort` is stable, so equal ranks kept
+            // walk order. Found by architecture review of bug 0242's fix; the branch
+            // had disclosed it in a test comment and nowhere else.
+            return primary !== 0 ? primary : text(x.anchor, y.anchor);
         });
+        return keyed.map((k) => k.cluster);
     }
-    buildViolations(pairs) {
-        const ruleDescription = this.describe();
+    buildClusterViolations(pairs) {
         const violations = [];
-        for (const pair of this.orderedPairs(pairs)) {
-            const nameA = pair.a.getName() ?? '<anonymous>';
-            const fileA = pair.a.getSourceFile().getFilePath();
-            const lineA = pair.a.getStartLineNumber();
-            const nameB = pair.b.getName() ?? '<anonymous>';
-            const fileB = pair.b.getSourceFile().getFilePath();
-            const lineB = pair.b.getStartLineNumber();
-            const pct = Math.round(pair.similarity * 100);
-            violations.push({
-                rule: ruleDescription,
-                element: nameA,
-                file: fileA,
-                line: lineA,
-                message: `${nameA} (${fileA}:${String(lineA)}) is ${String(pct)}% similar to ${nameB} (${fileB}:${String(lineB)})`,
-                // Which endpoint is "a" comes from the source-file walk order, which is
-                // a property of the filesystem: the same pair reports A→B on one
-                // machine and B→A on another, and the reported message alone would
-                // give them different identities. Sort the endpoints so the pair reads
-                // the same either way. Qualified by path — a bare function name is not
-                // unique across files — and without the similarity percentage, which
-                // drifts as either body is edited.
-                //
-                // Limitation: two anonymous functions in one file share an endpoint
-                // (`<file>#<anonymous>`) and so share an identity. Nothing stable
-                // distinguishes them — a line number would, and that is the coordinate
-                // dependence being removed. Measured at 0 collisions over 1006 findings
-                // on a real codebase; the collision guard in
-                // `tests/integration/baseline-portability.test.ts` is what would catch
-                // it becoming common.
-                identity: `duplicate-pair::${[`${fileA}#${nameA}`, `${fileB}#${nameB}`].sort().join('::')}`,
-                because: this._reason,
-            });
+        for (const cluster of this.orderedClusters(clusterPairs(pairs))) {
+            // A two-member cluster IS the pair, so it keeps the message and the
+            // baseline identity that already shipped. Only three-or-more collapses,
+            // which is where the inflation lives.
+            if (cluster.members.length <= 2) {
+                violations.push(...this.buildViolations(cluster.pairs));
+                continue;
+            }
+            violations.push(clusterViolation(cluster, { rule: this.describe(), because: this._reason }));
         }
         return violations;
     }
+    buildViolations(pairs) {
+        const context = { rule: this.describe(), because: this._reason };
+        return this.orderedPairs([...pairs]).map((pair) => pairViolation(pair, context));
+    }
 }
 //# sourceMappingURL=duplicate-bodies.js.map