@nielspeter/eess-ts 0.2.1 → 0.5.0

package/dist/presets/shared.js.map

@@ -1 +1 @@
-{"version":3,"file":"shared.js","sourceRoot":"","sources":["../../src/presets/shared.ts"],"names":[],"mappings":"AAAA,iFAAiF;AACjF,yEAAyE;AACzE,0CAA0C;AAC1C,OAAO,EAAE,YAAY,EAAE,iBAAiB,EAAE,iBAAiB,EAAE,YAAY,EAAE,MAAM,kBAAkB,CAAA"}
+{"version":3,"file":"shared.js","sourceRoot":"","sources":["../../src/presets/shared.ts"],"names":[],"mappings":"AAYA,OAAO,EACL,YAAY,EACZ,aAAa,EACb,iBAAiB,EACjB,mBAAmB,EACnB,aAAa,GACd,MAAM,kBAAkB,CAAA;AACzB,OAAO,EAAE,gBAAgB,EAAE,MAAM,yBAAyB,CAAA;AAC1D,OAAO,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAA;AAG1D,OAAO,EAAE,YAAY,EAAE,cAAc,EAAE,MAAM,2BAA2B,CAAA;AACxE,OAAO,EAAE,EAAE,EAAE,MAAM,wBAAwB,CAAA;AAmB3C;;;;;;;;;;;;;GAaG;AACH,MAAM,UAAU,WAAW,CACzB,OAAmB,EACnB,IAAmC,EACnC,eAA6B,EAC7B,MAAqC,EACrC,WAAsB;IAEtB,MAAM,SAAS,GAAG,MAAM,EAAE,SAAS,EAAE,CAAC,IAAI,CAAC,EAAE,CAAC,IAAI,eAAe,CAAA;IACjE,IAAI,SAAS,KAAK,KAAK;QAAE,OAAO,EAAE,CAAA;IAClC,6EAA6E;IAC7E,sEAAsE;IACtE,0EAA0E;IAC1E,yCAAyC;IACzC,WAAW,EAAE,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,CAAA;IAC1B,MAAM,OAAO,GAAG,EAAE,GAAG,IAAI,EAAE,mBAAmB,EAAE,yBAAyB,CAAC,IAAI,CAAC,EAAE,CAAC,EAAE,CAAA;IACpF,OAAO,CAAC,oBAAoB,CAAC,OAAO,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC,UAAU,CAAC,SAAS,CAAC,EAAE,IAAI,CAAC,EAAE,EAAE,MAAM,CAAC,CAAC,CAAA;AAC7F,CAAC;AAED;;;;;;;GAOG;AACH,MAAM,UAAU,oBAAoB,CAClC,OAAU,EACV,EAAU,EACV,MAAqC;IAErC,OAAO,MAAM,EAAE,WAAW,EAAE,QAAQ,CAAC,EAAE,CAAC,KAAK,IAAI,CAAC,CAAC,CAAC,OAAO,CAAC,WAAW,EAAE,CAAC,CAAC,CAAC,OAAO,CAAA;AACrF,CAAC;AAED;;;;;;;;;;;;GAYG;AACH,MAAM,UAAU,yBAAyB,CAAC,EAAU;IAClD,OAAO,kBAAkB,EAAE,6BAA6B,CAAA;AAC1D,CAAC;AAED;;;;;;GAMG;AACH,MAAM,UAAU,gBAAgB,CAC9B,UAA8B,EAC9B,OAAqD;IAErD,IAAI,UAAU,CAAC,MAAM,GAAG,CAAC;QAAE,OAAO,EAAE,CAAA;IACpC,MAAM,SAAS,GAAkB;QAC/B,IAAI,EAAE,OAAO,CAAC,EAAE;QAChB,MAAM,EAAE,OAAO,CAAC,EAAE;QAClB,OAAO,EAAE,OAAO,CAAC,EAAE;QACnB,IAAI,EAAE,EAAE;QACR,IAAI,EAAE,CAAC;QACP,OAAO,EAAE,0CAA0C,OAAO,CAAC,IAAI,MAAM,OAAO,CAAC,MAAM,EAAE;QACrF,OAAO,EACL,oGAAoG;QACtG,UAAU,EAAE,OAAO,CAAC,MAAM;QAC1B,QAAQ,EAAE,OAAO;QACjB,aAAa,EAAE,IAAI;KACpB,CAAA;IACD,6EAA6E;IAC7E,6EAA6E;IAC7E,4EAA4E;IAC5E,uDAAuD;IACvD,OAAO,CAAC,EAAE,UAAU,EAAE,GAAG,EAAE,CAAC,aAAa,CAAC,CAAC,SAAS,CAAC,EAAE,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC,EAAE,CAAC,CAAA;AAC5E,CAAC;AAED;;;;;;;;;;;;;;;;;;GAkBG;AACH;;;;;;;;;;;;;;;;;;;;;GAqBG;AACH,MAAM,UAAU,gBAAgB,CAC9B,SAA4D,EAC5D,QAA2B;IAE3B,IAAI,CAAC,SAAS;QAAE,OAAO,EAAE,CAAA;IACzB,MAAM,KAAK,GAAG,IAAI,GAAG,CAAC,QAAQ,CAAC,CAAA;IAC/B,MAAM,OAAO,GAAG,MAAM,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,MAAM,CAAC,CAAC,GAAG,EAAE,EAAE,CAAC,CAAC,KAAK,CAAC,GAAG,CAAC,GAAG,CAAC,CAAC,CAAA;IACvE,IAAI,OAAO,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,EAAE,CAAA;IAEnC,MAAM,UAAU,GAAoB,OAAO,CAAC,GAAG,CAAC,CAAC,GAAG,EAAE,EAAE,CAAC,CAAC;QACxD,IAAI,EAAE,oBAAoB,GAAG,GAAG;QAChC,MAAM,EAAE,mBAAmB,GAAG,EAAE;QAChC,OAAO,EAAE,GAAG;QACZ,IAAI,EAAE,EAAE;QACR,IAAI,EAAE,CAAC;QACP,OAAO,EACL,iBAAiB,GAAG,yDAAyD;YAC7E,yCAAyC;QAC3C,OAAO,EACL,2EAA2E;YAC3E,sDAAsD;QACxD,4EAA4E;QAC5E,wEAAwE;QACxE,UAAU,EACR,2DAA2D,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI;YAClF,cAAc;QAChB,aAAa,EAAE,IAAI;KACpB,CAAC,CAAC,CAAA;IACH,6EAA6E;IAC7E,6EAA6E;IAC7E,4EAA4E;IAC5E,uDAAuD;IACvD,OAAO,CAAC,EAAE,UAAU,EAAE,GAAG,EAAE,CAAC,aAAa,CAAC,UAAU,EAAE,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC,EAAE,CAAC,CAAA;AAC3E,CAAC;AAED;;;;;;;;;;;;;;GAcG;AACH,MAAM,UAAU,qBAAqB,CACnC,WAA0C,EAC1C,cAAiC;IAEjC,IAAI,CAAC,WAAW,IAAI,WAAW,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,EAAE,CAAA;IACvD,MAAM,KAAK,GAAG,IAAI,GAAG,CAAC,cAAc,CAAC,CAAA;IACrC,MAAM,OAAO,GAAG,CAAC,GAAG,IAAI,GAAG,CAAC,WAAW,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC,KAAK,CAAC,GAAG,CAAC,EAAE,CAAC,CAAC,CAAA;IACxE,IAAI,OAAO,CAAC,MAAM,KAAK,CAAC;QAAE,OAAO,EAAE,CAAA;IAEnC,8EAA8E;IAC9E,8EAA8E;IAC9E,mEAAmE;IACnE,uEAAuE;IACvE,8EAA8E;IAC9E,0EAA0E;IAC1E,+CAA+C;IAC/C,MAAM,iBAAiB,GAAG,CAAC,GAAG,IAAI,GAAG,CAAC,cAAc,CAAC,CAAC,CAAA;IAEtD,6EAA6E;IAC7E,4EAA4E;IAC5E,8EAA8E;IAC9E,4EAA4E;IAC5E,yEAAyE;IACzE,MAAM,UAAU,GACd,iBAAiB,CAAC,MAAM,KAAK,CAAC;QAC5B,CAAC,CAAC,oFAAoF;YACpF,6FAA6F;YAC7F,sFAAsF;YACtF,cAAc;QAChB,CAAC,CAAC,0DAA0D,iBAAiB,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI;YAC1F,wFAAwF;YACxF,cAAc,CAAA;IAEpB,MAAM,UAAU,GAAoB,OAAO,CAAC,GAAG,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC;QACvD,IAAI,EAAE,uBAAuB,EAAE,GAAG;QAClC,MAAM,EAAE,uBAAuB,EAAE,EAAE;QACnC,OAAO,EAAE,EAAE;QACX,IAAI,EAAE,EAAE;QACR,IAAI,EAAE,CAAC;QACP,OAAO,EACL,sBAAsB,EAAE,iDAAiD;YACzE,iCAAiC;QACnC,OAAO,EACL,sFAAsF;YACtF,6EAA6E;QAC/E,UAAU;QACV,aAAa,EAAE,IAAI;KACpB,CAAC,CAAC,CAAA;IACH,6EAA6E;IAC7E,6EAA6E;IAC7E,4EAA4E;IAC5E,uDAAuD;IACvD,OAAO,CAAC,EAAE,UAAU,EAAE,GAAG,EAAE,CAAC,aAAa,CAAC,UAAU,EAAE,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC,EAAE,CAAC,CAAA;AAC3E,CAAC;AAED;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA8BG;AACH,MAAM,UAAU,aAAa,CAC3B,SAA4B,EAC5B,aAAyC,EACzC,OAAgE;IAEhE,IAAI,SAAS,CAAC,MAAM,GAAG,CAAC,IAAI,aAAa,CAAC,MAAM,GAAG,CAAC;QAAE,OAAO,EAAE,CAAA;IAC/D,MAAM,SAAS,GAAkB;QAC/B,IAAI,EAAE,OAAO,CAAC,EAAE;QAChB,MAAM,EAAE,OAAO,CAAC,EAAE;QAClB,OAAO,EAAE,OAAO,CAAC,EAAE;QACnB,IAAI,EAAE,EAAE;QACR,IAAI,EAAE,CAAC;QACP,OAAO,EACL,GAAG,OAAO,CAAC,UAAU,wEAAwE;YAC7F,0FAA0F;YAC1F,iDAAiD;QACnD,OAAO,EACL,uFAAuF;YACvF,qFAAqF;QACvF,UAAU,EAAE,wBAAwB,OAAO,CAAC,WAAW,IAAI,GAAG,cAAc;QAC5E,aAAa,EAAE,IAAI;KACpB,CAAA;IACD,6EAA6E;IAC7E,6EAA6E;IAC7E,4EAA4E;IAC5E,uDAAuD;IACvD,OAAO,CAAC,EAAE,UAAU,EAAE,GAAG,EAAE,CAAC,aAAa,CAAC,CAAC,SAAS,CAAC,EAAE,EAAE,QAAQ,EAAE,CAAC,EAAE,CAAC,EAAE,CAAC,CAAA;AAC5E,CAAC;AAgED;;;;;;;;;;;;;;;;;;;GAmBG;AACH,MAAM,UAAU,MAAM,CAAoB,IAAY,EAAE,MAAe;IACrE,MAAM,QAAQ,GAAG,EAAE,CAAC,YAAY,CAAI,IAAI,CAAC,EAAE,cAAc,CAAI,IAAI,CAAC,CAAC,CAAA;IACnE,8EAA8E;IAC9E,4EAA4E;IAC5E,OAAO,MAAM,KAAK,SAAS,CAAC,CAAC,CAAC,QAAQ,CAAC,CAAC,CAAC,EAAE,GAAG,QAAQ,EAAE,WAAW,EAAE,GAAG,MAAM,MAAM,IAAI,GAAG,EAAE,CAAA;AAC/F,CAAC;AAED;;;;;GAKG;AACH,MAAM,UAAU,OAAO,CACrB,QAA2B,EAC3B,OAAwF;IAExF,8EAA8E;IAC9E,+EAA+E;IAC/E,0EAA0E;IAC1E,IAAI,OAAO,EAAE,MAAM,KAAK,UAAU;QAAE,OAAO,QAAQ,CAAA;IACnD,8EAA8E;IAC9E,6EAA6E;IAC7E,4EAA4E;IAC5E,yEAAyE;IACzE,gBAAgB;IAChB,EAAE;IACF,4EAA4E;IAC5E,uEAAuE;IACvE,uEAAuE;IACvE,4EAA4E;IAC5E,4EAA4E;IAC5E,oDAAoD;IACpD,MAAM,UAAU,GAAG,mBAAmB,CAAC,QAAQ,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,EAAE,CAAC,CAAC,CAAC,UAAU,EAAE,CAAC,CAAC,CAAA;IAC3E,MAAM,IAAI,GAAmB,OAAO,EAAE,MAAM,IAAI,OAAO,CAAA;IAEvD,0EAA0E;IAC1E,EAAE;IACF,+EAA+E;IAC/E,uEAAuE;IACvE,+EAA+E;IAC/E,8EAA8E;IAC9E,6DAA6D;IAC7D,EAAE;IACF,8EAA8E;IAC9E,sEAAsE;IACtE,gDAAgD;IAChD,EAAE;IACF,0EAA0E;IAC1E,uEAAuE;IACvE,0EAA0E;IAC1E,IAAI,IAAI,KAAK,OAAO,IAAI,gBAAgB,EAAE,EAAE,CAAC;QAC3C,2EAA2E;QAC3E,sEAAsE;QACtE,0EAA0E;QAC1E,uEAAuE;QACvE,4EAA4E;QAC5E,qDAAqD;QACrD,EAAE;QACF,uEAAuE;QACvE,4EAA4E;QAC5E,mEAAmE;QACnE,aAAa;QACb,MAAM,KAAK,GAAG,YAAY,CAAC,UAAU,EAAE,EAAE,MAAM,EAAE,QAAQ,EAAE,CAAC,CAAA;QAC5D,IAAI,KAAK,CAAC,MAAM,GAAG,CAAC;YAAE,MAAM,IAAI,aAAa,CAAC,KAAK,EAAE,OAAO,EAAE,MAAM,CAAC,CAAA;QACrE,OAAO,KAAK,CAAA;IACd,CAAC;IAED,OAAO,YAAY,CAAC,UAAU,EAAE;QAC9B,MAAM,EAAE,IAAI;QACZ,MAAM,EAAE,OAAO,EAAE,MAAM;QACvB,MAAM,EAAE,OAAO,EAAE,MAAM;KACxB,CAAC,CAAA;AACJ,CAAC;AAED,8EAA8E;AAC9E,8EAA8E;AAC9E,+EAA+E;AAC/E,0CAA0C;AAC1C,OAAO,EAAE,iBAAiB,EAAE,CAAA"}

package/dist/rules/code-quality.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"code-quality.d.ts","sourceRoot":"","sources":["../../src/rules/code-quality.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,UAAU,CAAA;AAChD,OAAO,KAAK,EAAE,SAAS,EAAoB,MAAM,kBAAkB,CAAA;AAInE;;;;;;;;;;;;;GAaG;AACH,wBAAgB,2BAA2B,IAAI,SAAS,CAAC,gBAAgB,CAAC,CAuBzE;AAED;;;;;;;;;;;;;;;GAeG;AACH,wBAAgB,cAAc,IAAI,SAAS,CAAC,gBAAgB,CAAC,CA2B5D;AAED;;;;;;;;;;;;;;;;GAgBG;AACH,wBAAgB,cAAc,CAAC,OAAO,CAAC,EAAE;IAAE,OAAO,CAAC,EAAE,MAAM,EAAE,CAAA;CAAE,GAAG,SAAS,CAAC,gBAAgB,CAAC,CA8B5F"}
+{"version":3,"file":"code-quality.d.ts","sourceRoot":"","sources":["../../src/rules/code-quality.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,gBAAgB,EAAE,MAAM,UAAU,CAAA;AAChD,OAAO,KAAK,EAAE,SAAS,EAAoB,MAAM,kBAAkB,CAAA;AAInE;;;;;;;;;;;;;GAaG;AACH,wBAAgB,2BAA2B,IAAI,SAAS,CAAC,gBAAgB,CAAC,CAuBzE;AAED;;;;;;;;;;;;;;;GAeG;AACH,wBAAgB,cAAc,IAAI,SAAS,CAAC,gBAAgB,CAAC,CAoC5D;AAED;;;;;;;;;;;;;;;;GAgBG;AACH,wBAAgB,cAAc,CAAC,OAAO,CAAC,EAAE;IAAE,OAAO,CAAC,EAAE,MAAM,EAAE,CAAA;CAAE,GAAG,SAAS,CAAC,gBAAgB,CAAC,CA8B5F"}

package/dist/rules/code-quality.js

@@ -1,4 +1,4 @@
-import { SyntaxKind } from 'ts-morph';
+import { Node, SyntaxKind } from 'ts-morph';
 import { createViolation } from '../core/violation.js';
 /**
  * All public methods must have JSDoc comments.
@@ -55,15 +55,24 @@ export function noPublicFields() {
             const violations = [];
             for (const cls of elements) {
                 for (const prop of cls.getProperties()) {
-                    // ES #private fields are private by name — they carry no scope
-                    // modifier, so getScope() reports public (dogfood finding, plan 0060)
-                    if (prop.getName().startsWith('#'))
+                    // An ECMAScript `#private` field FIRST, because `getScope()` cannot see
+                    // it: `#name` carries no TypeScript accessibility modifier, so the scope
+                    // reads `'public'` and the field was reported. That is a false positive
+                    // whose remedy — "use private + getter/setter" — is strictly backwards:
+                    // `#` is private at RUNTIME, while `private` is erased at compile time.
+                    // Measured on `ArchRuleError.#violations` (plan 0165).
+                    if (Node.isPrivateIdentifier(prop.getNameNode()))
                         continue;
                     const scope = prop.getScope();
                     if (scope !== undefined && String(scope) !== 'public')
                         continue;
-                    // Allow static readonly (constants)
-                    if (prop.isStatic() && prop.isReadonly())
+                    // `readonly` is not mutable — which is what this rule is named for.
+                    // It previously accepted only `static readonly`, so a public
+                    // `readonly` INSTANCE field was reported with the remedy "use private
+                    // + getter/setter": advice that removes nothing (the field already
+                    // cannot be reassigned) and that the rule's own description does not
+                    // support. Measured on `DiffFilter.baseBranch` (plan 0165).
+                    if (prop.isReadonly())
                         continue;
                     violations.push(createViolation(prop, `${cls.getName() ?? '<anonymous>'}.${prop.getName()} is a public field — use private + getter/setter`, context));
                 }

package/dist/rules/code-quality.js.map

@@ -1 +1 @@
-{"version":3,"file":"code-quality.js","sourceRoot":"","sources":["../../src/rules/code-quality.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,UAAU,CAAA;AAIrC,OAAO,EAAE,eAAe,EAAE,MAAM,sBAAsB,CAAA;AAEtD;;;;;;;;;;;;;GAaG;AACH,MAAM,UAAU,2BAA2B;IACzC,OAAO;QACL,WAAW,EAAE,kCAAkC;QAC/C,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,KAAK,MAAM,MAAM,IAAI,GAAG,CAAC,UAAU,EAAE,EAAE,CAAC;oBACtC,MAAM,KAAK,GAAG,MAAM,CAAC,QAAQ,EAAE,CAAA;oBAC/B,MAAM,QAAQ,GAAG,KAAK,KAAK,SAAS,IAAI,MAAM,CAAC,KAAK,CAAC,KAAK,QAAQ,CAAA;oBAClE,IAAI,QAAQ,IAAI,MAAM,CAAC,SAAS,EAAE,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;wBAChD,UAAU,CAAC,IAAI,CACb,eAAe,CACb,MAAM,EACN,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,IAAI,MAAM,CAAC,OAAO,EAAE,6BAA6B,EAClF,OAAO,CACR,CACF,CAAA;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;;;;;;;GAeG;AACH,MAAM,UAAU,cAAc;IAC5B,OAAO;QACL,WAAW,EAAE,+BAA+B;QAC5C,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,KAAK,MAAM,IAAI,IAAI,GAAG,CAAC,aAAa,EAAE,EAAE,CAAC;oBACvC,+DAA+D;oBAC/D,sEAAsE;oBACtE,IAAI,IAAI,CAAC,OAAO,EAAE,CAAC,UAAU,CAAC,GAAG,CAAC;wBAAE,SAAQ;oBAC5C,MAAM,KAAK,GAAG,IAAI,CAAC,QAAQ,EAAE,CAAA;oBAC7B,IAAI,KAAK,KAAK,SAAS,IAAI,MAAM,CAAC,KAAK,CAAC,KAAK,QAAQ;wBAAE,SAAQ;oBAC/D,oCAAoC;oBACpC,IAAI,IAAI,CAAC,QAAQ,EAAE,IAAI,IAAI,CAAC,UAAU,EAAE;wBAAE,SAAQ;oBAElD,UAAU,CAAC,IAAI,CACb,eAAe,CACb,IAAI,EACJ,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,IAAI,IAAI,CAAC,OAAO,EAAE,kDAAkD,EACrG,OAAO,CACR,CACF,CAAA;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;;;;;;;;GAgBG;AACH,MAAM,UAAU,cAAc,CAAC,OAAgC;IAC7D,MAAM,UAAU,GAAG,IAAI,GAAG,CAAC,OAAO,EAAE,OAAO,IAAI,CAAC,CAAC,EAAE,CAAC,EAAE,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,EAAE,GAAG,CAAC,CAAC,CAAA;IAEtE,OAAO;QACL,WAAW,EAAE,wCAAwC;QACrD,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,KAAK,MAAM,MAAM,IAAI,GAAG,CAAC,UAAU,EAAE,EAAE,CAAC;oBACtC,MAAM,IAAI,GAAG,MAAM,CAAC,OAAO,EAAE,CAAA;oBAC7B,IAAI,CAAC,IAAI;wBAAE,SAAQ;oBAEnB,MAAM,QAAQ,GAAG,IAAI,CAAC,oBAAoB,CAAC,UAAU,CAAC,cAAc,CAAC,CAAA;oBACrE,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;wBAC3B,MAAM,KAAK,GAAG,MAAM,CAAC,GAAG,CAAC,OAAO,EAAE,CAAC,CAAA;wBACnC,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC;4BAC3B,UAAU,CAAC,IAAI,CACb,eAAe,CACb,GAAG,EACH,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,IAAI,MAAM,CAAC,OAAO,EAAE,0BAA0B,MAAM,CAAC,KAAK,CAAC,gCAAgC,EAC5H,OAAO,CACR,CACF,CAAA;wBACH,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC"}
+{"version":3,"file":"code-quality.js","sourceRoot":"","sources":["../../src/rules/code-quality.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,IAAI,EAAE,UAAU,EAAE,MAAM,UAAU,CAAA;AAI3C,OAAO,EAAE,eAAe,EAAE,MAAM,sBAAsB,CAAA;AAEtD;;;;;;;;;;;;;GAaG;AACH,MAAM,UAAU,2BAA2B;IACzC,OAAO;QACL,WAAW,EAAE,kCAAkC;QAC/C,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,KAAK,MAAM,MAAM,IAAI,GAAG,CAAC,UAAU,EAAE,EAAE,CAAC;oBACtC,MAAM,KAAK,GAAG,MAAM,CAAC,QAAQ,EAAE,CAAA;oBAC/B,MAAM,QAAQ,GAAG,KAAK,KAAK,SAAS,IAAI,MAAM,CAAC,KAAK,CAAC,KAAK,QAAQ,CAAA;oBAClE,IAAI,QAAQ,IAAI,MAAM,CAAC,SAAS,EAAE,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;wBAChD,UAAU,CAAC,IAAI,CACb,eAAe,CACb,MAAM,EACN,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,IAAI,MAAM,CAAC,OAAO,EAAE,6BAA6B,EAClF,OAAO,CACR,CACF,CAAA;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;;;;;;;GAeG;AACH,MAAM,UAAU,cAAc;IAC5B,OAAO;QACL,WAAW,EAAE,+BAA+B;QAC5C,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,KAAK,MAAM,IAAI,IAAI,GAAG,CAAC,aAAa,EAAE,EAAE,CAAC;oBACvC,wEAAwE;oBACxE,yEAAyE;oBACzE,wEAAwE;oBACxE,wEAAwE;oBACxE,wEAAwE;oBACxE,uDAAuD;oBACvD,IAAI,IAAI,CAAC,mBAAmB,CAAC,IAAI,CAAC,WAAW,EAAE,CAAC;wBAAE,SAAQ;oBAC1D,MAAM,KAAK,GAAG,IAAI,CAAC,QAAQ,EAAE,CAAA;oBAC7B,IAAI,KAAK,KAAK,SAAS,IAAI,MAAM,CAAC,KAAK,CAAC,KAAK,QAAQ;wBAAE,SAAQ;oBAC/D,oEAAoE;oBACpE,6DAA6D;oBAC7D,sEAAsE;oBACtE,mEAAmE;oBACnE,qEAAqE;oBACrE,4DAA4D;oBAC5D,IAAI,IAAI,CAAC,UAAU,EAAE;wBAAE,SAAQ;oBAE/B,UAAU,CAAC,IAAI,CACb,eAAe,CACb,IAAI,EACJ,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,IAAI,IAAI,CAAC,OAAO,EAAE,kDAAkD,EACrG,OAAO,CACR,CACF,CAAA;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;;;;;;;;GAgBG;AACH,MAAM,UAAU,cAAc,CAAC,OAAgC;IAC7D,MAAM,UAAU,GAAG,IAAI,GAAG,CAAC,OAAO,EAAE,OAAO,IAAI,CAAC,CAAC,EAAE,CAAC,EAAE,CAAC,CAAC,EAAE,CAAC,EAAE,EAAE,EAAE,GAAG,CAAC,CAAC,CAAA;IAEtE,OAAO;QACL,WAAW,EAAE,wCAAwC;QACrD,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,KAAK,MAAM,MAAM,IAAI,GAAG,CAAC,UAAU,EAAE,EAAE,CAAC;oBACtC,MAAM,IAAI,GAAG,MAAM,CAAC,OAAO,EAAE,CAAA;oBAC7B,IAAI,CAAC,IAAI;wBAAE,SAAQ;oBAEnB,MAAM,QAAQ,GAAG,IAAI,CAAC,oBAAoB,CAAC,UAAU,CAAC,cAAc,CAAC,CAAA;oBACrE,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;wBAC3B,MAAM,KAAK,GAAG,MAAM,CAAC,GAAG,CAAC,OAAO,EAAE,CAAC,CAAA;wBACnC,IAAI,CAAC,UAAU,CAAC,GAAG,CAAC,KAAK,CAAC,EAAE,CAAC;4BAC3B,UAAU,CAAC,IAAI,CACb,eAAe,CACb,GAAG,EACH,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,IAAI,MAAM,CAAC,OAAO,EAAE,0BAA0B,MAAM,CAAC,KAAK,CAAC,gCAAgC,EAC5H,OAAO,CACR,CACF,CAAA;wBACH,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC"}

package/dist/rules/hygiene.d.ts

@@ -27,7 +27,7 @@ export declare function noDeadModules(): Condition<SourceFile>;
  */
 export declare function noUnusedExports(): Condition<SourceFile>;
 /**
- * No stub or deferred-work comments in function bodies.
+ * No stub or deferred-work comments in a function's body OR its own leading docstring.
  * Catches common markers (see STUB_PATTERNS) and phrases like
  * "not implemented" or "coming soon".
  *

package/dist/rules/hygiene.js

@@ -31,7 +31,7 @@ export function noUnusedExports() {
     return haveNoUnusedExports();
 }
 /**
- * No stub or deferred-work comments in function bodies.
+ * No stub or deferred-work comments in a function's body OR its own leading docstring.
  * Catches common markers (see STUB_PATTERNS) and phrases like
  * "not implemented" or "coming soon".
  *

package/dist/rules/metrics-function.d.ts

@@ -17,7 +17,8 @@ import type { Condition } from '@nielspeter/eess';
  */
 export declare function maxFunctionComplexity(threshold: number): Condition<ArchFunction>;
 /**
- * Function must not exceed the given number of lines (span lines).
+ * Function must not exceed the given number of CODE lines — comments and blank
+ * lines are not counted (bug 0170).
  *
  * @example
  * ```ts

package/dist/rules/metrics-function.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"metrics-function.d.ts","sourceRoot":"","sources":["../../src/rules/metrics-function.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,4BAA4B,CAAA;AAC9D,OAAO,KAAK,EAAE,SAAS,EAAoB,MAAM,kBAAkB,CAAA;AAKnE;;;;;;;;;;;;;;GAcG;AACH,wBAAgB,qBAAqB,CAAC,SAAS,EAAE,MAAM,GAAG,SAAS,CAAC,YAAY,CAAC,CAoBhF;AAED;;;;;;;;;GASG;AACH,wBAAgB,gBAAgB,CAAC,SAAS,EAAE,MAAM,GAAG,SAAS,CAAC,YAAY,CAAC,CAoB3E;AAED;;;;;;;;;;;;;GAaG;AACH,wBAAgB,qBAAqB,CAAC,SAAS,EAAE,MAAM,GAAG,SAAS,CAAC,YAAY,CAAC,CAoBhF"}
+{"version":3,"file":"metrics-function.d.ts","sourceRoot":"","sources":["../../src/rules/metrics-function.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,4BAA4B,CAAA;AAC9D,OAAO,KAAK,EAAE,SAAS,EAAoB,MAAM,kBAAkB,CAAA;AA6DnE;;;;;;;;;;;;;;GAcG;AACH,wBAAgB,qBAAqB,CAAC,SAAS,EAAE,MAAM,GAAG,SAAS,CAAC,YAAY,CAAC,CAQhF;AAED;;;;;;;;;;GAUG;AACH,wBAAgB,gBAAgB,CAAC,SAAS,EAAE,MAAM,GAAG,SAAS,CAAC,YAAY,CAAC,CAU3E;AAED;;;;;;;;;;;;;GAaG;AACH,wBAAgB,qBAAqB,CAAC,SAAS,EAAE,MAAM,GAAG,SAAS,CAAC,YAAY,CAAC,CAQhF"}

package/dist/rules/metrics-function.js

@@ -1,5 +1,46 @@
-import { createViolation } from '../core/violation.js';
 import { cyclomaticComplexity, linesOfCode } from '../helpers/complexity.js';
+import { metricViolation } from '../core/metric-violation.js';
+/**
+ * A ceiling on one measurement of every function.
+ *
+ * `maxFunctionComplexity`, `maxFunctionLines` and `maxFunctionParameters` were
+ * the same walk three times over — `no-copy-paste` reported them at 96% — and
+ * `rules/metrics.ts` carries the class-member twin of this helper.
+ *
+ * `name` is derived ONCE and used for the message and the identity alike. Two
+ * expressions that agree in every branch but one is how bug 0068 happened:
+ * `fn.getName() ?? '<anonymous>'` beside a bare `fn.getName()` disagree for an
+ * anonymous function, which would have reproduced that defect inside its own
+ * fix. One derivation in one place is what makes them unable to disagree.
+ *
+ * `unit` is threaded rather than derived from `metric`: `lines` kept its name
+ * when `linesOfCode` stopped counting comments, and the baseline refuses to
+ * compare across a unit change precisely so that silent loosening cannot
+ * happen again (bug 0171).
+ */
+function functionCeiling(threshold, spec) {
+    return {
+        description: spec.description,
+        evaluate(elements, context) {
+            const violations = [];
+            for (const fn of elements) {
+                const value = spec.measure(fn);
+                if (value <= threshold)
+                    continue;
+                const name = fn.getName() ?? '<anonymous>';
+                violations.push(metricViolation(fn.getNode(), {
+                    metric: spec.metric,
+                    ...(spec.unit === undefined ? {} : { unit: spec.unit }),
+                    // Long-hand, not `measured,` — see the note in `rules/metrics.ts`.
+                    measured: value,
+                    message: spec.message(name, value),
+                    qualifiedName: name,
+                }, context));
+            }
+            return violations;
+        },
+    };
+}
 /**
  * Function must not exceed the given cyclomatic complexity.
  *
@@ -16,22 +57,16 @@ import { cyclomaticComplexity, linesOfCode } from '../helpers/complexity.js';
  * ```
  */
 export function maxFunctionComplexity(threshold) {
-    return {
+    return functionCeiling(threshold, {
         description: `have cyclomatic complexity <= ${String(threshold)}`,
-        evaluate(elements, context) {
-            const violations = [];
-            for (const fn of elements) {
-                const cc = cyclomaticComplexity(fn.getBody());
-                if (cc > threshold) {
-                    violations.push(createViolation(fn.getNode(), `${fn.getName() ?? '<anonymous>'} has cyclomatic complexity ${String(cc)} (max: ${String(threshold)})`, context));
-                }
-            }
-            return violations;
-        },
-    };
+        metric: 'complexity',
+        measure: (fn) => cyclomaticComplexity(fn.getBody()),
+        message: (name, cc) => `${name} has cyclomatic complexity ${String(cc)} (max: ${String(threshold)})`,
+    });
 }
 /**
- * Function must not exceed the given number of lines (span lines).
+ * Function must not exceed the given number of CODE lines — comments and blank
+ * lines are not counted (bug 0170).
  *
  * @example
  * ```ts
@@ -41,19 +76,15 @@ export function maxFunctionComplexity(threshold) {
  * ```
  */
 export function maxFunctionLines(threshold) {
-    return {
-        description: `have no more than ${String(threshold)} lines`,
-        evaluate(elements, context) {
-            const violations = [];
-            for (const fn of elements) {
-                const loc = linesOfCode(fn.getNode());
-                if (loc > threshold) {
-                    violations.push(createViolation(fn.getNode(), `${fn.getName() ?? '<anonymous>'} has ${String(loc)} lines (max: ${String(threshold)})`, context));
-                }
-            }
-            return violations;
-        },
-    };
+    return functionCeiling(threshold, {
+        description: `have no more than ${String(threshold)} code lines`,
+        metric: 'lines',
+        // `code-lines` since bug 0170 — the metric kept its name when it stopped
+        // counting comments, and the baseline must not compare across that.
+        unit: 'code-lines',
+        measure: (fn) => linesOfCode(fn.getNode()),
+        message: (name, loc) => `${name} has ${String(loc)} code lines (max: ${String(threshold)})`,
+    });
 }
 /**
  * Function must not have more than the given number of parameters.
@@ -70,18 +101,11 @@ export function maxFunctionLines(threshold) {
  * ```
  */
 export function maxFunctionParameters(threshold) {
-    return {
+    return functionCeiling(threshold, {
         description: `have no more than ${String(threshold)} parameters`,
-        evaluate(elements, context) {
-            const violations = [];
-            for (const fn of elements) {
-                const params = fn.getParameters().length;
-                if (params > threshold) {
-                    violations.push(createViolation(fn.getNode(), `${fn.getName() ?? '<anonymous>'} has ${String(params)} parameters (max: ${String(threshold)}) — use an options object`, context));
-                }
-            }
-            return violations;
-        },
-    };
+        metric: 'parameters',
+        measure: (fn) => fn.getParameters().length,
+        message: (name, params) => `${name} has ${String(params)} parameters (max: ${String(threshold)}) — use an options object`,
+    });
 }
 //# sourceMappingURL=metrics-function.js.map

package/dist/rules/metrics-function.js.map

@@ -1 +1 @@
-{"version":3,"file":"metrics-function.js","sourceRoot":"","sources":["../../src/rules/metrics-function.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,eAAe,EAAE,MAAM,sBAAsB,CAAA;AACtD,OAAO,EAAE,oBAAoB,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAA;AAE5E;;;;;;;;;;;;;;GAcG;AACH,MAAM,UAAU,qBAAqB,CAAC,SAAiB;IACrD,OAAO;QACL,WAAW,EAAE,iCAAiC,MAAM,CAAC,SAAS,CAAC,EAAE;QACjE,QAAQ,CAAC,QAAwB,EAAE,OAAyB;YAC1D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,EAAE,IAAI,QAAQ,EAAE,CAAC;gBAC1B,MAAM,EAAE,GAAG,oBAAoB,CAAC,EAAE,CAAC,OAAO,EAAE,CAAC,CAAA;gBAC7C,IAAI,EAAE,GAAG,SAAS,EAAE,CAAC;oBACnB,UAAU,CAAC,IAAI,CACb,eAAe,CACb,EAAE,CAAC,OAAO,EAAE,EACZ,GAAG,EAAE,CAAC,OAAO,EAAE,IAAI,aAAa,8BAA8B,MAAM,CAAC,EAAE,CAAC,UAAU,MAAM,CAAC,SAAS,CAAC,GAAG,EACtG,OAAO,CACR,CACF,CAAA;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;GASG;AACH,MAAM,UAAU,gBAAgB,CAAC,SAAiB;IAChD,OAAO;QACL,WAAW,EAAE,qBAAqB,MAAM,CAAC,SAAS,CAAC,QAAQ;QAC3D,QAAQ,CAAC,QAAwB,EAAE,OAAyB;YAC1D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,EAAE,IAAI,QAAQ,EAAE,CAAC;gBAC1B,MAAM,GAAG,GAAG,WAAW,CAAC,EAAE,CAAC,OAAO,EAAE,CAAC,CAAA;gBACrC,IAAI,GAAG,GAAG,SAAS,EAAE,CAAC;oBACpB,UAAU,CAAC,IAAI,CACb,eAAe,CACb,EAAE,CAAC,OAAO,EAAE,EACZ,GAAG,EAAE,CAAC,OAAO,EAAE,IAAI,aAAa,QAAQ,MAAM,CAAC,GAAG,CAAC,gBAAgB,MAAM,CAAC,SAAS,CAAC,GAAG,EACvF,OAAO,CACR,CACF,CAAA;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;;;;;GAaG;AACH,MAAM,UAAU,qBAAqB,CAAC,SAAiB;IACrD,OAAO;QACL,WAAW,EAAE,qBAAqB,MAAM,CAAC,SAAS,CAAC,aAAa;QAChE,QAAQ,CAAC,QAAwB,EAAE,OAAyB;YAC1D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,EAAE,IAAI,QAAQ,EAAE,CAAC;gBAC1B,MAAM,MAAM,GAAG,EAAE,CAAC,aAAa,EAAE,CAAC,MAAM,CAAA;gBACxC,IAAI,MAAM,GAAG,SAAS,EAAE,CAAC;oBACvB,UAAU,CAAC,IAAI,CACb,eAAe,CACb,EAAE,CAAC,OAAO,EAAE,EACZ,GAAG,EAAE,CAAC,OAAO,EAAE,IAAI,aAAa,QAAQ,MAAM,CAAC,MAAM,CAAC,qBAAqB,MAAM,CAAC,SAAS,CAAC,2BAA2B,EACvH,OAAO,CACR,CACF,CAAA;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC"}
+{"version":3,"file":"metrics-function.js","sourceRoot":"","sources":["../../src/rules/metrics-function.ts"],"names":[],"mappings":"AAGA,OAAO,EAAE,oBAAoB,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAA;AAC5E,OAAO,EAAE,eAAe,EAAE,MAAM,6BAA6B,CAAA;AAE7D;;;;;;;;;;;;;;;;;GAiBG;AACH,SAAS,eAAe,CACtB,SAAiB,EACjB,IAMC;IAED,OAAO;QACL,WAAW,EAAE,IAAI,CAAC,WAAW;QAC7B,QAAQ,CAAC,QAAwB,EAAE,OAAyB;YAC1D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,EAAE,IAAI,QAAQ,EAAE,CAAC;gBAC1B,MAAM,KAAK,GAAG,IAAI,CAAC,OAAO,CAAC,EAAE,CAAC,CAAA;gBAC9B,IAAI,KAAK,IAAI,SAAS;oBAAE,SAAQ;gBAChC,MAAM,IAAI,GAAG,EAAE,CAAC,OAAO,EAAE,IAAI,aAAa,CAAA;gBAC1C,UAAU,CAAC,IAAI,CACb,eAAe,CACb,EAAE,CAAC,OAAO,EAAE,EACZ;oBACE,MAAM,EAAE,IAAI,CAAC,MAAM;oBACnB,GAAG,CAAC,IAAI,CAAC,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,CAAC;oBACvD,mEAAmE;oBACnE,QAAQ,EAAE,KAAK;oBACf,OAAO,EAAE,IAAI,CAAC,OAAO,CAAC,IAAI,EAAE,KAAK,CAAC;oBAClC,aAAa,EAAE,IAAI;iBACpB,EACD,OAAO,CACR,CACF,CAAA;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;;;;;;GAcG;AACH,MAAM,UAAU,qBAAqB,CAAC,SAAiB;IACrD,OAAO,eAAe,CAAC,SAAS,EAAE;QAChC,WAAW,EAAE,iCAAiC,MAAM,CAAC,SAAS,CAAC,EAAE;QACjE,MAAM,EAAE,YAAY;QACpB,OAAO,EAAE,CAAC,EAAE,EAAE,EAAE,CAAC,oBAAoB,CAAC,EAAE,CAAC,OAAO,EAAE,CAAC;QACnD,OAAO,EAAE,CAAC,IAAI,EAAE,EAAE,EAAE,EAAE,CACpB,GAAG,IAAI,8BAA8B,MAAM,CAAC,EAAE,CAAC,UAAU,MAAM,CAAC,SAAS,CAAC,GAAG;KAChF,CAAC,CAAA;AACJ,CAAC;AAED;;;;;;;;;;GAUG;AACH,MAAM,UAAU,gBAAgB,CAAC,SAAiB;IAChD,OAAO,eAAe,CAAC,SAAS,EAAE;QAChC,WAAW,EAAE,qBAAqB,MAAM,CAAC,SAAS,CAAC,aAAa;QAChE,MAAM,EAAE,OAAO;QACf,yEAAyE;QACzE,oEAAoE;QACpE,IAAI,EAAE,YAAY;QAClB,OAAO,EAAE,CAAC,EAAE,EAAE,EAAE,CAAC,WAAW,CAAC,EAAE,CAAC,OAAO,EAAE,CAAC;QAC1C,OAAO,EAAE,CAAC,IAAI,EAAE,GAAG,EAAE,EAAE,CAAC,GAAG,IAAI,QAAQ,MAAM,CAAC,GAAG,CAAC,qBAAqB,MAAM,CAAC,SAAS,CAAC,GAAG;KAC5F,CAAC,CAAA;AACJ,CAAC;AAED;;;;;;;;;;;;;GAaG;AACH,MAAM,UAAU,qBAAqB,CAAC,SAAiB;IACrD,OAAO,eAAe,CAAC,SAAS,EAAE;QAChC,WAAW,EAAE,qBAAqB,MAAM,CAAC,SAAS,CAAC,aAAa;QAChE,MAAM,EAAE,YAAY;QACpB,OAAO,EAAE,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,CAAC,aAAa,EAAE,CAAC,MAAM;QAC1C,OAAO,EAAE,CAAC,IAAI,EAAE,MAAM,EAAE,EAAE,CACxB,GAAG,IAAI,QAAQ,MAAM,CAAC,MAAM,CAAC,qBAAqB,MAAM,CAAC,SAAS,CAAC,2BAA2B;KACjG,CAAC,CAAA;AACJ,CAAC"}

package/dist/rules/metrics.d.ts

@@ -13,7 +13,8 @@ import type { Condition } from '@nielspeter/eess';
  */
 export declare function maxCyclomaticComplexity(threshold: number): Condition<ClassDeclaration>;
 /**
- * No class may exceed the given number of lines (span lines).
+ * No class may exceed the given number of CODE lines — comments and blank
+ * lines are not counted (bug 0170).
  *
  * @example
  * ```ts

package/dist/rules/metrics.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"metrics.d.ts","sourceRoot":"","sources":["../../src/rules/metrics.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,gBAAgB,EAKjB,MAAM,UAAU,CAAA;AACjB,OAAO,KAAK,EAAE,SAAS,EAAoB,MAAM,kBAAkB,CAAA;AA8BnE;;;;;;;;;;GAUG;AACH,wBAAgB,uBAAuB,CAAC,SAAS,EAAE,MAAM,GAAG,SAAS,CAAC,gBAAgB,CAAC,CAsBtF;AAED;;;;;;;;;GASG;AACH,wBAAgB,aAAa,CAAC,SAAS,EAAE,MAAM,GAAG,SAAS,CAAC,gBAAgB,CAAC,CAoB5E;AAED;;;;;;;;;GASG;AACH,wBAAgB,cAAc,CAAC,SAAS,EAAE,MAAM,GAAG,SAAS,CAAC,gBAAgB,CAAC,CAsB7E;AAED;;;;;;;;;;;GAWG;AACH,wBAAgB,UAAU,CAAC,SAAS,EAAE,MAAM,GAAG,SAAS,CAAC,gBAAgB,CAAC,CAoBzE;AAED;;;;;;;;;;;GAWG;AACH,wBAAgB,aAAa,CAAC,SAAS,EAAE,MAAM,GAAG,SAAS,CAAC,gBAAgB,CAAC,CAsB5E;AAGD,OAAO,EACL,qBAAqB,EACrB,gBAAgB,EAChB,qBAAqB,GACtB,MAAM,uBAAuB,CAAA"}
+{"version":3,"file":"metrics.d.ts","sourceRoot":"","sources":["../../src/rules/metrics.ts"],"names":[],"mappings":"AAAA,OAAO,KAAK,EACV,gBAAgB,EAKjB,MAAM,UAAU,CAAA;AACjB,OAAO,KAAK,EAAE,SAAS,EAAoB,MAAM,kBAAkB,CAAA;AA0FnE;;;;;;;;;;GAUG;AACH,wBAAgB,uBAAuB,CAAC,SAAS,EAAE,MAAM,GAAG,SAAS,CAAC,gBAAgB,CAAC,CAQtF;AAED;;;;;;;;;;GAUG;AACH,wBAAgB,aAAa,CAAC,SAAS,EAAE,MAAM,GAAG,SAAS,CAAC,gBAAgB,CAAC,CA2B5E;AAED;;;;;;;;;GASG;AACH,wBAAgB,cAAc,CAAC,SAAS,EAAE,MAAM,GAAG,SAAS,CAAC,gBAAgB,CAAC,CAU7E;AAED;;;;;;;;;;;GAWG;AACH,wBAAgB,UAAU,CAAC,SAAS,EAAE,MAAM,GAAG,SAAS,CAAC,gBAAgB,CAAC,CAwBzE;AAED;;;;;;;;;;;GAWG;AACH,wBAAgB,aAAa,CAAC,SAAS,EAAE,MAAM,GAAG,SAAS,CAAC,gBAAgB,CAAC,CAQ5E;AAGD,OAAO,EACL,qBAAqB,EACrB,gBAAgB,EAChB,qBAAqB,GACtB,MAAM,uBAAuB,CAAA"}

package/dist/rules/metrics.js

@@ -1,5 +1,5 @@
-import { createViolation } from '../core/violation.js';
 import { cyclomaticComplexity, linesOfCode } from '../helpers/complexity.js';
+import { metricViolation } from '../core/metric-violation.js';
 function getClassMembers(cls) {
     return [
         ...cls.getMethods(),
@@ -17,27 +17,44 @@ function getMemberName(cls, member) {
     return `${clsName}.constructor`;
 }
 /**
- * No method/constructor/getter/setter in the class may exceed the given
- * cyclomatic complexity.
+ * A ceiling on one measurement of every callable member of every class.
  *
- * @example
- * ```ts
- * import { maxCyclomaticComplexity } from '@nielspeter/eess-ts/rules/metrics'
+ * `maxCyclomaticComplexity`, `maxMethodLines` and `maxParameters` were the same
+ * nested walk three times over — `no-copy-paste` reported them at 98% — and the
+ * walk is the part that must not drift: a metric that visited methods but not
+ * accessors would report a clean ceiling for a class whose getter breaches it,
+ * which is a pass constructed from a partial scan (ADR-010).
  *
- * classes(p).should().satisfy(maxCyclomaticComplexity(15)).check()
- * ```
+ * `unit` is threaded rather than derived from `metric`: `lines` kept its name
+ * when `linesOfCode` stopped counting comments, and the baseline refuses to
+ * compare across a unit change precisely so that silent tripling cannot happen
+ * again (bug 0171). A metric whose name already says what it counts passes
+ * nothing here.
  */
-export function maxCyclomaticComplexity(threshold) {
+function memberCeiling(threshold, spec) {
     return {
-        description: `have no method with cyclomatic complexity > ${String(threshold)}`,
+        description: spec.description,
         evaluate(elements, context) {
             const violations = [];
             for (const cls of elements) {
                 for (const member of getClassMembers(cls)) {
-                    const cc = cyclomaticComplexity(member.getBody());
-                    if (cc > threshold) {
-                        violations.push(createViolation(member, `${getMemberName(cls, member)} has cyclomatic complexity ${String(cc)} (max: ${String(threshold)}) — split into smaller methods`, context));
-                    }
+                    const value = spec.measure(member);
+                    if (value <= threshold)
+                        continue;
+                    const name = getMemberName(cls, member);
+                    violations.push(metricViolation(member, {
+                        metric: spec.metric,
+                        ...(spec.unit === undefined ? {} : { unit: spec.unit }),
+                        // Written long-hand deliberately: `measured,` is a
+                        // ShorthandPropertyAssignment, and the producer census in
+                        // `every-metric-finding-carries-its-unit.test.ts` walks
+                        // PropertyAssignment. Shorthand here made this producer
+                        // invisible to it — the census now sees both kinds, and this
+                        // spelling keeps the two from having to agree twice.
+                        measured: value,
+                        qualifiedName: name,
+                        message: spec.message(name, value),
+                    }, context));
                 }
             }
             return violations;
@@ -45,7 +62,27 @@ export function maxCyclomaticComplexity(threshold) {
     };
 }
 /**
- * No class may exceed the given number of lines (span lines).
+ * No method/constructor/getter/setter in the class may exceed the given
+ * cyclomatic complexity.
+ *
+ * @example
+ * ```ts
+ * import { maxCyclomaticComplexity } from '@nielspeter/eess-ts/rules/metrics'
+ *
+ * classes(p).should().satisfy(maxCyclomaticComplexity(15)).check()
+ * ```
+ */
+export function maxCyclomaticComplexity(threshold) {
+    return memberCeiling(threshold, {
+        description: `have no method with cyclomatic complexity > ${String(threshold)}`,
+        metric: 'complexity',
+        measure: (member) => cyclomaticComplexity(member.getBody()),
+        message: (name, cc) => `${name} has cyclomatic complexity ${String(cc)} (max: ${String(threshold)}) — split into smaller methods`,
+    });
+}
+/**
+ * No class may exceed the given number of CODE lines — comments and blank
+ * lines are not counted (bug 0170).
  *
  * @example
  * ```ts
@@ -56,13 +93,20 @@ export function maxCyclomaticComplexity(threshold) {
  */
 export function maxClassLines(threshold) {
     return {
-        description: `have no more than ${String(threshold)} lines`,
+        description: `have no more than ${String(threshold)} code lines`,
         evaluate(elements, context) {
             const violations = [];
             for (const cls of elements) {
                 const loc = linesOfCode(cls);
                 if (loc > threshold) {
-                    violations.push(createViolation(cls, `${cls.getName() ?? '<anonymous>'} has ${String(loc)} lines (max: ${String(threshold)}) — consider splitting into focused classes`, context));
+                    violations.push(metricViolation(cls, {
+                        metric: 'lines',
+                        // `code-lines` since bug 0170 — the metric kept its name when it stopped
+                        // counting comments, and the baseline must not compare across that.
+                        unit: 'code-lines',
+                        measured: loc,
+                        message: `${cls.getName() ?? '<anonymous>'} has ${String(loc)} code lines (max: ${String(threshold)}) — consider splitting into focused classes`,
+                    }, context));
                 }
             }
             return violations;
@@ -80,21 +124,15 @@ export function maxClassLines(threshold) {
  * ```
  */
 export function maxMethodLines(threshold) {
-    return {
-        description: `have no method longer than ${String(threshold)} lines`,
-        evaluate(elements, context) {
-            const violations = [];
-            for (const cls of elements) {
-                for (const member of getClassMembers(cls)) {
-                    const loc = linesOfCode(member);
-                    if (loc > threshold) {
-                        violations.push(createViolation(member, `${getMemberName(cls, member)} has ${String(loc)} lines (max: ${String(threshold)})`, context));
-                    }
-                }
-            }
-            return violations;
-        },
-    };
+    return memberCeiling(threshold, {
+        description: `have no method longer than ${String(threshold)} code lines`,
+        metric: 'lines',
+        // `code-lines` since bug 0170 — the metric kept its name when it stopped
+        // counting comments, and the baseline must not compare across that.
+        unit: 'code-lines',
+        measure: (member) => linesOfCode(member),
+        message: (name, loc) => `${name} has ${String(loc)} code lines (max: ${String(threshold)})`,
+    });
 }
 /**
  * No class may have more than the given number of methods.
@@ -116,7 +154,11 @@ export function maxMethods(threshold) {
             for (const cls of elements) {
                 const count = cls.getMethods().length;
                 if (count > threshold) {
-                    violations.push(createViolation(cls, `${cls.getName() ?? '<anonymous>'} has ${String(count)} methods (max: ${String(threshold)}) — consider splitting into focused classes`, context));
+                    violations.push(metricViolation(cls, {
+                        metric: 'methods',
+                        measured: count,
+                        message: `${cls.getName() ?? '<anonymous>'} has ${String(count)} methods (max: ${String(threshold)}) — consider splitting into focused classes`,
+                    }, context));
                 }
             }
             return violations;
@@ -136,21 +178,12 @@ export function maxMethods(threshold) {
  * ```
  */
 export function maxParameters(threshold) {
-    return {
+    return memberCeiling(threshold, {
         description: `have no method with more than ${String(threshold)} parameters`,
-        evaluate(elements, context) {
-            const violations = [];
-            for (const cls of elements) {
-                for (const member of getClassMembers(cls)) {
-                    const params = member.getParameters().length;
-                    if (params > threshold) {
-                        violations.push(createViolation(member, `${getMemberName(cls, member)} has ${String(params)} parameters (max: ${String(threshold)}) — use an options object`, context));
-                    }
-                }
-            }
-            return violations;
-        },
-    };
+        metric: 'parameters',
+        measure: (member) => member.getParameters().length,
+        message: (name, params) => `${name} has ${String(params)} parameters (max: ${String(threshold)}) — use an options object`,
+    });
 }
 // Re-export function-level metric conditions from the same sub-path
 export { maxFunctionComplexity, maxFunctionLines, maxFunctionParameters, } from './metrics-function.js';

package/dist/rules/metrics.js.map

@@ -1 +1 @@
-{"version":3,"file":"metrics.js","sourceRoot":"","sources":["../../src/rules/metrics.ts"],"names":[],"mappings":"AASA,OAAO,EAAE,eAAe,EAAE,MAAM,sBAAsB,CAAA;AACtD,OAAO,EAAE,oBAAoB,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAA;AAS5E,SAAS,eAAe,CAAC,GAAqB;IAC5C,OAAO;QACL,GAAG,GAAG,CAAC,UAAU,EAAE;QACnB,GAAG,GAAG,CAAC,eAAe,EAAE;QACxB,GAAG,GAAG,CAAC,eAAe,EAAE;QACxB,GAAG,GAAG,CAAC,eAAe,EAAE;KACzB,CAAA;AACH,CAAC;AAED,SAAS,aAAa,CAAC,GAAqB,EAAE,MAAmB;IAC/D,MAAM,OAAO,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,CAAA;IAC9C,IAAI,SAAS,IAAI,MAAM,IAAI,OAAO,MAAM,CAAC,OAAO,KAAK,UAAU,EAAE,CAAC;QAChE,MAAM,UAAU,GAAG,MAAM,CAAC,MAAM,CAAC,OAAO,EAAE,CAAC,CAAA;QAC3C,OAAO,GAAG,OAAO,IAAI,UAAU,EAAE,CAAA;IACnC,CAAC;IACD,OAAO,GAAG,OAAO,cAAc,CAAA;AACjC,CAAC;AAED;;;;;;;;;;GAUG;AACH,MAAM,UAAU,uBAAuB,CAAC,SAAiB;IACvD,OAAO;QACL,WAAW,EAAE,+CAA+C,MAAM,CAAC,SAAS,CAAC,EAAE;QAC/E,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,KAAK,MAAM,MAAM,IAAI,eAAe,CAAC,GAAG,CAAC,EAAE,CAAC;oBAC1C,MAAM,EAAE,GAAG,oBAAoB,CAAC,MAAM,CAAC,OAAO,EAAE,CAAC,CAAA;oBACjD,IAAI,EAAE,GAAG,SAAS,EAAE,CAAC;wBACnB,UAAU,CAAC,IAAI,CACb,eAAe,CACb,MAAM,EACN,GAAG,aAAa,CAAC,GAAG,EAAE,MAAM,CAAC,8BAA8B,MAAM,CAAC,EAAE,CAAC,UAAU,MAAM,CAAC,SAAS,CAAC,gCAAgC,EAChI,OAAO,CACR,CACF,CAAA;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;GASG;AACH,MAAM,UAAU,aAAa,CAAC,SAAiB;IAC7C,OAAO;QACL,WAAW,EAAE,qBAAqB,MAAM,CAAC,SAAS,CAAC,QAAQ;QAC3D,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,MAAM,GAAG,GAAG,WAAW,CAAC,GAAG,CAAC,CAAA;gBAC5B,IAAI,GAAG,GAAG,SAAS,EAAE,CAAC;oBACpB,UAAU,CAAC,IAAI,CACb,eAAe,CACb,GAAG,EACH,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,QAAQ,MAAM,CAAC,GAAG,CAAC,gBAAgB,MAAM,CAAC,SAAS,CAAC,6CAA6C,EAClI,OAAO,CACR,CACF,CAAA;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;GASG;AACH,MAAM,UAAU,cAAc,CAAC,SAAiB;IAC9C,OAAO;QACL,WAAW,EAAE,8BAA8B,MAAM,CAAC,SAAS,CAAC,QAAQ;QACpE,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,KAAK,MAAM,MAAM,IAAI,eAAe,CAAC,GAAG,CAAC,EAAE,CAAC;oBAC1C,MAAM,GAAG,GAAG,WAAW,CAAC,MAAM,CAAC,CAAA;oBAC/B,IAAI,GAAG,GAAG,SAAS,EAAE,CAAC;wBACpB,UAAU,CAAC,IAAI,CACb,eAAe,CACb,MAAM,EACN,GAAG,aAAa,CAAC,GAAG,EAAE,MAAM,CAAC,QAAQ,MAAM,CAAC,GAAG,CAAC,gBAAgB,MAAM,CAAC,SAAS,CAAC,GAAG,EACpF,OAAO,CACR,CACF,CAAA;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,UAAU,CAAC,SAAiB;IAC1C,OAAO;QACL,WAAW,EAAE,qBAAqB,MAAM,CAAC,SAAS,CAAC,UAAU;QAC7D,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,MAAM,KAAK,GAAG,GAAG,CAAC,UAAU,EAAE,CAAC,MAAM,CAAA;gBACrC,IAAI,KAAK,GAAG,SAAS,EAAE,CAAC;oBACtB,UAAU,CAAC,IAAI,CACb,eAAe,CACb,GAAG,EACH,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,QAAQ,MAAM,CAAC,KAAK,CAAC,kBAAkB,MAAM,CAAC,SAAS,CAAC,6CAA6C,EACtI,OAAO,CACR,CACF,CAAA;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,aAAa,CAAC,SAAiB;IAC7C,OAAO;QACL,WAAW,EAAE,iCAAiC,MAAM,CAAC,SAAS,CAAC,aAAa;QAC5E,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,KAAK,MAAM,MAAM,IAAI,eAAe,CAAC,GAAG,CAAC,EAAE,CAAC;oBAC1C,MAAM,MAAM,GAAG,MAAM,CAAC,aAAa,EAAE,CAAC,MAAM,CAAA;oBAC5C,IAAI,MAAM,GAAG,SAAS,EAAE,CAAC;wBACvB,UAAU,CAAC,IAAI,CACb,eAAe,CACb,MAAM,EACN,GAAG,aAAa,CAAC,GAAG,EAAE,MAAM,CAAC,QAAQ,MAAM,CAAC,MAAM,CAAC,qBAAqB,MAAM,CAAC,SAAS,CAAC,2BAA2B,EACpH,OAAO,CACR,CACF,CAAA;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED,oEAAoE;AACpE,OAAO,EACL,qBAAqB,EACrB,gBAAgB,EAChB,qBAAqB,GACtB,MAAM,uBAAuB,CAAA"}
+{"version":3,"file":"metrics.js","sourceRoot":"","sources":["../../src/rules/metrics.ts"],"names":[],"mappings":"AASA,OAAO,EAAE,oBAAoB,EAAE,WAAW,EAAE,MAAM,0BAA0B,CAAA;AAC5E,OAAO,EAAE,eAAe,EAAE,MAAM,6BAA6B,CAAA;AAS7D,SAAS,eAAe,CAAC,GAAqB;IAC5C,OAAO;QACL,GAAG,GAAG,CAAC,UAAU,EAAE;QACnB,GAAG,GAAG,CAAC,eAAe,EAAE;QACxB,GAAG,GAAG,CAAC,eAAe,EAAE;QACxB,GAAG,GAAG,CAAC,eAAe,EAAE;KACzB,CAAA;AACH,CAAC;AAED,SAAS,aAAa,CAAC,GAAqB,EAAE,MAAmB;IAC/D,MAAM,OAAO,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,CAAA;IAC9C,IAAI,SAAS,IAAI,MAAM,IAAI,OAAO,MAAM,CAAC,OAAO,KAAK,UAAU,EAAE,CAAC;QAChE,MAAM,UAAU,GAAG,MAAM,CAAC,MAAM,CAAC,OAAO,EAAE,CAAC,CAAA;QAC3C,OAAO,GAAG,OAAO,IAAI,UAAU,EAAE,CAAA;IACnC,CAAC;IACD,OAAO,GAAG,OAAO,cAAc,CAAA;AACjC,CAAC;AAED;;;;;;;;;;;;;;GAcG;AACH,SAAS,aAAa,CACpB,SAAiB,EACjB,IAMC;IAED,OAAO;QACL,WAAW,EAAE,IAAI,CAAC,WAAW;QAC7B,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,KAAK,MAAM,MAAM,IAAI,eAAe,CAAC,GAAG,CAAC,EAAE,CAAC;oBAC1C,MAAM,KAAK,GAAG,IAAI,CAAC,OAAO,CAAC,MAAM,CAAC,CAAA;oBAClC,IAAI,KAAK,IAAI,SAAS;wBAAE,SAAQ;oBAChC,MAAM,IAAI,GAAG,aAAa,CAAC,GAAG,EAAE,MAAM,CAAC,CAAA;oBACvC,UAAU,CAAC,IAAI,CACb,eAAe,CACb,MAAM,EACN;wBACE,MAAM,EAAE,IAAI,CAAC,MAAM;wBACnB,GAAG,CAAC,IAAI,CAAC,IAAI,KAAK,SAAS,CAAC,CAAC,CAAC,EAAE,CAAC,CAAC,CAAC,EAAE,IAAI,EAAE,IAAI,CAAC,IAAI,EAAE,CAAC;wBACvD,mDAAmD;wBACnD,0DAA0D;wBAC1D,wDAAwD;wBACxD,wDAAwD;wBACxD,6DAA6D;wBAC7D,qDAAqD;wBACrD,QAAQ,EAAE,KAAK;wBACf,aAAa,EAAE,IAAI;wBACnB,OAAO,EAAE,IAAI,CAAC,OAAO,CAAC,IAAI,EAAE,KAAK,CAAC;qBACnC,EACD,OAAO,CACR,CACF,CAAA;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;;GAUG;AACH,MAAM,UAAU,uBAAuB,CAAC,SAAiB;IACvD,OAAO,aAAa,CAAC,SAAS,EAAE;QAC9B,WAAW,EAAE,+CAA+C,MAAM,CAAC,SAAS,CAAC,EAAE;QAC/E,MAAM,EAAE,YAAY;QACpB,OAAO,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,oBAAoB,CAAC,MAAM,CAAC,OAAO,EAAE,CAAC;QAC3D,OAAO,EAAE,CAAC,IAAI,EAAE,EAAE,EAAE,EAAE,CACpB,GAAG,IAAI,8BAA8B,MAAM,CAAC,EAAE,CAAC,UAAU,MAAM,CAAC,SAAS,CAAC,gCAAgC;KAC7G,CAAC,CAAA;AACJ,CAAC;AAED;;;;;;;;;;GAUG;AACH,MAAM,UAAU,aAAa,CAAC,SAAiB;IAC7C,OAAO;QACL,WAAW,EAAE,qBAAqB,MAAM,CAAC,SAAS,CAAC,aAAa;QAChE,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,MAAM,GAAG,GAAG,WAAW,CAAC,GAAG,CAAC,CAAA;gBAC5B,IAAI,GAAG,GAAG,SAAS,EAAE,CAAC;oBACpB,UAAU,CAAC,IAAI,CACb,eAAe,CACb,GAAG,EACH;wBACE,MAAM,EAAE,OAAO;wBACf,yEAAyE;wBACzE,oEAAoE;wBACpE,IAAI,EAAE,YAAY;wBAClB,QAAQ,EAAE,GAAG;wBACb,OAAO,EAAE,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,QAAQ,MAAM,CAAC,GAAG,CAAC,qBAAqB,MAAM,CAAC,SAAS,CAAC,6CAA6C;qBACjJ,EACD,OAAO,CACR,CACF,CAAA;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;GASG;AACH,MAAM,UAAU,cAAc,CAAC,SAAiB;IAC9C,OAAO,aAAa,CAAC,SAAS,EAAE;QAC9B,WAAW,EAAE,8BAA8B,MAAM,CAAC,SAAS,CAAC,aAAa;QACzE,MAAM,EAAE,OAAO;QACf,yEAAyE;QACzE,oEAAoE;QACpE,IAAI,EAAE,YAAY;QAClB,OAAO,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,WAAW,CAAC,MAAM,CAAC;QACxC,OAAO,EAAE,CAAC,IAAI,EAAE,GAAG,EAAE,EAAE,CAAC,GAAG,IAAI,QAAQ,MAAM,CAAC,GAAG,CAAC,qBAAqB,MAAM,CAAC,SAAS,CAAC,GAAG;KAC5F,CAAC,CAAA;AACJ,CAAC;AAED;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,UAAU,CAAC,SAAiB;IAC1C,OAAO;QACL,WAAW,EAAE,qBAAqB,MAAM,CAAC,SAAS,CAAC,UAAU;QAC7D,QAAQ,CAAC,QAA4B,EAAE,OAAyB;YAC9D,MAAM,UAAU,GAAoB,EAAE,CAAA;YACtC,KAAK,MAAM,GAAG,IAAI,QAAQ,EAAE,CAAC;gBAC3B,MAAM,KAAK,GAAG,GAAG,CAAC,UAAU,EAAE,CAAC,MAAM,CAAA;gBACrC,IAAI,KAAK,GAAG,SAAS,EAAE,CAAC;oBACtB,UAAU,CAAC,IAAI,CACb,eAAe,CACb,GAAG,EACH;wBACE,MAAM,EAAE,SAAS;wBACjB,QAAQ,EAAE,KAAK;wBACf,OAAO,EAAE,GAAG,GAAG,CAAC,OAAO,EAAE,IAAI,aAAa,QAAQ,MAAM,CAAC,KAAK,CAAC,kBAAkB,MAAM,CAAC,SAAS,CAAC,6CAA6C;qBAChJ,EACD,OAAO,CACR,CACF,CAAA;gBACH,CAAC;YACH,CAAC;YACD,OAAO,UAAU,CAAA;QACnB,CAAC;KACF,CAAA;AACH,CAAC;AAED;;;;;;;;;;;GAWG;AACH,MAAM,UAAU,aAAa,CAAC,SAAiB;IAC7C,OAAO,aAAa,CAAC,SAAS,EAAE;QAC9B,WAAW,EAAE,iCAAiC,MAAM,CAAC,SAAS,CAAC,aAAa;QAC5E,MAAM,EAAE,YAAY;QACpB,OAAO,EAAE,CAAC,MAAM,EAAE,EAAE,CAAC,MAAM,CAAC,aAAa,EAAE,CAAC,MAAM;QAClD,OAAO,EAAE,CAAC,IAAI,EAAE,MAAM,EAAE,EAAE,CACxB,GAAG,IAAI,QAAQ,MAAM,CAAC,MAAM,CAAC,qBAAqB,MAAM,CAAC,SAAS,CAAC,2BAA2B;KACjG,CAAC,CAAA;AACJ,CAAC;AAED,oEAAoE;AACpE,OAAO,EACL,qBAAqB,EACrB,gBAAgB,EAChB,qBAAqB,GACtB,MAAM,uBAAuB,CAAA"}

package/dist/smells/clusters.d.ts

@@ -0,0 +1,78 @@
+import type { ArchFunction } from '../models/arch-function.js';
+import type { SimilarPair } from './similar-pairs.js';
+/**
+ * At least two bodies — a cluster is built from a pair, so it can never hold
+ * fewer.
+ *
+ * Typed rather than asserted so `clusterViolation` can be TOTAL. It used to
+ * return `ArchViolation | undefined` on a lookup that cannot fail, and the
+ * caller dropped that with `if (violation)` — a finding vanishing with no
+ * diagnostic. Architecture review of bug 0242 pointed out that the file
+ * rejected exactly that shape for `pairViolation` one screen above, with the
+ * argument that applies here word for word: unreachable today is not a defence,
+ * the type is what stops it becoming reachable.
+ */
+type NonEmptyMembers = readonly [ArchFunction, ArchFunction, ...ArchFunction[]];
+/** A group of bodies that are mutually reachable through reported similarity. */
+export interface SimilarCluster {
+    /**
+     * Members, in first-seen order — i.e. the source walk's, which is a property
+     * of the filesystem.
+     *
+     * The first is NOT what the violation anchors to; it was until bug 0242, and
+     * this comment said so for as long. `clusterViolation` picks the anchor by
+     * path then line, and sorts the members it shows, precisely so neither depends
+     * on this order.
+     */
+    readonly members: NonEmptyMembers;
+    /** The pairs that put these members in one group. */
+    readonly pairs: readonly SimilarPair[];
+    /** Highest similarity among {@link pairs}. */
+    readonly peakSimilarity: number;
+}
+/**
+ * Group reported pairs into connected components.
+ *
+ * A pair is the wrong unit of report and it is not a close call. Measured on a
+ * ~5,600-file production monorepo: 407 clusters produced **4,770** pair
+ * findings, the eight largest clusters alone produced 49% of them, one cluster
+ * of 89 members produced 398, and the worst single function was named 29 times.
+ *
+ * Every one of those findings can be true and the output is still unreadable,
+ * because N mutually-similar bodies carry ONE observation and emit N^2/2 lines
+ * of it. The observation is "these 89 share a shape", which is also the unit a
+ * reader can act on. That is what this returns.
+ */
+export declare function clusterPairs(pairs: readonly SimilarPair[]): SimilarCluster[];
+/**
+ * How likely a cluster is to be worth acting on, highest first.
+ *
+ * Not a filter and deliberately not a score change — the similarity number is
+ * left exactly as it was. This decides only what a reader sees first, because at
+ * 4,770 findings the order IS the product.
+ *
+ * The signal is the one the fingerprint throws away: a body's identifiers are
+ * ignored by design (that is what makes the score a type-2 clone score), and so
+ * is the DECLARATION's own name, which is where the evidence was. Measured over
+ * that same corpus, bucketed by how the two names relate:
+ *
+ * | bucket                        | share | reading                    |
+ * | ----------------------------- | ----- | -------------------------- |
+ * | different file, different name | 56%  | convergent idiom           |
+ * | same class                     | 20%  | siblings, often extractable |
+ * | different file, SAME name      | 14%  | a COPY of one function     |
+ * | same file, different class     | 10%  | co-located                 |
+ *
+ * Two pairs from that run, both scored 100%: `timestampPrefix` in two files (a
+ * literal copy) and two unrelated SDK wrapper methods (a shared idiom). Same
+ * number on screen, opposite verdicts, and the thing that separates them costs
+ * nothing to compute.
+ *
+ * **It is a ranking and not a filter on purpose.** Dropping the different-name
+ * bucket would discard real same-class duplication — one repository in that
+ * corpus has six `exists*` methods differing only in a table name. Dropping
+ * cross-file would have discarded the finding that led to bug 0227.
+ */
+export declare function clusterRank(cluster: SimilarCluster): number;
+export {};
+//# sourceMappingURL=clusters.d.ts.map

package/dist/smells/clusters.d.ts.map

@@ -0,0 +1 @@
+{"version":3,"file":"clusters.d.ts","sourceRoot":"","sources":["../../src/smells/clusters.ts"],"names":[],"mappings":"AACA,OAAO,KAAK,EAAE,YAAY,EAAE,MAAM,4BAA4B,CAAA;AAC9D,OAAO,KAAK,EAAE,WAAW,EAAE,MAAM,oBAAoB,CAAA;AAErD;;;;;;;;;;;GAWG;AACH,KAAK,eAAe,GAAG,SAAS,CAAC,YAAY,EAAE,YAAY,EAAE,GAAG,YAAY,EAAE,CAAC,CAAA;AAE/E,iFAAiF;AACjF,MAAM,WAAW,cAAc;IAC7B;;;;;;;;OAQG;IACH,QAAQ,CAAC,OAAO,EAAE,eAAe,CAAA;IACjC,qDAAqD;IACrD,QAAQ,CAAC,KAAK,EAAE,SAAS,WAAW,EAAE,CAAA;IACtC,8CAA8C;IAC9C,QAAQ,CAAC,cAAc,EAAE,MAAM,CAAA;CAChC;AAED;;;;;;;;;;;;GAYG;AACH,wBAAgB,YAAY,CAAC,KAAK,EAAE,SAAS,WAAW,EAAE,GAAG,cAAc,EAAE,CAkE5E;AAED;;;;;;;;;;;;;;;;;;;;;;;;;;;;GA4BG;AACH,wBAAgB,WAAW,CAAC,OAAO,EAAE,cAAc,GAAG,MAAM,CAa3D"}