@nicnocquee/dataqueue 1.34.0 → 1.35.0-beta.20260224075710

package/src/index.test.ts

@@ -2,7 +2,7 @@ import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
 import { initJobQueue, JobQueueConfig } from './index.js';
 import { createTestDbAndPool, destroyTestDb } from './test-util.js';
 import { Pool } from 'pg';
-import type { CronScheduleRecord } from './types.js';
+import type { CronScheduleRecord, AddJobOptions } from './types.js';
 
 // Integration tests for index.ts
 
@@ -78,9 +78,7 @@ describe('index integration', () => {
       },
       { pollInterval: 100 },
     );
-    processor.start();
-    await new Promise((r) => setTimeout(r, 300));
-    processor.stop();
+    await processor.start();
     const job = await jobQueue.getJob(jobId);
     expect(handler).toHaveBeenCalledWith(
       { foo: 'bar' },
@@ -432,9 +430,7 @@ describe('index integration', () => {
       },
       { pollInterval: 100 },
     );
-    processor.start();
-    await new Promise((r) => setTimeout(r, 300));
-    processor.stop();
+    await processor.start();
 
     expect(handler).toHaveBeenCalledWith(
       { foo: 'updated@example.com' },
@@ -459,9 +455,7 @@ describe('index integration', () => {
       },
       { pollInterval: 100 },
     );
-    processor.start();
-    await new Promise((r) => setTimeout(r, 300));
-    processor.stop();
+    await processor.start();
 
     const originalJob = await jobQueue.getJob(jobId1);
     expect(originalJob?.status).toBe('completed');
@@ -494,7 +488,7 @@ describe('index integration', () => {
       jobType: 'email',
       payload: { to: 'processing@example.com' },
     });
-    processor2.start();
+    const startPromise = processor2.start();
     // Wait a bit for job to be picked up
     await new Promise((r) => setTimeout(r, 150));
     // Job should be processing now
@@ -510,7 +504,7 @@ describe('index integration', () => {
         expect(job2?.payload).toEqual({ to: 'processing@example.com' });
       }
     }
-    processor2.stop();
+    await startPromise;
   });
 
   it('should record edited event when editing via JobQueue API', async () => {
@@ -532,6 +526,51 @@ describe('index integration', () => {
       priority: 10,
     });
   });
+
+  // ── Configurable retry strategy integration tests ────────────────────
+
+  it('should store and return retry config through public API', async () => {
+    const jobId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'retry-api@example.com' },
+      retryDelay: 20,
+      retryBackoff: true,
+      retryDelayMax: 300,
+    });
+
+    const job = await jobQueue.getJob(jobId);
+    expect(job?.retryDelay).toBe(20);
+    expect(job?.retryBackoff).toBe(true);
+    expect(job?.retryDelayMax).toBe(300);
+  });
+
+  it('should use fixed delay on failure through public API', async () => {
+    const jobId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'fixed-api@example.com' },
+      maxAttempts: 3,
+      retryDelay: 10,
+      retryBackoff: false,
+    });
+
+    const handler = vi.fn(async () => {
+      throw new Error('fail');
+    });
+    const processor = jobQueue.createProcessor({
+      email: handler,
+      sms: vi.fn(async () => {}),
+      test: vi.fn(async () => {}),
+    });
+    await processor.start();
+
+    const job = await jobQueue.getJob(jobId);
+    expect(job?.status).toBe('failed');
+    expect(job?.nextAttemptAt).not.toBeNull();
+    const delaySec =
+      (job!.nextAttemptAt!.getTime() - job!.lastFailedAt!.getTime()) / 1000;
+    expect(delaySec).toBeGreaterThanOrEqual(9);
+    expect(delaySec).toBeLessThanOrEqual(11);
+  });
 });
 
 describe('cron schedules integration', () => {
@@ -892,4 +931,764 @@ describe('cron schedules integration', () => {
     );
     expect(cronJobs).toHaveLength(2);
   });
+
+  it('should propagate retry config from cron schedule to enqueued jobs', async () => {
+    const cronId = await jobQueue.addCronJob({
+      scheduleName: 'retry-cron',
+      cronExpression: '* * * * *',
+      jobType: 'email',
+      payload: { to: 'cron-retry@example.com' },
+      retryDelay: 15,
+      retryBackoff: false,
+      retryDelayMax: 90,
+    });
+
+    // Force next_run_at to the past
+    await pool.query(
+      `UPDATE cron_schedules SET next_run_at = NOW() - INTERVAL '1 minute' WHERE id = $1`,
+      [cronId],
+    );
+
+    const count = await jobQueue.enqueueDueCronJobs();
+    expect(count).toBe(1);
+
+    const jobs = await jobQueue.getJobsByStatus('pending');
+    const cronJob = jobs.find(
+      (j) => (j.payload as any).to === 'cron-retry@example.com',
+    );
+    expect(cronJob).toBeDefined();
+    expect(cronJob?.retryDelay).toBe(15);
+    expect(cronJob?.retryBackoff).toBe(false);
+    expect(cronJob?.retryDelayMax).toBe(90);
+  });
+
+  it('should store retry config on cron schedule record', async () => {
+    const cronId = await jobQueue.addCronJob({
+      scheduleName: 'retry-cron-record',
+      cronExpression: '0 */2 * * *',
+      jobType: 'email',
+      payload: { to: 'cron-record@example.com' },
+      retryDelay: 30,
+      retryBackoff: true,
+      retryDelayMax: 600,
+    });
+
+    const schedule = await jobQueue.getCronJob(cronId);
+    expect(schedule?.retryDelay).toBe(30);
+    expect(schedule?.retryBackoff).toBe(true);
+    expect(schedule?.retryDelayMax).toBe(600);
+  });
+});
+
+// ── BYOC (Bring Your Own Connection) tests ──────────────────────────────
+
+describe('BYOC: init with external pool', () => {
+  let pool: Pool;
+  let dbName: string;
+  let jobQueue: ReturnType<typeof initJobQueue<TestPayloadMap>>;
+
+  beforeEach(async () => {
+    const setup = await createTestDbAndPool();
+    pool = setup.pool;
+    dbName = setup.dbName;
+    jobQueue = initJobQueue<TestPayloadMap>({ pool });
+  });
+
+  afterEach(async () => {
+    await pool.end();
+    await destroyTestDb(dbName);
+  });
+
+  it('uses the provided pool for addJob and getJob', async () => {
+    // Act
+    const jobId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'byoc@example.com' },
+    });
+
+    // Assert
+    const job = await jobQueue.getJob(jobId);
+    expect(job).not.toBeNull();
+    expect(job?.jobType).toBe('email');
+    expect(job?.payload).toEqual({ to: 'byoc@example.com' });
+  });
+
+  it('returns the same pool instance from getPool()', () => {
+    // Act
+    const returnedPool = jobQueue.getPool();
+
+    // Assert
+    expect(returnedPool).toBe(pool);
+  });
+});
+
+describe('BYOC: transactional addJob with db option', () => {
+  let pool: Pool;
+  let dbName: string;
+  let testDbUrl: string;
+  let jobQueue: ReturnType<typeof initJobQueue<TestPayloadMap>>;
+
+  beforeEach(async () => {
+    const setup = await createTestDbAndPool();
+    pool = setup.pool;
+    dbName = setup.dbName;
+    testDbUrl = setup.testDbUrl;
+    jobQueue = initJobQueue<TestPayloadMap>({
+      databaseConfig: { connectionString: testDbUrl },
+    });
+  });
+
+  afterEach(async () => {
+    jobQueue.getPool().end();
+    await pool.end();
+    await destroyTestDb(dbName);
+  });
+
+  it('rolls back the job when the transaction is rolled back', async () => {
+    // Setup
+    const client = await pool.connect();
+    await client.query('BEGIN');
+
+    // Act
+    const jobId = await jobQueue.addJob(
+      { jobType: 'email', payload: { to: 'rollback@example.com' } },
+      { db: client },
+    );
+    await client.query('ROLLBACK');
+    client.release();
+
+    // Assert — job should not exist after rollback
+    const job = await jobQueue.getJob(jobId);
+    expect(job).toBeNull();
+  });
+
+  it('persists the job and event when the transaction is committed', async () => {
+    // Setup
+    const client = await pool.connect();
+    await client.query('BEGIN');
+
+    // Act
+    const jobId = await jobQueue.addJob(
+      { jobType: 'email', payload: { to: 'commit@example.com' } },
+      { db: client },
+    );
+    await client.query('COMMIT');
+    client.release();
+
+    // Assert — job exists
+    const job = await jobQueue.getJob(jobId);
+    expect(job).not.toBeNull();
+    expect(job?.payload).toEqual({ to: 'commit@example.com' });
+
+    // Assert — event was recorded in the same transaction
+    const events = await jobQueue.getJobEvents(jobId);
+    expect(events.length).toBeGreaterThanOrEqual(1);
+    expect(events[0].eventType).toBe('added');
+  });
+
+  it('job is visible within the transaction before commit', async () => {
+    // Setup
+    const client = await pool.connect();
+    await client.query('BEGIN');
+
+    // Act
+    const jobId = await jobQueue.addJob(
+      { jobType: 'sms', payload: { to: 'in-tx@example.com' } },
+      { db: client },
+    );
+
+    // Assert — visible within the transaction
+    const res = await client.query('SELECT id FROM job_queue WHERE id = $1', [
+      jobId,
+    ]);
+    expect(res.rows).toHaveLength(1);
+
+    await client.query('ROLLBACK');
+    client.release();
+  });
+});
+
+describe('addJobs batch insert', () => {
+  let pool: Pool;
+  let dbName: string;
+  let testDbUrl: string;
+  let jobQueue: ReturnType<typeof initJobQueue<TestPayloadMap>>;
+
+  beforeEach(async () => {
+    const setup = await createTestDbAndPool();
+    pool = setup.pool;
+    dbName = setup.dbName;
+    testDbUrl = setup.testDbUrl;
+    const config: JobQueueConfig = {
+      databaseConfig: {
+        connectionString: testDbUrl,
+      },
+    };
+    jobQueue = initJobQueue<TestPayloadMap>(config);
+  });
+
+  afterEach(async () => {
+    jobQueue.getPool().end();
+    await pool.end();
+    await destroyTestDb(dbName);
+  });
+
+  it('inserts multiple jobs and returns IDs in order', async () => {
+    // Act
+    const ids = await jobQueue.addJobs([
+      { jobType: 'email', payload: { to: 'a@test.com' } },
+      { jobType: 'sms', payload: { to: '+1234' } },
+      { jobType: 'email', payload: { to: 'b@test.com' } },
+    ]);
+
+    // Assert
+    expect(ids).toHaveLength(3);
+
+    const job0 = await jobQueue.getJob(ids[0]);
+    expect(job0?.jobType).toBe('email');
+    expect(job0?.payload).toEqual({ to: 'a@test.com' });
+
+    const job1 = await jobQueue.getJob(ids[1]);
+    expect(job1?.jobType).toBe('sms');
+
+    const job2 = await jobQueue.getJob(ids[2]);
+    expect(job2?.jobType).toBe('email');
+    expect(job2?.payload).toEqual({ to: 'b@test.com' });
+  });
+
+  it('returns empty array for empty input', async () => {
+    // Act
+    const ids = await jobQueue.addJobs([]);
+
+    // Assert
+    expect(ids).toEqual([]);
+  });
+
+  it('handles idempotency keys correctly', async () => {
+    // Setup
+    const existingId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'existing@test.com' },
+      idempotencyKey: 'batch-dup',
+    });
+
+    // Act
+    const ids = await jobQueue.addJobs([
+      { jobType: 'email', payload: { to: 'new@test.com' } },
+      {
+        jobType: 'email',
+        payload: { to: 'dup@test.com' },
+        idempotencyKey: 'batch-dup',
+      },
+    ]);
+
+    // Assert
+    expect(ids).toHaveLength(2);
+    expect(ids[1]).toBe(existingId);
+    expect(ids[0]).not.toBe(existingId);
+  });
+});
+
+describe('BYOC: validation errors', () => {
+  it('throws when neither databaseConfig nor pool is provided for postgres', () => {
+    // Act & Assert
+    expect(() =>
+      initJobQueue<TestPayloadMap>({ backend: 'postgres' } as any),
+    ).toThrow(
+      'PostgreSQL backend requires either "databaseConfig" or "pool" to be provided.',
+    );
+  });
+
+  it('throws when neither redisConfig nor client is provided for redis', () => {
+    // Act & Assert
+    expect(() =>
+      initJobQueue<TestPayloadMap>({ backend: 'redis' } as any),
+    ).toThrow(
+      'Redis backend requires either "redisConfig" or "client" to be provided.',
+    );
+  });
+});
+
+describe('event hooks', () => {
+  let pool: Pool;
+  let dbName: string;
+  let testDbUrl: string;
+  let jobQueue: ReturnType<typeof initJobQueue<TestPayloadMap>>;
+
+  beforeEach(async () => {
+    const setup = await createTestDbAndPool();
+    pool = setup.pool;
+    dbName = setup.dbName;
+    testDbUrl = setup.testDbUrl;
+    const config: JobQueueConfig = {
+      databaseConfig: {
+        connectionString: testDbUrl,
+      },
+    };
+    jobQueue = initJobQueue<TestPayloadMap>(config);
+  });
+
+  afterEach(async () => {
+    jobQueue.removeAllListeners();
+    jobQueue.getPool().end();
+    await pool.end();
+    await destroyTestDb(dbName);
+  });
+
+  it('emits job:added on addJob', async () => {
+    const listener = vi.fn();
+    jobQueue.on('job:added', listener);
+
+    const jobId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'test@example.com' },
+    });
+
+    expect(listener).toHaveBeenCalledTimes(1);
+    expect(listener).toHaveBeenCalledWith({ jobId, jobType: 'email' });
+  });
+
+  it('emits job:added for each job in addJobs', async () => {
+    const listener = vi.fn();
+    jobQueue.on('job:added', listener);
+
+    const ids = await jobQueue.addJobs([
+      { jobType: 'email', payload: { to: 'a@test.com' } },
+      { jobType: 'sms', payload: { to: '+1234' } },
+    ]);
+
+    expect(listener).toHaveBeenCalledTimes(2);
+    expect(listener).toHaveBeenCalledWith({ jobId: ids[0], jobType: 'email' });
+    expect(listener).toHaveBeenCalledWith({ jobId: ids[1], jobType: 'sms' });
+  });
+
+  it('emits job:cancelled on cancelJob', async () => {
+    const listener = vi.fn();
+    jobQueue.on('job:cancelled', listener);
+
+    const jobId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'test@example.com' },
+    });
+    await jobQueue.cancelJob(jobId);
+
+    expect(listener).toHaveBeenCalledTimes(1);
+    expect(listener).toHaveBeenCalledWith({ jobId });
+  });
+
+  it('emits job:retried on retryJob', async () => {
+    const listener = vi.fn();
+    jobQueue.on('job:retried', listener);
+
+    const jobId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'test@example.com' },
+    });
+
+    const handler = vi.fn(async () => {
+      throw new Error('fail');
+    });
+    const processor = jobQueue.createProcessor({
+      email: handler,
+      sms: vi.fn(async () => {}),
+      test: vi.fn(async () => {}),
+    });
+    await processor.start();
+
+    await jobQueue.retryJob(jobId);
+
+    expect(listener).toHaveBeenCalledTimes(1);
+    expect(listener).toHaveBeenCalledWith({ jobId });
+  });
+
+  it('emits job:processing and job:completed on successful processing', async () => {
+    const processingListener = vi.fn();
+    const completedListener = vi.fn();
+    jobQueue.on('job:processing', processingListener);
+    jobQueue.on('job:completed', completedListener);
+
+    const jobId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'test@example.com' },
+    });
+
+    const processor = jobQueue.createProcessor({
+      email: vi.fn(async () => {}),
+      sms: vi.fn(async () => {}),
+      test: vi.fn(async () => {}),
+    });
+    await processor.start();
+
+    expect(processingListener).toHaveBeenCalledTimes(1);
+    expect(processingListener).toHaveBeenCalledWith({
+      jobId,
+      jobType: 'email',
+    });
+    expect(completedListener).toHaveBeenCalledTimes(1);
+    expect(completedListener).toHaveBeenCalledWith({
+      jobId,
+      jobType: 'email',
+    });
+  });
+
+  it('emits job:failed with willRetry true when attempts remain', async () => {
+    const listener = vi.fn();
+    jobQueue.on('job:failed', listener);
+
+    const jobId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'test@example.com' },
+      maxAttempts: 3,
+    });
+
+    const processor = jobQueue.createProcessor({
+      email: vi.fn(async () => {
+        throw new Error('boom');
+      }),
+      sms: vi.fn(async () => {}),
+      test: vi.fn(async () => {}),
+    });
+    await processor.start();
+
+    expect(listener).toHaveBeenCalledTimes(1);
+    expect(listener).toHaveBeenCalledWith(
+      expect.objectContaining({
+        jobId,
+        jobType: 'email',
+        willRetry: true,
+        error: expect.any(Error),
+      }),
+    );
+  });
+
+  it('emits job:failed with willRetry false when no attempts remain', async () => {
+    const listener = vi.fn();
+    jobQueue.on('job:failed', listener);
+
+    const jobId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'test@example.com' },
+      maxAttempts: 1,
+    });
+
+    const processor = jobQueue.createProcessor({
+      email: vi.fn(async () => {
+        throw new Error('boom');
+      }),
+      sms: vi.fn(async () => {}),
+      test: vi.fn(async () => {}),
+    });
+    await processor.start();
+
+    expect(listener).toHaveBeenCalledTimes(1);
+    expect(listener).toHaveBeenCalledWith(
+      expect.objectContaining({
+        jobId,
+        jobType: 'email',
+        willRetry: false,
+      }),
+    );
+  });
+
+  it('emits job:waiting when handler calls ctx.waitFor', async () => {
+    const listener = vi.fn();
+    jobQueue.on('job:waiting', listener);
+
+    const jobId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'test@example.com' },
+    });
+
+    const processor = jobQueue.createProcessor({
+      email: vi.fn(async (_payload, _signal, ctx) => {
+        await ctx.waitFor({ hours: 1 });
+      }),
+      sms: vi.fn(async () => {}),
+      test: vi.fn(async () => {}),
+    });
+    await processor.start();
+
+    expect(listener).toHaveBeenCalledTimes(1);
+    expect(listener).toHaveBeenCalledWith({ jobId, jobType: 'email' });
+  });
+
+  it('emits job:progress when handler calls ctx.setProgress', async () => {
+    const listener = vi.fn();
+    jobQueue.on('job:progress', listener);
+
+    const jobId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'test@example.com' },
+    });
+
+    const processor = jobQueue.createProcessor({
+      email: vi.fn(async (_payload, _signal, ctx) => {
+        await ctx.setProgress(50);
+        await ctx.setProgress(100);
+      }),
+      sms: vi.fn(async () => {}),
+      test: vi.fn(async () => {}),
+    });
+    await processor.start();
+
+    expect(listener).toHaveBeenCalledTimes(2);
+    expect(listener).toHaveBeenCalledWith({ jobId, progress: 50 });
+    expect(listener).toHaveBeenCalledWith({ jobId, progress: 100 });
+  });
+
+  it('stores output from ctx.setOutput() and retrieves it via getJob', async () => {
+    const jobId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'output@test.com' },
+    });
+
+    const processor = jobQueue.createProcessor({
+      email: vi.fn(async (_payload, _signal, ctx) => {
+        await ctx.setOutput({ reportUrl: 'https://example.com/report.pdf' });
+      }),
+      sms: vi.fn(async () => {}),
+      test: vi.fn(async () => {}),
+    });
+    await processor.start();
+
+    const job = await jobQueue.getJob(jobId);
+    expect(job?.status).toBe('completed');
+    expect(job?.output).toEqual({
+      reportUrl: 'https://example.com/report.pdf',
+    });
+  });
+
+  it('stores handler return value as output when setOutput is not called', async () => {
+    const jobId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'return@test.com' },
+    });
+
+    const processor = jobQueue.createProcessor({
+      email: vi.fn(async () => {
+        return { processed: true, count: 42 };
+      }),
+      sms: vi.fn(async () => {}),
+      test: vi.fn(async () => {}),
+    });
+    await processor.start();
+
+    const job = await jobQueue.getJob(jobId);
+    expect(job?.status).toBe('completed');
+    expect(job?.output).toEqual({ processed: true, count: 42 });
+  });
+
+  it('setOutput takes precedence over handler return value', async () => {
+    const jobId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'precedence@test.com' },
+    });
+
+    const processor = jobQueue.createProcessor({
+      email: vi.fn(async (_payload, _signal, ctx) => {
+        await ctx.setOutput({ fromSetOutput: true });
+        return { fromReturn: true };
+      }),
+      sms: vi.fn(async () => {}),
+      test: vi.fn(async () => {}),
+    });
+    await processor.start();
+
+    const job = await jobQueue.getJob(jobId);
+    expect(job?.status).toBe('completed');
+    expect(job?.output).toEqual({ fromSetOutput: true });
+  });
+
+  it('output is null for jobs that do not set output (backward compat)', async () => {
+    const jobId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'no-output@test.com' },
+    });
+
+    const processor = jobQueue.createProcessor({
+      email: vi.fn(async () => {}),
+      sms: vi.fn(async () => {}),
+      test: vi.fn(async () => {}),
+    });
+    await processor.start();
+
+    const job = await jobQueue.getJob(jobId);
+    expect(job?.status).toBe('completed');
+    expect(job?.output).toBeNull();
+  });
+
+  it('emits job:output when handler calls ctx.setOutput', async () => {
+    const listener = vi.fn();
+    jobQueue.on('job:output', listener);
+
+    const jobId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'event-output@test.com' },
+    });
+
+    const processor = jobQueue.createProcessor({
+      email: vi.fn(async (_payload, _signal, ctx) => {
+        await ctx.setOutput({ result: 'done' });
+      }),
+      sms: vi.fn(async () => {}),
+      test: vi.fn(async () => {}),
+    });
+    await processor.start();
+
+    expect(listener).toHaveBeenCalledTimes(1);
+    expect(listener).toHaveBeenCalledWith({
+      jobId,
+      output: { result: 'done' },
+    });
+  });
+
+  it('stores scalar output values (string, number, array)', async () => {
+    const jobId1 = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'string-output@test.com' },
+    });
+    const jobId2 = await jobQueue.addJob({
+      jobType: 'sms',
+      payload: { to: '+123' },
+    });
+    const jobId3 = await jobQueue.addJob({
+      jobType: 'test',
+      payload: { foo: 'arr' },
+    });
+
+    const processor = jobQueue.createProcessor({
+      email: vi.fn(async () => 'simple string'),
+      sms: vi.fn(async () => 42),
+      test: vi.fn(async () => [1, 2, 3]),
+    });
+    await processor.start();
+
+    const job1 = await jobQueue.getJob(jobId1);
+    expect(job1?.output).toBe('simple string');
+
+    const job2 = await jobQueue.getJob(jobId2);
+    expect(job2?.output).toBe(42);
+
+    const job3 = await jobQueue.getJob(jobId3);
+    expect(job3?.output).toEqual([1, 2, 3]);
+  });
+
+  it('once fires only once then auto-unsubscribes', async () => {
+    const listener = vi.fn();
+    jobQueue.once('job:added', listener);
+
+    await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'a@test.com' },
+    });
+    await jobQueue.addJob({
+      jobType: 'sms',
+      payload: { to: '+1234' },
+    });
+
+    expect(listener).toHaveBeenCalledTimes(1);
+  });
+
+  it('off removes a listener', async () => {
+    const listener = vi.fn();
+    jobQueue.on('job:added', listener);
+
+    await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'a@test.com' },
+    });
+    expect(listener).toHaveBeenCalledTimes(1);
+
+    jobQueue.off('job:added', listener);
+
+    await jobQueue.addJob({
+      jobType: 'sms',
+      payload: { to: '+1234' },
+    });
+    expect(listener).toHaveBeenCalledTimes(1);
+  });
+
+  it('removeAllListeners clears all listeners for a specific event', async () => {
+    const listener1 = vi.fn();
+    const listener2 = vi.fn();
+    const otherListener = vi.fn();
+    jobQueue.on('job:added', listener1);
+    jobQueue.on('job:added', listener2);
+    jobQueue.on('job:cancelled', otherListener);
+
+    jobQueue.removeAllListeners('job:added');
+
+    await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'a@test.com' },
+    });
+    const jobId = await jobQueue.addJob({
+      jobType: 'sms',
+      payload: { to: '+1234' },
+    });
+    await jobQueue.cancelJob(jobId);
+
+    expect(listener1).not.toHaveBeenCalled();
+    expect(listener2).not.toHaveBeenCalled();
+    expect(otherListener).toHaveBeenCalledTimes(1);
+  });
+
+  it('removeAllListeners with no args clears everything', async () => {
+    const addedListener = vi.fn();
+    const cancelledListener = vi.fn();
+    jobQueue.on('job:added', addedListener);
+    jobQueue.on('job:cancelled', cancelledListener);
+
+    jobQueue.removeAllListeners();
+
+    const jobId = await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'a@test.com' },
+    });
+    await jobQueue.cancelJob(jobId);
+
+    expect(addedListener).not.toHaveBeenCalled();
+    expect(cancelledListener).not.toHaveBeenCalled();
+  });
+
+  it('onError callback still works alongside error event', async () => {
+    const onErrorSpy = vi.fn();
+    const errorListener = vi.fn();
+    jobQueue.on('error', errorListener);
+
+    await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'test@example.com' },
+      maxAttempts: 1,
+    });
+
+    const processor = jobQueue.createProcessor(
+      {
+        email: vi.fn(async () => {
+          throw new Error('boom');
+        }),
+        sms: vi.fn(async () => {}),
+        test: vi.fn(async () => {}),
+      },
+      { onError: onErrorSpy },
+    );
+    await processor.start();
+
+    // job:failed fires for individual job failures; error fires for
+    // batch-level errors caught in processBatchWithHandlers. In this case
+    // the job failure is handled inside processJobWithHandlers and doesn't
+    // propagate to the batch-level error handler. So we verify that
+    // onError still works as configured and job:failed events fire.
+    const failedListener = vi.fn();
+    jobQueue.on('job:failed', failedListener);
+
+    await jobQueue.addJob({
+      jobType: 'email',
+      payload: { to: 'test2@example.com' },
+      maxAttempts: 1,
+    });
+    await processor.start();
+
+    expect(failedListener).toHaveBeenCalledTimes(1);
+  });
 });