@nickmeriano/task 0.11.0 → 0.12.0

package/src/git-serve.test.ts

@@ -11,11 +11,12 @@
  *    runs; the board's own origin and origin-less clients pass.
  * 4. Degradation: a repo with no origin advertises no `git` capability and
  *    404s the whole route group — the self-hiding rule the UI builds on.
+ * 5. A board reached through a symlinked path is still a board (TAS-qn8td).
  */
 
 import assert from "node:assert/strict"
 import { after, test } from "node:test"
-import { mkdtempSync, mkdirSync, rmSync, writeFileSync } from "node:fs"
+import { mkdtempSync, mkdirSync, rmSync, symlinkSync, writeFileSync } from "node:fs"
 import { tmpdir } from "node:os"
 import { join } from "node:path"
 import { spawnSync } from "node:child_process"
@@ -232,6 +233,45 @@ test("a plain directory (no git at all) behaves the same", async () => {
   assert.equal("git" in project.body, false)
 })
 
+test("a repo reached through a symlink still finds its boards", async () => {
+  // `git rev-parse --show-toplevel` resolves symlinks and a Store's taskDir
+  // does not, so comparing them unresolved drops every board — commit 400s and
+  // status calls board files `otherDirty`, quietly. The symlink is explicit
+  // here rather than inherited from tmpdir(): on macOS /var/folders is already
+  // one (which is how this was found), on Linux it is not, and the property
+  // has to hold on both.
+  const home = tempDir()
+  const real = join(home, "real")
+  mkdirSync(real)
+  const bare = join(real, "origin.git")
+  sh(real, "git", "init", "--quiet", "--bare", "-b", "main", bare)
+  sh(real, "git", "clone", "--quiet", bare, join(real, "clone"))
+  const link = join(home, "link")
+  symlinkSync(real, link)
+
+  const clone = join(link, "clone")
+  sh(clone, "git", "config", "user.name", "Test")
+  sh(clone, "git", "config", "user.email", "test@example.com")
+  const store = initProject(clone, { name: "linked", prefix: "LNK" })
+  const first = store.create({ title: "First", status: "todo" }).key
+  sh(clone, "git", "add", "-A")
+  sh(clone, "git", "commit", "--quiet", "-m", "board")
+  sh(clone, "git", "push", "--quiet", "-u", "origin", "main")
+
+  const base = await serve(clone)
+  await call(base, `/api/tasks/${first}`, Object.assign(post({ status: "in_progress" }), { method: "PATCH" }))
+
+  const status = await call(base, "/api/git/status")
+  assert.equal(status.status, 200)
+  const dirty = status.body.dirty as { path: string }[]
+  assert.ok(dirty.length > 0, `board edits must read as board dirt: ${JSON.stringify(status.body)}`)
+  assert.ok(dirty.every((f) => f.path.startsWith(".task/")))
+  assert.equal(status.body.otherDirty, 0, "and must not be counted as other people's mess")
+
+  const commit = await call(base, "/api/git/commit", post({ message: "chore(board): through a link" }))
+  assert.equal(commit.status, 200, JSON.stringify(commit.body))
+})
+
 test("the gh-less PR fallback is the exact GitHub compare URL, branches escaped", () => {
   assert.equal(
     compareUrl({ owner: "nicmeriano", repo: "nickmeriano.com" }, "main", "board/2026-09-01"),

package/src/git-serve.ts

@@ -19,6 +19,7 @@
  */
 
 import { spawnSync } from "node:child_process"
+import { realpathSync } from "node:fs"
 import { relative, sep } from "node:path"
 import { claimBranch, claimNamespace, release } from "./claim.ts"
 import { remoteClaimTips, syncClaimRefs } from "./claim-io.ts"
@@ -31,6 +32,19 @@ export interface ServedBoard {
   store: Store
 }
 
+/**
+ * A path with its symlinks resolved, or the path itself when it cannot be —
+ * a board directory that does not exist on disk yet makes `realpathSync`
+ * throw ENOENT, and that is not a reason to lose the board.
+ */
+function realPath(path: string): string {
+  try {
+    return realpathSync(path)
+  } catch {
+    return path
+  }
+}
+
 /** A failure the route turns into a JSON error with this status. */
 export class GitServeError extends Error {
   readonly status: number
@@ -194,11 +208,25 @@ export class GitServe {
     return records
   }
 
-  /** Each board's `.task` dir as a toplevel-relative posix pathspec. */
+  /**
+   * Each board's `.task` dir as a toplevel-relative posix pathspec.
+   *
+   * Both sides are resolved through {@link realPath} before they are
+   * compared. `git rev-parse --show-toplevel` already returns a symlink-free
+   * path, while a store's `taskDir` is built from whatever path the process
+   * was given — so on a checkout reached through a symlink the two disagree,
+   * `relative()` answers `../../…`, and the guard below silently drops every
+   * board. That is not a corner case on macOS, where `os.tmpdir()` is
+   * `/var/folders/…` → `/private/var/folders/…`; it is also any repo under a
+   * symlinked parent. Dropping every board turns `commit` into a 400 and,
+   * worse, makes `status` report board files as `otherDirty` with an empty
+   * `dirty` list — a board that looks clean while `.task/` is full of edits.
+   */
   private boardDirs(top: string): Map<string, string> {
+    const root = realPath(top)
     const dirs = new Map<string, string>()
     for (const { id, store } of this.boards()) {
-      const rel = relative(top, store.taskDir).split(sep).join("/")
+      const rel = relative(root, realPath(store.taskDir)).split(sep).join("/")
       if (rel === "" || rel.startsWith("..")) continue
       dirs.set(id, rel)
     }

package/src/index.ts

@@ -42,5 +42,15 @@ export {
   type ReleaseResult,
 } from "./claim.ts"
 export { createTaskServer } from "./server.ts"
+// The live proxy for an exported board: the same read routes `task serve`
+// answers, from a GitHub repository, as one platform-neutral fetch handler.
+// `task export` ships it as a Cloudflare Pages Function beside the snapshot;
+// any other host gets this and a three-line adapter — see the README.
+export {
+  createBoardHandler,
+  type BoardHandler,
+  type BoardHandlerOptions,
+} from "./board/handler.ts"
+export { buildSnapshot, writeExport, type ExportSummary, type WriteExportOptions } from "./export.ts"
 export { resolveAuthor, ANONYMOUS, type Author, type AuthorSource } from "./author.ts"
 export * from "./types.ts"