@ni/fast-foundation 10.2.1 → 10.2.3

package/dist/esm/toolbar/toolbar.js

@@ -61,6 +61,12 @@ export class Toolbar extends FoundationElement {
          * @internal
          */
         this.direction = Direction.ltr;
+        /**
+         * The collection of focusable toolbar controls.
+         *
+         * @internal
+         */
+        this.focusableElements = [];
         /**
          * The orientation of the toolbar.
          *
@@ -81,7 +87,7 @@ export class Toolbar extends FoundationElement {
     }
     set activeIndex(value) {
         if (this.$fastController.isConnected) {
-            this._activeIndex = limit(0, this.focusableElements.length - 1, value);
+            this._activeIndex = limit(0, this.focusableElements.length > 0 ? this.focusableElements.length - 1 : 0, value);
             Observable.notify(this, "activeIndex");
         }
     }
@@ -96,7 +102,7 @@ export class Toolbar extends FoundationElement {
      * @internal
      */
     mouseDownHandler(e) {
-        const activeIndex = this.focusableElements?.findIndex(x => x.contains(e.target));
+        const activeIndex = this.focusableElements.findIndex(x => x.contains(e.target));
         if (activeIndex > -1 && this.activeIndex !== activeIndex) {
             this.setFocusedElement(activeIndex);
         }
@@ -153,7 +159,7 @@ export class Toolbar extends FoundationElement {
             return !e.target.closest("[role=radiogroup]");
         }
         const nextIndex = this.activeIndex + incrementer;
-        if (this.focusableElements[nextIndex]) {
+        if (this.focusableElements.length > 0 && this.focusableElements[nextIndex]) {
             e.preventDefault();
         }
         this.setFocusedElement(nextIndex);
@@ -176,7 +182,7 @@ export class Toolbar extends FoundationElement {
      * @internal
      */
     reduceFocusableElements() {
-        const previousFocusedElement = this.focusableElements?.[this.activeIndex];
+        const previousFocusedElement = this.focusableElements[this.activeIndex];
         this.focusableElements = this.allSlottedItems.reduce(Toolbar.reduceFocusableItems, []);
         // If the previously active item is still focusable, adjust the active index to the
         // index of that item.
@@ -193,7 +199,8 @@ export class Toolbar extends FoundationElement {
     setFocusedElement(activeIndex = this.activeIndex) {
         this.activeIndex = activeIndex;
         this.setFocusableElements();
-        if (this.focusableElements[this.activeIndex] &&
+        if (this.focusableElements.length > 0 &&
+            this.focusableElements[this.activeIndex] &&
             // Don't focus the toolbar element if some event handlers moved
             // the focus on another element in the page.
             this.contains(getRootActiveElement(this))) {

package/dist/fast-foundation.js

@@ -1327,9 +1327,6 @@ function compileTemplate(template, directives) {
     };
 }
 
-// A singleton Range instance used to efficiently remove ranges of DOM nodes.
-// See the implementation of HTMLView below for further details.
-const range = document.createRange();
 /**
  * The standard View implementation, which also implements ElementView and SyntheticView.
  * @public
@@ -1464,23 +1461,16 @@ class HTMLView {
         this.source = null;
     }
     /**
-     * Efficiently disposes of a contiguous range of synthetic view instances.
+     * Disposes of a contiguous range of synthetic view instances.
      * @param views - A contiguous range of views to be disposed.
      */
     static disposeContiguousBatch(views) {
         if (views.length === 0) {
             return;
         }
-        range.setStartBefore(views[0].firstChild);
-        range.setEndAfter(views[views.length - 1].lastChild);
-        range.deleteContents();
         for (let i = 0, ii = views.length; i < ii; ++i) {
             const view = views[i];
-            const behaviors = view.behaviors;
-            const oldSource = view.source;
-            for (let j = 0, jj = behaviors.length; j < jj; ++j) {
-                behaviors[j].unbind(oldSource);
-            }
+            view.dispose();
         }
     }
 }
@@ -20029,6 +20019,12 @@ class Toolbar extends FoundationElement {
          * @internal
          */
         this.direction = Direction.ltr;
+        /**
+         * The collection of focusable toolbar controls.
+         *
+         * @internal
+         */
+        this.focusableElements = [];
         /**
          * The orientation of the toolbar.
          *
@@ -20049,7 +20045,7 @@ class Toolbar extends FoundationElement {
     }
     set activeIndex(value) {
         if (this.$fastController.isConnected) {
-            this._activeIndex = limit(0, this.focusableElements.length - 1, value);
+            this._activeIndex = limit(0, this.focusableElements.length > 0 ? this.focusableElements.length - 1 : 0, value);
             Observable.notify(this, "activeIndex");
         }
     }
@@ -20064,7 +20060,7 @@ class Toolbar extends FoundationElement {
      * @internal
      */
     mouseDownHandler(e) {
-        const activeIndex = this.focusableElements?.findIndex(x => x.contains(e.target));
+        const activeIndex = this.focusableElements.findIndex(x => x.contains(e.target));
         if (activeIndex > -1 && this.activeIndex !== activeIndex) {
             this.setFocusedElement(activeIndex);
         }
@@ -20121,7 +20117,7 @@ class Toolbar extends FoundationElement {
             return !e.target.closest("[role=radiogroup]");
         }
         const nextIndex = this.activeIndex + incrementer;
-        if (this.focusableElements[nextIndex]) {
+        if (this.focusableElements.length > 0 && this.focusableElements[nextIndex]) {
             e.preventDefault();
         }
         this.setFocusedElement(nextIndex);
@@ -20144,7 +20140,7 @@ class Toolbar extends FoundationElement {
      * @internal
      */
     reduceFocusableElements() {
-        const previousFocusedElement = this.focusableElements?.[this.activeIndex];
+        const previousFocusedElement = this.focusableElements[this.activeIndex];
         this.focusableElements = this.allSlottedItems.reduce(Toolbar.reduceFocusableItems, []);
         // If the previously active item is still focusable, adjust the active index to the
         // index of that item.
@@ -20161,7 +20157,8 @@ class Toolbar extends FoundationElement {
     setFocusedElement(activeIndex = this.activeIndex) {
         this.activeIndex = activeIndex;
         this.setFocusableElements();
-        if (this.focusableElements[this.activeIndex] &&
+        if (this.focusableElements.length > 0 &&
+            this.focusableElements[this.activeIndex] &&
             // Don't focus the toolbar element if some event handlers moved
             // the focus on another element in the page.
             this.contains(getRootActiveElement(this))) {