@ngx-formly/core 6.0.2 → 6.0.4

package/fesm2020/ngx-formly-core.mjs

@@ -3,7 +3,7 @@ import { Type, TemplateRef, ComponentRef, ChangeDetectorRef, InjectionToken, Inj
 import * as i2 from '@angular/forms';
 import { AbstractControl, FormGroup, FormArray, FormControl, Validators } from '@angular/forms';
 import { isObservable, merge, of, Observable, Subject } from 'rxjs';
-import { distinctUntilChanged, startWith, debounceTime, filter, switchMap, take, map } from 'rxjs/operators';
+import { distinctUntilChanged, startWith, debounceTime, filter, switchMap, take, tap, map } from 'rxjs/operators';
 import * as i2$1 from '@angular/common';
 import { DOCUMENT, CommonModule } from '@angular/common';
 import * as i1 from '@angular/platform-browser';
@@ -410,7 +410,12 @@ class FormlyConfig {
         }
         const componentRef = _viewContainerRef.createComponent(type.component, { injector: _injector });
         defineHiddenProp(type, '_componentRef', componentRef);
-        componentRef.destroy();
+        try {
+            componentRef.destroy();
+        }
+        catch (e) {
+            console.error(`An error occurred while destroying the Formly component type "${field.type}"`, e);
+        }
         return type._componentRef;
     }
     setWrapper(options) {
@@ -889,6 +894,23 @@ class FormlyField {
             observeDeep(field, ['props'], () => field.options.detectChanges(field)),
             observeDeep(field.options, ['formState'], () => field.options.detectChanges(field)),
         ];
+        for (const key of Object.keys(field._expressions)) {
+            const expressionObserver = observe(field, ['_expressions', key], ({ currentValue, previousValue }) => {
+                if (previousValue?.subscription) {
+                    previousValue.subscription.unsubscribe();
+                    previousValue.subscription = null;
+                }
+                if (isObservable(currentValue.value$)) {
+                    currentValue.subscription = currentValue.value$.subscribe();
+                }
+            });
+            subscribes.push(() => {
+                if (field._expressions[key]?.subscription) {
+                    field._expressions[key].subscription.unsubscribe();
+                }
+                expressionObserver.unsubscribe();
+            });
+        }
         for (const path of [['template'], ['fieldGroupClassName'], ['validation', 'show']]) {
             const fieldObserver = observe(field, path, ({ firstChange }) => !firstChange && field.options.detectChanges(field));
             subscribes.push(() => fieldObserver.unsubscribe());
@@ -1408,7 +1430,8 @@ class FieldArrayType extends FieldType {
         markAsDirty && this.formControl.markAsDirty();
     }
     _build() {
-        this.options.build(this.field);
+        const fields = this.field.formControl._fields ?? [this.field];
+        fields.forEach((f) => this.options.build(f));
         this.options.fieldChanges.next({
             field: this.field,
             value: getFieldValue(this.field),
@@ -1510,22 +1533,11 @@ class FieldExpressionExtension {
                 field._expressions[key] = this.parseExpressions(field, key, expr);
             }
             else if (expr instanceof Observable) {
-                const subscribe = () => expr.subscribe((v) => {
-                    this.evalExpr(field, key, v);
-                });
-                let subscription = null;
-                const onInit = field.hooks.onInit;
-                field.hooks.onInit = () => {
-                    if (subscription === null) {
-                        subscription = subscribe();
-                    }
-                    return onInit?.(field);
-                };
-                const onDestroy = field.hooks.onDestroy;
-                field.hooks.onDestroy = () => {
-                    onDestroy?.(field);
-                    subscription.unsubscribe();
-                    subscription = null;
+                field._expressions[key] = {
+                    value$: expr.pipe(tap((v) => {
+                        this.evalExpr(field, key, v);
+                        field.options.detectChanges(field);
+                    })),
                 };
             }
         };
@@ -1619,7 +1631,7 @@ class FieldExpressionExtension {
         let fieldChanged = false;
         if (field._expressions) {
             for (const key of Object.keys(field._expressions)) {
-                field._expressions[key].callback(ignoreCache) && (fieldChanged = true);
+                field._expressions[key].callback?.(ignoreCache) && (fieldChanged = true);
             }
         }
         field.fieldGroup?.forEach((f) => this.checkExpressions(f, ignoreCache) && (fieldChanged = true));