@nguyenquangthai/pi-todo 0.2.2 → 0.2.3

package/src/reminder-cadence.ts

@@ -1,116 +1,116 @@
-/**
- * Pure cadence logic for system-reminder injection (ported from tintinweb/pi-tasks).
- *
- * tool_result tracks cadence only — never mutates tool output.
- * context drains the pending reminder into a transient user message for one LLM call.
- *
- * Reminder body is state-aware (edxeth/meh pi-tasks pattern): list open todos only,
- * and call out the in_progress item so the model updates completed status.
- */
-
-import { formatPlainTodoLine } from "./format.js";
-import type { TodoItem } from "./types.js";
-import { hasOpenTodos, isOpenTodo } from "./validate.js";
-
-export interface CadenceState {
-  currentTurn: number;
-  lastTodoToolUseTurn: number;
-  reminderInjectedThisCycle: boolean;
-  reminderDue: boolean;
-}
-
-export interface CadenceConfig {
-  /** Turns without a todo-tool call before a reminder is considered due. */
-  reminderInterval: number;
-  /** Tool names that count as todo usage and reset cadence. */
-  todoToolNames: ReadonlySet<string>;
-}
-
-export function createCadenceState(): CadenceState {
-  return {
-    currentTurn: 0,
-    lastTodoToolUseTurn: 0,
-    reminderInjectedThisCycle: false,
-    reminderDue: false,
-  };
-}
-
-export function resetCadenceState(state: CadenceState): void {
-  state.currentTurn = 0;
-  state.lastTodoToolUseTurn = 0;
-  state.reminderInjectedThisCycle = false;
-  state.reminderDue = false;
-}
-
-export function onTurnStart(state: CadenceState): void {
-  state.currentTurn++;
-}
-
-/**
- * Decide cadence change from a tool_result. Mutates state; returns whether
- * the reminder should be queued for the next context event.
- *
- * `hasOpenWork` must reflect pending/in_progress only — all-terminal lists
- * should not re-arm reminders (OpenCode: done means overlay gone).
- */
-export function evaluateToolResult(
-  state: CadenceState,
-  toolName: string,
-  hasOpenWork: boolean,
-  config: CadenceConfig,
-): { markDue: boolean } {
-  if (config.todoToolNames.has(toolName)) {
-    state.lastTodoToolUseTurn = state.currentTurn;
-    state.reminderInjectedThisCycle = false;
-    state.reminderDue = false;
-    return { markDue: false };
-  }
-
-  if (state.currentTurn - state.lastTodoToolUseTurn < config.reminderInterval) {
-    return { markDue: false };
-  }
-  if (state.reminderInjectedThisCycle) return { markDue: false };
-  if (!hasOpenWork) return { markDue: false };
-
-  state.reminderDue = true;
-  return { markDue: true };
-}
-
-/** Drain pending reminder when `context` fires. */
-export function drainReminderForContext(state: CadenceState): boolean {
-  if (!state.reminderDue) return false;
-  state.reminderDue = false;
-  state.reminderInjectedThisCycle = true;
-  state.lastTodoToolUseTurn = state.currentTurn;
-  return true;
-}
-
-/** Default: 4 turns without todowrite/todoread while open work remains. */
-export const REMINDER_INTERVAL = 4;
-
-/**
- * Build a transient system-reminder from the live open-todo snapshot.
- * Returns null when there is nothing open (caller must not inject).
- */
-export function buildSystemReminder(todos: readonly TodoItem[]): string | null {
-  if (!hasOpenTodos(todos)) return null;
-
-  const open = todos.filter(isOpenTodo);
-  const inProgress = open.filter((t) => t.status === "in_progress");
-  const lines = open.map(formatPlainTodoLine);
-
-  const focus =
-    inProgress.length > 0
-      ? `Active item still in_progress: "${inProgress[0].content}". If that work is finished, call todowrite immediately with it marked completed (full replace), then set the next pending item to in_progress (exactly one). Do not leave a stale [•] after finishing a step.`
-      : `Open items are still pending with none in_progress. If you are about to work, call todowrite and mark exactly one item in_progress before continuing.`;
-
-  return `<system-reminder>
-The todo tools haven't been used recently, and open work remains:
-
-${lines.map((l) => `- ${l}`).join("\n")}
-
-${focus}
-
-Only act if relevant to the current work. This is a gentle reminder — ignore if not applicable. NEVER mention this reminder to the user.
-</system-reminder>`;
-}
+/**
+ * Pure cadence logic for system-reminder injection (ported from tintinweb/pi-tasks).
+ *
+ * tool_result tracks cadence only — never mutates tool output.
+ * context drains the pending reminder into a transient user message for one LLM call.
+ *
+ * Reminder body is state-aware (edxeth/meh pi-tasks pattern): list open todos only,
+ * and call out the in_progress item so the model updates completed status.
+ */
+
+import { formatPlainTodoLine } from "./format.js";
+import type { TodoItem } from "./types.js";
+import { hasOpenTodos, isOpenTodo } from "./validate.js";
+
+export interface CadenceState {
+  currentTurn: number;
+  lastTodoToolUseTurn: number;
+  reminderInjectedThisCycle: boolean;
+  reminderDue: boolean;
+}
+
+export interface CadenceConfig {
+  /** Turns without a todo-tool call before a reminder is considered due. */
+  reminderInterval: number;
+  /** Tool names that count as todo usage and reset cadence. */
+  todoToolNames: ReadonlySet<string>;
+}
+
+export function createCadenceState(): CadenceState {
+  return {
+    currentTurn: 0,
+    lastTodoToolUseTurn: 0,
+    reminderInjectedThisCycle: false,
+    reminderDue: false,
+  };
+}
+
+export function resetCadenceState(state: CadenceState): void {
+  state.currentTurn = 0;
+  state.lastTodoToolUseTurn = 0;
+  state.reminderInjectedThisCycle = false;
+  state.reminderDue = false;
+}
+
+export function onTurnStart(state: CadenceState): void {
+  state.currentTurn++;
+}
+
+/**
+ * Decide cadence change from a tool_result. Mutates state; returns whether
+ * the reminder should be queued for the next context event.
+ *
+ * `hasOpenWork` must reflect pending/in_progress only — all-terminal lists
+ * should not re-arm reminders (OpenCode: done means overlay gone).
+ */
+export function evaluateToolResult(
+  state: CadenceState,
+  toolName: string,
+  hasOpenWork: boolean,
+  config: CadenceConfig,
+): { markDue: boolean } {
+  if (config.todoToolNames.has(toolName)) {
+    state.lastTodoToolUseTurn = state.currentTurn;
+    state.reminderInjectedThisCycle = false;
+    state.reminderDue = false;
+    return { markDue: false };
+  }
+
+  if (state.currentTurn - state.lastTodoToolUseTurn < config.reminderInterval) {
+    return { markDue: false };
+  }
+  if (state.reminderInjectedThisCycle) return { markDue: false };
+  if (!hasOpenWork) return { markDue: false };
+
+  state.reminderDue = true;
+  return { markDue: true };
+}
+
+/** Drain pending reminder when `context` fires. */
+export function drainReminderForContext(state: CadenceState): boolean {
+  if (!state.reminderDue) return false;
+  state.reminderDue = false;
+  state.reminderInjectedThisCycle = true;
+  state.lastTodoToolUseTurn = state.currentTurn;
+  return true;
+}
+
+/** Default: 4 turns without todo_write/todo_read while open work remains. */
+export const REMINDER_INTERVAL = 4;
+
+/**
+ * Build a transient system-reminder from the live open-todo snapshot.
+ * Returns null when there is nothing open (caller must not inject).
+ */
+export function buildSystemReminder(todos: readonly TodoItem[]): string | null {
+  if (!hasOpenTodos(todos)) return null;
+
+  const open = todos.filter(isOpenTodo);
+  const inProgress = open.filter((t) => t.status === "in_progress");
+  const lines = open.map(formatPlainTodoLine);
+
+  const focus =
+    inProgress.length > 0
+      ? `Active item still in_progress: "${inProgress[0].content}". If that work is finished, call todo_write immediately with it marked completed (full replace), then set the next pending item to in_progress (exactly one). Do not leave a stale [•] after finishing a step.`
+      : `Open items are still pending with none in_progress. If you are about to work, call todo_write and mark exactly one item in_progress before continuing.`;
+
+  return `<system-reminder>
+The todo tools haven't been used recently, and open work remains:
+
+${lines.map((l) => `- ${l}`).join("\n")}
+
+${focus}
+
+Only act if relevant to the current work. This is a gentle reminder — ignore if not applicable. NEVER mention this reminder to the user.
+</system-reminder>`;
+}

package/src/replay.ts

@@ -1,69 +1,69 @@
-import type { TodoItem, TodoWriteDetails } from "./types.js";
-import { TODO_STATE_ENTRY_TYPE, TOOL_WRITE } from "./types.js";
-import { TERMINAL_STATUSES, TODO_PRIORITIES, TODO_STATUSES } from "./types.js";
-
-type BranchEntry = {
-  type?: string;
-  customType?: string;
-  data?: unknown;
-  message?: unknown;
-};
-
-function isRecord(value: unknown): value is Record<string, unknown> {
-  return !!value && typeof value === "object";
-}
-
-function isTodoItem(value: unknown): value is TodoItem {
-  if (!isRecord(value)) return false;
-  return (
-    typeof value.content === "string" &&
-    typeof value.status === "string" &&
-    (TODO_STATUSES as readonly string[]).includes(value.status) &&
-    typeof value.priority === "string" &&
-    (TODO_PRIORITIES as readonly string[]).includes(value.priority)
-  );
-}
-
-function isTodoList(value: unknown): value is TodoItem[] {
-  return Array.isArray(value) && value.every(isTodoItem);
-}
-
-function isWriteDetails(value: unknown): value is TodoWriteDetails {
-  return isRecord(value) && isTodoList(value.todos);
-}
-
-/**
- * Last-write-wins over the current branch:
- * - custom `pi-todo.state` entries
- * - `todowrite` toolResult details
- */
-export function replayFromBranch(ctx: {
-  sessionManager: { getBranch(): Iterable<unknown> };
-}): TodoItem[] {
-  let todos: TodoItem[] = [];
-
-  for (const entry of ctx.sessionManager.getBranch()) {
-    const e = entry as BranchEntry;
-
-    if (e.type === "custom" && e.customType === TODO_STATE_ENTRY_TYPE) {
-      if (isRecord(e.data) && isTodoList(e.data.todos)) {
-        todos = e.data.todos.map((t) => ({ ...t }));
-      }
-      continue;
-    }
-
-    if (e.type !== "message" || !isRecord(e.message)) continue;
-    const msg = e.message;
-    if (msg.role !== "toolResult" || msg.toolName !== TOOL_WRITE) continue;
-    if (!isWriteDetails(msg.details)) continue;
-    // Skip error envelopes — they did not commit
-    if (msg.details.error) continue;
-    todos = msg.details.todos.map((t) => ({ ...t }));
-  }
-
-  return todos;
-}
-
-export function isTerminalList(todos: readonly TodoItem[]): boolean {
-  return todos.length === 0 || todos.every((t) => TERMINAL_STATUSES.has(t.status));
-}
+import type { TodoItem, TodoWriteDetails } from "./types.js";
+import { TODO_STATE_ENTRY_TYPE, TOOL_WRITE } from "./types.js";
+import { TERMINAL_STATUSES, TODO_PRIORITIES, TODO_STATUSES } from "./types.js";
+
+type BranchEntry = {
+  type?: string;
+  customType?: string;
+  data?: unknown;
+  message?: unknown;
+};
+
+function isRecord(value: unknown): value is Record<string, unknown> {
+  return !!value && typeof value === "object";
+}
+
+function isTodoItem(value: unknown): value is TodoItem {
+  if (!isRecord(value)) return false;
+  return (
+    typeof value.content === "string" &&
+    typeof value.status === "string" &&
+    (TODO_STATUSES as readonly string[]).includes(value.status) &&
+    typeof value.priority === "string" &&
+    (TODO_PRIORITIES as readonly string[]).includes(value.priority)
+  );
+}
+
+function isTodoList(value: unknown): value is TodoItem[] {
+  return Array.isArray(value) && value.every(isTodoItem);
+}
+
+function isWriteDetails(value: unknown): value is TodoWriteDetails {
+  return isRecord(value) && isTodoList(value.todos);
+}
+
+/**
+ * Last-write-wins over the current branch:
+ * - custom `pi-todo.state` entries
+ * - `todo_write` toolResult details
+ */
+export function replayFromBranch(ctx: {
+  sessionManager: { getBranch(): Iterable<unknown> };
+}): TodoItem[] {
+  let todos: TodoItem[] = [];
+
+  for (const entry of ctx.sessionManager.getBranch()) {
+    const e = entry as BranchEntry;
+
+    if (e.type === "custom" && e.customType === TODO_STATE_ENTRY_TYPE) {
+      if (isRecord(e.data) && isTodoList(e.data.todos)) {
+        todos = e.data.todos.map((t) => ({ ...t }));
+      }
+      continue;
+    }
+
+    if (e.type !== "message" || !isRecord(e.message)) continue;
+    const msg = e.message;
+    if (msg.role !== "toolResult" || msg.toolName !== TOOL_WRITE) continue;
+    if (!isWriteDetails(msg.details)) continue;
+    // Skip error envelopes — they did not commit
+    if (msg.details.error) continue;
+    todos = msg.details.todos.map((t) => ({ ...t }));
+  }
+
+  return todos;
+}
+
+export function isTerminalList(todos: readonly TodoItem[]): boolean {
+  return todos.length === 0 || todos.every((t) => TERMINAL_STATUSES.has(t.status));
+}

package/src/store.ts

@@ -1,36 +1,36 @@
-import type { TodoItem } from "./types.js";
-
-let currentTodos: TodoItem[] = [];
-/** Serializes todowrite/todoread across parallel tool batches. */
-let storeChain: Promise<unknown> = Promise.resolve();
-
-export function getTodos(): TodoItem[] {
-  return currentTodos.map((t) => ({ ...t }));
-}
-
-export function setTodos(todos: readonly TodoItem[]): void {
-  currentTodos = todos.map((t) => ({ ...t }));
-}
-
-export function clearTodos(): void {
-  currentTodos = [];
-}
-
-/**
- * Run store-touching work in a single-file queue so parallel tool batches
- * (todowrite + todoread in the same turn) cannot race.
- */
-export function withStoreLock<T>(fn: () => T | Promise<T>): Promise<T> {
-  const run = storeChain.then(() => fn());
-  storeChain = run.then(
-    () => undefined,
-    () => undefined,
-  );
-  return run;
-}
-
-/** Test helper — reset module state between tests. */
-export function __resetStore(): void {
-  currentTodos = [];
-  storeChain = Promise.resolve();
-}
+import type { TodoItem } from "./types.js";
+
+let currentTodos: TodoItem[] = [];
+/** Serializes todo_write/todo_read across parallel tool batches. */
+let storeChain: Promise<unknown> = Promise.resolve();
+
+export function getTodos(): TodoItem[] {
+  return currentTodos.map((t) => ({ ...t }));
+}
+
+export function setTodos(todos: readonly TodoItem[]): void {
+  currentTodos = todos.map((t) => ({ ...t }));
+}
+
+export function clearTodos(): void {
+  currentTodos = [];
+}
+
+/**
+ * Run store-touching work in a single-file queue so parallel tool batches
+ * (todo_write + todo_read in the same turn) cannot race.
+ */
+export function withStoreLock<T>(fn: () => T | Promise<T>): Promise<T> {
+  const run = storeChain.then(() => fn());
+  storeChain = run.then(
+    () => undefined,
+    () => undefined,
+  );
+  return run;
+}
+
+/** Test helper — reset module state between tests. */
+export function __resetStore(): void {
+  currentTodos = [];
+  storeChain = Promise.resolve();
+}

package/src/tools/todoread.ts

@@ -37,13 +37,18 @@ export function registerTodoReadTool(pi: ExtensionAPI): void {
     },
 
     renderCall(_args, theme) {
-      return new Text(theme.fg("toolTitle", theme.bold("todoread")), 0, 0);
+      return new Text(theme.fg("toolTitle", theme.bold("todo_read")), 0, 0);
     },
 
     renderResult(result, _opts, theme) {
       const details = result.details as { todos?: unknown[] } | undefined;
-      const n = Array.isArray(details?.todos) ? details.todos.length : 0;
-      return new Text(theme.fg("muted", `${n} todo(s)`), 0, 0);
+      const todos = details?.todos;
+      if (!Array.isArray(todos) || todos.length === 0) {
+        return new Text(theme.fg("dim", "0 items"), 0, 0);
+      }
+      const total = todos.length;
+      const open = Array.isArray(todos) ? todos.filter((t: any) => t.status === "pending" || t.status === "in_progress").length : 0;
+      return new Text(theme.fg("muted", `${open} open / ${total} total`), 0, 0);
     },
   });
 }

package/src/tools/todowrite.ts

@@ -69,7 +69,7 @@ export function registerTodoWriteTool(
     renderCall(args, theme) {
       const n = Array.isArray(args.todos) ? args.todos.length : 0;
       return new Text(
-        theme.fg("toolTitle", theme.bold("todowrite ")) + theme.fg("muted", `${n} item(s)`),
+        theme.fg("toolTitle", theme.bold("todo_write ")) + theme.fg("accent", `${n} item(s)`),
         0,
         0,
       );
@@ -84,6 +84,11 @@ export function registerTodoWriteTool(
         return new Text(theme.fg("dim", "No change"), 0, 0);
       }
       const text = result.content[0];
+      if (!details?.error && !details?.unchanged) {
+        const open = details?.todos ? details.todos.filter((t: any) => t.status === "pending" || t.status === "in_progress").length : 0;
+        const total = details?.todos?.length ?? 0;
+        return new Text(theme.fg("success", "✓ ") + theme.fg("muted", `${open} open / ${total} total`), 0, 0);
+      }
       const msg = text?.type === "text" ? text.text.split("\n")[0] ?? "Updated" : "Updated";
       return new Text(theme.fg("success", "✓ ") + theme.fg("muted", msg), 0, 0);
     },

package/src/types.ts

@@ -1,29 +1,29 @@
-export const TODO_STATUSES = ["pending", "in_progress", "completed", "cancelled"] as const;
-export type TodoStatus = (typeof TODO_STATUSES)[number];
-
-export const TODO_PRIORITIES = ["high", "medium", "low"] as const;
-export type TodoPriority = (typeof TODO_PRIORITIES)[number];
-
-export const TERMINAL_STATUSES: ReadonlySet<TodoStatus> = new Set(["completed", "cancelled"]);
-
-export interface TodoItem {
-  content: string;
-  status: TodoStatus;
-  priority: TodoPriority;
-}
-
-export interface TodoWriteDetails {
-  todos: TodoItem[];
-  error?: string;
-  unchanged?: boolean;
-}
-
-export const TODO_STATE_ENTRY_TYPE = "pi-todo.state";
-export const TOOL_WRITE = "todowrite";
-export const TOOL_READ = "todoread";
-export const WIDGET_KEY = "pi-todo";
-export const MAX_OVERLAY_LINES = 12;
-/** Max characters per todo content after sanitize (context/tool safety). */
-export const MAX_CONTENT_LENGTH = 500;
-/** Max todo lines echoed in todowrite/todoread text (full list still in details/JSON). */
-export const MAX_RESULT_LINES = 40;
+export const TODO_STATUSES = ["pending", "in_progress", "completed", "cancelled"] as const;
+export type TodoStatus = (typeof TODO_STATUSES)[number];
+
+export const TODO_PRIORITIES = ["high", "medium", "low"] as const;
+export type TodoPriority = (typeof TODO_PRIORITIES)[number];
+
+export const TERMINAL_STATUSES: ReadonlySet<TodoStatus> = new Set(["completed", "cancelled"]);
+
+export interface TodoItem {
+  content: string;
+  status: TodoStatus;
+  priority: TodoPriority;
+}
+
+export interface TodoWriteDetails {
+  todos: TodoItem[];
+  error?: string;
+  unchanged?: boolean;
+}
+
+export const TODO_STATE_ENTRY_TYPE = "pi-todo.state";
+export const TOOL_WRITE = "todo_write";
+export const TOOL_READ = "todo_read";
+export const WIDGET_KEY = "pi-todo";
+export const MAX_OVERLAY_LINES = 12;
+/** Max characters per todo content after sanitize (context/tool safety). */
+export const MAX_CONTENT_LENGTH = 500;
+/** Max todo lines echoed in todowrite/todoread text (full list still in details/JSON). */
+export const MAX_RESULT_LINES = 40;