@ngtools/webpack 8.0.0-rc.4 → 8.0.3

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ngtools/webpack",
-  "version": "8.0.0-rc.4",
+  "version": "8.0.3",
   "description": "Webpack plugin that AoT compiles your Angular components and modules.",
   "main": "./src/index.js",
   "typings": "src/index.d.ts",
@@ -25,7 +25,7 @@
   },
   "homepage": "https://github.com/angular/angular-cli",
   "dependencies": {
-    "@angular-devkit/core": "8.0.0-rc.4",
+    "@angular-devkit/core": "8.0.3",
     "enhanced-resolve": "4.1.0",
     "rxjs": "6.4.0",
     "tree-kill": "1.2.1",

package/src/angular_compiler_plugin.d.ts

@@ -41,6 +41,7 @@ export declare class AngularCompilerPlugin {
         className: string;
     } | null;
     readonly typeChecker: ts.TypeChecker | null;
+    /** @deprecated  From 8.0.2 */
     static isSupported(): boolean;
     private _setupOptions;
     private _getTsProgram;

package/src/angular_compiler_plugin.js

@@ -68,8 +68,9 @@ class AngularCompilerPlugin {
         const tsProgram = this._getTsProgram();
         return tsProgram ? tsProgram.getTypeChecker() : null;
     }
+    /** @deprecated  From 8.0.2 */
     static isSupported() {
-        return compiler_cli_1.VERSION && parseInt(compiler_cli_1.VERSION.major) >= 5;
+        return compiler_cli_1.VERSION && parseInt(compiler_cli_1.VERSION.major) >= 8;
     }
     _setupOptions(options) {
         benchmark_1.time('AngularCompilerPlugin._setupOptions');
@@ -487,17 +488,7 @@ class AngularCompilerPlugin {
             }
             let ngccProcessor;
             if (this._compilerOptions.enableIvy) {
-                let ngcc;
-                try {
-                    // this is done for the sole reason that @ngtools/webpack
-                    // support versions of Angular that don't have NGCC API
-                    ngcc = require('@angular/compiler-cli/ngcc');
-                }
-                catch (_a) {
-                }
-                if (ngcc) {
-                    ngccProcessor = new ngcc_processor_1.NgccProcessor(ngcc, this._mainFields, compilerWithFileSystems.inputFileSystem, this._warnings, this._errors, this._basePath);
-                }
+                ngccProcessor = new ngcc_processor_1.NgccProcessor(this._mainFields, compilerWithFileSystems.inputFileSystem, this._warnings, this._errors, this._basePath);
             }
             // Create the webpack compiler host.
             const webpackCompilerHost = new compiler_host_1.WebpackCompilerHost(this._compilerOptions, this._basePath, host, true, this._options.directTemplateLoading, ngccProcessor);
@@ -635,7 +626,6 @@ class AngularCompilerPlugin {
     }
     async _make(compilation) {
         benchmark_1.time('AngularCompilerPlugin._make');
-        this._emitSkipped = true;
         // tslint:disable-next-line:no-any
         if (compilation._ngToolsWebpackPluginInstance) {
             throw new Error('An @ngtools/webpack plugin already exist for this compilation.');
@@ -928,7 +918,7 @@ class AngularCompilerPlugin {
                 }
                 allDiagnostics.push(...gather_diagnostics_1.gatherDiagnostics(tsProgram, this._JitMode, 'AngularCompilerPlugin._emit.ts', diagMode));
                 if (!gather_diagnostics_1.hasErrors(allDiagnostics)) {
-                    if (this._firstRun || changedTsFiles.size > 20) {
+                    if (this._firstRun || changedTsFiles.size > 20 || this._emitSkipped) {
                         emitResult = tsProgram.emit(undefined, undefined, undefined, undefined, { before: this._transformers });
                         allDiagnostics.push(...emitResult.diagnostics);
                     }

package/src/compiler_host.js

@@ -106,13 +106,15 @@ class WebpackCompilerHost {
     readFile(fileName) {
         const filePath = this.resolve(fileName);
         try {
+            let content;
             if (this._memoryHost.isFile(filePath)) {
-                return core_1.virtualFs.fileBufferToString(this._memoryHost.read(filePath));
+                content = this._memoryHost.read(filePath);
             }
             else {
-                const content = this._syncHost.read(filePath);
-                return core_1.virtualFs.fileBufferToString(content);
+                content = this._syncHost.read(filePath);
             }
+            // strip BOM
+            return core_1.virtualFs.fileBufferToString(content).replace(/^\uFEFF/, '');
         }
         catch (_a) {
             return undefined;

package/src/interfaces.d.ts

@@ -7,6 +7,7 @@
  */
 /// <reference types="node" />
 import { logging, virtualFs } from '@angular-devkit/core';
+import { CompilerOptions } from '@angular/compiler-cli';
 import * as fs from 'fs';
 import * as ts from 'typescript';
 export declare enum PLATFORM {
@@ -48,7 +49,7 @@ export interface AngularCompilerPluginOptions {
     };
     additionalLazyModuleResources?: string[];
     contextElementDependencyConstructor?: ContextElementDependencyConstructor;
-    compilerOptions?: ts.CompilerOptions;
+    compilerOptions?: CompilerOptions;
     host?: virtualFs.Host<fs.Stats>;
     platformTransformers?: ts.TransformerFactory<ts.SourceFile>[];
 }

package/src/ngcc_processor.d.ts

@@ -8,7 +8,6 @@
 import * as ts from 'typescript';
 import { InputFileSystem } from 'webpack';
 export declare class NgccProcessor {
-    private readonly ngcc;
     private readonly propertiesToConsider;
     private readonly inputFileSystem;
     private readonly compilationWarnings;
@@ -17,7 +16,7 @@ export declare class NgccProcessor {
     private _processedModules;
     private _logger;
     private _nodeModulesDirectory;
-    constructor(ngcc: typeof import('@angular/compiler-cli/ngcc'), propertiesToConsider: string[], inputFileSystem: InputFileSystem, compilationWarnings: (Error | string)[], compilationErrors: (Error | string)[], basePath: string);
+    constructor(propertiesToConsider: string[], inputFileSystem: InputFileSystem, compilationWarnings: (Error | string)[], compilationErrors: (Error | string)[], basePath: string);
     processModule(moduleName: string, resolvedModule: ts.ResolvedModule | ts.ResolvedTypeReferenceDirective): void;
     /**
      * Try resolve a package.json file from the resolved .d.ts file.

package/src/ngcc_processor.js

@@ -7,6 +7,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 Object.defineProperty(exports, "__esModule", { value: true });
+const ngcc_1 = require("@angular/compiler-cli/ngcc");
 const fs_1 = require("fs");
 const path = require("path");
 const benchmark_1 = require("./benchmark");
@@ -18,8 +19,7 @@ const benchmark_1 = require("./benchmark");
 // but could not be resolved to an NgModule class
 // We now transform a package and it's typings when NGTSC is resolving a module.
 class NgccProcessor {
-    constructor(ngcc, propertiesToConsider, inputFileSystem, compilationWarnings, compilationErrors, basePath) {
-        this.ngcc = ngcc;
+    constructor(propertiesToConsider, inputFileSystem, compilationWarnings, compilationErrors, basePath) {
         this.propertiesToConsider = propertiesToConsider;
         this.inputFileSystem = inputFileSystem;
         this.compilationWarnings = compilationWarnings;
@@ -45,7 +45,7 @@ class NgccProcessor {
         }
         const timeLabel = `NgccProcessor.processModule.ngcc.process+${moduleName}`;
         benchmark_1.time(timeLabel);
-        this.ngcc.process({
+        ngcc_1.process({
             basePath: this._nodeModulesDirectory,
             targetEntryPointPath: path.dirname(packageJsonPath),
             propertiesToConsider: this.propertiesToConsider,

package/src/transformers/import_factory.js

@@ -62,7 +62,7 @@ loadChildren: () => import('IMPORT_STRING').then(M => M.EXPORT_NAME)
 
 Please note that only IMPORT_STRING, M, and EXPORT_NAME can be replaced in this format.
 
-Visit https://next.angular.io/guide/ivy for more information on using Ivy.
+Visit https://v8.angular.io/guide/ivy for more information on using Ivy.
 `;
             const emitWarning = () => warningCb(warning);
             const visitVariableStatement = (node) => {