@ngrx/eslint-plugin 18.0.1 → 18.1.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ngrx/eslint-plugin",
-  "version": "18.0.1",
+  "version": "18.1.0",
   "description": "NgRx ESLint Plugin",
   "repository": {
     "type": "git",
@@ -31,6 +31,7 @@
       "@ngrx/component-store",
       "@ngrx/component",
       "@ngrx/eslint-plugin",
+      "@ngrx/operators",
       "@ngrx/signals"
     ],
     "migrations": "./migrations/migration.json"
@@ -49,5 +50,6 @@
     "typescript": "*"
   },
   "main": "./src/index.js",
-  "type": "commonjs"
+  "type": "commonjs",
+  "types": "./src/index.d.ts"
 }

package/schematics/ng-add/index.js

@@ -3,6 +3,7 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.default = addNgRxESLintPlugin;
 const strip_json_comments_1 = __importDefault(require("strip-json-comments"));
 function addNgRxESLintPlugin(schema) {
     return (host, context) => {
@@ -59,5 +60,4 @@ ${detailsContent}
         };
     }
 }
-exports.default = addNgRxESLintPlugin;
 //# sourceMappingURL=index.js.map

package/schematics/ng-add/index.js.map

@@ -1 +1 @@
-{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../../modules/eslint-plugin/schematics/ng-add/index.ts"],"names":[],"mappings":";;;;;AACA,8EAAoD;AAGpD,SAAwB,mBAAmB,CAAC,MAAc;IACxD,OAAO,CAAC,IAAU,EAAE,OAAyB,EAAE,EAAE;QAC/C,MAAM,gBAAgB,GAAG,gBAAgB,CAAC;QAC1C,MAAM,IAAI,GAAG,qCAAqC,CAAC;QAEnD,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,gBAAgB,CAAC,EAAE,QAAQ,CAAC,OAAO,CAAC,CAAC;QAC9D,IAAI,CAAC,MAAM,EAAE,CAAC;YACZ,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC;wCACc,gBAAgB;;;aAG3C,IAAI;CAChB,CAAC,CAAC;YACG,OAAO,IAAI,CAAC;QACd,CAAC;QAED,IAAI,CAAC;YACH,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,IAAA,6BAAiB,EAAC,MAAM,CAAC,CAAC,CAAC;YACnD,IAAI,IAAI,CAAC,SAAS,EAAE,CAAC;gBACnB,IACE,CAAC,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,QAAa,EAAE,EAAE,CACrC,QAAQ,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC,MAAW,EAAE,EAAE,CACrC,MAAM,CAAC,UAAU,CAAC,cAAc,CAAC,CAClC,CACF,EACD,CAAC;oBACD,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,eAAe,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC;gBACtD,CAAC;YACH,CAAC;iBAAM,IACL,CAAC,IAAI,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC,MAAW,EAAE,EAAE,CAAC,MAAM,CAAC,UAAU,CAAC,cAAc,CAAC,CAAC,EACvE,CAAC;gBACD,IAAI,CAAC,SAAS,GAAG,CAAC,eAAe,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC;YACpD,CAAC;YAED,IAAI,CAAC,SAAS,CAAC,gBAAgB,EAAE,IAAI,CAAC,SAAS,CAAC,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC;YAEhE,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC;iEACuC,MAAM,CAAC,MAAM;;+BAE/C,IAAI;GAChC,CAAC,CAAC;YACC,OAAO,IAAI,CAAC;QACd,CAAC;QAAC,OAAO,GAAG,EAAE,CAAC;YACb,MAAM,cAAc,GAClB,GAAG,YAAY,KAAK;gBAClB,CAAC,CAAC;;EAEV,GAAG,CAAC,OAAO;CACZ;gBACS,CAAC,CAAC,EAAE,CAAC;YACT,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC;;;;aAIb,IAAI;EACf,cAAc;CACf,CAAC,CAAC;QACC,CAAC;IACH,CAAC,CAAC;IACF,SAAS,eAAe,CAAC,MAAwB;QAC/C,OAAO;YACL,KAAK,EAAE,CAAC,MAAM,CAAC;YACf,OAAO,EAAE,CAAC,gBAAgB,MAAM,EAAE,CAAC;SACpC,CAAC;IACJ,CAAC;AACH,CAAC;AAjED,sCAiEC","sourcesContent":["import type { Rule, SchematicContext, Tree } from '@angular-devkit/schematics';\nimport stripJsonComments from 'strip-json-comments';\nimport type { Schema } from './schema';\n\nexport default function addNgRxESLintPlugin(schema: Schema): Rule {\n  return (host: Tree, context: SchematicContext) => {\n    const eslintConfigPath = '.eslintrc.json';\n    const docs = 'https://ngrx.io/guide/eslint-plugin';\n\n    const eslint = host.read(eslintConfigPath)?.toString('utf-8');\n    if (!eslint) {\n      context.logger.warn(`\nCould not find the ESLint config at \\`${eslintConfigPath}\\`.\nThe NgRx ESLint Plugin is installed but not configured.\n\nPlease see ${docs} to configure the NgRx ESLint Plugin.\n`);\n      return host;\n    }\n\n    try {\n      const json = JSON.parse(stripJsonComments(eslint));\n      if (json.overrides) {\n        if (\n          !json.overrides.some((override: any) =>\n            override.extends?.some((extend: any) =>\n              extend.startsWith('plugin:@ngrx')\n            )\n          )\n        ) {\n          json.overrides.push(configurePlugin(schema.config));\n        }\n      } else if (\n        !json.extends?.some((extend: any) => extend.startsWith('plugin:@ngrx'))\n      ) {\n        json.overrides = [configurePlugin(schema.config)];\n      }\n\n      host.overwrite(eslintConfigPath, JSON.stringify(json, null, 2));\n\n      context.logger.info(`\n  The NgRx ESLint Plugin is installed and configured with the '${schema.config}' config.\n\n  Take a look at the docs at ${docs} if you want to change the default configuration.\n  `);\n      return host;\n    } catch (err) {\n      const detailsContent =\n        err instanceof Error\n          ? `\nDetails:\n${err.message}\n`\n          : '';\n      context.logger.warn(`\nSomething went wrong while adding the NgRx ESLint Plugin.\nThe NgRx ESLint Plugin is installed but not configured.\n\nPlease see ${docs} to configure the NgRx ESLint Plugin.\n${detailsContent}\n`);\n    }\n  };\n  function configurePlugin(config: Schema['config']): Record<string, unknown> {\n    return {\n      files: ['*.ts'],\n      extends: [`plugin:@ngrx/${config}`],\n    };\n  }\n}\n"]}
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../../modules/eslint-plugin/schematics/ng-add/index.ts"],"names":[],"mappings":";;;;;AAIA,sCAiEC;AApED,8EAAoD;AAGpD,SAAwB,mBAAmB,CAAC,MAAc;IACxD,OAAO,CAAC,IAAU,EAAE,OAAyB,EAAE,EAAE;QAC/C,MAAM,gBAAgB,GAAG,gBAAgB,CAAC;QAC1C,MAAM,IAAI,GAAG,qCAAqC,CAAC;QAEnD,MAAM,MAAM,GAAG,IAAI,CAAC,IAAI,CAAC,gBAAgB,CAAC,EAAE,QAAQ,CAAC,OAAO,CAAC,CAAC;QAC9D,IAAI,CAAC,MAAM,EAAE,CAAC;YACZ,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC;wCACc,gBAAgB;;;aAG3C,IAAI;CAChB,CAAC,CAAC;YACG,OAAO,IAAI,CAAC;QACd,CAAC;QAED,IAAI,CAAC;YACH,MAAM,IAAI,GAAG,IAAI,CAAC,KAAK,CAAC,IAAA,6BAAiB,EAAC,MAAM,CAAC,CAAC,CAAC;YACnD,IAAI,IAAI,CAAC,SAAS,EAAE,CAAC;gBACnB,IACE,CAAC,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,CAAC,QAAa,EAAE,EAAE,CACrC,QAAQ,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC,MAAW,EAAE,EAAE,CACrC,MAAM,CAAC,UAAU,CAAC,cAAc,CAAC,CAClC,CACF,EACD,CAAC;oBACD,IAAI,CAAC,SAAS,CAAC,IAAI,CAAC,eAAe,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC;gBACtD,CAAC;YACH,CAAC;iBAAM,IACL,CAAC,IAAI,CAAC,OAAO,EAAE,IAAI,CAAC,CAAC,MAAW,EAAE,EAAE,CAAC,MAAM,CAAC,UAAU,CAAC,cAAc,CAAC,CAAC,EACvE,CAAC;gBACD,IAAI,CAAC,SAAS,GAAG,CAAC,eAAe,CAAC,MAAM,CAAC,MAAM,CAAC,CAAC,CAAC;YACpD,CAAC;YAED,IAAI,CAAC,SAAS,CAAC,gBAAgB,EAAE,IAAI,CAAC,SAAS,CAAC,IAAI,EAAE,IAAI,EAAE,CAAC,CAAC,CAAC,CAAC;YAEhE,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC;iEACuC,MAAM,CAAC,MAAM;;+BAE/C,IAAI;GAChC,CAAC,CAAC;YACC,OAAO,IAAI,CAAC;QACd,CAAC;QAAC,OAAO,GAAG,EAAE,CAAC;YACb,MAAM,cAAc,GAClB,GAAG,YAAY,KAAK;gBAClB,CAAC,CAAC;;EAEV,GAAG,CAAC,OAAO;CACZ;gBACS,CAAC,CAAC,EAAE,CAAC;YACT,OAAO,CAAC,MAAM,CAAC,IAAI,CAAC;;;;aAIb,IAAI;EACf,cAAc;CACf,CAAC,CAAC;QACC,CAAC;IACH,CAAC,CAAC;IACF,SAAS,eAAe,CAAC,MAAwB;QAC/C,OAAO;YACL,KAAK,EAAE,CAAC,MAAM,CAAC;YACf,OAAO,EAAE,CAAC,gBAAgB,MAAM,EAAE,CAAC;SACpC,CAAC;IACJ,CAAC;AACH,CAAC","sourcesContent":["import type { Rule, SchematicContext, Tree } from '@angular-devkit/schematics';\nimport stripJsonComments from 'strip-json-comments';\nimport type { Schema } from './schema';\n\nexport default function addNgRxESLintPlugin(schema: Schema): Rule {\n  return (host: Tree, context: SchematicContext) => {\n    const eslintConfigPath = '.eslintrc.json';\n    const docs = 'https://ngrx.io/guide/eslint-plugin';\n\n    const eslint = host.read(eslintConfigPath)?.toString('utf-8');\n    if (!eslint) {\n      context.logger.warn(`\nCould not find the ESLint config at \\`${eslintConfigPath}\\`.\nThe NgRx ESLint Plugin is installed but not configured.\n\nPlease see ${docs} to configure the NgRx ESLint Plugin.\n`);\n      return host;\n    }\n\n    try {\n      const json = JSON.parse(stripJsonComments(eslint));\n      if (json.overrides) {\n        if (\n          !json.overrides.some((override: any) =>\n            override.extends?.some((extend: any) =>\n              extend.startsWith('plugin:@ngrx')\n            )\n          )\n        ) {\n          json.overrides.push(configurePlugin(schema.config));\n        }\n      } else if (\n        !json.extends?.some((extend: any) => extend.startsWith('plugin:@ngrx'))\n      ) {\n        json.overrides = [configurePlugin(schema.config)];\n      }\n\n      host.overwrite(eslintConfigPath, JSON.stringify(json, null, 2));\n\n      context.logger.info(`\n  The NgRx ESLint Plugin is installed and configured with the '${schema.config}' config.\n\n  Take a look at the docs at ${docs} if you want to change the default configuration.\n  `);\n      return host;\n    } catch (err) {\n      const detailsContent =\n        err instanceof Error\n          ? `\nDetails:\n${err.message}\n`\n          : '';\n      context.logger.warn(`\nSomething went wrong while adding the NgRx ESLint Plugin.\nThe NgRx ESLint Plugin is installed but not configured.\n\nPlease see ${docs} to configure the NgRx ESLint Plugin.\n${detailsContent}\n`);\n    }\n  };\n  function configurePlugin(config: Schema['config']): Record<string, unknown> {\n    return {\n      files: ['*.ts'],\n      extends: [`plugin:@ngrx/${config}`],\n    };\n  }\n}\n"]}

package/spec/utils/from-fixture.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.fromFixture = void 0;
+exports.fromFixture = fromFixture;
 function fromFixture(fixture, invalidTestCase = {}) {
     const { suggestions, ...rest } = invalidTestCase;
     return {
@@ -8,7 +8,6 @@ function fromFixture(fixture, invalidTestCase = {}) {
         ...parseFixture(fixture, suggestions),
     };
 }
-exports.fromFixture = fromFixture;
 function getSuggestions(suggestions, suggest, indices) {
     if (!suggestions || !suggest) {
         return {};

package/spec/utils/from-fixture.js.map

@@ -1 +1 @@
-{"version":3,"file":"from-fixture.js","sourceRoot":"","sources":["../../../../../modules/eslint-plugin/spec/utils/from-fixture.ts"],"names":[],"mappings":";;;AAuBA,SAAgB,WAAW,CAIzB,OAAe,EACf,kBAKI,EAAE;IAEN,MAAM,EAAE,WAAW,EAAE,GAAG,IAAI,EAAE,GAAG,eAAe,CAAC;IACjD,OAAO;QACL,GAAG,IAAI;QACP,GAAG,YAAY,CAAC,OAAO,EAAE,WAAW,CAAC;KACtC,CAAC;AACJ,CAAC;AAjBD,kCAiBC;AAED,SAAS,cAAc,CACrB,WAGa,EACb,OAAgB,EAChB,OAA2B;IAE3B,IAAI,CAAC,WAAW,IAAI,CAAC,OAAO,EAAE,CAAC;QAC7B,OAAO,EAAE,CAAC;IACZ,CAAC;IACD,IAAI,CAAC,OAAO,EAAE,CAAC;QACb,OAAO,EAAE,WAAW,EAAW,CAAC;IAClC,CAAC;IACD,OAAO;QACL,WAAW,EAAE,OAAO;aACjB,KAAK,CAAC,KAAK,CAAC;aACZ,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,WAAW,CAAC,MAAM,CAAC,QAAQ,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC,CAAC;KAClD,CAAC;AACb,CAAC;AAED,SAAS,YAAY,CACnB,OAAe,EACf,WAAoE;IAEpE,MAAM,WAAW,GACf,kHAAkH,CAAC;IACrH,MAAM,KAAK,GAAa,EAAE,CAAC;IAC3B,MAAM,MAAM,GAAwC,EAAE,CAAC;IACvD,IAAI,YAAY,GAAG,KAAK,CAAC;IACzB,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE;QACnC,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,WAAW,CAAC,CAAC;QACtC,IAAI,KAAK,EAAE,MAAM,EAAE,CAAC;YAClB,MAAM,MAAM,GAAG,KAAK,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,GAAG,CAAC,CAAC;YAC9C,MAAM,SAAS,GAAG,MAAM,GAAG,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC;YACrD,MAAM,EAAE,MAAM,EAAE,GAAG,KAAK,CAAC;YACzB,MAAM,CAAC,IAAI,CAAC;gBACV,MAAM;gBACN,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,MAAM,CAAC,IAAI,IAAI,IAAI,CAAC;gBAC3C,SAAS;gBACT,OAAO,EAAE,MAAM;gBACf,IAAI,EAAE,MAAM;gBACZ,SAAS,EAAE,KAAK,CAAC,MAAM,CAAC,EAAiB;gBACzC,kHAAkH;gBAClH,GAAI,cAAc,CAChB,WAAW,EACX,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,OAAO,CAAC,EAC7B,KAAK,CAAC,MAAM,CAAC,OAAO,EAAE,IAAI,EAAE,CACwB;aACvD,CAAC,CAAC;YACH,IAAI,KAAK,CAAC,MAAM,CAAC,OAAO,EAAE,CAAC;gBACzB,YAAY,GAAG,IAAI,CAAC;YACtB,CAAC;QACH,CAAC;aAAM,CAAC;YACN,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACnB,CAAC;IACH,CAAC,CAAC,CAAC;IACH,IAAI,WAAW,IAAI,CAAC,YAAY,EAAE,CAAC;QACjC,MAAM,IAAI,KAAK,CAAC,0DAA0D,CAAC,CAAC;IAC9E,CAAC;IACD,OAAO;QACL,IAAI,EAAE,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC;QACtB,MAAM;KACP,CAAC;AACJ,CAAC","sourcesContent":["import { TSESLint as eslint } from '@typescript-eslint/utils';\n\nexport function fromFixture<TMessageIds extends string>(\n  fixture: string,\n  invalidTestCase?: {\n    output?: string;\n    suggestions?: readonly eslint.SuggestionOutput<TMessageIds>[] | null;\n  }\n): eslint.InvalidTestCase<TMessageIds, never>;\n\nexport function fromFixture<\n  TMessageIds extends string,\n  TOptions extends readonly unknown[]\n>(\n  fixture: string,\n  invalidTestCase: Omit<\n    eslint.InvalidTestCase<TMessageIds, TOptions>,\n    'code' | 'errors'\n  > & {\n    suggestions?: readonly eslint.SuggestionOutput<TMessageIds>[] | null;\n  }\n): eslint.InvalidTestCase<TMessageIds, TOptions>;\n\nexport function fromFixture<\n  TMessageIds extends string,\n  TOptions extends readonly unknown[]\n>(\n  fixture: string,\n  invalidTestCase: Omit<\n    eslint.InvalidTestCase<TMessageIds, TOptions>,\n    'code' | 'errors'\n  > & {\n    suggestions?: readonly eslint.SuggestionOutput<TMessageIds>[] | null;\n  } = {}\n): eslint.InvalidTestCase<TMessageIds, TOptions> {\n  const { suggestions, ...rest } = invalidTestCase;\n  return {\n    ...rest,\n    ...parseFixture(fixture, suggestions),\n  };\n}\n\nfunction getSuggestions<TMessageIds extends string>(\n  suggestions:\n    | readonly eslint.SuggestionOutput<TMessageIds>[]\n    | null\n    | undefined,\n  suggest: boolean,\n  indices: string | undefined\n) {\n  if (!suggestions || !suggest) {\n    return {};\n  }\n  if (!indices) {\n    return { suggestions } as const;\n  }\n  return {\n    suggestions: indices\n      .split(/\\s+/)\n      .map((index) => suggestions[Number.parseInt(index, 10)]),\n  } as const;\n}\n\nfunction parseFixture<TMessageIds extends string>(\n  fixture: string,\n  suggestions?: readonly eslint.SuggestionOutput<TMessageIds>[] | null\n) {\n  const errorRegExp =\n    /^(?<indent>\\s*)(?<error>~+)\\s*\\[(?<id>\\w+)\\s*(?<data>.*?)(?:\\s*(?<suggest>suggest)\\s*(?<indices>[\\d\\s]*))?\\]\\s*$/;\n  const lines: string[] = [];\n  const errors: eslint.TestCaseError<TMessageIds>[] = [];\n  let suggestFound = false;\n  fixture.split('\\n').forEach((line) => {\n    const match = line.match(errorRegExp);\n    if (match?.groups) {\n      const column = match.groups.indent.length + 1;\n      const endColumn = column + match.groups.error.length;\n      const { length } = lines;\n      errors.push({\n        column,\n        data: JSON.parse(match.groups.data || '{}'),\n        endColumn,\n        endLine: length,\n        line: length,\n        messageId: match.groups.id as TMessageIds,\n        // TODO: Remove type assertion once https://github.com/typescript-eslint/typescript-eslint/pull/3844 is available.\n        ...(getSuggestions(\n          suggestions,\n          Boolean(match.groups.suggest),\n          match.groups.indices?.trim()\n        ) as eslint.TestCaseError<TMessageIds>['suggestions']),\n      });\n      if (match.groups.suggest) {\n        suggestFound = true;\n      }\n    } else {\n      lines.push(line);\n    }\n  });\n  if (suggestions && !suggestFound) {\n    throw new Error(\"Suggestions specified but no 'suggest' annotation found.\");\n  }\n  return {\n    code: lines.join('\\n'),\n    errors,\n  };\n}\n"]}
+{"version":3,"file":"from-fixture.js","sourceRoot":"","sources":["../../../../../modules/eslint-plugin/spec/utils/from-fixture.ts"],"names":[],"mappings":";;AAuBA,kCAiBC;AAjBD,SAAgB,WAAW,CAIzB,OAAe,EACf,kBAKI,EAAE;IAEN,MAAM,EAAE,WAAW,EAAE,GAAG,IAAI,EAAE,GAAG,eAAe,CAAC;IACjD,OAAO;QACL,GAAG,IAAI;QACP,GAAG,YAAY,CAAC,OAAO,EAAE,WAAW,CAAC;KACtC,CAAC;AACJ,CAAC;AAED,SAAS,cAAc,CACrB,WAGa,EACb,OAAgB,EAChB,OAA2B;IAE3B,IAAI,CAAC,WAAW,IAAI,CAAC,OAAO,EAAE,CAAC;QAC7B,OAAO,EAAE,CAAC;IACZ,CAAC;IACD,IAAI,CAAC,OAAO,EAAE,CAAC;QACb,OAAO,EAAE,WAAW,EAAW,CAAC;IAClC,CAAC;IACD,OAAO;QACL,WAAW,EAAE,OAAO;aACjB,KAAK,CAAC,KAAK,CAAC;aACZ,GAAG,CAAC,CAAC,KAAK,EAAE,EAAE,CAAC,WAAW,CAAC,MAAM,CAAC,QAAQ,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC,CAAC;KAClD,CAAC;AACb,CAAC;AAED,SAAS,YAAY,CACnB,OAAe,EACf,WAAoE;IAEpE,MAAM,WAAW,GACf,kHAAkH,CAAC;IACrH,MAAM,KAAK,GAAa,EAAE,CAAC;IAC3B,MAAM,MAAM,GAAwC,EAAE,CAAC;IACvD,IAAI,YAAY,GAAG,KAAK,CAAC;IACzB,OAAO,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,OAAO,CAAC,CAAC,IAAI,EAAE,EAAE;QACnC,MAAM,KAAK,GAAG,IAAI,CAAC,KAAK,CAAC,WAAW,CAAC,CAAC;QACtC,IAAI,KAAK,EAAE,MAAM,EAAE,CAAC;YAClB,MAAM,MAAM,GAAG,KAAK,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,GAAG,CAAC,CAAC;YAC9C,MAAM,SAAS,GAAG,MAAM,GAAG,KAAK,CAAC,MAAM,CAAC,KAAK,CAAC,MAAM,CAAC;YACrD,MAAM,EAAE,MAAM,EAAE,GAAG,KAAK,CAAC;YACzB,MAAM,CAAC,IAAI,CAAC;gBACV,MAAM;gBACN,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,KAAK,CAAC,MAAM,CAAC,IAAI,IAAI,IAAI,CAAC;gBAC3C,SAAS;gBACT,OAAO,EAAE,MAAM;gBACf,IAAI,EAAE,MAAM;gBACZ,SAAS,EAAE,KAAK,CAAC,MAAM,CAAC,EAAiB;gBACzC,kHAAkH;gBAClH,GAAI,cAAc,CAChB,WAAW,EACX,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,OAAO,CAAC,EAC7B,KAAK,CAAC,MAAM,CAAC,OAAO,EAAE,IAAI,EAAE,CACwB;aACvD,CAAC,CAAC;YACH,IAAI,KAAK,CAAC,MAAM,CAAC,OAAO,EAAE,CAAC;gBACzB,YAAY,GAAG,IAAI,CAAC;YACtB,CAAC;QACH,CAAC;aAAM,CAAC;YACN,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;QACnB,CAAC;IACH,CAAC,CAAC,CAAC;IACH,IAAI,WAAW,IAAI,CAAC,YAAY,EAAE,CAAC;QACjC,MAAM,IAAI,KAAK,CAAC,0DAA0D,CAAC,CAAC;IAC9E,CAAC;IACD,OAAO;QACL,IAAI,EAAE,KAAK,CAAC,IAAI,CAAC,IAAI,CAAC;QACtB,MAAM;KACP,CAAC;AACJ,CAAC","sourcesContent":["import { TSESLint as eslint } from '@typescript-eslint/utils';\n\nexport function fromFixture<TMessageIds extends string>(\n  fixture: string,\n  invalidTestCase?: {\n    output?: string;\n    suggestions?: readonly eslint.SuggestionOutput<TMessageIds>[] | null;\n  }\n): eslint.InvalidTestCase<TMessageIds, never>;\n\nexport function fromFixture<\n  TMessageIds extends string,\n  TOptions extends readonly unknown[]\n>(\n  fixture: string,\n  invalidTestCase: Omit<\n    eslint.InvalidTestCase<TMessageIds, TOptions>,\n    'code' | 'errors'\n  > & {\n    suggestions?: readonly eslint.SuggestionOutput<TMessageIds>[] | null;\n  }\n): eslint.InvalidTestCase<TMessageIds, TOptions>;\n\nexport function fromFixture<\n  TMessageIds extends string,\n  TOptions extends readonly unknown[]\n>(\n  fixture: string,\n  invalidTestCase: Omit<\n    eslint.InvalidTestCase<TMessageIds, TOptions>,\n    'code' | 'errors'\n  > & {\n    suggestions?: readonly eslint.SuggestionOutput<TMessageIds>[] | null;\n  } = {}\n): eslint.InvalidTestCase<TMessageIds, TOptions> {\n  const { suggestions, ...rest } = invalidTestCase;\n  return {\n    ...rest,\n    ...parseFixture(fixture, suggestions),\n  };\n}\n\nfunction getSuggestions<TMessageIds extends string>(\n  suggestions:\n    | readonly eslint.SuggestionOutput<TMessageIds>[]\n    | null\n    | undefined,\n  suggest: boolean,\n  indices: string | undefined\n) {\n  if (!suggestions || !suggest) {\n    return {};\n  }\n  if (!indices) {\n    return { suggestions } as const;\n  }\n  return {\n    suggestions: indices\n      .split(/\\s+/)\n      .map((index) => suggestions[Number.parseInt(index, 10)]),\n  } as const;\n}\n\nfunction parseFixture<TMessageIds extends string>(\n  fixture: string,\n  suggestions?: readonly eslint.SuggestionOutput<TMessageIds>[] | null\n) {\n  const errorRegExp =\n    /^(?<indent>\\s*)(?<error>~+)\\s*\\[(?<id>\\w+)\\s*(?<data>.*?)(?:\\s*(?<suggest>suggest)\\s*(?<indices>[\\d\\s]*))?\\]\\s*$/;\n  const lines: string[] = [];\n  const errors: eslint.TestCaseError<TMessageIds>[] = [];\n  let suggestFound = false;\n  fixture.split('\\n').forEach((line) => {\n    const match = line.match(errorRegExp);\n    if (match?.groups) {\n      const column = match.groups.indent.length + 1;\n      const endColumn = column + match.groups.error.length;\n      const { length } = lines;\n      errors.push({\n        column,\n        data: JSON.parse(match.groups.data || '{}'),\n        endColumn,\n        endLine: length,\n        line: length,\n        messageId: match.groups.id as TMessageIds,\n        // TODO: Remove type assertion once https://github.com/typescript-eslint/typescript-eslint/pull/3844 is available.\n        ...(getSuggestions(\n          suggestions,\n          Boolean(match.groups.suggest),\n          match.groups.indices?.trim()\n        ) as eslint.TestCaseError<TMessageIds>['suggestions']),\n      });\n      if (match.groups.suggest) {\n        suggestFound = true;\n      }\n    } else {\n      lines.push(line);\n    }\n  });\n  if (suggestions && !suggestFound) {\n    throw new Error(\"Suggestions specified but no 'suggest' annotation found.\");\n  }\n  return {\n    code: lines.join('\\n'),\n    errors,\n  };\n}\n"]}

package/spec/utils/rule-tester.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.ruleTester = void 0;
+exports.ruleTester = ruleTester;
 const utils_1 = require("../../src/utils");
 const test_utils_1 = require("@angular-eslint/test-utils");
 const path_1 = require("path");
@@ -19,5 +19,4 @@ function ruleTester(environment) {
         },
     });
 }
-exports.ruleTester = ruleTester;
 //# sourceMappingURL=rule-tester.js.map

package/spec/utils/rule-tester.js.map

@@ -1 +1 @@
-{"version":3,"file":"rule-tester.js","sourceRoot":"","sources":["../../../../../modules/eslint-plugin/spec/utils/rule-tester.ts"],"names":[],"mappings":";;;AAAA,2CAA6D;AAC7D,2DAAwD;AACxD,+BAA+B;AAE/B,SAAgB,UAAU,CAAC,WAG1B;IACC,IAAA,kBAAU,GAAE,CAAC;IAEb,IAAI,WAAW,EAAE,CAAC;QAChB,IAAA,sBAAc,EAAC,WAAW,CAAC,UAAU,EAAE,WAAW,CAAC,OAAO,CAAC,CAAC;IAC9D,CAAC;IAED,OAAO,IAAI,uBAAU,CAAC;QACpB,MAAM,EAAE,2BAA2B;QACnC,aAAa,EAAE;YACb,WAAW,EAAE,IAAI;YACjB,UAAU,EAAE,QAAQ;YACpB,eAAe,EAAE,IAAA,cAAO,EAAC,uCAAuC,CAAC;YACjE,OAAO,EAAE,iBAAiB;SAC3B;KACF,CAAC,CAAC;AACL,CAAC;AAnBD,gCAmBC","sourcesContent":["import { clearCache, setNgrxVersion } from '../../src/utils';\nimport { RuleTester } from '@angular-eslint/test-utils';\nimport { resolve } from 'path';\n\nexport function ruleTester(environment?: {\n  ngrxModule: string;\n  version: string;\n}) {\n  clearCache();\n\n  if (environment) {\n    setNgrxVersion(environment.ngrxModule, environment.version);\n  }\n\n  return new RuleTester({\n    parser: '@typescript-eslint/parser',\n    parserOptions: {\n      ecmaVersion: 2020,\n      sourceType: 'module',\n      tsconfigRootDir: resolve('./modules/eslint-plugin/spec/fixtures'),\n      project: './tsconfig.json',\n    },\n  });\n}\n"]}
+{"version":3,"file":"rule-tester.js","sourceRoot":"","sources":["../../../../../modules/eslint-plugin/spec/utils/rule-tester.ts"],"names":[],"mappings":";;AAIA,gCAmBC;AAvBD,2CAA6D;AAC7D,2DAAwD;AACxD,+BAA+B;AAE/B,SAAgB,UAAU,CAAC,WAG1B;IACC,IAAA,kBAAU,GAAE,CAAC;IAEb,IAAI,WAAW,EAAE,CAAC;QAChB,IAAA,sBAAc,EAAC,WAAW,CAAC,UAAU,EAAE,WAAW,CAAC,OAAO,CAAC,CAAC;IAC9D,CAAC;IAED,OAAO,IAAI,uBAAU,CAAC;QACpB,MAAM,EAAE,2BAA2B;QACnC,aAAa,EAAE;YACb,WAAW,EAAE,IAAI;YACjB,UAAU,EAAE,QAAQ;YACpB,eAAe,EAAE,IAAA,cAAO,EAAC,uCAAuC,CAAC;YACjE,OAAO,EAAE,iBAAiB;SAC3B;KACF,CAAC,CAAC;AACL,CAAC","sourcesContent":["import { clearCache, setNgrxVersion } from '../../src/utils';\nimport { RuleTester } from '@angular-eslint/test-utils';\nimport { resolve } from 'path';\n\nexport function ruleTester(environment?: {\n  ngrxModule: string;\n  version: string;\n}) {\n  clearCache();\n\n  if (environment) {\n    setNgrxVersion(environment.ngrxModule, environment.version);\n  }\n\n  return new RuleTester({\n    parser: '@typescript-eslint/parser',\n    parserOptions: {\n      ecmaVersion: 2020,\n      sourceType: 'module',\n      tsconfigRootDir: resolve('./modules/eslint-plugin/spec/fixtures'),\n      project: './tsconfig.json',\n    },\n  });\n}\n"]}

package/src/configs/all.js

@@ -38,6 +38,8 @@ exports.default = (plugin, parser) => [
             '@ngrx/use-effects-lifecycle-interface': 'error',
             '@ngrx/prefer-concat-latest-from': 'error',
             '@ngrx/signal-state-no-arrays-at-root-level': 'error',
+            '@ngrx/signal-store-feature-should-use-generic-type': 'error',
+            '@ngrx/prefer-protected-state': 'error',
             '@ngrx/with-state-no-arrays-at-root-level': 'error',
             '@ngrx/avoid-combining-selectors': 'error',
             '@ngrx/avoid-dispatching-multiple-actions-sequentially': 'error',

package/src/configs/all.js.map

@@ -1 +1 @@
-{"version":3,"file":"all.js","sourceRoot":"","sources":["../../../../../modules/eslint-plugin/src/configs/all.ts"],"names":[],"mappings":";AAAA;;;GAGG;;AAIH,kBAAe,CACb,MAAkC,EAClC,MAAkC,EACD,EAAE,CAAC;IACpC;QACE,IAAI,EAAE,WAAW;QACjB,eAAe,EAAE;YACf,MAAM;YACN,UAAU,EAAE,QAAQ;SACrB;QACD,OAAO,EAAE;YACP,OAAO,EAAE,MAAM;SAChB;KACF;IACD;QACE,IAAI,EAAE,UAAU;QAChB,eAAe,EAAE;YACf,MAAM;YACN,aAAa,EAAE;gBACb,WAAW,EAAE,IAAI;gBACjB,UAAU,EAAE,QAAQ;gBACpB,OAAO,EAAE,iBAAiB;aAC3B;SACF;QACD,KAAK,EAAE;YACL,iDAAiD,EAAE,OAAO;YAC1D,+CAA+C,EAAE,OAAO;YACxD,oCAAoC,EAAE,OAAO;YAC7C,4BAA4B,EAAE,OAAO;YACrC,8BAA8B,EAAE,OAAO;YACvC,+BAA+B,EAAE,OAAO;YACxC,sCAAsC,EAAE,OAAO;YAC/C,wCAAwC,EAAE,OAAO;YACjD,iDAAiD,EAAE,OAAO;YAC1D,uCAAuC,EAAE,OAAO;YAChD,iCAAiC,EAAE,OAAO;YAC1C,4CAA4C,EAAE,OAAO;YACrD,0CAA0C,EAAE,OAAO;YACnD,iCAAiC,EAAE,OAAO;YAC1C,uDAAuD,EAAE,OAAO;YAChE,0CAA0C,EAAE,OAAO;YACnD,+BAA+B,EAAE,OAAO;YACxC,2BAA2B,EAAE,OAAO;YACpC,iCAAiC,EAAE,OAAO;YAC1C,+BAA+B,EAAE,OAAO;YACxC,6BAA6B,EAAE,OAAO;YACtC,6BAA6B,EAAE,OAAO;YACtC,wCAAwC,EAAE,OAAO;YACjD,yCAAyC,EAAE,OAAO;YAClD,6BAA6B,EAAE,OAAO;YACtC,kCAAkC,EAAE,OAAO;YAC3C,yDAAyD,EAAE,OAAO;YAClE,iCAAiC,EAAE,OAAO;YAC1C,oCAAoC,EAAE,OAAO;YAC7C,oBAAoB,EAAE,OAAO;YAC7B,wCAAwC,EAAE,OAAO;SAClD;KACF;CACF,CAAC","sourcesContent":["/**\n * DO NOT EDIT\n * This file is generated\n */\n\nimport type { TSESLint } from '@typescript-eslint/utils';\n\nexport default (\n  plugin: TSESLint.FlatConfig.Plugin,\n  parser: TSESLint.FlatConfig.Parser\n): TSESLint.FlatConfig.ConfigArray => [\n  {\n    name: 'ngrx/base',\n    languageOptions: {\n      parser,\n      sourceType: 'module',\n    },\n    plugins: {\n      '@ngrx': plugin,\n    },\n  },\n  {\n    name: 'ngrx/all',\n    languageOptions: {\n      parser,\n      parserOptions: {\n        ecmaVersion: 2020,\n        sourceType: 'module',\n        project: './tsconfig.json',\n      },\n    },\n    rules: {\n      '@ngrx/avoid-combining-component-store-selectors': 'error',\n      '@ngrx/avoid-mapping-component-store-selectors': 'error',\n      '@ngrx/updater-explicit-return-type': 'error',\n      '@ngrx/avoid-cyclic-effects': 'error',\n      '@ngrx/no-dispatch-in-effects': 'error',\n      '@ngrx/no-effects-in-providers': 'error',\n      '@ngrx/no-multiple-actions-in-effects': 'error',\n      '@ngrx/prefer-action-creator-in-of-type': 'error',\n      '@ngrx/prefer-effect-callback-in-block-statement': 'error',\n      '@ngrx/use-effects-lifecycle-interface': 'error',\n      '@ngrx/prefer-concat-latest-from': 'error',\n      '@ngrx/signal-state-no-arrays-at-root-level': 'error',\n      '@ngrx/with-state-no-arrays-at-root-level': 'error',\n      '@ngrx/avoid-combining-selectors': 'error',\n      '@ngrx/avoid-dispatching-multiple-actions-sequentially': 'error',\n      '@ngrx/avoid-duplicate-actions-in-reducer': 'error',\n      '@ngrx/avoid-mapping-selectors': 'error',\n      '@ngrx/good-action-hygiene': 'error',\n      '@ngrx/no-multiple-global-stores': 'error',\n      '@ngrx/no-reducer-in-key-names': 'error',\n      '@ngrx/no-store-subscription': 'error',\n      '@ngrx/no-typed-global-store': 'error',\n      '@ngrx/on-function-explicit-return-type': 'error',\n      '@ngrx/prefer-action-creator-in-dispatch': 'error',\n      '@ngrx/prefer-action-creator': 'error',\n      '@ngrx/prefer-inline-action-props': 'error',\n      '@ngrx/prefer-one-generic-in-create-for-feature-selector': 'error',\n      '@ngrx/prefer-selector-in-select': 'error',\n      '@ngrx/prefix-selectors-with-select': 'error',\n      '@ngrx/select-style': 'error',\n      '@ngrx/use-consistent-global-store-name': 'error',\n    },\n  },\n];\n"]}
+{"version":3,"file":"all.js","sourceRoot":"","sources":["../../../../../modules/eslint-plugin/src/configs/all.ts"],"names":[],"mappings":";AAAA;;;GAGG;;AAIH,kBAAe,CACb,MAAkC,EAClC,MAAkC,EACD,EAAE,CAAC;IACpC;QACE,IAAI,EAAE,WAAW;QACjB,eAAe,EAAE;YACf,MAAM;YACN,UAAU,EAAE,QAAQ;SACrB;QACD,OAAO,EAAE;YACP,OAAO,EAAE,MAAM;SAChB;KACF;IACD;QACE,IAAI,EAAE,UAAU;QAChB,eAAe,EAAE;YACf,MAAM;YACN,aAAa,EAAE;gBACb,WAAW,EAAE,IAAI;gBACjB,UAAU,EAAE,QAAQ;gBACpB,OAAO,EAAE,iBAAiB;aAC3B;SACF;QACD,KAAK,EAAE;YACL,iDAAiD,EAAE,OAAO;YAC1D,+CAA+C,EAAE,OAAO;YACxD,oCAAoC,EAAE,OAAO;YAC7C,4BAA4B,EAAE,OAAO;YACrC,8BAA8B,EAAE,OAAO;YACvC,+BAA+B,EAAE,OAAO;YACxC,sCAAsC,EAAE,OAAO;YAC/C,wCAAwC,EAAE,OAAO;YACjD,iDAAiD,EAAE,OAAO;YAC1D,uCAAuC,EAAE,OAAO;YAChD,iCAAiC,EAAE,OAAO;YAC1C,4CAA4C,EAAE,OAAO;YACrD,oDAAoD,EAAE,OAAO;YAC7D,8BAA8B,EAAE,OAAO;YACvC,0CAA0C,EAAE,OAAO;YACnD,iCAAiC,EAAE,OAAO;YAC1C,uDAAuD,EAAE,OAAO;YAChE,0CAA0C,EAAE,OAAO;YACnD,+BAA+B,EAAE,OAAO;YACxC,2BAA2B,EAAE,OAAO;YACpC,iCAAiC,EAAE,OAAO;YAC1C,+BAA+B,EAAE,OAAO;YACxC,6BAA6B,EAAE,OAAO;YACtC,6BAA6B,EAAE,OAAO;YACtC,wCAAwC,EAAE,OAAO;YACjD,yCAAyC,EAAE,OAAO;YAClD,6BAA6B,EAAE,OAAO;YACtC,kCAAkC,EAAE,OAAO;YAC3C,yDAAyD,EAAE,OAAO;YAClE,iCAAiC,EAAE,OAAO;YAC1C,oCAAoC,EAAE,OAAO;YAC7C,oBAAoB,EAAE,OAAO;YAC7B,wCAAwC,EAAE,OAAO;SAClD;KACF;CACF,CAAC","sourcesContent":["/**\n * DO NOT EDIT\n * This file is generated\n */\n\nimport type { TSESLint } from '@typescript-eslint/utils';\n\nexport default (\n  plugin: TSESLint.FlatConfig.Plugin,\n  parser: TSESLint.FlatConfig.Parser\n): TSESLint.FlatConfig.ConfigArray => [\n  {\n    name: 'ngrx/base',\n    languageOptions: {\n      parser,\n      sourceType: 'module',\n    },\n    plugins: {\n      '@ngrx': plugin,\n    },\n  },\n  {\n    name: 'ngrx/all',\n    languageOptions: {\n      parser,\n      parserOptions: {\n        ecmaVersion: 2020,\n        sourceType: 'module',\n        project: './tsconfig.json',\n      },\n    },\n    rules: {\n      '@ngrx/avoid-combining-component-store-selectors': 'error',\n      '@ngrx/avoid-mapping-component-store-selectors': 'error',\n      '@ngrx/updater-explicit-return-type': 'error',\n      '@ngrx/avoid-cyclic-effects': 'error',\n      '@ngrx/no-dispatch-in-effects': 'error',\n      '@ngrx/no-effects-in-providers': 'error',\n      '@ngrx/no-multiple-actions-in-effects': 'error',\n      '@ngrx/prefer-action-creator-in-of-type': 'error',\n      '@ngrx/prefer-effect-callback-in-block-statement': 'error',\n      '@ngrx/use-effects-lifecycle-interface': 'error',\n      '@ngrx/prefer-concat-latest-from': 'error',\n      '@ngrx/signal-state-no-arrays-at-root-level': 'error',\n      '@ngrx/signal-store-feature-should-use-generic-type': 'error',\n      '@ngrx/prefer-protected-state': 'error',\n      '@ngrx/with-state-no-arrays-at-root-level': 'error',\n      '@ngrx/avoid-combining-selectors': 'error',\n      '@ngrx/avoid-dispatching-multiple-actions-sequentially': 'error',\n      '@ngrx/avoid-duplicate-actions-in-reducer': 'error',\n      '@ngrx/avoid-mapping-selectors': 'error',\n      '@ngrx/good-action-hygiene': 'error',\n      '@ngrx/no-multiple-global-stores': 'error',\n      '@ngrx/no-reducer-in-key-names': 'error',\n      '@ngrx/no-store-subscription': 'error',\n      '@ngrx/no-typed-global-store': 'error',\n      '@ngrx/on-function-explicit-return-type': 'error',\n      '@ngrx/prefer-action-creator-in-dispatch': 'error',\n      '@ngrx/prefer-action-creator': 'error',\n      '@ngrx/prefer-inline-action-props': 'error',\n      '@ngrx/prefer-one-generic-in-create-for-feature-selector': 'error',\n      '@ngrx/prefer-selector-in-select': 'error',\n      '@ngrx/prefix-selectors-with-select': 'error',\n      '@ngrx/select-style': 'error',\n      '@ngrx/use-consistent-global-store-name': 'error',\n    },\n  },\n];\n"]}

package/src/configs/all.json

@@ -14,6 +14,8 @@
     "@ngrx/use-effects-lifecycle-interface": "error",
     "@ngrx/prefer-concat-latest-from": "error",
     "@ngrx/signal-state-no-arrays-at-root-level": "error",
+    "@ngrx/signal-store-feature-should-use-generic-type": "error",
+    "@ngrx/prefer-protected-state": "error",
     "@ngrx/with-state-no-arrays-at-root-level": "error",
     "@ngrx/avoid-combining-selectors": "error",
     "@ngrx/avoid-dispatching-multiple-actions-sequentially": "error",

package/src/configs/signals.js

@@ -27,6 +27,8 @@ exports.default = (plugin, parser) => [
         },
         rules: {
             '@ngrx/signal-state-no-arrays-at-root-level': 'error',
+            '@ngrx/signal-store-feature-should-use-generic-type': 'error',
+            '@ngrx/prefer-protected-state': 'error',
             '@ngrx/with-state-no-arrays-at-root-level': 'error',
         },
     },

package/src/configs/signals.js.map

@@ -1 +1 @@
-{"version":3,"file":"signals.js","sourceRoot":"","sources":["../../../../../modules/eslint-plugin/src/configs/signals.ts"],"names":[],"mappings":";AAAA;;;GAGG;;AAIH,kBAAe,CACb,MAAkC,EAClC,MAAkC,EACD,EAAE,CAAC;IACpC;QACE,IAAI,EAAE,WAAW;QACjB,eAAe,EAAE;YACf,MAAM;YACN,UAAU,EAAE,QAAQ;SACrB;QACD,OAAO,EAAE;YACP,OAAO,EAAE,MAAM;SAChB;KACF;IACD;QACE,IAAI,EAAE,cAAc;QACpB,eAAe,EAAE;YACf,MAAM;YACN,aAAa,EAAE;gBACb,WAAW,EAAE,IAAI;gBACjB,UAAU,EAAE,QAAQ;gBACpB,OAAO,EAAE,iBAAiB;aAC3B;SACF;QACD,KAAK,EAAE;YACL,4CAA4C,EAAE,OAAO;YACrD,0CAA0C,EAAE,OAAO;SACpD;KACF;CACF,CAAC","sourcesContent":["/**\n * DO NOT EDIT\n * This file is generated\n */\n\nimport type { TSESLint } from '@typescript-eslint/utils';\n\nexport default (\n  plugin: TSESLint.FlatConfig.Plugin,\n  parser: TSESLint.FlatConfig.Parser\n): TSESLint.FlatConfig.ConfigArray => [\n  {\n    name: 'ngrx/base',\n    languageOptions: {\n      parser,\n      sourceType: 'module',\n    },\n    plugins: {\n      '@ngrx': plugin,\n    },\n  },\n  {\n    name: 'ngrx/signals',\n    languageOptions: {\n      parser,\n      parserOptions: {\n        ecmaVersion: 2020,\n        sourceType: 'module',\n        project: './tsconfig.json',\n      },\n    },\n    rules: {\n      '@ngrx/signal-state-no-arrays-at-root-level': 'error',\n      '@ngrx/with-state-no-arrays-at-root-level': 'error',\n    },\n  },\n];\n"]}
+{"version":3,"file":"signals.js","sourceRoot":"","sources":["../../../../../modules/eslint-plugin/src/configs/signals.ts"],"names":[],"mappings":";AAAA;;;GAGG;;AAIH,kBAAe,CACb,MAAkC,EAClC,MAAkC,EACD,EAAE,CAAC;IACpC;QACE,IAAI,EAAE,WAAW;QACjB,eAAe,EAAE;YACf,MAAM;YACN,UAAU,EAAE,QAAQ;SACrB;QACD,OAAO,EAAE;YACP,OAAO,EAAE,MAAM;SAChB;KACF;IACD;QACE,IAAI,EAAE,cAAc;QACpB,eAAe,EAAE;YACf,MAAM;YACN,aAAa,EAAE;gBACb,WAAW,EAAE,IAAI;gBACjB,UAAU,EAAE,QAAQ;gBACpB,OAAO,EAAE,iBAAiB;aAC3B;SACF;QACD,KAAK,EAAE;YACL,4CAA4C,EAAE,OAAO;YACrD,oDAAoD,EAAE,OAAO;YAC7D,8BAA8B,EAAE,OAAO;YACvC,0CAA0C,EAAE,OAAO;SACpD;KACF;CACF,CAAC","sourcesContent":["/**\n * DO NOT EDIT\n * This file is generated\n */\n\nimport type { TSESLint } from '@typescript-eslint/utils';\n\nexport default (\n  plugin: TSESLint.FlatConfig.Plugin,\n  parser: TSESLint.FlatConfig.Parser\n): TSESLint.FlatConfig.ConfigArray => [\n  {\n    name: 'ngrx/base',\n    languageOptions: {\n      parser,\n      sourceType: 'module',\n    },\n    plugins: {\n      '@ngrx': plugin,\n    },\n  },\n  {\n    name: 'ngrx/signals',\n    languageOptions: {\n      parser,\n      parserOptions: {\n        ecmaVersion: 2020,\n        sourceType: 'module',\n        project: './tsconfig.json',\n      },\n    },\n    rules: {\n      '@ngrx/signal-state-no-arrays-at-root-level': 'error',\n      '@ngrx/signal-store-feature-should-use-generic-type': 'error',\n      '@ngrx/prefer-protected-state': 'error',\n      '@ngrx/with-state-no-arrays-at-root-level': 'error',\n    },\n  },\n];\n"]}

package/src/configs/signals.json

@@ -3,6 +3,8 @@
   "plugins": ["@ngrx"],
   "rules": {
     "@ngrx/signal-state-no-arrays-at-root-level": "error",
+    "@ngrx/signal-store-feature-should-use-generic-type": "error",
+    "@ngrx/prefer-protected-state": "error",
     "@ngrx/with-state-no-arrays-at-root-level": "error"
   },
   "parserOptions": {

package/src/index.d.ts

@@ -16,6 +16,8 @@ declare const _default: {
                 "@ngrx/use-effects-lifecycle-interface": string;
                 "@ngrx/prefer-concat-latest-from": string;
                 "@ngrx/signal-state-no-arrays-at-root-level": string;
+                "@ngrx/signal-store-feature-should-use-generic-type": string;
+                "@ngrx/prefer-protected-state": string;
                 "@ngrx/with-state-no-arrays-at-root-level": string;
                 "@ngrx/avoid-combining-selectors": string;
                 "@ngrx/avoid-dispatching-multiple-actions-sequentially": string;
@@ -105,6 +107,8 @@ declare const _default: {
             plugins: string[];
             rules: {
                 "@ngrx/signal-state-no-arrays-at-root-level": string;
+                "@ngrx/signal-store-feature-should-use-generic-type": string;
+                "@ngrx/prefer-protected-state": string;
                 "@ngrx/with-state-no-arrays-at-root-level": string;
             };
             parserOptions: {
@@ -147,6 +151,8 @@ declare const _default: {
             readonly strict: boolean;
         }], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         'signal-state-no-arrays-at-root-level': import("@typescript-eslint/utils/ts-eslint").RuleModule<"signalStateNoArraysAtRootLevel", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+        'signal-store-feature-should-use-generic-type': import("@typescript-eslint/utils/ts-eslint").RuleModule<"signalStoreFeatureShouldUseGenericType", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+        'prefer-protected-state': import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferProtectedState" | "preferProtectedStateSuggest", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
         'with-state-no-arrays-at-root-level': import("@typescript-eslint/utils/ts-eslint").RuleModule<"withStateNoArraysAtRootLevel", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
     };
 };

package/src/rule-creator.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.createRule = void 0;
+exports.createRule = createRule;
 const utils_1 = require("@typescript-eslint/utils");
 const utils_2 = require("./utils");
 function createRule(config) {
@@ -20,5 +20,4 @@ function createRule(config) {
     }
     return utils_1.ESLintUtils.RuleCreator(utils_2.docsUrl)(configOverwrite);
 }
-exports.createRule = createRule;
 //# sourceMappingURL=rule-creator.js.map

package/src/rule-creator.js.map

@@ -1 +1 @@
-{"version":3,"file":"rule-creator.js","sourceRoot":"","sources":["../../../../modules/eslint-plugin/src/rule-creator.ts"],"names":[],"mappings":";;;AACA,oDAAuD;AAEvD,mCAA2E;AAwB3E,SAAgB,UAAU,CAIxB,MAQE;IAEF,MAAM,eAAe,GAAG;QACtB,GAAG,MAAM;QACT,MAAM,EAAE,CACN,OAA8D,EAC9D,kBAAsC,EACtC,EAAE;YACF,MAAM,EACJ,IAAI,EAAE,EAAE,UAAU,EAAE,OAAO,EAAE,GAC9B,GAAG,MAAM,CAAC;YACX,IACE,OAAO,KAAK,SAAS;gBACrB,CAAC,IAAA,4BAAoB,EAAC,yBAAiB,CAAC,UAAU,CAAC,EAAE,OAAO,CAAC,EAC7D,CAAC;gBACD,OAAO,EAAE,CAAC;YACZ,CAAC;YAED,OAAO,MAAM,CAAC,MAAM,CAAC,OAAO,EAAE,kBAAkB,CAAC,CAAC;QACpD,CAAC;KACF,CAAC;IAEF,KAAK,MAAM,CAAC,GAAG,EAAE,OAAO,CAAC,IAAI,MAAM,CAAC,OAAO,CAAC,eAAe,CAAC,IAAI,CAAC,QAAQ,CAAC,EAAE,CAAC;QAC1E,eAAe,CAAC,IAAI,CAAC,QAAgB,CAAC,GAAG,CAAC,GAAG,GAAG,OAAO,KAAK,IAAA,eAAO,EAClE,MAAM,CAAC,IAAI,CACZ,GAAG,CAAC;IACP,CAAC;IAED,OAAO,mBAAW,CAAC,WAAW,CAAC,eAAO,CAAC,CAAC,eAAe,CAAC,CAAC;AAC3D,CAAC;AAzCD,gCAyCC","sourcesContent":["import type { TSESLint } from '@typescript-eslint/utils';\nimport { ESLintUtils } from '@typescript-eslint/utils';\nimport type { NGRX_MODULE } from './utils';\nimport { docsUrl, ngrxVersionSatisfies, NGRX_MODULE_PATHS } from './utils';\n\ntype Meta<TMessageIds extends string, TOptions extends readonly unknown[]> =\n  | TSESLint.RuleMetaData<TMessageIds, TOptions> & {\n      ngrxModule: NGRX_MODULE;\n      version?: string;\n      docs: { requiresTypeChecking?: boolean };\n    };\n\ntype CreateRuleMeta<\n  TMessageIds extends string,\n  TOptions extends readonly unknown[]\n> = {\n  docs: Omit<TSESLint.RuleMetaDataDocs, 'url'> & {\n    requiresTypeChecking?: boolean;\n  };\n} & Omit<Meta<TMessageIds, TOptions>, 'docs'>;\nexport type NgRxRuleModule<\n  TOptions extends readonly unknown[],\n  TMessageIds extends string\n> = Omit<TSESLint.RuleModule<TMessageIds, TOptions>, 'meta'> & {\n  meta: Meta<TMessageIds, TOptions>;\n};\n\nexport function createRule<\n  TOptions extends readonly unknown[],\n  TMessageIds extends string\n>(\n  config: Readonly<{\n    name: string;\n    meta: CreateRuleMeta<TMessageIds, TOptions>;\n    defaultOptions: Readonly<TOptions>;\n    create: (\n      context: Readonly<TSESLint.RuleContext<TMessageIds, TOptions>>,\n      optionsWithDefault: Readonly<TOptions>\n    ) => TSESLint.RuleListener;\n  }>\n): TSESLint.RuleModule<TMessageIds, TOptions> {\n  const configOverwrite = {\n    ...config,\n    create: (\n      context: Readonly<TSESLint.RuleContext<TMessageIds, TOptions>>,\n      optionsWithDefault: Readonly<TOptions>\n    ) => {\n      const {\n        meta: { ngrxModule, version },\n      } = config;\n      if (\n        version !== undefined &&\n        !ngrxVersionSatisfies(NGRX_MODULE_PATHS[ngrxModule], version)\n      ) {\n        return {};\n      }\n\n      return config.create(context, optionsWithDefault);\n    },\n  };\n\n  for (const [key, message] of Object.entries(configOverwrite.meta.messages)) {\n    (configOverwrite.meta.messages as any)[key] = `${message} (${docsUrl(\n      config.name\n    )})`;\n  }\n\n  return ESLintUtils.RuleCreator(docsUrl)(configOverwrite);\n}\n"]}
+{"version":3,"file":"rule-creator.js","sourceRoot":"","sources":["../../../../modules/eslint-plugin/src/rule-creator.ts"],"names":[],"mappings":";;AA2BA,gCAyCC;AAnED,oDAAuD;AAEvD,mCAA2E;AAwB3E,SAAgB,UAAU,CAIxB,MAQE;IAEF,MAAM,eAAe,GAAG;QACtB,GAAG,MAAM;QACT,MAAM,EAAE,CACN,OAA8D,EAC9D,kBAAsC,EACtC,EAAE;YACF,MAAM,EACJ,IAAI,EAAE,EAAE,UAAU,EAAE,OAAO,EAAE,GAC9B,GAAG,MAAM,CAAC;YACX,IACE,OAAO,KAAK,SAAS;gBACrB,CAAC,IAAA,4BAAoB,EAAC,yBAAiB,CAAC,UAAU,CAAC,EAAE,OAAO,CAAC,EAC7D,CAAC;gBACD,OAAO,EAAE,CAAC;YACZ,CAAC;YAED,OAAO,MAAM,CAAC,MAAM,CAAC,OAAO,EAAE,kBAAkB,CAAC,CAAC;QACpD,CAAC;KACF,CAAC;IAEF,KAAK,MAAM,CAAC,GAAG,EAAE,OAAO,CAAC,IAAI,MAAM,CAAC,OAAO,CAAC,eAAe,CAAC,IAAI,CAAC,QAAQ,CAAC,EAAE,CAAC;QAC1E,eAAe,CAAC,IAAI,CAAC,QAAgB,CAAC,GAAG,CAAC,GAAG,GAAG,OAAO,KAAK,IAAA,eAAO,EAClE,MAAM,CAAC,IAAI,CACZ,GAAG,CAAC;IACP,CAAC;IAED,OAAO,mBAAW,CAAC,WAAW,CAAC,eAAO,CAAC,CAAC,eAAe,CAAC,CAAC;AAC3D,CAAC","sourcesContent":["import type { TSESLint } from '@typescript-eslint/utils';\nimport { ESLintUtils } from '@typescript-eslint/utils';\nimport type { NGRX_MODULE } from './utils';\nimport { docsUrl, ngrxVersionSatisfies, NGRX_MODULE_PATHS } from './utils';\n\ntype Meta<TMessageIds extends string, TOptions extends readonly unknown[]> =\n  | TSESLint.RuleMetaData<TMessageIds, TOptions> & {\n      ngrxModule: NGRX_MODULE;\n      version?: string;\n      docs: { requiresTypeChecking?: boolean };\n    };\n\ntype CreateRuleMeta<\n  TMessageIds extends string,\n  TOptions extends readonly unknown[]\n> = {\n  docs: Omit<TSESLint.RuleMetaDataDocs, 'url'> & {\n    requiresTypeChecking?: boolean;\n  };\n} & Omit<Meta<TMessageIds, TOptions>, 'docs'>;\nexport type NgRxRuleModule<\n  TOptions extends readonly unknown[],\n  TMessageIds extends string\n> = Omit<TSESLint.RuleModule<TMessageIds, TOptions>, 'meta'> & {\n  meta: Meta<TMessageIds, TOptions>;\n};\n\nexport function createRule<\n  TOptions extends readonly unknown[],\n  TMessageIds extends string\n>(\n  config: Readonly<{\n    name: string;\n    meta: CreateRuleMeta<TMessageIds, TOptions>;\n    defaultOptions: Readonly<TOptions>;\n    create: (\n      context: Readonly<TSESLint.RuleContext<TMessageIds, TOptions>>,\n      optionsWithDefault: Readonly<TOptions>\n    ) => TSESLint.RuleListener;\n  }>\n): TSESLint.RuleModule<TMessageIds, TOptions> {\n  const configOverwrite = {\n    ...config,\n    create: (\n      context: Readonly<TSESLint.RuleContext<TMessageIds, TOptions>>,\n      optionsWithDefault: Readonly<TOptions>\n    ) => {\n      const {\n        meta: { ngrxModule, version },\n      } = config;\n      if (\n        version !== undefined &&\n        !ngrxVersionSatisfies(NGRX_MODULE_PATHS[ngrxModule], version)\n      ) {\n        return {};\n      }\n\n      return config.create(context, optionsWithDefault);\n    },\n  };\n\n  for (const [key, message] of Object.entries(configOverwrite.meta.messages)) {\n    (configOverwrite.meta.messages as any)[key] = `${message} (${docsUrl(\n      config.name\n    )})`;\n  }\n\n  return ESLintUtils.RuleCreator(docsUrl)(configOverwrite);\n}\n"]}

package/src/rules/effects/no-multiple-actions-in-effects.js

@@ -61,7 +61,7 @@ exports.default = (0, rule_creator_1.createRule)({
                     });
                 }
                 else if (type.isUnion() &&
-                    type.types.some((ut) => !typeChecker.isArrayType(ut))) {
+                    type.types.some((ut) => typeChecker.isArrayType(ut))) {
                     context.report({
                         node: nodeToReport,
                         messageId: exports.messageId,

package/src/rules/effects/no-multiple-actions-in-effects.js.map

@@ -1 +1 @@
-{"version":3,"file":"no-multiple-actions-in-effects.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/effects/no-multiple-actions-in-effects.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;AAAA,oDAIkC;AAClC,2CAA6B;AAC7B,qDAAgD;AAChD,uCAKqB;AAER,QAAA,SAAS,GAAG,4BAA4B,CAAC;AAUtD,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EAAE,8CAA8C;YAC3D,oBAAoB,EAAE,IAAI;SAC3B;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,CAAC,iBAAS,CAAC,EAAE,yCAAyC;SACvD;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,OAAO;YACL,CAAC,GAAG,8BAAsB,IAAI,sCAA8B,EAAE,CAAC,CAC7D,IAAmC;gBAEnC,MAAM,YAAY,GAAG,eAAe,CAAC,IAAI,CAAC,CAAC;gBAC3C,IAAI,CAAC,YAAY,EAAE,CAAC;oBAClB,OAAO;gBACT,CAAC;gBAED,MAAM,QAAQ,GAAG,mBAAW,CAAC,iBAAiB,CAAC,OAAO,CAAC,CAAC;gBACxD,MAAM,WAAW,GAAG,QAAQ,CAAC,OAAO,CAAC,cAAc,EAAE,CAAC;gBACtD,MAAM,IAAI,GAAG,QAAQ,CAAC,iBAAiB,CAAC,YAAY,CAAC,CAAC;gBAEtD,IAAI,WAAW,CAAC,WAAW,CAAC,IAAI,CAAC,EAAE,CAAC;oBAClC,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,YAAY;wBAClB,SAAS,EAAT,iBAAS;qBACV,CAAC,CAAC;gBACL,CAAC;qBAAM,IACL,IAAI,CAAC,OAAO,EAAE;oBACd,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC,WAAW,CAAC,WAAW,CAAC,EAAE,CAAC,CAAC,EACrD,CAAC;oBACD,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,YAAY;wBAClB,SAAS,EAAT,iBAAS;qBACV,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC;AAEH,SAAS,eAAe,CAAC,IAAmC;IAC1D,QAAQ,IAAI,CAAC,IAAI,EAAE,CAAC;QAClB,KAAK,sBAAc,CAAC,uBAAuB,CAAC;QAC5C,KAAK,sBAAc,CAAC,kBAAkB;YACpC,OAAO,IAAA,wBAAgB,EAAC,IAAI,CAAC,IAAI,CAAC;gBAChC,CAAC,CAAC,mBAAmB,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC;gBACrC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC;QAChB,KAAK,sBAAc,CAAC,cAAc;YAChC,OAAO,mBAAmB,CAAC,IAAI,CAAC,SAAS,CAAC,IAAI,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;QAClE;YACE,OAAO,IAAI,CAAC,QAAQ,CAAC;IACzB,CAAC;AACH,CAAC;AAED,SAAS,mBAAmB,CAAC,KAAsB;IACjD,MAAM,UAAU,GAAG,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAiC,EAAE,CACjE,IAAA,yBAAiB,EAAC,CAAC,CAAC,CACrB,CAAC;IACF,OAAO,UAAU,EAAE,QAAQ,CAAC;AAC9B,CAAC","sourcesContent":["import {\n  AST_NODE_TYPES,\n  ESLintUtils,\n  type TSESTree,\n} from '@typescript-eslint/utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  createEffectExpression,\n  isBlockStatement,\n  isReturnStatement,\n  mapLikeOperatorCallExpressions,\n} from '../../utils';\n\nexport const messageId = 'noMultipleActionsInEffects';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly unknown[];\ntype EffectsMapLikeOperatorsReturn =\n  | TSESTree.ArrowFunctionExpression\n  | TSESTree.CallExpression\n  | TSESTree.FunctionExpression\n  | TSESTree.ReturnStatement;\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'problem',\n    ngrxModule: 'effects',\n    docs: {\n      description: '`Effect` should not return multiple actions.',\n      requiresTypeChecking: true,\n    },\n    schema: [],\n    messages: {\n      [messageId]: '`Effect` should return a single action.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    return {\n      [`${createEffectExpression} ${mapLikeOperatorCallExpressions}`](\n        node: EffectsMapLikeOperatorsReturn\n      ) {\n        const nodeToReport = getNodeToReport(node);\n        if (!nodeToReport) {\n          return;\n        }\n\n        const services = ESLintUtils.getParserServices(context);\n        const typeChecker = services.program.getTypeChecker();\n        const type = services.getTypeAtLocation(nodeToReport);\n\n        if (typeChecker.isArrayType(type)) {\n          context.report({\n            node: nodeToReport,\n            messageId,\n          });\n        } else if (\n          type.isUnion() &&\n          type.types.some((ut) => !typeChecker.isArrayType(ut))\n        ) {\n          context.report({\n            node: nodeToReport,\n            messageId,\n          });\n        }\n      },\n    };\n  },\n});\n\nfunction getNodeToReport(node: EffectsMapLikeOperatorsReturn) {\n  switch (node.type) {\n    case AST_NODE_TYPES.ArrowFunctionExpression:\n    case AST_NODE_TYPES.FunctionExpression:\n      return isBlockStatement(node.body)\n        ? findReturnStatement(node.body.body)\n        : node.body;\n    case AST_NODE_TYPES.CallExpression:\n      return findReturnStatement(node.arguments) ?? node.arguments[0];\n    default:\n      return node.argument;\n  }\n}\n\nfunction findReturnStatement(nodes: TSESTree.Node[]) {\n  const returnNode = nodes.find((n): n is TSESTree.ReturnStatement =>\n    isReturnStatement(n)\n  );\n  return returnNode?.argument;\n}\n"]}
+{"version":3,"file":"no-multiple-actions-in-effects.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/effects/no-multiple-actions-in-effects.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;AAAA,oDAIkC;AAClC,2CAA6B;AAC7B,qDAAgD;AAChD,uCAKqB;AAER,QAAA,SAAS,GAAG,4BAA4B,CAAC;AAUtD,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EAAE,8CAA8C;YAC3D,oBAAoB,EAAE,IAAI;SAC3B;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,CAAC,iBAAS,CAAC,EAAE,yCAAyC;SACvD;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,OAAO;YACL,CAAC,GAAG,8BAAsB,IAAI,sCAA8B,EAAE,CAAC,CAC7D,IAAmC;gBAEnC,MAAM,YAAY,GAAG,eAAe,CAAC,IAAI,CAAC,CAAC;gBAC3C,IAAI,CAAC,YAAY,EAAE,CAAC;oBAClB,OAAO;gBACT,CAAC;gBAED,MAAM,QAAQ,GAAG,mBAAW,CAAC,iBAAiB,CAAC,OAAO,CAAC,CAAC;gBACxD,MAAM,WAAW,GAAG,QAAQ,CAAC,OAAO,CAAC,cAAc,EAAE,CAAC;gBACtD,MAAM,IAAI,GAAG,QAAQ,CAAC,iBAAiB,CAAC,YAAY,CAAC,CAAC;gBAEtD,IAAI,WAAW,CAAC,WAAW,CAAC,IAAI,CAAC,EAAE,CAAC;oBAClC,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,YAAY;wBAClB,SAAS,EAAT,iBAAS;qBACV,CAAC,CAAC;gBACL,CAAC;qBAAM,IACL,IAAI,CAAC,OAAO,EAAE;oBACd,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,WAAW,CAAC,WAAW,CAAC,EAAE,CAAC,CAAC,EACpD,CAAC;oBACD,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,YAAY;wBAClB,SAAS,EAAT,iBAAS;qBACV,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC;AAEH,SAAS,eAAe,CAAC,IAAmC;IAC1D,QAAQ,IAAI,CAAC,IAAI,EAAE,CAAC;QAClB,KAAK,sBAAc,CAAC,uBAAuB,CAAC;QAC5C,KAAK,sBAAc,CAAC,kBAAkB;YACpC,OAAO,IAAA,wBAAgB,EAAC,IAAI,CAAC,IAAI,CAAC;gBAChC,CAAC,CAAC,mBAAmB,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC;gBACrC,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC;QAChB,KAAK,sBAAc,CAAC,cAAc;YAChC,OAAO,mBAAmB,CAAC,IAAI,CAAC,SAAS,CAAC,IAAI,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;QAClE;YACE,OAAO,IAAI,CAAC,QAAQ,CAAC;IACzB,CAAC;AACH,CAAC;AAED,SAAS,mBAAmB,CAAC,KAAsB;IACjD,MAAM,UAAU,GAAG,KAAK,CAAC,IAAI,CAAC,CAAC,CAAC,EAAiC,EAAE,CACjE,IAAA,yBAAiB,EAAC,CAAC,CAAC,CACrB,CAAC;IACF,OAAO,UAAU,EAAE,QAAQ,CAAC;AAC9B,CAAC","sourcesContent":["import {\n  AST_NODE_TYPES,\n  ESLintUtils,\n  type TSESTree,\n} from '@typescript-eslint/utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  createEffectExpression,\n  isBlockStatement,\n  isReturnStatement,\n  mapLikeOperatorCallExpressions,\n} from '../../utils';\n\nexport const messageId = 'noMultipleActionsInEffects';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly unknown[];\ntype EffectsMapLikeOperatorsReturn =\n  | TSESTree.ArrowFunctionExpression\n  | TSESTree.CallExpression\n  | TSESTree.FunctionExpression\n  | TSESTree.ReturnStatement;\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'problem',\n    ngrxModule: 'effects',\n    docs: {\n      description: '`Effect` should not return multiple actions.',\n      requiresTypeChecking: true,\n    },\n    schema: [],\n    messages: {\n      [messageId]: '`Effect` should return a single action.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    return {\n      [`${createEffectExpression} ${mapLikeOperatorCallExpressions}`](\n        node: EffectsMapLikeOperatorsReturn\n      ) {\n        const nodeToReport = getNodeToReport(node);\n        if (!nodeToReport) {\n          return;\n        }\n\n        const services = ESLintUtils.getParserServices(context);\n        const typeChecker = services.program.getTypeChecker();\n        const type = services.getTypeAtLocation(nodeToReport);\n\n        if (typeChecker.isArrayType(type)) {\n          context.report({\n            node: nodeToReport,\n            messageId,\n          });\n        } else if (\n          type.isUnion() &&\n          type.types.some((ut) => typeChecker.isArrayType(ut))\n        ) {\n          context.report({\n            node: nodeToReport,\n            messageId,\n          });\n        }\n      },\n    };\n  },\n});\n\nfunction getNodeToReport(node: EffectsMapLikeOperatorsReturn) {\n  switch (node.type) {\n    case AST_NODE_TYPES.ArrowFunctionExpression:\n    case AST_NODE_TYPES.FunctionExpression:\n      return isBlockStatement(node.body)\n        ? findReturnStatement(node.body.body)\n        : node.body;\n    case AST_NODE_TYPES.CallExpression:\n      return findReturnStatement(node.arguments) ?? node.arguments[0];\n    default:\n      return node.argument;\n  }\n}\n\nfunction findReturnStatement(nodes: TSESTree.Node[]) {\n  const returnNode = nodes.find((n): n is TSESTree.ReturnStatement =>\n    isReturnStatement(n)\n  );\n  return returnNode?.argument;\n}\n"]}

package/src/rules/index.d.ts

@@ -31,5 +31,7 @@ export declare const rules: {
         readonly strict: boolean;
     }], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
     'signal-state-no-arrays-at-root-level': import("@typescript-eslint/utils/ts-eslint").RuleModule<"signalStateNoArraysAtRootLevel", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'signal-store-feature-should-use-generic-type': import("@typescript-eslint/utils/ts-eslint").RuleModule<"signalStoreFeatureShouldUseGenericType", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'prefer-protected-state': import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferProtectedState" | "preferProtectedStateSuggest", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
     'with-state-no-arrays-at-root-level': import("@typescript-eslint/utils/ts-eslint").RuleModule<"withStateNoArraysAtRootLevel", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
 };

package/src/rules/index.js

@@ -37,8 +37,11 @@ const select_style_1 = __importDefault(require("./store/select-style"));
 const use_consistent_global_store_name_1 = __importDefault(require("./store/use-consistent-global-store-name"));
 // operators
 const prefer_concat_latest_from_1 = __importDefault(require("./operators/prefer-concat-latest-from"));
+// signals
 const signal_state_no_arrays_at_root_level_1 = __importDefault(require("./signals/signal-state-no-arrays-at-root-level"));
+const signal_store_feature_should_use_generic_type_1 = __importDefault(require("./signals/signal-store-feature-should-use-generic-type"));
 const with_state_no_arrays_at_root_level_1 = __importDefault(require("./signals/with-state-no-arrays-at-root-level"));
+const prefer_protected_state_1 = __importDefault(require("./signals/prefer-protected-state"));
 exports.rules = {
     // component-store
     'avoid-combining-component-store-selectors': avoid_combining_component_store_selectors_1.default,
@@ -75,6 +78,8 @@ exports.rules = {
     'prefer-concat-latest-from': prefer_concat_latest_from_1.default,
     // signals
     'signal-state-no-arrays-at-root-level': signal_state_no_arrays_at_root_level_1.default,
+    'signal-store-feature-should-use-generic-type': signal_store_feature_should_use_generic_type_1.default,
+    'prefer-protected-state': prefer_protected_state_1.default,
     'with-state-no-arrays-at-root-level': with_state_no_arrays_at_root_level_1.default,
 };
 //# sourceMappingURL=index.js.map

package/src/rules/index.js.map

@@ -1 +1 @@
-{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../../modules/eslint-plugin/src/rules/index.ts"],"names":[],"mappings":";;;;;;AAAA,kBAAkB;AAClB,4IAAgH;AAChH,wIAA4G;AAC5G,kHAAuF;AACvF,UAAU;AACV,0FAAgE;AAChE,8FAAmE;AACnE,gGAAqE;AACrE,8GAAkF;AAClF,kHAAqF;AACrF,oIAAuG;AACvG,gHAAqF;AACrF,QAAQ;AACR,kGAAwE;AACxE,8IAAkH;AAClH,oHAAwF;AACxF,8FAAoE;AACpE,sFAA4D;AAC5D,kGAAuE;AACvE,8FAAkE;AAClE,0FAAgE;AAChE,0FAA+D;AAC/D,gHAAoF;AACpF,0FAAgE;AAChE,kHAAsF;AACtF,oGAAyE;AACzE,kJAAmH;AACnH,kGAAuE;AACvE,wGAA6E;AAC7E,wEAA+C;AAC/C,gHAAoF;AACpF,YAAY;AACZ,sGAA2E;AAC3E,0HAA4F;AAC5F,sHAAwF;AAE3E,QAAA,KAAK,GAAG;IACnB,kBAAkB;IAClB,2CAA2C,EACzC,mDAAqC;IACvC,yCAAyC,EACvC,iDAAmC;IACrC,8BAA8B,EAAE,sCAAyB;IACzD,SAAS;IACT,sBAAsB,EAAE,8BAAkB;IAC1C,wBAAwB,EAAE,gCAAmB;IAC7C,yBAAyB,EAAE,iCAAoB;IAC/C,gCAAgC,EAAE,wCAA0B;IAC5D,kCAAkC,EAAE,0CAA2B;IAC/D,2CAA2C,EACzC,mDAAoC;IACtC,iCAAiC,EAAE,yCAA4B;IAC/D,QAAQ;IACR,2BAA2B,EAAE,mCAAuB;IACpD,iDAAiD,EAC/C,yDAA2C;IAC7C,oCAAoC,EAAE,4CAA8B;IACpE,yBAAyB,EAAE,iCAAqB;IAChD,qBAAqB,EAAE,6BAAiB;IACxC,2BAA2B,EAAE,mCAAsB;IACnD,yBAAyB,EAAE,iCAAmB;IAC9C,uBAAuB,EAAE,+BAAmB;IAC5C,uBAAuB,EAAE,+BAAkB;IAC3C,kCAAkC,EAAE,0CAA4B;IAChE,uBAAuB,EAAE,+BAAmB;IAC5C,mCAAmC,EAAE,2CAA6B;IAClE,4BAA4B,EAAE,oCAAuB;IACrD,mDAAmD,EACjD,2DAA0C;IAC5C,2BAA2B,EAAE,mCAAsB;IACnD,8BAA8B,EAAE,sCAAyB;IACzD,cAAc,EAAE,sBAAW;IAC3B,kCAAkC,EAAE,0CAA4B;IAChE,YAAY;IACZ,2BAA2B,EAAE,mCAAsB;IACnD,UAAU;IACV,sCAAsC,EAAE,8CAA8B;IACtE,oCAAoC,EAAE,4CAA4B;CACnE,CAAC","sourcesContent":["// component-store\nimport avoidCombiningComponentStoreSelectors from './component-store/avoid-combining-component-store-selectors';\nimport avoidMappingComponentStoreSelectors from './component-store/avoid-mapping-component-store-selectors';\nimport updaterExplicitReturnType from './component-store/updater-explicit-return-type';\n// effects\nimport avoidCyclicEffects from './effects/avoid-cyclic-effects';\nimport noDispatchInEffects from './effects/no-dispatch-in-effects';\nimport noEffectsInProviders from './effects/no-effects-in-providers';\nimport noMultipleActionsInEffects from './effects/no-multiple-actions-in-effects';\nimport preferActionCreatorInOfType from './effects/prefer-action-creator-in-of-type';\nimport preferEffectCallbackInBlockStatement from './effects/prefer-effect-callback-in-block-statement';\nimport useEffectsLifecycleInterface from './effects/use-effects-lifecycle-interface';\n// store\nimport avoidCombiningSelectors from './store/avoid-combining-selectors';\nimport avoidDispatchingMultipleActionsSequentially from './store/avoid-dispatching-multiple-actions-sequentially';\nimport avoidDuplicateActionsInReducer from './store/avoid-duplicate-actions-in-reducer';\nimport avoidMappingSelectors from './store/avoid-mapping-selectors';\nimport goodActionHygiene from './store/good-action-hygiene';\nimport noMultipleGlobalStores from './store/no-multiple-global-stores';\nimport noReducerInKeyNames from './store/no-reducer-in-key-names';\nimport noStoreSubscription from './store/no-store-subscription';\nimport noTypedGlobalStore from './store/no-typed-global-store';\nimport onFunctionExplicitReturnType from './store/on-function-explicit-return-type';\nimport preferActionCreator from './store/prefer-action-creator';\nimport preferActionCreatorInDispatch from './store/prefer-action-creator-in-dispatch';\nimport preferInlineActionProps from './store/prefer-inline-action-props';\nimport preferOneGenericInCreateForFeatureSelector from './store/prefer-one-generic-in-create-for-feature-selector';\nimport preferSelectorInSelect from './store/prefer-selector-in-select';\nimport prefixSelectorsWithSelect from './store/prefix-selectors-with-select';\nimport selectStyle from './store/select-style';\nimport useConsistentGlobalStoreName from './store/use-consistent-global-store-name';\n// operators\nimport preferConcatLatestFrom from './operators/prefer-concat-latest-from';\nimport signalStateNoArraysAtRootLevel from './signals/signal-state-no-arrays-at-root-level';\nimport withStateNoArraysAtRootLevel from './signals/with-state-no-arrays-at-root-level';\n\nexport const rules = {\n  // component-store\n  'avoid-combining-component-store-selectors':\n    avoidCombiningComponentStoreSelectors,\n  'avoid-mapping-component-store-selectors':\n    avoidMappingComponentStoreSelectors,\n  'updater-explicit-return-type': updaterExplicitReturnType,\n  //effects\n  'avoid-cyclic-effects': avoidCyclicEffects,\n  'no-dispatch-in-effects': noDispatchInEffects,\n  'no-effects-in-providers': noEffectsInProviders,\n  'no-multiple-actions-in-effects': noMultipleActionsInEffects,\n  'prefer-action-creator-in-of-type': preferActionCreatorInOfType,\n  'prefer-effect-callback-in-block-statement':\n    preferEffectCallbackInBlockStatement,\n  'use-effects-lifecycle-interface': useEffectsLifecycleInterface,\n  // store\n  'avoid-combining-selectors': avoidCombiningSelectors,\n  'avoid-dispatching-multiple-actions-sequentially':\n    avoidDispatchingMultipleActionsSequentially,\n  'avoid-duplicate-actions-in-reducer': avoidDuplicateActionsInReducer,\n  'avoid-mapping-selectors': avoidMappingSelectors,\n  'good-action-hygiene': goodActionHygiene,\n  'no-multiple-global-stores': noMultipleGlobalStores,\n  'no-reducer-in-key-names': noReducerInKeyNames,\n  'no-store-subscription': noStoreSubscription,\n  'no-typed-global-store': noTypedGlobalStore,\n  'on-function-explicit-return-type': onFunctionExplicitReturnType,\n  'prefer-action-creator': preferActionCreator,\n  'prefer-action-creator-in-dispatch': preferActionCreatorInDispatch,\n  'prefer-inline-action-props': preferInlineActionProps,\n  'prefer-one-generic-in-create-for-feature-selector':\n    preferOneGenericInCreateForFeatureSelector,\n  'prefer-selector-in-select': preferSelectorInSelect,\n  'prefix-selectors-with-select': prefixSelectorsWithSelect,\n  'select-style': selectStyle,\n  'use-consistent-global-store-name': useConsistentGlobalStoreName,\n  // operators\n  'prefer-concat-latest-from': preferConcatLatestFrom,\n  // signals\n  'signal-state-no-arrays-at-root-level': signalStateNoArraysAtRootLevel,\n  'with-state-no-arrays-at-root-level': withStateNoArraysAtRootLevel,\n};\n"]}
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../../modules/eslint-plugin/src/rules/index.ts"],"names":[],"mappings":";;;;;;AAAA,kBAAkB;AAClB,4IAAgH;AAChH,wIAA4G;AAC5G,kHAAuF;AACvF,UAAU;AACV,0FAAgE;AAChE,8FAAmE;AACnE,gGAAqE;AACrE,8GAAkF;AAClF,kHAAqF;AACrF,oIAAuG;AACvG,gHAAqF;AACrF,QAAQ;AACR,kGAAwE;AACxE,8IAAkH;AAClH,oHAAwF;AACxF,8FAAoE;AACpE,sFAA4D;AAC5D,kGAAuE;AACvE,8FAAkE;AAClE,0FAAgE;AAChE,0FAA+D;AAC/D,gHAAoF;AACpF,0FAAgE;AAChE,kHAAsF;AACtF,oGAAyE;AACzE,kJAAmH;AACnH,kGAAuE;AACvE,wGAA6E;AAC7E,wEAA+C;AAC/C,gHAAoF;AACpF,YAAY;AACZ,sGAA2E;AAC3E,UAAU;AACV,0HAA4F;AAC5F,0IAA4G;AAC5G,sHAAwF;AACxF,8FAAoE;AAEvD,QAAA,KAAK,GAAG;IACnB,kBAAkB;IAClB,2CAA2C,EACzC,mDAAqC;IACvC,yCAAyC,EACvC,iDAAmC;IACrC,8BAA8B,EAAE,sCAAyB;IACzD,SAAS;IACT,sBAAsB,EAAE,8BAAkB;IAC1C,wBAAwB,EAAE,gCAAmB;IAC7C,yBAAyB,EAAE,iCAAoB;IAC/C,gCAAgC,EAAE,wCAA0B;IAC5D,kCAAkC,EAAE,0CAA2B;IAC/D,2CAA2C,EACzC,mDAAoC;IACtC,iCAAiC,EAAE,yCAA4B;IAC/D,QAAQ;IACR,2BAA2B,EAAE,mCAAuB;IACpD,iDAAiD,EAC/C,yDAA2C;IAC7C,oCAAoC,EAAE,4CAA8B;IACpE,yBAAyB,EAAE,iCAAqB;IAChD,qBAAqB,EAAE,6BAAiB;IACxC,2BAA2B,EAAE,mCAAsB;IACnD,yBAAyB,EAAE,iCAAmB;IAC9C,uBAAuB,EAAE,+BAAmB;IAC5C,uBAAuB,EAAE,+BAAkB;IAC3C,kCAAkC,EAAE,0CAA4B;IAChE,uBAAuB,EAAE,+BAAmB;IAC5C,mCAAmC,EAAE,2CAA6B;IAClE,4BAA4B,EAAE,oCAAuB;IACrD,mDAAmD,EACjD,2DAA0C;IAC5C,2BAA2B,EAAE,mCAAsB;IACnD,8BAA8B,EAAE,sCAAyB;IACzD,cAAc,EAAE,sBAAW;IAC3B,kCAAkC,EAAE,0CAA4B;IAChE,YAAY;IACZ,2BAA2B,EAAE,mCAAsB;IACnD,UAAU;IACV,sCAAsC,EAAE,8CAA8B;IACtE,8CAA8C,EAC5C,sDAAsC;IACxC,wBAAwB,EAAE,gCAAoB;IAC9C,oCAAoC,EAAE,4CAA4B;CACnE,CAAC","sourcesContent":["// component-store\nimport avoidCombiningComponentStoreSelectors from './component-store/avoid-combining-component-store-selectors';\nimport avoidMappingComponentStoreSelectors from './component-store/avoid-mapping-component-store-selectors';\nimport updaterExplicitReturnType from './component-store/updater-explicit-return-type';\n// effects\nimport avoidCyclicEffects from './effects/avoid-cyclic-effects';\nimport noDispatchInEffects from './effects/no-dispatch-in-effects';\nimport noEffectsInProviders from './effects/no-effects-in-providers';\nimport noMultipleActionsInEffects from './effects/no-multiple-actions-in-effects';\nimport preferActionCreatorInOfType from './effects/prefer-action-creator-in-of-type';\nimport preferEffectCallbackInBlockStatement from './effects/prefer-effect-callback-in-block-statement';\nimport useEffectsLifecycleInterface from './effects/use-effects-lifecycle-interface';\n// store\nimport avoidCombiningSelectors from './store/avoid-combining-selectors';\nimport avoidDispatchingMultipleActionsSequentially from './store/avoid-dispatching-multiple-actions-sequentially';\nimport avoidDuplicateActionsInReducer from './store/avoid-duplicate-actions-in-reducer';\nimport avoidMappingSelectors from './store/avoid-mapping-selectors';\nimport goodActionHygiene from './store/good-action-hygiene';\nimport noMultipleGlobalStores from './store/no-multiple-global-stores';\nimport noReducerInKeyNames from './store/no-reducer-in-key-names';\nimport noStoreSubscription from './store/no-store-subscription';\nimport noTypedGlobalStore from './store/no-typed-global-store';\nimport onFunctionExplicitReturnType from './store/on-function-explicit-return-type';\nimport preferActionCreator from './store/prefer-action-creator';\nimport preferActionCreatorInDispatch from './store/prefer-action-creator-in-dispatch';\nimport preferInlineActionProps from './store/prefer-inline-action-props';\nimport preferOneGenericInCreateForFeatureSelector from './store/prefer-one-generic-in-create-for-feature-selector';\nimport preferSelectorInSelect from './store/prefer-selector-in-select';\nimport prefixSelectorsWithSelect from './store/prefix-selectors-with-select';\nimport selectStyle from './store/select-style';\nimport useConsistentGlobalStoreName from './store/use-consistent-global-store-name';\n// operators\nimport preferConcatLatestFrom from './operators/prefer-concat-latest-from';\n// signals\nimport signalStateNoArraysAtRootLevel from './signals/signal-state-no-arrays-at-root-level';\nimport signalStoreFeatureShouldUseGenericType from './signals/signal-store-feature-should-use-generic-type';\nimport withStateNoArraysAtRootLevel from './signals/with-state-no-arrays-at-root-level';\nimport preferProtectedState from './signals/prefer-protected-state';\n\nexport const rules = {\n  // component-store\n  'avoid-combining-component-store-selectors':\n    avoidCombiningComponentStoreSelectors,\n  'avoid-mapping-component-store-selectors':\n    avoidMappingComponentStoreSelectors,\n  'updater-explicit-return-type': updaterExplicitReturnType,\n  //effects\n  'avoid-cyclic-effects': avoidCyclicEffects,\n  'no-dispatch-in-effects': noDispatchInEffects,\n  'no-effects-in-providers': noEffectsInProviders,\n  'no-multiple-actions-in-effects': noMultipleActionsInEffects,\n  'prefer-action-creator-in-of-type': preferActionCreatorInOfType,\n  'prefer-effect-callback-in-block-statement':\n    preferEffectCallbackInBlockStatement,\n  'use-effects-lifecycle-interface': useEffectsLifecycleInterface,\n  // store\n  'avoid-combining-selectors': avoidCombiningSelectors,\n  'avoid-dispatching-multiple-actions-sequentially':\n    avoidDispatchingMultipleActionsSequentially,\n  'avoid-duplicate-actions-in-reducer': avoidDuplicateActionsInReducer,\n  'avoid-mapping-selectors': avoidMappingSelectors,\n  'good-action-hygiene': goodActionHygiene,\n  'no-multiple-global-stores': noMultipleGlobalStores,\n  'no-reducer-in-key-names': noReducerInKeyNames,\n  'no-store-subscription': noStoreSubscription,\n  'no-typed-global-store': noTypedGlobalStore,\n  'on-function-explicit-return-type': onFunctionExplicitReturnType,\n  'prefer-action-creator': preferActionCreator,\n  'prefer-action-creator-in-dispatch': preferActionCreatorInDispatch,\n  'prefer-inline-action-props': preferInlineActionProps,\n  'prefer-one-generic-in-create-for-feature-selector':\n    preferOneGenericInCreateForFeatureSelector,\n  'prefer-selector-in-select': preferSelectorInSelect,\n  'prefix-selectors-with-select': prefixSelectorsWithSelect,\n  'select-style': selectStyle,\n  'use-consistent-global-store-name': useConsistentGlobalStoreName,\n  // operators\n  'prefer-concat-latest-from': preferConcatLatestFrom,\n  // signals\n  'signal-state-no-arrays-at-root-level': signalStateNoArraysAtRootLevel,\n  'signal-store-feature-should-use-generic-type':\n    signalStoreFeatureShouldUseGenericType,\n  'prefer-protected-state': preferProtectedState,\n  'with-state-no-arrays-at-root-level': withStateNoArraysAtRootLevel,\n};\n"]}

package/src/rules/signals/prefer-protected-state.d.ts

@@ -0,0 +1,5 @@
+export declare const preferProtectedState = "preferProtectedState";
+export declare const preferProtectedStateSuggest = "preferProtectedStateSuggest";
+type MessageIds = typeof preferProtectedState | typeof preferProtectedStateSuggest;
+declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<MessageIds, readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+export default _default;

package/src/rules/signals/prefer-protected-state.js

@@ -0,0 +1,88 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || function (mod) {
+    if (mod && mod.__esModule) return mod;
+    var result = {};
+    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
+    __setModuleDefault(result, mod);
+    return result;
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.preferProtectedStateSuggest = exports.preferProtectedState = void 0;
+const path = __importStar(require("path"));
+const rule_creator_1 = require("../../rule-creator");
+exports.preferProtectedState = 'preferProtectedState';
+exports.preferProtectedStateSuggest = 'preferProtectedStateSuggest';
+exports.default = (0, rule_creator_1.createRule)({
+    name: path.parse(__filename).name,
+    meta: {
+        type: 'suggestion',
+        hasSuggestions: true,
+        ngrxModule: 'signals',
+        docs: {
+            description: `A Signal Store prefers protected state`,
+        },
+        schema: [],
+        messages: {
+            [exports.preferProtectedState]: '{ protectedState: false } should be removed to prevent external state mutations.',
+            [exports.preferProtectedStateSuggest]: 'Remove `{protectedState: false}`.',
+        },
+    },
+    defaultOptions: [],
+    create: (context) => {
+        return {
+            [`CallExpression[callee.name=signalStore][arguments.length>0] > ObjectExpression[properties.length>0] > Property[key.name=protectedState][value.value=false]`](node) {
+                context.report({
+                    node,
+                    messageId: exports.preferProtectedState,
+                    suggest: [
+                        {
+                            messageId: exports.preferProtectedStateSuggest,
+                            fix: (fixer) => {
+                                const getRangeToBeRemoved = () => {
+                                    const parentObject = node.parent;
+                                    const parentObjectHasOnlyOneProperty = parentObject.properties.length === 1;
+                                    if (parentObjectHasOnlyOneProperty) {
+                                        /**
+                                         * Remove the entire object if it contains only one property - the relevant one
+                                         */
+                                        return parentObject.range;
+                                    }
+                                    const tokenAfter = context.sourceCode.getTokenAfter(node);
+                                    const tokenAfterIsComma = tokenAfter?.value?.trim() === ',';
+                                    /**
+                                     * Remove the specific property if there is more than one property in the parent
+                                     */
+                                    return [
+                                        node.range[0],
+                                        /**
+                                         *  remove trailing comma as well
+                                         */
+                                        tokenAfterIsComma ? tokenAfter.range[1] : node.range[1],
+                                    ];
+                                };
+                                return fixer.removeRange(getRangeToBeRemoved());
+                            },
+                        },
+                    ],
+                });
+            },
+        };
+    },
+});
+//# sourceMappingURL=prefer-protected-state.js.map

package/src/rules/signals/prefer-protected-state.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"prefer-protected-state.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/signals/prefer-protected-state.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;AACA,2CAA6B;AAC7B,qDAAgD;AAEnC,QAAA,oBAAoB,GAAG,sBAAsB,CAAC;AAC9C,QAAA,2BAA2B,GAAG,6BAA6B,CAAC;AAOzE,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,cAAc,EAAE,IAAI;QACpB,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EAAE,wCAAwC;SACtD;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,CAAC,4BAAoB,CAAC,EACpB,kFAAkF;YACpF,CAAC,mCAA2B,CAAC,EAAE,mCAAmC;SACnE;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,OAAO;YACL,CAAC,4JAA4J,CAAC,CAC5J,IAAuB;gBAEvB,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI;oBACJ,SAAS,EAAE,4BAAoB;oBAC/B,OAAO,EAAE;wBACP;4BACE,SAAS,EAAE,mCAA2B;4BACtC,GAAG,EAAE,CAAC,KAAK,EAAE,EAAE;gCACb,MAAM,mBAAmB,GAAG,GAEvB,EAAE;oCACL,MAAM,YAAY,GAAG,IAAI,CAAC,MAAmC,CAAC;oCAC9D,MAAM,8BAA8B,GAClC,YAAY,CAAC,UAAU,CAAC,MAAM,KAAK,CAAC,CAAC;oCAEvC,IAAI,8BAA8B,EAAE,CAAC;wCACnC;;2CAEG;wCACH,OAAO,YAAY,CAAC,KAAK,CAAC;oCAC5B,CAAC;oCAED,MAAM,UAAU,GAAG,OAAO,CAAC,UAAU,CAAC,aAAa,CAAC,IAAI,CAAC,CAAC;oCAC1D,MAAM,iBAAiB,GAAG,UAAU,EAAE,KAAK,EAAE,IAAI,EAAE,KAAK,GAAG,CAAC;oCAC5D;;uCAEG;oCACH,OAAO;wCACL,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC;wCACb;;2CAEG;wCACH,iBAAiB,CAAC,CAAC,CAAC,UAAU,CAAC,KAAK,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAC,CAAC;qCACxD,CAAC;gCACJ,CAAC,CAAC;gCAEF,OAAO,KAAK,CAAC,WAAW,CAAC,mBAAmB,EAAE,CAAC,CAAC;4BAClD,CAAC;yBACF;qBACF;iBACF,CAAC,CAAC;YACL,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import { type TSESTree } from '@typescript-eslint/utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\n\nexport const preferProtectedState = 'preferProtectedState';\nexport const preferProtectedStateSuggest = 'preferProtectedStateSuggest';\n\ntype MessageIds =\n  | typeof preferProtectedState\n  | typeof preferProtectedStateSuggest;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    hasSuggestions: true,\n    ngrxModule: 'signals',\n    docs: {\n      description: `A Signal Store prefers protected state`,\n    },\n    schema: [],\n    messages: {\n      [preferProtectedState]:\n        '{ protectedState: false } should be removed to prevent external state mutations.',\n      [preferProtectedStateSuggest]: 'Remove `{protectedState: false}`.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    return {\n      [`CallExpression[callee.name=signalStore][arguments.length>0] > ObjectExpression[properties.length>0] > Property[key.name=protectedState][value.value=false]`](\n        node: TSESTree.Property\n      ) {\n        context.report({\n          node,\n          messageId: preferProtectedState,\n          suggest: [\n            {\n              messageId: preferProtectedStateSuggest,\n              fix: (fixer) => {\n                const getRangeToBeRemoved = (): Parameters<\n                  typeof fixer.removeRange\n                >[0] => {\n                  const parentObject = node.parent as TSESTree.ObjectExpression;\n                  const parentObjectHasOnlyOneProperty =\n                    parentObject.properties.length === 1;\n\n                  if (parentObjectHasOnlyOneProperty) {\n                    /**\n                     * Remove the entire object if it contains only one property - the relevant one\n                     */\n                    return parentObject.range;\n                  }\n\n                  const tokenAfter = context.sourceCode.getTokenAfter(node);\n                  const tokenAfterIsComma = tokenAfter?.value?.trim() === ',';\n                  /**\n                   * Remove the specific property if there is more than one property in the parent\n                   */\n                  return [\n                    node.range[0],\n                    /**\n                     *  remove trailing comma as well\n                     */\n                    tokenAfterIsComma ? tokenAfter.range[1] : node.range[1],\n                  ];\n                };\n\n                return fixer.removeRange(getRangeToBeRemoved());\n              },\n            },\n          ],\n        });\n      },\n    };\n  },\n});\n"]}

package/src/rules/signals/signal-store-feature-should-use-generic-type.d.ts

@@ -0,0 +1,4 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+export declare const messageId = "signalStoreFeatureShouldUseGenericType";
+declare const _default: ESLintUtils.RuleModule<"signalStoreFeatureShouldUseGenericType", readonly [], unknown, ESLintUtils.RuleListener>;
+export default _default;

package/src/rules/signals/signal-store-feature-should-use-generic-type.js

@@ -0,0 +1,100 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || function (mod) {
+    if (mod && mod.__esModule) return mod;
+    var result = {};
+    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
+    __setModuleDefault(result, mod);
+    return result;
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.messageId = void 0;
+const path = __importStar(require("path"));
+const rule_creator_1 = require("../../rule-creator");
+const utils_1 = require("../../utils");
+exports.messageId = 'signalStoreFeatureShouldUseGenericType';
+exports.default = (0, rule_creator_1.createRule)({
+    name: path.parse(__filename).name,
+    meta: {
+        type: 'problem',
+        ngrxModule: 'signals',
+        docs: {
+            description: `A custom Signal Store feature that accepts an input should define a generic type.`,
+        },
+        fixable: 'code',
+        schema: [],
+        messages: {
+            [exports.messageId]: `Add an unused generic type to the function creating the signal store feature.`,
+        },
+    },
+    defaultOptions: [],
+    create: (context) => {
+        function report(signalStoreFeature, func) {
+            if (!func ||
+                (!(0, utils_1.isFunctionDeclaration)(func) && !(0, utils_1.isArrowFunctionExpression)(func))) {
+                return;
+            }
+            const parentHasGenerics = func.typeParameters && func.typeParameters.params.length > 0;
+            if (!parentHasGenerics) {
+                context.report({
+                    node: signalStoreFeature.callee,
+                    messageId: exports.messageId,
+                    fix(fixer) {
+                        if ((0, utils_1.isFunctionDeclaration)(func)) {
+                            if (func.id) {
+                                return fixer.insertTextAfter(func.id, '<_>');
+                            }
+                        }
+                        return fixer.insertTextBefore(func, '<_>');
+                    },
+                });
+            }
+        }
+        function hasInputAsArgument(node) {
+            const [inputArg] = node.arguments;
+            return (!(0, utils_1.isCallExpression)(inputArg) ||
+                ((0, utils_1.isIdentifier)(inputArg.callee) && inputArg.callee.name === 'type'));
+        }
+        return {
+            [`ArrowFunctionExpression > CallExpression[callee.name=signalStoreFeature]`](node) {
+                if (hasInputAsArgument(node)) {
+                    report(node, node.parent);
+                }
+            },
+            [`ArrowFunctionExpression > BlockStatement CallExpression[callee.name=signalStoreFeature]`](node) {
+                if (hasInputAsArgument(node)) {
+                    let parent = node.parent;
+                    while (parent && !(0, utils_1.isArrowFunctionExpression)(parent)) {
+                        parent = parent.parent;
+                    }
+                    report(node, parent);
+                }
+            },
+            [`FunctionDeclaration > BlockStatement CallExpression[callee.name=signalStoreFeature]`](node) {
+                if (hasInputAsArgument(node)) {
+                    let parent = node.parent;
+                    while (parent && !(0, utils_1.isFunctionDeclaration)(parent)) {
+                        parent = parent.parent;
+                    }
+                    report(node, parent);
+                }
+            },
+        };
+    },
+});
+//# sourceMappingURL=signal-store-feature-should-use-generic-type.js.map

package/src/rules/signals/signal-store-feature-should-use-generic-type.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"signal-store-feature-should-use-generic-type.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/signals/signal-store-feature-should-use-generic-type.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;AACA,2CAA6B;AAC7B,qDAAgD;AAChD,uCAKqB;AAER,QAAA,SAAS,GAAG,wCAAwC,CAAC;AAKlE,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EAAE,mFAAmF;SACjG;QACD,OAAO,EAAE,MAAM;QACf,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,CAAC,iBAAS,CAAC,EAAE,+EAA+E;SAC7F;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,SAAS,MAAM,CACb,kBAA2C,EAC3C,IAAoB;YAEpB,IACE,CAAC,IAAI;gBACL,CAAC,CAAC,IAAA,6BAAqB,EAAC,IAAI,CAAC,IAAI,CAAC,IAAA,iCAAyB,EAAC,IAAI,CAAC,CAAC,EAClE,CAAC;gBACD,OAAO;YACT,CAAC;YACD,MAAM,iBAAiB,GACrB,IAAI,CAAC,cAAc,IAAI,IAAI,CAAC,cAAc,CAAC,MAAM,CAAC,MAAM,GAAG,CAAC,CAAC;YAC/D,IAAI,CAAC,iBAAiB,EAAE,CAAC;gBACvB,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI,EAAE,kBAAkB,CAAC,MAAM;oBAC/B,SAAS,EAAT,iBAAS;oBACT,GAAG,CAAC,KAAK;wBACP,IAAI,IAAA,6BAAqB,EAAC,IAAI,CAAC,EAAE,CAAC;4BAChC,IAAI,IAAI,CAAC,EAAE,EAAE,CAAC;gCACZ,OAAO,KAAK,CAAC,eAAe,CAAC,IAAI,CAAC,EAAE,EAAE,KAAK,CAAC,CAAC;4BAC/C,CAAC;wBACH,CAAC;wBAED,OAAO,KAAK,CAAC,gBAAgB,CAAC,IAAI,EAAE,KAAK,CAAC,CAAC;oBAC7C,CAAC;iBACF,CAAC,CAAC;YACL,CAAC;QACH,CAAC;QAED,SAAS,kBAAkB,CAAC,IAA6B;YACvD,MAAM,CAAC,QAAQ,CAAC,GAAG,IAAI,CAAC,SAAS,CAAC;YAClC,OAAO,CACL,CAAC,IAAA,wBAAgB,EAAC,QAAQ,CAAC;gBAC3B,CAAC,IAAA,oBAAY,EAAC,QAAQ,CAAC,MAAM,CAAC,IAAI,QAAQ,CAAC,MAAM,CAAC,IAAI,KAAK,MAAM,CAAC,CACnE,CAAC;QACJ,CAAC;QAED,OAAO;YACL,CAAC,0EAA0E,CAAC,CAC1E,IAA6B;gBAE7B,IAAI,kBAAkB,CAAC,IAAI,CAAC,EAAE,CAAC;oBAC7B,MAAM,CAAC,IAAI,EAAE,IAAI,CAAC,MAAM,CAAC,CAAC;gBAC5B,CAAC;YACH,CAAC;YACD,CAAC,yFAAyF,CAAC,CACzF,IAA6B;gBAE7B,IAAI,kBAAkB,CAAC,IAAI,CAAC,EAAE,CAAC;oBAC7B,IAAI,MAAM,GAA8B,IAAI,CAAC,MAAM,CAAC;oBACpD,OAAO,MAAM,IAAI,CAAC,IAAA,iCAAyB,EAAC,MAAM,CAAC,EAAE,CAAC;wBACpD,MAAM,GAAG,MAAM,CAAC,MAAM,CAAC;oBACzB,CAAC;oBACD,MAAM,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;gBACvB,CAAC;YACH,CAAC;YACD,CAAC,qFAAqF,CAAC,CACrF,IAA6B;gBAE7B,IAAI,kBAAkB,CAAC,IAAI,CAAC,EAAE,CAAC;oBAC7B,IAAI,MAAM,GAA8B,IAAI,CAAC,MAAM,CAAC;oBACpD,OAAO,MAAM,IAAI,CAAC,IAAA,6BAAqB,EAAC,MAAM,CAAC,EAAE,CAAC;wBAChD,MAAM,GAAG,MAAM,CAAC,MAAM,CAAC;oBACzB,CAAC;oBACD,MAAM,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;gBACvB,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import { ESLintUtils, type TSESTree } from '@typescript-eslint/utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  isArrowFunctionExpression,\n  isCallExpression,\n  isFunctionDeclaration,\n  isIdentifier,\n} from '../../utils';\n\nexport const messageId = 'signalStoreFeatureShouldUseGenericType';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'problem',\n    ngrxModule: 'signals',\n    docs: {\n      description: `A custom Signal Store feature that accepts an input should define a generic type.`,\n    },\n    fixable: 'code',\n    schema: [],\n    messages: {\n      [messageId]: `Add an unused generic type to the function creating the signal store feature.`,\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    function report(\n      signalStoreFeature: TSESTree.CallExpression,\n      func?: TSESTree.Node\n    ) {\n      if (\n        !func ||\n        (!isFunctionDeclaration(func) && !isArrowFunctionExpression(func))\n      ) {\n        return;\n      }\n      const parentHasGenerics =\n        func.typeParameters && func.typeParameters.params.length > 0;\n      if (!parentHasGenerics) {\n        context.report({\n          node: signalStoreFeature.callee,\n          messageId,\n          fix(fixer) {\n            if (isFunctionDeclaration(func)) {\n              if (func.id) {\n                return fixer.insertTextAfter(func.id, '<_>');\n              }\n            }\n\n            return fixer.insertTextBefore(func, '<_>');\n          },\n        });\n      }\n    }\n\n    function hasInputAsArgument(node: TSESTree.CallExpression) {\n      const [inputArg] = node.arguments;\n      return (\n        !isCallExpression(inputArg) ||\n        (isIdentifier(inputArg.callee) && inputArg.callee.name === 'type')\n      );\n    }\n\n    return {\n      [`ArrowFunctionExpression > CallExpression[callee.name=signalStoreFeature]`](\n        node: TSESTree.CallExpression\n      ) {\n        if (hasInputAsArgument(node)) {\n          report(node, node.parent);\n        }\n      },\n      [`ArrowFunctionExpression > BlockStatement CallExpression[callee.name=signalStoreFeature]`](\n        node: TSESTree.CallExpression\n      ) {\n        if (hasInputAsArgument(node)) {\n          let parent: TSESTree.Node | undefined = node.parent;\n          while (parent && !isArrowFunctionExpression(parent)) {\n            parent = parent.parent;\n          }\n          report(node, parent);\n        }\n      },\n      [`FunctionDeclaration > BlockStatement CallExpression[callee.name=signalStoreFeature]`](\n        node: TSESTree.CallExpression\n      ) {\n        if (hasInputAsArgument(node)) {\n          let parent: TSESTree.Node | undefined = node.parent;\n          while (parent && !isFunctionDeclaration(parent)) {\n            parent = parent.parent;\n          }\n          report(node, parent);\n        }\n      },\n    };\n  },\n});\n"]}