@ngrx/eslint-plugin 18.0.0-beta.1 → 18.0.0-rc.1

package/src/rules/effects/no-dispatch-in-effects.d.ts

@@ -0,0 +1,5 @@
+export declare const noDispatchInEffects = "noDispatchInEffects";
+export declare const noDispatchInEffectsSuggest = "noDispatchInEffectsSuggest";
+type MessageIds = typeof noDispatchInEffects | typeof noDispatchInEffectsSuggest;
+declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<MessageIds, readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+export default _default;

package/src/rules/effects/no-dispatch-in-effects.js

@@ -22,12 +22,11 @@ var __importStar = (this && this.__importStar) || function (mod) {
     __setModuleDefault(result, mod);
     return result;
 };
-var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.noDispatchInEffectsSuggest = exports.noDispatchInEffects = void 0;
-var path = __importStar(require("path"));
-var rule_creator_1 = require("../../rule-creator");
-var utils_1 = require("../../utils");
+const path = __importStar(require("path"));
+const rule_creator_1 = require("../../rule-creator");
+const utils_1 = require("../../utils");
 exports.noDispatchInEffects = 'noDispatchInEffects';
 exports.noDispatchInEffectsSuggest = 'noDispatchInEffectsSuggest';
 exports.default = (0, rule_creator_1.createRule)({
@@ -38,43 +37,40 @@ exports.default = (0, rule_creator_1.createRule)({
         hasSuggestions: true,
         docs: {
             description: '`Effect` should not call `store.dispatch`.',
-            recommended: 'warn',
-            suggestion: true,
         },
         schema: [],
-        messages: (_a = {},
-            _a[exports.noDispatchInEffects] = 'Calling `store.dispatch` in `Effect` is forbidden.',
-            _a[exports.noDispatchInEffectsSuggest] = 'Remove `store.dispatch`.',
-            _a),
+        messages: {
+            [exports.noDispatchInEffects]: 'Calling `store.dispatch` in `Effect` is forbidden.',
+            [exports.noDispatchInEffectsSuggest]: 'Remove `store.dispatch`.',
+        },
     },
     defaultOptions: [],
-    create: function (context) {
-        var _a;
-        var _b = (0, utils_1.getNgRxStores)(context).identifiers, identifiers = _b === void 0 ? [] : _b;
-        var storeNames = identifiers.length > 0 ? (0, utils_1.asPattern)(identifiers) : null;
+    create: (context) => {
+        const { identifiers = [] } = (0, utils_1.getNgRxStores)(context);
+        const storeNames = identifiers.length > 0 ? (0, utils_1.asPattern)(identifiers) : null;
         if (!storeNames) {
             return {};
         }
-        return _a = {},
-            _a[(0, utils_1.dispatchInEffects)(storeNames)] = function (node) {
-                var nodeToReport = getNodeToReport(node);
+        return {
+            [(0, utils_1.dispatchInEffects)(storeNames)](node) {
+                const nodeToReport = getNodeToReport(node);
                 context.report({
                     node: nodeToReport,
                     messageId: exports.noDispatchInEffects,
                     suggest: [
                         {
                             messageId: exports.noDispatchInEffectsSuggest,
-                            fix: function (fixer) { return fixer.remove(nodeToReport); },
+                            fix: (fixer) => fixer.remove(nodeToReport),
                         },
                     ],
                 });
             },
-            _a;
+        };
     },
 });
 function getNodeToReport(node) {
-    var parent = node.parent;
-    var grandParent = parent.parent;
+    const { parent } = node;
+    const { parent: grandParent } = parent;
     return grandParent &&
         ((0, utils_1.isArrowFunctionExpression)(grandParent) || (0, utils_1.isReturnStatement)(grandParent))
         ? node

package/src/rules/effects/no-dispatch-in-effects.js.map

@@ -1 +1 @@
-{"version":3,"file":"no-dispatch-in-effects.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/effects/no-dispatch-in-effects.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;AACA,yCAA6B;AAC7B,mDAAgD;AAChD,qCAMqB;AAER,QAAA,mBAAmB,GAAG,qBAAqB,CAAC;AAC5C,QAAA,0BAA0B,GAAG,4BAA4B,CAAC;AAUvE,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,UAAU,EAAE,SAAS;QACrB,cAAc,EAAE,IAAI;QACpB,IAAI,EAAE;YACJ,WAAW,EAAE,4CAA4C;YACzD,WAAW,EAAE,MAAM;YACnB,UAAU,EAAE,IAAI;SACjB;QACD,MAAM,EAAE,EAAE;QACV,QAAQ;YACN,GAAC,2BAAmB,IAClB,oDAAoD;YACtD,GAAC,kCAA0B,IAAG,0BAA0B;eACzD;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,UAAC,OAAO;;QACN,IAAA,KAAqB,IAAA,qBAAa,EAAC,OAAO,CAAC,YAA3B,EAAhB,WAAW,mBAAG,EAAE,KAAA,CAA4B;QACpD,IAAM,UAAU,GAAG,WAAW,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,IAAA,iBAAS,EAAC,WAAW,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;QAE1E,IAAI,CAAC,UAAU,EAAE,CAAC;YAChB,OAAO,EAAE,CAAC;QACZ,CAAC;QAED;YACE,GAAC,IAAA,yBAAiB,EAAC,UAAU,CAAC,IAA9B,UACE,IAA0C;gBAE1C,IAAM,YAAY,GAAG,eAAe,CAAC,IAAI,CAAC,CAAC;gBAC3C,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI,EAAE,YAAY;oBAClB,SAAS,EAAE,2BAAmB;oBAC9B,OAAO,EAAE;wBACP;4BACE,SAAS,EAAE,kCAA0B;4BACrC,GAAG,EAAE,UAAC,KAAK,IAAK,OAAA,KAAK,CAAC,MAAM,CAAC,YAAY,CAAC,EAA1B,CAA0B;yBAC3C;qBACF;iBACF,CAAC,CAAC;YACL,CAAC;eACD;IACJ,CAAC;CACF,CAAC,CAAC;AAEH,SAAS,eAAe,CAAC,IAA0C;IACzD,IAAA,MAAM,GAAK,IAAI,OAAT,CAAU;IAChB,IAAQ,WAAW,GAAK,MAAM,OAAX,CAAY;IACvC,OAAO,WAAW;QAChB,CAAC,IAAA,iCAAyB,EAAC,WAAW,CAAC,IAAI,IAAA,yBAAiB,EAAC,WAAW,CAAC,CAAC;QAC1E,CAAC,CAAC,IAAI;QACN,CAAC,CAAC,MAAM,CAAC;AACb,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/experimental-utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  asPattern,\n  dispatchInEffects,\n  getNgRxStores,\n  isArrowFunctionExpression,\n  isReturnStatement,\n} from '../../utils';\n\nexport const noDispatchInEffects = 'noDispatchInEffects';\nexport const noDispatchInEffectsSuggest = 'noDispatchInEffectsSuggest';\n\ntype MessageIds =\n  | typeof noDispatchInEffects\n  | typeof noDispatchInEffectsSuggest;\ntype Options = readonly [];\ntype MemberExpressionWithinCallExpression = TSESTree.MemberExpression & {\n  parent: TSESTree.CallExpression;\n};\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    ngrxModule: 'effects',\n    hasSuggestions: true,\n    docs: {\n      description: '`Effect` should not call `store.dispatch`.',\n      recommended: 'warn',\n      suggestion: true,\n    },\n    schema: [],\n    messages: {\n      [noDispatchInEffects]:\n        'Calling `store.dispatch` in `Effect` is forbidden.',\n      [noDispatchInEffectsSuggest]: 'Remove `store.dispatch`.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const { identifiers = [] } = getNgRxStores(context);\n    const storeNames = identifiers.length > 0 ? asPattern(identifiers) : null;\n\n    if (!storeNames) {\n      return {};\n    }\n\n    return {\n      [dispatchInEffects(storeNames)](\n        node: MemberExpressionWithinCallExpression\n      ) {\n        const nodeToReport = getNodeToReport(node);\n        context.report({\n          node: nodeToReport,\n          messageId: noDispatchInEffects,\n          suggest: [\n            {\n              messageId: noDispatchInEffectsSuggest,\n              fix: (fixer) => fixer.remove(nodeToReport),\n            },\n          ],\n        });\n      },\n    };\n  },\n});\n\nfunction getNodeToReport(node: MemberExpressionWithinCallExpression) {\n  const { parent } = node;\n  const { parent: grandParent } = parent;\n  return grandParent &&\n    (isArrowFunctionExpression(grandParent) || isReturnStatement(grandParent))\n    ? node\n    : parent;\n}\n"]}
+{"version":3,"file":"no-dispatch-in-effects.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/effects/no-dispatch-in-effects.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;AACA,2CAA6B;AAC7B,qDAAgD;AAChD,uCAMqB;AAER,QAAA,mBAAmB,GAAG,qBAAqB,CAAC;AAC5C,QAAA,0BAA0B,GAAG,4BAA4B,CAAC;AAUvE,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,UAAU,EAAE,SAAS;QACrB,cAAc,EAAE,IAAI;QACpB,IAAI,EAAE;YACJ,WAAW,EAAE,4CAA4C;SAC1D;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,CAAC,2BAAmB,CAAC,EACnB,oDAAoD;YACtD,CAAC,kCAA0B,CAAC,EAAE,0BAA0B;SACzD;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,MAAM,EAAE,WAAW,GAAG,EAAE,EAAE,GAAG,IAAA,qBAAa,EAAC,OAAO,CAAC,CAAC;QACpD,MAAM,UAAU,GAAG,WAAW,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,IAAA,iBAAS,EAAC,WAAW,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;QAE1E,IAAI,CAAC,UAAU,EAAE,CAAC;YAChB,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,OAAO;YACL,CAAC,IAAA,yBAAiB,EAAC,UAAU,CAAC,CAAC,CAC7B,IAA0C;gBAE1C,MAAM,YAAY,GAAG,eAAe,CAAC,IAAI,CAAC,CAAC;gBAC3C,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI,EAAE,YAAY;oBAClB,SAAS,EAAE,2BAAmB;oBAC9B,OAAO,EAAE;wBACP;4BACE,SAAS,EAAE,kCAA0B;4BACrC,GAAG,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,KAAK,CAAC,MAAM,CAAC,YAAY,CAAC;yBAC3C;qBACF;iBACF,CAAC,CAAC;YACL,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC;AAEH,SAAS,eAAe,CAAC,IAA0C;IACjE,MAAM,EAAE,MAAM,EAAE,GAAG,IAAI,CAAC;IACxB,MAAM,EAAE,MAAM,EAAE,WAAW,EAAE,GAAG,MAAM,CAAC;IACvC,OAAO,WAAW;QAChB,CAAC,IAAA,iCAAyB,EAAC,WAAW,CAAC,IAAI,IAAA,yBAAiB,EAAC,WAAW,CAAC,CAAC;QAC1E,CAAC,CAAC,IAAI;QACN,CAAC,CAAC,MAAM,CAAC;AACb,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  asPattern,\n  dispatchInEffects,\n  getNgRxStores,\n  isArrowFunctionExpression,\n  isReturnStatement,\n} from '../../utils';\n\nexport const noDispatchInEffects = 'noDispatchInEffects';\nexport const noDispatchInEffectsSuggest = 'noDispatchInEffectsSuggest';\n\ntype MessageIds =\n  | typeof noDispatchInEffects\n  | typeof noDispatchInEffectsSuggest;\ntype Options = readonly [];\ntype MemberExpressionWithinCallExpression = TSESTree.MemberExpression & {\n  parent: TSESTree.CallExpression;\n};\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    ngrxModule: 'effects',\n    hasSuggestions: true,\n    docs: {\n      description: '`Effect` should not call `store.dispatch`.',\n    },\n    schema: [],\n    messages: {\n      [noDispatchInEffects]:\n        'Calling `store.dispatch` in `Effect` is forbidden.',\n      [noDispatchInEffectsSuggest]: 'Remove `store.dispatch`.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const { identifiers = [] } = getNgRxStores(context);\n    const storeNames = identifiers.length > 0 ? asPattern(identifiers) : null;\n\n    if (!storeNames) {\n      return {};\n    }\n\n    return {\n      [dispatchInEffects(storeNames)](\n        node: MemberExpressionWithinCallExpression\n      ) {\n        const nodeToReport = getNodeToReport(node);\n        context.report({\n          node: nodeToReport,\n          messageId: noDispatchInEffects,\n          suggest: [\n            {\n              messageId: noDispatchInEffectsSuggest,\n              fix: (fixer) => fixer.remove(nodeToReport),\n            },\n          ],\n        });\n      },\n    };\n  },\n});\n\nfunction getNodeToReport(node: MemberExpressionWithinCallExpression) {\n  const { parent } = node;\n  const { parent: grandParent } = parent;\n  return grandParent &&\n    (isArrowFunctionExpression(grandParent) || isReturnStatement(grandParent))\n    ? node\n    : parent;\n}\n"]}

package/src/rules/effects/no-effects-in-providers.d.ts

@@ -0,0 +1,3 @@
+export declare const messageId = "noEffectsInProviders";
+declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<"noEffectsInProviders", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+export default _default;

package/src/rules/effects/no-effects-in-providers.js

@@ -22,23 +22,11 @@ var __importStar = (this && this.__importStar) || function (mod) {
     __setModuleDefault(result, mod);
     return result;
 };
-var __values = (this && this.__values) || function(o) {
-    var s = typeof Symbol === "function" && Symbol.iterator, m = s && o[s], i = 0;
-    if (m) return m.call(o);
-    if (o && typeof o.length === "number") return {
-        next: function () {
-            if (o && i >= o.length) o = void 0;
-            return { value: o && o[i++], done: !o };
-        }
-    };
-    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
-};
-var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.messageId = void 0;
-var path = __importStar(require("path"));
-var rule_creator_1 = require("../../rule-creator");
-var utils_1 = require("../../utils");
+const path = __importStar(require("path"));
+const rule_creator_1 = require("../../rule-creator");
+const utils_1 = require("../../utils");
 exports.messageId = 'noEffectsInProviders';
 exports.default = (0, rule_creator_1.createRule)({
     name: path.parse(__filename).name,
@@ -47,59 +35,40 @@ exports.default = (0, rule_creator_1.createRule)({
         ngrxModule: 'effects',
         docs: {
             description: '`Effect` should not be listed as a provider if it is added to the `EffectsModule`.',
-            recommended: 'error',
         },
         fixable: 'code',
         schema: [],
-        messages: (_a = {},
-            _a[exports.messageId] = '`Effect` should not be listed as a provider if it is added to the `EffectsModule`.',
-            _a),
+        messages: {
+            [exports.messageId]: '`Effect` should not be listed as a provider if it is added to the `EffectsModule`.',
+        },
     },
     defaultOptions: [],
-    create: function (context) {
-        var _a;
-        var sourceCode = context.getSourceCode();
-        var effectsInProviders = new Set();
-        var effectsInImports = new Set();
-        return _a = {},
-            _a[utils_1.effectsInNgModuleProviders] = function (node) {
+    create: (context) => {
+        const sourceCode = context.getSourceCode();
+        const effectsInProviders = new Set();
+        const effectsInImports = new Set();
+        return {
+            [utils_1.effectsInNgModuleProviders](node) {
                 effectsInProviders.add(node);
             },
-            _a[utils_1.effectsInNgModuleImports] = function (_a) {
-                var name = _a.name;
+            [utils_1.effectsInNgModuleImports]({ name }) {
                 effectsInImports.add(name);
             },
-            _a["".concat(utils_1.ngModuleDecorator, ":exit")] = function () {
-                var e_1, _a;
-                var _loop_1 = function (effectInProvider) {
+            [`${utils_1.ngModuleDecorator}:exit`]() {
+                for (const effectInProvider of effectsInProviders) {
                     if (!effectsInImports.has(effectInProvider.name)) {
-                        return "continue";
+                        continue;
                     }
                     context.report({
                         node: effectInProvider,
                         messageId: exports.messageId,
-                        fix: function (fixer) {
-                            return (0, utils_1.getNodeToCommaRemoveFix)(sourceCode, fixer, effectInProvider);
-                        },
+                        fix: (fixer) => (0, utils_1.getNodeToCommaRemoveFix)(sourceCode, fixer, effectInProvider),
                     });
-                };
-                try {
-                    for (var effectsInProviders_1 = __values(effectsInProviders), effectsInProviders_1_1 = effectsInProviders_1.next(); !effectsInProviders_1_1.done; effectsInProviders_1_1 = effectsInProviders_1.next()) {
-                        var effectInProvider = effectsInProviders_1_1.value;
-                        _loop_1(effectInProvider);
-                    }
-                }
-                catch (e_1_1) { e_1 = { error: e_1_1 }; }
-                finally {
-                    try {
-                        if (effectsInProviders_1_1 && !effectsInProviders_1_1.done && (_a = effectsInProviders_1.return)) _a.call(effectsInProviders_1);
-                    }
-                    finally { if (e_1) throw e_1.error; }
                 }
                 effectsInImports.clear();
                 effectsInProviders.clear();
             },
-            _a;
+        };
     },
 });
 //# sourceMappingURL=no-effects-in-providers.js.map

package/src/rules/effects/no-effects-in-providers.js.map

@@ -1 +1 @@
-{"version":3,"file":"no-effects-in-providers.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/effects/no-effects-in-providers.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AACA,yCAA6B;AAC7B,mDAAgD;AAChD,qCAKqB;AAER,QAAA,SAAS,GAAG,sBAAsB,CAAC;AAKhD,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EACT,oFAAoF;YACtF,WAAW,EAAE,OAAO;SACrB;QACD,OAAO,EAAE,MAAM;QACf,MAAM,EAAE,EAAE;QACV,QAAQ;YACN,GAAC,iBAAS,IACR,oFAAoF;eACvF;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,UAAC,OAAO;;QACd,IAAM,UAAU,GAAG,OAAO,CAAC,aAAa,EAAE,CAAC;QAC3C,IAAM,kBAAkB,GAAG,IAAI,GAAG,EAAuB,CAAC;QAC1D,IAAM,gBAAgB,GAAG,IAAI,GAAG,EAAU,CAAC;QAE3C;YACE,GAAC,kCAA0B,IAA3B,UAA6B,IAAyB;gBACpD,kBAAkB,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;YAC/B,CAAC;YACD,GAAC,gCAAwB,IAAzB,UAA2B,EAA6B;oBAA3B,IAAI,UAAA;gBAC/B,gBAAgB,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;YAC7B,CAAC;YACD,GAAC,UAAG,yBAAiB,UAAO,IAA5B;;wCACa,gBAAgB;oBACzB,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;;oBAEnD,CAAC;oBAED,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,gBAAgB;wBACtB,SAAS,mBAAA;wBACT,GAAG,EAAE,UAAC,KAAK;4BACT,OAAA,IAAA,+BAAuB,EAAC,UAAU,EAAE,KAAK,EAAE,gBAAgB,CAAC;wBAA5D,CAA4D;qBAC/D,CAAC,CAAC;;;oBAVL,KAA+B,IAAA,uBAAA,SAAA,kBAAkB,CAAA,sDAAA;wBAA5C,IAAM,gBAAgB,+BAAA;gCAAhB,gBAAgB;qBAW1B;;;;;;;;;gBAED,gBAAgB,CAAC,KAAK,EAAE,CAAC;gBACzB,kBAAkB,CAAC,KAAK,EAAE,CAAC;YAC7B,CAAC;eACD;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/experimental-utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  effectsInNgModuleImports,\n  effectsInNgModuleProviders,\n  getNodeToCommaRemoveFix,\n  ngModuleDecorator,\n} from '../../utils';\n\nexport const messageId = 'noEffectsInProviders';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'problem',\n    ngrxModule: 'effects',\n    docs: {\n      description:\n        '`Effect` should not be listed as a provider if it is added to the `EffectsModule`.',\n      recommended: 'error',\n    },\n    fixable: 'code',\n    schema: [],\n    messages: {\n      [messageId]:\n        '`Effect` should not be listed as a provider if it is added to the `EffectsModule`.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const sourceCode = context.getSourceCode();\n    const effectsInProviders = new Set<TSESTree.Identifier>();\n    const effectsInImports = new Set<string>();\n\n    return {\n      [effectsInNgModuleProviders](node: TSESTree.Identifier) {\n        effectsInProviders.add(node);\n      },\n      [effectsInNgModuleImports]({ name }: TSESTree.Identifier) {\n        effectsInImports.add(name);\n      },\n      [`${ngModuleDecorator}:exit`]() {\n        for (const effectInProvider of effectsInProviders) {\n          if (!effectsInImports.has(effectInProvider.name)) {\n            continue;\n          }\n\n          context.report({\n            node: effectInProvider,\n            messageId,\n            fix: (fixer) =>\n              getNodeToCommaRemoveFix(sourceCode, fixer, effectInProvider),\n          });\n        }\n\n        effectsInImports.clear();\n        effectsInProviders.clear();\n      },\n    };\n  },\n});\n"]}
+{"version":3,"file":"no-effects-in-providers.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/effects/no-effects-in-providers.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;AACA,2CAA6B;AAC7B,qDAAgD;AAChD,uCAKqB;AAER,QAAA,SAAS,GAAG,sBAAsB,CAAC;AAKhD,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EACT,oFAAoF;SACvF;QACD,OAAO,EAAE,MAAM;QACf,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,CAAC,iBAAS,CAAC,EACT,oFAAoF;SACvF;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,MAAM,UAAU,GAAG,OAAO,CAAC,aAAa,EAAE,CAAC;QAC3C,MAAM,kBAAkB,GAAG,IAAI,GAAG,EAAuB,CAAC;QAC1D,MAAM,gBAAgB,GAAG,IAAI,GAAG,EAAU,CAAC;QAE3C,OAAO;YACL,CAAC,kCAA0B,CAAC,CAAC,IAAyB;gBACpD,kBAAkB,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;YAC/B,CAAC;YACD,CAAC,gCAAwB,CAAC,CAAC,EAAE,IAAI,EAAuB;gBACtD,gBAAgB,CAAC,GAAG,CAAC,IAAI,CAAC,CAAC;YAC7B,CAAC;YACD,CAAC,GAAG,yBAAiB,OAAO,CAAC;gBAC3B,KAAK,MAAM,gBAAgB,IAAI,kBAAkB,EAAE,CAAC;oBAClD,IAAI,CAAC,gBAAgB,CAAC,GAAG,CAAC,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;wBACjD,SAAS;oBACX,CAAC;oBAED,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,gBAAgB;wBACtB,SAAS,EAAT,iBAAS;wBACT,GAAG,EAAE,CAAC,KAAK,EAAE,EAAE,CACb,IAAA,+BAAuB,EAAC,UAAU,EAAE,KAAK,EAAE,gBAAgB,CAAC;qBAC/D,CAAC,CAAC;gBACL,CAAC;gBAED,gBAAgB,CAAC,KAAK,EAAE,CAAC;gBACzB,kBAAkB,CAAC,KAAK,EAAE,CAAC;YAC7B,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  effectsInNgModuleImports,\n  effectsInNgModuleProviders,\n  getNodeToCommaRemoveFix,\n  ngModuleDecorator,\n} from '../../utils';\n\nexport const messageId = 'noEffectsInProviders';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'problem',\n    ngrxModule: 'effects',\n    docs: {\n      description:\n        '`Effect` should not be listed as a provider if it is added to the `EffectsModule`.',\n    },\n    fixable: 'code',\n    schema: [],\n    messages: {\n      [messageId]:\n        '`Effect` should not be listed as a provider if it is added to the `EffectsModule`.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const sourceCode = context.getSourceCode();\n    const effectsInProviders = new Set<TSESTree.Identifier>();\n    const effectsInImports = new Set<string>();\n\n    return {\n      [effectsInNgModuleProviders](node: TSESTree.Identifier) {\n        effectsInProviders.add(node);\n      },\n      [effectsInNgModuleImports]({ name }: TSESTree.Identifier) {\n        effectsInImports.add(name);\n      },\n      [`${ngModuleDecorator}:exit`]() {\n        for (const effectInProvider of effectsInProviders) {\n          if (!effectsInImports.has(effectInProvider.name)) {\n            continue;\n          }\n\n          context.report({\n            node: effectInProvider,\n            messageId,\n            fix: (fixer) =>\n              getNodeToCommaRemoveFix(sourceCode, fixer, effectInProvider),\n          });\n        }\n\n        effectsInImports.clear();\n        effectsInProviders.clear();\n      },\n    };\n  },\n});\n"]}

package/src/rules/effects/no-multiple-actions-in-effects.d.ts

@@ -0,0 +1,5 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+export declare const messageId = "noMultipleActionsInEffects";
+type Options = readonly unknown[];
+declare const _default: ESLintUtils.RuleModule<"noMultipleActionsInEffects", Options, unknown, ESLintUtils.RuleListener>;
+export default _default;

package/src/rules/effects/no-multiple-actions-in-effects.js

@@ -22,14 +22,12 @@ var __importStar = (this && this.__importStar) || function (mod) {
     __setModuleDefault(result, mod);
     return result;
 };
-var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.messageId = void 0;
-var experimental_utils_1 = require("@typescript-eslint/experimental-utils");
-var eslint_etc_1 = require("eslint-etc");
-var path = __importStar(require("path"));
-var rule_creator_1 = require("../../rule-creator");
-var utils_1 = require("../../utils");
+const utils_1 = require("@typescript-eslint/utils");
+const path = __importStar(require("path"));
+const rule_creator_1 = require("../../rule-creator");
+const utils_2 = require("../../utils");
 exports.messageId = 'noMultipleActionsInEffects';
 exports.default = (0, rule_creator_1.createRule)({
     name: path.parse(__filename).name,
@@ -38,37 +36,46 @@ exports.default = (0, rule_creator_1.createRule)({
         ngrxModule: 'effects',
         docs: {
             description: '`Effect` should not return multiple actions.',
-            recommended: 'warn',
             requiresTypeChecking: true,
         },
         schema: [],
-        messages: (_a = {},
-            _a[exports.messageId] = '`Effect` should return a single action.',
-            _a),
+        messages: {
+            [exports.messageId]: '`Effect` should return a single action.',
+        },
     },
     defaultOptions: [],
-    create: function (context) {
-        var _a;
-        return _a = {},
-            _a["".concat(utils_1.createEffectExpression, " :matches(").concat(utils_1.mapLikeOperatorsImplicitReturn, ", ").concat(utils_1.mapLikeOperatorsExplicitReturn, ")")] = function (node) {
-                var nodeToReport = getNodeToReport(node);
-                if (!nodeToReport ||
-                    !(0, eslint_etc_1.getTypeServices)(context).couldBeType(nodeToReport, 'Array')) {
+    create: (context) => {
+        return {
+            [`${utils_2.createEffectExpression} :matches(${utils_2.mapLikeOperatorsImplicitReturn}, ${utils_2.mapLikeOperatorsExplicitReturn})`](node) {
+                const nodeToReport = getNodeToReport(node);
+                if (!nodeToReport) {
                     return;
                 }
-                context.report({
-                    node: nodeToReport,
-                    messageId: exports.messageId,
-                });
+                const services = utils_1.ESLintUtils.getParserServices(context);
+                const typeChecker = services.program.getTypeChecker();
+                const type = services.getTypeAtLocation(nodeToReport);
+                if (typeChecker.isArrayType(type)) {
+                    context.report({
+                        node: nodeToReport,
+                        messageId: exports.messageId,
+                    });
+                }
+                else if (type.isUnion() &&
+                    type.types.some((ut) => !typeChecker.isArrayType(ut))) {
+                    context.report({
+                        node: nodeToReport,
+                        messageId: exports.messageId,
+                    });
+                }
             },
-            _a;
+        };
     },
 });
 function getNodeToReport(node) {
     switch (node.type) {
-        case experimental_utils_1.AST_NODE_TYPES.ArrowFunctionExpression:
+        case utils_1.AST_NODE_TYPES.ArrowFunctionExpression:
             return node.body;
-        case experimental_utils_1.AST_NODE_TYPES.CallExpression:
+        case utils_1.AST_NODE_TYPES.CallExpression:
             return node.arguments[0];
         default:
             return node.argument;

package/src/rules/effects/no-multiple-actions-in-effects.js.map

@@ -1 +1 @@
-{"version":3,"file":"no-multiple-actions-in-effects.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/effects/no-multiple-actions-in-effects.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;AACA,4EAAuE;AACvE,yCAA6C;AAC7C,yCAA6B;AAC7B,mDAAgD;AAChD,qCAIqB;AAER,QAAA,SAAS,GAAG,4BAA4B,CAAC;AAStD,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EAAE,8CAA8C;YAC3D,WAAW,EAAE,MAAM;YACnB,oBAAoB,EAAE,IAAI;SAC3B;QACD,MAAM,EAAE,EAAE;QACV,QAAQ;YACN,GAAC,iBAAS,IAAG,yCAAyC;eACvD;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,UAAC,OAAO;;QACd;YACE,GAAC,UAAG,8BAAsB,uBAAa,sCAA8B,eAAK,sCAA8B,MAAG,IAA3G,UACE,IAAmC;gBAEnC,IAAM,YAAY,GAAG,eAAe,CAAC,IAAI,CAAC,CAAC;gBAE3C,IACE,CAAC,YAAY;oBACb,CAAC,IAAA,4BAAe,EAAC,OAAO,CAAC,CAAC,WAAW,CAAC,YAAY,EAAE,OAAO,CAAC,EAC5D,CAAC;oBACD,OAAO;gBACT,CAAC;gBAED,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI,EAAE,YAAY;oBAClB,SAAS,mBAAA;iBACV,CAAC,CAAC;YACL,CAAC;eACD;IACJ,CAAC;CACF,CAAC,CAAC;AAEH,SAAS,eAAe,CAAC,IAAmC;IAC1D,QAAQ,IAAI,CAAC,IAAI,EAAE,CAAC;QAClB,KAAK,mCAAc,CAAC,uBAAuB;YACzC,OAAO,IAAI,CAAC,IAAI,CAAC;QACnB,KAAK,mCAAc,CAAC,cAAc;YAChC,OAAO,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;QAC3B;YACE,OAAO,IAAI,CAAC,QAAQ,CAAC;IACzB,CAAC;AACH,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/experimental-utils';\nimport { AST_NODE_TYPES } from '@typescript-eslint/experimental-utils';\nimport { getTypeServices } from 'eslint-etc';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  createEffectExpression,\n  mapLikeOperatorsExplicitReturn,\n  mapLikeOperatorsImplicitReturn,\n} from '../../utils';\n\nexport const messageId = 'noMultipleActionsInEffects';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\ntype EffectsMapLikeOperatorsReturn =\n  | TSESTree.ArrowFunctionExpression\n  | TSESTree.CallExpression\n  | TSESTree.ReturnStatement;\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'problem',\n    ngrxModule: 'effects',\n    docs: {\n      description: '`Effect` should not return multiple actions.',\n      recommended: 'warn',\n      requiresTypeChecking: true,\n    },\n    schema: [],\n    messages: {\n      [messageId]: '`Effect` should return a single action.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    return {\n      [`${createEffectExpression} :matches(${mapLikeOperatorsImplicitReturn}, ${mapLikeOperatorsExplicitReturn})`](\n        node: EffectsMapLikeOperatorsReturn\n      ) {\n        const nodeToReport = getNodeToReport(node);\n\n        if (\n          !nodeToReport ||\n          !getTypeServices(context).couldBeType(nodeToReport, 'Array')\n        ) {\n          return;\n        }\n\n        context.report({\n          node: nodeToReport,\n          messageId,\n        });\n      },\n    };\n  },\n});\n\nfunction getNodeToReport(node: EffectsMapLikeOperatorsReturn) {\n  switch (node.type) {\n    case AST_NODE_TYPES.ArrowFunctionExpression:\n      return node.body;\n    case AST_NODE_TYPES.CallExpression:\n      return node.arguments[0];\n    default:\n      return node.argument;\n  }\n}\n"]}
+{"version":3,"file":"no-multiple-actions-in-effects.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/effects/no-multiple-actions-in-effects.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;AAAA,oDAIkC;AAClC,2CAA6B;AAC7B,qDAAgD;AAChD,uCAIqB;AAER,QAAA,SAAS,GAAG,4BAA4B,CAAC;AAStD,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EAAE,8CAA8C;YAC3D,oBAAoB,EAAE,IAAI;SAC3B;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,CAAC,iBAAS,CAAC,EAAE,yCAAyC;SACvD;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,OAAO;YACL,CAAC,GAAG,8BAAsB,aAAa,sCAA8B,KAAK,sCAA8B,GAAG,CAAC,CAC1G,IAAmC;gBAEnC,MAAM,YAAY,GAAG,eAAe,CAAC,IAAI,CAAC,CAAC;gBAC3C,IAAI,CAAC,YAAY,EAAE,CAAC;oBAClB,OAAO;gBACT,CAAC;gBAED,MAAM,QAAQ,GAAG,mBAAW,CAAC,iBAAiB,CAAC,OAAO,CAAC,CAAC;gBACxD,MAAM,WAAW,GAAG,QAAQ,CAAC,OAAO,CAAC,cAAc,EAAE,CAAC;gBACtD,MAAM,IAAI,GAAG,QAAQ,CAAC,iBAAiB,CAAC,YAAY,CAAC,CAAC;gBAEtD,IAAI,WAAW,CAAC,WAAW,CAAC,IAAI,CAAC,EAAE,CAAC;oBAClC,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,YAAY;wBAClB,SAAS,EAAT,iBAAS;qBACV,CAAC,CAAC;gBACL,CAAC;qBAAM,IACL,IAAI,CAAC,OAAO,EAAE;oBACd,IAAI,CAAC,KAAK,CAAC,IAAI,CAAC,CAAC,EAAE,EAAE,EAAE,CAAC,CAAC,WAAW,CAAC,WAAW,CAAC,EAAE,CAAC,CAAC,EACrD,CAAC;oBACD,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,YAAY;wBAClB,SAAS,EAAT,iBAAS;qBACV,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC;AAEH,SAAS,eAAe,CAAC,IAAmC;IAC1D,QAAQ,IAAI,CAAC,IAAI,EAAE,CAAC;QAClB,KAAK,sBAAc,CAAC,uBAAuB;YACzC,OAAO,IAAI,CAAC,IAAI,CAAC;QACnB,KAAK,sBAAc,CAAC,cAAc;YAChC,OAAO,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC;QAC3B;YACE,OAAO,IAAI,CAAC,QAAQ,CAAC;IACzB,CAAC;AACH,CAAC","sourcesContent":["import {\n  AST_NODE_TYPES,\n  ESLintUtils,\n  type TSESTree,\n} from '@typescript-eslint/utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  createEffectExpression,\n  mapLikeOperatorsExplicitReturn,\n  mapLikeOperatorsImplicitReturn,\n} from '../../utils';\n\nexport const messageId = 'noMultipleActionsInEffects';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly unknown[];\ntype EffectsMapLikeOperatorsReturn =\n  | TSESTree.ArrowFunctionExpression\n  | TSESTree.CallExpression\n  | TSESTree.ReturnStatement;\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'problem',\n    ngrxModule: 'effects',\n    docs: {\n      description: '`Effect` should not return multiple actions.',\n      requiresTypeChecking: true,\n    },\n    schema: [],\n    messages: {\n      [messageId]: '`Effect` should return a single action.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    return {\n      [`${createEffectExpression} :matches(${mapLikeOperatorsImplicitReturn}, ${mapLikeOperatorsExplicitReturn})`](\n        node: EffectsMapLikeOperatorsReturn\n      ) {\n        const nodeToReport = getNodeToReport(node);\n        if (!nodeToReport) {\n          return;\n        }\n\n        const services = ESLintUtils.getParserServices(context);\n        const typeChecker = services.program.getTypeChecker();\n        const type = services.getTypeAtLocation(nodeToReport);\n\n        if (typeChecker.isArrayType(type)) {\n          context.report({\n            node: nodeToReport,\n            messageId,\n          });\n        } else if (\n          type.isUnion() &&\n          type.types.some((ut) => !typeChecker.isArrayType(ut))\n        ) {\n          context.report({\n            node: nodeToReport,\n            messageId,\n          });\n        }\n      },\n    };\n  },\n});\n\nfunction getNodeToReport(node: EffectsMapLikeOperatorsReturn) {\n  switch (node.type) {\n    case AST_NODE_TYPES.ArrowFunctionExpression:\n      return node.body;\n    case AST_NODE_TYPES.CallExpression:\n      return node.arguments[0];\n    default:\n      return node.argument;\n  }\n}\n"]}

package/src/rules/effects/prefer-action-creator-in-of-type.d.ts

@@ -0,0 +1,3 @@
+export declare const messageId = "preferActionCreatorInOfType";
+declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferActionCreatorInOfType", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+export default _default;

package/src/rules/effects/prefer-action-creator-in-of-type.js

@@ -22,11 +22,10 @@ var __importStar = (this && this.__importStar) || function (mod) {
     __setModuleDefault(result, mod);
     return result;
 };
-var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.messageId = void 0;
-var path = __importStar(require("path"));
-var rule_creator_1 = require("../../rule-creator");
+const path = __importStar(require("path"));
+const rule_creator_1 = require("../../rule-creator");
 exports.messageId = 'preferActionCreatorInOfType';
 exports.default = (0, rule_creator_1.createRule)({
     name: path.parse(__filename).name,
@@ -35,24 +34,22 @@ exports.default = (0, rule_creator_1.createRule)({
         ngrxModule: 'effects',
         docs: {
             description: 'Using `action creator` in `ofType` is preferred over `string`.',
-            recommended: 'warn',
         },
         schema: [],
-        messages: (_a = {},
-            _a[exports.messageId] = 'Using `string` is forbidden. Use `action creator` instead.',
-            _a),
+        messages: {
+            [exports.messageId]: 'Using `string` is forbidden. Use `action creator` instead.',
+        },
     },
     defaultOptions: [],
-    create: function (context) {
-        var _a;
-        return _a = {},
-            _a["CallExpression[callee.name='ofType'] Literal"] = function (node) {
+    create: (context) => {
+        return {
+            [`CallExpression[callee.name='ofType'] Literal`](node) {
                 context.report({
-                    node: node,
+                    node,
                     messageId: exports.messageId,
                 });
             },
-            _a;
+        };
     },
 });
 //# sourceMappingURL=prefer-action-creator-in-of-type.js.map

package/src/rules/effects/prefer-action-creator-in-of-type.js.map

@@ -1 +1 @@
-{"version":3,"file":"prefer-action-creator-in-of-type.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/effects/prefer-action-creator-in-of-type.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;AACA,yCAA6B;AAC7B,mDAAgD;AAEnC,QAAA,SAAS,GAAG,6BAA6B,CAAC;AAKvD,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EACT,gEAAgE;YAClE,WAAW,EAAE,MAAM;SACpB;QACD,MAAM,EAAE,EAAE;QACV,QAAQ;YACN,GAAC,iBAAS,IAAG,4DAA4D;eAC1E;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,UAAC,OAAO;;QACd;YACE,GAAC,8CAA8C,IAA/C,UAAiD,IAAsB;gBACrE,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI,MAAA;oBACJ,SAAS,mBAAA;iBACV,CAAC,CAAC;YACL,CAAC;eACD;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/experimental-utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\n\nexport const messageId = 'preferActionCreatorInOfType';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    ngrxModule: 'effects',\n    docs: {\n      description:\n        'Using `action creator` in `ofType` is preferred over `string`.',\n      recommended: 'warn',\n    },\n    schema: [],\n    messages: {\n      [messageId]: 'Using `string` is forbidden. Use `action creator` instead.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    return {\n      [`CallExpression[callee.name='ofType'] Literal`](node: TSESTree.Literal) {\n        context.report({\n          node,\n          messageId,\n        });\n      },\n    };\n  },\n});\n"]}
+{"version":3,"file":"prefer-action-creator-in-of-type.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/effects/prefer-action-creator-in-of-type.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;AACA,2CAA6B;AAC7B,qDAAgD;AAEnC,QAAA,SAAS,GAAG,6BAA6B,CAAC;AAKvD,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EACT,gEAAgE;SACnE;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,CAAC,iBAAS,CAAC,EAAE,4DAA4D;SAC1E;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,OAAO;YACL,CAAC,8CAA8C,CAAC,CAAC,IAAsB;gBACrE,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI;oBACJ,SAAS,EAAT,iBAAS;iBACV,CAAC,CAAC;YACL,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\n\nexport const messageId = 'preferActionCreatorInOfType';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    ngrxModule: 'effects',\n    docs: {\n      description:\n        'Using `action creator` in `ofType` is preferred over `string`.',\n    },\n    schema: [],\n    messages: {\n      [messageId]: 'Using `string` is forbidden. Use `action creator` instead.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    return {\n      [`CallExpression[callee.name='ofType'] Literal`](node: TSESTree.Literal) {\n        context.report({\n          node,\n          messageId,\n        });\n      },\n    };\n  },\n});\n"]}

package/src/rules/effects/prefer-effect-callback-in-block-statement.d.ts

@@ -0,0 +1,4 @@
+import type { TSESLint } from '@typescript-eslint/utils';
+export declare const messageId = "preferEffectCallbackInBlockStatement";
+declare const _default: TSESLint.RuleModule<"preferEffectCallbackInBlockStatement", readonly [], unknown, TSESLint.RuleListener>;
+export default _default;

package/src/rules/effects/prefer-effect-callback-in-block-statement.js

@@ -22,29 +22,12 @@ var __importStar = (this && this.__importStar) || function (mod) {
     __setModuleDefault(result, mod);
     return result;
 };
-var __read = (this && this.__read) || function (o, n) {
-    var m = typeof Symbol === "function" && o[Symbol.iterator];
-    if (!m) return o;
-    var i = m.call(o), r, ar = [], e;
-    try {
-        while ((n === void 0 || n-- > 0) && !(r = i.next()).done) ar.push(r.value);
-    }
-    catch (error) { e = { error: error }; }
-    finally {
-        try {
-            if (r && !r.done && (m = i["return"])) m.call(i);
-        }
-        finally { if (e) throw e.error; }
-    }
-    return ar;
-};
-var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.messageId = void 0;
-var experimental_utils_1 = require("@typescript-eslint/experimental-utils");
-var path = __importStar(require("path"));
-var rule_creator_1 = require("../../rule-creator");
-var utils_1 = require("../../utils");
+const utils_1 = require("@typescript-eslint/utils");
+const path = __importStar(require("path"));
+const rule_creator_1 = require("../../rule-creator");
+const utils_2 = require("../../utils");
 exports.messageId = 'preferEffectCallbackInBlockStatement';
 exports.default = (0, rule_creator_1.createRule)({
     name: path.parse(__filename).name,
@@ -53,45 +36,43 @@ exports.default = (0, rule_creator_1.createRule)({
         ngrxModule: 'effects',
         docs: {
             description: 'A block statement is easier to troubleshoot.',
-            recommended: 'warn',
         },
         schema: [],
-        messages: (_a = {},
-            _a[exports.messageId] = 'The callback of `Effect` should be wrapped in a block statement.',
-            _a),
+        messages: {
+            [exports.messageId]: 'The callback of `Effect` should be wrapped in a block statement.',
+        },
         fixable: 'code',
     },
     defaultOptions: [],
-    create: function (context) {
-        var _a;
-        var sourceCode = context.getSourceCode();
-        var nonParametrizedEffect = "".concat(utils_1.createEffectExpression, " > ArrowFunctionExpression > .body[type!=/^(ArrowFunctionExpression|BlockStatement)$/]");
-        var parametrizedEffect = "".concat(utils_1.createEffectExpression, " > ArrowFunctionExpression > ArrowFunctionExpression > .body[type!='BlockStatement']");
-        var parametrizedEffectWithinBlockStatement = "".concat(utils_1.createEffectExpression, " > ArrowFunctionExpression > BlockStatement > ReturnStatement > ArrowFunctionExpression > .body[type!='BlockStatement']");
-        return _a = {},
-            _a["".concat(nonParametrizedEffect, ", ").concat(parametrizedEffect, ", ").concat(parametrizedEffectWithinBlockStatement)] = function (node) {
+    create: (context) => {
+        const sourceCode = context.getSourceCode();
+        const nonParametrizedEffect = `${utils_2.createEffectExpression} > ArrowFunctionExpression > .body[type!=/^(ArrowFunctionExpression|BlockStatement)$/]`;
+        const parametrizedEffect = `${utils_2.createEffectExpression} > ArrowFunctionExpression > ArrowFunctionExpression > .body[type!='BlockStatement']`;
+        const parametrizedEffectWithinBlockStatement = `${utils_2.createEffectExpression} > ArrowFunctionExpression > BlockStatement > ReturnStatement > ArrowFunctionExpression > .body[type!='BlockStatement']`;
+        return {
+            [`${nonParametrizedEffect}, ${parametrizedEffect}, ${parametrizedEffectWithinBlockStatement}`](node) {
                 context.report({
-                    node: node,
+                    node,
                     messageId: exports.messageId,
-                    fix: function (fixer) {
-                        var _a = __read(getSafeNodesToApplyFix(sourceCode, node), 2), previousNode = _a[0], nextNode = _a[1];
+                    fix: (fixer) => {
+                        const [previousNode, nextNode] = getSafeNodesToApplyFix(sourceCode, node);
                         return [
-                            fixer.insertTextBefore(previousNode, "{ return "),
-                            fixer.insertTextAfter(nextNode, " }"),
+                            fixer.insertTextBefore(previousNode, `{ return `),
+                            fixer.insertTextAfter(nextNode, ` }`),
                         ];
                     },
                 });
             },
-            _a;
+        };
     },
 });
 function getSafeNodesToApplyFix(sourceCode, node) {
-    var previousToken = sourceCode.getTokenBefore(node);
-    var nextToken = sourceCode.getTokenAfter(node);
+    const previousToken = sourceCode.getTokenBefore(node);
+    const nextToken = sourceCode.getTokenAfter(node);
     if (previousToken &&
-        experimental_utils_1.ASTUtils.isOpeningParenToken(previousToken) &&
+        utils_1.ASTUtils.isOpeningParenToken(previousToken) &&
         nextToken &&
-        experimental_utils_1.ASTUtils.isClosingParenToken(nextToken)) {
+        utils_1.ASTUtils.isClosingParenToken(nextToken)) {
         return [previousToken, nextToken];
     }
     return [node, node];

package/src/rules/effects/prefer-effect-callback-in-block-statement.js.map

@@ -1 +1 @@
-{"version":3,"file":"prefer-effect-callback-in-block-statement.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/effects/prefer-effect-callback-in-block-statement.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AACA,4EAAiE;AACjE,yCAA6B;AAC7B,mDAAgD;AAChD,qCAAqD;AAExC,QAAA,SAAS,GAAG,sCAAsC,CAAC;AAKhE,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EAAE,8CAA8C;YAC3D,WAAW,EAAE,MAAM;SACpB;QACD,MAAM,EAAE,EAAE;QACV,QAAQ;YACN,GAAC,iBAAS,IACR,kEAAkE;eACrE;QACD,OAAO,EAAE,MAAM;KAChB;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,UAAC,OAAO;;QACd,IAAM,UAAU,GAAG,OAAO,CAAC,aAAa,EAAE,CAAC;QAC3C,IAAM,qBAAqB,GACzB,UAAG,8BAAsB,2FAAiG,CAAC;QAC7H,IAAM,kBAAkB,GACtB,UAAG,8BAAsB,yFAA+F,CAAC;QAC3H,IAAM,sCAAsC,GAC1C,UAAG,8BAAsB,4HAAkI,CAAC;QAE9J;YACE,GAAC,UAAG,qBAAqB,eAAK,kBAAkB,eAAK,sCAAsC,CAAE,IAA7F,UACE,IAA8C;gBAE9C,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI,MAAA;oBACJ,SAAS,mBAAA;oBACT,GAAG,EAAE,UAAC,KAAK;wBACH,IAAA,KAAA,OAA2B,sBAAsB,CACrD,UAAU,EACV,IAAI,CACL,IAAA,EAHM,YAAY,QAAA,EAAE,QAAQ,QAG5B,CAAC;wBACF,OAAO;4BACL,KAAK,CAAC,gBAAgB,CAAC,YAAY,EAAE,WAAW,CAAC;4BACjD,KAAK,CAAC,eAAe,CAAC,QAAQ,EAAE,IAAI,CAAC;yBACtC,CAAC;oBACJ,CAAC;iBACF,CAAC,CAAC;YACL,CAAC;eACD;IACJ,CAAC;CACF,CAAC,CAAC;AAEH,SAAS,sBAAsB,CAC7B,UAAyC,EACzC,IAAmB;IAEnB,IAAM,aAAa,GAAG,UAAU,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC;IACtD,IAAM,SAAS,GAAG,UAAU,CAAC,aAAa,CAAC,IAAI,CAAC,CAAC;IAEjD,IACE,aAAa;QACb,6BAAQ,CAAC,mBAAmB,CAAC,aAAa,CAAC;QAC3C,SAAS;QACT,6BAAQ,CAAC,mBAAmB,CAAC,SAAS,CAAC,EACvC,CAAC;QACD,OAAO,CAAC,aAAa,EAAE,SAAS,CAAU,CAAC;IAC7C,CAAC;IAED,OAAO,CAAC,IAAI,EAAE,IAAI,CAAU,CAAC;AAC/B,CAAC","sourcesContent":["import type { TSESLint, TSESTree } from '@typescript-eslint/experimental-utils';\nimport { ASTUtils } from '@typescript-eslint/experimental-utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport { createEffectExpression } from '../../utils';\n\nexport const messageId = 'preferEffectCallbackInBlockStatement';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    ngrxModule: 'effects',\n    docs: {\n      description: 'A block statement is easier to troubleshoot.',\n      recommended: 'warn',\n    },\n    schema: [],\n    messages: {\n      [messageId]:\n        'The callback of `Effect` should be wrapped in a block statement.',\n    },\n    fixable: 'code',\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const sourceCode = context.getSourceCode();\n    const nonParametrizedEffect =\n      `${createEffectExpression} > ArrowFunctionExpression > .body[type!=/^(ArrowFunctionExpression|BlockStatement)$/]` as const;\n    const parametrizedEffect =\n      `${createEffectExpression} > ArrowFunctionExpression > ArrowFunctionExpression > .body[type!='BlockStatement']` as const;\n    const parametrizedEffectWithinBlockStatement =\n      `${createEffectExpression} > ArrowFunctionExpression > BlockStatement > ReturnStatement > ArrowFunctionExpression > .body[type!='BlockStatement']` as const;\n\n    return {\n      [`${nonParametrizedEffect}, ${parametrizedEffect}, ${parametrizedEffectWithinBlockStatement}`](\n        node: TSESTree.ArrowFunctionExpression['body']\n      ) {\n        context.report({\n          node,\n          messageId,\n          fix: (fixer) => {\n            const [previousNode, nextNode] = getSafeNodesToApplyFix(\n              sourceCode,\n              node\n            );\n            return [\n              fixer.insertTextBefore(previousNode, `{ return `),\n              fixer.insertTextAfter(nextNode, ` }`),\n            ];\n          },\n        });\n      },\n    };\n  },\n});\n\nfunction getSafeNodesToApplyFix(\n  sourceCode: Readonly<TSESLint.SourceCode>,\n  node: TSESTree.Node\n) {\n  const previousToken = sourceCode.getTokenBefore(node);\n  const nextToken = sourceCode.getTokenAfter(node);\n\n  if (\n    previousToken &&\n    ASTUtils.isOpeningParenToken(previousToken) &&\n    nextToken &&\n    ASTUtils.isClosingParenToken(nextToken)\n  ) {\n    return [previousToken, nextToken] as const;\n  }\n\n  return [node, node] as const;\n}\n"]}
+{"version":3,"file":"prefer-effect-callback-in-block-statement.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/effects/prefer-effect-callback-in-block-statement.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;AACA,oDAAoD;AACpD,2CAA6B;AAC7B,qDAAgD;AAChD,uCAAqD;AAExC,QAAA,SAAS,GAAG,sCAAsC,CAAC;AAKhE,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EAAE,8CAA8C;SAC5D;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,CAAC,iBAAS,CAAC,EACT,kEAAkE;SACrE;QACD,OAAO,EAAE,MAAM;KAChB;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,MAAM,UAAU,GAAG,OAAO,CAAC,aAAa,EAAE,CAAC;QAC3C,MAAM,qBAAqB,GACzB,GAAG,8BAAsB,wFAAiG,CAAC;QAC7H,MAAM,kBAAkB,GACtB,GAAG,8BAAsB,sFAA+F,CAAC;QAC3H,MAAM,sCAAsC,GAC1C,GAAG,8BAAsB,yHAAkI,CAAC;QAE9J,OAAO;YACL,CAAC,GAAG,qBAAqB,KAAK,kBAAkB,KAAK,sCAAsC,EAAE,CAAC,CAC5F,IAA8C;gBAE9C,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI;oBACJ,SAAS,EAAT,iBAAS;oBACT,GAAG,EAAE,CAAC,KAAK,EAAE,EAAE;wBACb,MAAM,CAAC,YAAY,EAAE,QAAQ,CAAC,GAAG,sBAAsB,CACrD,UAAU,EACV,IAAI,CACL,CAAC;wBACF,OAAO;4BACL,KAAK,CAAC,gBAAgB,CAAC,YAAY,EAAE,WAAW,CAAC;4BACjD,KAAK,CAAC,eAAe,CAAC,QAAQ,EAAE,IAAI,CAAC;yBACtC,CAAC;oBACJ,CAAC;iBACF,CAAC,CAAC;YACL,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC;AAEH,SAAS,sBAAsB,CAC7B,UAAyC,EACzC,IAAmB;IAEnB,MAAM,aAAa,GAAG,UAAU,CAAC,cAAc,CAAC,IAAI,CAAC,CAAC;IACtD,MAAM,SAAS,GAAG,UAAU,CAAC,aAAa,CAAC,IAAI,CAAC,CAAC;IAEjD,IACE,aAAa;QACb,gBAAQ,CAAC,mBAAmB,CAAC,aAAa,CAAC;QAC3C,SAAS;QACT,gBAAQ,CAAC,mBAAmB,CAAC,SAAS,CAAC,EACvC,CAAC;QACD,OAAO,CAAC,aAAa,EAAE,SAAS,CAAU,CAAC;IAC7C,CAAC;IAED,OAAO,CAAC,IAAI,EAAE,IAAI,CAAU,CAAC;AAC/B,CAAC","sourcesContent":["import type { TSESLint, TSESTree } from '@typescript-eslint/utils';\nimport { ASTUtils } from '@typescript-eslint/utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport { createEffectExpression } from '../../utils';\n\nexport const messageId = 'preferEffectCallbackInBlockStatement';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    ngrxModule: 'effects',\n    docs: {\n      description: 'A block statement is easier to troubleshoot.',\n    },\n    schema: [],\n    messages: {\n      [messageId]:\n        'The callback of `Effect` should be wrapped in a block statement.',\n    },\n    fixable: 'code',\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const sourceCode = context.getSourceCode();\n    const nonParametrizedEffect =\n      `${createEffectExpression} > ArrowFunctionExpression > .body[type!=/^(ArrowFunctionExpression|BlockStatement)$/]` as const;\n    const parametrizedEffect =\n      `${createEffectExpression} > ArrowFunctionExpression > ArrowFunctionExpression > .body[type!='BlockStatement']` as const;\n    const parametrizedEffectWithinBlockStatement =\n      `${createEffectExpression} > ArrowFunctionExpression > BlockStatement > ReturnStatement > ArrowFunctionExpression > .body[type!='BlockStatement']` as const;\n\n    return {\n      [`${nonParametrizedEffect}, ${parametrizedEffect}, ${parametrizedEffectWithinBlockStatement}`](\n        node: TSESTree.ArrowFunctionExpression['body']\n      ) {\n        context.report({\n          node,\n          messageId,\n          fix: (fixer) => {\n            const [previousNode, nextNode] = getSafeNodesToApplyFix(\n              sourceCode,\n              node\n            );\n            return [\n              fixer.insertTextBefore(previousNode, `{ return `),\n              fixer.insertTextAfter(nextNode, ` }`),\n            ];\n          },\n        });\n      },\n    };\n  },\n});\n\nfunction getSafeNodesToApplyFix(\n  sourceCode: Readonly<TSESLint.SourceCode>,\n  node: TSESTree.Node\n) {\n  const previousToken = sourceCode.getTokenBefore(node);\n  const nextToken = sourceCode.getTokenAfter(node);\n\n  if (\n    previousToken &&\n    ASTUtils.isOpeningParenToken(previousToken) &&\n    nextToken &&\n    ASTUtils.isClosingParenToken(nextToken)\n  ) {\n    return [previousToken, nextToken] as const;\n  }\n\n  return [node, node] as const;\n}\n"]}

package/src/rules/effects/use-effects-lifecycle-interface.d.ts

@@ -0,0 +1,3 @@
+export declare const messageId = "useEffectsLifecycleInterface";
+declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<"useEffectsLifecycleInterface", readonly [], unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+export default _default;