@ngrx/eslint-plugin 18.0.0-beta.1 → 18.0.0-rc.0

package/src/rules/signals/with-state-no-arrays-at-root-level.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"with-state-no-arrays-at-root-level.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/signals/with-state-no-arrays-at-root-level.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;AAAA,oDAAsE;AACtE,2CAA6B;AAC7B,qDAAgD;AAChD,uCAAgD;AAEnC,QAAA,SAAS,GAAG,8BAA8B,CAAC;AAKxD,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EAAE,sEAAsE;YACnF,oBAAoB,EAAE,IAAI;SAC3B;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,CAAC,iBAAS,CAAC,EAAE,4CAA4C;SAC1D;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,OAAO;YACL,CAAC,uCAAuC,CAAC,CAAC,IAA6B;gBACrE,MAAM,CAAC,QAAQ,CAAC,GAAG,IAAI,CAAC,SAAS,CAAC;gBAClC,IAAI,IAAA,yBAAiB,EAAC,QAAQ,CAAC,EAAE,CAAC;oBAChC,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,QAAQ;wBACd,SAAS,EAAT,iBAAS;qBACV,CAAC,CAAC;gBACL,CAAC;qBAAM,IAAI,QAAQ,EAAE,CAAC;oBACpB,MAAM,QAAQ,GAAG,mBAAW,CAAC,iBAAiB,CAAC,OAAO,CAAC,CAAC;oBACxD,MAAM,WAAW,GAAG,QAAQ,CAAC,OAAO,CAAC,cAAc,EAAE,CAAC;oBACtD,MAAM,IAAI,GAAG,QAAQ,CAAC,iBAAiB,CAAC,QAAQ,CAAC,CAAC;oBAElD,IAAI,WAAW,CAAC,WAAW,CAAC,IAAI,CAAC,EAAE,CAAC;wBAClC,OAAO,CAAC,MAAM,CAAC;4BACb,IAAI,EAAE,QAAQ;4BACd,SAAS,EAAT,iBAAS;yBACV,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import { ESLintUtils, type TSESTree } from '@typescript-eslint/utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport { isArrayExpression } from '../../utils';\n\nexport const messageId = 'withStateNoArraysAtRootLevel';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'problem',\n    ngrxModule: 'signals',\n    docs: {\n      description: `withState should accept a record or dictionary as an input argument.`,\n      requiresTypeChecking: true,\n    },\n    schema: [],\n    messages: {\n      [messageId]: `Wrap the array in an record or dictionary.`,\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    return {\n      [`CallExpression[callee.name=withState]`](node: TSESTree.CallExpression) {\n        const [argument] = node.arguments;\n        if (isArrayExpression(argument)) {\n          context.report({\n            node: argument,\n            messageId,\n          });\n        } else if (argument) {\n          const services = ESLintUtils.getParserServices(context);\n          const typeChecker = services.program.getTypeChecker();\n          const type = services.getTypeAtLocation(argument);\n\n          if (typeChecker.isArrayType(type)) {\n            context.report({\n              node: argument,\n              messageId,\n            });\n          }\n        }\n      },\n    };\n  },\n});\n"]}

package/src/rules/store/avoid-combining-selectors.d.ts

@@ -0,0 +1,3 @@
+export declare const messageId = "avoidCombiningSelectors";
+declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<"avoidCombiningSelectors", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+export default _default;

package/src/rules/store/avoid-combining-selectors.js

@@ -22,23 +22,11 @@ var __importStar = (this && this.__importStar) || function (mod) {
     __setModuleDefault(result, mod);
     return result;
 };
-var __values = (this && this.__values) || function(o) {
-    var s = typeof Symbol === "function" && Symbol.iterator, m = s && o[s], i = 0;
-    if (m) return m.call(o);
-    if (o && typeof o.length === "number") return {
-        next: function () {
-            if (o && i >= o.length) o = void 0;
-            return { value: o && o[i++], done: !o };
-        }
-    };
-    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
-};
-var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.messageId = void 0;
-var path = __importStar(require("path"));
-var rule_creator_1 = require("../../rule-creator");
-var utils_1 = require("../../utils");
+const path = __importStar(require("path"));
+const rule_creator_1 = require("../../rule-creator");
+const utils_1 = require("../../utils");
 exports.messageId = 'avoidCombiningSelectors';
 exports.default = (0, rule_creator_1.createRule)({
     name: path.parse(__filename).name,
@@ -47,48 +35,35 @@ exports.default = (0, rule_creator_1.createRule)({
         ngrxModule: 'store',
         docs: {
             description: 'Prefer combining selectors at the selector level.',
-            recommended: 'warn',
         },
         schema: [],
-        messages: (_a = {},
-            _a[exports.messageId] = 'Combine selectors at the selector level.',
-            _a),
+        messages: {
+            [exports.messageId]: 'Combine selectors at the selector level.',
+        },
     },
     defaultOptions: [],
-    create: function (context) {
-        var _a;
-        var _b = (0, utils_1.getNgRxStores)(context).identifiers, identifiers = _b === void 0 ? [] : _b;
-        var storeNames = identifiers.length > 0 ? (0, utils_1.asPattern)(identifiers) : null;
+    create: (context) => {
+        const { identifiers = [] } = (0, utils_1.getNgRxStores)(context);
+        const storeNames = identifiers.length > 0 ? (0, utils_1.asPattern)(identifiers) : null;
         if (!storeNames) {
             return {};
         }
-        var pipeableOrStoreSelect = ":matches(".concat((0, utils_1.namedExpression)(storeNames), "[callee.property.name='pipe']:has(CallExpression[callee.name='select']), ").concat((0, utils_1.selectExpression)(storeNames), ")");
-        var selectsInArray = [];
-        return _a = {},
-            _a["CallExpression[callee.name='combineLatest'] ".concat(pipeableOrStoreSelect, " ~ ").concat(pipeableOrStoreSelect)] = function (node) {
+        const pipeableOrStoreSelect = `:matches(${(0, utils_1.namedExpression)(storeNames)}[callee.property.name='pipe']:has(CallExpression[callee.name='select']), ${(0, utils_1.selectExpression)(storeNames)})`;
+        const selectsInArray = [];
+        return {
+            [`CallExpression[callee.name='combineLatest'] ${pipeableOrStoreSelect} ~ ${pipeableOrStoreSelect}`](node) {
                 selectsInArray.push(node);
             },
-            _a["CallExpression[callee.name='combineLatest']:exit"] = function () {
-                var e_1, _a;
-                try {
-                    for (var selectsInArray_1 = __values(selectsInArray), selectsInArray_1_1 = selectsInArray_1.next(); !selectsInArray_1_1.done; selectsInArray_1_1 = selectsInArray_1.next()) {
-                        var node = selectsInArray_1_1.value;
-                        context.report({
-                            node: node,
-                            messageId: exports.messageId,
-                        });
-                    }
-                }
-                catch (e_1_1) { e_1 = { error: e_1_1 }; }
-                finally {
-                    try {
-                        if (selectsInArray_1_1 && !selectsInArray_1_1.done && (_a = selectsInArray_1.return)) _a.call(selectsInArray_1);
-                    }
-                    finally { if (e_1) throw e_1.error; }
+            [`CallExpression[callee.name='combineLatest']:exit`]() {
+                for (const node of selectsInArray) {
+                    context.report({
+                        node,
+                        messageId: exports.messageId,
+                    });
                 }
                 selectsInArray.length = 0;
             },
-            _a;
+        };
     },
 });
 //# sourceMappingURL=avoid-combining-selectors.js.map

package/src/rules/store/avoid-combining-selectors.js.map

@@ -1 +1 @@
-{"version":3,"file":"avoid-combining-selectors.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/store/avoid-combining-selectors.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AACA,yCAA6B;AAC7B,mDAAgD;AAChD,qCAKqB;AAER,QAAA,SAAS,GAAG,yBAAyB,CAAC;AAKnD,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,UAAU,EAAE,OAAO;QACnB,IAAI,EAAE;YACJ,WAAW,EAAE,mDAAmD;YAChE,WAAW,EAAE,MAAM;SACpB;QACD,MAAM,EAAE,EAAE;QACV,QAAQ;YACN,GAAC,iBAAS,IAAG,0CAA0C;eACxD;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,UAAC,OAAO;;QACN,IAAA,KAAqB,IAAA,qBAAa,EAAC,OAAO,CAAC,YAA3B,EAAhB,WAAW,mBAAG,EAAE,KAAA,CAA4B;QACpD,IAAM,UAAU,GAAG,WAAW,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,IAAA,iBAAS,EAAC,WAAW,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;QAE1E,IAAI,CAAC,UAAU,EAAE,CAAC;YAChB,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,IAAM,qBAAqB,GAAG,mBAAY,IAAA,uBAAe,EACvD,UAAU,CACX,sFAA4E,IAAA,wBAAgB,EAC3F,UAAU,CACX,MAAY,CAAC;QAEd,IAAM,cAAc,GAA8B,EAAE,CAAC;QACrD;YACE,GAAC,sDAA+C,qBAAqB,gBAAM,qBAAqB,CAAE,IAAlG,UACE,IAA6B;gBAE7B,cAAc,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAC5B,CAAC;YACD,GAAC,kDAAkD,IAAnD;;;oBACE,KAAmB,IAAA,mBAAA,SAAA,cAAc,CAAA,8CAAA,0EAAE,CAAC;wBAA/B,IAAM,IAAI,2BAAA;wBACb,OAAO,CAAC,MAAM,CAAC;4BACb,IAAI,MAAA;4BACJ,SAAS,mBAAA;yBACV,CAAC,CAAC;oBACL,CAAC;;;;;;;;;gBACD,cAAc,CAAC,MAAM,GAAG,CAAC,CAAC;YAC5B,CAAC;eACD;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/experimental-utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  asPattern,\n  getNgRxStores,\n  namedExpression,\n  selectExpression,\n} from '../../utils';\n\nexport const messageId = 'avoidCombiningSelectors';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    ngrxModule: 'store',\n    docs: {\n      description: 'Prefer combining selectors at the selector level.',\n      recommended: 'warn',\n    },\n    schema: [],\n    messages: {\n      [messageId]: 'Combine selectors at the selector level.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const { identifiers = [] } = getNgRxStores(context);\n    const storeNames = identifiers.length > 0 ? asPattern(identifiers) : null;\n\n    if (!storeNames) {\n      return {};\n    }\n\n    const pipeableOrStoreSelect = `:matches(${namedExpression(\n      storeNames\n    )}[callee.property.name='pipe']:has(CallExpression[callee.name='select']), ${selectExpression(\n      storeNames\n    )})` as const;\n\n    const selectsInArray: TSESTree.CallExpression[] = [];\n    return {\n      [`CallExpression[callee.name='combineLatest'] ${pipeableOrStoreSelect} ~ ${pipeableOrStoreSelect}`](\n        node: TSESTree.CallExpression\n      ) {\n        selectsInArray.push(node);\n      },\n      [`CallExpression[callee.name='combineLatest']:exit`]() {\n        for (const node of selectsInArray) {\n          context.report({\n            node,\n            messageId,\n          });\n        }\n        selectsInArray.length = 0;\n      },\n    };\n  },\n});\n"]}
+{"version":3,"file":"avoid-combining-selectors.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/store/avoid-combining-selectors.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;AACA,2CAA6B;AAC7B,qDAAgD;AAChD,uCAKqB;AAER,QAAA,SAAS,GAAG,yBAAyB,CAAC;AAKnD,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,UAAU,EAAE,OAAO;QACnB,IAAI,EAAE;YACJ,WAAW,EAAE,mDAAmD;SACjE;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,CAAC,iBAAS,CAAC,EAAE,0CAA0C;SACxD;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,MAAM,EAAE,WAAW,GAAG,EAAE,EAAE,GAAG,IAAA,qBAAa,EAAC,OAAO,CAAC,CAAC;QACpD,MAAM,UAAU,GAAG,WAAW,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,IAAA,iBAAS,EAAC,WAAW,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;QAE1E,IAAI,CAAC,UAAU,EAAE,CAAC;YAChB,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,MAAM,qBAAqB,GAAG,YAAY,IAAA,uBAAe,EACvD,UAAU,CACX,4EAA4E,IAAA,wBAAgB,EAC3F,UAAU,CACX,GAAY,CAAC;QAEd,MAAM,cAAc,GAA8B,EAAE,CAAC;QACrD,OAAO;YACL,CAAC,+CAA+C,qBAAqB,MAAM,qBAAqB,EAAE,CAAC,CACjG,IAA6B;gBAE7B,cAAc,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YAC5B,CAAC;YACD,CAAC,kDAAkD,CAAC;gBAClD,KAAK,MAAM,IAAI,IAAI,cAAc,EAAE,CAAC;oBAClC,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI;wBACJ,SAAS,EAAT,iBAAS;qBACV,CAAC,CAAC;gBACL,CAAC;gBACD,cAAc,CAAC,MAAM,GAAG,CAAC,CAAC;YAC5B,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  asPattern,\n  getNgRxStores,\n  namedExpression,\n  selectExpression,\n} from '../../utils';\n\nexport const messageId = 'avoidCombiningSelectors';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    ngrxModule: 'store',\n    docs: {\n      description: 'Prefer combining selectors at the selector level.',\n    },\n    schema: [],\n    messages: {\n      [messageId]: 'Combine selectors at the selector level.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const { identifiers = [] } = getNgRxStores(context);\n    const storeNames = identifiers.length > 0 ? asPattern(identifiers) : null;\n\n    if (!storeNames) {\n      return {};\n    }\n\n    const pipeableOrStoreSelect = `:matches(${namedExpression(\n      storeNames\n    )}[callee.property.name='pipe']:has(CallExpression[callee.name='select']), ${selectExpression(\n      storeNames\n    )})` as const;\n\n    const selectsInArray: TSESTree.CallExpression[] = [];\n    return {\n      [`CallExpression[callee.name='combineLatest'] ${pipeableOrStoreSelect} ~ ${pipeableOrStoreSelect}`](\n        node: TSESTree.CallExpression\n      ) {\n        selectsInArray.push(node);\n      },\n      [`CallExpression[callee.name='combineLatest']:exit`]() {\n        for (const node of selectsInArray) {\n          context.report({\n            node,\n            messageId,\n          });\n        }\n        selectsInArray.length = 0;\n      },\n    };\n  },\n});\n"]}

package/src/rules/store/avoid-dispatching-multiple-actions-sequentially.d.ts

@@ -0,0 +1,3 @@
+export declare const messageId = "avoidDispatchingMultipleActionsSequentially";
+declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<"avoidDispatchingMultipleActionsSequentially", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+export default _default;

package/src/rules/store/avoid-dispatching-multiple-actions-sequentially.js

@@ -22,23 +22,11 @@ var __importStar = (this && this.__importStar) || function (mod) {
     __setModuleDefault(result, mod);
     return result;
 };
-var __values = (this && this.__values) || function(o) {
-    var s = typeof Symbol === "function" && Symbol.iterator, m = s && o[s], i = 0;
-    if (m) return m.call(o);
-    if (o && typeof o.length === "number") return {
-        next: function () {
-            if (o && i >= o.length) o = void 0;
-            return { value: o && o[i++], done: !o };
-        }
-    };
-    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
-};
-var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.messageId = void 0;
-var path = __importStar(require("path"));
-var rule_creator_1 = require("../../rule-creator");
-var utils_1 = require("../../utils");
+const path = __importStar(require("path"));
+const rule_creator_1 = require("../../rule-creator");
+const utils_1 = require("../../utils");
 exports.messageId = 'avoidDispatchingMultipleActionsSequentially';
 exports.default = (0, rule_creator_1.createRule)({
     name: path.parse(__filename).name,
@@ -47,52 +35,37 @@ exports.default = (0, rule_creator_1.createRule)({
         ngrxModule: 'store',
         docs: {
             description: 'It is recommended to only dispatch one `Action` at a time.',
-            recommended: 'warn',
         },
         schema: [],
-        messages: (_a = {},
-            _a[exports.messageId] = 'Avoid dispatching many actions in a row to accomplish a larger conceptual "transaction".',
-            _a),
+        messages: {
+            [exports.messageId]: 'Avoid dispatching many actions in a row to accomplish a larger conceptual "transaction".',
+        },
     },
     defaultOptions: [],
-    create: function (context) {
-        var _a;
-        var _b = (0, utils_1.getNgRxStores)(context).identifiers, identifiers = _b === void 0 ? [] : _b;
-        var storeNames = identifiers.length > 0 ? (0, utils_1.asPattern)(identifiers) : null;
+    create: (context) => {
+        const { identifiers = [] } = (0, utils_1.getNgRxStores)(context);
+        const storeNames = identifiers.length > 0 ? (0, utils_1.asPattern)(identifiers) : null;
         if (!storeNames) {
             return {};
         }
-        var collectedDispatches = [];
-        return _a = {},
-            _a["BlockStatement > ExpressionStatement > ".concat((0, utils_1.dispatchExpression)(storeNames))] = function (node) {
+        const collectedDispatches = [];
+        return {
+            [`BlockStatement > ExpressionStatement > ${(0, utils_1.dispatchExpression)(storeNames)}`](node) {
                 collectedDispatches.push(node);
             },
-            _a['BlockStatement:exit'] = function () {
-                var e_1, _a;
-                var withSameParent = collectedDispatches.filter(function (d1) {
-                    return collectedDispatches.some(function (d2) { var _a, _b; return d2 !== d1 && ((_a = d2.parent) === null || _a === void 0 ? void 0 : _a.parent) === ((_b = d1.parent) === null || _b === void 0 ? void 0 : _b.parent); });
-                });
+            'BlockStatement:exit'() {
+                const withSameParent = collectedDispatches.filter((d1) => collectedDispatches.some((d2) => d2 !== d1 && d2.parent?.parent === d1.parent?.parent));
                 if (withSameParent.length > 1) {
-                    try {
-                        for (var withSameParent_1 = __values(withSameParent), withSameParent_1_1 = withSameParent_1.next(); !withSameParent_1_1.done; withSameParent_1_1 = withSameParent_1.next()) {
-                            var node = withSameParent_1_1.value;
-                            context.report({
-                                node: node,
-                                messageId: exports.messageId,
-                            });
-                        }
-                    }
-                    catch (e_1_1) { e_1 = { error: e_1_1 }; }
-                    finally {
-                        try {
-                            if (withSameParent_1_1 && !withSameParent_1_1.done && (_a = withSameParent_1.return)) _a.call(withSameParent_1);
-                        }
-                        finally { if (e_1) throw e_1.error; }
+                    for (const node of withSameParent) {
+                        context.report({
+                            node,
+                            messageId: exports.messageId,
+                        });
                     }
                 }
                 collectedDispatches.length = 0;
             },
-            _a;
+        };
     },
 });
 //# sourceMappingURL=avoid-dispatching-multiple-actions-sequentially.js.map

package/src/rules/store/avoid-dispatching-multiple-actions-sequentially.js.map

@@ -1 +1 @@
-{"version":3,"file":"avoid-dispatching-multiple-actions-sequentially.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/store/avoid-dispatching-multiple-actions-sequentially.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AACA,yCAA6B;AAC7B,mDAAgD;AAChD,qCAA2E;AAE9D,QAAA,SAAS,GAAG,6CAA6C,CAAC;AAKvE,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,UAAU,EAAE,OAAO;QACnB,IAAI,EAAE;YACJ,WAAW,EAAE,4DAA4D;YACzE,WAAW,EAAE,MAAM;SACpB;QACD,MAAM,EAAE,EAAE;QACV,QAAQ;YACN,GAAC,iBAAS,IACR,0FAA0F;eAC7F;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,UAAC,OAAO;;QACN,IAAA,KAAqB,IAAA,qBAAa,EAAC,OAAO,CAAC,YAA3B,EAAhB,WAAW,mBAAG,EAAE,KAAA,CAA4B;QACpD,IAAM,UAAU,GAAG,WAAW,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,IAAA,iBAAS,EAAC,WAAW,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;QAE1E,IAAI,CAAC,UAAU,EAAE,CAAC;YAChB,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,IAAM,mBAAmB,GAA8B,EAAE,CAAC;QAE1D;YACE,GAAC,iDAA0C,IAAA,0BAAkB,EAC3D,UAAU,CACX,CAAE,IAFH,UAEK,IAA6B;gBAChC,mBAAmB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YACjC,CAAC;YACD,yBAAqB,GAArB;;gBACE,IAAM,cAAc,GAAG,mBAAmB,CAAC,MAAM,CAAC,UAAC,EAAE;oBACnD,OAAA,mBAAmB,CAAC,IAAI,CACtB,UAAC,EAAE,gBAAK,OAAA,EAAE,KAAK,EAAE,IAAI,CAAA,MAAA,EAAE,CAAC,MAAM,0CAAE,MAAM,OAAK,MAAA,EAAE,CAAC,MAAM,0CAAE,MAAM,CAAA,CAAA,EAAA,CAC7D;gBAFD,CAEC,CACF,CAAC;gBACF,IAAI,cAAc,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;;wBAC9B,KAAmB,IAAA,mBAAA,SAAA,cAAc,CAAA,8CAAA,0EAAE,CAAC;4BAA/B,IAAM,IAAI,2BAAA;4BACb,OAAO,CAAC,MAAM,CAAC;gCACb,IAAI,MAAA;gCACJ,SAAS,mBAAA;6BACV,CAAC,CAAC;wBACL,CAAC;;;;;;;;;gBACH,CAAC;gBAED,mBAAmB,CAAC,MAAM,GAAG,CAAC,CAAC;YACjC,CAAC;eACD;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/experimental-utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport { asPattern, dispatchExpression, getNgRxStores } from '../../utils';\n\nexport const messageId = 'avoidDispatchingMultipleActionsSequentially';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    ngrxModule: 'store',\n    docs: {\n      description: 'It is recommended to only dispatch one `Action` at a time.',\n      recommended: 'warn',\n    },\n    schema: [],\n    messages: {\n      [messageId]:\n        'Avoid dispatching many actions in a row to accomplish a larger conceptual \"transaction\".',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const { identifiers = [] } = getNgRxStores(context);\n    const storeNames = identifiers.length > 0 ? asPattern(identifiers) : null;\n\n    if (!storeNames) {\n      return {};\n    }\n\n    const collectedDispatches: TSESTree.CallExpression[] = [];\n\n    return {\n      [`BlockStatement > ExpressionStatement > ${dispatchExpression(\n        storeNames\n      )}`](node: TSESTree.CallExpression) {\n        collectedDispatches.push(node);\n      },\n      'BlockStatement:exit'() {\n        const withSameParent = collectedDispatches.filter((d1) =>\n          collectedDispatches.some(\n            (d2) => d2 !== d1 && d2.parent?.parent === d1.parent?.parent\n          )\n        );\n        if (withSameParent.length > 1) {\n          for (const node of withSameParent) {\n            context.report({\n              node,\n              messageId,\n            });\n          }\n        }\n\n        collectedDispatches.length = 0;\n      },\n    };\n  },\n});\n"]}
+{"version":3,"file":"avoid-dispatching-multiple-actions-sequentially.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/store/avoid-dispatching-multiple-actions-sequentially.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;AACA,2CAA6B;AAC7B,qDAAgD;AAChD,uCAA2E;AAE9D,QAAA,SAAS,GAAG,6CAA6C,CAAC;AAKvE,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,UAAU,EAAE,OAAO;QACnB,IAAI,EAAE;YACJ,WAAW,EAAE,4DAA4D;SAC1E;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,CAAC,iBAAS,CAAC,EACT,0FAA0F;SAC7F;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,MAAM,EAAE,WAAW,GAAG,EAAE,EAAE,GAAG,IAAA,qBAAa,EAAC,OAAO,CAAC,CAAC;QACpD,MAAM,UAAU,GAAG,WAAW,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,IAAA,iBAAS,EAAC,WAAW,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;QAE1E,IAAI,CAAC,UAAU,EAAE,CAAC;YAChB,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,MAAM,mBAAmB,GAA8B,EAAE,CAAC;QAE1D,OAAO;YACL,CAAC,0CAA0C,IAAA,0BAAkB,EAC3D,UAAU,CACX,EAAE,CAAC,CAAC,IAA6B;gBAChC,mBAAmB,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YACjC,CAAC;YACD,qBAAqB;gBACnB,MAAM,cAAc,GAAG,mBAAmB,CAAC,MAAM,CAAC,CAAC,EAAE,EAAE,EAAE,CACvD,mBAAmB,CAAC,IAAI,CACtB,CAAC,EAAE,EAAE,EAAE,CAAC,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,MAAM,EAAE,MAAM,KAAK,EAAE,CAAC,MAAM,EAAE,MAAM,CAC7D,CACF,CAAC;gBACF,IAAI,cAAc,CAAC,MAAM,GAAG,CAAC,EAAE,CAAC;oBAC9B,KAAK,MAAM,IAAI,IAAI,cAAc,EAAE,CAAC;wBAClC,OAAO,CAAC,MAAM,CAAC;4BACb,IAAI;4BACJ,SAAS,EAAT,iBAAS;yBACV,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;gBAED,mBAAmB,CAAC,MAAM,GAAG,CAAC,CAAC;YACjC,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport { asPattern, dispatchExpression, getNgRxStores } from '../../utils';\n\nexport const messageId = 'avoidDispatchingMultipleActionsSequentially';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    ngrxModule: 'store',\n    docs: {\n      description: 'It is recommended to only dispatch one `Action` at a time.',\n    },\n    schema: [],\n    messages: {\n      [messageId]:\n        'Avoid dispatching many actions in a row to accomplish a larger conceptual \"transaction\".',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const { identifiers = [] } = getNgRxStores(context);\n    const storeNames = identifiers.length > 0 ? asPattern(identifiers) : null;\n\n    if (!storeNames) {\n      return {};\n    }\n\n    const collectedDispatches: TSESTree.CallExpression[] = [];\n\n    return {\n      [`BlockStatement > ExpressionStatement > ${dispatchExpression(\n        storeNames\n      )}`](node: TSESTree.CallExpression) {\n        collectedDispatches.push(node);\n      },\n      'BlockStatement:exit'() {\n        const withSameParent = collectedDispatches.filter((d1) =>\n          collectedDispatches.some(\n            (d2) => d2 !== d1 && d2.parent?.parent === d1.parent?.parent\n          )\n        );\n        if (withSameParent.length > 1) {\n          for (const node of withSameParent) {\n            context.report({\n              node,\n              messageId,\n            });\n          }\n        }\n\n        collectedDispatches.length = 0;\n      },\n    };\n  },\n});\n"]}

package/src/rules/store/avoid-duplicate-actions-in-reducer.d.ts

@@ -0,0 +1,5 @@
+export declare const avoidDuplicateActionsInReducer = "avoidDuplicateActionsInReducer";
+export declare const avoidDuplicateActionsInReducerSuggest = "avoidDuplicateActionsInReducerSuggest";
+type MessageIds = typeof avoidDuplicateActionsInReducer | typeof avoidDuplicateActionsInReducerSuggest;
+declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<MessageIds, readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+export default _default;

package/src/rules/store/avoid-duplicate-actions-in-reducer.js

@@ -22,48 +22,11 @@ var __importStar = (this && this.__importStar) || function (mod) {
     __setModuleDefault(result, mod);
     return result;
 };
-var __read = (this && this.__read) || function (o, n) {
-    var m = typeof Symbol === "function" && o[Symbol.iterator];
-    if (!m) return o;
-    var i = m.call(o), r, ar = [], e;
-    try {
-        while ((n === void 0 || n-- > 0) && !(r = i.next()).done) ar.push(r.value);
-    }
-    catch (error) { e = { error: error }; }
-    finally {
-        try {
-            if (r && !r.done && (m = i["return"])) m.call(i);
-        }
-        finally { if (e) throw e.error; }
-    }
-    return ar;
-};
-var __spreadArray = (this && this.__spreadArray) || function (to, from, pack) {
-    if (pack || arguments.length === 2) for (var i = 0, l = from.length, ar; i < l; i++) {
-        if (ar || !(i in from)) {
-            if (!ar) ar = Array.prototype.slice.call(from, 0, i);
-            ar[i] = from[i];
-        }
-    }
-    return to.concat(ar || Array.prototype.slice.call(from));
-};
-var __values = (this && this.__values) || function(o) {
-    var s = typeof Symbol === "function" && Symbol.iterator, m = s && o[s], i = 0;
-    if (m) return m.call(o);
-    if (o && typeof o.length === "number") return {
-        next: function () {
-            if (o && i >= o.length) o = void 0;
-            return { value: o && o[i++], done: !o };
-        }
-    };
-    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
-};
-var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.avoidDuplicateActionsInReducerSuggest = exports.avoidDuplicateActionsInReducer = void 0;
-var path = __importStar(require("path"));
-var rule_creator_1 = require("../../rule-creator");
-var utils_1 = require("../../utils");
+const path = __importStar(require("path"));
+const rule_creator_1 = require("../../rule-creator");
+const utils_1 = require("../../utils");
 exports.avoidDuplicateActionsInReducer = 'avoidDuplicateActionsInReducer';
 exports.avoidDuplicateActionsInReducerSuggest = 'avoidDuplicateActionsInReducerSuggest';
 exports.default = (0, rule_creator_1.createRule)({
@@ -74,77 +37,46 @@ exports.default = (0, rule_creator_1.createRule)({
         ngrxModule: 'store',
         docs: {
             description: 'A `Reducer` should handle an `Action` once.',
-            recommended: 'warn',
-            suggestion: true,
         },
         schema: [],
-        messages: (_a = {},
-            _a[exports.avoidDuplicateActionsInReducer] = 'The `Reducer` handles a duplicate `Action` `{{ actionName }}`.',
-            _a[exports.avoidDuplicateActionsInReducerSuggest] = 'Remove this duplication.',
-            _a),
+        messages: {
+            [exports.avoidDuplicateActionsInReducer]: 'The `Reducer` handles a duplicate `Action` `{{ actionName }}`.',
+            [exports.avoidDuplicateActionsInReducerSuggest]: 'Remove this duplication.',
+        },
     },
     defaultOptions: [],
-    create: function (context) {
-        var _a;
-        var sourceCode = context.getSourceCode();
-        var collectedActions = new Map();
-        return _a = {},
-            _a["".concat(utils_1.createReducer, " > CallExpression[callee.name='on'][arguments.0.type='Identifier']")] = function (_a) {
-                var _b;
-                var _c = __read(_a.arguments, 1), action = _c[0];
-                var actions = (_b = collectedActions.get(action.name)) !== null && _b !== void 0 ? _b : [];
-                collectedActions.set(action.name, __spreadArray(__spreadArray([], __read(actions), false), [action], false));
+    create: (context) => {
+        const sourceCode = context.getSourceCode();
+        const collectedActions = new Map();
+        return {
+            [`${utils_1.createReducer} > CallExpression[callee.name='on'][arguments.0.type='Identifier']`]({ arguments: [action], }) {
+                const actions = collectedActions.get(action.name) ?? [];
+                collectedActions.set(action.name, [...actions, action]);
             },
-            _a["".concat(utils_1.createReducer, ":exit")] = function () {
-                var e_1, _a, e_2, _b;
-                try {
-                    for (var collectedActions_1 = __values(collectedActions), collectedActions_1_1 = collectedActions_1.next(); !collectedActions_1_1.done; collectedActions_1_1 = collectedActions_1.next()) {
-                        var _c = __read(collectedActions_1_1.value, 2), actionName = _c[0], identifiers = _c[1];
-                        if (identifiers.length <= 1) {
-                            break;
-                        }
-                        var _loop_1 = function (node) {
-                            context.report({
-                                node: node,
-                                messageId: exports.avoidDuplicateActionsInReducer,
-                                data: {
-                                    actionName: actionName,
-                                },
-                                suggest: [
-                                    {
-                                        messageId: exports.avoidDuplicateActionsInReducerSuggest,
-                                        fix: function (fixer) {
-                                            return (0, utils_1.getNodeToCommaRemoveFix)(sourceCode, fixer, node.parent);
-                                        },
-                                    },
-                                ],
-                            });
-                        };
-                        try {
-                            for (var identifiers_1 = (e_2 = void 0, __values(identifiers)), identifiers_1_1 = identifiers_1.next(); !identifiers_1_1.done; identifiers_1_1 = identifiers_1.next()) {
-                                var node = identifiers_1_1.value;
-                                _loop_1(node);
-                            }
-                        }
-                        catch (e_2_1) { e_2 = { error: e_2_1 }; }
-                        finally {
-                            try {
-                                if (identifiers_1_1 && !identifiers_1_1.done && (_b = identifiers_1.return)) _b.call(identifiers_1);
-                            }
-                            finally { if (e_2) throw e_2.error; }
-                        }
+            [`${utils_1.createReducer}:exit`]() {
+                for (const [actionName, identifiers] of collectedActions) {
+                    if (identifiers.length <= 1) {
+                        break;
                     }
-                }
-                catch (e_1_1) { e_1 = { error: e_1_1 }; }
-                finally {
-                    try {
-                        if (collectedActions_1_1 && !collectedActions_1_1.done && (_a = collectedActions_1.return)) _a.call(collectedActions_1);
+                    for (const node of identifiers) {
+                        context.report({
+                            node,
+                            messageId: exports.avoidDuplicateActionsInReducer,
+                            data: {
+                                actionName,
+                            },
+                            suggest: [
+                                {
+                                    messageId: exports.avoidDuplicateActionsInReducerSuggest,
+                                    fix: (fixer) => (0, utils_1.getNodeToCommaRemoveFix)(sourceCode, fixer, node.parent),
+                                },
+                            ],
+                        });
                     }
-                    finally { if (e_1) throw e_1.error; }
                 }
                 collectedActions.clear();
             },
-            _a;
+        };
     },
 });
 //# sourceMappingURL=avoid-duplicate-actions-in-reducer.js.map

package/src/rules/store/avoid-duplicate-actions-in-reducer.js.map

@@ -1 +1 @@
-{"version":3,"file":"avoid-duplicate-actions-in-reducer.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/store/avoid-duplicate-actions-in-reducer.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AACA,yCAA6B;AAC7B,mDAAgD;AAChD,qCAAqE;AAExD,QAAA,8BAA8B,GAAG,gCAAgC,CAAC;AAClE,QAAA,qCAAqC,GAChD,uCAAuC,CAAC;AAQ1C,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,cAAc,EAAE,IAAI;QACpB,UAAU,EAAE,OAAO;QACnB,IAAI,EAAE;YACJ,WAAW,EAAE,6CAA6C;YAC1D,WAAW,EAAE,MAAM;YACnB,UAAU,EAAE,IAAI;SACjB;QACD,MAAM,EAAE,EAAE;QACV,QAAQ;YACN,GAAC,sCAA8B,IAC7B,gEAAgE;YAClE,GAAC,6CAAqC,IAAG,0BAA0B;eACpE;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,UAAC,OAAO;;QACd,IAAM,UAAU,GAAG,OAAO,CAAC,aAAa,EAAE,CAAC;QAC3C,IAAM,gBAAgB,GAAG,IAAI,GAAG,EAAoB,CAAC;QAErD;YACE,GAAC,UAAG,qBAAa,uEAAoE,IAArF,UAAuF,EAItF;;oBAHC,KAAA,uBAAmB,EAAP,MAAM,QAAA;gBAIlB,IAAM,OAAO,GAAG,MAAA,gBAAgB,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,mCAAI,EAAE,CAAC;gBACxD,gBAAgB,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,yCAAM,OAAO,YAAE,MAAM,UAAE,CAAC;YAC1D,CAAC;YACD,GAAC,UAAG,qBAAa,UAAO,IAAxB;;;oBACE,KAAwC,IAAA,qBAAA,SAAA,gBAAgB,CAAA,kDAAA,gFAAE,CAAC;wBAAhD,IAAA,KAAA,qCAAyB,EAAxB,UAAU,QAAA,EAAE,WAAW,QAAA;wBACjC,IAAI,WAAW,CAAC,MAAM,IAAI,CAAC,EAAE,CAAC;4BAC5B,MAAM;wBACR,CAAC;gDAEU,IAAI;4BACb,OAAO,CAAC,MAAM,CAAC;gCACb,IAAI,MAAA;gCACJ,SAAS,EAAE,sCAA8B;gCACzC,IAAI,EAAE;oCACJ,UAAU,YAAA;iCACX;gCACD,OAAO,EAAE;oCACP;wCACE,SAAS,EAAE,6CAAqC;wCAChD,GAAG,EAAE,UAAC,KAAK;4CACT,OAAA,IAAA,+BAAuB,EAAC,UAAU,EAAE,KAAK,EAAE,IAAI,CAAC,MAAM,CAAC;wCAAvD,CAAuD;qCAC1D;iCACF;6BACF,CAAC,CAAC;;;4BAdL,KAAmB,IAAA,+BAAA,SAAA,WAAW,CAAA,CAAA,wCAAA;gCAAzB,IAAM,IAAI,wBAAA;wCAAJ,IAAI;6BAed;;;;;;;;;oBACH,CAAC;;;;;;;;;gBAED,gBAAgB,CAAC,KAAK,EAAE,CAAC;YAC3B,CAAC;eACD;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/experimental-utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport { createReducer, getNodeToCommaRemoveFix } from '../../utils';\n\nexport const avoidDuplicateActionsInReducer = 'avoidDuplicateActionsInReducer';\nexport const avoidDuplicateActionsInReducerSuggest =\n  'avoidDuplicateActionsInReducerSuggest';\n\ntype MessageIds =\n  | typeof avoidDuplicateActionsInReducer\n  | typeof avoidDuplicateActionsInReducerSuggest;\ntype Options = readonly [];\ntype Action = TSESTree.Identifier & { parent: TSESTree.CallExpression };\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    hasSuggestions: true,\n    ngrxModule: 'store',\n    docs: {\n      description: 'A `Reducer` should handle an `Action` once.',\n      recommended: 'warn',\n      suggestion: true,\n    },\n    schema: [],\n    messages: {\n      [avoidDuplicateActionsInReducer]:\n        'The `Reducer` handles a duplicate `Action` `{{ actionName }}`.',\n      [avoidDuplicateActionsInReducerSuggest]: 'Remove this duplication.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const sourceCode = context.getSourceCode();\n    const collectedActions = new Map<string, Action[]>();\n\n    return {\n      [`${createReducer} > CallExpression[callee.name='on'][arguments.0.type='Identifier']`]({\n        arguments: [action],\n      }: TSESTree.CallExpression & {\n        arguments: Action[];\n      }) {\n        const actions = collectedActions.get(action.name) ?? [];\n        collectedActions.set(action.name, [...actions, action]);\n      },\n      [`${createReducer}:exit`]() {\n        for (const [actionName, identifiers] of collectedActions) {\n          if (identifiers.length <= 1) {\n            break;\n          }\n\n          for (const node of identifiers) {\n            context.report({\n              node,\n              messageId: avoidDuplicateActionsInReducer,\n              data: {\n                actionName,\n              },\n              suggest: [\n                {\n                  messageId: avoidDuplicateActionsInReducerSuggest,\n                  fix: (fixer) =>\n                    getNodeToCommaRemoveFix(sourceCode, fixer, node.parent),\n                },\n              ],\n            });\n          }\n        }\n\n        collectedActions.clear();\n      },\n    };\n  },\n});\n"]}
+{"version":3,"file":"avoid-duplicate-actions-in-reducer.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/store/avoid-duplicate-actions-in-reducer.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;AACA,2CAA6B;AAC7B,qDAAgD;AAChD,uCAAqE;AAExD,QAAA,8BAA8B,GAAG,gCAAgC,CAAC;AAClE,QAAA,qCAAqC,GAChD,uCAAuC,CAAC;AAQ1C,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,cAAc,EAAE,IAAI;QACpB,UAAU,EAAE,OAAO;QACnB,IAAI,EAAE;YACJ,WAAW,EAAE,6CAA6C;SAC3D;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,CAAC,sCAA8B,CAAC,EAC9B,gEAAgE;YAClE,CAAC,6CAAqC,CAAC,EAAE,0BAA0B;SACpE;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,MAAM,UAAU,GAAG,OAAO,CAAC,aAAa,EAAE,CAAC;QAC3C,MAAM,gBAAgB,GAAG,IAAI,GAAG,EAAoB,CAAC;QAErD,OAAO;YACL,CAAC,GAAG,qBAAa,oEAAoE,CAAC,CAAC,EACrF,SAAS,EAAE,CAAC,MAAM,CAAC,GAGpB;gBACC,MAAM,OAAO,GAAG,gBAAgB,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,EAAE,CAAC;gBACxD,gBAAgB,CAAC,GAAG,CAAC,MAAM,CAAC,IAAI,EAAE,CAAC,GAAG,OAAO,EAAE,MAAM,CAAC,CAAC,CAAC;YAC1D,CAAC;YACD,CAAC,GAAG,qBAAa,OAAO,CAAC;gBACvB,KAAK,MAAM,CAAC,UAAU,EAAE,WAAW,CAAC,IAAI,gBAAgB,EAAE,CAAC;oBACzD,IAAI,WAAW,CAAC,MAAM,IAAI,CAAC,EAAE,CAAC;wBAC5B,MAAM;oBACR,CAAC;oBAED,KAAK,MAAM,IAAI,IAAI,WAAW,EAAE,CAAC;wBAC/B,OAAO,CAAC,MAAM,CAAC;4BACb,IAAI;4BACJ,SAAS,EAAE,sCAA8B;4BACzC,IAAI,EAAE;gCACJ,UAAU;6BACX;4BACD,OAAO,EAAE;gCACP;oCACE,SAAS,EAAE,6CAAqC;oCAChD,GAAG,EAAE,CAAC,KAAK,EAAE,EAAE,CACb,IAAA,+BAAuB,EAAC,UAAU,EAAE,KAAK,EAAE,IAAI,CAAC,MAAM,CAAC;iCAC1D;6BACF;yBACF,CAAC,CAAC;oBACL,CAAC;gBACH,CAAC;gBAED,gBAAgB,CAAC,KAAK,EAAE,CAAC;YAC3B,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport { createReducer, getNodeToCommaRemoveFix } from '../../utils';\n\nexport const avoidDuplicateActionsInReducer = 'avoidDuplicateActionsInReducer';\nexport const avoidDuplicateActionsInReducerSuggest =\n  'avoidDuplicateActionsInReducerSuggest';\n\ntype MessageIds =\n  | typeof avoidDuplicateActionsInReducer\n  | typeof avoidDuplicateActionsInReducerSuggest;\ntype Options = readonly [];\ntype Action = TSESTree.Identifier & { parent: TSESTree.CallExpression };\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    hasSuggestions: true,\n    ngrxModule: 'store',\n    docs: {\n      description: 'A `Reducer` should handle an `Action` once.',\n    },\n    schema: [],\n    messages: {\n      [avoidDuplicateActionsInReducer]:\n        'The `Reducer` handles a duplicate `Action` `{{ actionName }}`.',\n      [avoidDuplicateActionsInReducerSuggest]: 'Remove this duplication.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const sourceCode = context.getSourceCode();\n    const collectedActions = new Map<string, Action[]>();\n\n    return {\n      [`${createReducer} > CallExpression[callee.name='on'][arguments.0.type='Identifier']`]({\n        arguments: [action],\n      }: TSESTree.CallExpression & {\n        arguments: Action[];\n      }) {\n        const actions = collectedActions.get(action.name) ?? [];\n        collectedActions.set(action.name, [...actions, action]);\n      },\n      [`${createReducer}:exit`]() {\n        for (const [actionName, identifiers] of collectedActions) {\n          if (identifiers.length <= 1) {\n            break;\n          }\n\n          for (const node of identifiers) {\n            context.report({\n              node,\n              messageId: avoidDuplicateActionsInReducer,\n              data: {\n                actionName,\n              },\n              suggest: [\n                {\n                  messageId: avoidDuplicateActionsInReducerSuggest,\n                  fix: (fixer) =>\n                    getNodeToCommaRemoveFix(sourceCode, fixer, node.parent),\n                },\n              ],\n            });\n          }\n        }\n\n        collectedActions.clear();\n      },\n    };\n  },\n});\n"]}

package/src/rules/store/avoid-mapping-selectors.d.ts

@@ -0,0 +1,3 @@
+export declare const messageId = "avoidMapppingSelectors";
+declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<"avoidMapppingSelectors", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+export default _default;

package/src/rules/store/avoid-mapping-selectors.js

@@ -22,13 +22,11 @@ var __importStar = (this && this.__importStar) || function (mod) {
     __setModuleDefault(result, mod);
     return result;
 };
-var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.messageId = void 0;
-var eslint_etc_1 = require("eslint-etc");
-var path = __importStar(require("path"));
-var rule_creator_1 = require("../../rule-creator");
-var utils_1 = require("../../utils");
+const path = __importStar(require("path"));
+const rule_creator_1 = require("../../rule-creator");
+const utils_1 = require("../../utils");
 exports.messageId = 'avoidMapppingSelectors';
 exports.default = (0, rule_creator_1.createRule)({
     name: path.parse(__filename).name,
@@ -37,28 +35,26 @@ exports.default = (0, rule_creator_1.createRule)({
         ngrxModule: 'store',
         docs: {
             description: 'Avoid mapping logic outside the selector level.',
-            recommended: 'warn',
         },
         schema: [],
-        messages: (_a = {},
-            _a[exports.messageId] = 'Map logic at the selector level instead.',
-            _a),
+        messages: {
+            [exports.messageId]: 'Map logic at the selector level instead.',
+        },
     },
     defaultOptions: [],
-    create: function (context) {
-        var _a;
-        var _b = (0, utils_1.getNgRxStores)(context).identifiers, identifiers = _b === void 0 ? [] : _b;
-        var storeNames = identifiers.length > 0 ? (0, utils_1.asPattern)(identifiers) : null;
+    create: (context) => {
+        const { identifiers = [] } = (0, utils_1.getNgRxStores)(context);
+        const storeNames = identifiers.length > 0 ? (0, utils_1.asPattern)(identifiers) : null;
         if (!storeNames) {
             return {};
         }
-        var pipeWithSelectAndMapSelector = "".concat((0, utils_1.pipeExpression)(storeNames), ":has(CallExpression[callee.name='select'] ~ CallExpression[callee.name='map'])");
-        var selectSelector = "".concat((0, utils_1.namedCallableExpression)(storeNames), "[callee.object.callee.property.name='select']");
+        const pipeWithSelectAndMapSelector = `${(0, utils_1.pipeExpression)(storeNames)}:has(CallExpression[callee.name='select'] ~ CallExpression[callee.name='map'])`;
+        const selectSelector = `${(0, utils_1.namedCallableExpression)(storeNames)}[callee.object.callee.property.name='select']`;
         function isInCreateEffect(node) {
-            var parent = node.parent;
+            let parent = node.parent;
             while (parent) {
-                if ((0, eslint_etc_1.isCallExpression)(parent) &&
-                    (0, eslint_etc_1.isIdentifier)(parent.callee) &&
+                if ((0, utils_1.isCallExpression)(parent) &&
+                    (0, utils_1.isIdentifier)(parent.callee) &&
                     parent.callee.name === 'createEffect') {
                     return true;
                 }
@@ -66,13 +62,13 @@ exports.default = (0, rule_creator_1.createRule)({
             }
             return false;
         }
-        var pipeHasThisExpression = false;
-        var selectorQuery = ":matches(".concat(selectSelector, ", ").concat(pipeWithSelectAndMapSelector, ")");
-        return _a = {},
-            _a["".concat(selectorQuery, " > CallExpression:has(ThisExpression)")] = function (node) {
+        let pipeHasThisExpression = false;
+        const selectorQuery = `:matches(${selectSelector}, ${pipeWithSelectAndMapSelector})`;
+        return {
+            [`${selectorQuery} > CallExpression:has(ThisExpression)`](_node) {
                 pipeHasThisExpression = true;
             },
-            _a["".concat(selectorQuery, "[callee.property.name=pipe]:exit")] = function (node) {
+            [`${selectorQuery}[callee.property.name=pipe]:exit`](node) {
                 if (pipeHasThisExpression) {
                     pipeHasThisExpression = false;
                     return;
@@ -80,12 +76,10 @@ exports.default = (0, rule_creator_1.createRule)({
                 if (isInCreateEffect(node)) {
                     return;
                 }
-                var operators = node.arguments;
-                var mapOperator = operators.find(function (operator) {
-                    return (0, eslint_etc_1.isCallExpression)(operator) &&
-                        (0, eslint_etc_1.isIdentifier)(operator.callee) &&
-                        operator.callee.name === 'map';
-                });
+                const operators = node.arguments;
+                const mapOperator = operators.find((operator) => (0, utils_1.isCallExpression)(operator) &&
+                    (0, utils_1.isIdentifier)(operator.callee) &&
+                    operator.callee.name === 'map');
                 if (mapOperator) {
                     context.report({
                         node: mapOperator,
@@ -93,7 +87,7 @@ exports.default = (0, rule_creator_1.createRule)({
                     });
                 }
             },
-            _a;
+        };
     },
 });
 //# sourceMappingURL=avoid-mapping-selectors.js.map

package/src/rules/store/avoid-mapping-selectors.js.map

@@ -1 +1 @@
-{"version":3,"file":"avoid-mapping-selectors.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/store/avoid-mapping-selectors.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;AACA,yCAA4D;AAC5D,yCAA6B;AAC7B,mDAAgD;AAChD,qCAMqB;AAER,QAAA,SAAS,GAAG,wBAAwB,CAAC;AAKlD,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,UAAU,EAAE,OAAO;QACnB,IAAI,EAAE;YACJ,WAAW,EAAE,iDAAiD;YAC9D,WAAW,EAAE,MAAM;SACpB;QACD,MAAM,EAAE,EAAE;QACV,QAAQ;YACN,GAAC,iBAAS,IAAG,0CAA0C;eACxD;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,UAAC,OAAO;;QACN,IAAA,KAAqB,IAAA,qBAAa,EAAC,OAAO,CAAC,YAA3B,EAAhB,WAAW,mBAAG,EAAE,KAAA,CAA4B;QACpD,IAAM,UAAU,GAAG,WAAW,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,IAAA,iBAAS,EAAC,WAAW,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;QAE1E,IAAI,CAAC,UAAU,EAAE,CAAC;YAChB,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,IAAM,4BAA4B,GAAG,UAAG,IAAA,sBAAc,EACpD,UAAU,CACX,mFAAyF,CAAC;QAC3F,IAAM,cAAc,GAAG,UAAG,IAAA,+BAAuB,EAC/C,UAAU,CACX,kDAAwD,CAAC;QAE1D,SAAS,gBAAgB,CAAC,IAA6B;YACrD,IAAI,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC;YACzB,OAAO,MAAM,EAAE,CAAC;gBACd,IACE,IAAA,6BAAgB,EAAC,MAAM,CAAC;oBACxB,IAAA,yBAAY,EAAC,MAAM,CAAC,MAAM,CAAC;oBAC3B,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,cAAc,EACrC,CAAC;oBACD,OAAO,IAAI,CAAC;gBACd,CAAC;gBACD,MAAM,GAAG,MAAM,CAAC,MAAM,CAAC;YACzB,CAAC;YACD,OAAO,KAAK,CAAC;QACf,CAAC;QAED,IAAI,qBAAqB,GAAG,KAAK,CAAC;QAElC,IAAM,aAAa,GAAG,mBAAY,cAAc,eAAK,4BAA4B,MAAG,CAAC;QACrF;YACE,GAAC,UAAG,aAAa,0CAAuC,IAAxD,UACE,IAA6B;gBAE7B,qBAAqB,GAAG,IAAI,CAAC;YAC/B,CAAC;YACD,GAAC,UAAG,aAAa,qCAAkC,IAAnD,UACE,IAA6B;gBAE7B,IAAI,qBAAqB,EAAE,CAAC;oBAC1B,qBAAqB,GAAG,KAAK,CAAC;oBAC9B,OAAO;gBACT,CAAC;gBAED,IAAI,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;oBAC3B,OAAO;gBACT,CAAC;gBAED,IAAM,SAAS,GAAG,IAAI,CAAC,SAAS,CAAC;gBACjC,IAAM,WAAW,GAAG,SAAS,CAAC,IAAI,CAChC,UAAC,QAAQ;oBACP,OAAA,IAAA,6BAAgB,EAAC,QAAQ,CAAC;wBAC1B,IAAA,yBAAY,EAAC,QAAQ,CAAC,MAAM,CAAC;wBAC7B,QAAQ,CAAC,MAAM,CAAC,IAAI,KAAK,KAAK;gBAF9B,CAE8B,CACjC,CAAC;gBACF,IAAI,WAAW,EAAE,CAAC;oBAChB,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,WAAW;wBACjB,SAAS,mBAAA;qBACV,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;eACD;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/experimental-utils';\nimport { isCallExpression, isIdentifier } from 'eslint-etc';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  asPattern,\n  getNgRxStores,\n  isMemberExpression,\n  namedCallableExpression,\n  pipeExpression,\n} from '../../utils';\n\nexport const messageId = 'avoidMapppingSelectors';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    ngrxModule: 'store',\n    docs: {\n      description: 'Avoid mapping logic outside the selector level.',\n      recommended: 'warn',\n    },\n    schema: [],\n    messages: {\n      [messageId]: 'Map logic at the selector level instead.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const { identifiers = [] } = getNgRxStores(context);\n    const storeNames = identifiers.length > 0 ? asPattern(identifiers) : null;\n\n    if (!storeNames) {\n      return {};\n    }\n\n    const pipeWithSelectAndMapSelector = `${pipeExpression(\n      storeNames\n    )}:has(CallExpression[callee.name='select'] ~ CallExpression[callee.name='map'])` as const;\n    const selectSelector = `${namedCallableExpression(\n      storeNames\n    )}[callee.object.callee.property.name='select']` as const;\n\n    function isInCreateEffect(node: TSESTree.CallExpression) {\n      let parent = node.parent;\n      while (parent) {\n        if (\n          isCallExpression(parent) &&\n          isIdentifier(parent.callee) &&\n          parent.callee.name === 'createEffect'\n        ) {\n          return true;\n        }\n        parent = parent.parent;\n      }\n      return false;\n    }\n\n    let pipeHasThisExpression = false;\n\n    const selectorQuery = `:matches(${selectSelector}, ${pipeWithSelectAndMapSelector})`;\n    return {\n      [`${selectorQuery} > CallExpression:has(ThisExpression)`](\n        node: TSESTree.CallExpression\n      ) {\n        pipeHasThisExpression = true;\n      },\n      [`${selectorQuery}[callee.property.name=pipe]:exit`](\n        node: TSESTree.CallExpression\n      ) {\n        if (pipeHasThisExpression) {\n          pipeHasThisExpression = false;\n          return;\n        }\n\n        if (isInCreateEffect(node)) {\n          return;\n        }\n\n        const operators = node.arguments;\n        const mapOperator = operators.find(\n          (operator) =>\n            isCallExpression(operator) &&\n            isIdentifier(operator.callee) &&\n            operator.callee.name === 'map'\n        );\n        if (mapOperator) {\n          context.report({\n            node: mapOperator,\n            messageId,\n          });\n        }\n      },\n    };\n  },\n});\n"]}
+{"version":3,"file":"avoid-mapping-selectors.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/store/avoid-mapping-selectors.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;AACA,2CAA6B;AAC7B,qDAAgD;AAChD,uCAOqB;AAER,QAAA,SAAS,GAAG,wBAAwB,CAAC;AAKlD,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,UAAU,EAAE,OAAO;QACnB,IAAI,EAAE;YACJ,WAAW,EAAE,iDAAiD;SAC/D;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,CAAC,iBAAS,CAAC,EAAE,0CAA0C;SACxD;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,MAAM,EAAE,WAAW,GAAG,EAAE,EAAE,GAAG,IAAA,qBAAa,EAAC,OAAO,CAAC,CAAC;QACpD,MAAM,UAAU,GAAG,WAAW,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,IAAA,iBAAS,EAAC,WAAW,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;QAE1E,IAAI,CAAC,UAAU,EAAE,CAAC;YAChB,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,MAAM,4BAA4B,GAAG,GAAG,IAAA,sBAAc,EACpD,UAAU,CACX,gFAAyF,CAAC;QAC3F,MAAM,cAAc,GAAG,GAAG,IAAA,+BAAuB,EAC/C,UAAU,CACX,+CAAwD,CAAC;QAE1D,SAAS,gBAAgB,CAAC,IAA6B;YACrD,IAAI,MAAM,GAA8B,IAAI,CAAC,MAAM,CAAC;YACpD,OAAO,MAAM,EAAE,CAAC;gBACd,IACE,IAAA,wBAAgB,EAAC,MAAM,CAAC;oBACxB,IAAA,oBAAY,EAAC,MAAM,CAAC,MAAM,CAAC;oBAC3B,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,cAAc,EACrC,CAAC;oBACD,OAAO,IAAI,CAAC;gBACd,CAAC;gBACD,MAAM,GAAG,MAAM,CAAC,MAAM,CAAC;YACzB,CAAC;YACD,OAAO,KAAK,CAAC;QACf,CAAC;QAED,IAAI,qBAAqB,GAAG,KAAK,CAAC;QAElC,MAAM,aAAa,GAAG,YAAY,cAAc,KAAK,4BAA4B,GAAG,CAAC;QACrF,OAAO;YACL,CAAC,GAAG,aAAa,uCAAuC,CAAC,CACvD,KAA8B;gBAE9B,qBAAqB,GAAG,IAAI,CAAC;YAC/B,CAAC;YACD,CAAC,GAAG,aAAa,kCAAkC,CAAC,CAClD,IAA6B;gBAE7B,IAAI,qBAAqB,EAAE,CAAC;oBAC1B,qBAAqB,GAAG,KAAK,CAAC;oBAC9B,OAAO;gBACT,CAAC;gBAED,IAAI,gBAAgB,CAAC,IAAI,CAAC,EAAE,CAAC;oBAC3B,OAAO;gBACT,CAAC;gBAED,MAAM,SAAS,GAAG,IAAI,CAAC,SAAS,CAAC;gBACjC,MAAM,WAAW,GAAG,SAAS,CAAC,IAAI,CAChC,CAAC,QAAQ,EAAE,EAAE,CACX,IAAA,wBAAgB,EAAC,QAAQ,CAAC;oBAC1B,IAAA,oBAAY,EAAC,QAAQ,CAAC,MAAM,CAAC;oBAC7B,QAAQ,CAAC,MAAM,CAAC,IAAI,KAAK,KAAK,CACjC,CAAC;gBACF,IAAI,WAAW,EAAE,CAAC;oBAChB,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,WAAW;wBACjB,SAAS,EAAT,iBAAS;qBACV,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  asPattern,\n  getNgRxStores,\n  isCallExpression,\n  isIdentifier,\n  namedCallableExpression,\n  pipeExpression,\n} from '../../utils';\n\nexport const messageId = 'avoidMapppingSelectors';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    ngrxModule: 'store',\n    docs: {\n      description: 'Avoid mapping logic outside the selector level.',\n    },\n    schema: [],\n    messages: {\n      [messageId]: 'Map logic at the selector level instead.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const { identifiers = [] } = getNgRxStores(context);\n    const storeNames = identifiers.length > 0 ? asPattern(identifiers) : null;\n\n    if (!storeNames) {\n      return {};\n    }\n\n    const pipeWithSelectAndMapSelector = `${pipeExpression(\n      storeNames\n    )}:has(CallExpression[callee.name='select'] ~ CallExpression[callee.name='map'])` as const;\n    const selectSelector = `${namedCallableExpression(\n      storeNames\n    )}[callee.object.callee.property.name='select']` as const;\n\n    function isInCreateEffect(node: TSESTree.CallExpression) {\n      let parent: TSESTree.Node | undefined = node.parent;\n      while (parent) {\n        if (\n          isCallExpression(parent) &&\n          isIdentifier(parent.callee) &&\n          parent.callee.name === 'createEffect'\n        ) {\n          return true;\n        }\n        parent = parent.parent;\n      }\n      return false;\n    }\n\n    let pipeHasThisExpression = false;\n\n    const selectorQuery = `:matches(${selectSelector}, ${pipeWithSelectAndMapSelector})`;\n    return {\n      [`${selectorQuery} > CallExpression:has(ThisExpression)`](\n        _node: TSESTree.CallExpression\n      ) {\n        pipeHasThisExpression = true;\n      },\n      [`${selectorQuery}[callee.property.name=pipe]:exit`](\n        node: TSESTree.CallExpression\n      ) {\n        if (pipeHasThisExpression) {\n          pipeHasThisExpression = false;\n          return;\n        }\n\n        if (isInCreateEffect(node)) {\n          return;\n        }\n\n        const operators = node.arguments;\n        const mapOperator = operators.find(\n          (operator) =>\n            isCallExpression(operator) &&\n            isIdentifier(operator.callee) &&\n            operator.callee.name === 'map'\n        );\n        if (mapOperator) {\n          context.report({\n            node: mapOperator,\n            messageId,\n          });\n        }\n      },\n    };\n  },\n});\n"]}

package/src/rules/store/good-action-hygiene.d.ts

@@ -0,0 +1,3 @@
+export declare const messageId = "goodActionHygiene";
+declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<"goodActionHygiene", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+export default _default;