@ngrx/eslint-plugin 18.0.0-beta.0 → 18.0.0-rc.0

package/src/rules/effects/use-effects-lifecycle-interface.js

@@ -22,12 +22,11 @@ var __importStar = (this && this.__importStar) || function (mod) {
     __setModuleDefault(result, mod);
     return result;
 };
-var _a;
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.messageId = void 0;
-var path = __importStar(require("path"));
-var rule_creator_1 = require("../../rule-creator");
-var utils_1 = require("../../utils");
+const path = __importStar(require("path"));
+const rule_creator_1 = require("../../rule-creator");
+const utils_1 = require("../../utils");
 exports.messageId = 'useEffectsLifecycleInterface';
 exports.default = (0, rule_creator_1.createRule)({
     name: path.parse(__filename).name,
@@ -36,53 +35,51 @@ exports.default = (0, rule_creator_1.createRule)({
         ngrxModule: 'effects',
         docs: {
             description: 'Ensures classes implement lifecycle interfaces corresponding to the declared lifecycle methods.',
-            recommended: 'warn',
         },
         fixable: 'code',
         schema: [],
-        messages: (_a = {},
-            _a[exports.messageId] = 'Lifecycle interface `{{ interfaceName }}` should be implemented for method `{{ methodName }}`.',
-            _a),
+        messages: {
+            [exports.messageId]: 'Lifecycle interface `{{ interfaceName }}` should be implemented for method `{{ methodName }}`.',
+        },
     },
     defaultOptions: [],
-    create: function (context) {
-        var _a;
-        var lifecycleMapper = {
+    create: (context) => {
+        const lifecycleMapper = {
             ngrxOnIdentifyEffects: 'OnIdentifyEffects',
             ngrxOnInitEffects: 'OnInitEffects',
             ngrxOnRunEffects: 'OnRunEffects',
         };
-        var lifecyclesPattern = Object.keys(lifecycleMapper).join('|');
-        return _a = {},
-            _a["ClassDeclaration > ClassBody > MethodDefinition > Identifier[name=/".concat(lifecyclesPattern, "/]")] = function (node) {
-                var classDeclaration = node.parent.parent.parent;
-                var methodName = node.name;
-                var interfaceName = lifecycleMapper[methodName];
+        const lifecyclesPattern = Object.keys(lifecycleMapper).join('|');
+        return {
+            [`ClassDeclaration > ClassBody > MethodDefinition > Identifier[name=/${lifecyclesPattern}/]`](node) {
+                const classDeclaration = node.parent.parent.parent;
+                const methodName = node.name;
+                const interfaceName = lifecycleMapper[methodName];
                 if ((0, utils_1.getInterface)(classDeclaration, interfaceName)) {
                     return;
                 }
                 context.report({
-                    fix: function (fixer) {
-                        var _a = (0, utils_1.getImplementsSchemaFixer)(classDeclaration, interfaceName), implementsNodeReplace = _a.implementsNodeReplace, implementsTextReplace = _a.implementsTextReplace;
+                    fix: (fixer) => {
+                        const { implementsNodeReplace, implementsTextReplace } = (0, utils_1.getImplementsSchemaFixer)(classDeclaration, interfaceName);
                         return [
                             fixer.insertTextAfter(implementsNodeReplace, implementsTextReplace),
                         ].concat((0, utils_1.getImportAddFix)({
                             compatibleWithTypeOnlyImport: true,
-                            fixer: fixer,
+                            fixer,
                             importName: interfaceName,
                             moduleName: utils_1.NGRX_MODULE_PATHS.effects,
                             node: classDeclaration,
                         }));
                     },
-                    node: node,
+                    node,
                     messageId: exports.messageId,
                     data: {
-                        interfaceName: interfaceName,
-                        methodName: methodName,
+                        interfaceName,
+                        methodName,
                     },
                 });
             },
-            _a;
+        };
     },
 });
 //# sourceMappingURL=use-effects-lifecycle-interface.js.map

package/src/rules/effects/use-effects-lifecycle-interface.js.map

@@ -1 +1 @@
-{"version":3,"file":"use-effects-lifecycle-interface.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/effects/use-effects-lifecycle-interface.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;AACA,yCAA6B;AAC7B,mDAAgD;AAChD,qCAKqB;AAER,QAAA,SAAS,GAAG,8BAA8B,CAAC;AAKxD,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EACT,iGAAiG;YACnG,WAAW,EAAE,MAAM;SACpB;QACD,OAAO,EAAE,MAAM;QACf,MAAM,EAAE,EAAE;QACV,QAAQ;YACN,GAAC,iBAAS,IACR,gGAAgG;eACnG;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,UAAC,OAAO;;QACd,IAAM,eAAe,GAAG;YACtB,qBAAqB,EAAE,mBAAmB;YAC1C,iBAAiB,EAAE,eAAe;YAClC,gBAAgB,EAAE,cAAc;SACxB,CAAC;QACX,IAAM,iBAAiB,GAAG,MAAM,CAAC,IAAI,CAAC,eAAe,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QAEjE;YACE,GAAC,6EAAsE,iBAAiB,OAAI,IAA5F,UACE,IAKC;gBAED,IAAM,gBAAgB,GAAG,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC;gBACnD,IAAM,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC;gBAC7B,IAAM,aAAa,GAAG,eAAe,CAAC,UAAU,CAAC,CAAC;gBAElD,IAAI,IAAA,oBAAY,EAAC,gBAAgB,EAAE,aAAa,CAAC,EAAE,CAAC;oBAClD,OAAO;gBACT,CAAC;gBAED,OAAO,CAAC,MAAM,CAAC;oBACb,GAAG,EAAE,UAAC,KAAK;wBACH,IAAA,KACJ,IAAA,gCAAwB,EAAC,gBAAgB,EAAE,aAAa,CAAC,EADnD,qBAAqB,2BAAA,EAAE,qBAAqB,2BACO,CAAC;wBAC5D,OAAO;4BACL,KAAK,CAAC,eAAe,CACnB,qBAAqB,EACrB,qBAAqB,CACtB;yBACF,CAAC,MAAM,CACN,IAAA,uBAAe,EAAC;4BACd,4BAA4B,EAAE,IAAI;4BAClC,KAAK,OAAA;4BACL,UAAU,EAAE,aAAa;4BACzB,UAAU,EAAE,yBAAiB,CAAC,OAAO;4BACrC,IAAI,EAAE,gBAAgB;yBACvB,CAAC,CACH,CAAC;oBACJ,CAAC;oBACD,IAAI,MAAA;oBACJ,SAAS,mBAAA;oBACT,IAAI,EAAE;wBACJ,aAAa,eAAA;wBACb,UAAU,YAAA;qBACX;iBACF,CAAC,CAAC;YACL,CAAC;eACD;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/experimental-utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  getImplementsSchemaFixer,\n  getImportAddFix,\n  getInterface,\n  NGRX_MODULE_PATHS,\n} from '../../utils';\n\nexport const messageId = 'useEffectsLifecycleInterface';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    ngrxModule: 'effects',\n    docs: {\n      description:\n        'Ensures classes implement lifecycle interfaces corresponding to the declared lifecycle methods.',\n      recommended: 'warn',\n    },\n    fixable: 'code',\n    schema: [],\n    messages: {\n      [messageId]:\n        'Lifecycle interface `{{ interfaceName }}` should be implemented for method `{{ methodName }}`.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const lifecycleMapper = {\n      ngrxOnIdentifyEffects: 'OnIdentifyEffects',\n      ngrxOnInitEffects: 'OnInitEffects',\n      ngrxOnRunEffects: 'OnRunEffects',\n    } as const;\n    const lifecyclesPattern = Object.keys(lifecycleMapper).join('|');\n\n    return {\n      [`ClassDeclaration > ClassBody > MethodDefinition > Identifier[name=/${lifecyclesPattern}/]`](\n        node: TSESTree.Identifier & {\n          name: keyof typeof lifecycleMapper;\n          parent: TSESTree.MethodDefinition & {\n            parent: TSESTree.ClassBody & { parent: TSESTree.ClassDeclaration };\n          };\n        }\n      ) {\n        const classDeclaration = node.parent.parent.parent;\n        const methodName = node.name;\n        const interfaceName = lifecycleMapper[methodName];\n\n        if (getInterface(classDeclaration, interfaceName)) {\n          return;\n        }\n\n        context.report({\n          fix: (fixer) => {\n            const { implementsNodeReplace, implementsTextReplace } =\n              getImplementsSchemaFixer(classDeclaration, interfaceName);\n            return [\n              fixer.insertTextAfter(\n                implementsNodeReplace,\n                implementsTextReplace\n              ),\n            ].concat(\n              getImportAddFix({\n                compatibleWithTypeOnlyImport: true,\n                fixer,\n                importName: interfaceName,\n                moduleName: NGRX_MODULE_PATHS.effects,\n                node: classDeclaration,\n              })\n            );\n          },\n          node,\n          messageId,\n          data: {\n            interfaceName,\n            methodName,\n          },\n        });\n      },\n    };\n  },\n});\n"]}
+{"version":3,"file":"use-effects-lifecycle-interface.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/effects/use-effects-lifecycle-interface.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;AACA,2CAA6B;AAC7B,qDAAgD;AAChD,uCAKqB;AAER,QAAA,SAAS,GAAG,8BAA8B,CAAC;AAKxD,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EACT,iGAAiG;SACpG;QACD,OAAO,EAAE,MAAM;QACf,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,CAAC,iBAAS,CAAC,EACT,gGAAgG;SACnG;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,MAAM,eAAe,GAAG;YACtB,qBAAqB,EAAE,mBAAmB;YAC1C,iBAAiB,EAAE,eAAe;YAClC,gBAAgB,EAAE,cAAc;SACxB,CAAC;QACX,MAAM,iBAAiB,GAAG,MAAM,CAAC,IAAI,CAAC,eAAe,CAAC,CAAC,IAAI,CAAC,GAAG,CAAC,CAAC;QAEjE,OAAO;YACL,CAAC,sEAAsE,iBAAiB,IAAI,CAAC,CAC3F,IAKC;gBAED,MAAM,gBAAgB,GAAG,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,MAAM,CAAC;gBACnD,MAAM,UAAU,GAAG,IAAI,CAAC,IAAI,CAAC;gBAC7B,MAAM,aAAa,GAAG,eAAe,CAAC,UAAU,CAAC,CAAC;gBAElD,IAAI,IAAA,oBAAY,EAAC,gBAAgB,EAAE,aAAa,CAAC,EAAE,CAAC;oBAClD,OAAO;gBACT,CAAC;gBAED,OAAO,CAAC,MAAM,CAAC;oBACb,GAAG,EAAE,CAAC,KAAK,EAAE,EAAE;wBACb,MAAM,EAAE,qBAAqB,EAAE,qBAAqB,EAAE,GACpD,IAAA,gCAAwB,EAAC,gBAAgB,EAAE,aAAa,CAAC,CAAC;wBAC5D,OAAO;4BACL,KAAK,CAAC,eAAe,CACnB,qBAAqB,EACrB,qBAAqB,CACtB;yBACF,CAAC,MAAM,CACN,IAAA,uBAAe,EAAC;4BACd,4BAA4B,EAAE,IAAI;4BAClC,KAAK;4BACL,UAAU,EAAE,aAAa;4BACzB,UAAU,EAAE,yBAAiB,CAAC,OAAO;4BACrC,IAAI,EAAE,gBAAgB;yBACvB,CAAC,CACH,CAAC;oBACJ,CAAC;oBACD,IAAI;oBACJ,SAAS,EAAT,iBAAS;oBACT,IAAI,EAAE;wBACJ,aAAa;wBACb,UAAU;qBACX;iBACF,CAAC,CAAC;YACL,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  getImplementsSchemaFixer,\n  getImportAddFix,\n  getInterface,\n  NGRX_MODULE_PATHS,\n} from '../../utils';\n\nexport const messageId = 'useEffectsLifecycleInterface';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    ngrxModule: 'effects',\n    docs: {\n      description:\n        'Ensures classes implement lifecycle interfaces corresponding to the declared lifecycle methods.',\n    },\n    fixable: 'code',\n    schema: [],\n    messages: {\n      [messageId]:\n        'Lifecycle interface `{{ interfaceName }}` should be implemented for method `{{ methodName }}`.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const lifecycleMapper = {\n      ngrxOnIdentifyEffects: 'OnIdentifyEffects',\n      ngrxOnInitEffects: 'OnInitEffects',\n      ngrxOnRunEffects: 'OnRunEffects',\n    } as const;\n    const lifecyclesPattern = Object.keys(lifecycleMapper).join('|');\n\n    return {\n      [`ClassDeclaration > ClassBody > MethodDefinition > Identifier[name=/${lifecyclesPattern}/]`](\n        node: TSESTree.Identifier & {\n          name: keyof typeof lifecycleMapper;\n          parent: TSESTree.MethodDefinition & {\n            parent: TSESTree.ClassBody & { parent: TSESTree.ClassDeclaration };\n          };\n        }\n      ) {\n        const classDeclaration = node.parent.parent.parent;\n        const methodName = node.name;\n        const interfaceName = lifecycleMapper[methodName];\n\n        if (getInterface(classDeclaration, interfaceName)) {\n          return;\n        }\n\n        context.report({\n          fix: (fixer) => {\n            const { implementsNodeReplace, implementsTextReplace } =\n              getImplementsSchemaFixer(classDeclaration, interfaceName);\n            return [\n              fixer.insertTextAfter(\n                implementsNodeReplace,\n                implementsTextReplace\n              ),\n            ].concat(\n              getImportAddFix({\n                compatibleWithTypeOnlyImport: true,\n                fixer,\n                importName: interfaceName,\n                moduleName: NGRX_MODULE_PATHS.effects,\n                node: classDeclaration,\n              })\n            );\n          },\n          node,\n          messageId,\n          data: {\n            interfaceName,\n            methodName,\n          },\n        });\n      },\n    };\n  },\n});\n"]}

package/src/rules/index.d.ts

@@ -0,0 +1,33 @@
+export declare const rules: {
+    'avoid-combining-component-store-selectors': import("@typescript-eslint/utils/ts-eslint").RuleModule<"avoidCombiningComponentStoreSelectors", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'avoid-mapping-component-store-selectors': import("@typescript-eslint/utils/ts-eslint").RuleModule<"avoidMappingComponentStoreSelectors", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'updater-explicit-return-type': import("@typescript-eslint/utils/ts-eslint").RuleModule<"updaterExplicitReturnType", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'avoid-cyclic-effects': import("@typescript-eslint/utils/ts-eslint").RuleModule<"avoidCyclicEffects", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'no-dispatch-in-effects': import("@typescript-eslint/utils/ts-eslint").RuleModule<"noDispatchInEffects" | "noDispatchInEffectsSuggest", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'no-effects-in-providers': import("@typescript-eslint/utils/ts-eslint").RuleModule<"noEffectsInProviders", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'no-multiple-actions-in-effects': import("@typescript-eslint/utils/ts-eslint").RuleModule<"noMultipleActionsInEffects", readonly unknown[], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'prefer-action-creator-in-of-type': import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferActionCreatorInOfType", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'prefer-effect-callback-in-block-statement': import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferEffectCallbackInBlockStatement", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'use-effects-lifecycle-interface': import("@typescript-eslint/utils/ts-eslint").RuleModule<"useEffectsLifecycleInterface", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'avoid-combining-selectors': import("@typescript-eslint/utils/ts-eslint").RuleModule<"avoidCombiningSelectors", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'avoid-dispatching-multiple-actions-sequentially': import("@typescript-eslint/utils/ts-eslint").RuleModule<"avoidDispatchingMultipleActionsSequentially", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'avoid-duplicate-actions-in-reducer': import("@typescript-eslint/utils/ts-eslint").RuleModule<"avoidDuplicateActionsInReducer" | "avoidDuplicateActionsInReducerSuggest", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'avoid-mapping-selectors': import("@typescript-eslint/utils/ts-eslint").RuleModule<"avoidMapppingSelectors", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'good-action-hygiene': import("@typescript-eslint/utils/ts-eslint").RuleModule<"goodActionHygiene", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'no-multiple-global-stores': import("@typescript-eslint/utils/ts-eslint").RuleModule<"noMultipleGlobalStores" | "noMultipleGlobalStoresSuggest", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'no-reducer-in-key-names': import("@typescript-eslint/utils/ts-eslint").RuleModule<"noReducerInKeyNames" | "noReducerInKeyNamesSuggest", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'no-store-subscription': import("@typescript-eslint/utils/ts-eslint").RuleModule<"noStoreSubscription", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'no-typed-global-store': import("@typescript-eslint/utils/ts-eslint").RuleModule<"noTypedStore" | "noTypedStoreSuggest", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'on-function-explicit-return-type': import("@typescript-eslint/utils/ts-eslint").RuleModule<"onFunctionExplicitReturnType" | "onFunctionExplicitReturnTypeSuggest", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'prefer-action-creator': import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferActionCreator", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'prefer-action-creator-in-dispatch': import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferActionCreatorInDispatch", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'prefer-inline-action-props': import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferInlineActionProps" | "preferInlineActionPropsSuggest", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'prefer-one-generic-in-create-for-feature-selector': import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferOneGenericInCreateForFeatureSelector" | "preferOneGenericInCreateForFeatureSelectorSuggest", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'prefer-selector-in-select': import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferSelectorInSelect", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'prefix-selectors-with-select': import("@typescript-eslint/utils/ts-eslint").RuleModule<"prefixSelectorsWithSelect" | "prefixSelectorsWithSelectSuggest", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'select-style': import("@typescript-eslint/utils/ts-eslint").RuleModule<"operator" | "method", readonly ["operator" | "method"], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'use-consistent-global-store-name': import("@typescript-eslint/utils/ts-eslint").RuleModule<"useConsistentGlobalStoreName" | "useConsistentGlobalStoreNameSuggest", readonly [string], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+    'prefer-concat-latest-from': import("@typescript-eslint/utils/ts-eslint").RuleModule<"preferConcatLatestFrom", readonly [{
+        readonly strict: boolean;
+    }], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+};

package/src/rules/index.js

@@ -1,59 +1,75 @@
 "use strict";
-var __assign = (this && this.__assign) || function () {
-    __assign = Object.assign || function(t) {
-        for (var s, i = 1, n = arguments.length; i < n; i++) {
-            s = arguments[i];
-            for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p))
-                t[p] = s[p];
-        }
-        return t;
-    };
-    return __assign.apply(this, arguments);
-};
-var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    var desc = Object.getOwnPropertyDescriptor(m, k);
-    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
-      desc = { enumerable: true, get: function() { return m[k]; } };
-    }
-    Object.defineProperty(o, k2, desc);
-}) : (function(o, m, k, k2) {
-    if (k2 === undefined) k2 = k;
-    o[k2] = m[k];
-}));
-var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
-    Object.defineProperty(o, "default", { enumerable: true, value: v });
-}) : function(o, v) {
-    o["default"] = v;
-});
-var __importStar = (this && this.__importStar) || function (mod) {
-    if (mod && mod.__esModule) return mod;
-    var result = {};
-    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
-    __setModuleDefault(result, mod);
-    return result;
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.rules = void 0;
-var path = __importStar(require("path"));
-var utils_1 = require("../utils");
-// Copied from https://github.com/jest-community/eslint-plugin-jest/blob/main/src/index.ts
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
-var interopRequireDefault = function (obj) {
-    return (obj === null || obj === void 0 ? void 0 : obj.__esModule) ? obj : { default: obj };
-};
-var importDefault = function (moduleName) {
-    // eslint-disable-next-line @typescript-eslint/no-var-requires
-    return interopRequireDefault(require(moduleName)).default;
+// component-store
+const avoid_combining_component_store_selectors_1 = __importDefault(require("./component-store/avoid-combining-component-store-selectors"));
+const avoid_mapping_component_store_selectors_1 = __importDefault(require("./component-store/avoid-mapping-component-store-selectors"));
+const updater_explicit_return_type_1 = __importDefault(require("./component-store/updater-explicit-return-type"));
+// effects
+const avoid_cyclic_effects_1 = __importDefault(require("./effects/avoid-cyclic-effects"));
+const no_dispatch_in_effects_1 = __importDefault(require("./effects/no-dispatch-in-effects"));
+const no_effects_in_providers_1 = __importDefault(require("./effects/no-effects-in-providers"));
+const no_multiple_actions_in_effects_1 = __importDefault(require("./effects/no-multiple-actions-in-effects"));
+const prefer_action_creator_in_of_type_1 = __importDefault(require("./effects/prefer-action-creator-in-of-type"));
+const prefer_effect_callback_in_block_statement_1 = __importDefault(require("./effects/prefer-effect-callback-in-block-statement"));
+const use_effects_lifecycle_interface_1 = __importDefault(require("./effects/use-effects-lifecycle-interface"));
+// store
+const avoid_combining_selectors_1 = __importDefault(require("./store/avoid-combining-selectors"));
+const avoid_dispatching_multiple_actions_sequentially_1 = __importDefault(require("./store/avoid-dispatching-multiple-actions-sequentially"));
+const avoid_duplicate_actions_in_reducer_1 = __importDefault(require("./store/avoid-duplicate-actions-in-reducer"));
+const avoid_mapping_selectors_1 = __importDefault(require("./store/avoid-mapping-selectors"));
+const good_action_hygiene_1 = __importDefault(require("./store/good-action-hygiene"));
+const no_multiple_global_stores_1 = __importDefault(require("./store/no-multiple-global-stores"));
+const no_reducer_in_key_names_1 = __importDefault(require("./store/no-reducer-in-key-names"));
+const no_store_subscription_1 = __importDefault(require("./store/no-store-subscription"));
+const no_typed_global_store_1 = __importDefault(require("./store/no-typed-global-store"));
+const on_function_explicit_return_type_1 = __importDefault(require("./store/on-function-explicit-return-type"));
+const prefer_action_creator_1 = __importDefault(require("./store/prefer-action-creator"));
+const prefer_action_creator_in_dispatch_1 = __importDefault(require("./store/prefer-action-creator-in-dispatch"));
+const prefer_inline_action_props_1 = __importDefault(require("./store/prefer-inline-action-props"));
+const prefer_one_generic_in_create_for_feature_selector_1 = __importDefault(require("./store/prefer-one-generic-in-create-for-feature-selector"));
+const prefer_selector_in_select_1 = __importDefault(require("./store/prefer-selector-in-select"));
+const prefix_selectors_with_select_1 = __importDefault(require("./store/prefix-selectors-with-select"));
+const select_style_1 = __importDefault(require("./store/select-style"));
+const use_consistent_global_store_name_1 = __importDefault(require("./store/use-consistent-global-store-name"));
+// operators
+const prefer_concat_latest_from_1 = __importDefault(require("./operators/prefer-concat-latest-from"));
+exports.rules = {
+    // component-store
+    'avoid-combining-component-store-selectors': avoid_combining_component_store_selectors_1.default,
+    'avoid-mapping-component-store-selectors': avoid_mapping_component_store_selectors_1.default,
+    'updater-explicit-return-type': updater_explicit_return_type_1.default,
+    //effects
+    'avoid-cyclic-effects': avoid_cyclic_effects_1.default,
+    'no-dispatch-in-effects': no_dispatch_in_effects_1.default,
+    'no-effects-in-providers': no_effects_in_providers_1.default,
+    'no-multiple-actions-in-effects': no_multiple_actions_in_effects_1.default,
+    'prefer-action-creator-in-of-type': prefer_action_creator_in_of_type_1.default,
+    'prefer-effect-callback-in-block-statement': prefer_effect_callback_in_block_statement_1.default,
+    'use-effects-lifecycle-interface': use_effects_lifecycle_interface_1.default,
+    // store
+    'avoid-combining-selectors': avoid_combining_selectors_1.default,
+    'avoid-dispatching-multiple-actions-sequentially': avoid_dispatching_multiple_actions_sequentially_1.default,
+    'avoid-duplicate-actions-in-reducer': avoid_duplicate_actions_in_reducer_1.default,
+    'avoid-mapping-selectors': avoid_mapping_selectors_1.default,
+    'good-action-hygiene': good_action_hygiene_1.default,
+    'no-multiple-global-stores': no_multiple_global_stores_1.default,
+    'no-reducer-in-key-names': no_reducer_in_key_names_1.default,
+    'no-store-subscription': no_store_subscription_1.default,
+    'no-typed-global-store': no_typed_global_store_1.default,
+    'on-function-explicit-return-type': on_function_explicit_return_type_1.default,
+    'prefer-action-creator': prefer_action_creator_1.default,
+    'prefer-action-creator-in-dispatch': prefer_action_creator_in_dispatch_1.default,
+    'prefer-inline-action-props': prefer_inline_action_props_1.default,
+    'prefer-one-generic-in-create-for-feature-selector': prefer_one_generic_in_create_for_feature_selector_1.default,
+    'prefer-selector-in-select': prefer_selector_in_select_1.default,
+    'prefix-selectors-with-select': prefix_selectors_with_select_1.default,
+    'select-style': select_style_1.default,
+    'use-consistent-global-store-name': use_consistent_global_store_name_1.default,
+    // operators
+    'prefer-concat-latest-from': prefer_concat_latest_from_1.default,
 };
-var rulesDir = __dirname;
-var excludedFiles = ['index'];
-exports.rules = Array.from((0, utils_1.traverseFolder)(rulesDir))
-    .filter(function (rule) { return !excludedFiles.includes(rule.file); })
-    .reduce(function (allRules, rule) {
-    var _a;
-    var ruleModule = importDefault(rule.path);
-    ruleModule.meta.ngrxModule = path.basename(path.dirname(rule.path));
-    return __assign(__assign({}, allRules), (_a = {}, _a[rule.file] = ruleModule, _a));
-}, {});
 //# sourceMappingURL=index.js.map

package/src/rules/index.js.map

@@ -1 +1 @@
-{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../../modules/eslint-plugin/src/rules/index.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AAAA,yCAA6B;AAG7B,kCAA0C;AAE1C,0FAA0F;AAE1F,8DAA8D;AAC9D,IAAM,qBAAqB,GAAG,UAAC,GAAQ;IACrC,OAAA,CAAA,GAAG,aAAH,GAAG,uBAAH,GAAG,CAAE,UAAU,EAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,EAAE,OAAO,EAAE,GAAG,EAAE;AAAxC,CAAwC,CAAC;AAE3C,IAAM,aAAa,GAAG,UAAC,UAAkB;IACvC,8DAA8D;IAC9D,OAAA,qBAAqB,CAAC,OAAO,CAAC,UAAU,CAAC,CAAC,CAAC,OAAO;AAAlD,CAAkD,CAAC;AAErD,IAAM,QAAQ,GAAG,SAAS,CAAC;AAC3B,IAAM,aAAa,GAAG,CAAC,OAAO,CAAC,CAAC;AAEnB,QAAA,KAAK,GAAG,KAAK,CAAC,IAAI,CAAC,IAAA,sBAAc,EAAC,QAAQ,CAAC,CAAC;KACtD,MAAM,CAAC,UAAC,IAAI,IAAK,OAAA,CAAC,aAAa,CAAC,QAAQ,CAAC,IAAI,CAAC,IAAI,CAAC,EAAlC,CAAkC,CAAC;KACpD,MAAM,CAA6C,UAAC,QAAQ,EAAE,IAAI;;IACjE,IAAM,UAAU,GAAG,aAAa,CAAC,IAAI,CAAC,IAAI,CAA+B,CAAC;IAC1E,UAAU,CAAC,IAAI,CAAC,UAAU,GAAG,IAAI,CAAC,QAAQ,CACxC,IAAI,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,CACT,CAAC;IACjB,6BACK,QAAQ,gBACV,IAAI,CAAC,IAAI,IAAG,UAAU,OACvB;AACJ,CAAC,EAAE,EAAE,CAAC,CAAC","sourcesContent":["import * as path from 'path';\nimport type { NgRxRuleModule } from '../rule-creator';\nimport type { NGRX_MODULE } from '../utils';\nimport { traverseFolder } from '../utils';\n\n// Copied from https://github.com/jest-community/eslint-plugin-jest/blob/main/src/index.ts\n\n// eslint-disable-next-line @typescript-eslint/no-explicit-any\nconst interopRequireDefault = (obj: any): { default: unknown } =>\n  obj?.__esModule ? obj : { default: obj };\n\nconst importDefault = (moduleName: string) =>\n  // eslint-disable-next-line @typescript-eslint/no-var-requires\n  interopRequireDefault(require(moduleName)).default;\n\nconst rulesDir = __dirname;\nconst excludedFiles = ['index'];\n\nexport const rules = Array.from(traverseFolder(rulesDir))\n  .filter((rule) => !excludedFiles.includes(rule.file))\n  .reduce<Record<string, NgRxRuleModule<[], string>>>((allRules, rule) => {\n    const ruleModule = importDefault(rule.path) as NgRxRuleModule<[], string>;\n    ruleModule.meta.ngrxModule = path.basename(\n      path.dirname(rule.path)\n    ) as NGRX_MODULE;\n    return {\n      ...allRules,\n      [rule.file]: ruleModule,\n    };\n  }, {});\n"]}
+{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../../modules/eslint-plugin/src/rules/index.ts"],"names":[],"mappings":";;;;;;AAAA,kBAAkB;AAClB,4IAAgH;AAChH,wIAA4G;AAC5G,kHAAuF;AACvF,UAAU;AACV,0FAAgE;AAChE,8FAAmE;AACnE,gGAAqE;AACrE,8GAAkF;AAClF,kHAAqF;AACrF,oIAAuG;AACvG,gHAAqF;AACrF,QAAQ;AACR,kGAAwE;AACxE,8IAAkH;AAClH,oHAAwF;AACxF,8FAAoE;AACpE,sFAA4D;AAC5D,kGAAuE;AACvE,8FAAkE;AAClE,0FAAgE;AAChE,0FAA+D;AAC/D,gHAAoF;AACpF,0FAAgE;AAChE,kHAAsF;AACtF,oGAAyE;AACzE,kJAAmH;AACnH,kGAAuE;AACvE,wGAA6E;AAC7E,wEAA+C;AAC/C,gHAAoF;AACpF,YAAY;AACZ,sGAA2E;AAE9D,QAAA,KAAK,GAAG;IACnB,kBAAkB;IAClB,2CAA2C,EACzC,mDAAqC;IACvC,yCAAyC,EACvC,iDAAmC;IACrC,8BAA8B,EAAE,sCAAyB;IACzD,SAAS;IACT,sBAAsB,EAAE,8BAAkB;IAC1C,wBAAwB,EAAE,gCAAmB;IAC7C,yBAAyB,EAAE,iCAAoB;IAC/C,gCAAgC,EAAE,wCAA0B;IAC5D,kCAAkC,EAAE,0CAA2B;IAC/D,2CAA2C,EACzC,mDAAoC;IACtC,iCAAiC,EAAE,yCAA4B;IAC/D,QAAQ;IACR,2BAA2B,EAAE,mCAAuB;IACpD,iDAAiD,EAC/C,yDAA2C;IAC7C,oCAAoC,EAAE,4CAA8B;IACpE,yBAAyB,EAAE,iCAAqB;IAChD,qBAAqB,EAAE,6BAAiB;IACxC,2BAA2B,EAAE,mCAAsB;IACnD,yBAAyB,EAAE,iCAAmB;IAC9C,uBAAuB,EAAE,+BAAmB;IAC5C,uBAAuB,EAAE,+BAAkB;IAC3C,kCAAkC,EAAE,0CAA4B;IAChE,uBAAuB,EAAE,+BAAmB;IAC5C,mCAAmC,EAAE,2CAA6B;IAClE,4BAA4B,EAAE,oCAAuB;IACrD,mDAAmD,EACjD,2DAA0C;IAC5C,2BAA2B,EAAE,mCAAsB;IACnD,8BAA8B,EAAE,sCAAyB;IACzD,cAAc,EAAE,sBAAW;IAC3B,kCAAkC,EAAE,0CAA4B;IAChE,YAAY;IACZ,2BAA2B,EAAE,mCAAsB;CACpD,CAAC","sourcesContent":["// component-store\nimport avoidCombiningComponentStoreSelectors from './component-store/avoid-combining-component-store-selectors';\nimport avoidMappingComponentStoreSelectors from './component-store/avoid-mapping-component-store-selectors';\nimport updaterExplicitReturnType from './component-store/updater-explicit-return-type';\n// effects\nimport avoidCyclicEffects from './effects/avoid-cyclic-effects';\nimport noDispatchInEffects from './effects/no-dispatch-in-effects';\nimport noEffectsInProviders from './effects/no-effects-in-providers';\nimport noMultipleActionsInEffects from './effects/no-multiple-actions-in-effects';\nimport preferActionCreatorInOfType from './effects/prefer-action-creator-in-of-type';\nimport preferEffectCallbackInBlockStatement from './effects/prefer-effect-callback-in-block-statement';\nimport useEffectsLifecycleInterface from './effects/use-effects-lifecycle-interface';\n// store\nimport avoidCombiningSelectors from './store/avoid-combining-selectors';\nimport avoidDispatchingMultipleActionsSequentially from './store/avoid-dispatching-multiple-actions-sequentially';\nimport avoidDuplicateActionsInReducer from './store/avoid-duplicate-actions-in-reducer';\nimport avoidMappingSelectors from './store/avoid-mapping-selectors';\nimport goodActionHygiene from './store/good-action-hygiene';\nimport noMultipleGlobalStores from './store/no-multiple-global-stores';\nimport noReducerInKeyNames from './store/no-reducer-in-key-names';\nimport noStoreSubscription from './store/no-store-subscription';\nimport noTypedGlobalStore from './store/no-typed-global-store';\nimport onFunctionExplicitReturnType from './store/on-function-explicit-return-type';\nimport preferActionCreator from './store/prefer-action-creator';\nimport preferActionCreatorInDispatch from './store/prefer-action-creator-in-dispatch';\nimport preferInlineActionProps from './store/prefer-inline-action-props';\nimport preferOneGenericInCreateForFeatureSelector from './store/prefer-one-generic-in-create-for-feature-selector';\nimport preferSelectorInSelect from './store/prefer-selector-in-select';\nimport prefixSelectorsWithSelect from './store/prefix-selectors-with-select';\nimport selectStyle from './store/select-style';\nimport useConsistentGlobalStoreName from './store/use-consistent-global-store-name';\n// operators\nimport preferConcatLatestFrom from './operators/prefer-concat-latest-from';\n\nexport const rules = {\n  // component-store\n  'avoid-combining-component-store-selectors':\n    avoidCombiningComponentStoreSelectors,\n  'avoid-mapping-component-store-selectors':\n    avoidMappingComponentStoreSelectors,\n  'updater-explicit-return-type': updaterExplicitReturnType,\n  //effects\n  'avoid-cyclic-effects': avoidCyclicEffects,\n  'no-dispatch-in-effects': noDispatchInEffects,\n  'no-effects-in-providers': noEffectsInProviders,\n  'no-multiple-actions-in-effects': noMultipleActionsInEffects,\n  'prefer-action-creator-in-of-type': preferActionCreatorInOfType,\n  'prefer-effect-callback-in-block-statement':\n    preferEffectCallbackInBlockStatement,\n  'use-effects-lifecycle-interface': useEffectsLifecycleInterface,\n  // store\n  'avoid-combining-selectors': avoidCombiningSelectors,\n  'avoid-dispatching-multiple-actions-sequentially':\n    avoidDispatchingMultipleActionsSequentially,\n  'avoid-duplicate-actions-in-reducer': avoidDuplicateActionsInReducer,\n  'avoid-mapping-selectors': avoidMappingSelectors,\n  'good-action-hygiene': goodActionHygiene,\n  'no-multiple-global-stores': noMultipleGlobalStores,\n  'no-reducer-in-key-names': noReducerInKeyNames,\n  'no-store-subscription': noStoreSubscription,\n  'no-typed-global-store': noTypedGlobalStore,\n  'on-function-explicit-return-type': onFunctionExplicitReturnType,\n  'prefer-action-creator': preferActionCreator,\n  'prefer-action-creator-in-dispatch': preferActionCreatorInDispatch,\n  'prefer-inline-action-props': preferInlineActionProps,\n  'prefer-one-generic-in-create-for-feature-selector':\n    preferOneGenericInCreateForFeatureSelector,\n  'prefer-selector-in-select': preferSelectorInSelect,\n  'prefix-selectors-with-select': prefixSelectorsWithSelect,\n  'select-style': selectStyle,\n  'use-consistent-global-store-name': useConsistentGlobalStoreName,\n  // operators\n  'prefer-concat-latest-from': preferConcatLatestFrom,\n};\n"]}

package/src/rules/operators/prefer-concat-latest-from.d.ts

@@ -0,0 +1,7 @@
+import { type TSESLint } from '@typescript-eslint/utils';
+export declare const messageId = "preferConcatLatestFrom";
+type Options = readonly [{
+    readonly strict: boolean;
+}];
+declare const _default: TSESLint.RuleModule<"preferConcatLatestFrom", Options, TSESLint.RuleListener>;
+export default _default;

package/src/rules/operators/prefer-concat-latest-from.js

@@ -0,0 +1,123 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || function (mod) {
+    if (mod && mod.__esModule) return mod;
+    var result = {};
+    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
+    __setModuleDefault(result, mod);
+    return result;
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.messageId = void 0;
+const utils_1 = require("@typescript-eslint/utils");
+const path = __importStar(require("path"));
+const rule_creator_1 = require("../../rule-creator");
+const utils_2 = require("../../utils");
+exports.messageId = 'preferConcatLatestFrom';
+const defaultOptions = { strict: false };
+const concatLatestFromKeyword = 'concatLatestFrom';
+const withLatestFromKeyword = 'withLatestFrom';
+exports.default = (0, rule_creator_1.createRule)({
+    name: path.parse(__filename).name,
+    meta: {
+        type: 'problem',
+        ngrxModule: 'operators',
+        docs: {
+            description: `Use \`${concatLatestFromKeyword}\` instead of \`${withLatestFromKeyword}\` to prevent the selector from firing until the correct \`Action\` is dispatched.`,
+        },
+        fixable: 'code',
+        schema: [
+            {
+                type: 'object',
+                properties: {
+                    strict: {
+                        type: 'boolean',
+                        default: defaultOptions.strict,
+                    },
+                },
+                additionalProperties: false,
+            },
+        ],
+        messages: {
+            [exports.messageId]: `Use \`${concatLatestFromKeyword}\` instead of \`${withLatestFromKeyword}\`.`,
+        },
+    },
+    defaultOptions: [defaultOptions],
+    create: (context, [options]) => {
+        if (options.strict) {
+            return {
+                [`${utils_2.createEffectExpression} CallExpression > Identifier[name='withLatestFrom']`](node) {
+                    context.report({
+                        node,
+                        messageId: exports.messageId,
+                        fix: (fixer) => getFixes(context.getSourceCode(), fixer, node),
+                    });
+                },
+            };
+        }
+        const { identifiers = [], sourceCode } = (0, utils_2.getNgRxEffectActions)(context);
+        const actionsNames = identifiers.length > 0 ? (0, utils_2.asPattern)(identifiers) : null;
+        if (!actionsNames) {
+            return {};
+        }
+        return {
+            [`${utils_2.createEffectExpression} ${(0, utils_2.namedExpression)(actionsNames)} > CallExpression[arguments.length=1] > Identifier[name='${withLatestFromKeyword}']`](node) {
+                context.report({
+                    node,
+                    messageId: exports.messageId,
+                    fix: (fixer) => getFixes(sourceCode, fixer, node),
+                });
+            },
+            [`${utils_2.createEffectExpression} ${(0, utils_2.namedExpression)(actionsNames)} > CallExpression[arguments.length>1] > Identifier[name='${withLatestFromKeyword}']`](node) {
+                context.report({
+                    node,
+                    messageId: exports.messageId,
+                });
+            },
+        };
+    },
+});
+function getFixes(sourceCode, fixer, node) {
+    const { parent } = node;
+    const isUsingDeprecatedProjectorArgument = parent.arguments.length > 1;
+    const [firstArgument] = parent.arguments;
+    const nextToken = isUsingDeprecatedProjectorArgument &&
+        sourceCode.getTokenAfter(firstArgument);
+    return [
+        fixer.replaceText(node, concatLatestFromKeyword),
+        ...(firstArgument.type == utils_1.AST_NODE_TYPES.ArrowFunctionExpression
+            ? []
+            : [fixer.insertTextBefore(firstArgument, '() => ')]),
+    ].concat((0, utils_2.getImportAddFix)({
+        fixer,
+        importName: concatLatestFromKeyword,
+        moduleName: utils_2.NGRX_MODULE_PATHS.operators,
+        node,
+    }), ...(isUsingDeprecatedProjectorArgument && nextToken
+        ? [
+            (0, utils_2.getImportAddFix)({
+                fixer,
+                importName: 'map',
+                moduleName: 'rxjs/operators',
+                node,
+            }),
+            fixer.insertTextAfterRange(nextToken.range, '), map('),
+        ]
+        : []));
+}
+//# sourceMappingURL=prefer-concat-latest-from.js.map

package/src/rules/operators/prefer-concat-latest-from.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"prefer-concat-latest-from.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/operators/prefer-concat-latest-from.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;AAAA,oDAIkC;AAClC,2CAA6B;AAC7B,qDAAgD;AAChD,uCAOqB;AAER,QAAA,SAAS,GAAG,wBAAwB,CAAC;AAQlD,MAAM,cAAc,GAAoB,EAAE,MAAM,EAAE,KAAK,EAAE,CAAC;AAC1D,MAAM,uBAAuB,GAAG,kBAAkB,CAAC;AACnD,MAAM,qBAAqB,GAAG,gBAAgB,CAAC;AAE/C,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,UAAU,EAAE,WAAW;QACvB,IAAI,EAAE;YACJ,WAAW,EAAE,SAAS,uBAAuB,mBAAmB,qBAAqB,oFAAoF;SAC1K;QACD,OAAO,EAAE,MAAM;QACf,MAAM,EAAE;YACN;gBACE,IAAI,EAAE,QAAQ;gBACd,UAAU,EAAE;oBACV,MAAM,EAAE;wBACN,IAAI,EAAE,SAAS;wBACf,OAAO,EAAE,cAAc,CAAC,MAAM;qBAC/B;iBACF;gBACD,oBAAoB,EAAE,KAAK;aAC5B;SACF;QACD,QAAQ,EAAE;YACR,CAAC,iBAAS,CAAC,EAAE,SAAS,uBAAuB,mBAAmB,qBAAqB,KAAK;SAC3F;KACF;IACD,cAAc,EAAE,CAAC,cAAc,CAAC;IAChC,MAAM,EAAE,CAAC,OAAO,EAAE,CAAC,OAAO,CAAC,EAAE,EAAE;QAC7B,IAAI,OAAO,CAAC,MAAM,EAAE,CAAC;YACnB,OAAO;gBACL,CAAC,GAAG,8BAAsB,qDAAqD,CAAC,CAC9E,IAA8B;oBAE9B,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI;wBACJ,SAAS,EAAT,iBAAS;wBACT,GAAG,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,QAAQ,CAAC,OAAO,CAAC,aAAa,EAAE,EAAE,KAAK,EAAE,IAAI,CAAC;qBAC/D,CAAC,CAAC;gBACL,CAAC;aACF,CAAC;QACJ,CAAC;QAED,MAAM,EAAE,WAAW,GAAG,EAAE,EAAE,UAAU,EAAE,GAAG,IAAA,4BAAoB,EAAC,OAAO,CAAC,CAAC;QACvE,MAAM,YAAY,GAAG,WAAW,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,IAAA,iBAAS,EAAC,WAAW,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;QAE5E,IAAI,CAAC,YAAY,EAAE,CAAC;YAClB,OAAO,EAAE,CAAC;QACZ,CAAC;QAED,OAAO;YACL,CAAC,GAAG,8BAAsB,IAAI,IAAA,uBAAe,EAC3C,YAAY,CACb,4DAA4D,qBAAqB,IAAI,CAAC,CACrF,IAA8B;gBAE9B,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI;oBACJ,SAAS,EAAT,iBAAS;oBACT,GAAG,EAAE,CAAC,KAAK,EAAE,EAAE,CAAC,QAAQ,CAAC,UAAU,EAAE,KAAK,EAAE,IAAI,CAAC;iBAClD,CAAC,CAAC;YACL,CAAC;YACD,CAAC,GAAG,8BAAsB,IAAI,IAAA,uBAAe,EAC3C,YAAY,CACb,4DAA4D,qBAAqB,IAAI,CAAC,CACrF,IAA8B;gBAE9B,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI;oBACJ,SAAS,EAAT,iBAAS;iBACV,CAAC,CAAC;YACL,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC;AAEH,SAAS,QAAQ,CACf,UAAyC,EACzC,KAAyB,EACzB,IAA8B;IAE9B,MAAM,EAAE,MAAM,EAAE,GAAG,IAAI,CAAC;IACxB,MAAM,kCAAkC,GAAG,MAAM,CAAC,SAAS,CAAC,MAAM,GAAG,CAAC,CAAC;IACvE,MAAM,CAAC,aAAa,CAAC,GAAG,MAAM,CAAC,SAAS,CAAC;IACzC,MAAM,SAAS,GACb,kCAAkC;QAClC,UAAU,CAAC,aAAa,CAAC,aAAa,CAAC,CAAC;IAC1C,OAAO;QACL,KAAK,CAAC,WAAW,CAAC,IAAI,EAAE,uBAAuB,CAAC;QAChD,GAAG,CAAC,aAAa,CAAC,IAAI,IAAI,sBAAc,CAAC,uBAAuB;YAC9D,CAAC,CAAC,EAAE;YACJ,CAAC,CAAC,CAAC,KAAK,CAAC,gBAAgB,CAAC,aAAa,EAAE,QAAQ,CAAC,CAAC,CAAC;KACvD,CAAC,MAAM,CACN,IAAA,uBAAe,EAAC;QACd,KAAK;QACL,UAAU,EAAE,uBAAuB;QACnC,UAAU,EAAE,yBAAiB,CAAC,SAAS;QACvC,IAAI;KACL,CAAC,EACF,GAAG,CAAC,kCAAkC,IAAI,SAAS;QACjD,CAAC,CAAC;YACE,IAAA,uBAAe,EAAC;gBACd,KAAK;gBACL,UAAU,EAAE,KAAK;gBACjB,UAAU,EAAE,gBAAgB;gBAC5B,IAAI;aACL,CAAC;YACF,KAAK,CAAC,oBAAoB,CAAC,SAAS,CAAC,KAAK,EAAE,SAAS,CAAC;SACvD;QACH,CAAC,CAAC,EAAE,CAAC,CACR,CAAC;AACJ,CAAC","sourcesContent":["import {\n  AST_NODE_TYPES,\n  type TSESLint,\n  type TSESTree,\n} from '@typescript-eslint/utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  asPattern,\n  createEffectExpression,\n  getImportAddFix,\n  getNgRxEffectActions,\n  namedExpression,\n  NGRX_MODULE_PATHS,\n} from '../../utils';\n\nexport const messageId = 'preferConcatLatestFrom';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [{ readonly strict: boolean }];\ntype WithLatestFromIdentifier = TSESTree.Identifier & {\n  parent: TSESTree.CallExpression;\n};\n\nconst defaultOptions: Options[number] = { strict: false };\nconst concatLatestFromKeyword = 'concatLatestFrom';\nconst withLatestFromKeyword = 'withLatestFrom';\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'problem',\n    ngrxModule: 'operators',\n    docs: {\n      description: `Use \\`${concatLatestFromKeyword}\\` instead of \\`${withLatestFromKeyword}\\` to prevent the selector from firing until the correct \\`Action\\` is dispatched.`,\n    },\n    fixable: 'code',\n    schema: [\n      {\n        type: 'object',\n        properties: {\n          strict: {\n            type: 'boolean',\n            default: defaultOptions.strict,\n          },\n        },\n        additionalProperties: false,\n      },\n    ],\n    messages: {\n      [messageId]: `Use \\`${concatLatestFromKeyword}\\` instead of \\`${withLatestFromKeyword}\\`.`,\n    },\n  },\n  defaultOptions: [defaultOptions],\n  create: (context, [options]) => {\n    if (options.strict) {\n      return {\n        [`${createEffectExpression} CallExpression > Identifier[name='withLatestFrom']`](\n          node: WithLatestFromIdentifier\n        ) {\n          context.report({\n            node,\n            messageId,\n            fix: (fixer) => getFixes(context.getSourceCode(), fixer, node),\n          });\n        },\n      };\n    }\n\n    const { identifiers = [], sourceCode } = getNgRxEffectActions(context);\n    const actionsNames = identifiers.length > 0 ? asPattern(identifiers) : null;\n\n    if (!actionsNames) {\n      return {};\n    }\n\n    return {\n      [`${createEffectExpression} ${namedExpression(\n        actionsNames\n      )} > CallExpression[arguments.length=1] > Identifier[name='${withLatestFromKeyword}']`](\n        node: WithLatestFromIdentifier\n      ) {\n        context.report({\n          node,\n          messageId,\n          fix: (fixer) => getFixes(sourceCode, fixer, node),\n        });\n      },\n      [`${createEffectExpression} ${namedExpression(\n        actionsNames\n      )} > CallExpression[arguments.length>1] > Identifier[name='${withLatestFromKeyword}']`](\n        node: WithLatestFromIdentifier\n      ) {\n        context.report({\n          node,\n          messageId,\n        });\n      },\n    };\n  },\n});\n\nfunction getFixes(\n  sourceCode: Readonly<TSESLint.SourceCode>,\n  fixer: TSESLint.RuleFixer,\n  node: WithLatestFromIdentifier\n) {\n  const { parent } = node;\n  const isUsingDeprecatedProjectorArgument = parent.arguments.length > 1;\n  const [firstArgument] = parent.arguments;\n  const nextToken =\n    isUsingDeprecatedProjectorArgument &&\n    sourceCode.getTokenAfter(firstArgument);\n  return [\n    fixer.replaceText(node, concatLatestFromKeyword),\n    ...(firstArgument.type == AST_NODE_TYPES.ArrowFunctionExpression\n      ? []\n      : [fixer.insertTextBefore(firstArgument, '() => ')]),\n  ].concat(\n    getImportAddFix({\n      fixer,\n      importName: concatLatestFromKeyword,\n      moduleName: NGRX_MODULE_PATHS.operators,\n      node,\n    }),\n    ...(isUsingDeprecatedProjectorArgument && nextToken\n      ? [\n          getImportAddFix({\n            fixer,\n            importName: 'map',\n            moduleName: 'rxjs/operators',\n            node,\n          }),\n          fixer.insertTextAfterRange(nextToken.range, '), map('),\n        ]\n      : [])\n  );\n}\n"]}

package/src/rules/signals/signal-state-no-arrays-at-root-level.d.ts

@@ -0,0 +1,3 @@
+export declare const messageId = "signalStateNoArraysAtRootLevel";
+declare const _default: import("@typescript-eslint/utils/ts-eslint").RuleModule<"signalStateNoArraysAtRootLevel", readonly [], import("@typescript-eslint/utils/ts-eslint").RuleListener>;
+export default _default;

package/src/rules/signals/signal-state-no-arrays-at-root-level.js

@@ -0,0 +1,59 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || function (mod) {
+    if (mod && mod.__esModule) return mod;
+    var result = {};
+    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
+    __setModuleDefault(result, mod);
+    return result;
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.messageId = void 0;
+const path = __importStar(require("path"));
+const rule_creator_1 = require("../../rule-creator");
+const utils_1 = require("../../utils");
+exports.messageId = 'signalStateNoArraysAtRootLevel';
+exports.default = (0, rule_creator_1.createRule)({
+    name: path.parse(__filename).name,
+    meta: {
+        type: 'problem',
+        ngrxModule: 'signals',
+        docs: {
+            description: `signalState should accept a record or dictionary as an input argument.`,
+        },
+        schema: [],
+        messages: {
+            [exports.messageId]: `Wrap the array in an record or dictionary.`,
+        },
+    },
+    defaultOptions: [],
+    create: (context) => {
+        return {
+            [`CallExpression[callee.name=signalState]`](node) {
+                const [argument] = node.arguments;
+                if ((0, utils_1.isArrayExpression)(argument)) {
+                    context.report({
+                        node: argument,
+                        messageId: exports.messageId,
+                    });
+                }
+            },
+        };
+    },
+});
+//# sourceMappingURL=signal-state-no-arrays-at-root-level.js.map

package/src/rules/signals/signal-state-no-arrays-at-root-level.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"signal-state-no-arrays-at-root-level.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/signals/signal-state-no-arrays-at-root-level.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;AACA,2CAA6B;AAC7B,qDAAgD;AAChD,uCAAgD;AAEnC,QAAA,SAAS,GAAG,gCAAgC,CAAC;AAK1D,kBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EAAE,wEAAwE;SACtF;QACD,MAAM,EAAE,EAAE;QACV,QAAQ,EAAE;YACR,CAAC,iBAAS,CAAC,EAAE,4CAA4C;SAC1D;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,CAAC,OAAO,EAAE,EAAE;QAClB,OAAO;YACL,CAAC,yCAAyC,CAAC,CACzC,IAA6B;gBAE7B,MAAM,CAAC,QAAQ,CAAC,GAAG,IAAI,CAAC,SAAS,CAAC;gBAClC,IAAI,IAAA,yBAAiB,EAAC,QAAQ,CAAC,EAAE,CAAC;oBAChC,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,QAAQ;wBACd,SAAS,EAAT,iBAAS;qBACV,CAAC,CAAC;gBACL,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import { type TSESTree } from '@typescript-eslint/utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport { isArrayExpression } from '../../utils';\n\nexport const messageId = 'signalStateNoArraysAtRootLevel';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'problem',\n    ngrxModule: 'signals',\n    docs: {\n      description: `signalState should accept a record or dictionary as an input argument.`,\n    },\n    schema: [],\n    messages: {\n      [messageId]: `Wrap the array in an record or dictionary.`,\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    return {\n      [`CallExpression[callee.name=signalState]`](\n        node: TSESTree.CallExpression\n      ) {\n        const [argument] = node.arguments;\n        if (isArrayExpression(argument)) {\n          context.report({\n            node: argument,\n            messageId,\n          });\n        }\n      },\n    };\n  },\n});\n"]}

package/src/rules/signals/with-state-no-arrays-at-root-level.d.ts

@@ -0,0 +1,4 @@
+import { ESLintUtils } from '@typescript-eslint/utils';
+export declare const messageId = "withStateNoArraysAtRootLevel";
+declare const _default: ESLintUtils.RuleModule<"withStateNoArraysAtRootLevel", readonly [], ESLintUtils.RuleListener>;
+export default _default;

package/src/rules/signals/with-state-no-arrays-at-root-level.js

@@ -0,0 +1,72 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || function (mod) {
+    if (mod && mod.__esModule) return mod;
+    var result = {};
+    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
+    __setModuleDefault(result, mod);
+    return result;
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.messageId = void 0;
+const utils_1 = require("@typescript-eslint/utils");
+const path = __importStar(require("path"));
+const rule_creator_1 = require("../../rule-creator");
+const utils_2 = require("../../utils");
+exports.messageId = 'withStateNoArraysAtRootLevel';
+exports.default = (0, rule_creator_1.createRule)({
+    name: path.parse(__filename).name,
+    meta: {
+        type: 'problem',
+        ngrxModule: 'signals',
+        docs: {
+            description: `withState should accept a record or dictionary as an input argument.`,
+            requiresTypeChecking: true,
+        },
+        schema: [],
+        messages: {
+            [exports.messageId]: `Wrap the array in an record or dictionary.`,
+        },
+    },
+    defaultOptions: [],
+    create: (context) => {
+        return {
+            [`CallExpression[callee.name=withState]`](node) {
+                const [argument] = node.arguments;
+                if ((0, utils_2.isArrayExpression)(argument)) {
+                    context.report({
+                        node: argument,
+                        messageId: exports.messageId,
+                    });
+                }
+                else if (argument) {
+                    const services = utils_1.ESLintUtils.getParserServices(context);
+                    const typeChecker = services.program.getTypeChecker();
+                    const type = services.getTypeAtLocation(argument);
+                    if (typeChecker.isArrayType(type)) {
+                        context.report({
+                            node: argument,
+                            messageId: exports.messageId,
+                        });
+                    }
+                }
+            },
+        };
+    },
+});
+//# sourceMappingURL=with-state-no-arrays-at-root-level.js.map