@ngrx/eslint-plugin 14.0.0-beta.0

package/src/rule-creator.js

@@ -0,0 +1,29 @@
+"use strict";
+var __assign = (this && this.__assign) || function () {
+    __assign = Object.assign || function(t) {
+        for (var s, i = 1, n = arguments.length; i < n; i++) {
+            s = arguments[i];
+            for (var p in s) if (Object.prototype.hasOwnProperty.call(s, p))
+                t[p] = s[p];
+        }
+        return t;
+    };
+    return __assign.apply(this, arguments);
+};
+exports.__esModule = true;
+exports.createRule = void 0;
+var experimental_utils_1 = require("@typescript-eslint/experimental-utils");
+var utils_1 = require("./utils");
+function createRule(config) {
+    var configOverwrite = __assign(__assign({}, config), { create: function (context, optionsWithDefault) {
+            var _a = config.meta, ngrxModule = _a.ngrxModule, version = _a.version;
+            if (version !== undefined &&
+                !(0, utils_1.ngrxVersionSatisfies)(utils_1.NGRX_MODULE_PATHS[ngrxModule], version)) {
+                return {};
+            }
+            return config.create(context, optionsWithDefault);
+        } });
+    return experimental_utils_1.ESLintUtils.RuleCreator(utils_1.docsUrl)(configOverwrite);
+}
+exports.createRule = createRule;
+//# sourceMappingURL=rule-creator.js.map

package/src/rule-creator.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"rule-creator.js","sourceRoot":"","sources":["../../../../modules/eslint-plugin/src/rule-creator.ts"],"names":[],"mappings":";;;;;;;;;;;;;;AACA,4EAAoE;AAEpE,iCAA2E;AAiB3E,SAAgB,UAAU,CAIxB,MAQE;IAEF,IAAM,eAAe,yBAChB,MAAM,KACT,MAAM,EAAE,UACN,OAA8D,EAC9D,kBAAsC;YAGpC,IAAA,KACE,MAAM,KADqB,EAArB,UAAU,gBAAA,EAAE,OAAO,aAAE,CACpB;YACX,IACE,OAAO,KAAK,SAAS;gBACrB,CAAC,IAAA,4BAAoB,EAAC,yBAAiB,CAAC,UAAU,CAAC,EAAE,OAAO,CAAC,EAC7D;gBACA,OAAO,EAAE,CAAC;aACX;YAED,OAAO,MAAM,CAAC,MAAM,CAAC,OAAO,EAAE,kBAAkB,CAAC,CAAC;QACpD,CAAC,GACF,CAAC;IAEF,OAAO,gCAAW,CAAC,WAAW,CAAC,eAAO,CAAC,CAAC,eAAe,CAAC,CAAC;AAC3D,CAAC;AAnCD,gCAmCC","sourcesContent":["import type { TSESLint } from '@typescript-eslint/experimental-utils';\nimport { ESLintUtils } from '@typescript-eslint/experimental-utils';\nimport type { NGRX_MODULE } from './utils';\nimport { docsUrl, ngrxVersionSatisfies, NGRX_MODULE_PATHS } from './utils';\n\ntype Meta<TMessageIds extends string> =\n  | TSESLint.RuleMetaData<TMessageIds> & {\n      ngrxModule: NGRX_MODULE;\n      version?: string;\n    };\ntype CreateRuleMeta<TMessageIds extends string> = {\n  docs: Omit<TSESLint.RuleMetaDataDocs, 'url'>;\n} & Omit<Meta<TMessageIds>, 'docs'>;\nexport type NgRxRuleModule<\n  TOptions extends readonly unknown[],\n  TMessageIds extends string\n> = Omit<TSESLint.RuleModule<TMessageIds, TOptions>, 'meta'> & {\n  meta: Meta<TMessageIds>;\n};\n\nexport function createRule<\n  TOptions extends readonly unknown[],\n  TMessageIds extends string\n>(\n  config: Readonly<{\n    name: string;\n    meta: CreateRuleMeta<TMessageIds>;\n    defaultOptions: Readonly<TOptions>;\n    create: (\n      context: Readonly<TSESLint.RuleContext<TMessageIds, TOptions>>,\n      optionsWithDefault: Readonly<TOptions>\n    ) => TSESLint.RuleListener;\n  }>\n): TSESLint.RuleModule<TMessageIds, TOptions> {\n  const configOverwrite = {\n    ...config,\n    create: (\n      context: Readonly<TSESLint.RuleContext<TMessageIds, TOptions>>,\n      optionsWithDefault: Readonly<TOptions>\n    ) => {\n      const {\n        meta: { ngrxModule, version },\n      } = config;\n      if (\n        version !== undefined &&\n        !ngrxVersionSatisfies(NGRX_MODULE_PATHS[ngrxModule], version)\n      ) {\n        return {};\n      }\n\n      return config.create(context, optionsWithDefault);\n    },\n  };\n\n  return ESLintUtils.RuleCreator(docsUrl)(configOverwrite);\n}\n"]}

package/src/rules/component-store/updater-explicit-return-type.js

@@ -0,0 +1,69 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || function (mod) {
+    if (mod && mod.__esModule) return mod;
+    var result = {};
+    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
+    __setModuleDefault(result, mod);
+    return result;
+};
+var _a;
+exports.__esModule = true;
+exports.messageId = void 0;
+var path = __importStar(require("path"));
+var rule_creator_1 = require("../../rule-creator");
+var utils_1 = require("../../utils");
+exports.messageId = 'updaterExplicitReturnType';
+exports["default"] = (0, rule_creator_1.createRule)({
+    name: path.parse(__filename).name,
+    meta: {
+        type: 'problem',
+        ngrxModule: 'component-store',
+        docs: {
+            description: '`Updater` should have an explicit return type.',
+            recommended: 'warn'
+        },
+        schema: [],
+        messages: (_a = {},
+            _a[exports.messageId] = '`Updater` should have an explicit return type when using arrow functions: `this.store.updater((state, value): State => {}`.',
+            _a)
+    },
+    defaultOptions: [],
+    create: function (context) {
+        var _a;
+        var _b = (0, utils_1.getNgRxComponentStores)(context).identifiers, identifiers = _b === void 0 ? [] : _b;
+        var storeNames = identifiers.length > 0 ? (0, utils_1.asPattern)(identifiers) : null;
+        var withoutTypeAnnotation = "ArrowFunctionExpression:not([returnType.typeAnnotation])";
+        var selectors = [
+            "ClassDeclaration[superClass.name='ComponentStore'] CallExpression[callee.object.type='ThisExpression'][callee.property.name='updater'] > ".concat(withoutTypeAnnotation),
+            storeNames &&
+                "".concat((0, utils_1.namedExpression)(storeNames), "[callee.property.name='updater'] > ").concat(withoutTypeAnnotation),
+        ]
+            .filter(Boolean)
+            .join(',');
+        return _a = {},
+            _a[selectors] = function (node) {
+                context.report({
+                    node: node,
+                    messageId: exports.messageId
+                });
+            },
+            _a;
+    }
+});
+//# sourceMappingURL=updater-explicit-return-type.js.map

package/src/rules/component-store/updater-explicit-return-type.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"updater-explicit-return-type.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/component-store/updater-explicit-return-type.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;AACA,yCAA6B;AAC7B,mDAAgD;AAChD,qCAIqB;AAER,QAAA,SAAS,GAAG,2BAA2B,CAAC;AAKrD,qBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,UAAU,EAAE,iBAAiB;QAC7B,IAAI,EAAE;YACJ,WAAW,EAAE,gDAAgD;YAC7D,WAAW,EAAE,MAAM;SACpB;QACD,MAAM,EAAE,EAAE;QACV,QAAQ;YACN,GAAC,iBAAS,IACR,6HAA6H;eAChI;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,UAAC,OAAO;;QACN,IAAA,KAAqB,IAAA,8BAAsB,EAAC,OAAO,CAAC,YAApC,EAAhB,WAAW,mBAAG,EAAE,KAAA,CAAqC;QAC7D,IAAM,UAAU,GAAG,WAAW,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,IAAA,iBAAS,EAAC,WAAW,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;QAC1E,IAAM,qBAAqB,GAAG,0DAA0D,CAAC;QACzF,IAAM,SAAS,GAAG;YAChB,mJAA4I,qBAAqB,CAAE;YACnK,UAAU;gBACR,UAAG,IAAA,uBAAe,EAChB,UAAU,CACX,gDAAsC,qBAAqB,CAAE;SACjE;aACE,MAAM,CAAC,OAAO,CAAC;aACf,IAAI,CAAC,GAAG,CAAC,CAAC;QAEb;YACE,GAAC,SAAS,IAAV,UAAY,IAAsC;gBAChD,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI,MAAA;oBACJ,SAAS,mBAAA;iBACV,CAAC,CAAC;YACL,CAAC;eACD;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/experimental-utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  asPattern,\n  getNgRxComponentStores,\n  namedExpression,\n} from '../../utils';\n\nexport const messageId = 'updaterExplicitReturnType';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'problem',\n    ngrxModule: 'component-store',\n    docs: {\n      description: '`Updater` should have an explicit return type.',\n      recommended: 'warn',\n    },\n    schema: [],\n    messages: {\n      [messageId]:\n        '`Updater` should have an explicit return type when using arrow functions: `this.store.updater((state, value): State => {}`.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const { identifiers = [] } = getNgRxComponentStores(context);\n    const storeNames = identifiers.length > 0 ? asPattern(identifiers) : null;\n    const withoutTypeAnnotation = `ArrowFunctionExpression:not([returnType.typeAnnotation])`;\n    const selectors = [\n      `ClassDeclaration[superClass.name='ComponentStore'] CallExpression[callee.object.type='ThisExpression'][callee.property.name='updater'] > ${withoutTypeAnnotation}`,\n      storeNames &&\n        `${namedExpression(\n          storeNames\n        )}[callee.property.name='updater'] > ${withoutTypeAnnotation}`,\n    ]\n      .filter(Boolean)\n      .join(',');\n\n    return {\n      [selectors](node: TSESTree.ArrowFunctionExpression) {\n        context.report({\n          node,\n          messageId,\n        });\n      },\n    };\n  },\n});\n"]}

package/src/rules/effects/avoid-cyclic-effects.js

@@ -0,0 +1,202 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || function (mod) {
+    if (mod && mod.__esModule) return mod;
+    var result = {};
+    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
+    __setModuleDefault(result, mod);
+    return result;
+};
+var __read = (this && this.__read) || function (o, n) {
+    var m = typeof Symbol === "function" && o[Symbol.iterator];
+    if (!m) return o;
+    var i = m.call(o), r, ar = [], e;
+    try {
+        while ((n === void 0 || n-- > 0) && !(r = i.next()).done) ar.push(r.value);
+    }
+    catch (error) { e = { error: error }; }
+    finally {
+        try {
+            if (r && !r.done && (m = i["return"])) m.call(i);
+        }
+        finally { if (e) throw e.error; }
+    }
+    return ar;
+};
+var __values = (this && this.__values) || function(o) {
+    var s = typeof Symbol === "function" && Symbol.iterator, m = s && o[s], i = 0;
+    if (m) return m.call(o);
+    if (o && typeof o.length === "number") return {
+        next: function () {
+            if (o && i >= o.length) o = void 0;
+            return { value: o && o[i++], done: !o };
+        }
+    };
+    throw new TypeError(s ? "Object is not iterable." : "Symbol.iterator is not defined.");
+};
+var __spreadArray = (this && this.__spreadArray) || function (to, from, pack) {
+    if (pack || arguments.length === 2) for (var i = 0, l = from.length, ar; i < l; i++) {
+        if (ar || !(i in from)) {
+            if (!ar) ar = Array.prototype.slice.call(from, 0, i);
+            ar[i] = from[i];
+        }
+    }
+    return to.concat(ar || Array.prototype.slice.call(from));
+};
+var _a;
+exports.__esModule = true;
+exports.messageId = void 0;
+var eslint_etc_1 = require("eslint-etc");
+var path = __importStar(require("path"));
+var ts = __importStar(require("typescript"));
+var rule_creator_1 = require("../../rule-creator");
+var utils_1 = require("../../utils");
+exports.messageId = 'avoidCyclicEffects';
+// This rule is a modified version (to support dispatch: false) from the eslint-plugin-rxjs plugin.
+// The original implementation can be found at https://github.com/cartant/eslint-plugin-rxjs/blob/main/source/rules/no-cyclic-action.ts
+// Thank you Nicholas Jamieson (@cartant).
+exports["default"] = (0, rule_creator_1.createRule)({
+    name: path.parse(__filename).name,
+    meta: {
+        type: 'problem',
+        ngrxModule: 'effects',
+        docs: {
+            description: 'Avoid `Effect` that re-emit filtered actions.',
+            recommended: 'warn',
+            requiresTypeChecking: true
+        },
+        schema: [],
+        messages: (_a = {},
+            _a[exports.messageId] = '`Effect` that re-emit filtered actions are forbidden.',
+            _a)
+    },
+    defaultOptions: [],
+    create: function (context) {
+        var _a;
+        var _b = (0, utils_1.getNgRxEffectActions)(context).identifiers, identifiers = _b === void 0 ? [] : _b;
+        var actionsNames = identifiers.length > 0 ? (0, utils_1.asPattern)(identifiers) : null;
+        if (!actionsNames) {
+            return {};
+        }
+        var _c = (0, eslint_etc_1.getTypeServices)(context), getType = _c.getType, typeChecker = _c.typeChecker;
+        function checkNode(pipeCallExpression) {
+            var e_1, _a;
+            var operatorCallExpression = pipeCallExpression.arguments.find(function (arg) {
+                return (0, utils_1.isCallExpression)(arg) &&
+                    (0, utils_1.isIdentifier)(arg.callee) &&
+                    arg.callee.name === 'ofType';
+            });
+            if (!operatorCallExpression) {
+                return;
+            }
+            var operatorType = getType(operatorCallExpression);
+            var _b = __read(typeChecker.getSignaturesOfType(operatorType, ts.SignatureKind.Call), 1), signature = _b[0];
+            if (!signature) {
+                return;
+            }
+            var operatorReturnType = typeChecker.getReturnTypeOfSignature(signature);
+            if (!(0, utils_1.isTypeReference)(operatorReturnType)) {
+                return;
+            }
+            var _c = __read(typeChecker.getTypeArguments(operatorReturnType), 1), operatorElementType = _c[0];
+            if (!operatorElementType) {
+                return;
+            }
+            var pipeType = getType(pipeCallExpression);
+            if (!(0, utils_1.isTypeReference)(pipeType)) {
+                return;
+            }
+            var _d = __read(typeChecker.getTypeArguments(pipeType), 1), pipeElementType = _d[0];
+            if (!pipeElementType) {
+                return;
+            }
+            var operatorActionTypes = getActionTypes(operatorElementType);
+            var pipeActionTypes = getActionTypes(pipeElementType);
+            try {
+                for (var operatorActionTypes_1 = __values(operatorActionTypes), operatorActionTypes_1_1 = operatorActionTypes_1.next(); !operatorActionTypes_1_1.done; operatorActionTypes_1_1 = operatorActionTypes_1.next()) {
+                    var actionType = operatorActionTypes_1_1.value;
+                    if (pipeActionTypes.includes(actionType)) {
+                        context.report({
+                            node: pipeCallExpression.callee,
+                            messageId: exports.messageId
+                        });
+                        return;
+                    }
+                }
+            }
+            catch (e_1_1) { e_1 = { error: e_1_1 }; }
+            finally {
+                try {
+                    if (operatorActionTypes_1_1 && !operatorActionTypes_1_1.done && (_a = operatorActionTypes_1["return"])) _a.call(operatorActionTypes_1);
+                }
+                finally { if (e_1) throw e_1.error; }
+            }
+        }
+        function getActionType(symbol) {
+            var valueDeclaration = symbol.valueDeclaration;
+            if (!valueDeclaration) {
+                return null;
+            }
+            if (valueDeclaration.kind === ts.SyntaxKind.PropertyDeclaration) {
+                var parent_1 = symbol.parent;
+                return parent_1.valueDeclaration
+                    ? typeChecker.getTypeOfSymbolAtLocation(parent_1, parent_1.valueDeclaration)
+                    : null;
+            }
+            return typeChecker.getTypeOfSymbolAtLocation(symbol, valueDeclaration);
+        }
+        function getActionTypes(type) {
+            var e_2, _a;
+            if (type.isUnion()) {
+                var memberActionTypes = [];
+                try {
+                    for (var _b = __values(type.types), _c = _b.next(); !_c.done; _c = _b.next()) {
+                        var memberType = _c.value;
+                        memberActionTypes.push.apply(memberActionTypes, __spreadArray([], __read(getActionTypes(memberType)), false));
+                    }
+                }
+                catch (e_2_1) { e_2 = { error: e_2_1 }; }
+                finally {
+                    try {
+                        if (_c && !_c.done && (_a = _b["return"])) _a.call(_b);
+                    }
+                    finally { if (e_2) throw e_2.error; }
+                }
+                return memberActionTypes;
+            }
+            var symbol = typeChecker.getPropertyOfType(type, 'type');
+            if (!symbol) {
+                return [];
+            }
+            var actionType = getActionType(symbol);
+            if (!actionType) {
+                return [];
+            }
+            // TODO: support "dynamic" types
+            // e.g. const genericFoo = createAction(`${subject} FOO`); (resolves to 'string')
+            if (typeChecker.typeToString(actionType) === 'string') {
+                return [];
+            }
+            return [typeChecker.typeToString(actionType)];
+        }
+        return _a = {},
+            _a["".concat(utils_1.createEffectExpression, ":not([arguments.1]:has(Property[key.name='dispatch'][value.value=false])) CallExpression[callee.property.name='pipe'][callee.object.property.name=").concat(actionsNames, "]")] = checkNode,
+            _a;
+    }
+});
+//# sourceMappingURL=avoid-cyclic-effects.js.map

package/src/rules/effects/avoid-cyclic-effects.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"avoid-cyclic-effects.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/effects/avoid-cyclic-effects.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;AACA,yCAA6C;AAC7C,yCAA6B;AAC7B,6CAAiC;AACjC,mDAAgD;AAChD,qCAOqB;AAER,QAAA,SAAS,GAAG,oBAAoB,CAAC;AAK9C,mGAAmG;AACnG,uIAAuI;AACvI,0CAA0C;AAE1C,qBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EAAE,+CAA+C;YAC5D,WAAW,EAAE,MAAM;YACnB,oBAAoB,EAAE,IAAI;SAC3B;QACD,MAAM,EAAE,EAAE;QACV,QAAQ;YACN,GAAC,iBAAS,IAAG,uDAAuD;eACrE;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,UAAC,OAAO;;QACN,IAAA,KAAqB,IAAA,4BAAoB,EAAC,OAAO,CAAC,YAAlC,EAAhB,WAAW,mBAAG,EAAE,KAAA,CAAmC;QAC3D,IAAM,YAAY,GAAG,WAAW,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,IAAA,iBAAS,EAAC,WAAW,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;QAE5E,IAAI,CAAC,YAAY,EAAE;YACjB,OAAO,EAAE,CAAC;SACX;QAEK,IAAA,KAA2B,IAAA,4BAAe,EAAC,OAAO,CAAC,EAAjD,OAAO,aAAA,EAAE,WAAW,iBAA6B,CAAC;QAE1D,SAAS,SAAS,CAAC,kBAA2C;;YAC5D,IAAM,sBAAsB,GAAG,kBAAkB,CAAC,SAAS,CAAC,IAAI,CAC9D,UAAC,GAAG;gBACF,OAAA,IAAA,wBAAgB,EAAC,GAAG,CAAC;oBACrB,IAAA,oBAAY,EAAC,GAAG,CAAC,MAAM,CAAC;oBACxB,GAAG,CAAC,MAAM,CAAC,IAAI,KAAK,QAAQ;YAF5B,CAE4B,CAC/B,CAAC;YACF,IAAI,CAAC,sBAAsB,EAAE;gBAC3B,OAAO;aACR;YACD,IAAM,YAAY,GAAG,OAAO,CAAC,sBAAsB,CAAC,CAAC;YAC/C,IAAA,KAAA,OAAc,WAAW,CAAC,mBAAmB,CACjD,YAAY,EACZ,EAAE,CAAC,aAAa,CAAC,IAAI,CACtB,IAAA,EAHM,SAAS,QAGf,CAAC;YAEF,IAAI,CAAC,SAAS,EAAE;gBACd,OAAO;aACR;YACD,IAAM,kBAAkB,GACtB,WAAW,CAAC,wBAAwB,CAAC,SAAS,CAAC,CAAC;YAClD,IAAI,CAAC,IAAA,uBAAe,EAAC,kBAAkB,CAAC,EAAE;gBACxC,OAAO;aACR;YACK,IAAA,KAAA,OACJ,WAAW,CAAC,gBAAgB,CAAC,kBAAkB,CAAC,IAAA,EAD3C,mBAAmB,QACwB,CAAC;YACnD,IAAI,CAAC,mBAAmB,EAAE;gBACxB,OAAO;aACR;YAED,IAAM,QAAQ,GAAG,OAAO,CAAC,kBAAkB,CAAC,CAAC;YAC7C,IAAI,CAAC,IAAA,uBAAe,EAAC,QAAQ,CAAC,EAAE;gBAC9B,OAAO;aACR;YACK,IAAA,KAAA,OAAoB,WAAW,CAAC,gBAAgB,CAAC,QAAQ,CAAC,IAAA,EAAzD,eAAe,QAA0C,CAAC;YACjE,IAAI,CAAC,eAAe,EAAE;gBACpB,OAAO;aACR;YAED,IAAM,mBAAmB,GAAG,cAAc,CAAC,mBAAmB,CAAC,CAAC;YAChE,IAAM,eAAe,GAAG,cAAc,CAAC,eAAe,CAAC,CAAC;;gBAExD,KAAyB,IAAA,wBAAA,SAAA,mBAAmB,CAAA,wDAAA,yFAAE;oBAAzC,IAAM,UAAU,gCAAA;oBACnB,IAAI,eAAe,CAAC,QAAQ,CAAC,UAAU,CAAC,EAAE;wBACxC,OAAO,CAAC,MAAM,CAAC;4BACb,IAAI,EAAE,kBAAkB,CAAC,MAAM;4BAC/B,SAAS,mBAAA;yBACV,CAAC,CAAC;wBACH,OAAO;qBACR;iBACF;;;;;;;;;QACH,CAAC;QAED,SAAS,aAAa,CAAC,MAAiB;YAC9B,IAAA,gBAAgB,GAAK,MAAM,iBAAX,CAAY;YAEpC,IAAI,CAAC,gBAAgB,EAAE;gBACrB,OAAO,IAAI,CAAC;aACb;YAED,IAAI,gBAAgB,CAAC,IAAI,KAAK,EAAE,CAAC,UAAU,CAAC,mBAAmB,EAAE;gBACvD,IAAA,QAAM,GAAK,MAA+C,OAApD,CAAqD;gBACnE,OAAO,QAAM,CAAC,gBAAgB;oBAC5B,CAAC,CAAC,WAAW,CAAC,yBAAyB,CACnC,QAAM,EACN,QAAM,CAAC,gBAAgB,CACxB;oBACH,CAAC,CAAC,IAAI,CAAC;aACV;YAED,OAAO,WAAW,CAAC,yBAAyB,CAAC,MAAM,EAAE,gBAAgB,CAAC,CAAC;QACzE,CAAC;QAED,SAAS,cAAc,CAAC,IAAa;;YACnC,IAAI,IAAI,CAAC,OAAO,EAAE,EAAE;gBAClB,IAAM,iBAAiB,GAAa,EAAE,CAAC;;oBACvC,KAAyB,IAAA,KAAA,SAAA,IAAI,CAAC,KAAK,CAAA,gBAAA,4BAAE;wBAAhC,IAAM,UAAU,WAAA;wBACnB,iBAAiB,CAAC,IAAI,OAAtB,iBAAiB,2BAAS,cAAc,CAAC,UAAU,CAAC,WAAE;qBACvD;;;;;;;;;gBACD,OAAO,iBAAiB,CAAC;aAC1B;YAED,IAAM,MAAM,GAAG,WAAW,CAAC,iBAAiB,CAAC,IAAI,EAAE,MAAM,CAAC,CAAC;YAE3D,IAAI,CAAC,MAAM,EAAE;gBACX,OAAO,EAAE,CAAC;aACX;YAED,IAAM,UAAU,GAAG,aAAa,CAAC,MAAM,CAAC,CAAC;YAEzC,IAAI,CAAC,UAAU,EAAE;gBACf,OAAO,EAAE,CAAC;aACX;YAED,gCAAgC;YAChC,iFAAiF;YACjF,IAAI,WAAW,CAAC,YAAY,CAAC,UAAU,CAAC,KAAK,QAAQ,EAAE;gBACrD,OAAO,EAAE,CAAC;aACX;YACD,OAAO,CAAC,WAAW,CAAC,YAAY,CAAC,UAAU,CAAC,CAAC,CAAC;QAChD,CAAC;QAED;YACE,GAAC,UAAG,8BAAsB,+JAAqJ,YAAY,MAAG,IAC5L,SAAS;eACX;IACJ,CAAC;CACF,CAAC,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/experimental-utils';\nimport { getTypeServices } from 'eslint-etc';\nimport * as path from 'path';\nimport * as ts from 'typescript';\nimport { createRule } from '../../rule-creator';\nimport {\n  asPattern,\n  createEffectExpression,\n  getNgRxEffectActions,\n  isCallExpression,\n  isIdentifier,\n  isTypeReference,\n} from '../../utils';\n\nexport const messageId = 'avoidCyclicEffects';\n\ntype MessageIds = typeof messageId;\ntype Options = readonly [];\n\n// This rule is a modified version (to support dispatch: false) from the eslint-plugin-rxjs plugin.\n// The original implementation can be found at https://github.com/cartant/eslint-plugin-rxjs/blob/main/source/rules/no-cyclic-action.ts\n// Thank you Nicholas Jamieson (@cartant).\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'problem',\n    ngrxModule: 'effects',\n    docs: {\n      description: 'Avoid `Effect` that re-emit filtered actions.',\n      recommended: 'warn',\n      requiresTypeChecking: true,\n    },\n    schema: [],\n    messages: {\n      [messageId]: '`Effect` that re-emit filtered actions are forbidden.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const { identifiers = [] } = getNgRxEffectActions(context);\n    const actionsNames = identifiers.length > 0 ? asPattern(identifiers) : null;\n\n    if (!actionsNames) {\n      return {};\n    }\n\n    const { getType, typeChecker } = getTypeServices(context);\n\n    function checkNode(pipeCallExpression: TSESTree.CallExpression) {\n      const operatorCallExpression = pipeCallExpression.arguments.find(\n        (arg) =>\n          isCallExpression(arg) &&\n          isIdentifier(arg.callee) &&\n          arg.callee.name === 'ofType'\n      );\n      if (!operatorCallExpression) {\n        return;\n      }\n      const operatorType = getType(operatorCallExpression);\n      const [signature] = typeChecker.getSignaturesOfType(\n        operatorType,\n        ts.SignatureKind.Call\n      );\n\n      if (!signature) {\n        return;\n      }\n      const operatorReturnType =\n        typeChecker.getReturnTypeOfSignature(signature);\n      if (!isTypeReference(operatorReturnType)) {\n        return;\n      }\n      const [operatorElementType] =\n        typeChecker.getTypeArguments(operatorReturnType);\n      if (!operatorElementType) {\n        return;\n      }\n\n      const pipeType = getType(pipeCallExpression);\n      if (!isTypeReference(pipeType)) {\n        return;\n      }\n      const [pipeElementType] = typeChecker.getTypeArguments(pipeType);\n      if (!pipeElementType) {\n        return;\n      }\n\n      const operatorActionTypes = getActionTypes(operatorElementType);\n      const pipeActionTypes = getActionTypes(pipeElementType);\n\n      for (const actionType of operatorActionTypes) {\n        if (pipeActionTypes.includes(actionType)) {\n          context.report({\n            node: pipeCallExpression.callee,\n            messageId,\n          });\n          return;\n        }\n      }\n    }\n\n    function getActionType(symbol: ts.Symbol): ts.Type | null {\n      const { valueDeclaration } = symbol;\n\n      if (!valueDeclaration) {\n        return null;\n      }\n\n      if (valueDeclaration.kind === ts.SyntaxKind.PropertyDeclaration) {\n        const { parent } = symbol as typeof symbol & { parent: ts.Symbol };\n        return parent.valueDeclaration\n          ? typeChecker.getTypeOfSymbolAtLocation(\n              parent,\n              parent.valueDeclaration\n            )\n          : null;\n      }\n\n      return typeChecker.getTypeOfSymbolAtLocation(symbol, valueDeclaration);\n    }\n\n    function getActionTypes(type: ts.Type): string[] {\n      if (type.isUnion()) {\n        const memberActionTypes: string[] = [];\n        for (const memberType of type.types) {\n          memberActionTypes.push(...getActionTypes(memberType));\n        }\n        return memberActionTypes;\n      }\n\n      const symbol = typeChecker.getPropertyOfType(type, 'type');\n\n      if (!symbol) {\n        return [];\n      }\n\n      const actionType = getActionType(symbol);\n\n      if (!actionType) {\n        return [];\n      }\n\n      // TODO: support \"dynamic\" types\n      // e.g. const genericFoo = createAction(`${subject} FOO`); (resolves to 'string')\n      if (typeChecker.typeToString(actionType) === 'string') {\n        return [];\n      }\n      return [typeChecker.typeToString(actionType)];\n    }\n\n    return {\n      [`${createEffectExpression}:not([arguments.1]:has(Property[key.name='dispatch'][value.value=false])) CallExpression[callee.property.name='pipe'][callee.object.property.name=${actionsNames}]`]:\n        checkNode,\n    };\n  },\n});\n"]}

package/src/rules/effects/no-dispatch-in-effects.js

@@ -0,0 +1,83 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || function (mod) {
+    if (mod && mod.__esModule) return mod;
+    var result = {};
+    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
+    __setModuleDefault(result, mod);
+    return result;
+};
+var _a;
+exports.__esModule = true;
+exports.noDispatchInEffectsSuggest = exports.noDispatchInEffects = void 0;
+var path = __importStar(require("path"));
+var rule_creator_1 = require("../../rule-creator");
+var utils_1 = require("../../utils");
+exports.noDispatchInEffects = 'noDispatchInEffects';
+exports.noDispatchInEffectsSuggest = 'noDispatchInEffectsSuggest';
+exports["default"] = (0, rule_creator_1.createRule)({
+    name: path.parse(__filename).name,
+    meta: {
+        type: 'suggestion',
+        ngrxModule: 'effects',
+        hasSuggestions: true,
+        docs: {
+            description: '`Effect` should not call `store.dispatch`.',
+            recommended: 'warn',
+            suggestion: true
+        },
+        schema: [],
+        messages: (_a = {},
+            _a[exports.noDispatchInEffects] = 'Calling `store.dispatch` in `Effect` is forbidden.',
+            _a[exports.noDispatchInEffectsSuggest] = 'Remove `store.dispatch`.',
+            _a)
+    },
+    defaultOptions: [],
+    create: function (context) {
+        var _a;
+        var _b = (0, utils_1.getNgRxStores)(context).identifiers, identifiers = _b === void 0 ? [] : _b;
+        var storeNames = identifiers.length > 0 ? (0, utils_1.asPattern)(identifiers) : null;
+        if (!storeNames) {
+            return {};
+        }
+        return _a = {},
+            _a[(0, utils_1.dispatchInEffects)(storeNames)] = function (node) {
+                var nodeToReport = getNodeToReport(node);
+                context.report({
+                    node: nodeToReport,
+                    messageId: exports.noDispatchInEffects,
+                    suggest: [
+                        {
+                            messageId: exports.noDispatchInEffectsSuggest,
+                            fix: function (fixer) { return fixer.remove(nodeToReport); }
+                        },
+                    ]
+                });
+            },
+            _a;
+    }
+});
+function getNodeToReport(node) {
+    var parent = node.parent;
+    var grandParent = parent.parent;
+    return grandParent &&
+        ((0, utils_1.isArrowFunctionExpression)(grandParent) || (0, utils_1.isReturnStatement)(grandParent))
+        ? node
+        : parent;
+}
+//# sourceMappingURL=no-dispatch-in-effects.js.map

package/src/rules/effects/no-dispatch-in-effects.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"no-dispatch-in-effects.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/effects/no-dispatch-in-effects.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;AACA,yCAA6B;AAC7B,mDAAgD;AAChD,qCAMqB;AAER,QAAA,mBAAmB,GAAG,qBAAqB,CAAC;AAC5C,QAAA,0BAA0B,GAAG,4BAA4B,CAAC;AAUvE,qBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,UAAU,EAAE,SAAS;QACrB,cAAc,EAAE,IAAI;QACpB,IAAI,EAAE;YACJ,WAAW,EAAE,4CAA4C;YACzD,WAAW,EAAE,MAAM;YACnB,UAAU,EAAE,IAAI;SACjB;QACD,MAAM,EAAE,EAAE;QACV,QAAQ;YACN,GAAC,2BAAmB,IAClB,oDAAoD;YACtD,GAAC,kCAA0B,IAAG,0BAA0B;eACzD;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,UAAC,OAAO;;QACN,IAAA,KAAqB,IAAA,qBAAa,EAAC,OAAO,CAAC,YAA3B,EAAhB,WAAW,mBAAG,EAAE,KAAA,CAA4B;QACpD,IAAM,UAAU,GAAG,WAAW,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,IAAA,iBAAS,EAAC,WAAW,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;QAE1E,IAAI,CAAC,UAAU,EAAE;YACf,OAAO,EAAE,CAAC;SACX;QAED;YACE,GAAC,IAAA,yBAAiB,EAAC,UAAU,CAAC,IAA9B,UACE,IAA0C;gBAE1C,IAAM,YAAY,GAAG,eAAe,CAAC,IAAI,CAAC,CAAC;gBAC3C,OAAO,CAAC,MAAM,CAAC;oBACb,IAAI,EAAE,YAAY;oBAClB,SAAS,EAAE,2BAAmB;oBAC9B,OAAO,EAAE;wBACP;4BACE,SAAS,EAAE,kCAA0B;4BACrC,GAAG,EAAE,UAAC,KAAK,IAAK,OAAA,KAAK,CAAC,MAAM,CAAC,YAAY,CAAC,EAA1B,CAA0B;yBAC3C;qBACF;iBACF,CAAC,CAAC;YACL,CAAC;eACD;IACJ,CAAC;CACF,CAAC,CAAC;AAEH,SAAS,eAAe,CAAC,IAA0C;IACzD,IAAA,MAAM,GAAK,IAAI,OAAT,CAAU;IAChB,IAAQ,WAAW,GAAK,MAAM,OAAX,CAAY;IACvC,OAAO,WAAW;QAChB,CAAC,IAAA,iCAAyB,EAAC,WAAW,CAAC,IAAI,IAAA,yBAAiB,EAAC,WAAW,CAAC,CAAC;QAC1E,CAAC,CAAC,IAAI;QACN,CAAC,CAAC,MAAM,CAAC;AACb,CAAC","sourcesContent":["import type { TSESTree } from '@typescript-eslint/experimental-utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  asPattern,\n  dispatchInEffects,\n  getNgRxStores,\n  isArrowFunctionExpression,\n  isReturnStatement,\n} from '../../utils';\n\nexport const noDispatchInEffects = 'noDispatchInEffects';\nexport const noDispatchInEffectsSuggest = 'noDispatchInEffectsSuggest';\n\ntype MessageIds =\n  | typeof noDispatchInEffects\n  | typeof noDispatchInEffectsSuggest;\ntype Options = readonly [];\ntype MemberExpressionWithinCallExpression = TSESTree.MemberExpression & {\n  parent: TSESTree.CallExpression;\n};\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    ngrxModule: 'effects',\n    hasSuggestions: true,\n    docs: {\n      description: '`Effect` should not call `store.dispatch`.',\n      recommended: 'warn',\n      suggestion: true,\n    },\n    schema: [],\n    messages: {\n      [noDispatchInEffects]:\n        'Calling `store.dispatch` in `Effect` is forbidden.',\n      [noDispatchInEffectsSuggest]: 'Remove `store.dispatch`.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const { identifiers = [] } = getNgRxStores(context);\n    const storeNames = identifiers.length > 0 ? asPattern(identifiers) : null;\n\n    if (!storeNames) {\n      return {};\n    }\n\n    return {\n      [dispatchInEffects(storeNames)](\n        node: MemberExpressionWithinCallExpression\n      ) {\n        const nodeToReport = getNodeToReport(node);\n        context.report({\n          node: nodeToReport,\n          messageId: noDispatchInEffects,\n          suggest: [\n            {\n              messageId: noDispatchInEffectsSuggest,\n              fix: (fixer) => fixer.remove(nodeToReport),\n            },\n          ],\n        });\n      },\n    };\n  },\n});\n\nfunction getNodeToReport(node: MemberExpressionWithinCallExpression) {\n  const { parent } = node;\n  const { parent: grandParent } = parent;\n  return grandParent &&\n    (isArrowFunctionExpression(grandParent) || isReturnStatement(grandParent))\n    ? node\n    : parent;\n}\n"]}

package/src/rules/effects/no-effect-decorator-and-creator.js

@@ -0,0 +1,107 @@
+"use strict";
+var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    var desc = Object.getOwnPropertyDescriptor(m, k);
+    if (!desc || ("get" in desc ? !m.__esModule : desc.writable || desc.configurable)) {
+      desc = { enumerable: true, get: function() { return m[k]; } };
+    }
+    Object.defineProperty(o, k2, desc);
+}) : (function(o, m, k, k2) {
+    if (k2 === undefined) k2 = k;
+    o[k2] = m[k];
+}));
+var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
+    Object.defineProperty(o, "default", { enumerable: true, value: v });
+}) : function(o, v) {
+    o["default"] = v;
+});
+var __importStar = (this && this.__importStar) || function (mod) {
+    if (mod && mod.__esModule) return mod;
+    var result = {};
+    if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
+    __setModuleDefault(result, mod);
+    return result;
+};
+var _a;
+exports.__esModule = true;
+exports.noEffectDecoratorAndCreatorSuggest = exports.noEffectDecoratorAndCreator = void 0;
+var path = __importStar(require("path"));
+var rule_creator_1 = require("../../rule-creator");
+var utils_1 = require("../../utils");
+exports.noEffectDecoratorAndCreator = 'noEffectDecoratorAndCreator';
+exports.noEffectDecoratorAndCreatorSuggest = 'noEffectDecoratorAndCreatorSuggest';
+exports["default"] = (0, rule_creator_1.createRule)({
+    name: path.parse(__filename).name,
+    meta: {
+        type: 'suggestion',
+        hasSuggestions: true,
+        ngrxModule: 'effects',
+        docs: {
+            description: '`Effect` should use either the `createEffect` or the `@Effect` decorator, but not both.',
+            recommended: 'error',
+            suggestion: true
+        },
+        fixable: 'code',
+        schema: [],
+        messages: (_a = {},
+            _a[exports.noEffectDecoratorAndCreator] = 'Using the `createEffect` and the `@Effect` decorator simultaneously is forbidden.',
+            _a[exports.noEffectDecoratorAndCreatorSuggest] = 'Remove the `@Effect` decorator.',
+            _a)
+    },
+    defaultOptions: [],
+    create: function (context) {
+        var _a;
+        var sourceCode = context.getSourceCode();
+        return _a = {},
+            _a["".concat(utils_1.effectCreator, ":has(").concat(utils_1.effectDecorator, ")")] = function (node) {
+                var decorator = (0, utils_1.getDecorator)(node, 'Effect');
+                if (!decorator) {
+                    return;
+                }
+                var hasDecoratorArgument = Boolean((0, utils_1.getDecoratorArguments)(decorator)[0]);
+                var fix = function (fixer) {
+                    return getFixes(node, sourceCode, fixer, decorator);
+                };
+                if (hasDecoratorArgument) {
+                    context.report({
+                        node: node.key,
+                        messageId: exports.noEffectDecoratorAndCreator,
+                        // In this case where the argument to the `@Effect({...})`
+                        // decorator exists, it is more appropriate to **suggest**
+                        // instead of **fix**, since either simply removing or merging
+                        // the arguments would likely generate unexpected behaviors and
+                        // would be quite costly.
+                        suggest: [
+                            {
+                                messageId: exports.noEffectDecoratorAndCreatorSuggest,
+                                fix: fix
+                            },
+                        ]
+                    });
+                }
+                else {
+                    context.report({
+                        node: node.key,
+                        messageId: exports.noEffectDecoratorAndCreator,
+                        fix: fix
+                    });
+                }
+            },
+            _a;
+    }
+});
+function getFixes(node, sourceCode, fixer, decorator) {
+    var _a;
+    var importDeclarations = (_a = (0, utils_1.getImportDeclarations)(node, utils_1.NGRX_MODULE_PATHS.effects)) !== null && _a !== void 0 ? _a : [];
+    var text = sourceCode.getText();
+    var totalEffectDecoratorOccurrences = getEffectDecoratorOccurrences(text);
+    var importRemoveFix = totalEffectDecoratorOccurrences === 1
+        ? (0, utils_1.getImportRemoveFix)(sourceCode, importDeclarations, 'Effect', fixer)
+        : [];
+    return [fixer.remove(decorator)].concat(importRemoveFix);
+}
+function getEffectDecoratorOccurrences(text) {
+    var _a, _b;
+    return (_b = (_a = text.replace(/\s/g, '').match(/@Effect/g)) === null || _a === void 0 ? void 0 : _a.length) !== null && _b !== void 0 ? _b : 0;
+}
+//# sourceMappingURL=no-effect-decorator-and-creator.js.map

package/src/rules/effects/no-effect-decorator-and-creator.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"no-effect-decorator-and-creator.js","sourceRoot":"","sources":["../../../../../../modules/eslint-plugin/src/rules/effects/no-effect-decorator-and-creator.ts"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;AACA,yCAA6B;AAC7B,mDAAgD;AAChD,qCAQqB;AAER,QAAA,2BAA2B,GAAG,6BAA6B,CAAC;AAC5D,QAAA,kCAAkC,GAC7C,oCAAoC,CAAC;AAOvC,qBAAe,IAAA,yBAAU,EAAsB;IAC7C,IAAI,EAAE,IAAI,CAAC,KAAK,CAAC,UAAU,CAAC,CAAC,IAAI;IACjC,IAAI,EAAE;QACJ,IAAI,EAAE,YAAY;QAClB,cAAc,EAAE,IAAI;QACpB,UAAU,EAAE,SAAS;QACrB,IAAI,EAAE;YACJ,WAAW,EACT,yFAAyF;YAC3F,WAAW,EAAE,OAAO;YACpB,UAAU,EAAE,IAAI;SACjB;QACD,OAAO,EAAE,MAAM;QACf,MAAM,EAAE,EAAE;QACV,QAAQ;YACN,GAAC,mCAA2B,IAC1B,mFAAmF;YACrF,GAAC,0CAAkC,IAAG,iCAAiC;eACxE;KACF;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,EAAE,UAAC,OAAO;;QACd,IAAM,UAAU,GAAG,OAAO,CAAC,aAAa,EAAE,CAAC;QAE3C;YACE,GAAC,UAAG,qBAAa,kBAAQ,uBAAe,MAAG,IAA3C,UACE,IAAiC;gBAEjC,IAAM,SAAS,GAAG,IAAA,oBAAY,EAAC,IAAI,EAAE,QAAQ,CAAC,CAAC;gBAE/C,IAAI,CAAC,SAAS,EAAE;oBACd,OAAO;iBACR;gBAED,IAAM,oBAAoB,GAAG,OAAO,CAClC,IAAA,6BAAqB,EAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CACpC,CAAC;gBACF,IAAM,GAAG,GAA+B,UAAC,KAAK;oBAC5C,OAAA,QAAQ,CAAC,IAAI,EAAE,UAAU,EAAE,KAAK,EAAE,SAAS,CAAC;gBAA5C,CAA4C,CAAC;gBAE/C,IAAI,oBAAoB,EAAE;oBACxB,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,IAAI,CAAC,GAAG;wBACd,SAAS,EAAE,mCAA2B;wBACtC,0DAA0D;wBAC1D,0DAA0D;wBAC1D,8DAA8D;wBAC9D,+DAA+D;wBAC/D,yBAAyB;wBACzB,OAAO,EAAE;4BACP;gCACE,SAAS,EAAE,0CAAkC;gCAC7C,GAAG,KAAA;6BACJ;yBACF;qBACF,CAAC,CAAC;iBACJ;qBAAM;oBACL,OAAO,CAAC,MAAM,CAAC;wBACb,IAAI,EAAE,IAAI,CAAC,GAAG;wBACd,SAAS,EAAE,mCAA2B;wBACtC,GAAG,KAAA;qBACJ,CAAC,CAAC;iBACJ;YACH,CAAC;eACD;IACJ,CAAC;CACF,CAAC,CAAC;AAEH,SAAS,QAAQ,CACf,IAAiC,EACjC,UAAyC,EACzC,KAAyB,EACzB,SAA6B;;IAE7B,IAAM,kBAAkB,GACtB,MAAA,IAAA,6BAAqB,EAAC,IAAI,EAAE,yBAAiB,CAAC,OAAO,CAAC,mCAAI,EAAE,CAAC;IAC/D,IAAM,IAAI,GAAG,UAAU,CAAC,OAAO,EAAE,CAAC;IAClC,IAAM,+BAA+B,GAAG,6BAA6B,CAAC,IAAI,CAAC,CAAC;IAC5E,IAAM,eAAe,GACnB,+BAA+B,KAAK,CAAC;QACnC,CAAC,CAAC,IAAA,0BAAkB,EAAC,UAAU,EAAE,kBAAkB,EAAE,QAAQ,EAAE,KAAK,CAAC;QACrE,CAAC,CAAC,EAAE,CAAC;IAET,OAAO,CAAC,KAAK,CAAC,MAAM,CAAC,SAAS,CAAC,CAAC,CAAC,MAAM,CAAC,eAAe,CAAC,CAAC;AAC3D,CAAC;AAED,SAAS,6BAA6B,CAAC,IAAY;;IACjD,OAAO,MAAA,MAAA,IAAI,CAAC,OAAO,CAAC,KAAK,EAAE,EAAE,CAAC,CAAC,KAAK,CAAC,UAAU,CAAC,0CAAE,MAAM,mCAAI,CAAC,CAAC;AAChE,CAAC","sourcesContent":["import type { TSESLint, TSESTree } from '@typescript-eslint/experimental-utils';\nimport * as path from 'path';\nimport { createRule } from '../../rule-creator';\nimport {\n  effectCreator,\n  effectDecorator,\n  getDecorator,\n  getDecoratorArguments,\n  getImportDeclarations,\n  getImportRemoveFix,\n  NGRX_MODULE_PATHS,\n} from '../../utils';\n\nexport const noEffectDecoratorAndCreator = 'noEffectDecoratorAndCreator';\nexport const noEffectDecoratorAndCreatorSuggest =\n  'noEffectDecoratorAndCreatorSuggest';\n\ntype MessageIds =\n  | typeof noEffectDecoratorAndCreator\n  | typeof noEffectDecoratorAndCreatorSuggest;\ntype Options = readonly [];\n\nexport default createRule<Options, MessageIds>({\n  name: path.parse(__filename).name,\n  meta: {\n    type: 'suggestion',\n    hasSuggestions: true,\n    ngrxModule: 'effects',\n    docs: {\n      description:\n        '`Effect` should use either the `createEffect` or the `@Effect` decorator, but not both.',\n      recommended: 'error',\n      suggestion: true,\n    },\n    fixable: 'code',\n    schema: [],\n    messages: {\n      [noEffectDecoratorAndCreator]:\n        'Using the `createEffect` and the `@Effect` decorator simultaneously is forbidden.',\n      [noEffectDecoratorAndCreatorSuggest]: 'Remove the `@Effect` decorator.',\n    },\n  },\n  defaultOptions: [],\n  create: (context) => {\n    const sourceCode = context.getSourceCode();\n\n    return {\n      [`${effectCreator}:has(${effectDecorator})`](\n        node: TSESTree.PropertyDefinition\n      ) {\n        const decorator = getDecorator(node, 'Effect');\n\n        if (!decorator) {\n          return;\n        }\n\n        const hasDecoratorArgument = Boolean(\n          getDecoratorArguments(decorator)[0]\n        );\n        const fix: TSESLint.ReportFixFunction = (fixer) =>\n          getFixes(node, sourceCode, fixer, decorator);\n\n        if (hasDecoratorArgument) {\n          context.report({\n            node: node.key,\n            messageId: noEffectDecoratorAndCreator,\n            // In this case where the argument to the `@Effect({...})`\n            // decorator exists, it is more appropriate to **suggest**\n            // instead of **fix**, since either simply removing or merging\n            // the arguments would likely generate unexpected behaviors and\n            // would be quite costly.\n            suggest: [\n              {\n                messageId: noEffectDecoratorAndCreatorSuggest,\n                fix,\n              },\n            ],\n          });\n        } else {\n          context.report({\n            node: node.key,\n            messageId: noEffectDecoratorAndCreator,\n            fix,\n          });\n        }\n      },\n    };\n  },\n});\n\nfunction getFixes(\n  node: TSESTree.PropertyDefinition,\n  sourceCode: Readonly<TSESLint.SourceCode>,\n  fixer: TSESLint.RuleFixer,\n  decorator: TSESTree.Decorator\n): readonly TSESLint.RuleFix[] {\n  const importDeclarations =\n    getImportDeclarations(node, NGRX_MODULE_PATHS.effects) ?? [];\n  const text = sourceCode.getText();\n  const totalEffectDecoratorOccurrences = getEffectDecoratorOccurrences(text);\n  const importRemoveFix =\n    totalEffectDecoratorOccurrences === 1\n      ? getImportRemoveFix(sourceCode, importDeclarations, 'Effect', fixer)\n      : [];\n\n  return [fixer.remove(decorator)].concat(importRemoveFix);\n}\n\nfunction getEffectDecoratorOccurrences(text: string) {\n  return text.replace(/\\s/g, '').match(/@Effect/g)?.length ?? 0;\n}\n"]}