@ngrx-traits/common 14.1.1-beta.1 → 15.0.0-beta.1

package/fesm2020/ngrx-traits-common.mjs

@@ -1577,16 +1577,11 @@ function addAsyncActionTrait({ name, actionProps, actionSuccessProps, actionFail
                     ? createAction(`${actionsGroupKey} ${nameAsSentence} Failure`, actionFailProps)
                     : createAction(`${actionsGroupKey} ${nameAsSentence} Failure`)),
             };
-            //TypeScript error after migration to 4.9.5
-            //Removed because 'name' is not optional
-            //if (name) {
             return {
                 [`${name}`]: internalActions.request,
                 [`${name}Success`]: internalActions.requestSuccess,
                 [`${name}Fail`]: internalActions.requestFail,
             };
-            //}
-            //return internalActions;
         },
         selectors: () => {
             function isLoadingEntity(state) {
@@ -1611,19 +1606,17 @@ function addAsyncActionTrait({ name, actionProps, actionSuccessProps, actionFail
             // Added 'any' to 'state' and removed 'as AsyncActionState<J>'
             // because OnReducer have a weird type for the state.
             // TODO: Investigate if possible to remove the 'any' type and have better type safety
+            // tried remove the any seems to be a problex with ngrx on making the state unknown
             return createReducer(initialState, on(internalActions.request, (state) => ({
                 ...state,
                 [`${name}Status`]: 'loading',
-            }) // as AsyncActionState<J>)
-            ), on(internalActions.requestFail, (state) => ({
+            })), on(internalActions.requestFail, (state) => ({
                 ...state,
                 [`${name}Status`]: 'fail',
-            }) // as AsyncActionState<J>)
-            ), on(internalActions.requestSuccess, (state) => ({
+            })), on(internalActions.requestSuccess, (state) => ({
                 ...state,
                 [`${name}Status`]: 'success',
-            }) //as AsyncActionState<J>)
-            ));
+            })));
         },
     });
 }