@ngocsangairvds/vsaf 4.1.8 → 4.1.10

package/skills/vds-skill/vds-scripts/vds_cli_common/tests/test_migrate_sdlc_config.py

@@ -1,257 +0,0 @@
-"""Unit tests for sdlc-config.env → .env migration."""
-
-from __future__ import annotations
-
-import os
-import stat
-from pathlib import Path
-
-import pytest
-
-
-# ── Fixtures ──
-
-
-@pytest.fixture
-def vds_dir(tmp_path: Path) -> Path:
-    """Create a temporary ~/.vds/ directory."""
-    d = tmp_path / ".vds"
-    d.mkdir()
-    return d
-
-
-@pytest.fixture
-def legacy_file(vds_dir: Path) -> Path:
-    """Create a populated sdlc-config.env."""
-    f = vds_dir / "sdlc-config.env"
-    f.write_text(
-        "# VDS Skill Pack — credential config\n"
-        "VDS_CONFLUENCE_TOKEN=my-confluence-pat\n"
-        "VDS_JIRA_TOKEN=my-jira-pat\n"
-        "VDS_BITBUCKET_TOKEN=my-bitbucket-pat\n"
-        "VDS_USERNAME=myuser\n"
-        "VDS_PASSWORD=mypass\n"
-        "VDS_CONFLUENCE_SPACE_DEFAULT=CEP\n"
-        "VDS_JIRA_PROJECT_DEFAULT=NTTC\n",
-        encoding="utf-8",
-    )
-    return f
-
-
-@pytest.fixture
-def target_file(vds_dir: Path) -> Path:
-    """Return path to target .env (does not create it)."""
-    return vds_dir / ".env"
-
-
-# ── Tests ──
-
-
-class TestParseEnvFile:
-    def test_basic_parse(self, vds_dir: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import parse_legacy_env
-
-        f = vds_dir / "test.env"
-        f.write_text("KEY1=value1\nKEY2=value2\n")
-        result = parse_legacy_env(f)
-        assert result == {"KEY1": "value1", "KEY2": "value2"}
-
-    def test_skips_comments_and_blanks(self, vds_dir: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import parse_legacy_env
-
-        f = vds_dir / "test.env"
-        f.write_text("# comment\n\nKEY=val\n  # indented comment\n")
-        result = parse_legacy_env(f)
-        assert result == {"KEY": "val"}
-
-    def test_handles_quoted_values(self, vds_dir: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import parse_legacy_env
-
-        f = vds_dir / "test.env"
-        f.write_text('SINGLE=\'hello world\'\nDOUBLE="foo bar"\n')
-        result = parse_legacy_env(f)
-        assert result == {"SINGLE": "hello world", "DOUBLE": "foo bar"}
-
-    def test_handles_equals_in_value(self, vds_dir: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import parse_legacy_env
-
-        f = vds_dir / "test.env"
-        f.write_text("TOKEN=abc123==\n")  # base64 padding
-        result = parse_legacy_env(f)
-        assert result == {"TOKEN": "abc123=="}
-
-    def test_handles_export_prefix(self, vds_dir: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import parse_legacy_env
-
-        f = vds_dir / "test.env"
-        f.write_text("export KEY=val\n")
-        result = parse_legacy_env(f)
-        assert result == {"KEY": "val"}
-
-    def test_handles_crlf(self, vds_dir: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import parse_legacy_env
-
-        f = vds_dir / "test.env"
-        f.write_bytes(b"KEY1=a\r\nKEY2=b\r\n")
-        result = parse_legacy_env(f)
-        assert result == {"KEY1": "a", "KEY2": "b"}
-
-    def test_handles_bom(self, vds_dir: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import parse_legacy_env
-
-        f = vds_dir / "test.env"
-        f.write_bytes(b"\xef\xbb\xbfKEY=val\n")
-        result = parse_legacy_env(f)
-        assert result == {"KEY": "val"}
-
-    def test_nonexistent_file_returns_empty(self, vds_dir: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import parse_legacy_env
-
-        result = parse_legacy_env(vds_dir / "nope.env")
-        assert result == {}
-
-    def test_skips_empty_values(self, vds_dir: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import parse_legacy_env
-
-        f = vds_dir / "test.env"
-        f.write_text("FILLED=ok\nEMPTY=\nALSO_EMPTY=  \n")
-        result = parse_legacy_env(f)
-        assert result == {"FILLED": "ok"}
-
-
-class TestMigration:
-    def test_basic_migration(self, legacy_file: Path, target_file: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import migrate_sdlc_config
-
-        result = migrate_sdlc_config(legacy_file, target_file)
-        assert result.migrated == [
-            "INTERNAL_CONFLUENCE_TOKEN",
-            "JIRA_TOKEN",
-            "BITBUCKET_TOKEN",
-            "VDS_USERNAME",
-            "VDS_PASSWORD",
-            "VDS_CONFLUENCE_SPACE_DEFAULT",
-            "VDS_JIRA_PROJECT_DEFAULT",
-        ]
-        assert result.skipped == []
-        assert result.warnings == []
-
-        # Verify file content
-        content = target_file.read_text(encoding="utf-8")
-        assert "INTERNAL_CONFLUENCE_TOKEN=my-confluence-pat" in content
-        assert "JIRA_TOKEN=my-jira-pat" in content
-        assert "BITBUCKET_TOKEN=my-bitbucket-pat" in content
-        assert "VDS_USERNAME=myuser" in content
-
-    def test_skips_placeholders(self, vds_dir: Path, target_file: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import migrate_sdlc_config
-
-        legacy = vds_dir / "sdlc-config.env"
-        legacy.write_text(
-            "VDS_CONFLUENCE_TOKEN=changeme\n"
-            "VDS_JIRA_TOKEN=<your-token>\n"
-            "VDS_BITBUCKET_TOKEN=xxx\n"
-            "VDS_USERNAME=realuser\n",
-        )
-        result = migrate_sdlc_config(legacy, target_file)
-        assert "VDS_USERNAME" in result.migrated
-        assert len(result.skipped) == 3
-        content = target_file.read_text(encoding="utf-8")
-        assert "VDS_USERNAME=realuser" in content
-        assert "INTERNAL_CONFLUENCE_TOKEN" not in content
-
-    def test_no_overwrite_existing_real_values(self, legacy_file: Path, target_file: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import migrate_sdlc_config
-
-        # Pre-populate target with a real value
-        target_file.write_text(
-            "INTERNAL_CONFLUENCE_TOKEN=already-set-by-user\n"
-            "JIRA_TOKEN=\n",  # empty — should be overwritten
-        )
-        result = migrate_sdlc_config(legacy_file, target_file)
-        content = target_file.read_text(encoding="utf-8")
-        # Real value preserved
-        assert "INTERNAL_CONFLUENCE_TOKEN=already-set-by-user" in content
-        # Empty value overwritten
-        assert "JIRA_TOKEN=my-jira-pat" in content
-
-    def test_overwrites_commented_var(self, legacy_file: Path, target_file: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import migrate_sdlc_config
-
-        target_file.write_text("# JIRA_TOKEN=old-commented-out\n")
-        result = migrate_sdlc_config(legacy_file, target_file)
-        content = target_file.read_text(encoding="utf-8")
-        assert "JIRA_TOKEN=my-jira-pat" in content
-
-    def test_idempotent(self, legacy_file: Path, target_file: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import migrate_sdlc_config
-
-        result1 = migrate_sdlc_config(legacy_file, target_file)
-        content_after_first = target_file.read_text(encoding="utf-8")
-        assert len(result1.migrated) == 7
-
-        result2 = migrate_sdlc_config(legacy_file, target_file)
-        content_after_second = target_file.read_text(encoding="utf-8")
-        assert result2.migrated == []
-        assert content_after_first == content_after_second
-
-    def test_warns_on_unknown_keys(self, vds_dir: Path, target_file: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import migrate_sdlc_config
-
-        legacy = vds_dir / "sdlc-config.env"
-        legacy.write_text("UNKNOWN_VAR=hello\nVDS_USERNAME=user\n")
-        result = migrate_sdlc_config(legacy, target_file)
-        assert "UNKNOWN_VAR" in result.warnings[0]
-        assert "VDS_USERNAME" in result.migrated
-
-    def test_creates_backup(self, legacy_file: Path, target_file: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import migrate_sdlc_config
-
-        target_file.write_text("EXISTING=value\n")
-        migrate_sdlc_config(legacy_file, target_file)
-        backups = list(target_file.parent.glob(".env.bak.*"))
-        assert len(backups) == 1
-        assert "EXISTING=value" in backups[0].read_text()
-
-    def test_no_backup_when_target_missing(self, legacy_file: Path, target_file: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import migrate_sdlc_config
-
-        assert not target_file.exists()
-        migrate_sdlc_config(legacy_file, target_file)
-        backups = list(target_file.parent.glob(".env.bak.*"))
-        assert len(backups) == 0
-
-    def test_file_permissions_0600(self, legacy_file: Path, target_file: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import migrate_sdlc_config
-
-        if os.name == "nt":
-            pytest.skip("Unix permissions not applicable on Windows")
-        migrate_sdlc_config(legacy_file, target_file)
-        mode = stat.S_IMODE(target_file.stat().st_mode)
-        assert mode == 0o600
-
-    def test_nonexistent_legacy_returns_skip(self, vds_dir: Path, target_file: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import migrate_sdlc_config
-
-        result = migrate_sdlc_config(vds_dir / "nope.env", target_file)
-        assert result.migrated == []
-        assert result.skipped == []
-        assert result.warnings == []
-        assert result.legacy_not_found is True
-
-    def test_preserves_existing_lines_and_comments(self, legacy_file: Path, target_file: Path) -> None:
-        from vds_cli_common.migrate_sdlc_config import migrate_sdlc_config
-
-        target_file.write_text(
-            "# My hand-written header\n"
-            "CUSTOM_VAR=keep-me\n"
-            "\n"
-            "# Another section\n"
-            "ANOTHER=also-keep\n",
-        )
-        migrate_sdlc_config(legacy_file, target_file)
-        content = target_file.read_text(encoding="utf-8")
-        assert "# My hand-written header" in content
-        assert "CUSTOM_VAR=keep-me" in content
-        assert "ANOTHER=also-keep" in content
-        assert "INTERNAL_CONFLUENCE_TOKEN=my-confluence-pat" in content

package/skills/vds-skill/vds-scripts-skill/.openskills.json

@@ -1,6 +0,0 @@
-{
-  "source": "./.agent/skills/vds-scripts-skill",
-  "sourceType": "local",
-  "localPath": "/Users/vds-ai/Library/Mobile Documents/com~apple~CloudDocs/project/vds/.agent/skills/vds-scripts-skill",
-  "installedAt": "2026-01-26T07:07:42.597Z"
-}

package/skills/vds-skill/vds-scripts-skill/QUALITY.md

@@ -1,44 +0,0 @@
-# Quality Baseline — vds-scripts-skill
-
-## Version History
-
-| Version | Date | Score | Evaluator | Notes |
-|---------|------|-------|-----------|-------|
-| 1.0.0 | 2026-03-19 | 3.6/5 | Manual | Initial baseline - needs split |
-| 1.1.0 | 2026-03-23 | pending | Manual | Repositioned as platform-routing skill; pending post-refactor review |
-
-## Evaluation Criteria
-
-| Criterion | Weight | Type | Description |
-|-----------|--------|------|-------------|
-| Accuracy | 40% | Scored 1-5 | Commands and routing guidance are correct |
-| Completeness | 25% | Scored 1-5 | Current WHO capabilities are represented through skill text, references, or routing aids |
-| Actionability | 20% | Scored 1-5 | Users can quickly choose the correct command family or specialist skill |
-| Token Efficiency | 10% | Scored 1-5 | Main skill stays concise and relies on progressive disclosure |
-| Schema Validity | 5% | Binary | Skill follows AgentSkills/OpenSkills structure and metadata |
-
-## Current Role
-
-`vds-scripts-skill` is the platform-routing skill for the WHO scripts ecosystem.
-It is not the deep specialist runbook for audit workflows or other specialist domains.
-
-## Known Issues
-
-- Post-refactor scoring still needs a fresh baseline run.
-- Capability coverage should be validated against the current WHO workspace inventory.
-- Generated/root agent surfaces must be synced after the final skill/doc changes land.
-
-## Validation Checklist
-
-- [ ] `SKILL.md` remains concise and activation-oriented
-- [ ] references/ covers the broader capability map
-- [ ] routing matrix maps common intents to the right skill/command family
-- [ ] registry metadata matches the updated role
-- [ ] scripts docs and skills docs tell the same ownership story
-
-## Quality Hypotheses
-
-| Date | Hypothesis | Expected | Actual | Score Change |
-|------|------------|----------|--------|--------------|
-| 2026-03-23 | Shift from command dump to platform-routing + references | Token Efficiency up, Completeness up, clearer routing | pending | pending |
-| 2026-03-23 | Add capability index and routing matrix | Completeness 3.5→4.2 | pending | pending |