@ngocsangairvds/vsaf 4.1.29 → 4.1.31

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ngocsangairvds/vsaf",
-  "version": "4.1.29",
+  "version": "4.1.31",
   "description": "logging step",
   "main": "packages/core/dist/index.js",
   "types": "packages/core/dist/index.d.ts",

package/skills/sdlc/hotfix-implement/SKILL.md

@@ -160,6 +160,34 @@ If unexpected impact detected → evaluate:
 [HOTFIX-IMPL] [6/6] Impact verification... ✅
 ```
 
+## Verification Gate
+
+⛔ **NO COMPLETION CLAIMS WITHOUT FRESH VERIFICATION EVIDENCE.**
+
+Before printing Phase Exit, you MUST pass ALL checks below. For each check: **run the command → read the full output → verify the claim matches the output.** Do NOT trust memory, do NOT trust previous runs, do NOT say "should pass."
+
+| # | Check | Command to Run | Evidence Required | ❌ NOT Acceptable |
+|---|-------|---------------|-------------------|-------------------|
+| 1 | Build compiles | `mvn compile` / `npm run build` / equivalent | `BUILD SUCCESS` or `0 errors` in output | "It compiled earlier" |
+| 2 | All tests pass | `npm test` / `mvn test` / equivalent | `X passed, 0 failed` in output | "Tests should still pass" |
+| 3 | Regression test passes | Run specific test by name | Test name + PASS in output | "I wrote the test so it passes" |
+| 4 | No new SonarQube issues | Check output from Step 4 | 0 blockers, 0 critical, 0 vulns | "Code looks clean" |
+| 5 | GitNexus impact clean | Check output from Step 6 | Blast radius matches analysis | "Fix is minimal so it's fine" |
+| 6 | Scope boundary held | `git diff --stat` | Changed files ⊆ files listed in analysis | "I only changed what was needed" |
+
+**Red flags — if you catch yourself thinking any of these, STOP and run the command:**
+- "It should work" → Run it and prove it
+- "I'm confident" → Confidence ≠ evidence
+- "I already checked" → Check again with fresh output
+- "It's a small change so it's safe" → Small changes break big systems
+- "The test passed during TDD" → TDD was minutes ago; verify NOW
+
+**Procedure:**
+1. Run checks 1-6 sequentially
+2. For each: paste the **actual command output** (or key lines) into `03-impl-log.md` under a `## Verification Evidence` section
+3. If ANY check fails → fix → re-run ALL checks (not just the failed one)
+4. Only after ALL 6 checks show fresh passing evidence → proceed to Phase Exit
+
 ## Output
 
 Write file: `.vsaf/docs/hotfixes/{bug-id}/03-impl-log.md`
@@ -198,6 +226,17 @@ Write file: `.vsaf/docs/hotfixes/{bug-id}/03-impl-log.md`
 ## Build
 - Compile: PASS
 - Full test suite: PASS
+
+## Verification Evidence
+
+| # | Check | Result | Evidence |
+|---|-------|--------|----------|
+| 1 | Build compiles | ✅ PASS | `{actual build output line}` |
+| 2 | All tests pass | ✅ PASS | `{X} passed, 0 failed` |
+| 3 | Regression test | ✅ PASS | `{test name} — PASSED` |
+| 4 | SonarQube clean | ✅ PASS | 0 blocker, 0 critical, 0 vuln |
+| 5 | Impact clean | ✅ PASS | Blast radius = {files}, matches analysis |
+| 6 | Scope held | ✅ PASS | `git diff --stat`: {n} files changed, all within scope |
 ```
 
 ## Phase Exit Protocol

package/skills/vds-skill/runtime/diagram_generator/generate_all_diagrams.py

@@ -1,3 +1,5 @@
+from __future__ import annotations
+
 #!/usr/bin/env python3
 """Generate PlantUML diagrams for all VDS project services.
 

package/skills/vds-skill/runtime/mcp_server/src/vds_mcp_server/tools/bitbucket_tools.py

@@ -4,6 +4,8 @@ Based on MCP Python SDK v1.0.0+
 Context7: /modelcontextprotocol/python-sdk
 """
 
+from __future__ import annotations
+
 from collections.abc import Callable
 from typing import TYPE_CHECKING, Any
 

package/skills/vds-skill/runtime/mcp_server/src/vds_mcp_server/tools/confluence_tools.py

@@ -4,6 +4,8 @@ Based on MCP Python SDK v1.0.0+
 Context7: /modelcontextprotocol/python-sdk
 """
 
+from __future__ import annotations
+
 from collections.abc import Callable
 from typing import TYPE_CHECKING, Any
 

package/skills/vds-skill/runtime/mcp_server/src/vds_mcp_server/tools/git_tools.py

@@ -4,6 +4,8 @@ Based on MCP Python SDK v1.0.0+
 Context7: /modelcontextprotocol/python-sdk
 """
 
+from __future__ import annotations
+
 from collections.abc import Callable
 from typing import TYPE_CHECKING, Any
 

package/skills/vds-skill/runtime/mcp_server/src/vds_mcp_server/tools/jira_tools.py

@@ -4,6 +4,8 @@ Based on MCP Python SDK v1.0.0+
 Context7: /modelcontextprotocol/python-sdk
 """
 
+from __future__ import annotations
+
 from collections.abc import Callable
 from typing import TYPE_CHECKING, Any
 

package/skills/vds-skill/runtime/mcp_server/tests/conftest.py

@@ -1,5 +1,7 @@
 """Pytest configuration and fixtures for MCP server tests."""
 
+from __future__ import annotations
+
 from collections.abc import AsyncGenerator
 from typing import TYPE_CHECKING
 from unittest.mock import Mock

package/skills/vds-skill/runtime/mcp_server/tests/unit/test_bitbucket_tools.py

@@ -4,6 +4,8 @@ Based on pytest v8.3.3+ API
 Context7: /pytest-dev/pytest
 """
 
+from __future__ import annotations
+
 from typing import TYPE_CHECKING
 
 import pytest

package/skills/vds-skill/runtime/mcp_server/tests/unit/test_confluence_tools.py

@@ -4,6 +4,8 @@ Based on pytest v8.3.3+ API
 Context7: /pytest-dev/pytest
 """
 
+from __future__ import annotations
+
 from typing import TYPE_CHECKING
 
 import pytest

package/skills/vds-skill/runtime/mcp_server/tests/unit/test_git_tools.py

@@ -4,6 +4,8 @@ Based on pytest v8.3.3+ API
 Context7: /pytest-dev/pytest
 """
 
+from __future__ import annotations
+
 from typing import TYPE_CHECKING
 
 import pytest

package/skills/vds-skill/runtime/mcp_server/tests/unit/test_jira_tools.py

@@ -4,6 +4,8 @@ Based on pytest v8.3.3+ API
 Context7: /pytest-dev/pytest
 """
 
+from __future__ import annotations
+
 from typing import TYPE_CHECKING
 
 import pytest

package/skills/vds-skill/runtime/mcp_server/tests/verification/test_mcp_confluence_tools.py

@@ -5,6 +5,8 @@ Context7: /pytest-dev/pytest
 Key Features: @pytest.mark.skipif, real API calls via MCP
 """
 
+from __future__ import annotations
+
 import os
 from typing import TYPE_CHECKING
 

package/skills/vds-skill/runtime/mcp_server/tests/verification/test_mcp_jira_tools.py

@@ -5,6 +5,8 @@ Context7: /pytest-dev/pytest
 Key Features: @pytest.mark.skipif, real API calls via MCP
 """
 
+from __future__ import annotations
+
 import os
 from typing import TYPE_CHECKING
 

package/skills/vds-skill/runtime/mcp_server/tests/verification/test_mcp_tool_registration.py

@@ -4,6 +4,8 @@ Based on pytest v8.3.3+ API
 Context7: /pytest-dev/pytest
 """
 
+from __future__ import annotations
+
 from typing import TYPE_CHECKING
 
 import pytest

package/skills/vds-skill/runtime/platform_core/src/vds_platform_core/http/auth.py

@@ -1,5 +1,7 @@
 """Auth middleware: inject CredentialResolver into HTTPClient headers."""
 
+from __future__ import annotations
+
 from typing import TYPE_CHECKING, Any
 
 if TYPE_CHECKING: