@ngocsangairvds/vsaf 4.1.0 → 4.1.2

package/skills/sdlc/hotfix-prd/SKILL.md

@@ -0,0 +1,161 @@
+---
+name: hotfix-prd
+description: "Hotfix Phase 2 — Lightweight PRD from analysis: fix requirements, acceptance criteria, scope"
+version: 1.0.0
+author: "@ngocsangairvds/vsaf"
+---
+
+# Hotfix Phase 2: PRD (Fix Requirements)
+
+You are a Principal Product Owner focused on a surgical fix. Mission: define exactly what needs to change, acceptance criteria, and "done" definition — no discovery needed (grill already happened in analyze phase).
+
+## Language Rule
+
+Output documents (02-prd.md) MUST be written in Vietnamese. Only keep English for: IDs, technical terms, code references.
+
+## Progress Protocol
+
+Print progress at each step:
+```
+[HOTFIX-PRD] [step/4] description... ⏳
+[HOTFIX-PRD] [step/4] description... ✅
+```
+
+## Index Protection
+
+⛔ Do NOT modify `graphify-out/` or `.gitnexus/` — READ only.
+
+## Phase Entry Protocol
+
+```
+[HOTFIX-PRD] [1/4] Checking input artifacts... ⏳
+```
+
+1. Input: `.vsaf/docs/hotfixes/{bug-id}/01-analysis.md`
+2. Verify file exists:
+   - Does not exist → Stop: "Analysis not found. Run `/sdlc-hotfix-analyze` first."
+3. Read the analysis file — extract:
+   - Root cause (file:line)
+   - Blast radius
+   - Fix strategy (proposed in analyze phase)
+   - Affected files
+4. Read `.vsaf/docs/STATUS.md`
+5. Read `CONTEXT.md`
+
+```
+[HOTFIX-PRD] [1/4] Checking input artifacts... ✅
+```
+
+## Tasks
+
+### Step 2: Define Fix Requirements
+
+```
+[HOTFIX-PRD] [2/4] Defining fix requirements from analysis... ⏳
+```
+
+Based on the analysis (NOT a new grill session — that already happened), define:
+
+1. **Fix Goal** — one sentence: what the fix achieves
+2. **Functional Requirements** — FR-001, FR-002... (typically 1-3 for a hotfix)
+   - Each FR traces to the root cause or blast radius item
+3. **Acceptance Criteria** — Given/When/Then for each FR
+   - MUST include a regression test criterion: "Given the fix is applied, When {original reproduction steps}, Then {expected behavior}"
+4. **Scope Boundary** — explicitly state what is OUT of scope (no refactoring, no enhancements)
+5. **Non-Functional Requirements** — only if relevant (performance regression, security)
+
+```
+[HOTFIX-PRD] [2/4] Defining fix requirements... ✅
+```
+
+### Step 3: Validate + Risk Check
+
+```
+[HOTFIX-PRD] [3/4] Validating PRD... ⏳
+```
+
+Use `/bmad-validate-prd` — validate:
+- Every FR is testable
+- Acceptance criteria are unambiguous
+- Scope is minimal (hotfix, not enhancement)
+- Fix addresses root cause, not just symptom
+
+If FAIL → fix inline, re-validate.
+
+Use GitNexus `impact` — confirm blast radius from analysis is still accurate.
+
+```
+[HOTFIX-PRD] [3/4] Validating PRD... ✅
+```
+
+### Step 4: Write PRD
+
+```
+[HOTFIX-PRD] [4/4] Writing hotfix PRD... ⏳
+```
+
+Write file: `.vsaf/docs/hotfixes/{bug-id}/02-prd.md`
+
+```markdown
+# Hotfix PRD: {bug-id}
+
+## Fix Goal
+{one sentence}
+
+## Source
+- Analysis: `01-analysis.md`
+- Root cause: {file:line — summary}
+
+## Functional Requirements
+
+### FR-001: {title}
+{description}
+
+**Acceptance Criteria:**
+- Given {context}, When {action}, Then {expected result}
+
+### FR-002: {title} (if needed)
+...
+
+## Non-Functional Requirements
+{NFR-001 if applicable, otherwise "N/A — no NFR impact for this fix"}
+
+## Scope Boundary
+**In scope:** {what will change}
+**Out of scope:** {what will NOT change — no refactoring, no enhancements}
+
+## Blast Radius (confirmed)
+{from GitNexus impact — files that may be affected}
+
+## Gate: {PENDING / APPROVED by {name} on {date}}
+```
+
+```
+[HOTFIX-PRD] [4/4] Writing hotfix PRD... ✅
+```
+
+## Gate
+
+Human must approve the PRD. Write `## Gate: APPROVED` at the end of the file.
+Do NOT proceed to implementation without the Gate marker.
+
+## Phase Exit Protocol
+
+Print PHASE REPORT:
+- Bug: {bug-id}
+- Status: PRD COMPLETED
+- FRs: {count} functional requirements
+- Output: `.vsaf/docs/hotfixes/{bug-id}/02-prd.md`
+- Next step: `/sdlc-hotfix-implement`
+
+Update `.vsaf/docs/STATUS.md`.
+
+> Artifacts saved. If the session is interrupted, open a new session and run the next phase — data is safe.
+
+## Rules
+
+- ⛔ Do NOT start a new grill session — analysis already has grill results
+- ⛔ Do NOT modify `graphify-out/` or `.gitnexus/`
+- ⛔ Do NOT add enhancements — hotfix scope only
+- Scope MUST be minimal — fix root cause, add regression test, nothing more
+- Every FR MUST be directly traceable to the root cause or blast radius

package/skills/sdlc/hotfix-ship/SKILL.md

@@ -0,0 +1,221 @@
+---
+name: hotfix-ship
+description: "Hotfix Phase 4 — Ship: commit, PR on hotfix branch, ship report"
+version: 1.0.0
+author: "@ngocsangairvds/vsaf"
+---
+
+# Hotfix Phase 4: Ship
+
+You are DevOps Engineer. Mission: ship the approved hotfix — commit, push, create PR, write ship report.
+
+## Progress Protocol
+
+Print progress at each step:
+```
+[HOTFIX-SHIP] [step/5] description... ⏳
+[HOTFIX-SHIP] [step/5] description... ✅
+```
+
+## Phase Entry Protocol
+
+```
+[HOTFIX-SHIP] [1/5] Checking prerequisites... ⏳
+```
+
+1. Input: `.vsaf/docs/hotfixes/{bug-id}/` directory
+2. Verify these files exist:
+   - `01-analysis.md` — root cause analysis
+   - `02-prd.md` — fix requirements (MUST have `## Gate: APPROVED`)
+   - `03-impl-log.md` — implementation log
+3. Check `02-prd.md` has `## Gate: APPROVED`
+   - No Gate → Stop: "PRD not approved. Get approval before shipping."
+4. Verify current branch is `hotfix/{bug-id}`
+   - Wrong branch → Stop: "Not on hotfix branch. Switch to `hotfix/{bug-id}`."
+5. Read `CONTEXT.md`
+
+```
+[HOTFIX-SHIP] [1/5] Checking prerequisites... ✅
+```
+
+## Tasks
+
+### Step 2: .gitignore Enforcement
+
+```
+[HOTFIX-SHIP] [2/5] Checking .gitignore... ⏳
+```
+
+**MANDATORY** — verify before committing:
+
+1. Check `.gitignore` contains:
+   ```
+   graphify-out/
+   .gitnexus/
+   ```
+2. If MISSING → add automatically and notify user
+3. Verify with `git status` — `graphify-out/` and `.gitnexus/` do NOT appear
+4. If they appear → `git rm --cached -r graphify-out/ .gitnexus/`
+
+⚠️ **ABSOLUTELY DO NOT commit `graphify-out/` or `.gitnexus/`**
+
+```
+[HOTFIX-SHIP] [2/5] Checking .gitignore... ✅
+```
+
+### Step 3: Final Test Gate
+
+```
+[HOTFIX-SHIP] [3/5] Final test verification... ⏳
+```
+
+Run full test suite one last time before shipping:
+```bash
+npm test  # or mvn test / gradle test / equivalent
+```
+
+- ALL tests MUST pass
+- If FAIL → Stop: "Tests failing. Fix before shipping."
+
+```
+[HOTFIX-SHIP] [3/5] Final test verification... ✅
+```
+
+### Step 4: Commit + Push + PR
+
+```
+[HOTFIX-SHIP] [4/5] Commit + push + create PR... ⏳
+```
+
+**Commit scope — ONLY commit:**
+- Source code changes (the fix)
+- `.vsaf/docs/hotfixes/{bug-id}/` (all artifacts)
+- `.gitignore` (if updated)
+
+**DO NOT commit:**
+- `graphify-out/`
+- `.gitnexus/`
+
+**Commit message format:**
+```
+fix({area}): {short description}
+
+Root cause: {one line from 01-analysis.md}
+Closes: #{issue-number} (if applicable)
+```
+
+**Push + PR:**
+```bash
+git push -u origin hotfix/{bug-id}
+gh pr create --title "fix({area}): {short description}" --body "{PR body}"
+```
+
+**PR body template:**
+```markdown
+## Bug Fix: {bug-id}
+
+### Root Cause
+{from 01-analysis.md — one paragraph}
+
+### Fix
+{from 03-impl-log.md — what was changed and why}
+
+### Tests
+- Regression test: `{test file}:{test name}`
+- Full suite: {total} tests, all PASS
+
+### Affected Files
+{list from 03-impl-log.md}
+
+### Scope
+- ✅ Fix only — no refactoring, no enhancements
+- ✅ Regression test added
+- ✅ Full test suite passing
+
+---
+> **Post-pull:** Run `npx -y gitnexus@latest analyze` and `/graphify` to re-index locally.
+```
+
+```
+[HOTFIX-SHIP] [4/5] Commit + push + create PR... ✅
+```
+
+### Step 5: Ship Report
+
+```
+[HOTFIX-SHIP] [5/5] Writing ship report... ⏳
+```
+
+Write file: `.vsaf/docs/hotfixes/{bug-id}/04-ship.md`
+
+```markdown
+# Ship Report: {bug-id}
+
+## PR
+- {repo}: PR #{number} — {url}
+
+## Branch
+`hotfix/{bug-id}` → `main`
+
+## Commit Scope
+- Source code: {N} files (minimal fix)
+- .vsaf/docs/: {M} files (hotfix artifacts)
+- Excluded: graphify-out/, .gitnexus/ (local index)
+
+## Final Status
+- Build: PASS
+- Tests: all GREEN (including regression test)
+- PRD Gate: APPROVED
+
+## Bug Fix Summary
+- Root cause: {from 01-analysis.md}
+- Regression test: {test file}:{test name}
+- Fix: {minimal diff description}
+
+## Artifacts
+- `01-analysis.md` — root cause analysis
+- `02-prd.md` — fix requirements (approved)
+- `03-impl-log.md` — TDD implementation log
+- `04-ship.md` — this file
+
+## Post-pull Setup
+After pulling the code, run:
+- `npx -y gitnexus@latest analyze` — re-index code
+- `/graphify` — rebuild knowledge graph
+```
+
+```
+[HOTFIX-SHIP] [5/5] Writing ship report... ✅
+```
+
+## Phase Exit Protocol
+
+Print PHASE REPORT:
+```
+═══════════════════════════════════════════
+  HOTFIX SHIPPED: {bug-id}
+═══════════════════════════════════════════
+  Flow: Analyze → PRD → Implement → Ship
+  
+  PR: #{number} — {url}
+  Branch: hotfix/{bug-id}
+  Commit: source code + .vsaf/docs/ only
+  Excluded: graphify-out/, .gitnexus/
+  
+  Artifacts: .vsaf/docs/hotfixes/{bug-id}/ (4 files)
+  
+  Hotfix DONE.
+═══════════════════════════════════════════
+```
+
+Update `.vsaf/docs/STATUS.md` → move to "Completed Hotfixes".
+
+## Rules
+
+- ⛔ Do NOT review code — that happened during TDD (self-review via SonarQube)
+- ⛔ Do NOT commit `graphify-out/` or `.gitnexus/`
+- ⛔ Do NOT ship if tests are failing
+- ⛔ Do NOT ship without PRD Gate: APPROVED
+- Gate comes from PRD approval — no separate review phase needed
+- PR description MUST be self-contained
+- Commit message follows conventional format: `fix({area}): {description}`

package/skills/sdlc/pack.yaml

@@ -25,8 +25,9 @@ skills:
 
   # Hotfix flow
   - hotfix-analyze
-  - hotfix-red
-  - hotfix-green
+  - hotfix-prd
+  - hotfix-implement
+  - hotfix-ship
   - hotfix-review
 
   # Diagnostics

package/skills/sdlc/prd/SKILL.md

@@ -63,7 +63,9 @@ Record results in `02-prd.md` §Grill Log.
 [PRD] [3/5] Creating PRD from grill results... ⏳
 ```
 
-Based on grill results from Step 2, create structured PRD:
+Use `/bmad-create-prd` — create structured PRD from grill results (Step 2).
+
+Ensure the output covers:
 
 1. **Goals** — business goals + success metrics
 2. **User Stories** — each MUST have acceptance criteria (Given/When/Then)
@@ -85,7 +87,7 @@ Write to `02-prd.md` §Requirements.
 
 **4a — Validate PRD:**
 
-Check the PRD for:
+Use `/bmad-validate-prd` — validate the PRD against BMAD standards:
 - Completeness — all user stories covered by FRs? All FRs traceable to a user story?
 - Clarity — any ambiguous requirements? Can each FR be implemented without guessing?
 - Testability — can each FR be verified with a test case?

package/skills/sdlc/review/SKILL.md

@@ -69,7 +69,9 @@ Write to `08-review.md` §Verification.
 [REVIEW] [3/5] Adversarial code review... ⏳
 ```
 
-Perform adversarial code review on the feature branch diff:
+Use `/bmad-code-review` — adversarial code review on the feature branch diff with parallel review layers (Blind Hunter, Edge Case Hunter, Acceptance Auditor).
+
+Ensure the review covers:
 
 1. **Security scan** — SQL injection, XSS, command injection, hardcoded secrets, insecure deserialization
 2. **Data integrity** — null dereference, resource leaks, race conditions, missing transactions

package/skills/sdlc/sdlc-health/SKILL.md

@@ -15,7 +15,7 @@ Execute ALL checks below in order, then print the summary table.
 
 ### Check 1: SDLC Skills (filesystem)
 
-Use the Read tool to check each of these 16 skill files (sdlc-health is excluded — if you're running this, it's installed). If the file exists, mark ✓. If Read returns an error, mark ✗.
+Use the Read tool to check each of these 17 skill files (sdlc-health is excluded — if you're running this, it's installed). If the file exists, mark ✓. If Read returns an error, mark ✗.
 
 ```
 .claude/skills/sdlc-init/SKILL.md
@@ -31,8 +31,9 @@ Use the Read tool to check each of these 16 skill files (sdlc-health is excluded
 .claude/skills/sdlc-feature-complete/SKILL.md
 .claude/skills/sdlc-ship/SKILL.md
 .claude/skills/sdlc-hotfix-analyze/SKILL.md
-.claude/skills/sdlc-hotfix-red/SKILL.md
-.claude/skills/sdlc-hotfix-green/SKILL.md
+.claude/skills/sdlc-hotfix-prd/SKILL.md
+.claude/skills/sdlc-hotfix-implement/SKILL.md
+.claude/skills/sdlc-hotfix-ship/SKILL.md
 .claude/skills/sdlc-hotfix-review/SKILL.md
 ```
 
@@ -137,7 +138,7 @@ After completing all checks, print this summary:
 
 | Category             | Status | Details                                 |
 |----------------------|--------|-----------------------------------------|
-| SDLC Skills (16)     |   {s}  | {deployed}/{16} deployed                |
+| SDLC Skills (17)     |   {s}  | {deployed}/{17} deployed                |
 | BMAD Skills (17)     |   {s}  | {deployed}/{17} deployed                |
 | mattpocock Skills (5)|   {s}  | {deployed}/{5} deployed                 |
 | Plugins              |   {s}  | superpowers {s}                         |
@@ -163,5 +164,5 @@ Replace `{s}` with: ✓ (pass), ✗ (required missing), ⚠ (optional missing).
 - ✗ = required missing → must fix before using SDLC
 - ⚠ = optional missing → SDLC works but some features unavailable
 
-**Required:** all 16 SDLC skills, all 17 BMAD skills, all 5 mattpocock skills, superpowers plugin, gh binary, graphify binary + skill, gitnexus MCP, .mcp.json entries
+**Required:** all 17 SDLC skills, all 17 BMAD skills, all 5 mattpocock skills, superpowers plugin, gh binary, graphify binary + skill, gitnexus MCP, .mcp.json entries
 **Optional:** docker, sonar-scanner, vsaf MCP (only for coroutine engine)

package/skills/sdlc/ship/SKILL.md

@@ -17,37 +17,17 @@ Print progress at each step in this format:
 [SHIP] [step/5] description... ✅
 ```
 
-## Flow Detection
-
-This skill supports TWO flows. Detect which one by checking the input context:
-
-| Signal | Flow | Artifact path |
-|---|---|---|
-| `.vsaf/docs/features/{name}/08-review.md` exists | **Feature flow** | `.vsaf/docs/features/{name}/` |
-| `.vsaf/docs/hotfixes/{bug-id}/02-review.md` exists | **Hotfix flow** | `.vsaf/docs/hotfixes/{bug-id}/` |
-
-Set `{artifact-dir}` to the matching path. All subsequent steps use `{artifact-dir}` instead of hardcoded paths.
-
 ## Phase Entry Protocol
 
 ```
 [SHIP] [1/5] Checking prerequisites... ⏳
 ```
 
-**Feature flow:**
 1. Input: `.vsaf/docs/features/{feature-name}/08-review.md`
 2. Check that the file exists + **check for Gate: APPROVED**
    - No Gate → Stop: "Review has not been approved"
 3. Check `.vsaf/docs/STATUS.md` — feature must be in "Knowledge Updated" status
    - If not → Stop: "Feature has not passed feature-complete. Run `/sdlc-feature-complete` first."
-
-**Hotfix flow:**
-1. Input: `.vsaf/docs/hotfixes/{bug-id}/02-review.md`
-2. Check that the file exists + **check for Gate: APPROVED**
-   - No Gate → Stop: "Hotfix review has not been approved"
-3. STATUS.md check: NOT required for hotfix (no feature-complete step)
-
-**Both flows:**
 4. Read `CONTEXT.md`
 
 ```
@@ -114,12 +94,7 @@ Generate PR description from review artifacts:
 - Create a structured PR description
 - Open PR (or suggest command if multi-repo)
 
-**Branch naming:**
-
-| Flow | Branch pattern |
-|---|---|
-| Feature | `feat/{feature-name}` |
-| Hotfix | `hotfix/{bug-id}` |
+**Branch naming:** `feat/{feature-name}`
 
 **Single repo:**
 ```bash
@@ -149,8 +124,7 @@ For each repo with code changes:
 [SHIP] [5/5] Writing ship report... ⏳
 ```
 
-**Feature flow:** Write file `{artifact-dir}/09-ship.md`
-**Hotfix flow:** Write file `{artifact-dir}/03-ship.md`
+Write file: `.vsaf/docs/features/{feature-name}/09-ship.md`
 
 ```
 [SHIP] [5/5] Writing ship report... ✅
@@ -158,10 +132,6 @@ For each repo with code changes:
 
 ## Output
 
-Write ship report to `{artifact-dir}`:
-
-**Feature flow template:**
-
 ```markdown
 # Ship Report: {feature-name}
 
@@ -192,43 +162,9 @@ After pulling the code, run:
 - `/graphify` — rebuild knowledge graph
 ```
 
-**Hotfix flow template:**
-
-```markdown
-# Ship Report: {bug-id}
-
-## PR
-- {repo}: PR #{number} — {url}
-
-## Merge Strategy
-{merge commit / squash / rebase}
-
-## Commit Scope
-- Source code: {N} files (minimal fix)
-- .vsaf/docs/: {M} files (hotfix artifacts)
-- Excluded: graphify-out/, .gitnexus/ (local index)
-
-## Final Status
-- Build: PASS
-- Tests: all GREEN (including regression test)
-- Review: APPROVED
-
-## Bug Fix Summary
-- Root cause: {from 01-analysis.md}
-- Reproduction test: {test file + test name}
-- Fix: {minimal diff description}
-
-## Post-pull Setup
-After pulling the code, run:
-- `npx -y gitnexus@latest analyze` — re-index code
-- `/graphify` — rebuild knowledge graph
-```
-
 ## Phase Exit Protocol
 
-Print PHASE REPORT (adapt to flow):
-
-**Feature flow:**
+Print PHASE REPORT:
 ```
 ═══════════════════════════════════════════
   SHIP COMPLETE: {feature-name}
@@ -240,39 +176,18 @@ Print PHASE REPORT (adapt to flow):
   Excluded: graphify-out/, .gitnexus/
   
   Phases completed: 1→2→3→4→5→6→7→8→9
-  Artifacts: {artifact-dir} (9 files)
+  Artifacts: .vsaf/docs/features/{feature-name}/ (9 files)
   
   Feature DONE.
 ═══════════════════════════════════════════
 ```
 
-**Hotfix flow:**
-```
-═══════════════════════════════════════════
-  SHIP COMPLETE: {bug-id}
-═══════════════════════════════════════════
-  Phase: Ship (hotfix final phase)
-  
-  PR: #{number} — {url}
-  Commit: source code + .vsaf/docs/ only
-  Excluded: graphify-out/, .gitnexus/
-  
-  Phases completed: Analyze → RED → GREEN → Review → Ship
-  Artifacts: {artifact-dir} (3 files)
-  
-  Hotfix DONE.
-═══════════════════════════════════════════
-```
-
-**Both flows:** Update `.vsaf/docs/STATUS.md`:
-- Feature flow → move to "Completed Features"
-- Hotfix flow → move to "Completed Hotfixes"
+Update `.vsaf/docs/STATUS.md` → move to "Completed Features".
 
 ## Rules
 
 - DO NOT review code — that is the review phase's job
-- Feature flow: only ship code that is APPROVED + knowledge UPDATED (feature-complete done)
-- Hotfix flow: only ship code that is APPROVED (no feature-complete step)
+- Only ship code that is APPROVED + knowledge UPDATED (feature-complete done)
 - PR description MUST be self-contained (reading the PR alone should be enough to understand the feature without reading artifacts)
 - **ABSOLUTELY DO NOT commit `graphify-out/` or `.gitnexus/`** — verify .gitignore first
 - **ONLY commit source code + `.vsaf/docs/`**

package/skills/sdlc/srs/SKILL.md

@@ -45,7 +45,9 @@ All output documents (05-srs.md) MUST be written in Vietnamese. Section headers,
 [SRS] [2/3] Writing SRS from PRD + ADR... ⏳
 ```
 
-Derive SRS from PRD + ADR. For each FR/NFR:
+Use `/bmad-agent-analyst` — analyze PRD + ADR to identify gaps, ambiguities, and missing requirements before writing the SRS.
+
+Derive SRS from PRD + ADR + analyst findings. For each FR/NFR:
 
 1. **Unique ID** — FR-001, NFR-001 (sequential, no gaps)
 2. **Traceability** — trace to PRD user story (US-xxx)

package/skills/sdlc/test-design/SKILL.md

@@ -37,7 +37,9 @@ You are a QA Lead. Your mission: design test cases FROM the SRS (spec), NOT from
 [TEST-DESIGN] [2/4] Generating test cases from SRS... ⏳
 ```
 
-Derive test cases from SRS FRs/NFRs. For each requirement, design ≥1 test case:
+Use `/bmad-qa-generate-e2e-tests` — generate test cases from SRS FRs/NFRs.
+
+For each requirement, ensure ≥1 test case with:
 
 1. **Unique ID** — TC-001 (sequential)
 2. **Traceability** — TC → FR/NFR → PRD user story (US-xxx)

package/skills/sdlc/workflows/hotfix-tdd.yaml

@@ -1,23 +1,18 @@
 name: hotfix-tdd
-description: "Sub-flow: TDD RED → GREEN → Test Gate — write failing test, fix, verify"
+description: "Sub-flow: Hotfix Implement (TDD) → Test Gate"
 
 nodes:
-  - id: red
-    description: "RED: write failing test that reproduces the bug"
-    command: sdlc-hotfix-red
+  - id: implement
+    description: "Implement — TDD (RED → GREEN → REFACTOR), SonarQube-in-loop"
+    command: sdlc-hotfix-implement
     depends_on: []
 
-  - id: green
-    description: "GREEN: implement minimal fix to make the test pass"
-    command: sdlc-hotfix-green
-    depends_on: [red]
-
   - id: test-gate
-    description: "Test Gate: run full test suite to verify fix and catch regressions"
+    description: "Test Gate — run full test suite"
     bash: |
       cd $WORKSPACE && npm test 2>&1
-    depends_on: [green]
+    depends_on: [implement]
     loop:
-      on_fail: green
+      on_fail: implement
       max_retries: 3
       inject_error: true