@ngocsangairvds/vsaf 3.2.14 → 3.2.16

package/tools/vds-scripts/audit_orchestrator/tests/unit/engine/test_instruction_analysis_phase122.py

@@ -1,761 +0,0 @@
-"""Tests for Phase 122 Package P122-E: Instruction-Aware Evaluation Pipeline.
-
-Covers TSK-122.19 through TSK-122.27 (FR-122.5).
-~44 tests across data models, heuristic parser, fixtures, orchestrator,
-rubric injection, compliance check, and feature flag.
-"""
-
-from __future__ import annotations
-
-import json
-import os
-from pathlib import Path
-from unittest.mock import patch
-
-import pytest
-from vds_audit_orchestrator.config import FeatureFlag
-from vds_audit_orchestrator.engine.instruction_analyzer import (
-    FAIL_CRITERIA_PATTERNS,
-    PASS_CRITERIA_PATTERNS,
-    SEARCH_FILE_PATTERNS,
-    SKIP_INFRA_PATTERNS,
-    SKIP_MANUAL_PATTERNS,
-    VALID_DIRECTIVE_TYPES,
-    VALID_TARGET_SCOPES,
-    ComplianceResult,
-    InstructionDirective,
-    InstructionPlan,
-    ScoringCriterion,
-    _instruction_text_hash,
-    _is_instruction_analysis_enabled,
-    _layer1_heuristic_parse,
-    _validate_plan,
-    analyze_instruction,
-)
-from vds_audit_orchestrator.engine.instruction_compliance import (
-    verify_instruction_compliance,
-)
-from vds_audit_orchestrator.llm.prompts.instruction_templates import (
-    InstructionMode,
-    InstructionTemplateConfig,
-    build_agentic_user_prompt,
-)
-from vds_audit_orchestrator.llm.prompts.row_evaluation import (
-    ROW_EVALUATION_USER,
-    build_instruction_rubric_block,
-)
-
-# ---------------------------------------------------------------------------
-# Paths
-# ---------------------------------------------------------------------------
-_DATA_DIR = Path(__file__).resolve().parents[3] / "data"
-_FIXTURES_PATH = _DATA_DIR / "instruction_plan_fixtures.json"
-
-
-# ===========================================================================
-# TSK-122.19: Data model tests
-# ===========================================================================
-class TestInstructionDirective:
-    """Tests for InstructionDirective data model."""
-
-    def test_valid_directive(self):
-        d = InstructionDirective(
-            directive_type="search_file",
-            target="application.yml",
-            target_scope="current_repo",
-            rationale="Check config",
-        )
-        assert d.is_valid()
-        assert d.directive_type == "search_file"
-        assert d.target == "application.yml"
-
-    def test_invalid_directive_type(self):
-        d = InstructionDirective(
-            directive_type="invalid_type",
-            target="file.txt",
-        )
-        assert not d.is_valid()
-
-    def test_invalid_target_scope(self):
-        d = InstructionDirective(
-            directive_type="search_file",
-            target="file.txt",
-            target_scope="invalid_scope",
-        )
-        assert not d.is_valid()
-
-    def test_empty_target(self):
-        d = InstructionDirective(
-            directive_type="search_file",
-            target="",
-        )
-        assert not d.is_valid()
-
-    def test_frozen(self):
-        d = InstructionDirective(directive_type="search_file", target="f.txt")
-        with pytest.raises(AttributeError):
-            d.directive_type = "other"  # type: ignore[misc]
-
-
-class TestScoringCriterion:
-    """Tests for ScoringCriterion data model."""
-
-    def test_valid_criterion(self):
-        c = ScoringCriterion(
-            criterion="datasource found",
-            verdict_if_met="PASS",
-            weight=0.8,
-            source_instruction="test",
-        )
-        assert c.is_valid()
-
-    def test_invalid_verdict(self):
-        c = ScoringCriterion(criterion="test", verdict_if_met="INVALID")
-        assert not c.is_valid()
-
-    def test_invalid_weight_too_high(self):
-        c = ScoringCriterion(criterion="test", weight=1.5)
-        assert not c.is_valid()
-
-    def test_empty_criterion(self):
-        c = ScoringCriterion(criterion="")
-        assert not c.is_valid()
-
-
-class TestInstructionPlan:
-    """Tests for InstructionPlan data model."""
-
-    def test_defaults(self):
-        plan = InstructionPlan()
-        assert plan.plan_id == ""
-        assert plan.directives == ()
-        assert plan.pass_criteria == ()
-        assert plan.fail_criteria == ()
-        assert plan.skip_decision is None
-        assert plan.confidence == 0.0
-        assert plan.analysis_source == "heuristic"
-        assert not plan.has_directives
-        assert not plan.has_scoring_criteria
-        assert not plan.should_skip
-
-    def test_with_directives(self):
-        d = InstructionDirective(directive_type="search_file", target="pom.xml")
-        plan = InstructionPlan(directives=(d,))
-        assert plan.has_directives
-        assert len(plan.valid_directives) == 1
-
-    def test_evidence_targets(self):
-        d1 = InstructionDirective(directive_type="search_file", target="pom.xml")
-        d2 = InstructionDirective(directive_type="skip_infra", target="server check")
-        plan = InstructionPlan(directives=(d1, d2))
-        targets = plan.evidence_targets
-        assert "pom.xml" in targets
-        assert "server check" not in targets  # skip directives excluded
-
-    def test_should_skip(self):
-        plan = InstructionPlan(skip_decision="infra_provided")
-        assert plan.should_skip
-
-    def test_to_dict(self):
-        plan = InstructionPlan(plan_id="test-1", requirement_key="CL-005")
-        d = plan.to_dict()
-        assert d["plan_id"] == "test-1"
-        assert d["requirement_key"] == "CL-005"
-        assert isinstance(d["directives"], tuple)
-
-
-class TestComplianceResult:
-    """Tests for ComplianceResult data model."""
-
-    def test_defaults(self):
-        cr = ComplianceResult()
-        assert cr.compliant is True
-        assert cr.violations == ()
-        assert cr.coverage_ratio == 1.0
-        assert cr.confidence_adjustment == 1.0
-
-    def test_non_compliant(self):
-        cr = ComplianceResult(
-            compliant=False,
-            violations=("missing target",),
-            coverage_ratio=0.5,
-            confidence_adjustment=0.5,
-        )
-        assert not cr.compliant
-        assert len(cr.violations) == 1
-
-    def test_to_dict(self):
-        cr = ComplianceResult(compliant=True)
-        d = cr.to_dict()
-        assert d["compliant"] is True
-
-
-# ===========================================================================
-# TSK-122.20: Layer 1 heuristic parser tests
-# ===========================================================================
-class TestLayer1HeuristicParser:
-    """Tests for _layer1_heuristic_parse Vietnamese pattern matching."""
-
-    def test_search_file_application_yml(self):
-        plan = _layer1_heuristic_parse(
-            "Kiểm tra file application.yml có cấu hình datasource đúng.",
-            requirement_key="CL-005",
-        )
-        assert plan is not None
-        assert plan.has_directives
-        assert any(d.directive_type in ("search_file", "search_config") for d in plan.directives)
-        assert plan.skip_decision is None
-
-    def test_search_file_dockerfile(self):
-        plan = _layer1_heuristic_parse(
-            "Kiểm tra file Dockerfile có tuân thủ best practices.",
-        )
-        assert plan is not None
-        assert any(d.directive_type == "search_file" for d in plan.directives)
-
-    def test_search_config_env(self):
-        plan = _layer1_heuristic_parse(
-            "Kiểm tra file .env có chứa thông tin nhạy cảm.",
-        )
-        assert plan is not None
-        assert any(d.directive_type == "search_config" for d in plan.directives)
-
-    def test_skip_infra_production_server(self):
-        plan = _layer1_heuristic_parse(
-            "Kiểm tra trực tiếp trên hệ thống production xem service có hoạt động.",
-        )
-        assert plan is not None
-        assert plan.skip_decision == "infra_provided"
-        assert any(d.directive_type == "skip_infra" for d in plan.directives)
-
-    def test_skip_infra_ssh(self):
-        plan = _layer1_heuristic_parse(
-            "SSH vào server production để kiểm tra log ứng dụng.",
-        )
-        assert plan is not None
-        assert plan.skip_decision == "infra_provided"
-
-    def test_skip_manual_interview(self):
-        plan = _layer1_heuristic_parse(
-            "Phỏng vấn đội phát triển về quy trình code review hiện tại.",
-        )
-        assert plan is not None
-        assert plan.skip_decision == "manual_required"
-        assert any(d.directive_type == "skip_manual" for d in plan.directives)
-
-    def test_skip_manual_verification(self):
-        plan = _layer1_heuristic_parse(
-            "Kiểm tra thủ công hồ sơ đào tạo bảo mật của nhân viên.",
-        )
-        assert plan is not None
-        assert plan.skip_decision == "manual_required"
-
-    def test_verify_absence(self):
-        plan = _layer1_heuristic_parse(
-            "Đảm bảo không có hardcoded password trong source code.",
-        )
-        assert plan is not None
-        assert any(d.directive_type == "verify_absence" for d in plan.directives)
-
-    def test_code_pattern_annotation(self):
-        plan = _layer1_heuristic_parse(
-            "Kiểm tra xem có sử dụng @Transactional annotation trong service layer.",
-        )
-        assert plan is not None
-        assert any(d.directive_type == "search_code_pattern" for d in plan.directives)
-
-    def test_api_check(self):
-        plan = _layer1_heuristic_parse(
-            "Kiểm tra api /health endpoint có trả về status 200.",
-        )
-        assert plan is not None
-        assert any(d.directive_type == "check_api" for d in plan.directives)
-
-    def test_pass_criteria_extraction(self):
-        plan = _layer1_heuristic_parse(
-            "Yêu cầu: phải có unit test cho các service chính.",
-        )
-        assert plan is not None
-        assert len(plan.pass_criteria) > 0
-
-    def test_fail_criteria_extraction(self):
-        plan = _layer1_heuristic_parse(
-            "Không đạt nếu coverage dưới 60%.",
-        )
-        assert plan is not None
-        assert len(plan.fail_criteria) > 0
-
-    def test_empty_input_returns_none(self):
-        assert _layer1_heuristic_parse("") is None
-        assert _layer1_heuristic_parse("   ") is None
-
-    def test_ambiguous_input_returns_none(self):
-        # Generic text with no Vietnamese patterns should return None
-        plan = _layer1_heuristic_parse("This is a generic English sentence with no patterns.")
-        assert plan is None
-
-    def test_plan_has_correct_source(self):
-        plan = _layer1_heuristic_parse(
-            "Kiểm tra file pom.xml có dependency management đúng.",
-        )
-        assert plan is not None
-        assert plan.analysis_source == "heuristic"
-        assert plan.plan_id.startswith("heur-")
-
-
-# ===========================================================================
-# TSK-122.21: Instruction plan fixtures tests
-# ===========================================================================
-class TestInstructionPlanFixtures:
-    """Tests for instruction_plan_fixtures.json."""
-
-    @pytest.fixture()
-    def fixtures(self):
-        assert _FIXTURES_PATH.exists(), f"Fixtures file not found: {_FIXTURES_PATH}"
-        with open(_FIXTURES_PATH) as f:
-            return json.load(f)
-
-    def test_fixture_file_structure(self, fixtures):
-        assert "version" in fixtures
-        assert "fixtures" in fixtures
-        assert len(fixtures["fixtures"]) >= 10
-
-    def test_all_fixtures_have_required_fields(self, fixtures):
-        for fix in fixtures["fixtures"]:
-            assert "id" in fix
-            assert "instruction_text" in fix
-            assert "expected" in fix
-            assert "requirement_key" in fix
-
-    def test_fixtures_cover_skip_decisions(self, fixtures):
-        skip_decisions = {fix["expected"].get("skip_decision") for fix in fixtures["fixtures"]}
-        assert None in skip_decisions  # non-skip fixtures
-        assert "manual_required" in skip_decisions
-        assert "infra_provided" in skip_decisions
-
-    def test_layer1_matches_fixture_expectations(self, fixtures):
-        """Verify Layer 1 heuristic produces results matching fixture expectations."""
-        for fix in fixtures["fixtures"]:
-            plan = _layer1_heuristic_parse(
-                fix["instruction_text"],
-                requirement_key=fix.get("requirement_key", ""),
-            )
-            expected = fix["expected"]
-
-            if expected.get("has_directives"):
-                assert plan is not None, f"Fixture {fix['id']}: expected directives but got None"
-                assert plan.has_directives, f"Fixture {fix['id']}: expected has_directives=True"
-
-            if expected.get("skip_decision") is not None:
-                assert plan is not None, f"Fixture {fix['id']}: expected skip but got None"
-                assert plan.skip_decision == expected["skip_decision"], (
-                    f"Fixture {fix['id']}: expected skip={expected['skip_decision']}, got skip={plan.skip_decision}"
-                )
-
-            if plan is not None and expected.get("confidence_min"):
-                assert plan.confidence >= expected["confidence_min"], (
-                    f"Fixture {fix['id']}: confidence {plan.confidence} < {expected['confidence_min']}"
-                )
-
-
-# ===========================================================================
-# TSK-122.23: analyze_instruction() orchestrator tests
-# ===========================================================================
-class TestAnalyzeInstruction:
-    """Tests for analyze_instruction() two-layer orchestrator."""
-
-    def test_returns_plan_for_file_instruction(self):
-        plan = analyze_instruction(
-            "Kiểm tra file application.yml có cấu hình datasource.",
-            requirement_key="CL-005",
-        )
-        assert plan is not None
-        assert plan.has_directives
-
-    def test_returns_plan_for_skip_instruction(self):
-        plan = analyze_instruction(
-            "Phỏng vấn đội phát triển về quy trình code review.",
-            requirement_key="CL-019",
-        )
-        assert plan is not None
-        assert plan.should_skip
-        assert plan.skip_decision == "manual_required"
-
-    def test_returns_none_for_empty_input(self):
-        assert analyze_instruction("") is None
-        assert analyze_instruction("   ") is None
-
-    def test_disabled_returns_none(self):
-        with patch.dict(os.environ, {"VDS_AUDIT_INSTRUCTION_ANALYSIS_ENABLED": "false"}):
-            plan = analyze_instruction(
-                "Kiểm tra file application.yml có cấu hình datasource.",
-            )
-            assert plan is None
-
-    def test_validates_plan(self):
-        """analyze_instruction should drop invalid directives."""
-        plan = analyze_instruction(
-            "Kiểm tra file pom.xml có dependency management đúng.",
-        )
-        if plan is not None:
-            for d in plan.directives:
-                assert d.is_valid()
-
-    def test_plan_has_raw_instruction(self):
-        text = "Kiểm tra file Dockerfile có tuân thủ best practices."
-        plan = analyze_instruction(text)
-        assert plan is not None
-        assert plan.raw_instruction == text
-
-
-# ===========================================================================
-# TSK-122.23: _validate_plan tests
-# ===========================================================================
-class TestValidatePlan:
-    """Tests for _validate_plan sanitization."""
-
-    def test_drops_invalid_directives(self):
-        plan = InstructionPlan(
-            plan_id="test",
-            directives=(
-                InstructionDirective(directive_type="search_file", target="pom.xml"),
-                InstructionDirective(directive_type="INVALID", target="bad"),
-            ),
-        )
-        validated = _validate_plan(plan)
-        assert len(validated.directives) == 1
-        assert validated.directives[0].directive_type == "search_file"
-
-    def test_drops_invalid_criteria(self):
-        plan = InstructionPlan(
-            plan_id="test",
-            pass_criteria=(
-                ScoringCriterion(criterion="valid", verdict_if_met="PASS"),
-                ScoringCriterion(criterion="", verdict_if_met="PASS"),  # invalid
-            ),
-        )
-        validated = _validate_plan(plan)
-        assert len(validated.pass_criteria) == 1
-
-    def test_preserves_valid_plan(self):
-        d = InstructionDirective(directive_type="search_file", target="pom.xml")
-        c = ScoringCriterion(criterion="found", verdict_if_met="PASS")
-        plan = InstructionPlan(
-            plan_id="test",
-            directives=(d,),
-            pass_criteria=(c,),
-            confidence=0.9,
-        )
-        validated = _validate_plan(plan)
-        assert len(validated.directives) == 1
-        assert len(validated.pass_criteria) == 1
-        assert validated.confidence == 0.9
-
-
-# ===========================================================================
-# TSK-122.25: INSTRUCTION_RUBRIC_BLOCK tests
-# ===========================================================================
-class TestInstructionRubricBlock:
-    """Tests for build_instruction_rubric_block prompt injection."""
-
-    def test_returns_empty_for_none(self):
-        assert build_instruction_rubric_block(None) == ""
-
-    def test_returns_empty_for_no_criteria(self):
-        plan = InstructionPlan(plan_id="test")
-        assert build_instruction_rubric_block(plan) == ""
-
-    def test_includes_pass_criteria(self):
-        plan = InstructionPlan(
-            pass_criteria=(ScoringCriterion(criterion="datasource found", verdict_if_met="PASS"),),
-            raw_instruction="test instruction",
-        )
-        block = build_instruction_rubric_block(plan)
-        assert "Tiêu chí ĐẠT" in block
-        assert "datasource found" in block
-
-    def test_includes_fail_criteria(self):
-        plan = InstructionPlan(
-            fail_criteria=(ScoringCriterion(criterion="missing config", verdict_if_met="FAIL"),),
-            raw_instruction="test instruction",
-        )
-        block = build_instruction_rubric_block(plan)
-        assert "Tiêu chí KHÔNG ĐẠT" in block
-        assert "missing config" in block
-
-    def test_includes_raw_instruction(self):
-        plan = InstructionPlan(
-            pass_criteria=(ScoringCriterion(criterion="test"),),
-            raw_instruction="Kiểm tra file application.yml",
-        )
-        block = build_instruction_rubric_block(plan)
-        assert "Kiểm tra file application.yml" in block
-
-    def test_accepts_serialized_instruction_plan_dict(self):
-        block = build_instruction_rubric_block(
-            {
-                "pass_criteria": [{"criterion": "datasource found", "weight": 0.8}],
-                "raw_instruction": "Kiểm tra datasource",
-            }
-        )
-        assert "datasource found" in block
-        assert "Kiểm tra datasource" in block
-
-    def test_row_prompt_formats_with_instruction_rubric(self):
-        rendered = ROW_EVALUATION_USER.format(
-            row_id="row-1",
-            category="Security",
-            requirement_text="Check datasource config",
-            requirement_guidance="Use config files",
-            instruction_rubric="[RUBRIC BLOCK]",
-            requirement_interpretation="{}",
-            evidence_context="seed evidence",
-            evidence_ref_count=1,
-            evidence_refs="- pom.xml",
-        )
-        assert "[RUBRIC BLOCK]" in rendered
-
-    def test_agentic_prompt_includes_instruction_rubric(self):
-        rendered = build_agentic_user_prompt(
-            row_id="row-1",
-            category="Security",
-            requirement_text="Check datasource config",
-            requirement_guidance="Use config files",
-            requirement_interpretation="{}",
-            instruction_rubric="[RUBRIC BLOCK]",
-            evidence_context="seed evidence",
-            evidence_refs=["pom.xml"],
-            config=InstructionTemplateConfig(mode=InstructionMode.MINIMAL),
-        )
-        assert "[RUBRIC BLOCK]" in rendered
-
-
-# ===========================================================================
-# TSK-122.26: verify_instruction_compliance tests
-# ===========================================================================
-class TestVerifyInstructionCompliance:
-    """Tests for post-evaluation compliance check."""
-
-    def test_no_plan_returns_compliant(self):
-        plan = InstructionPlan()
-        result = verify_instruction_compliance(plan, {})
-        assert result.compliant
-        assert result.confidence_adjustment == 1.0
-
-    def test_all_targets_searched(self):
-        plan = InstructionPlan(
-            directives=(
-                InstructionDirective(
-                    directive_type="search_file",
-                    target="pom.xml",
-                ),
-            ),
-        )
-        trace = {"searched_files": ["pom.xml"]}
-        result = verify_instruction_compliance(plan, trace)
-        assert result.compliant
-        assert result.coverage_ratio == 1.0
-
-    def test_missing_target_reduces_coverage(self):
-        plan = InstructionPlan(
-            directives=(
-                InstructionDirective(
-                    directive_type="search_file",
-                    target="pom.xml",
-                ),
-                InstructionDirective(
-                    directive_type="search_config",
-                    target="application.yml",
-                ),
-            ),
-        )
-        trace = {"searched_files": ["pom.xml"]}
-        result = verify_instruction_compliance(plan, trace)
-        assert not result.compliant
-        assert result.coverage_ratio == 0.5
-        assert result.confidence_adjustment < 1.0
-
-    def test_skip_directives_always_covered(self):
-        plan = InstructionPlan(
-            directives=(
-                InstructionDirective(
-                    directive_type="skip_infra",
-                    target="server check",
-                ),
-            ),
-        )
-        result = verify_instruction_compliance(plan, {})
-        assert result.compliant
-        assert result.coverage_ratio == 1.0
-
-    def test_confidence_floor(self):
-        """Confidence adjustment should not go below 0.5 (DD-122.13)."""
-        plan = InstructionPlan(
-            directives=(
-                InstructionDirective(directive_type="search_file", target="a.txt"),
-                InstructionDirective(directive_type="search_file", target="b.txt"),
-                InstructionDirective(directive_type="search_file", target="c.txt"),
-                InstructionDirective(directive_type="search_file", target="d.txt"),
-            ),
-        )
-        result = verify_instruction_compliance(plan, {})
-        assert result.confidence_adjustment >= 0.5
-
-    def test_tool_calls_used_as_evidence(self):
-        plan = InstructionPlan(
-            directives=(
-                InstructionDirective(
-                    directive_type="search_file",
-                    target="pom.xml",
-                ),
-            ),
-        )
-        trace = {"tool_calls_used": [{"target": "pom.xml"}]}
-        result = verify_instruction_compliance(plan, trace)
-        assert result.compliant
-
-    def test_fail_verdict_without_failure_findings_reduces_alignment(self):
-        plan = InstructionPlan(
-            directives=(InstructionDirective(directive_type="search_file", target="application.yml"),),
-            pass_criteria=(ScoringCriterion(criterion="datasource found", verdict_if_met="PASS", weight=1.0),),
-        )
-        result = verify_instruction_compliance(
-            plan,
-            {},
-            evaluation_result={
-                "status": "FAIL",
-                "score": 20.0,
-                "reason": "Có bằng chứng cấu hình datasource phù hợp.",
-                "finding": "Đã tìm thấy datasource và cấu hình hợp lệ.",
-                "reasoning": "Tệp cấu hình tồn tại và không thấy lỗi.",
-            },
-        )
-        assert not result.compliant
-        assert result.coverage_ratio < 1.0
-
-    def test_pass_verdict_without_supporting_findings_reduces_alignment(self):
-        plan = InstructionPlan(
-            directives=(InstructionDirective(directive_type="search_file", target="application.yml"),),
-            fail_criteria=(ScoringCriterion(criterion="hardcoded password", verdict_if_met="FAIL", weight=1.0),),
-        )
-        result = verify_instruction_compliance(
-            plan,
-            {},
-            evaluation_result={
-                "status": "PASS",
-                "score": 95.0,
-                "reason": "Thiếu bằng chứng khẳng định PASS.",
-                "finding": "Chưa thấy phát hiện cụ thể xác nhận trạng thái đạt hoặc cấu hình hiện diện.",
-                "reasoning": "Không có kết quả cụ thể xác nhận pass hoặc trạng thái được cấu hình.",
-            },
-        )
-        assert not result.compliant
-        assert result.coverage_ratio < 1.0
-
-
-# ===========================================================================
-# TSK-122.23: Feature flag tests
-# ===========================================================================
-class TestInstructionAnalysisFeatureFlag:
-    """Tests for INSTRUCTION_ANALYSIS_ENABLED feature flag."""
-
-    def test_flag_exists_in_enum(self):
-        assert hasattr(FeatureFlag, "INSTRUCTION_ANALYSIS_ENABLED")
-        assert FeatureFlag.INSTRUCTION_ANALYSIS_ENABLED == "instruction_analysis_enabled"
-
-    def test_features_config_default_true(self):
-        from vds_audit_orchestrator.config import FeaturesConfig
-
-        assert FeaturesConfig().instruction_analysis_enabled is True
-
-    def test_env_enable(self):
-        with patch.dict(os.environ, {"VDS_AUDIT_INSTRUCTION_ANALYSIS_ENABLED": "true"}):
-            assert _is_instruction_analysis_enabled()
-
-    def test_env_disable(self):
-        with patch.dict(os.environ, {"VDS_AUDIT_INSTRUCTION_ANALYSIS_ENABLED": "false"}):
-            assert not _is_instruction_analysis_enabled()
-
-    def test_default_enabled(self):
-        with patch.dict(os.environ, {}, clear=False):
-            env_key = "VDS_AUDIT_INSTRUCTION_ANALYSIS_ENABLED"
-            old = os.environ.pop(env_key, None)
-            try:
-                assert _is_instruction_analysis_enabled()
-            finally:
-                if old is not None:
-                    os.environ[env_key] = old
-
-
-# ===========================================================================
-# TSK-122.19: Pattern dict structure tests
-# ===========================================================================
-class TestPatternDicts:
-    """Tests for Vietnamese pattern dictionaries."""
-
-    def test_search_file_patterns_non_empty(self):
-        assert len(SEARCH_FILE_PATTERNS) >= 5
-
-    def test_skip_infra_patterns_non_empty(self):
-        assert len(SKIP_INFRA_PATTERNS) >= 5
-
-    def test_skip_manual_patterns_non_empty(self):
-        assert len(SKIP_MANUAL_PATTERNS) >= 5
-
-    def test_pass_criteria_patterns_non_empty(self):
-        assert len(PASS_CRITERIA_PATTERNS) >= 3
-
-    def test_fail_criteria_patterns_non_empty(self):
-        assert len(FAIL_CRITERIA_PATTERNS) >= 3
-
-    def test_valid_directive_types_complete(self):
-        expected = {
-            "search_file",
-            "search_config",
-            "search_code_pattern",
-            "verify_absence",
-            "skip_infra",
-            "skip_manual",
-            "check_api",
-        }
-        assert expected == VALID_DIRECTIVE_TYPES
-
-    def test_valid_target_scopes_complete(self):
-        expected = {"current_repo", "config_repo", "project_wide"}
-        assert expected == VALID_TARGET_SCOPES
-
-
-# ===========================================================================
-# Utility tests
-# ===========================================================================
-class TestUtilities:
-    """Tests for utility functions."""
-
-    def test_instruction_text_hash_stable(self):
-        h1 = _instruction_text_hash("test instruction")
-        h2 = _instruction_text_hash("test instruction")
-        assert h1 == h2
-
-    def test_instruction_text_hash_case_insensitive(self):
-        h1 = _instruction_text_hash("Test Instruction")
-        h2 = _instruction_text_hash("test instruction")
-        assert h1 == h2
-
-    def test_instruction_text_hash_strips_whitespace(self):
-        h1 = _instruction_text_hash("  test  ")
-        h2 = _instruction_text_hash("test")
-        assert h1 == h2
-
-    def test_layer2_fallback_returns_plan_for_file_like_instruction(self):
-        from vds_audit_orchestrator.engine.instruction_analyzer import _layer2_llm_decompose
-
-        plan = _layer2_llm_decompose(
-            "Review application-prod.yml to ensure datasource is not hardcoded",
-            requirement_key="CL-005",
-            repo_type="backend",
-            tech_stack_summary="spring boot",
-        )
-        assert plan is not None
-        assert plan.analysis_source == "llm_fallback"
-        assert plan.confidence >= 0.6
-        assert any(d.directive_type in {"search_file", "search_config", "verify_absence"} for d in plan.directives)